From unknown Sat Aug 16 10:47:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79178 <79178@debbugs.gnu.org> To: bug#79178 <79178@debbugs.gnu.org> Subject: Status: [Improvement] Allow auto-insert to have functions as conditions Reply-To: bug#79178 <79178@debbugs.gnu.org> Date: Sat, 16 Aug 2025 17:47:37 +0000 retitle 79178 [Improvement] Allow auto-insert to have functions as conditio= ns reassign 79178 emacs submitter 79178 Mattias severity 79178 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 05 12:17:24 2025 Received: (at submit) by debbugs.gnu.org; 5 Aug 2025 16:17:25 +0000 Received: from localhost ([127.0.0.1]:56788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ujKLs-0000tu-HG for submit@debbugs.gnu.org; Tue, 05 Aug 2025 12:17:24 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59646) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ujKLo-0000tK-PG for submit@debbugs.gnu.org; Tue, 05 Aug 2025 12:17:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujKLX-0006wA-D7 for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2025 12:17:03 -0400 Received: from smtp6-g21.free.fr ([2a01:e0c:1:1599::15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujKLU-0001lu-V2 for bug-gnu-emacs@gnu.org; Tue, 05 Aug 2025 12:17:03 -0400 Received: from [IPV6:2a01:e34:ec0b:4930:c19e:af58:6226:bace] (unknown [IPv6:2a01:e34:ec0b:4930:c19e:af58:6226:bace]) (Authenticated sender: mattias.roux@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 76013780513 for ; Tue, 5 Aug 2025 18:16:48 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------73Xztc0KU66vNQj7HiMzAP04" Message-ID: <2b5f436a-8f0d-443c-829a-b98e98018b5a@kojin.tech> Date: Tue, 5 Aug 2025 18:16:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: bug-gnu-emacs@gnu.org Subject: [Improvement] Allow auto-insert to have functions as conditions Content-Language: en-US From: Mattias Received-SPF: permerror client-ip=2a01:e0c:1:1599::15; envelope-from=mattias@kojin.tech; helo=smtp6-g21.free.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------73Xztc0KU66vNQj7HiMzAP04 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit --text follows this line-- Hi everyone, First contribution to emacs. This comes from the fact that I have a custom function that overrides auto-insert to fit my needs and I realised it was not a big change and could be merged into emacs directly. This small patch aims to allow any function acting as a predicate with no arguments to be used as a condition in auto-insert-alist --------------73Xztc0KU66vNQj7HiMzAP04 Content-Type: text/x-patch; charset=UTF-8; name="0001-Autoinsert-Allow-condition-to-be-a-function.patch" Content-Disposition: attachment; filename="0001-Autoinsert-Allow-condition-to-be-a-function.patch" Content-Transfer-Encoding: base64 RnJvbSAzN2Q2NDgxODVmNDYyOGMwMWQ0ZTkzYzkyNGRlNTFmMzhlYTQ3MTI2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBtYXR0aWFzZHJwIDxtYXR0aWFzQGtvamluLnRlY2g+ CkRhdGU6IFR1ZSwgNSBBdWcgMjAyNSAxODoxMTo1OCArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IEF1dG9pbnNlcnQ6IEFsbG93IGNvbmRpdGlvbiB0byBiZSBhIGZ1bmN0aW9uCgpDdXJyZW50 bHkgYSBjb25kaXRpb24gY2FuIG9ubHkgYmUgYSByZWdleHAgb3IgYSBtYWpvci1tb2RlIHN5 bWJvbCBidXQKdGhlcmUncyBubyByZWFsIHJlYXNvbiB0byBub3QgYWxsb3cgYW55IHByZWRp Y2F0ZSBhcyBhIGNvbmRpdGlvbgotLS0KIGxpc3AvYXV0b2luc2VydC5lbCB8IDI4ICsrKysr KysrKysrKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvYXV0b2luc2VydC5lbCBi L2xpc3AvYXV0b2luc2VydC5lbAppbmRleCBlNzQ5MmQxYjllZC4uZjk3YmVmN2M1NzUgMTAw NjQ0Ci0tLSBhL2xpc3AvYXV0b2luc2VydC5lbAorKysgYi9saXNwL2F1dG9pbnNlcnQuZWwK QEAgLTMyMyw4ICszMjMsOSBAQCBUaGUgZG9jdW1lbnQgd2FzIHR5cGVzZXQgd2l0aAogIikp CiAgICJBIGxpc3Qgc3BlY2lmeWluZyB0ZXh0IHRvIGluc2VydCBieSBkZWZhdWx0IGludG8g YSBuZXcgZmlsZS4KIEVsZW1lbnRzIGxvb2sgbGlrZSAoQ09ORElUSU9OIC4gQUNUSU9OKSBv ciAoKENPTkRJVElPTiAuIERFU0NSSVBUSU9OKSAuIEFDVElPTikuCi1DT05ESVRJT04gbWF5 IGJlIGEgcmVnZXhwIHRoYXQgbXVzdCBtYXRjaCB0aGUgbmV3IGZpbGUncyBuYW1lLCBvciBp dCBtYXkgYmUKLWEgc3ltYm9sIHRoYXQgbXVzdCBtYXRjaCB0aGUgbWFqb3IgbW9kZSBmb3Ig dGhpcyBlbGVtZW50IHRvIGFwcGx5LgorQ09ORElUSU9OIG1heSBiZSBhIHJlZ2V4cCB0aGF0 IG11c3QgbWF0Y2ggdGhlIG5ldyBmaWxlJ3MgbmFtZSwgYSBzeW1ib2wgdGhhdAorbXVzdCBt YXRjaCB0aGUgbWFqb3IgbW9kZSBmb3IgdGhpcyBlbGVtZW50IHRvIGFwcGx5IG9yIGEgY3Vz dG9tIHByZWRpY2F0ZSB0aGF0Cit0YWtlcyBubyBhcmd1bWVudC4KIE9ubHkgdGhlIGZpcnN0 IG1hdGNoaW5nIGVsZW1lbnQgaXMgZWZmZWN0aXZlLgogT3B0aW9uYWwgREVTQ1JJUFRJT04g aXMgYSBzdHJpbmcgZm9yIGZpbGxpbmcgYGF1dG8taW5zZXJ0LXByb21wdCcuCiBBQ1RJT04g bWF5IGJlIGEgc2tlbGV0b24gdG8gaW5zZXJ0IChzZWUgYHNrZWxldG9uLWluc2VydCcpLCBh biBhYnNvbHV0ZQpAQCAtMzY4LDEyICszNjksMjUgQEAgTWF0Y2hlcyB0aGUgdmlzaXRlZCBm aWxlIG5hbWUgYWdhaW5zdCB0aGUgZWxlbWVudHMgb2YgYGF1dG8taW5zZXJ0LWFsaXN0Jy4i CiAgICAgICAgICAgICAgICAgKHBjYXNlLWxhbWJkYSAoYCgsY29uZCAuICxhY3Rpb24pKQog ICAgICAgICAgICAgICAgICAgKGlmIChhdG9tIGNvbmQpCiAgICAgICAgICAgICAgICAgICAg ICAgKHNldHEgZGVzYyBjb25kKQotICAgICAgICAgICAgICAgICAgICAoc2V0cSBkZXNjIChj ZHIgY29uZCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgY29uZCAoY2FyIGNvbmQpKSkK LSAgICAgICAgICAgICAgICAgICh3aGVuIChpZiAoc3ltYm9scCBjb25kKQotICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChkZXJpdmVkLW1vZGUtcCBjb25kKQorICAgICAgICAgICAg ICAgICAgICA7OyBpZiBgY29uZCcgaXMgYSBsYW1iZGEsIGRvbid0IHNwbGl0IGl0IGJ1dCBz ZXQgYGRlc2MnIHRvIGEgY3VzdG9tIHN0cmluZworICAgICAgICAgICAgICAgICAgICAoaWYg KGFuZCAobm90IChzeW1ib2xwIGNvbmQpKSAoZnVuY3Rpb25wIGNvbmQpKQorICAgICAgICAg ICAgICAgICAgICAgICAgKHNldHEgZGVzYyAiYGxhbWJkYSBjb25kaXRpb24nIikKKyAgICAg ICAgICAgICAgICAgICAgICAoc2V0cSBkZXNjIChjZHIgY29uZCkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjb25kIChjYXIgY29uZCkpKSkKKyAgICAgICAgICAgICAgICAgICh3 aGVuIChjb25kCisgICAgICAgICAgICAgICAgICAgICAgICAgOzsgY29uZCBzaG91bGQgYmUg YSBtYWpvci1tb2RlIHZhcmlhYmxlCisgICAgICAgICAgICAgICAgICAgICAgICAgKChhbmQg KHN5bWJvbHAgY29uZCkgKG5vdCAoZnVuY3Rpb25wIGNvbmQpKSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgKGRlcml2ZWQtbW9kZS1wIGNvbmQpKQorCisgICAgICAgICAgICAgICAg ICAgICAgICAgOzsgY29uZCBzaG91bGQgYmUgYSBwcmVkaWNhdGUgdGhhdCB0YWtlcyBubyBh cmd1bWVudAorICAgICAgICAgICAgICAgICAgICAgICAgIDs7IEl0IGNhbiBlaXRoZXIgYmUg YSBuYW1lZCBmdW5jdGlvbiBvciBhIGxhbWJkYQorICAgICAgICAgICAgICAgICAgICAgICAg ICgoZnVuY3Rpb25wIGNvbmQpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChmdW5jYWxs IGNvbmQpKQorCisgICAgICAgICAgICAgICAgICAgICAgICAgOzsgY29uZCBzaG91bGQgYmUg YSByZWdleHAKKyAgICAgICAgICAgICAgICAgICAgICAgICAodAogICAgICAgICAgICAgICAg ICAgICAgICAgICAoYW5kIGJ1ZmZlci1maWxlLW5hbWUKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoc3RyaW5nLW1hdGNoIGNvbmQgYnVmZmVyLWZpbGUtbmFtZSkpKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctbWF0Y2ggY29uZCBidWZmZXIt ZmlsZS1uYW1lKSkpKQogICAgICAgICAgICAgICAgICAgICBhY3Rpb24pKQogICAgICAgICAg ICAgICAgIGF1dG8taW5zZXJ0LWFsaXN0KSkpCiAgICAgICAgICAoZ290by1jaGFyIDEpCi0t IAoyLjUwLjEKCg== --------------73Xztc0KU66vNQj7HiMzAP04-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 06 07:33:22 2025 Received: (at 79178) by debbugs.gnu.org; 6 Aug 2025 11:33:22 +0000 Received: from localhost ([127.0.0.1]:58260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ujcOY-0007Xh-43 for submit@debbugs.gnu.org; Wed, 06 Aug 2025 07:33:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46490) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ujcOU-0007XU-Mg for 79178@debbugs.gnu.org; Wed, 06 Aug 2025 07:33:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujcOL-0000Dt-QE; Wed, 06 Aug 2025 07:33:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OdURfhUMI3+hXkG3JyocVpyW+VFP9i2L0ydRqmAVs6g=; b=B1/ihrBbuxW1 uOXPEeAxuFyCV8a35DnO8vrJc9qcJWBacWvZslSqHLcokLCw3cLTkJlJnG/Nb+fp3NaGTIJdMncED +xNnxFcXRJCwox00k5WWyM4Pu453tNEx2nkBd9raDSICkzvWalKjPrYza3wFIuMbZF3Cjn/ft6GEL Xhp/5dhwOj/xKm4+WCyFNZUChGyThBdS6IOyNaJb6zQ2sakEZ+CE/2dF+8IHSDqoETb5h1nbDK4cP VECo/e57H7jzCFUbxKqsE1J/Z3hKrbHZGyWLYgnsBaWFKuKEc0kkR1sablBe1HNWT1FXTmXwLnRys NRlTfn82oC7j9CE+79PvyQ==; Date: Wed, 06 Aug 2025 14:33:07 +0300 Message-Id: <86o6ssu1l8.fsf@gnu.org> From: Eli Zaretskii To: Mattias In-Reply-To: <2b5f436a-8f0d-443c-829a-b98e98018b5a@kojin.tech> (message from Mattias on Tue, 5 Aug 2025 18:16:48 +0200) Subject: Re: bug#79178: [Improvement] Allow auto-insert to have functions as conditions References: <2b5f436a-8f0d-443c-829a-b98e98018b5a@kojin.tech> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79178 Cc: 79178@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 5 Aug 2025 18:16:48 +0200 > From: Mattias > > First contribution to emacs. This comes from the fact that I have a > custom function that overrides auto-insert to fit my needs and I > realised it was not a big change and could be merged into emacs directly. > > This small patch aims to allow any function acting as a predicate with > no arguments to be used as a condition in auto-insert-alist Thanks. Changes like this one should be called out in NEWS. In addition, auto-insert is described in a manual (see doc/misc/autotype.texi), which should be updated due to this change. > Currently a condition can only be a regexp or a major-mode symbol but > there's no real reason to not allow any predicate as a condition This log message is incomplete: it lacks the record of the file and the functions/variables which are modified by the patch. See "git log" for examples of how we format commit log messages. > +CONDITION may be a regexp that must match the new file's name, a symbol that > +must match the major mode for this element to apply or a custom predicate that > +takes no argument. This addition makes the sentence too long and hard to read and grasp. Suggest to break it in two: CONDITION may be a regexp that must match the new file's name, or a symbol that must match the major mode for this element to apply. CONDITION could also be a predicate function of no arguments; Emacs will insert the text if the predicate function returns non-nil, > + ;; if `cond' is a lambda, don't split it but set `desc' to a custom string > + (if (and (not (symbolp cond)) (functionp cond)) > + (setq desc "`lambda condition'") > + (setq desc (cdr cond) > + cond (car cond)))) > + (when (cond > + ;; cond should be a major-mode variable > + ((and (symbolp cond) (not (functionp cond))) > + (derived-mode-p cond)) > + > + ;; cond should be a predicate that takes no argument > + ;; It can either be a named function or a lambda > + ((functionp cond) > + (funcall cond)) > + > + ;; cond should be a regexp Please be consistent, and quote 'cond' in all of these comments. P.S. Since the number of the bug is now known, please mention the bug number in the commit log message when you submit the updated patch. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 06 10:46:34 2025 Received: (at 79178) by debbugs.gnu.org; 6 Aug 2025 14:46:34 +0000 Received: from localhost ([127.0.0.1]:59670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ujfPV-00035H-Cz for submit@debbugs.gnu.org; Wed, 06 Aug 2025 10:46:34 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:4130) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ujfPQ-000353-OJ for 79178@debbugs.gnu.org; Wed, 06 Aug 2025 10:46:32 -0400 Received: from [IPV6:2a01:e34:ec0b:4930:c19e:af58:6226:bace] (unknown [IPv6:2a01:e34:ec0b:4930:c19e:af58:6226:bace]) (Authenticated sender: mattias.roux@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id D3292780368; Wed, 6 Aug 2025 16:46:25 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------ktKHm9J4euFDeklm1PGkS0XE" Message-ID: <49652288-2df8-486c-bc8c-41fa74bd6891@kojin.tech> Date: Wed, 6 Aug 2025 16:46:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#79178: [Improvement] Allow auto-insert to have functions as conditions To: Eli Zaretskii References: <2b5f436a-8f0d-443c-829a-b98e98018b5a@kojin.tech> <86o6ssu1l8.fsf@gnu.org> Content-Language: en-US From: Mattias In-Reply-To: <86o6ssu1l8.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 79178 Cc: 79178@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------ktKHm9J4euFDeklm1PGkS0XE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Eli, Thanks for the review! I think I did everything you asked, let me know if there's something missing or not done properly ;-) Mattias Le 06/08/2025 à 13:33, Eli Zaretskii a écrit : >> Date: Tue, 5 Aug 2025 18:16:48 +0200 >> From: Mattias >> >> First contribution to emacs. This comes from the fact that I have a >> custom function that overrides auto-insert to fit my needs and I >> realised it was not a big change and could be merged into emacs directly. >> >> This small patch aims to allow any function acting as a predicate with >> no arguments to be used as a condition in auto-insert-alist > Thanks. Changes like this one should be called out in NEWS. In > addition, auto-insert is described in a manual (see > doc/misc/autotype.texi), which should be updated due to this change. > >> Currently a condition can only be a regexp or a major-mode symbol but >> there's no real reason to not allow any predicate as a condition > This log message is incomplete: it lacks the record of the file and > the functions/variables which are modified by the patch. See "git > log" for examples of how we format commit log messages. > >> +CONDITION may be a regexp that must match the new file's name, a symbol that >> +must match the major mode for this element to apply or a custom predicate that >> +takes no argument. > This addition makes the sentence too long and hard to read and grasp. > Suggest to break it in two: > > CONDITION may be a regexp that must match the new file's name, or > a symbol that must match the major mode for this element to apply. > CONDITION could also be a predicate function of no arguments; Emacs > will insert the text if the predicate function returns non-nil, > >> + ;; if `cond' is a lambda, don't split it but set `desc' to a custom string >> + (if (and (not (symbolp cond)) (functionp cond)) >> + (setq desc "`lambda condition'") >> + (setq desc (cdr cond) >> + cond (car cond)))) >> + (when (cond >> + ;; cond should be a major-mode variable >> + ((and (symbolp cond) (not (functionp cond))) >> + (derived-mode-p cond)) >> + >> + ;; cond should be a predicate that takes no argument >> + ;; It can either be a named function or a lambda >> + ((functionp cond) >> + (funcall cond)) >> + >> + ;; cond should be a regexp > Please be consistent, and quote 'cond' in all of these comments. > > P.S. Since the number of the bug is now known, please mention the bug > number in the commit log message when you submit the updated patch. --------------ktKHm9J4euFDeklm1PGkS0XE Content-Type: text/x-patch; charset=UTF-8; name="0001-bug-79178-Autoinsert-Allow-condition-to-be-a-functio.patch" Content-Disposition: attachment; filename*0="0001-bug-79178-Autoinsert-Allow-condition-to-be-a-functio.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxZTQ3MTZkMTY5ZGRlNjE0NjcxZTdmMmY5NmQ1MjdiNTcyYjIxMTllIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBtYXR0aWFzZHJwIDxtYXR0aWFzQGtvamluLnRlY2g+ CkRhdGU6IFR1ZSwgNSBBdWcgMjAyNSAxODoxMTo1OCArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IFtidWcjNzkxNzhdIEF1dG9pbnNlcnQ6IEFsbG93IGNvbmRpdGlvbiB0byBiZSBhIGZ1bmN0 aW9uCgpDdXJyZW50bHkgYSBjb25kaXRpb24gY2FuIG9ubHkgYmUgYSByZWdleHAgb3IgYSBt YWpvci1tb2RlIHN5bWJvbCBidXQKdGhlcmUncyBubyByZWFsIHJlYXNvbiB0byBub3QgYWxs b3cgYW55IHByZWRpY2F0ZSBhcyBhIGNvbmRpdGlvbgoKKiBkb2MvbWlzYy9hdXRvdHlwZS50 ZXh0OiBEb2N1bWVudCB0aGUgbmV3IGNvbmRpdGlvbiB0eXBlIGluICdhdXRvLWluc2VydC1h bGlzdCcKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhlIG5ldyBjb25kaXRpb24gdHlwZSBpbiAn YXV0by1pbnNlcnQtYWxpc3QnCiogbGlzcC9hdXRvaW5zZXJ0LmVsOgooYXV0by1pbnNlcnQt YWxpc3QpOiBBZGQgdGhlIG5ldyBjb25kaXRpb24gdHlwZSB0byB0aGUgdmFyaWFibGUKZG9j dW1lbnRhdGlvbgooYXV0by1pbnNlcnQpOiBDaGFuZ2UgdGhlIHdheSB0aGUgY29uZGl0aW9u IGlzIG1hdGNoZWQgdG8gYWxsb3cgZm9yCmN1c3RvbSBwcmVkaWNhdGVzCi0tLQogZG9jL21p c2MvYXV0b3R5cGUudGV4aSB8ICA1ICsrKy0tCiBldGMvTkVXUyAgICAgICAgICAgICAgIHwg IDYgKysrKysrCiBsaXNwL2F1dG9pbnNlcnQuZWwgICAgIHwgMjkgKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgOSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvbWlzYy9hdXRvdHlwZS50ZXhpIGIvZG9j L21pc2MvYXV0b3R5cGUudGV4aQppbmRleCBjNTNiZTU0ZDBhZi4uM2ExZWVmMWM2OTQgMTAw NjQ0Ci0tLSBhL2RvYy9taXNjL2F1dG90eXBlLnRleGkKKysrIGIvZG9jL21pc2MvYXV0b3R5 cGUudGV4aQpAQCAtMjc1LDkgKzI3NSwxMCBAQCBlbXB0eSBmaWxlIGlzIHZpc2l0ZWQuICBU aGlzIGlzIGFjY29tcGxpc2hlZCBieSBwdXR0aW5nCiAgIFdoYXQgZ2V0cyBpbnNlcnRlZCwg aWYgYW55dGhpbmcsIGlzIGRldGVybWluZWQgYnkgdGhlIHZhcmlhYmxlCiBAY29kZXthdXRv LWluc2VydC1hbGlzdH0uICBUaGUgQHNje2Nhcn0gb2YgZWFjaCBlbGVtZW50IG9mIHRoaXMg bGlzdAogaXMgZWl0aGVyIGEgbW9kZSBuYW1lLCBtYWtpbmcgdGhlIGVsZW1lbnQgYXBwbGlj YWJsZSB3aGVuIGEgYnVmZmVyIGlzCi1pbiB0aGF0IG1vZGUsIG9yIGEgc3RyaW5nLCB3aGlj aCBpcyBhIHJlZ2V4cCBtYXRjaGVkIGFnYWluc3QgYQoraW4gdGhhdCBtb2RlLCBhIHN0cmlu Zywgd2hpY2ggaXMgYSByZWdleHAgbWF0Y2hlZCBhZ2FpbnN0IGEKIGJ1ZmZlcidzIGZpbGUg bmFtZSAodGhlIGxhdHRlciBlbmFibGVzIHlvdSB0byBkaXN0aW5ndWlzaCBiZXR3ZWVuCi1k aWZmZXJlbnQga2luZHMgb2YgZmlsZXMgdGhhdCBoYXZlIHRoZSBzYW1lIG1vZGUgaW4gRW1h Y3MpLiAgVGhlCitkaWZmZXJlbnQga2luZHMgb2YgZmlsZXMgdGhhdCBoYXZlIHRoZSBzYW1l IG1vZGUgaW4gRW1hY3MpIG9yIGEgY3VzdG9tCitwcmVkaWNhdGUgdGhhdCB0YWtlcyBubyBh cmd1bWVudC4gIFRoZQogQHNje2Nhcn0gb2YgYW4gZWxlbWVudCBtYXkgYWxzbyBiZSBhIGNv bnMgY2VsbCwgY29uc2lzdGluZyBvZiBtb2RlCiBuYW1lIG9yIHJlZ2V4cCwgYXMgYWJvdmUs IGFuZCBhbiBhZGRpdGlvbmFsIGRlc2NyaXB0aXZlIHN0cmluZy4KIApkaWZmIC0tZ2l0IGEv ZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBlNGZiODMzYzBiZS4uZjllZTM3ZDk1ZjMgMTAw NjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC02ODgsNiArNjg4LDEyIEBA IHlvdSBjb3VsZCBhbHJlYWR5IHVzZSAnQy11IEMteCBDLW4nIHRvIGNsZWFyIHRoZSBnb2Fs IGNvbHVtbi4KIAwKICogQ2hhbmdlcyBpbiBTcGVjaWFsaXplZCBNb2RlcyBhbmQgUGFja2Fn ZXMgaW4gRW1hY3MgMzEuMQogCisqKiBBdXRvaW5zZXJ0CisKKyoqKiBOZXcgY29uZGl0aW9u IGZvciAnYXV0by1pbnNlcnQtYWxpc3QnLgorJ2F1dG8taW5zZXJ0LWFsaXN0JyBub3cgYWxz byBhbGxvd3MgdG8gaGF2ZSBhIHByZWRpY2F0ZSB0YWtpbmcgbm8gYXJndW1lbnQKK2FzIGNv bmRpdGlvbnMuIFRoaXMgYWxsb3dzIHRvIHRyaWdnZXIgJ2F1dG8taW5zZXJ0JyB3aXRoIGZp bmVyIGdyYWluZWQgY29udHJvbC4KKwogKiogUmVnaXN0ZXIKIAogKioqIFRoZSAiKlJlZ2lz dGVyIFByZXZpZXcqIiBidWZmZXIgc2hvd3Mgb25seSBzdWl0YWJsZSByZWdpc3RlcnMuCmRp ZmYgLS1naXQgYS9saXNwL2F1dG9pbnNlcnQuZWwgYi9saXNwL2F1dG9pbnNlcnQuZWwKaW5k ZXggZTc0OTJkMWI5ZWQuLjNjNDA1N2YxNjIzIDEwMDY0NAotLS0gYS9saXNwL2F1dG9pbnNl cnQuZWwKKysrIGIvbGlzcC9hdXRvaW5zZXJ0LmVsCkBAIC0zMjMsOCArMzIzLDEwIEBAIFRo ZSBkb2N1bWVudCB3YXMgdHlwZXNldCB3aXRoCiAiKSkKICAgIkEgbGlzdCBzcGVjaWZ5aW5n IHRleHQgdG8gaW5zZXJ0IGJ5IGRlZmF1bHQgaW50byBhIG5ldyBmaWxlLgogRWxlbWVudHMg bG9vayBsaWtlIChDT05ESVRJT04gLiBBQ1RJT04pIG9yICgoQ09ORElUSU9OIC4gREVTQ1JJ UFRJT04pIC4gQUNUSU9OKS4KLUNPTkRJVElPTiBtYXkgYmUgYSByZWdleHAgdGhhdCBtdXN0 IG1hdGNoIHRoZSBuZXcgZmlsZSdzIG5hbWUsIG9yIGl0IG1heSBiZQotYSBzeW1ib2wgdGhh dCBtdXN0IG1hdGNoIHRoZSBtYWpvciBtb2RlIGZvciB0aGlzIGVsZW1lbnQgdG8gYXBwbHku CitDT05ESVRJT04gbWF5IGJlIGEgcmVnZXhwIHRoYXQgbXVzdCBtYXRjaCB0aGUgbmV3IGZp bGUncyBuYW1lIG9yIGEgc3ltYm9sIHRoYXQKK211c3QgbWF0Y2ggdGhlIG1ham9yIG1vZGUg Zm9yIHRoaXMgZWxlbWVudCB0byBhcHBseS4KK0NPTkRJVElPTiBjYW4gYWxzbyBiZSBjdXN0 b20gcHJlZGljYXRlIGZ1bmN0aW9uIG9mIG5vIGFyZ3VtZW50czsgRW1hY3Mgd2lsbAoraW5z ZXJ0IHRoZSB0ZXh0IGlmIHRoZSBwcmVkaWNhdGUgZnVuY3Rpb24gcmV0dXJucyBub24tbmls LgogT25seSB0aGUgZmlyc3QgbWF0Y2hpbmcgZWxlbWVudCBpcyBlZmZlY3RpdmUuCiBPcHRp b25hbCBERVNDUklQVElPTiBpcyBhIHN0cmluZyBmb3IgZmlsbGluZyBgYXV0by1pbnNlcnQt cHJvbXB0Jy4KIEFDVElPTiBtYXkgYmUgYSBza2VsZXRvbiB0byBpbnNlcnQgKHNlZSBgc2tl bGV0b24taW5zZXJ0JyksIGFuIGFic29sdXRlCkBAIC0zNjgsMTIgKzM3MCwyNSBAQCBNYXRj aGVzIHRoZSB2aXNpdGVkIGZpbGUgbmFtZSBhZ2FpbnN0IHRoZSBlbGVtZW50cyBvZiBgYXV0 by1pbnNlcnQtYWxpc3QnLiIKICAgICAgICAgICAgICAgICAocGNhc2UtbGFtYmRhIChgKCxj b25kIC4gLGFjdGlvbikpCiAgICAgICAgICAgICAgICAgICAoaWYgKGF0b20gY29uZCkKICAg ICAgICAgICAgICAgICAgICAgICAoc2V0cSBkZXNjIGNvbmQpCi0gICAgICAgICAgICAgICAg ICAgIChzZXRxIGRlc2MgKGNkciBjb25kKQotICAgICAgICAgICAgICAgICAgICAgICAgICBj b25kIChjYXIgY29uZCkpKQotICAgICAgICAgICAgICAgICAgKHdoZW4gKGlmIChzeW1ib2xw IGNvbmQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRlcml2ZWQtbW9kZS1wIGNv bmQpCisgICAgICAgICAgICAgICAgICAgIDs7IGlmIGBjb25kJyBpcyBhIGxhbWJkYSwgZG9u J3Qgc3BsaXQgaXQgYnV0IHNldCBgZGVzYycgdG8gYSBjdXN0b20gc3RyaW5nCisgICAgICAg ICAgICAgICAgICAgIChpZiAoYW5kIChub3QgKHN5bWJvbHAgY29uZCkpIChmdW5jdGlvbnAg Y29uZCkpCisgICAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBkZXNjICJgbGFtYmRhIGNv bmRpdGlvbiciKQorICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGRlc2MgKGNkciBjb25k KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbmQgKGNhciBjb25kKSkpKQorICAg ICAgICAgICAgICAgICAgKHdoZW4gKGNvbmQKKyAgICAgICAgICAgICAgICAgICAgICAgICA7 OyBgY29uZCcgc2hvdWxkIGJlIGEgbWFqb3ItbW9kZSB2YXJpYWJsZQorICAgICAgICAgICAg ICAgICAgICAgICAgICgoYW5kIChzeW1ib2xwIGNvbmQpIChub3QgKGZ1bmN0aW9ucCBjb25k KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChkZXJpdmVkLW1vZGUtcCBjb25kKSkK KworICAgICAgICAgICAgICAgICAgICAgICAgIDs7IGBjb25kJyBzaG91bGQgYmUgYSBwcmVk aWNhdGUgdGhhdCB0YWtlcyBubyBhcmd1bWVudAorICAgICAgICAgICAgICAgICAgICAgICAg IDs7IEl0IGNhbiBlaXRoZXIgYmUgYSBuYW1lZCBmdW5jdGlvbiBvciBhIGxhbWJkYQorICAg ICAgICAgICAgICAgICAgICAgICAgICgoZnVuY3Rpb25wIGNvbmQpCisgICAgICAgICAgICAg ICAgICAgICAgICAgIChmdW5jYWxsIGNvbmQpKQorCisgICAgICAgICAgICAgICAgICAgICAg ICAgOzsgY29uZCBzaG91bGQgYmUgYSByZWdleHAKKyAgICAgICAgICAgICAgICAgICAgICAg ICAodAogICAgICAgICAgICAgICAgICAgICAgICAgICAoYW5kIGJ1ZmZlci1maWxlLW5hbWUK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLW1hdGNoIGNvbmQgYnVm ZmVyLWZpbGUtbmFtZSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJp bmctbWF0Y2ggY29uZCBidWZmZXItZmlsZS1uYW1lKSkpKQogICAgICAgICAgICAgICAgICAg ICBhY3Rpb24pKQogICAgICAgICAgICAgICAgIGF1dG8taW5zZXJ0LWFsaXN0KSkpCiAgICAg ICAgICAoZ290by1jaGFyIDEpCi0tIAoyLjUwLjEKCg== --------------ktKHm9J4euFDeklm1PGkS0XE-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 07 09:05:06 2025 Received: (at 79178) by debbugs.gnu.org; 7 Aug 2025 13:05:06 +0000 Received: from localhost ([127.0.0.1]:34023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uk0Ir-0006ZS-Uw for submit@debbugs.gnu.org; Thu, 07 Aug 2025 09:05:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49570) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uk0In-0006Yp-JA for 79178@debbugs.gnu.org; Thu, 07 Aug 2025 09:05:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uk0Ih-0007RK-97; Thu, 07 Aug 2025 09:04:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=O9l8ZQkAhLqTdjYB9xWDLKNWjw7GVRP+ngP6SvmVIv0=; b=XTQectr5UUtl MnZmC15yBcPqZxBlk4iZwGaBAfE2mnws/z8gZtjqQ3B/TPf31DrXbiqBNyYY428n+iS1O7Mk/F0kG DH869D2IZQ7vSWROr8ziqnRhK8kfmjHAcsgsiKHDwg939iTLQ8dZF2S15hlhTWs8RDCnr8tOHFG6C 41SkZghCkIGe2ccyUs1qNszCy+1NzBr3WcvCvjpEl4VpB36mgFAMFP+qug4tknp51Hc8mLNHmfWYH dbuwCDFXkPU+D+YwG8i0n2XcXf1kf9+iDbry6KJMtTMoulFZLqh4cPUKmNNTIIV09PqzoX2dzX25S BXjhhGY80Vv1501vpxWOeg==; Date: Thu, 07 Aug 2025 16:04:48 +0300 Message-Id: <86jz3fqo3z.fsf@gnu.org> From: Eli Zaretskii To: Mattias In-Reply-To: <49652288-2df8-486c-bc8c-41fa74bd6891@kojin.tech> (message from Mattias on Wed, 6 Aug 2025 16:46:25 +0200) Subject: Re: bug#79178: [Improvement] Allow auto-insert to have functions as conditions References: <2b5f436a-8f0d-443c-829a-b98e98018b5a@kojin.tech> <86o6ssu1l8.fsf@gnu.org> <49652288-2df8-486c-bc8c-41fa74bd6891@kojin.tech> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79178 Cc: 79178@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 6 Aug 2025 16:46:25 +0200 > Cc: 79178@debbugs.gnu.org > From: Mattias > > Thanks for the review! > > I think I did everything you asked, let me know if there's something > missing or not done properly ;-) Thanks, a couple of minor comments below. > * lisp/autoinsert.el: > (auto-insert-alist): Add the new condition type to the variable > documentation > (auto-insert): Change the way the condition is matched to allow for > custom predicates This should be formatted as below: * lisp/autoinsert.el: (auto-insert-alist): Add the new condition type to the variable documentation. (auto-insert): Change the way the condition is matched to allow for custom predicates. It is best to use change-log-mode for formatting commit log messages, as it will allow you to use M-q and other conveniences, and will obey the formatting according to our conventions. Also, don't forget the periods at the end of each sentence (I added them above). > +** Autoinsert > + > +*** New condition for 'auto-insert-alist'. > +'auto-insert-alist' now also allows to have a predicate taking no argument > +as conditions. This allows to trigger 'auto-insert' with finer grained control. Our convention is to leave 2 spaces between sentences. Also, since the manual was updated, the NEWS entry should be marked with "+++" (see the explanation at the beginning of NEWS). From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 07 09:18:49 2025 Received: (at 79178) by debbugs.gnu.org; 7 Aug 2025 13:18:49 +0000 Received: from localhost ([127.0.0.1]:34058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uk0W8-0007Ee-Tj for submit@debbugs.gnu.org; Thu, 07 Aug 2025 09:18:49 -0400 Received: from smtp6-g21.free.fr ([2a01:e0c:1:1599::15]:42382) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uk0W6-0007ET-MD for 79178@debbugs.gnu.org; Thu, 07 Aug 2025 09:18:47 -0400 Received: from [IPV6:2a01:e34:ec0b:4930:c19e:af58:6226:bace] (unknown [IPv6:2a01:e34:ec0b:4930:c19e:af58:6226:bace]) (Authenticated sender: mattias.roux@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 810DC780503; Thu, 7 Aug 2025 15:18:43 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------2sV7ZF0ihvG0Ngg9WR1kbfKQ" Message-ID: Date: Thu, 7 Aug 2025 15:18:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#79178: [Improvement] Allow auto-insert to have functions as conditions To: Eli Zaretskii References: <2b5f436a-8f0d-443c-829a-b98e98018b5a@kojin.tech> <86o6ssu1l8.fsf@gnu.org> <49652288-2df8-486c-bc8c-41fa74bd6891@kojin.tech> <86jz3fqo3z.fsf@gnu.org> Content-Language: en-US From: Mattias In-Reply-To: <86jz3fqo3z.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79178 Cc: 79178@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------2sV7ZF0ihvG0Ngg9WR1kbfKQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi and thanks again, > It is best to use change-log-mode for formatting commit log messages, > as it will allow you to use M-q and other conveniences, and will obey > the formatting according to our conventions. Also, don't forget the > periods at the end of each sentence (I added them above). I tried using change-log-mode but it indented the whole commit message with 4 spaces when I used M-q on it. My current mode seems to do the job with M-q, I just didn't use it before (and it removes the : between lisp/autoinsert and (auto-insert-alist) which looks like the intended formatting since other commit logs are formatted this way). --------------2sV7ZF0ihvG0Ngg9WR1kbfKQ Content-Type: text/x-patch; charset=UTF-8; name="0001-bug-79178-Autoinsert-Allow-condition-to-be-a-functio.patch" Content-Disposition: attachment; filename*0="0001-bug-79178-Autoinsert-Allow-condition-to-be-a-functio.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5NTUzNWM3MDE3ZjE5MjBmYTI4YTU2ZTMwMTA5NWU2YmUzNjA5NWIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBtYXR0aWFzZHJwIDxtYXR0aWFzQGtvamluLnRlY2g+ CkRhdGU6IFR1ZSwgNSBBdWcgMjAyNSAxODoxMTo1OCArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IFtidWcjNzkxNzhdIEF1dG9pbnNlcnQ6IEFsbG93IGNvbmRpdGlvbiB0byBiZSBhIGZ1bmN0 aW9uCgpDdXJyZW50bHkgYSBjb25kaXRpb24gY2FuIG9ubHkgYmUgYSByZWdleHAgb3IgYSBt YWpvci1tb2RlIHN5bWJvbCBidXQKdGhlcmUncyBubyByZWFsIHJlYXNvbiB0byBub3QgYWxs b3cgYW55IHByZWRpY2F0ZSBhcyBhIGNvbmRpdGlvbi4KCiogZG9jL21pc2MvYXV0b3R5cGUu dGV4dDogRG9jdW1lbnQgdGhlIG5ldyBjb25kaXRpb24gdHlwZSBpbgonYXV0by1pbnNlcnQt YWxpc3QnLgoqIGV0Yy9ORVdTOiBBbm5vdW5jZSB0aGUgbmV3IGNvbmRpdGlvbiB0eXBlIGlu ICdhdXRvLWluc2VydC1hbGlzdCcuCiogbGlzcC9hdXRvaW5zZXJ0LmVsIChhdXRvLWluc2Vy dC1hbGlzdCk6IEFkZCB0aGUgbmV3IGNvbmRpdGlvbiB0eXBlIHRvCnRoZSB2YXJpYWJsZSBk b2N1bWVudGF0aW9uLgooYXV0by1pbnNlcnQpOiBDaGFuZ2UgdGhlIHdheSB0aGUgY29uZGl0 aW9uIGlzIG1hdGNoZWQgdG8gYWxsb3cgZm9yCmN1c3RvbSBwcmVkaWNhdGVzLgotLS0KIGRv Yy9taXNjL2F1dG90eXBlLnRleGkgfCAgNSArKystLQogZXRjL05FV1MgICAgICAgICAgICAg ICB8ICA3ICsrKysrKysKIGxpc3AvYXV0b2luc2VydC5lbCAgICAgfCAyOSArKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCsp LCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9taXNjL2F1dG90eXBlLnRleGkg Yi9kb2MvbWlzYy9hdXRvdHlwZS50ZXhpCmluZGV4IGM1M2JlNTRkMGFmLi4zYTFlZWYxYzY5 NCAxMDA2NDQKLS0tIGEvZG9jL21pc2MvYXV0b3R5cGUudGV4aQorKysgYi9kb2MvbWlzYy9h dXRvdHlwZS50ZXhpCkBAIC0yNzUsOSArMjc1LDEwIEBAIGVtcHR5IGZpbGUgaXMgdmlzaXRl ZC4gIFRoaXMgaXMgYWNjb21wbGlzaGVkIGJ5IHB1dHRpbmcKICAgV2hhdCBnZXRzIGluc2Vy dGVkLCBpZiBhbnl0aGluZywgaXMgZGV0ZXJtaW5lZCBieSB0aGUgdmFyaWFibGUKIEBjb2Rl e2F1dG8taW5zZXJ0LWFsaXN0fS4gIFRoZSBAc2N7Y2FyfSBvZiBlYWNoIGVsZW1lbnQgb2Yg dGhpcyBsaXN0CiBpcyBlaXRoZXIgYSBtb2RlIG5hbWUsIG1ha2luZyB0aGUgZWxlbWVudCBh cHBsaWNhYmxlIHdoZW4gYSBidWZmZXIgaXMKLWluIHRoYXQgbW9kZSwgb3IgYSBzdHJpbmcs IHdoaWNoIGlzIGEgcmVnZXhwIG1hdGNoZWQgYWdhaW5zdCBhCitpbiB0aGF0IG1vZGUsIGEg c3RyaW5nLCB3aGljaCBpcyBhIHJlZ2V4cCBtYXRjaGVkIGFnYWluc3QgYQogYnVmZmVyJ3Mg ZmlsZSBuYW1lICh0aGUgbGF0dGVyIGVuYWJsZXMgeW91IHRvIGRpc3Rpbmd1aXNoIGJldHdl ZW4KLWRpZmZlcmVudCBraW5kcyBvZiBmaWxlcyB0aGF0IGhhdmUgdGhlIHNhbWUgbW9kZSBp biBFbWFjcykuICBUaGUKK2RpZmZlcmVudCBraW5kcyBvZiBmaWxlcyB0aGF0IGhhdmUgdGhl IHNhbWUgbW9kZSBpbiBFbWFjcykgb3IgYSBjdXN0b20KK3ByZWRpY2F0ZSB0aGF0IHRha2Vz IG5vIGFyZ3VtZW50LiAgVGhlCiBAc2N7Y2FyfSBvZiBhbiBlbGVtZW50IG1heSBhbHNvIGJl IGEgY29ucyBjZWxsLCBjb25zaXN0aW5nIG9mIG1vZGUKIG5hbWUgb3IgcmVnZXhwLCBhcyBh Ym92ZSwgYW5kIGFuIGFkZGl0aW9uYWwgZGVzY3JpcHRpdmUgc3RyaW5nLgogCmRpZmYgLS1n aXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGU0ZmI4MzNjMGJlLi5lNGMxZmU2NDdh OSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTY4OCw2ICs2ODgs MTMgQEAgeW91IGNvdWxkIGFscmVhZHkgdXNlICdDLXUgQy14IEMtbicgdG8gY2xlYXIgdGhl IGdvYWwgY29sdW1uLgogDAogKiBDaGFuZ2VzIGluIFNwZWNpYWxpemVkIE1vZGVzIGFuZCBQ YWNrYWdlcyBpbiBFbWFjcyAzMS4xCiAKKyoqIEF1dG9pbnNlcnQKKworKysrCisqKiogTmV3 IGNvbmRpdGlvbiBmb3IgJ2F1dG8taW5zZXJ0LWFsaXN0Jy4KKydhdXRvLWluc2VydC1hbGlz dCcgbm93IGFsc28gYWxsb3dzIHRvIGhhdmUgYSBwcmVkaWNhdGUgdGFraW5nIG5vIGFyZ3Vt ZW50CithcyBjb25kaXRpb25zLiAgVGhpcyBhbGxvd3MgdG8gdHJpZ2dlciAnYXV0by1pbnNl cnQnIHdpdGggZmluZXIgZ3JhaW5lZCBjb250cm9sLgorCiAqKiBSZWdpc3RlcgogCiAqKiog VGhlICIqUmVnaXN0ZXIgUHJldmlldyoiIGJ1ZmZlciBzaG93cyBvbmx5IHN1aXRhYmxlIHJl Z2lzdGVycy4KZGlmZiAtLWdpdCBhL2xpc3AvYXV0b2luc2VydC5lbCBiL2xpc3AvYXV0b2lu c2VydC5lbAppbmRleCBlNzQ5MmQxYjllZC4uM2M0MDU3ZjE2MjMgMTAwNjQ0Ci0tLSBhL2xp c3AvYXV0b2luc2VydC5lbAorKysgYi9saXNwL2F1dG9pbnNlcnQuZWwKQEAgLTMyMyw4ICsz MjMsMTAgQEAgVGhlIGRvY3VtZW50IHdhcyB0eXBlc2V0IHdpdGgKICIpKQogICAiQSBsaXN0 IHNwZWNpZnlpbmcgdGV4dCB0byBpbnNlcnQgYnkgZGVmYXVsdCBpbnRvIGEgbmV3IGZpbGUu CiBFbGVtZW50cyBsb29rIGxpa2UgKENPTkRJVElPTiAuIEFDVElPTikgb3IgKChDT05ESVRJ T04gLiBERVNDUklQVElPTikgLiBBQ1RJT04pLgotQ09ORElUSU9OIG1heSBiZSBhIHJlZ2V4 cCB0aGF0IG11c3QgbWF0Y2ggdGhlIG5ldyBmaWxlJ3MgbmFtZSwgb3IgaXQgbWF5IGJlCi1h IHN5bWJvbCB0aGF0IG11c3QgbWF0Y2ggdGhlIG1ham9yIG1vZGUgZm9yIHRoaXMgZWxlbWVu dCB0byBhcHBseS4KK0NPTkRJVElPTiBtYXkgYmUgYSByZWdleHAgdGhhdCBtdXN0IG1hdGNo IHRoZSBuZXcgZmlsZSdzIG5hbWUgb3IgYSBzeW1ib2wgdGhhdAorbXVzdCBtYXRjaCB0aGUg bWFqb3IgbW9kZSBmb3IgdGhpcyBlbGVtZW50IHRvIGFwcGx5LgorQ09ORElUSU9OIGNhbiBh bHNvIGJlIGN1c3RvbSBwcmVkaWNhdGUgZnVuY3Rpb24gb2Ygbm8gYXJndW1lbnRzOyBFbWFj cyB3aWxsCitpbnNlcnQgdGhlIHRleHQgaWYgdGhlIHByZWRpY2F0ZSBmdW5jdGlvbiByZXR1 cm5zIG5vbi1uaWwuCiBPbmx5IHRoZSBmaXJzdCBtYXRjaGluZyBlbGVtZW50IGlzIGVmZmVj dGl2ZS4KIE9wdGlvbmFsIERFU0NSSVBUSU9OIGlzIGEgc3RyaW5nIGZvciBmaWxsaW5nIGBh dXRvLWluc2VydC1wcm9tcHQnLgogQUNUSU9OIG1heSBiZSBhIHNrZWxldG9uIHRvIGluc2Vy dCAoc2VlIGBza2VsZXRvbi1pbnNlcnQnKSwgYW4gYWJzb2x1dGUKQEAgLTM2OCwxMiArMzcw LDI1IEBAIE1hdGNoZXMgdGhlIHZpc2l0ZWQgZmlsZSBuYW1lIGFnYWluc3QgdGhlIGVsZW1l bnRzIG9mIGBhdXRvLWluc2VydC1hbGlzdCcuIgogICAgICAgICAgICAgICAgIChwY2FzZS1s YW1iZGEgKGAoLGNvbmQgLiAsYWN0aW9uKSkKICAgICAgICAgICAgICAgICAgIChpZiAoYXRv bSBjb25kKQogICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGRlc2MgY29uZCkKLSAgICAg ICAgICAgICAgICAgICAgKHNldHEgZGVzYyAoY2RyIGNvbmQpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbmQgKGNhciBjb25kKSkpCi0gICAgICAgICAgICAgICAgICAod2hlbiAo aWYgKHN5bWJvbHAgY29uZCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVyaXZl ZC1tb2RlLXAgY29uZCkKKyAgICAgICAgICAgICAgICAgICAgOzsgaWYgYGNvbmQnIGlzIGEg bGFtYmRhLCBkb24ndCBzcGxpdCBpdCBidXQgc2V0IGBkZXNjJyB0byBhIGN1c3RvbSBzdHJp bmcKKyAgICAgICAgICAgICAgICAgICAgKGlmIChhbmQgKG5vdCAoc3ltYm9scCBjb25kKSkg KGZ1bmN0aW9ucCBjb25kKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGRlc2Mg ImBsYW1iZGEgY29uZGl0aW9uJyIpCisgICAgICAgICAgICAgICAgICAgICAgKHNldHEgZGVz YyAoY2RyIGNvbmQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uZCAoY2FyIGNv bmQpKSkpCisgICAgICAgICAgICAgICAgICAod2hlbiAoY29uZAorICAgICAgICAgICAgICAg ICAgICAgICAgIDs7IGBjb25kJyBzaG91bGQgYmUgYSBtYWpvci1tb2RlIHZhcmlhYmxlCisg ICAgICAgICAgICAgICAgICAgICAgICAgKChhbmQgKHN5bWJvbHAgY29uZCkgKG5vdCAoZnVu Y3Rpb25wIGNvbmQpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKGRlcml2ZWQtbW9k ZS1wIGNvbmQpKQorCisgICAgICAgICAgICAgICAgICAgICAgICAgOzsgYGNvbmQnIHNob3Vs ZCBiZSBhIHByZWRpY2F0ZSB0aGF0IHRha2VzIG5vIGFyZ3VtZW50CisgICAgICAgICAgICAg ICAgICAgICAgICAgOzsgSXQgY2FuIGVpdGhlciBiZSBhIG5hbWVkIGZ1bmN0aW9uIG9yIGEg bGFtYmRhCisgICAgICAgICAgICAgICAgICAgICAgICAgKChmdW5jdGlvbnAgY29uZCkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgKGZ1bmNhbGwgY29uZCkpCisKKyAgICAgICAgICAg ICAgICAgICAgICAgICA7OyBjb25kIHNob3VsZCBiZSBhIHJlZ2V4cAorICAgICAgICAgICAg ICAgICAgICAgICAgICh0CiAgICAgICAgICAgICAgICAgICAgICAgICAgIChhbmQgYnVmZmVy LWZpbGUtbmFtZQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctbWF0 Y2ggY29uZCBidWZmZXItZmlsZS1uYW1lKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHN0cmluZy1tYXRjaCBjb25kIGJ1ZmZlci1maWxlLW5hbWUpKSkpCiAgICAgICAg ICAgICAgICAgICAgIGFjdGlvbikpCiAgICAgICAgICAgICAgICAgYXV0by1pbnNlcnQtYWxp c3QpKSkKICAgICAgICAgIChnb3RvLWNoYXIgMSkKLS0gCjIuNTAuMQoK --------------2sV7ZF0ihvG0Ngg9WR1kbfKQ-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 07 10:41:03 2025 Received: (at 79178-done) by debbugs.gnu.org; 7 Aug 2025 14:41:03 +0000 Received: from localhost ([127.0.0.1]:35422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uk1ni-0003I3-Up for submit@debbugs.gnu.org; Thu, 07 Aug 2025 10:41:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34644) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uk1nf-0003HN-NC for 79178-done@debbugs.gnu.org; Thu, 07 Aug 2025 10:41:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uk1nZ-0000x5-2g; Thu, 07 Aug 2025 10:40:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GjZpvWW+8B2S5Wq035WKAoAOZ6dlRXHnrQWpLVbn41o=; b=muG8FBVmo3uH0BUWgf2W yHqpliSKlCKHgQNa5WNjtm5ZMmmsRnsSaBwcJf/pLJ+FkF1N7H6595Sx6F/NAcf0jIG6TK1CEyE/r ht1Bmv1Ko+0B/c39Eu+QS3reToW9CSO0ovYQM6vKMovymBK/xsoNbvMjxks07h4zDWIs1c+r/+Vnq MG8yywtXnOiOqAiD9GfAG4zviTreCe+1a2cjbB77b9yi9V3IRtyHyxQ30U4ROe1ZhLf7obTPFaZ8A Z8YHIns2I9bU6yVp2KJ1QprSpGZruzVDIrEgJzvtyZbC4wN9H8ChcejQXV5ttqZw2QtXQqsS/qdgY AMJR2SMr2xvuhQ==; Date: Thu, 07 Aug 2025 17:40:47 +0300 Message-Id: <86v7mzp53k.fsf@gnu.org> From: Eli Zaretskii To: Mattias In-Reply-To: (message from Mattias on Thu, 7 Aug 2025 15:18:43 +0200) Subject: Re: bug#79178: [Improvement] Allow auto-insert to have functions as conditions References: <2b5f436a-8f0d-443c-829a-b98e98018b5a@kojin.tech> <86o6ssu1l8.fsf@gnu.org> <49652288-2df8-486c-bc8c-41fa74bd6891@kojin.tech> <86jz3fqo3z.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79178-done Cc: 79178-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 7 Aug 2025 15:18:43 +0200 > Cc: 79178@debbugs.gnu.org > From: Mattias > > Hi and thanks again, > > > It is best to use change-log-mode for formatting commit log messages, > > as it will allow you to use M-q and other conveniences, and will obey > > the formatting according to our conventions. Also, don't forget the > > periods at the end of each sentence (I added them above). > > I tried using change-log-mode but it indented the whole commit > message with 4 spaces when I used M-q on it. My current mode seems to do > the job with M-q, I just didn't use it before (and it removes the : > between lisp/autoinsert and (auto-insert-alist) which looks like the > intended formatting since other commit logs are formatted this way). Thanks, installed on the master branch (with a few tiny fixes), and closing the bug.