GNU bug report logs - #79177
31.0.50; [PATCH] [v4] Add tests to ispell.el

Previous Next

Full log

Message #17 received at 79177 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lockywolf <for_emacs_1 <at> lockywolf.net>
Cc: 79177 <at> debbugs.gnu.org
Subject: Re: bug#79177: 31.0.50; [PATCH] [v4] Add tests to ispell.el
Date: Thu, 07 Aug 2025 12:09:30 +0300

> From: Lockywolf <for_emacs_1 <at> lockywolf.net>
> Cc: Lockywolf <for_emacs_1 <at> lockywolf.net>,  79177 <at> debbugs.gnu.org
> Date: Thu, 07 Aug 2025 16:07:54 +0800
> 
> >> diff --git a/test/lisp/textmodes/ispell-resources/fake-aspell.bash b/test/lisp/textmodes/ispell-resources/fake-aspell.bash
> >> new file mode 100755
> >> index 00000000000..4406a18a22e
> >> --- /dev/null
> >> +++ b/test/lisp/textmodes/ispell-resources/fake-aspell.bash
> >> @@ -0,0 +1,2 @@
> >> +#!/bin/bash
> >> +printf  '%s\n' "@(#) International Ispell Version 3.1.20 (but really Aspell 0.59.800)"
> >
> > I asked to use Emacs instead of a Bash script?  If that causes
> > problems, let's discuss that, okay?
> 
> Aspell needs to parse the "-vv" command-line argument, and Emacs
> launched in batch mode cannot do that.  Or I did not manage to make it.

Sorry, I don't understand.  The Bash script just outputs a fixed
string, and Emacs is capable of doing that.  What did you try, and if
it didn''t work, how it failed to work?

> I am not intentionally ignoring your suggestions, some of my responses
> got lost while moving from emacs-devel to the bug tracker.

Sorry, I didn't see any explanations, only the new patch, and I
responded to what I saw.

> >> +    (let ((test-dict "nonexistent")
> >> +          (test-pdict "/tmp/lnonexistent.txt"))
> >                          ^^^^^^^^^^^^^^^^^^^^^^^
> > Likewise here: please use
> >
> >    (expand-file-name "lnonexistent.txt" temporary-file-directory)
> >
> > instead.  (There are several other places in the patch with the same
> > problem.)
> 
> This is not a file path.  This is just a string which looks like a file
> path.  If something tries to access this as if it is a path during the
> execution of the test, this is an error.

OK, but the file name you use is not an absolute file name on Windows,
so it could cause problems.  Is there a problem with using my
suggestion, even though you don't need a real file name?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.