From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Daniel Colascione Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jan 2011 06:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7917 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 7917@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.129602286313187 (code B ref -1); Wed, 26 Jan 2011 06:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Jan 2011 06:21:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PhykY-0003Qe-Qp for submit@debbugs.gnu.org; Wed, 26 Jan 2011 01:21:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PhykX-0003QC-SD for submit@debbugs.gnu.org; Wed, 26 Jan 2011 01:21:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhysN-0000TQ-J0 for submit@debbugs.gnu.org; Wed, 26 Jan 2011 01:29:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:45993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhysN-0000TL-Ei for submit@debbugs.gnu.org; Wed, 26 Jan 2011 01:29:07 -0500 Received: from [140.186.70.92] (port=33126 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhysJ-0008Qc-8f for bug-gnu-emacs@gnu.org; Wed, 26 Jan 2011 01:29:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhysI-0000SA-2F for bug-gnu-emacs@gnu.org; Wed, 26 Jan 2011 01:29:03 -0500 Received: from mail-qw0-f41.google.com ([209.85.216.41]:36386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhysH-0000S4-UM for bug-gnu-emacs@gnu.org; Wed, 26 Jan 2011 01:29:02 -0500 Received: by qwa26 with SMTP id 26so594503qwa.0 for ; Tue, 25 Jan 2011 22:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=Cppsj7mgknVsgR2r7rZ8ZNS2T6U6yi1jZs69R+s8dfA=; b=tzDsAEdkLUPWjHFRE9/7ERv0JTpry5qAq1Je6qBFL9o8fKOGWZHbAMzDP6vhvrdbyx xsCtoW5k4/4F+yf3fS9wr9CL3kX6kDvUMO6gAOVe2YicN3oWiNftjaWrXXdO8l1RG+Rl f2y8McznKTnMXrytcfFMZUjtpydNa6/LWgA9k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=r/njD9kSre8QvzBKdAfZJVFtWUY1sTNaXa/gfDCXUf8XeXUnbaThU5b4LJa8Oujedb TFFu3KZRLlWOJ5owyrLanI1G0RfTYMQZujMDJgWyrr0zOuP+Cw4gicOlUT//0n5e3AQn YL9dkU2STNVzbm0XSGqoqMgsyHmyNBHoOp4gY= MIME-Version: 1.0 Received: by 10.229.189.6 with SMTP id dc6mr62906qcb.175.1296023341584; Tue, 25 Jan 2011 22:29:01 -0800 (PST) Received: by 10.220.200.11 with HTTP; Tue, 25 Jan 2011 22:29:01 -0800 (PST) Date: Tue, 25 Jan 2011 22:29:01 -0800 Message-ID: From: Daniel Colascione Content-Type: multipart/mixed; boundary=00163630f8dde551cf049ab9f263 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --00163630f8dde551cf049ab9f263 Content-Type: text/plain; charset=ISO-8859-1 None of the templates here should be fontified as types. template void foo(T t) {} template<> void foo(int x) {} void bar() { foo(5); } --00163630f8dde551cf049ab9f263 Content-Type: text/plain; charset=US-ASCII; name="templatefunc.patch" Content-Disposition: attachment; filename="templatefunc.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gjduqhiy0 PT09IG1vZGlmaWVkIGZpbGUgJ2xpc3AvcHJvZ21vZGVzL2NjLWVuZ2luZS5lbCcKLS0tIGxpc3Av cHJvZ21vZGVzL2NjLWVuZ2luZS5lbAkyMDEwLTEyLTA5IDA3OjUyOjU4ICswMDAwCisrKyBsaXNw L3Byb2dtb2Rlcy9jYy1lbmdpbmUuZWwJMjAxMS0wMS0yNiAwNTowNjo1OSArMDAwMApAQCAtNTg1 MCwxMSArNTg1MCwxMiBAQAogCSAgICAgICAod2hlbiAobGV0ICgoYy1yZWNvcmQtdHlwZS1pZGVu dGlmaWVycyB0KQogCQkJICAgKGMtcmVjb3JkLWZvdW5kLXR5cGVzIHQpKQogCQkgICAgICAgKGMt Zm9yd2FyZC08Pi1hcmdsaXN0IG5pbCkpCi0KLQkJIChjLWFkZC10eXBlIHN0YXJ0ICgxKyBwb3Mp KQorCQkgCiAJCSAoYy1mb3J3YXJkLXN5bnRhY3RpYy13cykKLQkJIChzZXRxIHBvcyAocG9pbnQp Ci0JCSAgICAgICBjLWxhc3QtaWRlbnRpZmllci1yYW5nZSBuaWwpCisJCSAodW5sZXNzIChlcSAo Y2hhci1hZnRlcikgP1woKQorCQkgICAoc2V0cSBjLWxhc3QtaWRlbnRpZmllci1yYW5nZSBuaWwp CisJCSAgIChjLWFkZC10eXBlIHN0YXJ0ICgxKyBwb3MpKSkKKwkJIChzZXRxIHBvcyAocG9pbnQp KQogCiAJCSAoaWYgKGFuZCBjLW9wdC1pZGVudGlmaWVyLWNvbmNhdC1rZXkKIAkJCSAgKGxvb2tp bmctYXQgYy1vcHQtaWRlbnRpZmllci1jb25jYXQta2V5KSkKQEAgLTU4NjgsNyArNTg2OSw4IEBA CiAJCSAgICAgICAoYy1mb3J3YXJkLXN5bnRhY3RpYy13cykKIAkJICAgICAgIHQpCiAKLQkJICAg KHdoZW4gKGFuZCBjLXJlY29yZC10eXBlLWlkZW50aWZpZXJzIGlkLXN0YXJ0KQorCQkgICAod2hl biAoYW5kIGMtcmVjb3JkLXR5cGUtaWRlbnRpZmllcnMgaWQtc3RhcnQKKwkJCSAgICAgIChub3Qg KGVxIChjaGFyLWFmdGVyKSA/XCgpKSkKIAkJICAgICAoYy1yZWNvcmQtdHlwZS1pZCAoY29ucyBp ZC1zdGFydCBpZC1lbmQpKSkKIAkJICAgKHNldHEgcmVzICd0ZW1wbGF0ZSkKIAkJICAgbmlsKSkp CkBAIC02MDU0LDkgKzYwNTYsMTcgQEAKIAkJCSAgIDs7IEl0J3MgYW4gaWRlbnRpZmllciB0aGF0 IG1pZ2h0IGJlIGEgdHlwZS4KIAkJCSAgICdtYXliZSkpKSkKIAkgICAgKChlcSBuYW1lLXJlcyAn dGVtcGxhdGUpCi0JICAgICA7OyBBIHRlbXBsYXRlIGlzIGEgdHlwZS4KKwkgICAgIDs7IEEgdGVt cGxhdGUgaXMgc29tZXRpbWVzIGEgdHlwZS4KIAkgICAgIChnb3RvLWNoYXIgaWQtZW5kKQotCSAg ICAgKHNldHEgcmVzIHQpKQorCSAgICAgKHNldHEgcmVzCisJCSAgIChpZiAoZXEgKGNoYXItYWZ0 ZXIpID9cKCkKKwkJICAgICAgIChpZiAoYy1jaGVjay10eXBlIGlkLXN0YXJ0IGlkLWVuZCkKKwkJ CSAgIDs7IEl0J3MgYW4gaWRlbnRpZmllciB0aGF0IGhhcyBiZWVuIHVzZWQgYXMKKwkJCSAgIDs7 IGEgdHlwZSBzb21ld2hlcmUgZWxzZS4KKwkJCSAgICdmb3VuZAorCQkJIDs7IEl0J3MgYW4gaWRl bnRpZmllciB0aGF0IG1pZ2h0IGJlIGEgdHlwZS4KKwkJCSAnbWF5YmUpCisJCSAgICAgdCkpKQog CSAgICAodAogCSAgICAgOzsgT3RoZXJ3aXNlIGl0J3MgYW4gb3BlcmF0b3IgaWRlbnRpZmllciwg d2hpY2ggaXMgbm90IGEgdHlwZS4KIAkgICAgIChnb3RvLWNoYXIgc3RhcnQpCgo9PT0gbW9kaWZp ZWQgZmlsZSAnbGlzcC9wcm9nbW9kZXMvY2MtZm9udHMuZWwnCi0tLSBsaXNwL3Byb2dtb2Rlcy9j Yy1mb250cy5lbAkyMDExLTAxLTI1IDExOjIwOjI1ICswMDAwCisrKyBsaXNwL3Byb2dtb2Rlcy9j Yy1mb250cy5lbAkyMDExLTAxLTI1IDEyOjU4OjI2ICswMDAwCkBAIC04MzUsMTEgKzgzNSwxMiBA QAogCQkgICAgKHdoZW4gKGFuZCBjLW9wdC1pZGVudGlmaWVyLWNvbmNhdC1rZXkKIAkJCSAgICAg ICAobm90IChnZXQtdGV4dC1wcm9wZXJ0eSBpZC1zdGFydCAnZmFjZSkpKQogCQkgICAgICAoYy1m b3J3YXJkLXN5bnRhY3RpYy13cykKLQkJICAgICAgKGlmIChsb29raW5nLWF0IGMtb3B0LWlkZW50 aWZpZXItY29uY2F0LWtleSkKLQkJCSAgKGMtcHV0LWZvbnQtbG9jay1mYWNlIGlkLXN0YXJ0IGlk LWVuZAotCQkJCQkJYy1yZWZlcmVuY2UtZmFjZS1uYW1lKQotCQkJKGMtcHV0LWZvbnQtbG9jay1m YWNlIGlkLXN0YXJ0IGlkLWVuZAotCQkJCQkgICAgICAnZm9udC1sb2NrLXR5cGUtZmFjZSkpKSkp CisJCSAgICAgIChjb25kICgobG9va2luZy1hdCBjLW9wdC1pZGVudGlmaWVyLWNvbmNhdC1rZXkp CisJCQkgICAgIChjLXB1dC1mb250LWxvY2stZmFjZSBpZC1zdGFydCBpZC1lbmQKKwkJCQkJCWMt cmVmZXJlbmNlLWZhY2UtbmFtZSkpCisJCQkgICAgKChlcSAoY2hhci1hZnRlcikgP1woKSkKKwkJ CSAgICAodCAoYy1wdXQtZm9udC1sb2NrLWZhY2UgaWQtc3RhcnQgaWQtZW5kCisJCQkJCSAgICAg ICdmb250LWxvY2stdHlwZS1mYWNlKSkpKSkpCiAKIAkJKGdvdG8tY2hhciBwb3MpKSkKIAkgIChn b3RvLWNoYXIgcG9zKSkpKSkKCg== --00163630f8dde551cf049ab9f263-- From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 26 Feb 2016 06:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch To: Daniel Colascione Cc: 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.145646777631986 (code B ref 7917); Fri, 26 Feb 2016 06:23:02 +0000 Received: (at 7917) by debbugs.gnu.org; 26 Feb 2016 06:22:56 +0000 Received: from localhost ([127.0.0.1]:46645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZBnk-0008Jp-0s for submit@debbugs.gnu.org; Fri, 26 Feb 2016 01:22:56 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:41025) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZBni-0008Ji-FS for 7917@debbugs.gnu.org; Fri, 26 Feb 2016 01:22:54 -0500 Received: from [175.103.25.178] (helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZBnM-0005Fx-2g; Fri, 26 Feb 2016 07:22:32 +0100 From: Lars Ingebrigtsen References: Date: Fri, 26 Feb 2016 16:52:27 +1030 In-Reply-To: (Daniel Colascione's message of "Tue, 25 Jan 2011 22:29:01 -0800") Message-ID: <87egc0uh24.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aZBnM-0005Fx-2g X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457072553.02892@fPPS6rADpGbAYbQbdbT3dw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Daniel Colascione writes: > None of the templates here should be fontified as types. > > template > void foo(T t) > {} > > template<> > void foo(int x) > {} > > void bar() > { > foo(5); > } On the Emacs trunk, I can't see anything immediately wrong about the fontification of the templates -- they're all fontified with the keyword face. So has this been fixed in the meantime (just five years)? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 26 Feb 2016 06:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen , Daniel Colascione Cc: 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.14564682141038 (code B ref 7917); Fri, 26 Feb 2016 06:31:02 +0000 Received: (at 7917) by debbugs.gnu.org; 26 Feb 2016 06:30:14 +0000 Received: from localhost ([127.0.0.1]:46660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZBuo-0000Ga-DM for submit@debbugs.gnu.org; Fri, 26 Feb 2016 01:30:14 -0500 Received: from dancol.org ([96.126.100.184]:45766) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZBum-0000DF-Ch for 7917@debbugs.gnu.org; Fri, 26 Feb 2016 01:30:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=HaObc01tlMphChvDENzOD3TnXQnsRBT/O/UdVkMRDp0=; b=CsJLJmJqUSI6fiVOmJeL+7XO+rqrMibUoHkoiuWde3CtHtQFTBpebB6zwPRlJmtV5fZTz2sTDJkYSmy50UkCXmGcaZKQRyRoTg/x70MjAzARjFo/fbcZrDOiig6zPRhfoy9d9HUbiuXjW/LKTq1sdpZVTSDL/zI4joUqZ2RNu3TPxaUhBkoxOvjYj5Qpo0ML6QMITrX0C4LjLJcFWlSxR6anPJajVmMAi1roQybbz35MsBFPlFtrRfMcyuRM4DqLdZXwlSA2hmwlhPsdUSEv7K35XK4WrfUrzEj+5HJ7LyQY/C6YM5EIJOvzRrMAQxP+Wxb2CHfW0C8leXT+L8merA==; Received: from c-67-161-115-4.hsd1.wa.comcast.net ([67.161.115.4] helo=[192.168.1.210]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1aZBuk-0005Yj-KA; Thu, 25 Feb 2016 22:30:10 -0800 References: <87egc0uh24.fsf@gnus.org> From: Daniel Colascione Message-ID: <56CFF0EE.6070300@dancol.org> Date: Thu, 25 Feb 2016 22:30:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87egc0uh24.fsf@gnus.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UK4K34v7uvI24jfj1KGJbaNAJI7Q00sij" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UK4K34v7uvI24jfj1KGJbaNAJI7Q00sij Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 02/25/2016 10:22 PM, Lars Ingebrigtsen wrote: > Daniel Colascione writes: >=20 >> None of the templates here should be fontified as types. >> >> template >> void foo(T t) >> {} >> >> template<> >> void foo(int x) >> {} >> >> void bar() >> { >> foo(5); >> } >=20 > On the Emacs trunk, I can't see anything immediately wrong about the > fontification of the templates -- they're all fontified with the keywor= d > face. >=20 > So has this been fixed in the meantime (just five years)? >=20 For me --- empty scratch buffer, c++-mode, emacs -Q, pasting in this example, the name of the second function is fontified as a type, not a function name. In the third function, in the call to foo, foo is also fontified as a type, although it shouldn't be fontified as anything at all. --UK4K34v7uvI24jfj1KGJbaNAJI7Q00sij Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJWz/DuAAoJEN4WImmbpWBlIcgP/3ClrABR4Pl4fUAH63COTsVD wO/OUI9iuhdf2mDmxVbeLNkXjYmLj7U9Sf8ZjpOS3L2KuqcfAO62m3ATZAuLOXUl gFuoV1jVNbj9E1xQbV9U5/RJP8h0zH3gOVXcxoqSgu/BYf15S1qDUJSN4u+/DDDM +fgE75y1dPRZaNkYSHxzHirUnQkGy8kTYZAGDU2WIWL2UfaJYU5NFeiaxckJqFaO iJRM5ElAD5+N4fEvvWvl9J6KFiEmgMKakCDohgBbrdvq+9Mr9Kw5DjhuRkkoAXD0 Utt3eoD2lLaMtSHwjwtO2VZsgu9VnXL4bPXpPWPLixIzJGZZkdJrp0BMIH8RqgYD A8xHwBHhRaNGlsWCEtAg1xBRoshFWCcfvYVPT7cYIh7/IddO0nuMLCzVjA+o8ohx vQS6Y54ohLkLqMOBvJWs7EdPvT/1MpUdrahNLQB5G3CvPpapcFKloqhfLdJktgDY MgX05ny/RkGtIg35yDQ7+NLkUnsDKCTNaHvaTTQtWPs3I0wbXC+ELFsut/eiUJTJ XChuXyHyDwNuFmurQCHNe2o623OPwQNjKizK/eH6KelG2pS+oQua62OWLSxdCsBI VDA6KBsF82LLhM9/GLnP0oise7et9TNh652lESyZ1YqOk6jVQjkRZ2GOezNfolVV ifZ/5tpFzgAQQC4g9pQ4 =KV// -----END PGP SIGNATURE----- --UK4K34v7uvI24jfj1KGJbaNAJI7Q00sij-- From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 26 Feb 2016 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch To: Daniel Colascione Cc: Daniel Colascione , 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.145647064623527 (code B ref 7917); Fri, 26 Feb 2016 07:11:02 +0000 Received: (at 7917) by debbugs.gnu.org; 26 Feb 2016 07:10:46 +0000 Received: from localhost ([127.0.0.1]:46742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZCY1-00067P-OX for submit@debbugs.gnu.org; Fri, 26 Feb 2016 02:10:45 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40453) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZCY0-00067G-Dp for 7917@debbugs.gnu.org; Fri, 26 Feb 2016 02:10:44 -0500 Received: from [175.103.25.178] (helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZCXU-0006ZT-QI; Fri, 26 Feb 2016 08:10:13 +0100 From: Lars Ingebrigtsen References: <87egc0uh24.fsf@gnus.org> <56CFF0EE.6070300@dancol.org> Date: Fri, 26 Feb 2016 17:40:06 +1030 In-Reply-To: <56CFF0EE.6070300@dancol.org> (Daniel Colascione's message of "Thu, 25 Feb 2016 22:30:06 -0800") Message-ID: <87egc0rlpt.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aZCXU-0006ZT-QI X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457075414.45999@lMopjzMwUUHnE+fFfh34bw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Daniel Colascione writes: > For me --- empty scratch buffer, c++-mode, emacs -Q, pasting in > this example, the name of the second function is fontified as a type, > not a function name. In the third function, in the call to foo, foo > is also fontified as a type, although it shouldn't be fontified as > anything at all. Oh, yeah, that's true. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 26 02:10:57 2016 Received: (at control) by debbugs.gnu.org; 26 Feb 2016 07:10:57 +0000 Received: from localhost ([127.0.0.1]:46745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZCYC-00067r-WD for submit@debbugs.gnu.org; Fri, 26 Feb 2016 02:10:57 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40468) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZCYB-00067h-6u for control@debbugs.gnu.org; Fri, 26 Feb 2016 02:10:55 -0500 Received: from [175.103.25.178] (helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZCXm-0006Zu-8C for control@debbugs.gnu.org; Fri, 26 Feb 2016 08:10:31 +0100 Date: Fri, 26 Feb 2016 17:40:26 +1030 Message-Id: <87d1rkrlp9.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #7917 X-MailScanner-ID: 1aZCXm-0006Zu-8C X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457075432.48988@aroM4YwQATCTUtLPmX6rBw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 7917 confirmed From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 27 Feb 2016 04:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch confirmed To: Daniel Colascione Cc: 7917@debbugs.gnu.org, dan.colascione@gmail.com X-Debbugs-Original-Cc: bug-cc-mode@gnu.org, Daniel Colascione , 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.14565458561775 (code B ref 7917); Sat, 27 Feb 2016 04:05:02 +0000 Received: (at 7917) by debbugs.gnu.org; 27 Feb 2016 04:04:16 +0000 Received: from localhost ([127.0.0.1]:48074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZW72-0000ST-Bz for submit@debbugs.gnu.org; Fri, 26 Feb 2016 23:04:15 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:51459) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZW6x-0000SJ-D8 for 7917@debbugs.gnu.org; Fri, 26 Feb 2016 23:04:11 -0500 Received: from [175.103.25.178] (helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aZW6X-0001mI-UU; Sat, 27 Feb 2016 05:03:42 +0100 From: Lars Ingebrigtsen References: <87egc0uh24.fsf@gnus.org> <56CFF0EE.6070300@dancol.org> <87egc0rlpt.fsf@gnus.org> Date: Sat, 27 Feb 2016 14:33:36 +1030 In-Reply-To: <87egc0rlpt.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 26 Feb 2016 17:40:06 +1030") Message-ID: <87h9gulrzb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aZW6X-0001mI-UU X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457150623.4669@Z2L74Be5tPZtjbS1AIvWQQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > Daniel Colascione writes: > >> For me --- empty scratch buffer, c++-mode, emacs -Q, pasting in >> this example, the name of the second function is fontified as a type, >> not a function name. In the third function, in the call to foo, foo >> is also fontified as a type, although it shouldn't be fontified as >> anything at all. > > Oh, yeah, that's true. And your patch fixes the issue. Does anybody have any objections to applying the patch? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 28 Feb 2016 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch confirmed To: Lars Ingebrigtsen Cc: 7917@debbugs.gnu.org, dancol@dancol.org, dan.colascione@gmail.com X-Debbugs-Original-Cc: bug-cc-mode@gnu.org, Daniel Colascione , Daniel Colascione , 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.145669498628791 (code B ref 7917); Sun, 28 Feb 2016 21:30:02 +0000 Received: (at 7917) by debbugs.gnu.org; 28 Feb 2016 21:29:46 +0000 Received: from localhost ([127.0.0.1]:51052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aa8uO-0007UF-PB for submit@debbugs.gnu.org; Sun, 28 Feb 2016 16:29:46 -0500 Received: from mail.muc.de ([193.149.48.3]:24166) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aa8uK-0007U4-Cp for 7917@debbugs.gnu.org; Sun, 28 Feb 2016 16:29:44 -0500 Received: (qmail 66290 invoked by uid 3782); 28 Feb 2016 21:29:38 -0000 Received: from acm.muc.de (p5B147015.dip0.t-ipconnect.de [91.20.112.21]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 28 Feb 2016 22:29:37 +0100 Received: (qmail 4142 invoked by uid 1000); 28 Feb 2016 21:32:07 -0000 Date: Sun, 28 Feb 2016 21:32:07 +0000 Message-ID: <20160228213207.GA2801@acm.fritz.box> References: <87egc0uh24.fsf@gnus.org> <56CFF0EE.6070300@dancol.org> <87egc0rlpt.fsf@gnus.org> <87h9gulrzb.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h9gulrzb.fsf@gnus.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, Lars. On Sat, Feb 27, 2016 at 02:33:36PM +1030, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > > Daniel Colascione writes: > >> For me --- empty scratch buffer, c++-mode, emacs -Q, pasting in > >> this example, the name of the second function is fontified as a type, > >> not a function name. In the third function, in the call to foo, foo > >> is also fontified as a type, although it shouldn't be fontified as > >> anything at all. > > Oh, yeah, that's true. > And your patch fixes the issue. Does anybody have any objections to > applying the patch? The patch breaks the fontification of certain Java constructs, in particular, ones looking like this: Map allDrivers = new Map(); ^^^ With the patch in place, the indicated "Map" doesn't get fontified in font-lock-type-face as it should. Before applying any patches like this to CC Mode, could you please run them through the CC Mode test suite first (or ask Daniel (the OP) or me to do it). Thanks! > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Mon, 29 Feb 2016 02:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch confirmed To: Alan Mackenzie Cc: 7917@debbugs.gnu.org, dancol@dancol.org, dan.colascione@gmail.com X-Debbugs-Original-Cc: bug-cc-mode@gnu.org, Daniel Colascione , Daniel Colascione , 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.14567143217079 (code B ref 7917); Mon, 29 Feb 2016 02:53:01 +0000 Received: (at 7917) by debbugs.gnu.org; 29 Feb 2016 02:52:01 +0000 Received: from localhost ([127.0.0.1]:51184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaDwH-0001q1-5X for submit@debbugs.gnu.org; Sun, 28 Feb 2016 21:52:01 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:53213) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaDwE-0001pr-Ea for 7917@debbugs.gnu.org; Sun, 28 Feb 2016 21:51:59 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aaDvq-0008LS-LI; Mon, 29 Feb 2016 03:51:35 +0100 From: Lars Ingebrigtsen References: <87egc0uh24.fsf@gnus.org> <56CFF0EE.6070300@dancol.org> <87egc0rlpt.fsf@gnus.org> <87h9gulrzb.fsf@gnus.org> <20160228213207.GA2801@acm.fritz.box> Date: Mon, 29 Feb 2016 13:51:29 +1100 In-Reply-To: <20160228213207.GA2801@acm.fritz.box> (Alan Mackenzie's message of "Sun, 28 Feb 2016 21:32:07 +0000") Message-ID: <8760x82pqm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aaDvq-0008LS-LI X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457319095.6286@EtGwvDbzeolG3HCuWz6pkQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Alan Mackenzie writes: > Before applying any patches like this to CC Mode, could you please run > them through the CC Mode test suite first (or ask Daniel (the OP) or me > to do it). Thanks! Is the CC Mode test suite included in the Emacs test/ directory somewhere? I looked around and didn't really find anything... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Mon, 29 Feb 2016 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch confirmed To: Lars Ingebrigtsen Cc: 7917@debbugs.gnu.org, dancol@dancol.org, dan.colascione@gmail.com X-Debbugs-Original-Cc: bug-cc-mode@gnu.org, Daniel Colascione , Daniel Colascione , 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.14567839116864 (code B ref 7917); Mon, 29 Feb 2016 22:12:01 +0000 Received: (at 7917) by debbugs.gnu.org; 29 Feb 2016 22:11:51 +0000 Received: from localhost ([127.0.0.1]:54220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaW2h-0001mc-73 for submit@debbugs.gnu.org; Mon, 29 Feb 2016 17:11:51 -0500 Received: from mail.muc.de ([193.149.48.3]:38387) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaW2f-0001mU-Td for 7917@debbugs.gnu.org; Mon, 29 Feb 2016 17:11:50 -0500 Received: (qmail 37978 invoked by uid 3782); 29 Feb 2016 22:11:48 -0000 Received: from acm.muc.de (p579E9FE1.dip0.t-ipconnect.de [87.158.159.225]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 29 Feb 2016 23:11:45 +0100 Received: (qmail 27854 invoked by uid 1000); 29 Feb 2016 22:14:17 -0000 Date: Mon, 29 Feb 2016 22:14:17 +0000 Message-ID: <20160229221417.GA3762@acm.fritz.box> References: <87egc0uh24.fsf@gnus.org> <56CFF0EE.6070300@dancol.org> <87egc0rlpt.fsf@gnus.org> <87h9gulrzb.fsf@gnus.org> <20160228213207.GA2801@acm.fritz.box> <8760x82pqm.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8760x82pqm.fsf@gnus.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, Lars. On Mon, Feb 29, 2016 at 01:51:29PM +1100, Lars Ingebrigtsen wrote: > Alan Mackenzie writes: > > Before applying any patches like this to CC Mode, could you please run > > them through the CC Mode test suite first (or ask Daniel (the OP) or me > > to do it). Thanks! > Is the CC Mode test suite included in the Emacs test/ directory > somewhere? I looked around and didn't really find anything... No, it's only in CC Mode (the project) itself. It's build up from around 400 mostly small source files, each of which tests either indentation, fontification, or both, together with an elisp file which drives everything. The (Mercurial) repository of CC Mode can be found via . -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 01 Apr 2016 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch confirmed To: Daniel Colascione Cc: 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.145951586823762 (code B ref 7917); Fri, 01 Apr 2016 13:05:01 +0000 Received: (at 7917) by debbugs.gnu.org; 1 Apr 2016 13:04:28 +0000 Received: from localhost ([127.0.0.1]:46887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alykW-0006BC-06 for submit@debbugs.gnu.org; Fri, 01 Apr 2016 09:04:28 -0400 Received: from mail.muc.de ([193.149.48.3]:13614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alykU-0006B2-05 for 7917@debbugs.gnu.org; Fri, 01 Apr 2016 09:04:26 -0400 Received: (qmail 70777 invoked by uid 3782); 1 Apr 2016 13:04:24 -0000 Received: from acm.muc.de (p548A5847.dip0.t-ipconnect.de [84.138.88.71]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 01 Apr 2016 15:04:18 +0200 Received: (qmail 5236 invoked by uid 1000); 1 Apr 2016 13:07:14 -0000 Date: Fri, 1 Apr 2016 13:07:14 +0000 Message-ID: <20160401130714.GA5228@acm.fritz.box> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Daniel. I've committed a fix for bug #7917 into the emacs-25 branch. It's basically your patch, but with one or two extra bits to cope with a nasty little problem it caused in a Java Mode test file. Would you try it out, please, and confirm that it has indeed fixed the bug, or let me know what is still wrong. Thanks! -- Alan Mackenzie (Nuremberg, Germany). On Tue, Jan 25, 2011 at 10:29:01PM -0800, Daniel Colascione wrote: > None of the templates here should be fontified as types. > template > void foo(T t) > {} > template<> > void foo(int x) > {} > void bar() > { > foo(5); > } > === modified file 'lisp/progmodes/cc-engine.el' > --- lisp/progmodes/cc-engine.el 2010-12-09 07:52:58 +0000 > +++ lisp/progmodes/cc-engine.el 2011-01-26 05:06:59 +0000 > @@ -5850,11 +5850,12 @@ > (when (let ((c-record-type-identifiers t) > (c-record-found-types t)) > (c-forward-<>-arglist nil)) > - > - (c-add-type start (1+ pos)) > + > (c-forward-syntactic-ws) > - (setq pos (point) > - c-last-identifier-range nil) > + (unless (eq (char-after) ?\() > + (setq c-last-identifier-range nil) > + (c-add-type start (1+ pos))) > + (setq pos (point)) > (if (and c-opt-identifier-concat-key > (looking-at c-opt-identifier-concat-key)) > @@ -5868,7 +5869,8 @@ > (c-forward-syntactic-ws) > t) > - (when (and c-record-type-identifiers id-start) > + (when (and c-record-type-identifiers id-start > + (not (eq (char-after) ?\())) > (c-record-type-id (cons id-start id-end))) > (setq res 'template) > nil))) > @@ -6054,9 +6056,17 @@ > ;; It's an identifier that might be a type. > 'maybe)))) > ((eq name-res 'template) > - ;; A template is a type. > + ;; A template is sometimes a type. > (goto-char id-end) > - (setq res t)) > + (setq res > + (if (eq (char-after) ?\() > + (if (c-check-type id-start id-end) > + ;; It's an identifier that has been used as > + ;; a type somewhere else. > + 'found > + ;; It's an identifier that might be a type. > + 'maybe) > + t))) > (t > ;; Otherwise it's an operator identifier, which is not a type. > (goto-char start) > === modified file 'lisp/progmodes/cc-fonts.el' > --- lisp/progmodes/cc-fonts.el 2011-01-25 11:20:25 +0000 > +++ lisp/progmodes/cc-fonts.el 2011-01-25 12:58:26 +0000 > @@ -835,11 +835,12 @@ > (when (and c-opt-identifier-concat-key > (not (get-text-property id-start 'face))) > (c-forward-syntactic-ws) > - (if (looking-at c-opt-identifier-concat-key) > - (c-put-font-lock-face id-start id-end > - c-reference-face-name) > - (c-put-font-lock-face id-start id-end > - 'font-lock-type-face))))) > + (cond ((looking-at c-opt-identifier-concat-key) > + (c-put-font-lock-face id-start id-end > + c-reference-face-name)) > + ((eq (char-after) ?\()) > + (t (c-put-font-lock-face id-start id-end > + 'font-lock-type-face)))))) > (goto-char pos))) > (goto-char pos))))) From unknown Fri Aug 15 21:24:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7917: [PATCH] cc-mode: not all templates are types Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Thu, 29 Jun 2017 01:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7917 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch confirmed To: Alan Mackenzie Cc: Daniel Colascione , 7917@debbugs.gnu.org Received: via spool by 7917-submit@debbugs.gnu.org id=B7917.149869804910859 (code B ref 7917); Thu, 29 Jun 2017 01:01:02 +0000 Received: (at 7917) by debbugs.gnu.org; 29 Jun 2017 01:00:49 +0000 Received: from localhost ([127.0.0.1]:43162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQNpB-0002p0-An for submit@debbugs.gnu.org; Wed, 28 Jun 2017 21:00:49 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQNp9-0002og-OC; Wed, 28 Jun 2017 21:00:48 -0400 Received: by mail-io0-f195.google.com with SMTP id h134so6712732iof.3; Wed, 28 Jun 2017 18:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FcqOdsssrxwu7JbE/J63Q0j85lzLjqmePo2G+EfMJKQ=; b=CvsAgnOngeznqzVXSsAZq/AF4eqc5EGgwCC16I4WUhCQDTvFDmD7a6LXUMxpcrUT9O S8JwKjm6ahdkMbpMitV1o984eAOID1wWtpjzPUbGFe8DM6OUOAqhZQg9VbtV47Kgl7HA wPto3JR5hoCFeZjSYtlsilzfT6p18Mueo0nVq8xeGLUiqJEhVXQGxwV8n0X11yRIIxyX AvxvUqjExFVlADQk4pYZFMRCSXbM4NvxXnayYr3o5HmfhavKns0PjAiuRm4LLlTSVU1o witAaLzr3uzlg5Rx/OFhpr1H1Jto8okrZN9PKMqO5EAKSdVEnMffWDEDpJzo9Dbw/teq gN0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=FcqOdsssrxwu7JbE/J63Q0j85lzLjqmePo2G+EfMJKQ=; b=BvTMKQx2FNQ7IbloXhOUzsDAfkt4iJPSFHdp+7ixmUJ4RjwUHWFNCYKmWkoiNQPZKz tpbxbkvBKrz5vVWkvAnt2S2o4x9ZO0smeSwtTqOVrfzUpGIXN8zZoNlEXsmlvimb4T/0 zP6Ai5xSjcbM4TOtkXJG/0QhyETPImXDahqVWldDRJdxq+NQHbKj37N7TdLhQjAg4TUS nz17gx5NNqTLINh8lJSd02gj175MYpEkIQxplIRWaEHcKL+FLN68LAl3/To/I1ESombS oXXmoidIeurucd7f+K/KoWBWWnV92Wipv7P6dRUBDDhPMq8U9csFjtTnJzRTYsVjZ2sy ujAg== X-Gm-Message-State: AKS2vOxLBNCeMyzbE75OcV2EHd0oQvTceW76kxdKerYk51f7NKV4/98I 78VhBw/Of072ILMd X-Received: by 10.107.13.143 with SMTP id 137mr346734ion.203.1498698040270; Wed, 28 Jun 2017 18:00:40 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 131sm3740141itk.10.2017.06.28.18.00.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jun 2017 18:00:39 -0700 (PDT) From: npostavs@users.sourceforge.net References: <20160401130714.GA5228@acm.fritz.box> Date: Wed, 28 Jun 2017 21:02:15 -0400 In-Reply-To: <20160401130714.GA5228@acm.fritz.box> (Alan Mackenzie's message of "Fri, 1 Apr 2016 13:07:14 +0000") Message-ID: <87o9t7mwrs.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) found 7917 24.5 severity 7917 minor tags 7917 fixed close 7917 25.1 quit Alan Mackenzie writes: > I've committed a fix for bug #7917 into the emacs-25 branch. It's > basically your patch, but with one or two extra bits to cope with a > nasty little problem it caused in a Java Mode test file. > > Would you try it out, please, and confirm that it has indeed fixed the > bug, or let me know what is still wrong. Thanks! I can see the bug in 24.5, but not in 25.1