From unknown Fri Aug 15 04:02:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79157 <79157@debbugs.gnu.org> To: bug#79157 <79157@debbugs.gnu.org> Subject: Status: [PATCH] Fix recursive load when 'calc-always-load-extensions' is set Reply-To: bug#79157 <79157@debbugs.gnu.org> Date: Fri, 15 Aug 2025 11:02:42 +0000 retitle 79157 [PATCH] Fix recursive load when 'calc-always-load-extensions'= is set reassign 79157 emacs submitter 79157 Sean Devlin severity 79157 normal tag 79157 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 12:32:17 2025 Received: (at submit) by debbugs.gnu.org; 2 Aug 2025 16:32:17 +0000 Received: from localhost ([127.0.0.1]:37314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiF9c-0003Pn-Ok for submit@debbugs.gnu.org; Sat, 02 Aug 2025 12:32:17 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44884) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiF9a-0003PS-0M for submit@debbugs.gnu.org; Sat, 02 Aug 2025 12:32:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uiF9U-0000Oj-0N for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2025 12:32:08 -0400 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uiF9S-0000lC-82 for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2025 12:32:07 -0400 Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-87c6dfca35bso95850639f.1 for ; Sat, 02 Aug 2025 09:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1754152324; x=1754757124; darn=gnu.org; h=to:date:message-id:subject:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Fxetgkyu97MIJSiimo95j3c040B3rTS/s0kKJbUeygM=; b=i7PQxLaaxb2gWVoeFhO7wMfunSfk9e9RVsiM8X3bPJBP7qLA0YavQEYbISbhufJfZW NiVhzYUckZY6TmdO5u8ftY52vsZfiKEzqDTN5NwCK/d0lyrxgzUhGfNBkL1eMsc2IYyk MT0XlLSSj6wYX4XmkDPiDKfWAJ0bfGeE+WhGIK1YxwVK/DPghiC8pKTkz2GodiqDP3bk ufr5ERgBwPT3w1OyEe08wX79f+t8IH5Jo18YiXZ/VOOHnEewxcX0tt+CTGQ4dVAMYjVs hi2YiaBOnzdga6jyA1i3YeNLcovovLzWVUMi2C6p55fDKMhuNU26WYy8lWGNzS6m0j50 dWJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754152324; x=1754757124; h=to:date:message-id:subject:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Fxetgkyu97MIJSiimo95j3c040B3rTS/s0kKJbUeygM=; b=Jz2Jniq86jr9IOAy1dXuXQzeJqX0lmiKNxVpMnlbjqyGBuupzzmzsyhSArx5nwf4ZC 6Vo14eOpYya32Wgr5/6XQIZAuiJiHh6/UTplEVSiVAP3PQ5NUz/a0ft5uPNH4iRgHcOa 1jSif0mX9cjE0QRYQP61PJcKwYoz6NjYpk3bsKMvTPK1JT477dLRYJVCn8sC2DIUvoY9 x76KX19p4KuArUrlX6t6kS8gIMn2SvOcPvRjSnx9YNDBStolOdulu1r3cTRGjzxTZc5M NCJlO6TF0CiN5/6ZW4j+5cbq4cPDoQP5eLQjd2AXqSv93WrbNtKgKyf9lIIv3UR/PLh2 npNw== X-Gm-Message-State: AOJu0YwA/E18p3dTyXkH3/mILSi0RGkqMlBIEGkBqLyi/HccjeAJb3pm HtGY7sZrZIR6XOMZlF8K932iEyFm6CERXxpErNh9JhWPm2Fp/O1/Oe8Um27dA0n/aLFG8O7F8tm O6VgR X-Gm-Gg: ASbGncudtfMNvFRxH9bbIbacm4KYxOqErlrcZZKVtODrrxzEp2VdAfkJB5Fy3qWkzF8 oDSw0A2BXmvFGIk9B0129OahJVIdAyuVkAyM/ebqOuoiLmQYMB1ps5ue0/FkeXEaJC0OKG/2DV7 2q646ch3wvX2hucSoAwjShZe5nnvkXsZPg67X5F2cEgZUeePu/KsZS8AlcUmAz5adIeTmgAqZp8 0qYAPcTDOAM6tePe7h4pfLNNZEyzBXOsvue5LqPh0d9iTFZHfwEewkEw8hbTTpXspH2cRYLVgaN vr467hEF9hpp6YnIZObhJKtnal5ThZoo3xhNdLjnzipEDVeVhN0B7t051KfVrNcximPeYlFEGHL 7cu6//bgSsN7MYLT5CR/1deczptWvZFX5/mYghlp7F9saxvWkUA6X/wWQOfV8MCSbBiGGcas1x8 0YFERWtPiB9AM= X-Google-Smtp-Source: AGHT+IFEPN542JvdM/8GFVpEEOPT9NYDrRW0dkDH+PihMYDxh7bMWuncID51EZnfmWt8G+tsCgwT2A== X-Received: by 2002:a05:6602:44c:b0:876:4204:b63d with SMTP id ca18e2360f4ac-8814eb92c9amr1255647639f.8.1754152324096; Sat, 02 Aug 2025 09:32:04 -0700 (PDT) Received: from smtpclient.apple (c-67-167-5-111.hsd1.il.comcast.net. [67.167.5.111]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50a55b1c1c4sm2040874173.4.2025.08.02.09.32.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Aug 2025 09:32:03 -0700 (PDT) From: Sean Devlin Content-Type: multipart/mixed; boundary="Apple-Mail=_1B0BA98B-AF02-4F52-8FA6-4AA36DE9EE31" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: [PATCH] Fix recursive load when 'calc-always-load-extensions' is set Message-Id: Date: Sat, 2 Aug 2025 11:31:53 -0500 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3826.700.81) Received-SPF: pass client-ip=2607:f8b0:4864:20::d2e; envelope-from=spd@toadstyle.org; helo=mail-io1-xd2e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_1B0BA98B-AF02-4F52-8FA6-4AA36DE9EE31 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi folks, The Calc setting calc-always-load-extensions leads to a recursive load error if you set it in your init file before loading calc.el. (If you = set it after loading calc.el, e.g. via calc-settings-file, there is no recursive = error, but it also doesn=E2=80=99t load the extensions.) To reproduce: 1. Emacs -Q 2. Eval: (setq calc-always-load-extensions t) 3. M-x calc RET You should see a recursive load error. This is due to this top-level stanza near the bottom of calc.el: (when calc-always-load-extensions (require 'calc-ext) (calc-load-everything)) This can never work as written, since calc-ext.el requires calc.el. I took a stab at correcting this by deleting this stanza and moving the call to calc-load-everything inside calc-create-buffer. I=E2=80=99m not = sure if this is the best way, so feedback is welcome. Thanks! --Apple-Mail=_1B0BA98B-AF02-4F52-8FA6-4AA36DE9EE31 Content-Disposition: attachment; filename=0001-Fix-recursive-load-when-calc-always-load-extensions-.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-recursive-load-when-calc-always-load-extensions-.patch" Content-Transfer-Encoding: quoted-printable =46rom=2049e34dede07b2151dadc0e1f71cc4405ba7f42f5=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Sean=20Devlin=20=0ADate:=20= Sat,=202=20Aug=202025=2010:51:18=20-0500=0ASubject:=20[PATCH]=20Fix=20= recursive=20load=20when=20'calc-always-load-extensions'=20is=20set=0A=0A= *=20lisp/calc/calc.el=20(calc-create-buffer):=20Call=20= 'calc-load-everything'.=0A(calc-always-load-extensions):=20Delete=20= erroneous=20stanza.=0A---=0A=20lisp/calc/calc.el=20|=208=20++------=0A=20= 1=20file=20changed,=202=20insertions(+),=206=20deletions(-)=0A=0Adiff=20= --git=20a/lisp/calc/calc.el=20b/lisp/calc/calc.el=0Aindex=20= d4fb8776c6c..6f4664dd6c4=20100644=0A---=20a/lisp/calc/calc.el=0A+++=20= b/lisp/calc/calc.el=0A@@=20-1468,7=20+1468,8=20@@=20calc-create-buffer=0A= =20=20=20=20=20=20=20(calc-mode))=0A=20=20=20(setq=20max-lisp-eval-depth=20= (max=20max-lisp-eval-depth=201000))=0A=20=20=20(when=20= calc-always-load-extensions=0A-=20=20=20=20(require=20'calc-ext))=0A+=20=20= =20=20(require=20'calc-ext)=0A+=20=20=20=20(calc-load-everything))=0A=20=20= =20(when=20calc-language=0A=20=20=20=20=20(require=20'calc-ext)=0A=20=20=20= =20=20(calc-set-language=20calc-language=20calc-language-option=20t)))=0A= @@=20-3522,11=20+3523,6=20@@=20math-2-word-size=0A=20(defcalcmodevar=20= math-half-2-word-size=202147483648=0A=20=20=20"One-half=20of=20two=20to=20= the=20power=20of=20`calc-word-size'.")=0A=20=0A-(when=20= calc-always-load-extensions=0A-=20=20(require=20'calc-ext)=0A-=20=20= (calc-load-everything))=0A-=0A-=0A=20(run-hooks=20'calc-load-hook)=0A=20=0A= =20(provide=20'calc)=0A--=20=0A2.39.5=20(Apple=20Git-154)=0A=0A= --Apple-Mail=_1B0BA98B-AF02-4F52-8FA6-4AA36DE9EE31 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.6.0, NS appkit-2575.70 Version 15.6 (Build 24G84)) of 2025-08-02 built on beatrix.local Repository revision: 49e34dede07b2151dadc0e1f71cc4405ba7f42f5 Repository branch: calc-always-load-extensions-fix Windowing system distributor 'Apple', version 10.3.2575 System Description: macOS 15.6 Configured using: 'configure --with-ns --with-modules --with-native-compilation --with-libgmp --with-tree-sitter --with-sqlite3 --with-mps=yes --without-imagemagick --without-dbus CPPFLAGS=-I/opt/homebrew/include LDFLAGS=-L/opt/homebrew/lib PKG_CONFIG_PATH=/opt/homebrew/lib/pkgconfig ac_cv_func_posix_spawn_file_actions_addchdir=no' --Apple-Mail=_1B0BA98B-AF02-4F52-8FA6-4AA36DE9EE31-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 12:47:55 2025 Received: (at 79157) by debbugs.gnu.org; 2 Aug 2025 16:47:55 +0000 Received: from localhost ([127.0.0.1]:37374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiFOl-0004In-Ef for submit@debbugs.gnu.org; Sat, 02 Aug 2025 12:47:55 -0400 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]:60679) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiFOi-0004IV-Le for 79157@debbugs.gnu.org; Sat, 02 Aug 2025 12:47:53 -0400 Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-3e3e926fdeaso10569365ab.1 for <79157@debbugs.gnu.org>; Sat, 02 Aug 2025 09:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1754153267; x=1754758067; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+zwmE4TZV7AAOiy+7N90O2zj2dvYBzi5rMnTExqBbmQ=; b=d2E9cUjbIkTVvVygIbr+4LIYLPRIx/JurNigOuMiZ1p8YL/X2kU4CQMVn6pcZzJju7 pS0rrZ5jZ2lro3f7j50YFGlY0a3yB/xiN/K4RVaMC+00Tu8EqbOa6+zYzDpASljPo06T hYBMPoRiDJ46h+Ee3iggm/UVLEjH3OcDD/XW5o7wjpq9kIJGXgPp/6XoQEYREJ46+4Hn b90fkQRv7b1j688xiK4liFSLo6wCjNRFaJXvMIm661NPEyIoCLucd4FwgxqXWqljHaJQ rXf+sZq3Z9lzu14U1IVpl7FH27xKjF/oeJeWcasp9OEUTsDotnSWqKzOSJLs9b0c8gRA tNCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754153267; x=1754758067; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+zwmE4TZV7AAOiy+7N90O2zj2dvYBzi5rMnTExqBbmQ=; b=sCRg2K/lNaO7ftTWuMHHx6b8yXdJFbItv2lmQd1YKNFk101kh/A4WCqpm2vMMZscDw OE2oQDXQTjgAZi7+Dhx55DvCsrOWnG00au6Q/I3BttiGQG6mnuttMl69tR7TBmgWc17u xxW69Yu84kwA5Peh4J6JejzLmO0FwbGS2t0Cajwb+0CTuaKqYEA4mdPQnbQuAqqiXEDC AmKMqkx4b9J1WRKCIVei6RTVhmPi+smYHo6BlUyTQs6i2Pn2N2h42E+35XkkEOVmw7eR 9t+YnF3l67ODg0M1S8DpKS67a+jWRzm0zMRkd6fp6vCK9TXL1vqRrgemcxVVmpFipq97 KlRQ== X-Gm-Message-State: AOJu0Yxi51YqUqbH4Hn5JQx/9wHgKsdMYRyqtm1R9stLgrcb6/7jm7e3 cS69mjdjvPcfWC/Z7JI8mZqkOm3ZNm6E4FnlZFUch0pXOqRXLa6RmCf71338LKYET5U= X-Gm-Gg: ASbGnctbM775lVI6hcLeOk3LsPp4YAhFMySa3OXNa/ZcBI7Fw2dVs2J0Ot/gk1ZUxph vtgFPKwQWlKIEjVYDCUBccoHnbwSVuR/j6UMAbPLRO6mJf/WwoQnBCLjnehlw2h6CSU4fduDp6G 7JZoNvTfgHC779mPO54NRS59X8RN2viicuhOrGJAgKN8EESyLeeAKF6vGB4PKs893QHwc9Jv2fr LaZtdR+/ue+/DT1iAb7QHrRJ7kLyjQBbU8WFHvyDv0GvAdTIVybvgg2RNRQJ/5kY5E9umDu1/Dt 3KyC+hoKz9mBDRsXLIkKrobSOBL6CloI+R4RWiMSbjfrGRUBho6z62PtzC20fMCjNo3revJtfsy caerPOikkhuS4Oq7dfogM1n/rk2t7APnPFgirBwRAQEhReX7yWVFH39xCFWgPMgBnGzde7OmOKm 7IieKMWzO2s9c= X-Google-Smtp-Source: AGHT+IGj1rgAI/C71clQHMG72OneHpsctKW49Kja7EQcjnPfebN+Wr9PzS8Tr1OGydJR26OzKgXj6A== X-Received: by 2002:a05:6e02:164f:b0:3e3:f90f:85ca with SMTP id e9e14a558f8ab-3e4161257b0mr63201835ab.8.1754153266661; Sat, 02 Aug 2025 09:47:46 -0700 (PDT) Received: from smtpclient.apple (c-67-167-5-111.hsd1.il.comcast.net. [67.167.5.111]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e402acc795sm25372325ab.29.2025.08.02.09.47.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Aug 2025 09:47:46 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH] Fix recursive load when 'calc-always-load-extensions' is set From: Sean Devlin In-Reply-To: Date: Sat, 2 Aug 2025 11:47:35 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Sean Devlin X-Mailer: Apple Mail (2.3826.700.81) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79157 Cc: 79157@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Aug 2, 2025, at 11:31=E2=80=AFAM, Sean Devlin = wrote: >=20 > Hi folks, >=20 > The Calc setting calc-always-load-extensions leads to a recursive load > error if you set it in your init file before loading calc.el. (If you = set it after > loading calc.el, e.g. via calc-settings-file, there is no recursive = error, but > it also doesn=E2=80=99t load the extensions.) >=20 To reproduce the latter issue, i.e. failure to load extensions: 1. Emacs -Q 2. M-x load-library calc RET 3. Evaluate: (setq calc-always-load-extensions t) 4. M-x calc RET 5. Evaluate: (featurep 'calc-aent) The result will be nil. Alternately, by using the settings file: 1. mkdir /tmp/emacs-calc 2. HOME=3D/tmp/emacs-calc emacs 3. M-x calc RET 4. m x 5. m m 6. C-x C-c 7. Repeat steps 2 and 3 8. Evaluate: (featurep 'calc-aent) The result will be nil.=