GNU bug report logs - #79156
igc: igc_xpalloc_ambig SEGV

Previous Next

Full log

Message #26 received at 79156 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, eller.helmut <at> gmail.com, 79156 <at> debbugs.gnu.org
Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV
Date: Sat, 02 Aug 2025 19:30:40 +0200

Pip Cet <pipcet <at> protonmail.com> writes:

> Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>>>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but
>>>> I'm not sure whether there are other callers that rely on this behavior,
>>>> so it's safest to work around it.
>>>
>>> xpalloc handles this case:
>>>
>>>   if (! pa)
>>>     *nitems = 0;
>>
>> Yeah, I'd rather check the other igc variants of xpalloc, to make sure
>> they are compatible with the original, even if no one else uses that
>> particular feature.
>
> That's what I did, I think?
>
> The code above doesn't have any effect unless we run out of memory (even
> then, it won't have an effect if NITEMS is a stack variable in a frame
> that's unwound by memory_full).

Sorry, I'm currently to unconcentrated to follow. I just wanted to say
that it would be good to make the functions are compatible with xpalloc,
whatever that means.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.