From unknown Fri Aug 15 04:03:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79156 <79156@debbugs.gnu.org> To: bug#79156 <79156@debbugs.gnu.org> Subject: Status: igc: igc_xpalloc_ambig SEGV Reply-To: bug#79156 <79156@debbugs.gnu.org> Date: Fri, 15 Aug 2025 11:03:14 +0000 retitle 79156 igc: igc_xpalloc_ambig SEGV reassign 79156 emacs submitter 79156 Gerd M=C3=B6llmann severity 79156 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 11:27:59 2025 Received: (at submit) by debbugs.gnu.org; 2 Aug 2025 15:27:59 +0000 Received: from localhost ([127.0.0.1]:37135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiE9O-0007wy-Jh for submit@debbugs.gnu.org; Sat, 02 Aug 2025 11:27:58 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34072) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiE9M-0007vf-Gt for submit@debbugs.gnu.org; Sat, 02 Aug 2025 11:27:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uiE8a-0002m6-RQ for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2025 11:27:10 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uiE8Z-0001JC-8T for bug-gnu-emacs@gnu.org; Sat, 02 Aug 2025 11:27:08 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-451d3f72391so24880735e9.3 for ; Sat, 02 Aug 2025 08:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754148422; x=1754753222; darn=gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=oemH3VaUtMAhCYTSLLoc4d6NWr8g55hE9TmG5xF0sB8=; b=G5od3IunO0XLUMf/IX6kre+Cr3p09ZqlIhaDfJ9iP7AzUoipeq3Ww4ryOjyIUL881r HxYuV5TuKEqZBErGJ1qiaQt3gxiGlQYNJMpn/Sanh142YO94u9KiYhBQ3irdiSPUrBqo NysCCs0GbVO9qPrD+XceHQtdrCOzujNxwNgeJfRiE2FrIWdqxqBQ92+Fz9HGgaG4NUcA y1XFzZtXWFaPhMkzNwSLWKmbGKiTfYx3JWOjZAuMqOPyoOhv+9XnH1lYV7w8fg0KzRWA 1pu85wl2YiI8spTgER7ZxxcCFLx6POB9IpmvVXQHFb/QHtDmWBOFXzzxtnmNvECJFwRm Ukzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754148422; x=1754753222; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oemH3VaUtMAhCYTSLLoc4d6NWr8g55hE9TmG5xF0sB8=; b=HjiW9EsBif8vzqIGmz2Hs8o7sI03U1V5aSI82erg9vk4G3kzbxh03zgKmd4xJk9gLG iN9DDUz2qNMgjC+MqAkC5RVy0VhfzPP/JKER6ogpL+85BlXlLF2y+MEMuF61RAIzKhp7 MNs8m5oFrr0h7YjxRO/ERrXKDoXKrbAKz0x0wkEmvZslXulsGKJJ7u9VhQ/9IZNr1980 Pf7No7DOsduFTtEQK7tKe/wZ4ZT0D5auol8P6St0HcrqA2Knpaddw740cKgZPVt+nJKh NiDZ1kFqdN+OJLDfYmjhT8bT2BJc1v4PSYeNQT4hR5QdJv0dON6WW1mdgJxUD2mJPcFn KR8A== X-Gm-Message-State: AOJu0Yzi6o7S25Tb7u4lepSrWbochy5lxREvnf3Rld4LSFACRRzUlyRq Aj67+XXDKww1RM3L8tUZRm1akulVBQPiF6ltnQ7DemwppkyChQJfton3 X-Gm-Gg: ASbGnctRO6aducVHPShinMSTYihrl1J7iYm9JYfCsSnC+oeU1ziQnNvYJ/KIHVzg+Nz m2nnowxnng4HKuakrDU8gebeUujRzU0TIlNBY8dOLawIpImvNLum9Q6OVfQfloGT3E+IXsvdZSl 9SHRQqWk2UBEUCMlPLYnA63N1C9yQTzVjel1AlSrsNq/vJWO5ThdrOqEc/d/SEgiDud/RgPna4O HNOoSGci7xGES3RjBGiCMvXL5nKNouARkEmhDvPQgfSsY8frL7n97qmA0BDhA6bW5ewUX8bBklZ TGgseSeE2PrBR69c41j9fc3j3lrFUgAVBPpTAccHsBVcFierjk041YY4bT62pDFpzaLwan//gMC wnBUJCf2u3iih5tbNuxE4EaMpzdhBFXixGcVwzuafvKVYTZE2iZLiVo56Ab34FHytkDMI2gJ8mm LwCqLpgCQf7LBz36lYG8YbbeqemQ== X-Google-Smtp-Source: AGHT+IH64zLWqUpZc++DqRcHwdAnOauCc0MklxUe539kLIht4JPqO55KKfUYsNrClV2cDlQYX9DTLw== X-Received: by 2002:a05:600c:4f41:b0:458:bfe1:4a91 with SMTP id 5b1f17b1804b1-458bfe14d53mr6996605e9.20.1754148421777; Sat, 02 Aug 2025 08:27:01 -0700 (PDT) Received: from pro2 (p200300e0b705810018c4522615e75b34.dip0.t-ipconnect.de. [2003:e0:b705:8100:18c4:5226:15e7:5b34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4589edf56e0sm104546915e9.1.2025.08.02.08.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Aug 2025 08:27:01 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: bug-gnu-emacs@gnu.org Subject: igc: igc_xpalloc_ambig SEGV X-Debbugs-Cc: Date: Sat, 02 Aug 2025 17:26:59 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Pip Cet , Helmut Eller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) We have igc.c: 3465 void * 3466 igc_xpalloc_ambig (void *old_pa, ptrdiff_t *nitems, ptrdiff_t nitems_incr_min, 3467 ptrdiff_t nitems_max, ptrdiff_t item_size) 3468 { 3469 ptrdiff_t old_nitems = *nitems; and igc_xpalloc_ambig is called here with a NULL old_pa, and non-zero new_size: charset.c: 1135 struct charset *new_table = 1136 #ifdef HAVE_MPS 1137 igc_xpalloc_ambig 1138 #else 1139 xpalloc 1140 #endif 1141 (0, &new_size, 1, 1142 min (INT_MAX, MOST_POSITIVE_FIXNUM), 1143 sizeof *charset_table); In this case, this loop deferences a null pointer. igc.c: 3477 mps_word_t *new_word = new_pa; 3478 for (ptrdiff_t i = 0; i < (old_nitems * item_size) / sizeof (mps_word_t); i++) 3479 new_word[i] = old_word[i]; This apparently currently never happens in feature/igc, but it could, and it does when using igc with emacs-mac's mac-win.el which defines charsets. Quick workaround is something like modified src/igc.c @@ -3466,7 +3466,7 @@ igc_xfree (void *p) igc_xpalloc_ambig (void *old_pa, ptrdiff_t *nitems, ptrdiff_t nitems_incr_min, ptrdiff_t nitems_max, ptrdiff_t item_size) { - ptrdiff_t old_nitems = *nitems; + ptrdiff_t old_nitems = old_pa == NULL ? 0 : *nitems; ptrdiff_t new_nitems = *nitems; ptrdiff_t nbytes = xpalloc_nbytes (old_pa, &new_nitems, nitems_incr_min, nitems_max, item_size); Likewise in other igc_xpalloc variants, and one could exploit old_pa == NULL, and so on. If someone else has the time to fix this, that would be nice because I'm doing something else ATM. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 12:00:37 2025 Received: (at 79156) by debbugs.gnu.org; 2 Aug 2025 16:00:37 +0000 Received: from localhost ([127.0.0.1]:37238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiEey-0001cg-JY for submit@debbugs.gnu.org; Sat, 02 Aug 2025 12:00:37 -0400 Received: from mail-10629.protonmail.ch ([79.135.106.29]:64165) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiEev-0001c5-SD for 79156@debbugs.gnu.org; Sat, 02 Aug 2025 12:00:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1754150426; x=1754409626; bh=bXFxfElH3bpgjwA3wjhqwL2GDC1d4m+3b5D9LUYpS+s=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=v2m0tSAHY1n53TzyOFKKyQJlAfD+r05z14pNG7faT+jEwLsVQ+KfP5a5hQSzDagvR Akh3Y12B1HII8K9wkLz3DwagZvkZ7ofZSSAUy4G7IYgqov9ibLPKY1RweaUmjSDi4c ZllcV+mbv/rOZwKqqXWp8/pQFRzGADSNln3/NVCYlJD42hx7qcih0Tdfdv2pNbV7J9 vg4gciy+y85ltb0gbbf00WBx5qravxswMXJSUpIWujLYjjVIlWFm+iCMIJ0vEpZ3EA 6xeotyl7unen9RQ8emb/Z88d6NNyFr5ogtJ6xGyN+R2K4WLvCOBYlc9Fy7Kp2Oy4Qy L3K8BWQQT1HSA== Date: Sat, 02 Aug 2025 16:00:23 +0000 To: =?utf-8?Q?Gerd_M=C3=B6llmann?= From: Pip Cet Subject: Re: igc: igc_xpalloc_ambig SEGV Message-ID: <87ldo1btow.fsf@protonmail.com> In-Reply-To: References: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 952ad1186c4d6f410d45f2a99062536e946e3491 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Helmut Eller , 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann writes: > We have > > igc.c: > 3465 void * > 3466 igc_xpalloc_ambig (void *old_pa, ptrdiff_t *nitems, ptrdiff_t nitem= s_incr_min, > 3467 ptrdiff_t nitems_max, ptrdiff_t item_size) > 3468 { > 3469 ptrdiff_t old_nitems =3D *nitems; > > and igc_xpalloc_ambig is called here with a NULL old_pa, and non-zero > new_size: > > charset.c: > 1135 struct charset *new_table =3D > 1136 #ifdef HAVE_MPS > 1137 igc_xpalloc_ambig > 1138 #else > 1139 xpalloc > 1140 #endif > 1141 (0, &new_size, 1, > 1142 min (INT_MAX, MOST_POSITIVE_FIXNUM), > 1143 sizeof *charset_table); > > In this case, this loop deferences a null pointer. > > igc.c: > 3477 mps_word_t *new_word =3D new_pa; > 3478 for (ptrdiff_t i =3D 0; i < (old_nitems * item_size) / sizeof (mp= s_word_t); i++) > 3479 new_word[i] =3D old_word[i]; > > This apparently currently never happens in feature/igc, but it could, > and it does when using igc with emacs-mac's mac-win.el which defines > charsets. Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but I'm not sure whether there are other callers that rely on this behavior, so it's safest to work around it. (Of course, the reason for the static charset_table_init variable was unexec, and now that reason is gone we should just remove it and use plain xpalloc) > Quick workaround is something like > > modified src/igc.c > @@ -3466,7 +3466,7 @@ igc_xfree (void *p) > igc_xpalloc_ambig (void *old_pa, ptrdiff_t *nitems, ptrdiff_t nitems_inc= r_min, > =09=09 ptrdiff_t nitems_max, ptrdiff_t item_size) > { > - ptrdiff_t old_nitems =3D *nitems; > + ptrdiff_t old_nitems =3D old_pa =3D=3D NULL ? 0 : *nitems; > ptrdiff_t new_nitems =3D *nitems; > ptrdiff_t nbytes =3D xpalloc_nbytes (old_pa, &new_nitems, nitems_incr_= min, > =09=09=09=09 nitems_max, item_size); LGTM. > Likewise in other igc_xpalloc variants, and one could exploit old_pa =3D= =3D > NULL, and so on. Do we need it for those? > If someone else has the time to fix this, that would be nice because I'm > doing something else ATM. I'll push this if there are no objections. commit 962e9be111402e1c83c418bea9e75f23a423ccc6 (HEAD) Author: Pip Cet Date: Sat Aug 2 15:51:13 2025 +0000 [MPS] Avoid segfaults for some inconsistent arguments in igc_xpalloc =20 Fdefine_charset_internal calls igc_xpalloc with a NULL pointer as OLD_PA and a non-zero *NITEMS value. =20 * src/igc.c (igc_xpalloc_ambig): (igc_xpalloc_exact): (igc_xpalloc_lisp_objs_exact): Handle OLD_PA =3D=3D NULL, *NITEMS !=3D = 0. diff --git a/src/igc.c b/src/igc.c index f3c98fbe49c..4eb57a3072b 100644 --- a/src/igc.c +++ b/src/igc.c @@ -3473,7 +3473,7 @@ igc_xfree (void *p) igc_xpalloc_ambig (void *old_pa, ptrdiff_t *nitems, ptrdiff_t nitems_incr_= min, =09=09 ptrdiff_t nitems_max, ptrdiff_t item_size) { - ptrdiff_t old_nitems =3D *nitems; + ptrdiff_t old_nitems =3D old_pa ? *nitems : 0; ptrdiff_t new_nitems =3D *nitems; ptrdiff_t nbytes =3D xpalloc_nbytes (old_pa, &new_nitems, nitems_incr_mi= n, =09=09=09=09 nitems_max, item_size); @@ -3496,7 +3496,7 @@ igc_xpalloc_exact (void **pa_cell, ptrdiff_t *nitems, =09=09 void *closure) { void *old_pa =3D *pa_cell; - ptrdiff_t old_nitems =3D *nitems; + ptrdiff_t old_nitems =3D old_pa ? *nitems : 0; ptrdiff_t new_nitems =3D *nitems; ptrdiff_t nbytes =3D xpalloc_nbytes (old_pa, &new_nitems, nitems_incr_mi= n, =09=09=09=09 nitems_max, item_size); @@ -3556,7 +3556,7 @@ igc_xpalloc_lisp_objs_exact (Lisp_Object *pa, ptrdiff= _t *nitems, =09=09=09 ptrdiff_t nitems_incr_min, ptrdiff_t nitems_max, =09=09=09 const char *label) { - ptrdiff_t nitems_old =3D *nitems; + ptrdiff_t nitems_old =3D pa ? *nitems : 0; ptrdiff_t nitems_new =3D nitems_old; ptrdiff_t nbytes =3D xpalloc_nbytes (pa, &nitems_new, nitems_incr_min, nitems_max, word= _size); Pip From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 12:27:38 2025 Received: (at 79156) by debbugs.gnu.org; 2 Aug 2025 16:27:38 +0000 Received: from localhost ([127.0.0.1]:37304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiF57-00037m-OD for submit@debbugs.gnu.org; Sat, 02 Aug 2025 12:27:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34420) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiF54-00037M-Jk for 79156@debbugs.gnu.org; Sat, 02 Aug 2025 12:27:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uiF4z-0000Er-36; Sat, 02 Aug 2025 12:27:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lpNJ2zkPXBOzlcJRgu0Xq5JIxXd4kdDZxJ25vAO+hus=; b=ZY8d/aOdTR6rZFG8pWWO 63Uruj729lDZ2PcbJnYhA+UnMlNj8hH36iauQAzY3w73ab1c+1nsDNsSqzeR4QZQxQjD5h4Me/cI0 y9jxMYyYqEL284pN/7yGoDYEztw1eRMW8KkrzhIKpWVkQfd3TYS+2Ale1iWCmBtouqzvIt7wg/S61 mPdYsBWemHFEWOdIjSP8B4trSzQK9CWtUfJQqrENAh7tq/6A9KMItmc1n+9iy4B31Dub+5I0IIr3d ZSE4L3ODwUJnObvgw5Y9/7iS1JZOVCaBmdyYSRK4JdXWonhACW4skiJUOpR/v+g+faWeBTEqi3t1S 0WBqZmdOBCTl+A==; Date: Sat, 02 Aug 2025 19:27:27 +0300 Message-Id: <865xf5r8nk.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet In-Reply-To: <87ldo1btow.fsf@protonmail.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV References: <87ldo1btow.fsf@protonmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79156 Cc: gerd.moellmann@gmail.com, eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Helmut Eller , 79156@debbugs.gnu.org > Date: Sat, 02 Aug 2025 16:00:23 +0000 > From: Pip Cet via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Gerd Möllmann writes: > > > We have > > > > igc.c: > > 3465 void * > > 3466 igc_xpalloc_ambig (void *old_pa, ptrdiff_t *nitems, ptrdiff_t nitems_incr_min, > > 3467 ptrdiff_t nitems_max, ptrdiff_t item_size) > > 3468 { > > 3469 ptrdiff_t old_nitems = *nitems; > > > > and igc_xpalloc_ambig is called here with a NULL old_pa, and non-zero > > new_size: > > > > charset.c: > > 1135 struct charset *new_table = > > 1136 #ifdef HAVE_MPS > > 1137 igc_xpalloc_ambig > > 1138 #else > > 1139 xpalloc > > 1140 #endif > > 1141 (0, &new_size, 1, > > 1142 min (INT_MAX, MOST_POSITIVE_FIXNUM), > > 1143 sizeof *charset_table); > > > > In this case, this loop deferences a null pointer. > > > > igc.c: > > 3477 mps_word_t *new_word = new_pa; > > 3478 for (ptrdiff_t i = 0; i < (old_nitems * item_size) / sizeof (mps_word_t); i++) > > 3479 new_word[i] = old_word[i]; > > > > This apparently currently never happens in feature/igc, but it could, > > and it does when using igc with emacs-mac's mac-win.el which defines > > charsets. > > Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but > I'm not sure whether there are other callers that rely on this behavior, > so it's safest to work around it. xpalloc handles this case: if (! pa) *nitems = 0; Regarding the code in charset.c, it happened when xpalloc was added there, see commit 0065d05491ce. The original code called xmalloc and then copied the table. The FIXME comment at the end of the block tries to explain why the obvious solution of passing &charset_table as the first argument to xpalloc was not taken: we were not sure this is not on purpose. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 12:41:30 2025 Received: (at 79156) by debbugs.gnu.org; 2 Aug 2025 16:41:30 +0000 Received: from localhost ([127.0.0.1]:37349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiFIX-0003xZ-J3 for submit@debbugs.gnu.org; Sat, 02 Aug 2025 12:41:29 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:50249) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiFIV-0003x5-5Y for 79156@debbugs.gnu.org; Sat, 02 Aug 2025 12:41:27 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-458bb0e692cso3617545e9.0 for <79156@debbugs.gnu.org>; Sat, 02 Aug 2025 09:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754152881; x=1754757681; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2k0wBGZfDWbWcwrQixSOI2PoQb2f94oHWJ0lqQjOIsI=; b=iYEAciP6HsZqJ+CYwqUHjK5g7pLcMrqfhMD8nED/Pz27NBzZP4NtTlV2jW7V6IjQX0 9PqtctB/DkLcjiN5lNokJtr2VerDjcgLOmLlpRNOgtcEcToQZXfaScOmo7hYwk48ezya Y1dZJFsfmD8I1aWa386gXJgCAIsvuQJhNSwyiZvIv+GV8Zj0xc16qYEJVieyJXvla0mn zcH7JRpGyV9oqbCFyAbphi9yoVBevE7kv2msEJFWYRGPUG2kZ0KSgtCfrZ9c/SdpQ3xi CLO2sWuR5ZAFFkiY/0cztYlcv8xDJnSmOqFRSo47OJmUxYu0CopbPidp3vZ3C9f4LaSj bEsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754152881; x=1754757681; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2k0wBGZfDWbWcwrQixSOI2PoQb2f94oHWJ0lqQjOIsI=; b=jbYFDLil5ZtHjI8IKjhja4FK2rjWJBV4hIaZ/++lzY2BMnJ4LDt+h3JS6HS+g8slLO OBsSwxE1743x97RwiKb9gRnyUZgQHrthLMbQBHQJXx4Z4P8EDNcrhLoIoo8nKEWj+q2b RBjtCzg8a1AQ79zeXW/7B7QEFu5UlWf2HwsI+kidQ5ezW/JH3KH8WjrBe/h45jjZxlW7 s6UkUBbG+MUU7BeLVXHEzBwa1SSHIRbix9kJBXyNlRsbMZ+LqDczNWutwC51hhYs2lyb f8BDkk4fGGa3ii9AgP/jIBJFvS/bidctA9LvEf7MJsOO6QIlysXxxMZ3BBiCKn4/X0iZ 936w== X-Forwarded-Encrypted: i=1; AJvYcCX3aGqrsU21lpsrgp7r2JYXefa4k7rzytH7e48QYQyDM+WFgMjF93A6RfT+TqlvHHvTeWEMpQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzoIf+1+bp8hqpA7nCpy7fQCvbyYhnkqzP7cZTCil6i6p3WtFzc sS1GLhGoTqrP8WoIyS/+a5cTAOui7aFatljjrbuRTwqAVJ2+y5lH3kEARxI6h8wb X-Gm-Gg: ASbGncsQxVbFcLtZBIVlkAmDjqp9aTIc7/eIWMn5u5XMd6rlra0/GZBFICXRyp5bwN0 o0SFdNAr8fA4+P/RJK63MD9kj4kmDFxGNK2ggrCJdLiB0BmxmhP6qtMFEYMjKN6SBBFT33LbHyv 7CfrfPcv3mVHBO6MTkCO5bnUoknXPw7yAaQVRyIVJX3HLPF2Y1uWCv0lBrl8jVZTuZ+E9fIu7sM R0iQxq+5vrAZg/9xRr8MewDKTcAf8vCjlV5YuW36/QS8JA1mF0ANW9ksfzt7P7p0gmdEpH5Z74D mOrhom++AvVbyCl5fHifzSphUDH52Dj89VnVpq6a5e0yG/xLNaxzorDxATOg+HpKxtwjCeCLxmJ tuveFXL+ZUsE7TwLBn83Cc+hUlt0JakTWZuvWhumgdgoxASoPjiw6ue5Wt/Im+/7eZ1hp5b5dQ0 +cU31gfdHJ6VkX6Ww0Cz9tshFRRg== X-Google-Smtp-Source: AGHT+IGbNMDtzc8bW/iatfOyO/D0su4T4ey1mujAepeVWLc6IVweBUKeYsWCTJY6U3FXhSS83DHuZQ== X-Received: by 2002:a05:600c:3b87:b0:453:c39:d0a7 with SMTP id 5b1f17b1804b1-458b69ca0bbmr25840915e9.5.1754152880511; Sat, 02 Aug 2025 09:41:20 -0700 (PDT) Received: from pro2 (p200300e0b705810018c4522615e75b34.dip0.t-ipconnect.de. [2003:e0:b705:8100:18c4:5226:15e7:5b34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c47908esm9634016f8f.59.2025.08.02.09.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Aug 2025 09:41:20 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Eli Zaretskii Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV In-Reply-To: <865xf5r8nk.fsf@gnu.org> References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> Date: Sat, 02 Aug 2025 18:41:19 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Pip Cet , eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but >> I'm not sure whether there are other callers that rely on this behavior, >> so it's safest to work around it. > > xpalloc handles this case: > > if (! pa) > *nitems = 0; Yeah, I'd rather check the other igc variants of xpalloc, to make sure they are compatible with the original, even if no one else uses that particular feature. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 13:07:50 2025 Received: (at 79156) by debbugs.gnu.org; 2 Aug 2025 17:07:50 +0000 Received: from localhost ([127.0.0.1]:37430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiFi1-0005SL-QO for submit@debbugs.gnu.org; Sat, 02 Aug 2025 13:07:50 -0400 Received: from mail-24418.protonmail.ch ([109.224.244.18]:59955) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiFhz-0005S3-6U for 79156@debbugs.gnu.org; Sat, 02 Aug 2025 13:07:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1754154460; x=1754413660; bh=ayKY4Wk9FCg0+zdlWF5nEiwE0Yx5l2WcL0Z7VLYHVxU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=bXEy3v7+4Uwj9fziZdZzSFj/K2pA1/6nZJv5N6vC4KVZFDO0uFwIrdRExK4sNg/MC zLhfYhs74+AtDSpk0J6hCqAXK3unEyfoll4pMdjHU18OUBQX0JlL/d7scDsLXVA4vg 7y+2OY6bgm+aBacQn13v0N7Qub2oIqmk1OBgbJkDh17F1xkGkoWZkywKU45CAcDWGX Ma0Gfl7tygUi8gX8sXR4t7cncfDtmo0ypU8KTUyYgUOpPU+qqAbHKzjCwGtKk+djMq uDgOiUqXTL1Z2T7uiqI6ZrNzPALFmpFOdcbAvdXhRnHEz24LSqIglXild6obbQVwEJ 1xI7R6dpG7lBA== Date: Sat, 02 Aug 2025 17:07:35 +0000 To: =?utf-8?Q?Gerd_M=C3=B6llmann?= From: Pip Cet Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV Message-ID: <87cy9dbqku.fsf@protonmail.com> In-Reply-To: References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 8bb2d60921e5e6e4195e79bacb79586c334b41e1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Eli Zaretskii , eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann writes: > Eli Zaretskii writes: > >>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but >>> I'm not sure whether there are other callers that rely on this behavior= , >>> so it's safest to work around it. >> >> xpalloc handles this case: >> >> if (! pa) >> *nitems =3D 0; > > Yeah, I'd rather check the other igc variants of xpalloc, to make sure > they are compatible with the original, even if no one else uses that > particular feature. That's what I did, I think? The code above doesn't have any effect unless we run out of memory (even then, it won't have an effect if NITEMS is a stack variable in a frame that's unwound by memory_full). However, xrealloc does handle the case, and evxprintf relies on that, so we shouldn't change anything further at this point. The FIXME comment in charset.c should be amended to point out that charset_table usually lives in the pdump, and xpalloc does not like pdumper object pointers, so we'd have to check that before freeing charset_table. Pip From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 13:13:52 2025 Received: (at 79156) by debbugs.gnu.org; 2 Aug 2025 17:13:52 +0000 Received: from localhost ([127.0.0.1]:37489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiFnr-0005op-TT for submit@debbugs.gnu.org; Sat, 02 Aug 2025 13:13:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54034) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiFnp-0005oc-P3 for 79156@debbugs.gnu.org; Sat, 02 Aug 2025 13:13:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uiFnk-0005X6-6L; Sat, 02 Aug 2025 13:13:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Xq5Ovt18eHTkq4x0AUOdoTAw7Us9F3qiGNLXEcdOHAI=; b=Um5bCBtJf8NBks2sOu78 U0WsDuhiIPB0q0QBk8Nf/uG1JT8OIgNoRkZoOVJUuzdBDdDmSq6FomkhVjNvIvOYfsdjFJS44x/eH R6hFMcTs4LfBKTHeVAXPGCMH99jX3mSj2o1qzTInkASWNyWQGLh1JtlNS9mpHK/Qd+b95BihBIoeO KL3d+v9qZeMpJXbGGvZhDgpaLlDTHce5AQVHcHJc1fv7VGg83/JUAKZO8Rqqvq0f46aJpTi7KZ/iD csalIULcu4CHlIW/MRcBA5u/iviwxwHyln2SILTJBjMTiQ4IIw9BqzqeZFgDjfQWTEPAidEDZZM7p i59rlCEmotsaFQ==; Date: Sat, 02 Aug 2025 20:13:41 +0300 Message-Id: <8634a9r6ii.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet In-Reply-To: <87cy9dbqku.fsf@protonmail.com> (message from Pip Cet on Sat, 02 Aug 2025 17:07:35 +0000) Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79156 Cc: gerd.moellmann@gmail.com, eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 02 Aug 2025 17:07:35 +0000 > From: Pip Cet > Cc: Eli Zaretskii , eller.helmut@gmail.com, 79156@debbugs.gnu.org > > Gerd Möllmann writes: > > > Eli Zaretskii writes: > > > >>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but > >>> I'm not sure whether there are other callers that rely on this behavior, > >>> so it's safest to work around it. > >> > >> xpalloc handles this case: > >> > >> if (! pa) > >> *nitems = 0; > > > > Yeah, I'd rather check the other igc variants of xpalloc, to make sure > > they are compatible with the original, even if no one else uses that > > particular feature. > > That's what I did, I think? > > The code above doesn't have any effect unless we run out of memory (even > then, it won't have an effect if NITEMS is a stack variable in a frame > that's unwound by memory_full). The code above in xpalloc doesn't have anything to do with running out of memory, because it tests the value of the argument passed to xpalloc before calling xrealloc. > The FIXME comment in charset.c should be amended to point out that > charset_table usually lives in the pdump, and xpalloc does not like > pdumper object pointers, so we'd have to check that before freeing > charset_table. If this is the reason, then there's no reason to call xpalloc in the first place, right? We could call xmalloc instead, since we already memcpy the old table to the newly-allocated memory. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 13:24:48 2025 Received: (at 79156) by debbugs.gnu.org; 2 Aug 2025 17:24:49 +0000 Received: from localhost ([127.0.0.1]:37521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiFyS-0006SV-Fh for submit@debbugs.gnu.org; Sat, 02 Aug 2025 13:24:48 -0400 Received: from mail-10631.protonmail.ch ([79.135.106.31]:36285) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiFyP-0006Rv-Uy for 79156@debbugs.gnu.org; Sat, 02 Aug 2025 13:24:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1754155479; x=1754414679; bh=rMvFYKFn3x6eTd7PYboC6xVt58RiIf/60P+H1TMufx0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=HojqRDJlTNxhbx7jQdgm/M4vKSlC1E9ziH7/Bob6j8IN2cNXCM/MraN447q5mjZWM G1GA0Ug4cYnTPKlcCz9vezlrMt8CW03Q6JbdrPUyhdXGCML5IA8OxPnF//Gd2vjerA xThjLpikrXH4A9ThV4aSwIjvFq0AY3v2qo0D2GVn9oe0tmEs5oJCYDt09xSSubn8qM oCWLBUGVZfuyr9YD0nZHaeN1wcjMmYOC6Se1ZOrApYsCApsgMHEk91NAhETPXa5ibW swKhpxbYLRO5O7z7tYmXi0WWoTgSIRE9FPALCcfeXkehQcUpzili85dhK7maUDkLMa M/wjmc61YUGfQ== Date: Sat, 02 Aug 2025 17:24:35 +0000 To: Eli Zaretskii From: Pip Cet Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV Message-ID: <877bzlbpsj.fsf@protonmail.com> In-Reply-To: <8634a9r6ii.fsf@gnu.org> References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> <8634a9r6ii.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 2971d1841c1bb105808dc8dce85b95c77faedf29 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 79156 Cc: gerd.moellmann@gmail.com, eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Eli Zaretskii" writes: >> Date: Sat, 02 Aug 2025 17:07:35 +0000 >> From: Pip Cet >> Cc: Eli Zaretskii , eller.helmut@gmail.com, 79156@debbugs.= gnu.org >> >> Gerd M=C3=B6llmann writes: >> >> > Eli Zaretskii writes: >> > >> >>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, b= ut >> >>> I'm not sure whether there are other callers that rely on this behav= ior, >> >>> so it's safest to work around it. >> >> >> >> xpalloc handles this case: >> >> >> >> if (! pa) >> >> *nitems =3D 0; >> > >> > Yeah, I'd rather check the other igc variants of xpalloc, to make sure >> > they are compatible with the original, even if no one else uses that >> > particular feature. >> >> That's what I did, I think? >> >> The code above doesn't have any effect unless we run out of memory (even >> then, it won't have an effect if NITEMS is a stack variable in a frame >> that's unwound by memory_full). > > The code above in xpalloc doesn't have anything to do with running out > of memory, because it tests the value of the argument passed to > xpalloc before calling xrealloc. Here's the code: if (! pa) *nitems =3D 0; if (n - n0 < nitems_incr_min && (ckd_add (&n, n0, nitems_incr_min) =09 || (0 <=3D nitems_max && nitems_max < n) =09 || ckd_mul (&nbytes, n, item_size))) memory_full (SIZE_MAX); pa =3D xrealloc (pa, nbytes); *nitems =3D n; Since the final line sets *NITEMS unconditionally, the first two lines have no effect unless we either call memory_full or xrealloc exits nonlocally, which it does only if we run out of memory. So to say the code you quoted "doesn't have anything to do with running out of memory" seems incorrect to me; it has an effect only if we run out of memory. >> The FIXME comment in charset.c should be amended to point out that >> charset_table usually lives in the pdump, and xpalloc does not like >> pdumper object pointers, so we'd have to check that before freeing >> charset_table. > > If this is the reason, then there's no reason to call xpalloc in the > first place, right? We could call xmalloc instead, since we already > memcpy the old table to the newly-allocated memory. I think the point is only to reuse the larger-buffer-size calculation xpalloc performs. There are probably cleaner ways of doing that. Pip From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 13:30:52 2025 Received: (at 79156) by debbugs.gnu.org; 2 Aug 2025 17:30:52 +0000 Received: from localhost ([127.0.0.1]:37558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiG4J-0006uc-QX for submit@debbugs.gnu.org; Sat, 02 Aug 2025 13:30:52 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:54701) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiG4H-0006uF-4T for 79156@debbugs.gnu.org; Sat, 02 Aug 2025 13:30:49 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-458b49c98a7so7109315e9.1 for <79156@debbugs.gnu.org>; Sat, 02 Aug 2025 10:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754155843; x=1754760643; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ng15KAuC3z72tArG85kavt6k6aRD87t4VvvRHh3uhqE=; b=N7yUKqHGbdBBS6q4TlrVaQn8UyGf0gtIEMMbi9DMj694sfAJ063IakZhgtY+PI4hZ2 e95dvfEoIGLpp+cTLaC1ui6L47R17R8sQi8i/uSicIILP/Q+b1PnaCynqY43VroE9PmE 2gfpIFsrACX89rc7yi+IiMe0xMpYQhPvxI24JsfR7C8jIALy7OAHMypP7xM6B56sqjdD hAXSyjtYFuoWrqDhv1/+92UWCrLsNvOBTl7zkRzkC9PfoNx1CV5RHXPo1m+PBSJJPtDY kSyxyqOjYVTsZKZc9PV49cRyNAALQrlYqzbC2eW2DQkUBPYMOq+X2vtKiXvOZRE5tKEZ wkhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754155843; x=1754760643; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ng15KAuC3z72tArG85kavt6k6aRD87t4VvvRHh3uhqE=; b=Ndf2rHlOzasg1eFUuv9UWW5YKPh+THGuHEFBQF/2aWx9ggiEyk6wAbw59auwLw0+4d wjOoLna1m1y/IGZgs5eZ/rl7eA/PgWnq5w5jp71h3Xb5YDOvuyZVtJsV45WuS3neQZ9A tQy0HCgwfyiGtMNV20atJfzGDBMlNKtVgtOATOJH322tfT9P1NczS5HmpplzG/AEiZXI wP2BvmDKk32zJYPj5Bo3Zu08h/8toDqHQEFPdEmQI4bPRxqR/7H2Upwvb5pQqrdeyc3o Xye2BF6mkVgn2mt27Zt8r3XIEU2tca0hGXjN+nzZTDlf1nKqbimI43gZib98lpuu/tRi t+Mg== X-Forwarded-Encrypted: i=1; AJvYcCWQXU3sfbNVM1qGxafuYKfw5UrJdYHn8QANN3tttuXdOB2aQwRPfXdebgaX8lKw5dODAYB7Zg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzwa2oTlVo2zGhQM8X8Km5Cp60Sh+g4o2UgZbn/IQn8iVVY7kxL QFawm1LVHy09reQpgnvoExtcJU3mJOFpYlUs8zbyvd8glGqGozyzmz2a46DMPrGo X-Gm-Gg: ASbGncvyPGZc/PF462Rrxl7F94TPRQTLJP4HYNNNxTTVknMy8Af7FqO2BZo/goaZ2cn d0v20QfdFZRdrCnVljTFdyPjQB+KlGQevh15+72iCwyG3jXsGSQ7rIWEc0G3Mj7k4/VJ7p4GHw3 93AqgGvNdD1SnX7/9dCbVSk/YEcnUfSIzH568AE7KRGpOro/fX8R0Pz0oPeXJzID+iFdxtPN6ct d89rO2D73egdRH5amizn/9Wj/mvLqif4txN3F+T3A6yWMhbGTy6c19/yxB2RDVY68ZjF27vSVyr yEM+CL02Xct0UfXwdPzgto7UGxtZoeeAmV6gEjH8cU8jOdzMWtwN3wE2p7Y4Rmlgwi4VNKUWwMn fxyPhc9QKOuR1ehywdFdPtAhL6U+0g314XPuAzbNSv2V6yw/hooGvEXyVVK28kisuLAInKKjEb8 yxQxDR/0w64qmn7DStfpqc94DeTQu7+ESxhaYV X-Google-Smtp-Source: AGHT+IGGv5ldj3LIcA26Ev9+pDs2OOb+1Trdp0+gGReGKecMkjpoPUB9q33xwqlVWvlVewIl6KCdTQ== X-Received: by 2002:a05:600c:1c98:b0:43c:f629:66f4 with SMTP id 5b1f17b1804b1-458b6872fedmr29892505e9.0.1754155842513; Sat, 02 Aug 2025 10:30:42 -0700 (PDT) Received: from pro2 (p200300e0b705810018c4522615e75b34.dip0.t-ipconnect.de. [2003:e0:b705:8100:18c4:5226:15e7:5b34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458a7c91c0esm85219875e9.11.2025.08.02.10.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Aug 2025 10:30:42 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Pip Cet Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV In-Reply-To: <87cy9dbqku.fsf@protonmail.com> References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> Date: Sat, 02 Aug 2025 19:30:40 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Eli Zaretskii , eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > Gerd M=C3=B6llmann writes: > >> Eli Zaretskii writes: >> >>>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but >>>> I'm not sure whether there are other callers that rely on this behavio= r, >>>> so it's safest to work around it. >>> >>> xpalloc handles this case: >>> >>> if (! pa) >>> *nitems =3D 0; >> >> Yeah, I'd rather check the other igc variants of xpalloc, to make sure >> they are compatible with the original, even if no one else uses that >> particular feature. > > That's what I did, I think? > > The code above doesn't have any effect unless we run out of memory (even > then, it won't have an effect if NITEMS is a stack variable in a frame > that's unwound by memory_full). Sorry, I'm currently to unconcentrated to follow. I just wanted to say that it would be good to make the functions are compatible with xpalloc, whatever that means. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 03 08:52:58 2025 Received: (at 79156) by debbugs.gnu.org; 3 Aug 2025 12:52:58 +0000 Received: from localhost ([127.0.0.1]:43121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiYCv-0002Um-GX for submit@debbugs.gnu.org; Sun, 03 Aug 2025 08:52:57 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:47450) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiYCs-0002UN-B9 for 79156@debbugs.gnu.org; Sun, 03 Aug 2025 08:52:56 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4589b3e3820so36793865e9.3 for <79156@debbugs.gnu.org>; Sun, 03 Aug 2025 05:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754225568; x=1754830368; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lduu1moZ6Gz7PuE/Mr89lRigMnNssa7J1EuL8st1H9w=; b=mWUmyozIimaLeODjlaSHXhOZ366P5oMY2MFaE/L9Sj12xuWLeGL4kHuU6G6FJvwbNG GkLns3IM+bOwfO9g6Af4WvMNVSQC+1om20tP3bmJ/Et/Ffowe8dbq5FnYucx/S1YXZH7 feJ+gUQ6xOF8K+mBBCllzMmONHHpX8InZawsuM6Shf/ND830xIZIjp/pJXVgBbBGHCz0 A868UpGAgtEQH4WdyiweXD4uWKEbYmX5vcqHMr6icZUdhcHrbq4JqcOsHyBw55UviMcg dUXAlt9FIgX35YRPcH4yxW7bX/Vo0MHxaIzhW5V2kyRL5xUK1SQRjg2DFg1TV4UBv7Xv 61sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754225568; x=1754830368; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lduu1moZ6Gz7PuE/Mr89lRigMnNssa7J1EuL8st1H9w=; b=osk85KYpuRytWxzSaNSB0aUqwXXFOSxaM748BjGKskZGrItODCEQdEZ1pTmk/ml3Fm caDlbKR1PwG0u2uNcRgEXkyMzeQIYwle9NxWu5Twa40i0S4VBzvM0oRfpbNMiNbTGiP4 Glo4aC8kQqomlEOjqY5q1XLKi1NfGm+9x0we1Vb+BjWlRWzdz+S65ZXllY8qFgppigS7 ouRApYVQoN3pRK9VyOeWn6uJ2djF3ri6X3gsLEFmHHwXImKTrfLsuONqgikgdFUVtLhH Y+xB25CksGMPo40/DHvEX+04FBUJX34dyZDqYipxYXwqJ/m/5ktVO4e8lOl3GLiqfmQ4 SR4g== X-Forwarded-Encrypted: i=1; AJvYcCVhYBu2/ObEHz+OJiwK1syW/l5VPtMxi0uiAr3cSD2yuTFT7TOWiYRgaQD0goF60eWRa4cF+Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwVcJmlulRd24/STpJZo+8g2NKnIq1+ombvgquDXlUx6ySnlJtu OG5NHKHNTmxZrMHryjnIGteWmPKaaQRRtKgWE/D1KuhZloyyvR+f3TpyGiizCGFC X-Gm-Gg: ASbGncv8hpy2eoAorhIXooEx3aZAB2a+Fz1H3zI2YUrob/AC3TrN0TnoSK0CTSZzCT3 3t64Vk/Y5CLb40GQiByyo4FBP5lakpuZdtmiWgg0NoHFbTi9qKNJHb6Xwf1H8td4J1Se7AEJYyQ G2y4s3fSehkDlxZQHU6EYNH7b4Zc8pMhjar1VPyv2VuSg6WLimqOj9E3FqJL89+8MZGAuVoLAqT Y3S5blIezvTFZKNksQtdwxYx1jZrVakX9TqYj4u6o2TMjm+TtkmQNEopOuS+apx9V+5l813fH9e 2QgzlkA7y2UEFXYr6VZoWj2hxraEswHNDqRzLhbRIV0vE+6/hEnEpj/Z/RsrN4+aIrFRD5KVJzv Pboci8RQ7tbmgSPXK4C01ZWfbN6aXDoNlAmM8fvKGGeYtRvQqjRGZoVCthDi7cJz1+8Y7BewOF2 XSHUXf9YVyUi9PQheko4XqAluQ X-Google-Smtp-Source: AGHT+IEayQi2gWC59BjmV9F2PBxnQDlfCwJjVFS87AETh9rPDay4O5Gu4oVti/UFY+JWnPgk464zkA== X-Received: by 2002:a5d:64cb:0:b0:3b7:83c0:a9ab with SMTP id ffacd0b85a97d-3b8d94ce6damr4685674f8f.55.1754225567615; Sun, 03 Aug 2025 05:52:47 -0700 (PDT) Received: from pro2 (p200300e0b70e8b002124748d09eedd4d.dip0.t-ipconnect.de. [2003:e0:b70e:8b00:2124:748d:9ee:dd4d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458953cfcc1sm179513795e9.17.2025.08.03.05.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Aug 2025 05:52:47 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Pip Cet Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV In-Reply-To: References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> Date: Sun, 03 Aug 2025 14:52:45 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Eli Zaretskii , eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann writes: > Pip Cet writes: > >> Gerd M=C3=B6llmann writes: >> >>> Eli Zaretskii writes: >>> >>>>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, but >>>>> I'm not sure whether there are other callers that rely on this behavi= or, >>>>> so it's safest to work around it. >>>> >>>> xpalloc handles this case: >>>> >>>> if (! pa) >>>> *nitems =3D 0; >>> >>> Yeah, I'd rather check the other igc variants of xpalloc, to make sure >>> they are compatible with the original, even if no one else uses that >>> particular feature. >> >> That's what I did, I think? >> >> The code above doesn't have any effect unless we run out of memory (even >> then, it won't have an effect if NITEMS is a stack variable in a frame >> that's unwound by memory_full). > > Sorry, I'm currently to unconcentrated to follow. I just wanted to say > that it would be good to make the functions are compatible with xpalloc, > whatever that means. Do you want me to look at your patch? I'd rather just rely on you, though :-). And while everyone is on board: I was making emacs-mac use igc in my Emacs. Seems to have worked, I'm writing this from ELISP> (and (featurep 'mac) (featurep 'mps)) t Only minimal additions to igc.[ch] were necessary because mac uses a Lisp and a GUI thread, and so on, so I couldn't use init_igc for mac. Two new functions in =C3=A4ifdef HAVE_MAC_GUI instead, igc_init_mac_early a= nd _late. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 03 09:14:01 2025 Received: (at 79156) by debbugs.gnu.org; 3 Aug 2025 13:14:01 +0000 Received: from localhost ([127.0.0.1]:43193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiYXJ-0003oK-3l for submit@debbugs.gnu.org; Sun, 03 Aug 2025 09:14:01 -0400 Received: from mail-10630.protonmail.ch ([79.135.106.30]:45583) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiYXF-0003nm-NW for 79156@debbugs.gnu.org; Sun, 03 Aug 2025 09:13:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1754226830; x=1754486030; bh=5ox7m1qVFidKHtnZ9vrCO+4sok2tyRNi6YkkEwIKf+0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Syb/TA6hgIakYIZUdhyE8zVn9uEBt5cckNlmf4vBJiuJZPBusb9oarl1CTDEIdZLe y7ZHZG0j4UFCzK1QZ8zRUgKO8O/whlGuwlC/STNBX7QCKoqrRH9Hfryj5xlqX3Xam8 G9OhhLJuJ1/vkdggbeUzwlyU8E2UjaAVPNtVOD26RfHFFDyN9cx9D15LlxsRdtgxAL MgXcgQZeUUKI3iRpqLyseu2ExmI73s5zou924SFko3hKx0pW3p/2MRF4r436iCun3n OxtAyjJztycAARh0ZSrODbqnwVEAWgb+iP2xlECKghVcPtRSJepLVgkrquG3Iv6UsU 03j3F+FGc5XCQ== Date: Sun, 03 Aug 2025 13:13:45 +0000 To: =?utf-8?Q?Gerd_M=C3=B6llmann?= From: Pip Cet Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV Message-ID: <871ppsblb5.fsf@protonmail.com> In-Reply-To: References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 3f7ca9ef8d6b926478f36e9fda7afaef9e1e0d3d MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Eli Zaretskii , eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gerd M=C3=B6llmann writes: > Gerd M=C3=B6llmann writes: > >> Pip Cet writes: >> >>> Gerd M=C3=B6llmann writes: >>> >>>> Eli Zaretskii writes: >>>> >>>>>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, b= ut >>>>>> I'm not sure whether there are other callers that rely on this behav= ior, >>>>>> so it's safest to work around it. >>>>> >>>>> xpalloc handles this case: >>>>> >>>>> if (! pa) >>>>> *nitems =3D 0; >>>> >>>> Yeah, I'd rather check the other igc variants of xpalloc, to make sure >>>> they are compatible with the original, even if no one else uses that >>>> particular feature. >>> >>> That's what I did, I think? >>> >>> The code above doesn't have any effect unless we run out of memory (eve= n >>> then, it won't have an effect if NITEMS is a stack variable in a frame >>> that's unwound by memory_full). >> >> Sorry, I'm currently to unconcentrated to follow. I just wanted to say >> that it would be good to make the functions are compatible with xpalloc, >> whatever that means. > > Do you want me to look at your patch? I'd rather just rely on you, > though :-). Pushed now. Can you confirm it works and close this bug? > And while everyone is on board: I was making emacs-mac use igc > in my Emacs. Seems to have worked, I'm writing this from > > ELISP> (and (featurep 'mac) (featurep 'mps)) > t > > Only minimal additions to igc.[ch] were necessary because mac uses a > Lisp and a GUI thread, and so on, so I couldn't use init_igc for mac. > Two new functions in =C3=A4ifdef HAVE_MAC_GUI instead, igc_init_mac_early= and > _late. That sounds like an acceptable price to support macOS better. I don't use macOS, though, so I can't really say anything about the two ports and their differences. Pip From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 03 09:34:51 2025 Received: (at 79156) by debbugs.gnu.org; 3 Aug 2025 13:34:51 +0000 Received: from localhost ([127.0.0.1]:43280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiYrT-0005IQ-1J for submit@debbugs.gnu.org; Sun, 03 Aug 2025 09:34:51 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:50449) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiYrQ-0005I1-Jf for 79156@debbugs.gnu.org; Sun, 03 Aug 2025 09:34:49 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-458b2d9dba5so10749215e9.1 for <79156@debbugs.gnu.org>; Sun, 03 Aug 2025 06:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754228082; x=1754832882; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gXenGhcPl4iQgqnkmFIY203JdlfHn935x7ud44xd9/s=; b=OSyPgdLxxCjumuLpL8zkUreeGqmHl2SObgzAbMMu1teF49XfGc9whdkPzzbDp4huXq bpaQYXXGRJIX3f3VCWbkCn8GrQYPG2PHJu2T6KGqCqrRhlJmQ/tPwu64crY3Y1oh0Nc3 7mGlNyq/rKR2wfObc78r5iZxuh0H+EIkfVyCw5pvHYNuVtwv+41SA7xwdE3rKRQzZ3kx fyFlD6usQ6CVyhDvQuL5VNDoEhNuGmgdzV6HpaNawr2hh9wk0iMVEJlbiDgpdsgtqDLy lk29tjYXCox6G8AkPrSPNlWM8dD6cF+q9qevF8xBHes9Y432nXfJzhesQadGn86LfXSB 5fWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754228082; x=1754832882; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gXenGhcPl4iQgqnkmFIY203JdlfHn935x7ud44xd9/s=; b=EesDIPxf6M29a1vqZxE5icNfRTX4Hwur+eCk8oYSG7cum6FTQTgMjFy+ZlViQ7oxTl 4/sPMl61W1vDmN71DsaMu8C9y1Hqz9tNK4auAaV0sZHIndA40BTLKdIkc6VOf8+24WbV LmYZVJnCiQ78ZHkz6KVzcnOUb9C4MP9vl/QwhfnyEueDrcHGLFw1GWjQtL48IOMWmgtU kWLO8g4QK33hzFIzAHYbL1ElNwTXwyMr+tx32bcS+Bnnv24ICe4sZ+H0Mg/QLKg3rxxj UwSH7GYHxaEqY3x33dqGbgjJvEZcweeDrd4vnaXgDPKivHPMdPthlF/lh5E6/RWp7GQt rxaw== X-Forwarded-Encrypted: i=1; AJvYcCUhSuJnsm0DzvaUv9B3/F4p6J/ErhQ01OalPf0h5/e+Ai+w2rRpsLYm15K0DSZP0QWWvdddvg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzrDKKCx6f1i1RCR5MyV+oIXYptTCMqEYH+v6/L6s0TQaAufUGv KUjIWMy71Pxufn6Ck9M8qPLgouu0NLjNl/LfObYoQgehvrSLls50XASmrAVCaJOQ X-Gm-Gg: ASbGncs8QzCUtqPmqb1THAwkN4p0Le1lQ4Fbkao9fNwxcksR+t7P8Ky8TZ2oZRLhppj DEVF0fnlhCSXMA9VevjyDMGKfU/Hq9MWRE2vnrs/ZXNqhw71iz2MBEsHMuaVPG94MmQsVkR2zd1 GRwVfOVYVLwfXhxFfXiqQb+Q0rRZ4L3HBSN4XG/ZPQ1vYz6yh9dRLcb06KUlwxq/VcXwLVDRlDS JauESbCz+b+H+MAzqk7ZNRwRf7/csveOBEKnMOksYwF6S7JranZW7FytYIhz6ZTrx1ngumOJR29 yyi+f1MoY9Jgh0UGUAE1KWPDaYCPpS9bsJg5FoWo+33HKR504Fn4YzZdXHCtf/5CLks1kwSbEi5 w+94k86F5MiRRCWGk98P5SK+fAVjeK0TEsTRyCait17+oumxPmRodYXKgV/Vagj9/NYY803/we6 LkXa4/u9QHBwTZhAQFr5dlQwIb X-Google-Smtp-Source: AGHT+IF1rKdjgBDlZtiIsmr7XVuluDdEi0WmD0842JTUeJb+MMj0gPo9b7bdIj6gEdW7/vP4+zKZ2w== X-Received: by 2002:a05:600c:19cc:b0:458:c045:ee99 with SMTP id 5b1f17b1804b1-458c045f1ddmr23734555e9.28.1754228081881; Sun, 03 Aug 2025 06:34:41 -0700 (PDT) Received: from pro2 (p200300e0b70e8b002124748d09eedd4d.dip0.t-ipconnect.de. [2003:e0:b70e:8b00:2124:748d:9ee:dd4d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4589ee57922sm133381355e9.22.2025.08.03.06.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Aug 2025 06:34:41 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Pip Cet Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV In-Reply-To: <871ppsblb5.fsf@protonmail.com> References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> <871ppsblb5.fsf@protonmail.com> Date: Sun, 03 Aug 2025 15:34:40 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Eli Zaretskii , eller.helmut@gmail.com, 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > Pushed now. Can you confirm it works and close this bug? Cherry-picked, built, and verified. Thanks! >> And while everyone is on board: I was making emacs-mac use igc >> in my Emacs. Seems to have worked, I'm writing this from >> >> ELISP> (and (featurep 'mac) (featurep 'mps)) >> t >> >> Only minimal additions to igc.[ch] were necessary because mac uses a >> Lisp and a GUI thread, and so on, so I couldn't use init_igc for mac. >> Two new functions in =C3=A4ifdef HAVE_MAC_GUI instead, igc_init_mac_earl= y and >> _late. > > That sounds like an acceptable price to support macOS better. I don't > use macOS, though, so I can't really say anything about the two ports > and their differences. Yes, I think so too. Let's see how that all plays out. I've old JD that it's available. And I'm rubbing my hands together that I have a stable GUI, and it doesn't stutter :-) Closing. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 03 09:35:00 2025 Received: (at control) by debbugs.gnu.org; 3 Aug 2025 13:35:00 +0000 Received: from localhost ([127.0.0.1]:43283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiYrb-0005Iz-HN for submit@debbugs.gnu.org; Sun, 03 Aug 2025 09:34:59 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:60779) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiYrY-0005IN-7P for control@debbugs.gnu.org; Sun, 03 Aug 2025 09:34:56 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3b79bdc9a7dso1930559f8f.1 for ; Sun, 03 Aug 2025 06:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754228090; x=1754832890; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:from:to:cc:subject:date:message-id:reply-to; bh=Umah3T844zuo69p9GdXnkFpAKi1iwu7ViugiqaOzA1g=; b=DdnaTdgnYS1QW8w2hu5c04uixIAZn91j2d1//406qZbRKmWa4u3eC0p2qTpUads1+P mVeuIEDhvYUnH4/vfBrE0eGXqzBxh7LZbdV9fGIMaYl71lIrWeRMInkGl8vxcJCf2dx9 LK2oXJeuerxSFJ/bNNMWu8FgCssl0LrAmCBNVQG1iRYJ5x+5JNhs81Xna/pGEzcWMAjP n5kKW7yNzTu29so/52ASrx/hmxzzK2z7yTEk7CJ3X1Uqht38Zm3CWEUYVMplUZobxxU9 ZOtPfIn2VAkMeMZTn9M50qaD4cbdWohzZtQ/C2VWOfIVfVytR2Qcj1Pe0XTlL8HwmMlO XTbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754228090; x=1754832890; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Umah3T844zuo69p9GdXnkFpAKi1iwu7ViugiqaOzA1g=; b=lPUww/b1S2GldAaWJE0ZELRef/mMzduTgUgbsqYUud3itCSVrvTdzuO/MuK64UCGaZ k0QaHUSLjKSTIPGjkxWc0nIwfbWEZnfQ91IL1J2C+INguCA3XcN9UhPx94lGrFtzMPEC YnCFQj6wwYpVh4NdE1PGTQGQBN90oJsyNBmhgyIGG0qB5ESN/nwHLmFnZLPrix7Kqdb0 zMetSqpvTeNFcRU5LFCANZlWmB9PzfBcmFxnJ5nhgtEgTWAADGiX5Vm77VLGnQTTJVOr 6zRfwU4d+vq025N93qCNKqQYq1GcCHFbIQ20OGFPzYRfAFPOyvCyZR6ZGYYsCcYBrK6I 7lFg== X-Gm-Message-State: AOJu0YwTk39FrmcVYInLI6AfEfpToPc9K2jpC5HHqDrwszW7Q6tO3fub pa2H8Cm1T1AwyBzhRo73sPE/8comxgTRaa11WJNR5NMY2ZuqjeYWiH7+RVyiHDaR X-Gm-Gg: ASbGncvnmyZbbtgKsZ9voJ16PbX7qzXlUNVBY2XZ/myXa7fOJLck8SgvYDCFYcZkKta vO5gnd43eY5lXFtTdIvpKHzwQrD9nDsnT1LGGZZyRY4W5PMNwCOnWE/YaWrzmOFnhrsa3by1ebE CPmhPFNaz6dVOhrJXmkpufQnngfFHciJc/KJ54zN5Or3MrLI8ZopkhgxY/NX00VI2WTWNBrYJvX eEmqGFi+JFSGS8oSItjJuFvOkQjgTFCkkR2mhxnn3nA8eMh/8KMrwK6HkgW+D2axSFwi0KOD/3H y9eqZtSZ3xkIsilkBeuHCzRj3ebx7rInk4Ex0ysrsB7tSMqO8qjoy7WQl1JPk3wUAtZMCXFs1oK IVOBGHULjN520XQj5pN61GuQM8WRBer8M23ROzSKLhCsCKC0XJVG7mEVq6/zeOm3IYlDwweidLS MsMFkkQcW8gL26UUDdIeWPOs3+ X-Google-Smtp-Source: AGHT+IFq1Bzyu2R6IhPf1yOKPoW3oDKi33EykVpMmXuf/6NHFe3BWrkrDUlm+WjZhHt3x05s/KXYFg== X-Received: by 2002:a05:6000:4202:b0:3b7:9617:c9d6 with SMTP id ffacd0b85a97d-3b8d94c4853mr4044915f8f.45.1754228089755; Sun, 03 Aug 2025 06:34:49 -0700 (PDT) Received: from pro2 (p200300e0b70e8b002124748d09eedd4d.dip0.t-ipconnect.de. [2003:e0:b70e:8b00:2124:748d:9ee:dd4d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c475067sm12171414f8f.58.2025.08.03.06.34.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Aug 2025 06:34:49 -0700 (PDT) Date: Sun, 03 Aug 2025 15:34:48 +0200 Message-Id: To: control@debbugs.gnu.org From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Subject: control message for bug #79156 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 79156 31.1 quit Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gerd.moellmann[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:436 listed in] [list.dnswl.org] 1.7 MALFORMED_FREEMAIL Bad headers on message from free email service X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) close 79156 31.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 03 10:05:50 2025 Received: (at 79156) by debbugs.gnu.org; 3 Aug 2025 14:05:50 +0000 Received: from localhost ([127.0.0.1]:44989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiZLR-00027n-Im for submit@debbugs.gnu.org; Sun, 03 Aug 2025 10:05:50 -0400 Received: from mail-ua1-x92b.google.com ([2607:f8b0:4864:20::92b]:51228) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiZLN-00027K-6J for 79156@debbugs.gnu.org; Sun, 03 Aug 2025 10:05:47 -0400 Received: by mail-ua1-x92b.google.com with SMTP id a1e0cc1a2514c-88bc6f023edso1464889241.2 for <79156@debbugs.gnu.org>; Sun, 03 Aug 2025 07:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754229939; x=1754834739; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ae4qFDvNWGc2ekHlHyly2a2RmYnNibI57kxG7Yl7z98=; b=hCRolvkZ9BAOhhvTQJuGw7nlRblbvj6T1LP5jE4LajMf3xIiL7OaV1bJFLicMcwfBS /0B5yjrR4/w4Glr5th4SYd7zCDXfENdtvIELAip2aiBL3kHcWHePag1z4UZIA/L6YP/h BHg1Nssu0CQUK+3Do9HfQuTGPklQ7ZDV8pPxVmzt28PO/xrTlM9uoUAhMNZqUv4fphrt bkBhWhyMMXUdlphwf+2+HeGGgmJW0AA9RBgshu9vIHiOvq+sU6vvqp1efh1DskcEXWfh NZ0LtPJPiErjju+0JRlr1W5RY2uB4soafvKs1MLvQg9edJ6LNydW2hznCKCuTAjh4dRb 0GDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754229939; x=1754834739; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ae4qFDvNWGc2ekHlHyly2a2RmYnNibI57kxG7Yl7z98=; b=djVVp64IenmOQLU2C/F9Em500wXjDJjOtgRNkYemDVgsCMGYml8TSrYQoh7dtTmD6I TZiN7RmIfuypkuCRZfu1WJYMzeVabFG0k/hfWYjHqy7f27PPx0oCSv1FYvX+mI6KPHqF RSA2bbsdj3EmZIFnixul6BIL9AsdobIdJ+FCzXl58nizQ/BD+VpqzOD6ZIvV2tnZaUyl f8vruYSai54Ei/2d4mpsDQAFQhd80HZRXG6mfxW5YWpeUf724+8MFP3qp3yv1s2GAWQy feZYTWUCu8Xhv7pW/gkmAvyuvDZo3fltzV3EBfkx8LcxqO4xcyUBx19EvbU5GD9qdsxv hPBA== X-Forwarded-Encrypted: i=1; AJvYcCU3ooEx1vufUxq1aQPQO6jlzCpTJ+dw+NkymuuG/02chikUh7km6N/n/l4Rk5DmEo/rO0R/lA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw9PhmP4TU1C6WwOGwdAOl3pwfvSxY6LmJwDPsQCCEFsmqA5vva +uTFmdYy4ONEJOoImkY+g99tFkiY/H3R+x4jVdh7D3upeEq2w77yRYeVCadyRvqIQqvT+IomOJk VC16uidXKdNfZ+LziE8xU0yrkqNGLHZI= X-Gm-Gg: ASbGncuPoRv+JJFjoE4aqkdcxXT5tRz6+U2gj2iObkPpK9gMG/o5ap02v33Ogid8MDy S/9Qc/Dp/wyZxXykYxD3wGt45/1xPyaW/2dfBfKjJeDpvm7zhmMb7UjoeXqmkadAF5Zjy8aAEa9 gDG86S4JbgyClOCy9LXfG/54qVrxxwtjiy1c79dou1PqSiiTdi9iKUKjE0ro9jEhZIveippd4yB SorSSXDmQ== X-Google-Smtp-Source: AGHT+IGXMn+FkQ3dCJS9OCCP/uZMOnxMfZ6eQT8yf4EhrEndqokEB96ezRIrV1qNdijYoAU2N8gdtb6Q6X0DbrrDHG8= X-Received: by 2002:a05:6102:6cc:b0:4e5:997a:748f with SMTP id ada2fe7eead31-4fdc4218d3bmr2093315137.22.1754229939396; Sun, 03 Aug 2025 07:05:39 -0700 (PDT) MIME-Version: 1.0 References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> In-Reply-To: From: =?UTF-8?Q?St=C3=A9phane_Marks?= Date: Sun, 3 Aug 2025 10:05:28 -0400 X-Gm-Features: Ac12FXw7B9rSWScXxRzmVv3qXlZEMjzVm5HfUv6KYCfVsPAnlpidSQ5zjGXwlLw Message-ID: Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= Content-Type: multipart/alternative; boundary="00000000000064622f063b767ca3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Pip Cet , eller.helmut@gmail.com, Eli Zaretskii , 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000064622f063b767ca3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Aug 3, 2025 at 8:53=E2=80=AFAM Gerd M=C3=B6llmann wrote: > Gerd M=C3=B6llmann writes: > > > Pip Cet writes: > > > >> Gerd M=C3=B6llmann writes: > >> > >>> Eli Zaretskii writes: > >>> > >>>>> Ouch. That seems to me to be a bug in how charset.c calls xpalloc, > but > >>>>> I'm not sure whether there are other callers that rely on this > behavior, > >>>>> so it's safest to work around it. > >>>> > >>>> xpalloc handles this case: > >>>> > >>>> if (! pa) > >>>> *nitems =3D 0; > >>> > >>> Yeah, I'd rather check the other igc variants of xpalloc, to make sur= e > >>> they are compatible with the original, even if no one else uses that > >>> particular feature. > >> > >> That's what I did, I think? > >> > >> The code above doesn't have any effect unless we run out of memory (ev= en > >> then, it won't have an effect if NITEMS is a stack variable in a frame > >> that's unwound by memory_full). > > > > Sorry, I'm currently to unconcentrated to follow. I just wanted to say > > that it would be good to make the functions are compatible with xpalloc= , > > whatever that means. > > Do you want me to look at your patch? I'd rather just rely on you, > though :-). > > And while everyone is on board: I was making emacs-mac use igc > in my Emacs. Seems to have worked, I'm writing this from > > ELISP> (and (featurep 'mac) (featurep 'mps)) > t > > Only minimal additions to igc.[ch] were necessary because mac uses a > Lisp and a GUI thread, and so on, so I couldn't use init_igc for mac. > Two new functions in =C3=A4ifdef HAVE_MAC_GUI instead, igc_init_mac_early= and > _late. > Do you think you'll push that igc merged branch up to JD's git repo? --00000000000064622f063b767ca3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Sun, Aug 3, 2025 at 8:53=E2=80=AFAM Gerd M=C3=B6llmann <gerd.moellmann@gmail.com> wrote:
Gerd M=C3=B6llmann <gerd.moellmann@gmail.com> writes:

> Pip Cet <pipcet@protonmail.com> writes:
>
>> Gerd M=C3=B6llmann <gerd.moellmann@gmail.com> writes:
>>
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>
>>>>> Ouch. That seems to me to be a bug in how charset.c ca= lls xpalloc, but
>>>>> I'm not sure whether there are other callers that = rely on this behavior,
>>>>> so it's safest to work around it.
>>>>
>>>> xpalloc handles this case:
>>>>
>>>>=C2=A0 =C2=A0if (! pa)
>>>>=C2=A0 =C2=A0 =C2=A0*nitems =3D 0;
>>>
>>> Yeah, I'd rather check the other igc variants of xpalloc, = to make sure
>>> they are compatible with the original, even if no one else use= s that
>>> particular feature.
>>
>> That's what I did, I think?
>>
>> The code above doesn't have any effect unless we run out of me= mory (even
>> then, it won't have an effect if NITEMS is a stack variable in= a frame
>> that's unwound by memory_full).
>
> Sorry, I'm currently to unconcentrated to follow. I just wanted to= say
> that it would be good to make the functions are compatible with xpallo= c,
> whatever that means.

Do you want me to look at your patch? I'd rather just rely on you,
though :-).

And while everyone is on board: I was making emacs-mac use igc
in my Emacs. Seems to have worked, I'm writing this from

=C2=A0 ELISP> (and (featurep 'mac) (featurep 'mps))
=C2=A0 t

Only minimal additions to igc.[ch] were necessary because mac uses a
Lisp and a GUI thread, and so on, so I couldn't use init_igc for mac. Two new functions in =C3=A4ifdef HAVE_MAC_GUI instead, igc_init_mac_early a= nd
_late.

Do you think you'll push that igc merged branch= up to JD's git repo?
--00000000000064622f063b767ca3-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 03 10:18:59 2025 Received: (at 79156) by debbugs.gnu.org; 3 Aug 2025 14:18:59 +0000 Received: from localhost ([127.0.0.1]:45013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiZYB-0002nW-0f for submit@debbugs.gnu.org; Sun, 03 Aug 2025 10:18:59 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:54353) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiZY7-0002nG-0Z for 79156@debbugs.gnu.org; Sun, 03 Aug 2025 10:18:56 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4561ed868b5so23253095e9.0 for <79156@debbugs.gnu.org>; Sun, 03 Aug 2025 07:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754230728; x=1754835528; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xzjs8fWXMxjSc/D1Cjw8bAEprbCQa4q+AvLX8BsFq7Q=; b=EnqqPBF5pKna8SdcMVvlXgb/yu3vfhwydyWf6UDz0peyTmKgQ8aNcx7IAtMuLtUfbA Ym6uPYkaICzSNOVI5OTbY4xHYMJed5nz7vcD6lx4NAUkV+kJI3DrAollbpgFu8bkljol hBYyan/5/fzsuHu4g6awo2VUyZy4oPBwtLtpA9bs6HzV2a0ymXUrjjhFXjhd4+WGro2g 4PUHnlUMFhr5AM1fgC5VsDjbKSRVkqjGMXg1jfrEWMMvYnQlOWAwZ8804z2M3qXCe+Ag INBFqUX/SpAAukdoSV4TTXS+Sp+xQqkFMpwDAbw7FWFJgZlB4utC+4r6VNw8CFou5fhT 4Wtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754230729; x=1754835529; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Xzjs8fWXMxjSc/D1Cjw8bAEprbCQa4q+AvLX8BsFq7Q=; b=TmlPPVfkCthUYjL0z098JC5H2ITR4XiPLFrqjaUmTD/ZZbb5hV658vE1STyz65ldMj U9WKTF6mJ5QuLsSchqAFzc7KXA0BZd0pwUF8rT8VKP764TNa+3GaGrd+Dj1bWM1Tq+Qe vWIWiqoJRMeUFcPxxTc3J2jY04FTV+lyAWPZbwHe1OrL6rLyTBPTDmCizVjH4fackEOV s+oBJh2J3PgIWjPe/CLAZMDl1kipburIr4MkouchBD51v1r8cfW0YUXhIhaqINnV6vY4 DlP7QGJt272R9R3ueGDFV5MPGtxbwVz+ASVrvr2HSr/5I5gmSGGyCH1+osfuGrf58xZ7 dI/g== X-Forwarded-Encrypted: i=1; AJvYcCU4TDxdWMd5K9dCRQFPmgZvJycKL7MDIyaiVMefc1Te3bpK/q2aq2f+CB8wNaCLgIQaxPnNGA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwWaclN+ccJB4O76soJSeCTQUMRDQm2nAF28CptF05AgdM7nHc8 HT1zadApCESP9ixswyIT2JQY03bfVSFbnm67+LWI/K8KjNmCY+iJBYOpuaulOhVI X-Gm-Gg: ASbGncsVTcHzCoau7zuc0NVzSCEgOKs5yyE+7d2tNJEpK7XPFXBuUlUYiIUFEZX0k+A wWe8LpmNJKK0vO/9WT2Wwv9DkEkoYaB3UnRflnfk6RH4MRu7D87ml0Th1j4yQydj3357aC8+lbR lIkTXpRPJ7xnUGMuSeZy8DspGgRUf00WcBUlq7uB2y8q2wNBhNm/cG0RU2EALWUqoZAYs5PAgSm UHIVlz9P8qsSQivlrwPEMDI58Zzn7Jo/5mJ5EfRpXG3bAaQueNGOc5Bxq9kcOoqOBQgmqBYEXVv vF+W1Ek/d8JvcrwxAVXiipIwEiQh7mnGLiAxkKtfycgCJxBke/RpVt7KyEzKnIkbvYL1QBztrLM hYiyRye5vsc3AHnDvRy9Iq3LJ97yr3BSVncFR8vlJE90X2BWrkTIj8aFDVCAXdz4/qJFpQS/fGC weg851Uptr+0MIckODvFf0TCYu X-Google-Smtp-Source: AGHT+IEw1hU5FLbPM5Iu5XtozXDGjKH5ZvVzuZZpt8/uUah2Ti6c8TXzrbbspyM4W6ywNoEWb1rBEw== X-Received: by 2002:a05:600c:19c9:b0:459:d494:faf9 with SMTP id 5b1f17b1804b1-459d494fd04mr16978535e9.10.1754230728599; Sun, 03 Aug 2025 07:18:48 -0700 (PDT) Received: from pro2 (p200300e0b70e8b002124748d09eedd4d.dip0.t-ipconnect.de. [2003:e0:b70e:8b00:2124:748d:9ee:dd4d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c3ac574sm12400578f8f.5.2025.08.03.07.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Aug 2025 07:18:48 -0700 (PDT) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: =?utf-8?Q?St=C3=A9phane?= Marks Subject: Re: bug#79156: igc: igc_xpalloc_ambig SEGV In-Reply-To: References: <87ldo1btow.fsf@protonmail.com> <865xf5r8nk.fsf@gnu.org> <87cy9dbqku.fsf@protonmail.com> Date: Sun, 03 Aug 2025 16:18:47 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79156 Cc: Pip Cet , eller.helmut@gmail.com, Eli Zaretskii , 79156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) St=C3=A9phane Marks writes: > Do you think you'll push that igc merged branch up to JD's git repo? What I currently have is in my fork, which contains a lot of other stuff, like CL packages and so on. I've told JD that I have something, and the rest I just let happen :-).