GNU bug report logs - #79143
[PATCH] New user option to inhibit Calc startup message

Previous Next

To reply to this bug, email your comments to 79143 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Devlin <spd <at> toadstyle.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] New user option to inhibit Calc startup message
Date: Fri, 1 Aug 2025 17:15:36 -0500

[Message part 1 (text/plain, inline)]

Hi folks,

This is a patch adding a new user option to suppress Calc’s startup
message.

By default, Calc prints a message like this during startup:

"Welcome to the GNU Emacs Calculator!  Press ? or M-x calc-help-prefix
for help, q to quit"

I find this a bit distracting, so I’d like to be able to silence it. The
attached patch adds an option to allow this along with a small test
harness and documentation in the NEWS file.

Please let me know if any changes are needed to the patch.

Thanks!

[0001-New-user-option-to-inhibit-Calc-startup-message.patch (application/octet-stream, attachment)]

Message #8 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Devlin <spd <at> toadstyle.org>,
 Christopher Howard <christopher <at> librehacker.com>
Cc: 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Sat, 02 Aug 2025 09:33:24 +0300

> From: Sean Devlin <spd <at> toadstyle.org>
> Date: Fri, 1 Aug 2025 17:15:36 -0500
> 
> This is a patch adding a new user option to suppress Calc’s startup
> message.
> 
> By default, Calc prints a message like this during startup:
> 
> "Welcome to the GNU Emacs Calculator!  Press ? or M-x calc-help-prefix
> for help, q to quit"
> 
> I find this a bit distracting, so I’d like to be able to silence it. The
> attached patch adds an option to allow this along with a small test
> harness and documentation in the NEWS file.
> 
> Please let me know if any changes are needed to the patch.

Thanks.

Christopher, any comments?  (I hope you don't mind being involved in
maintenance of Calc by way of reviewing patches of others.)

> From 1ad1f17b6c9326ffc009c6de5c5f2b9929014f52 Mon Sep 17 00:00:00 2001
> From: Sean Devlin <spd <at> toadstyle.org>
> Date: Fri, 1 Aug 2025 17:05:48 -0500
> Subject: [PATCH] New user option to inhibit Calc startup message
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> * etc/NEWS: Document the new option.
> * lisp/calc/calc.el (calc-inhibit-startup-message): New option to
> inhibit Calc’s startup message.
> (calc): Respect the option in Calc’s startup code.
> * test/lisp/calc/calc-tests.el (ert): Require ert-x for
> 'ert-with-message-capture'.
> (calc-inhibit-startup-message): Test the new user option.

Should this new option be in the Calc manual as well?  If you agree
and send an updated patch for that, then please (a) mention the bug
number in the commit log message, and (b) mark the NEWS entry as
"+++", to indicate that the relevant manuals have been updated.

> ---
>  etc/NEWS                     |  4 ++++
>  lisp/calc/calc.el            | 21 ++++++++++++++-------
>  test/lisp/calc/calc-tests.el | 15 +++++++++++++++
>  3 files changed, 33 insertions(+), 7 deletions(-)
> 
> diff --git a/etc/NEWS b/etc/NEWS
> index f4e64c0851f..aa1936fe7fc 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2305,6 +2305,10 @@ Latin-1 range 0-255.  This hard-coded maximum is replaced by
>  the display of matching vectors as Unicode strings.  The default value
>  is 0xFF or 255 to preserve the existing behavior.
>  
> +*** New user option 'calc-inhibit-startup-message'.
> +If it is non-nil, inhibit Calc from printing its startup message.  The
> +default value is nil to preserve the existing behavior.
> +
>  ** Time
>  
>  *** New user option 'world-clock-sort-order'.
> diff --git a/lisp/calc/calc.el b/lisp/calc/calc.el
> index a350419b320..d4fb8776c6c 100644
> --- a/lisp/calc/calc.el
> +++ b/lisp/calc/calc.el
> @@ -1473,6 +1473,11 @@ calc-create-buffer
>      (require 'calc-ext)
>      (calc-set-language calc-language calc-language-option t)))
>  
> +(defcustom calc-inhibit-startup-message nil
> +  "If non-nil, inhibit the Calc startup message."
> +  :version "31.1"
> +  :type 'boolean)
> +
>  (defcustom calc-make-windows-dedicated nil
>    "If non-nil, windows displaying Calc buffers will be marked dedicated.
>  See `window-dedicated-p' for what that means."
> @@ -1524,9 +1529,10 @@ calc
>          (with-current-buffer (calc-trail-buffer)
>            (and calc-display-trail
>                 (calc-trail-display 1 t)))
> -        (message (substitute-command-keys
> -                  (concat "Welcome to the GNU Emacs Calculator!  \\<calc-mode-map>"
> -                          "Press \\[calc-help] or \\[calc-help-prefix] for help, \\[calc-quit] to quit")))
> +        (unless calc-inhibit-startup-message
> +          (message (substitute-command-keys
> +                    (concat "Welcome to the GNU Emacs Calculator!  \\<calc-mode-map>"
> +                            "Press \\[calc-help] or \\[calc-help-prefix] for help, \\[calc-quit] to quit"))))
>          (run-hooks 'calc-start-hook)
>          (and (windowp full-display)
>               (window-point full-display)
> @@ -1534,10 +1540,11 @@ calc
>          (and calc-make-windows-dedicated
>               (set-window-dedicated-p nil t))
>          (calc-check-defines)
> -        (when (and calc-said-hello interactive)
> -          (sit-for 2)
> -          (message ""))
> -        (setq calc-said-hello t)))))
> +        (unless calc-inhibit-startup-message
> +          (when (and calc-said-hello interactive)
> +            (sit-for 2)
> +            (message ""))
> +          (setq calc-said-hello t))))))
>  
>  ;;;###autoload
>  (defun full-calc (&optional interactive)
> diff --git a/test/lisp/calc/calc-tests.el b/test/lisp/calc/calc-tests.el
> index 2fd6a6be45e..49762e146a5 100644
> --- a/test/lisp/calc/calc-tests.el
> +++ b/test/lisp/calc/calc-tests.el
> @@ -26,6 +26,7 @@
>  
>  (require 'cl-lib)
>  (require 'ert)
> +(require 'ert-x)
>  (require 'calc)
>  (require 'calc-ext)
>  (require 'calc-units)
> @@ -946,5 +947,19 @@ calc-math-vector-is-string
>        (should-error (math-vector-is-string cplx-vec)
>                      :type 'wrong-type-argument))))
>  
> +(ert-deftest calc-inhibit-startup-message ()
> +  "Test user option `calc-inhibit-startup-message'."
> +  (let ((welcome-message "Welcome to the GNU Emacs Calculator!"))
> +    (ert-with-message-capture messages
> +      (let ((calc-inhibit-startup-message t))
> +        (calc))
> +      (should-not (string-match-p welcome-message messages))
> +      (calc-quit))
> +    (ert-with-message-capture messages
> +      (let ((calc-inhibit-startup-message nil))
> +        (calc))
> +      (should (string-match-p welcome-message messages))
> +      (calc-quit))))
> +
>  (provide 'calc-tests)
>  ;;; calc-tests.el ends here
> -- 
> 2.39.5 (Apple Git-154)
> 

Message #11 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Sean Devlin <spd <at> toadstyle.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Christopher Howard <christopher <at> librehacker.com>, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Sat, 2 Aug 2025 09:51:08 -0500

[Message part 1 (text/plain, inline)]

> On Aug 2, 2025, at 1:33 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Sean Devlin <spd <at> toadstyle.org>
>> Date: Fri, 1 Aug 2025 17:15:36 -0500
>> 
>> This is a patch adding a new user option to suppress Calc’s startup
>> message.
>> 
>> By default, Calc prints a message like this during startup:
>> 
>> "Welcome to the GNU Emacs Calculator!  Press ? or M-x calc-help-prefix
>> for help, q to quit"
>> 
>> I find this a bit distracting, so I’d like to be able to silence it. The
>> attached patch adds an option to allow this along with a small test
>> harness and documentation in the NEWS file.
>> 
>> Please let me know if any changes are needed to the patch.
> 
> Thanks.
> 
> Christopher, any comments?  (I hope you don't mind being involved in
> maintenance of Calc by way of reviewing patches of others.)
> 
>> From 1ad1f17b6c9326ffc009c6de5c5f2b9929014f52 Mon Sep 17 00:00:00 2001
>> From: Sean Devlin <spd <at> toadstyle.org>
>> Date: Fri, 1 Aug 2025 17:05:48 -0500
>> Subject: [PATCH] New user option to inhibit Calc startup message
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>> 
>> * etc/NEWS: Document the new option.
>> * lisp/calc/calc.el (calc-inhibit-startup-message): New option to
>> inhibit Calc’s startup message.
>> (calc): Respect the option in Calc’s startup code.
>> * test/lisp/calc/calc-tests.el (ert): Require ert-x for
>> 'ert-with-message-capture'.
>> (calc-inhibit-startup-message): Test the new user option.
> 
> Should this new option be in the Calc manual as well?  If you agree
> and send an updated patch for that, then please (a) mention the bug
> number in the commit log message, and (b) mark the NEWS entry as
> "+++", to indicate that the relevant manuals have been updated.

Hi Eli,

I’ve taken a stab at this. Please see the attached patch, and let me know if the
language or formatting need any revision.

Thanks!

[0001-Add-user-option-to-inhibit-Calc-startup-message.patch (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

> 
>> ---
>> etc/NEWS                     |  4 ++++
>> lisp/calc/calc.el            | 21 ++++++++++++++-------
>> test/lisp/calc/calc-tests.el | 15 +++++++++++++++
>> 3 files changed, 33 insertions(+), 7 deletions(-)
>> 
>> diff --git a/etc/NEWS b/etc/NEWS
>> index f4e64c0851f..aa1936fe7fc 100644
>> --- a/etc/NEWS
>> +++ b/etc/NEWS
>> @@ -2305,6 +2305,10 @@ Latin-1 range 0-255.  This hard-coded maximum is replaced by
>> the display of matching vectors as Unicode strings.  The default value
>> is 0xFF or 255 to preserve the existing behavior.
>> 
>> +*** New user option 'calc-inhibit-startup-message'.
>> +If it is non-nil, inhibit Calc from printing its startup message.  The
>> +default value is nil to preserve the existing behavior.
>> +
>> ** Time
>> 
>> *** New user option 'world-clock-sort-order'.
>> diff --git a/lisp/calc/calc.el b/lisp/calc/calc.el
>> index a350419b320..d4fb8776c6c 100644
>> --- a/lisp/calc/calc.el
>> +++ b/lisp/calc/calc.el
>> @@ -1473,6 +1473,11 @@ calc-create-buffer
>>     (require 'calc-ext)
>>     (calc-set-language calc-language calc-language-option t)))
>> 
>> +(defcustom calc-inhibit-startup-message nil
>> +  "If non-nil, inhibit the Calc startup message."
>> +  :version "31.1"
>> +  :type 'boolean)
>> +
>> (defcustom calc-make-windows-dedicated nil
>>   "If non-nil, windows displaying Calc buffers will be marked dedicated.
>> See `window-dedicated-p' for what that means."
>> @@ -1524,9 +1529,10 @@ calc
>>         (with-current-buffer (calc-trail-buffer)
>>           (and calc-display-trail
>>                (calc-trail-display 1 t)))
>> -        (message (substitute-command-keys
>> -                  (concat "Welcome to the GNU Emacs Calculator!  \\<calc-mode-map>"
>> -                          "Press \\[calc-help] or \\[calc-help-prefix] for help, \\[calc-quit] to quit")))
>> +        (unless calc-inhibit-startup-message
>> +          (message (substitute-command-keys
>> +                    (concat "Welcome to the GNU Emacs Calculator!  \\<calc-mode-map>"
>> +                            "Press \\[calc-help] or \\[calc-help-prefix] for help, \\[calc-quit] to quit"))))
>>         (run-hooks 'calc-start-hook)
>>         (and (windowp full-display)
>>              (window-point full-display)
>> @@ -1534,10 +1540,11 @@ calc
>>         (and calc-make-windows-dedicated
>>              (set-window-dedicated-p nil t))
>>         (calc-check-defines)
>> -        (when (and calc-said-hello interactive)
>> -          (sit-for 2)
>> -          (message ""))
>> -        (setq calc-said-hello t)))))
>> +        (unless calc-inhibit-startup-message
>> +          (when (and calc-said-hello interactive)
>> +            (sit-for 2)
>> +            (message ""))
>> +          (setq calc-said-hello t))))))
>> 
>> ;;;###autoload
>> (defun full-calc (&optional interactive)
>> diff --git a/test/lisp/calc/calc-tests.el b/test/lisp/calc/calc-tests.el
>> index 2fd6a6be45e..49762e146a5 100644
>> --- a/test/lisp/calc/calc-tests.el
>> +++ b/test/lisp/calc/calc-tests.el
>> @@ -26,6 +26,7 @@
>> 
>> (require 'cl-lib)
>> (require 'ert)
>> +(require 'ert-x)
>> (require 'calc)
>> (require 'calc-ext)
>> (require 'calc-units)
>> @@ -946,5 +947,19 @@ calc-math-vector-is-string
>>       (should-error (math-vector-is-string cplx-vec)
>>                     :type 'wrong-type-argument))))
>> 
>> +(ert-deftest calc-inhibit-startup-message ()
>> +  "Test user option `calc-inhibit-startup-message'."
>> +  (let ((welcome-message "Welcome to the GNU Emacs Calculator!"))
>> +    (ert-with-message-capture messages
>> +      (let ((calc-inhibit-startup-message t))
>> +        (calc))
>> +      (should-not (string-match-p welcome-message messages))
>> +      (calc-quit))
>> +    (ert-with-message-capture messages
>> +      (let ((calc-inhibit-startup-message nil))
>> +        (calc))
>> +      (should (string-match-p welcome-message messages))
>> +      (calc-quit))))
>> +
>> (provide 'calc-tests)
>> ;;; calc-tests.el ends here
>> -- 
>> 2.39.5 (Apple Git-154)
>> 

Message #14 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Sean Devlin <spd <at> toadstyle.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Christopher Howard <christopher <at> librehacker.com>, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Sat, 2 Aug 2025 11:04:22 -0500

[Message part 1 (text/plain, inline)]

> On Aug 2, 2025, at 9:51 AM, Sean Devlin <spd <at> toadstyle.org> wrote:
> 
>> 
>> On Aug 2, 2025, at 1:33 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
>>> From: Sean Devlin <spd <at> toadstyle.org>
>>> Date: Fri, 1 Aug 2025 17:15:36 -0500
>>> 
>>> This is a patch adding a new user option to suppress Calc’s startup
>>> message.
>>> 
>>> By default, Calc prints a message like this during startup:
>>> 
>>> "Welcome to the GNU Emacs Calculator!  Press ? or M-x calc-help-prefix
>>> for help, q to quit"
>>> 
>>> I find this a bit distracting, so I’d like to be able to silence it. The
>>> attached patch adds an option to allow this along with a small test
>>> harness and documentation in the NEWS file.
>>> 
>>> Please let me know if any changes are needed to the patch.
>> 
>> Thanks.
>> 
>> Christopher, any comments?  (I hope you don't mind being involved in
>> maintenance of Calc by way of reviewing patches of others.)
>> 
>>> From 1ad1f17b6c9326ffc009c6de5c5f2b9929014f52 Mon Sep 17 00:00:00 2001
>>> From: Sean Devlin <spd <at> toadstyle.org>
>>> Date: Fri, 1 Aug 2025 17:05:48 -0500
>>> Subject: [PATCH] New user option to inhibit Calc startup message
>>> MIME-Version: 1.0
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>> 
>>> * etc/NEWS: Document the new option.
>>> * lisp/calc/calc.el (calc-inhibit-startup-message): New option to
>>> inhibit Calc’s startup message.
>>> (calc): Respect the option in Calc’s startup code.
>>> * test/lisp/calc/calc-tests.el (ert): Require ert-x for
>>> 'ert-with-message-capture'.
>>> (calc-inhibit-startup-message): Test the new user option.
>> 
>> Should this new option be in the Calc manual as well?  If you agree
>> and send an updated patch for that, then please (a) mention the bug
>> number in the commit log message, and (b) mark the NEWS entry as
>> "+++", to indicate that the relevant manuals have been updated.
> 
> Hi Eli,
> 
> I’ve taken a stab at this. Please see the attached patch, and let me know if the
> language or formatting need any revision.
> 
> Thanks!
> 
> <0001-Add-user-option-to-inhibit-Calc-startup-message.patch>

Wait, try this one instead. I had forgotten to add the “+++” and amend the commit log.


>> 
>>> ---
>>> etc/NEWS                     |  4 ++++
>>> lisp/calc/calc.el            | 21 ++++++++++++++-------
>>> test/lisp/calc/calc-tests.el | 15 +++++++++++++++
>>> 3 files changed, 33 insertions(+), 7 deletions(-)
>>> 
>>> diff --git a/etc/NEWS b/etc/NEWS
>>> index f4e64c0851f..aa1936fe7fc 100644
>>> --- a/etc/NEWS
>>> +++ b/etc/NEWS
>>> @@ -2305,6 +2305,10 @@ Latin-1 range 0-255.  This hard-coded maximum is replaced by
>>> the display of matching vectors as Unicode strings.  The default value
>>> is 0xFF or 255 to preserve the existing behavior.
>>> 
>>> +*** New user option 'calc-inhibit-startup-message'.
>>> +If it is non-nil, inhibit Calc from printing its startup message.  The
>>> +default value is nil to preserve the existing behavior.
>>> +
>>> ** Time
>>> 
>>> *** New user option 'world-clock-sort-order'.
>>> diff --git a/lisp/calc/calc.el b/lisp/calc/calc.el
>>> index a350419b320..d4fb8776c6c 100644
>>> --- a/lisp/calc/calc.el
>>> +++ b/lisp/calc/calc.el
>>> @@ -1473,6 +1473,11 @@ calc-create-buffer
>>>    (require 'calc-ext)
>>>    (calc-set-language calc-language calc-language-option t)))
>>> 
>>> +(defcustom calc-inhibit-startup-message nil
>>> +  "If non-nil, inhibit the Calc startup message."
>>> +  :version "31.1"
>>> +  :type 'boolean)
>>> +
>>> (defcustom calc-make-windows-dedicated nil
>>>  "If non-nil, windows displaying Calc buffers will be marked dedicated.
>>> See `window-dedicated-p' for what that means."
>>> @@ -1524,9 +1529,10 @@ calc
>>>        (with-current-buffer (calc-trail-buffer)
>>>          (and calc-display-trail
>>>               (calc-trail-display 1 t)))
>>> -        (message (substitute-command-keys
>>> -                  (concat "Welcome to the GNU Emacs Calculator!  \\<calc-mode-map>"
>>> -                          "Press \\[calc-help] or \\[calc-help-prefix] for help, \\[calc-quit] to quit")))
>>> +        (unless calc-inhibit-startup-message
>>> +          (message (substitute-command-keys
>>> +                    (concat "Welcome to the GNU Emacs Calculator!  \\<calc-mode-map>"
>>> +                            "Press \\[calc-help] or \\[calc-help-prefix] for help, \\[calc-quit] to quit"))))
>>>        (run-hooks 'calc-start-hook)
>>>        (and (windowp full-display)
>>>             (window-point full-display)
>>> @@ -1534,10 +1540,11 @@ calc
>>>        (and calc-make-windows-dedicated
>>>             (set-window-dedicated-p nil t))
>>>        (calc-check-defines)
>>> -        (when (and calc-said-hello interactive)
>>> -          (sit-for 2)
>>> -          (message ""))
>>> -        (setq calc-said-hello t)))))
>>> +        (unless calc-inhibit-startup-message
>>> +          (when (and calc-said-hello interactive)
>>> +            (sit-for 2)
>>> +            (message ""))
>>> +          (setq calc-said-hello t))))))
>>> 
>>> ;;;###autoload
>>> (defun full-calc (&optional interactive)
>>> diff --git a/test/lisp/calc/calc-tests.el b/test/lisp/calc/calc-tests.el
>>> index 2fd6a6be45e..49762e146a5 100644
>>> --- a/test/lisp/calc/calc-tests.el
>>> +++ b/test/lisp/calc/calc-tests.el
>>> @@ -26,6 +26,7 @@
>>> 
>>> (require 'cl-lib)
>>> (require 'ert)
>>> +(require 'ert-x)
>>> (require 'calc)
>>> (require 'calc-ext)
>>> (require 'calc-units)
>>> @@ -946,5 +947,19 @@ calc-math-vector-is-string
>>>      (should-error (math-vector-is-string cplx-vec)
>>>                    :type 'wrong-type-argument))))
>>> 
>>> +(ert-deftest calc-inhibit-startup-message ()
>>> +  "Test user option `calc-inhibit-startup-message'."
>>> +  (let ((welcome-message "Welcome to the GNU Emacs Calculator!"))
>>> +    (ert-with-message-capture messages
>>> +      (let ((calc-inhibit-startup-message t))
>>> +        (calc))
>>> +      (should-not (string-match-p welcome-message messages))
>>> +      (calc-quit))
>>> +    (ert-with-message-capture messages
>>> +      (let ((calc-inhibit-startup-message nil))
>>> +        (calc))
>>> +      (should (string-match-p welcome-message messages))
>>> +      (calc-quit))))
>>> +
>>> (provide 'calc-tests)
>>> ;;; calc-tests.el ends here
>>> -- 
>>> 2.39.5 (Apple Git-154)

[Message part 2 (text/html, inline)]

[0001-Add-user-option-to-inhibit-Calc-startup-message-bug-.patch (application/octet-stream, attachment)]

[Message part 4 (text/html, inline)]

Message #17 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Howard <christopher <at> librehacker.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Sean Devlin <spd <at> toadstyle.org>, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Sat, 02 Aug 2025 17:56:23 -0800

> Christopher, any comments?  (I hope you don't mind being involved in
> maintenance of Calc by way of reviewing patches of others.)

The basic idea seems straightforward enough. Just glancing over the patch quickly, I wonder what significance that calc-said-hello variable has and if we are handling that logic for that correctly. But I haven't looked at the larger context.

-- 
Christopher Howard

Message #20 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Sean Devlin <spd <at> toadstyle.org>
To: Christopher Howard <christopher <at> librehacker.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Sun, 3 Aug 2025 10:41:32 -0500

> On Aug 2, 2025, at 8:56 PM, Christopher Howard <christopher <at> librehacker.com> wrote:
> 
>> Christopher, any comments?  (I hope you don't mind being involved in
>> maintenance of Calc by way of reviewing patches of others.)
> 
> The basic idea seems straightforward enough. Just glancing over the patch quickly, I wonder what significance that calc-said-hello variable has and if we are handling that logic for that correctly. But I haven't looked at the larger context.
> 

Hi Christopher,

I investigated this a little while I was developing the change.

Calc-said-hello is a defvar (as opposed to defcustom or defcalcmodevar) with this doc string:

“Non-nil if the welcome message has been displayed.”

It’s referenced only in the calc defun at the end:

        (message (substitute-command-keys
                  (concat "Welcome to the GNU Emacs Calculator!  \\<calc-mode-map>"
                          "Press \\[calc-help] or \\[calc-help-prefix] for help, \\[calc-quit] to quit")))
        ...
        (when (and calc-said-hello interactive)
          (sit-for 2)
          (message ""))
        (setq calc-said-hello t)

Basically, the first time we run M-x calc, the welcome message stays there until the user does something. On subsequent uses of M-x calc (within the same Emacs session), we clear the welcome message after two seconds or when the user does something, whichever comes first.

I think my patch makes sense with respect to managing this variable. If calc-inhibit-startup-message is set, we avoid setting this flag, since Calc hasn’t “said hello” yet. If the user then clears calc-inhibit-startup-message, the next invocation of M-x calc will be the first time the welcome message appears, so presumably we want it to stay there until the user does something and give them time to read it.

What do you think?

Cheers.

> -- 
> Christopher Howard

Message #23 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Howard <christopher <at> librehacker.com>
To: Sean Devlin <spd <at> toadstyle.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Sun, 03 Aug 2025 20:39:29 -0800

> I think my patch makes sense with respect to managing this variable. If calc-inhibit-startup-message is set, we avoid setting this flag, since Calc hasn’t “said hello” yet. If the user then clears calc-inhibit-startup-message, the next invocation of M-x calc will be the first time the welcome message appears, so presumably we want it to stay there until the user does something and give them time to read it.
>
> What do you think?

Sounds good to me, thanks!

-- 
Christopher Howard

Message #26 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Devlin <spd <at> toadstyle.org>
Cc: christopher <at> librehacker.com, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Thu, 07 Aug 2025 17:03:21 +0300

> From: Sean Devlin <spd <at> toadstyle.org>
> Date: Sat, 2 Aug 2025 11:04:22 -0500
> Cc: Christopher Howard <christopher <at> librehacker.com>,
>  79143 <at> debbugs.gnu.org
> 
> Wait, try this one instead. I had forgotten to add the “+++” and amend the
> commit log.

This LGTM, but I see that you have no copyright assignment on file,
and this patch (and others you posted) exceed the limit of what we can
accept without an assignment.  Would you like to start your assignment
paperwork at this time, so we could accept this and all the other
contributions of yours?  If yes, I will send you the form to fill and
the instructions to go with it.

Message #29 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Sean Devlin <spd <at> toadstyle.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: christopher <at> librehacker.com, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Thu, 7 Aug 2025 09:21:45 -0500

> On Aug 7, 2025, at 9:03 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> 
>> 
>> From: Sean Devlin <spd <at> toadstyle.org>
>> Date: Sat, 2 Aug 2025 11:04:22 -0500
>> Cc: Christopher Howard <christopher <at> librehacker.com>,
>> 79143 <at> debbugs.gnu.org
>> 
>> Wait, try this one instead. I had forgotten to add the “+++” and amend the
>> commit log.
> 
> This LGTM, but I see that you have no copyright assignment on file,
> and this patch (and others you posted) exceed the limit of what we can
> accept without an assignment.  Would you like to start your assignment
> paperwork at this time, so we could accept this and all the other
> contributions of yours?  If yes, I will send you the form to fill and
> the instructions to go with it.

Sure, thanks!

Message #32 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Devlin <spd <at> toadstyle.org>
Cc: christopher <at> librehacker.com, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Thu, 07 Aug 2025 17:49:28 +0300

> From: Sean Devlin <spd <at> toadstyle.org>
> Date: Thu, 7 Aug 2025 09:21:45 -0500
> Cc: christopher <at> librehacker.com, 79143 <at> debbugs.gnu.org
> 
> 
> > On Aug 7, 2025, at 9:03 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > 
> >> 
> >> From: Sean Devlin <spd <at> toadstyle.org>
> >> Date: Sat, 2 Aug 2025 11:04:22 -0500
> >> Cc: Christopher Howard <christopher <at> librehacker.com>,
> >> 79143 <at> debbugs.gnu.org
> >> 
> >> Wait, try this one instead. I had forgotten to add the “+++” and amend the
> >> commit log.
> > 
> > This LGTM, but I see that you have no copyright assignment on file,
> > and this patch (and others you posted) exceed the limit of what we can
> > accept without an assignment.  Would you like to start your assignment
> > paperwork at this time, so we could accept this and all the other
> > contributions of yours?  If yes, I will send you the form to fill and
> > the instructions to go with it.
> 
> Sure, thanks!

Thanks, form sent off-list.

Message #35 received at 79143 <at> debbugs.gnu.org (full text, mbox):

From: Sean Devlin <spd <at> toadstyle.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: christopher <at> librehacker.com, 79143 <at> debbugs.gnu.org
Subject: Re: bug#79143: [PATCH] New user option to inhibit Calc startup message
Date: Thu, 7 Aug 2025 11:04:25 -0500

> On Aug 7, 2025, at 9:49 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
> 
> Thanks, form sent off-list.

Thanks, I sent them my information.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.