From unknown Sat Aug 16 11:42:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79135 <79135@debbugs.gnu.org> To: bug#79135 <79135@debbugs.gnu.org> Subject: Status: [PATCH] gnu: procmail: Fix build with gcc-14. Reply-To: bug#79135 <79135@debbugs.gnu.org> Date: Sat, 16 Aug 2025 18:42:01 +0000 retitle 79135 [PATCH] gnu: procmail: Fix build with gcc-14. reassign 79135 guix-patches submitter 79135 Tomas Volf <~@wolfsden.cz> severity 79135 normal tag 79135 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 31 12:15:06 2025 Received: (at submit) by debbugs.gnu.org; 31 Jul 2025 16:15:06 +0000 Received: from localhost ([127.0.0.1]:49360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uhVvt-0003Dy-GY for submit@debbugs.gnu.org; Thu, 31 Jul 2025 12:15:06 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53150) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1uhVvq-0003CY-6i for submit@debbugs.gnu.org; Thu, 31 Jul 2025 12:15:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1uhVvi-0002Zc-NN for guix-patches@gnu.org; Thu, 31 Jul 2025 12:14:56 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1uhVvc-000608-3k for guix-patches@gnu.org; Thu, 31 Jul 2025 12:14:54 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 34F6036174F; Thu, 31 Jul 2025 16:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1753978484; bh=0+DtuP+uTmibjc2be5mFx3CljlsgYXPYO/da0XguJCg=; h=From:To:Cc:Subject:Date; b=fszu6XjLLjTfzHz87+tiLid/Ml9V6bqI68kztJaQ4y63MkOK5imrVDt08vWyDAz7K eKsIo1NqrKWD2qzxPGRWIWQLSaBaR6+8R2qtjtwb1zLVXHmcW0tm1CfUqwmV4UJgvv oZsjtd1FSjqtAlsK2zZV3lZ3xoXU71dhMAFNdVSlg390jGJ6ycZx5xA3U4hOUo3b9c 5LrYyuRtLH1KmWtyZ2iINWBkIaz9JyVDzoOhK0Wa0X1xULDnd3yt0PYZjkugc/Cb34 kAxEdu0OGxnLiQ0YWQzTUrNj9oJwuJ0GPdHLyjUzfvTLQ2gvuFSLLGNBqzLOBKpwaj dvtZ9itGLqbD5ZztdsjxVGPDNSuwgRWSb7fpmu0TufAu9N7lTuOHpWkWJCiyqxNNh4 WI1pjTlxIsbT2IfiNfaTZZ4q/LgmYcZbkPb7gxlScc3EJlccF51Hhd2SChcnUJGeYQ w3gAs33c7UL+10d3pEDax1OrJScbdZYcvOeWP77VDtjuyc2dObEN0hDVIao0xGHMxe bhzGWbl//72Bg6y6YHx1HbUcoIX+o/SN8BGJvkTzvG9Cm9IJxUlOe1prPZKHEg5D/z 3SuoHE4tTy4nQeqATqRtDqMxEymbbxFz/U1FTLWlJgX+U/e3iKVt/HXaWbmTJeCbJ6 awacRYkEyfjBMOT5r/KTh8CI= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (78-80-19-206.customers.tmcz.cz [78.80.19.206]) by wolfsden.cz (Postfix) with ESMTPSA id 144CF3628C3; Thu, 31 Jul 2025 16:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1753978483; bh=0+DtuP+uTmibjc2be5mFx3CljlsgYXPYO/da0XguJCg=; h=From:To:Cc:Subject:Date; b=haImz3AQ7kOlvogWjHAqdipQdKAyexQzNE0kWBk+ttgFvyfo0ITRUINDlCOyp8Q6a ieY62OlG4IBBc7vRJDJPFjnaFrd0UO83kxUN9slPBODyOm+SIalBut9BPaSVOm51Mq 10AikMKMxZdEJmQxIcmxwCRbiyQwhTIYssFbbziU3s6MCKvG1QGKwE0gaDkjgD5R88 zmrcXGc0jiP8NK28+w/7698R+qBx9LEme0CPmwhUl7t5G0F/SHAaKg8MFdIYYHvLKh B5z9p6PmBKICE+rdONAtwMUbE8bRo3NcnqvrOyClJyyKMq/M3AqlfI5V0qZVFuyUNu C/6i3baa3+Fkydm+EBF8yXesGiLXD35fodE1jJ/DSSShINDNEkfKMKQpadR/mgArA6 uB75yUbvkhD13FaMZcGUdUgtWgpgnPXnAmQxlzUoJfzzh/yd0XMTPcFBQBIC2dvuKV Rxf+xq3m0l6cnfUW6Mvnaqcy4M+53dG+MkJTV4EX5cXY4lXZILcxVFCn7QPljD/zP7 Ip9PH+F9HxCG8JpvnCewXbVCCQadcdd31HSKoewULIfU7GwVdGJCbwlLG89g1SghtB 2FA+xgWH5DhJ/vQp5p4SEkSix85jMnTK2WCb6mdIJg9hkV4K2gzptOAch3Tp8vabYw kTo5l/wiH8X5sbfrnXsSW7go= From: Tomas Volf <~@wolfsden.cz> To: guix-patches@gnu.org Subject: [PATCH] gnu: procmail: Fix build with gcc-14. Date: Thu, 31 Jul 2025 18:14:31 +0200 Message-ID: X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Tomas Volf <~@wolfsden.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/patches/procmail-gcc-14.patch: New patch. * gnu/packages/mail.scm (procmail)[source]: Use it. * gnu/local.mk (dist_patch_DATA): Register it. Change-Id: I41b3e1d73d319a19efa15ac75cefd326eedd58b1 --- gnu/local.mk | 1 + gnu/packages/mail.scm | 3 +- gnu/packages/patches/procmail-gcc-14.patch | 266 +++++++++++++++++++++ 3 files changed, 269 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/procmail-gcc-14.patch diff --git a/gnu/local.mk b/gnu/local.mk index 76f2e402b5..37b4a5f959 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2127,6 +2127,7 @@ dist_patch_DATA = \ %D%/packages/patches/procmail-ambiguous-getline-debian.patch \ %D%/packages/patches/procmail-CVE-2014-3618.patch \ %D%/packages/patches/procmail-CVE-2017-16844.patch \ + %D%/packages/patches/procmail-gcc-14.patch \ %D%/packages/patches/proj-7-initialize-memory.patch \ %D%/packages/patches/proot-add-clone3.patch \ %D%/packages/patches/proot-add-missing-include.patch \ diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 68611d32f2..f13dbc3010 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -2808,7 +2808,8 @@ (define-public procmail ;; patch 24. (patches (search-patches "procmail-ambiguous-getline-debian.patch" "procmail-CVE-2014-3618.patch" - "procmail-CVE-2017-16844.patch")))) + "procmail-CVE-2017-16844.patch" + "procmail-gcc-14.patch")))) (arguments `(#:phases (modify-phases %standard-phases (replace 'configure diff --git a/gnu/packages/patches/procmail-gcc-14.patch b/gnu/packages/patches/procmail-gcc-14.patch new file mode 100644 index 0000000000..36accb863f --- /dev/null +++ b/gnu/packages/patches/procmail-gcc-14.patch @@ -0,0 +1,266 @@ +diff --git a/initmake b/initmake +index 82d718d..e44ee67 100755 +--- a/initmake ++++ b/initmake +@@ -124,7 +124,7 @@ else + fi + + cat >_autotst.c <_autotst.c < + #include + #include +-main() ++int main() + { struct stat buf;return!&buf; + } + HERE +diff --git a/src/autoconf b/src/autoconf +index 1cb4c42..995d8bb 100755 +--- a/src/autoconf ++++ b/src/autoconf +@@ -363,6 +363,7 @@ cat >_autotst.c < /* getpid() getppid() */ + #endif + #include ++#include + #include + #include + #include /* SIGKILL */ +@@ -416,6 +417,16 @@ cat >_autotst.c <0) ++ kill(child[i],SIGTERM),child[i]=0; ++ while(i); ++ return 0; ++} ++ + void stimeout() + { timeout=1;close(fdcollect);killchildren(); + } +@@ -437,7 +448,79 @@ unsigned sfork() + return pid; + } + +-int main(argc,argv)char*argv[]; ++static int oldfdlock; ++#ifdef F_SETLKW ++static struct flock flck; /* why can't it be a local variable? */ ++#endif ++#ifdef F_LOCK ++static off_t oldlockoffset; ++#endif ++ ++int fdlock(int fd) ++{ int i;unsigned gobble[GOBBLE>>2]; ++ for(i=GOBBLE>>2;i;gobble[--i]=~(unsigned)0); /* SunOS crash test */ ++ oldfdlock=fd;fd=0; ++ if(MSK_fcntl&dolock) ++#ifdef F_SETLKW ++ { static unsigned extra; ++ flck.l_type=F_WRLCK;flck.l_whence=SEEK_SET;flck.l_start=tell(oldfdlock); ++ if(!extra--) ++ extra=MIN_locks/4,flck.l_len=2,i|=fcntl(oldfdlock,F_SETLK,&flck); ++ flck.l_len=0;fd|=fcntl(oldfdlock,F_SETLKW,&flck); ++ } ++#else ++ fd=1; ++#endif ++ if(MSK_lockf&dolock) ++#ifdef F_LOCK ++ oldlockoffset=tell(oldfdlock),fd|=lockf(oldfdlock,F_LOCK,(off_t)0); ++#else ++ fd=1; ++#endif ++ if(MSK_flock&dolock) ++#ifdef LOCK_EX ++ fd|=flock(oldfdlock,LOCK_EX); ++#else ++ fd=1; ++#endif ++ return fd; ++} ++ ++int sfdlock(int fd) ++{ int i;unsigned gobble[GOBBLE>>2]; ++ for(i=GOBBLE>>2;i;gobble[--i]=~(unsigned)0); /* SunOS crash test */ ++ return fdlock(fd); ++} ++ ++int fdunlock() ++{ int i;unsigned gobble[GOBBLE]; ++ for(i=GOBBLE;i;gobble[--i]=~(unsigned)0); /* some SunOS libs mess this up */ ++ if(MSK_flock&dolock) ++#ifdef LOCK_EX ++ i|=flock(oldfdlock,LOCK_UN); ++#else ++ i=1; ++#endif ++ if(MSK_lockf&dolock) ++#ifdef F_LOCK ++ { lseek(oldfdlock,oldlockoffset,SEEK_SET); ++ i|=lockf(oldfdlock,F_LOCK,(off_t)2);i|=lockf(oldfdlock,F_ULOCK,(off_t)0); ++ } ++#else ++ i=1; ++#endif ++ if(MSK_fcntl&dolock) ++#ifdef F_SETLKW ++ flck.l_type=F_UNLCK,flck.l_len=0,i|=fcntl(oldfdlock,F_SETLK,&flck); ++#else ++ i=1; ++#endif ++ if(!i) ++ for(i=GOBBLE;i&&gobble[--i]==~(unsigned)0;); ++ return i; ++} ++ ++int main(argc,argv)int argc;char*argv[]; + { int goodlock,testlock,i,pip[2],pipw[2];time_t otimet;unsigned dtimet; + static char filename[]="_locktst.l0"; + close(0);goodlock=0;testlock=FIRST_lock;signal(SIGPIPE,SIG_DFL); +@@ -576,88 +659,6 @@ skip_tests: + puts("Kernel-locking tests completed.");fprintf(stderr,"\n"); + return EXIT_SUCCESS; + } +- +-int killchildren() +-{ int i; +- i=NR_of_forks; +- do +- if(child[--i]>0) +- kill(child[i],SIGTERM),child[i]=0; +- while(i); +- return 0; +-} +- +-int sfdlock(fd) +-{ int i;unsigned gobble[GOBBLE>>2]; +- for(i=GOBBLE>>2;i;gobble[--i]=~(unsigned)0); /* SunOS crash test */ +- return fdlock(fd); +-} +- +-static oldfdlock; +-#ifdef F_SETLKW +-static struct flock flck; /* why can't it be a local variable? */ +-#endif +-#ifdef F_LOCK +-static off_t oldlockoffset; +-#endif +- +-int fdlock(fd) +-{ int i;unsigned gobble[GOBBLE>>2]; +- for(i=GOBBLE>>2;i;gobble[--i]=~(unsigned)0); /* SunOS crash test */ +- oldfdlock=fd;fd=0; +- if(MSK_fcntl&dolock) +-#ifdef F_SETLKW +- { static unsigned extra; +- flck.l_type=F_WRLCK;flck.l_whence=SEEK_SET;flck.l_start=tell(oldfdlock); +- if(!extra--) +- extra=MIN_locks/4,flck.l_len=2,i|=fcntl(oldfdlock,F_SETLK,&flck); +- flck.l_len=0;fd|=fcntl(oldfdlock,F_SETLKW,&flck); +- } +-#else +- fd=1; +-#endif +- if(MSK_lockf&dolock) +-#ifdef F_LOCK +- oldlockoffset=tell(oldfdlock),fd|=lockf(oldfdlock,F_LOCK,(off_t)0); +-#else +- fd=1; +-#endif +- if(MSK_flock&dolock) +-#ifdef LOCK_EX +- fd|=flock(oldfdlock,LOCK_EX); +-#else +- fd=1; +-#endif +- return fd; +-} +- +-int fdunlock() +-{ int i;unsigned gobble[GOBBLE]; +- for(i=GOBBLE;i;gobble[--i]=~(unsigned)0); /* some SunOS libs mess this up */ +- if(MSK_flock&dolock) +-#ifdef LOCK_EX +- i|=flock(oldfdlock,LOCK_UN); +-#else +- i=1; +-#endif +- if(MSK_lockf&dolock) +-#ifdef F_LOCK +- { lseek(oldfdlock,oldlockoffset,SEEK_SET); +- i|=lockf(oldfdlock,F_LOCK,(off_t)2);i|=lockf(oldfdlock,F_ULOCK,(off_t)0); +- } +-#else +- i=1; +-#endif +- if(MSK_fcntl&dolock) +-#ifdef F_SETLKW +- flck.l_type=F_UNLCK,flck.l_len=0,i|=fcntl(oldfdlock,F_SETLK,&flck); +-#else +- i=1; +-#endif +- if(!i) +- for(i=GOBBLE;i&&gobble[--i]==~(unsigned)0;); +- return i; +-} + HERE + + if $MAKE _autotst >_autotst.rrr 2>&1 +@@ -1033,6 +1034,10 @@ cat >_autotst.c < ++#include ++int setrgid(); ++int setresgid(); + int main(){char a[2]; + endpwent();endgrent();memmove(a,"0",1);bcopy("0",a,1);strcspn(a,"0"); + strtol("0",(char**)0,10);strchr("0",'0');strpbrk(a,"0");rename(a,"0"); +@@ -1059,7 +1064,7 @@ echo 'Testing for memmove, strchr, strpbrk, strcspn, strtol, strstr,' + echo ' rename, setrgid, setegid, pow, opendir, mkdir, waitpid, fsync,' + echo ' ftruncate, strtod, strncasecmp, strerror, strlcat,' + echo ' memset, bzero, and _exit' +-if $MAKE _autotst.$O >$DEVNULL 2>&1 ++if $MAKE _autotst.$O >_autotst.rrr 2>&1 + then + : + else +diff --git a/src/foldinfo.c b/src/foldinfo.c +index 10fe406..33e7bff 100644 +--- a/src/foldinfo.c ++++ b/src/foldinfo.c +@@ -18,6 +18,7 @@ static /*const*/char rcsid[]= + #include "goodies.h" + #include "locking.h" + #include "foldinfo.h" ++#include "acommon.h" + + static const char + maildirtmp[]=MAILDIRtmp,maildircur[]=MAILDIRcur; +diff --git a/src/mailfold.c b/src/mailfold.c +index 917b502..9e3d386 100644 +--- a/src/mailfold.c ++++ b/src/mailfold.c +@@ -371,7 +371,7 @@ void concon(ch)const int ch; /* flip between concatenated and split fields */ + } + } + +-void readmail(rhead,tobesent)const long tobesent; ++void readmail(rhead,tobesent)const long tobesent; int rhead; + { char*chp,*pastend;static size_t contlengthoffset; + ;{ long dfilled; + if(rhead==2) /* already read, just examine what we have */ -- 2.50.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 01 07:54:05 2025 Received: (at 79135) by debbugs.gnu.org; 1 Aug 2025 11:54:06 +0000 Received: from localhost ([127.0.0.1]:55481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uhoKr-0001na-Jq for submit@debbugs.gnu.org; Fri, 01 Aug 2025 07:54:05 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:55446) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uhoKn-0001mn-7R for 79135@debbugs.gnu.org; Fri, 01 Aug 2025 07:54:03 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 27508277; Fri, 1 Aug 2025 13:53:54 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id 1CkuwSK8DrWP; Fri, 1 Aug 2025 13:53:53 +0200 (CEST) Received: from jurong (86.56.141.77.rev.sfr.net [77.141.56.86]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 3C066B4; Fri, 1 Aug 2025 13:53:53 +0200 (CEST) Date: Fri, 1 Aug 2025 13:53:51 +0200 From: Andreas Enge To: Tomas Volf <~@wolfsden.cz> Subject: Re: [PATCH] gnu: procmail: Fix build with gcc-14. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-5.35 / 15.00]; BAYES_HAM(-3.00)[99.98%]; NEURAL_HAM(-2.76)[-0.918]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[codeberg.org:url]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 27508277 X-Rspamd-Server: hera X-Spamd-Bar: ----- X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79135 Cc: 79135@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Tomas, thanks for the patch! Could you add a comment as to where it comes from? Or did you create it yourself? Maybe then this could also be a comment at the top of the file... At https://codeberg.org/guix/guix/issues/1671 I ask the question whether there is a new "official" release; would you have an answer to that? Andreas From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 11:41:26 2025 Received: (at 79135) by debbugs.gnu.org; 2 Aug 2025 15:41:26 +0000 Received: from localhost ([127.0.0.1]:37183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiEMP-0000Qv-TY for submit@debbugs.gnu.org; Sat, 02 Aug 2025 11:41:26 -0400 Received: from wolfsden.cz ([37.205.8.62]:40200) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1uiEMN-0000Qj-4S for 79135@debbugs.gnu.org; Sat, 02 Aug 2025 11:41:24 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 62CE836D72F; Sat, 2 Aug 2025 15:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1754149281; bh=oTlmC2zH4c0v3Inb2alVCar0wmWN4PFw8wvOtGNtSiI=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=fL0834b+qGDK3XL0Kvwl5K9i3d4Irrif8ba2CWByFlEdSLgMLSvTzo+VbgtE4cNQL 1KeGPr+CMULAFyklLTR7eifvVpRCzecxzhw2HIVm0AUz4EOiEQmkNo4oval67Gn3Uq shtpLatPwXlH4CRa+3KjbRB5bw5YAO74Z6ldBHNet5w+iwNKIi78ErAJYzqrXJ8W+u o04t5k/wjQrYTwZvTFD0VaJ6Pp+zeUS1ohLVg2E3D/4LoDjmgxpJXLSdv+EZky4BTT QrK9dIM9HZZxEBj5/koCHJ/yJ2iDwjdASnEjvtmU23CqNILcUVOx3j3N3mUKUVP3rk pM8gSnQjaiBY1OVT36qoL2ommyV+nOTEDaBQ5RiHtgs4d6x0nbUMifyxYe9IRk3hKR wkEjxHmYcflE4AC8zcTDRvNF7hHBg4PBo+CcR7FnXye/SzFuoR64BOl2RXI9sjFdHl 78DzlK1XTvf+aleHNc1nEXAUJGDGhzW4vSV4uxR2pfU2I0i360JLcooh09PF+UQkRP 7qLNXlO+MqZ+9OW5GRwaCop0TEVRCbUI3dnysBx2ZUvETx1HPag7PvYGsMr0zFeF+y o6KeiaCKzgGoIJwXohoKWgMNB4ItjU3JMXT7lmyac2kAPaQPfiOoy1e2lhkSWiLqZD IB0DRcjNsi2k97ahssw6fSv4= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 757D136D7AF; Sat, 2 Aug 2025 15:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1754149280; bh=oTlmC2zH4c0v3Inb2alVCar0wmWN4PFw8wvOtGNtSiI=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=TSwzt6Qfa/f8D/iGCqcM/IcDvSdFNJWhojzWGjlT04HvgR12he8Xa21qjehOVurR4 cd70VcQMgpYPXPJ6zAnSTFtvG2+guptk+mnk0NcXO4i4MoBqJqauX8hIAzNCzJWn5o 0x0eg6AUA/YuJLm1CP/fwF006QBJ0VP4LEn+VGvyT+GK+WeUnMJaFREB5Zhd1ioTgX MxXiYIBJdoOJ6in0v/RpeqhIjh0UQzEqGq79r0L8SSStfPLLdkHYh1qj3GLHQVYSxc 8CEeg1Mn9LquoxVIO033qaEtEntTce/XwPcuf3zqE9J2/vhBgeTvcftbX2w8z2nVqU DxHo3Fqa67alWIfeAm6SDZakjasVj6jUD1iIaB7Rwv2N/FLK8wKsSqoFZwLMsoE9KI d9bSPrvcskK5x4F3m4oD3sPbvqK23oDOLp9qqs0Qt9j6eiKU70W8COEteu6nmpAxQx KFwKDGzal34DCtBTSHk864B/IErH/UQD2JVlc5Fj8hHHNXCJ/0jnbOfumwX7Lm/28i MC3wdMwICVBof4iLkYxm69xQ2ayTzT+ndCelrjBlu5zfb1lB16jjFIkyoK7PnxXgJu o7u9F8TwYvV/7L5R4Z8kgXCXH3Iu9g6Yyr+e2vDw7IvIdH4Ev8a9bCHnGJN//Ytg81 NnUKo5uiQqnoa75YmbvNGPLA= From: Tomas Volf <~@wolfsden.cz> To: Andreas Enge Subject: Re: [PATCH] gnu: procmail: Fix build with gcc-14. In-Reply-To: (Andreas Enge's message of "Fri, 1 Aug 2025 13:53:51 +0200") References: Date: Sat, 02 Aug 2025 17:41:20 +0200 Message-ID: <87bjox689r.fsf@wolfsden.cz> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79135 Cc: 79135@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Andreas, Andreas Enge writes: > thanks for the patch! Could you add a comment as to where it comes from? > Or did you create it yourself? Maybe then this could also be a comment > at the top of the file... Since the patch already has From and Signed-off-by, I did not realize it necessary, but sure, can do. I took the patch from the link ArneBab provided in the issue you have linked below and made few additions to get it to actually compile in Guix, but those are minor enough to not warrant copyright for me. Where should that comment go? Into the package definition (gnu/packages/mail.scm) or into the patch itself? > At https://codeberg.org/guix/guix/issues/1671 I ask the question whether > there is a new "official" release; would you have an answer to that? Sadly I have no answer here. Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 13:06:13 2025 Received: (at 79135-done) by debbugs.gnu.org; 2 Aug 2025 17:06:13 +0000 Received: from localhost ([127.0.0.1]:37417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiFgT-0005O5-9S for submit@debbugs.gnu.org; Sat, 02 Aug 2025 13:06:13 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:46870) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiFgQ-0005Nm-Sl for 79135-done@debbugs.gnu.org; Sat, 02 Aug 2025 13:06:12 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 695E51CA; Sat, 2 Aug 2025 19:06:02 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id LZCOZKapgLjx; Sat, 2 Aug 2025 19:06:01 +0200 (CEST) Received: from jurong (86.56.141.77.rev.sfr.net [77.141.56.86]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0B27DEB; Sat, 2 Aug 2025 19:05:59 +0200 (CEST) Date: Sat, 2 Aug 2025 19:05:58 +0200 From: Andreas Enge To: Tomas Volf <~@wolfsden.cz> Subject: Re: [PATCH] gnu: procmail: Fix build with gcc-14. Message-ID: References: <87bjox689r.fsf@wolfsden.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bjox689r.fsf@wolfsden.cz> X-Spamd-Result: default: False [-5.59 / 15.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM(-2.99)[-0.998]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 695E51CA X-Rspamd-Server: hera X-Spamd-Bar: ----- X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79135-done Cc: 79135-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sat, Aug 02, 2025 at 05:41:20PM +0200 schrieb Tomas Volf: > > thanks for the patch! Could you add a comment as to where it comes from? > > Or did you create it yourself? Maybe then this could also be a comment > > at the top of the file... > Since the patch already has From and Signed-off-by, I did not realize it > necessary, but sure, can do. I took the patch from the link ArneBab > provided in the issue you have linked below and made few additions to > get it to actually compile in Guix, but those are minor enough to not > warrant copyright for me. Sorry for being ambiguous, I really meant adding a comment to the .patch file itself; when it comes from upstream, for instance, it can be useful to make it clear that it can simply be dropped in a newer release, for instance. Given your explanation, I have added the link Arne gave to this issue. Pushed, thanks! Andreas