From unknown Sat Aug 16 10:50:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79128 <79128@debbugs.gnu.org> To: bug#79128 <79128@debbugs.gnu.org> Subject: Status: 31.0.50; shortdoc doesn't always display the correct arglist Reply-To: bug#79128 <79128@debbugs.gnu.org> Date: Sat, 16 Aug 2025 17:50:56 +0000 retitle 79128 31.0.50; shortdoc doesn't always display the correct arglist reassign 79128 emacs submitter 79128 Robert Pluim severity 79128 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 30 09:26:44 2025 Received: (at submit) by debbugs.gnu.org; 30 Jul 2025 13:26:44 +0000 Received: from localhost ([127.0.0.1]:40486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uh6pP-0001DU-JQ for submit@debbugs.gnu.org; Wed, 30 Jul 2025 09:26:43 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58478) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uh6pM-0001Cu-BP for submit@debbugs.gnu.org; Wed, 30 Jul 2025 09:26:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uh6oz-000710-19 for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2025 09:26:21 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uh6ow-0007i1-Qj for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2025 09:26:16 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3b7961cf660so587109f8f.1 for ; Wed, 30 Jul 2025 06:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753881971; x=1754486771; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=qaCBmGt9upOJXJpNufxHgT37mET/bwmeFP7DflX7/M0=; b=OX6bMY0WRZL9ST3tX0tLt8qpTnk2DTm2hEEFWm7SNEY1D1f3u7P+lZ+lsPWjr7qnlf kptWBwRNa0ActQ0Up80a3ztItnFjxai1enHQKS4/Kpkp6Zr5IHf9PUYhR55Hgtq7GB3Q Wybv5uyc7UTI4jNUV3ejrNnQbZPW+fOFBb6B5yBH7raaWU4Jgfv3TV9IScDdhk43pDu5 CrSJQN7oRI7bxmvGZ4D3UtkMvK2fn6GYkdlyPuF+fr+OtErGabShdfVuzCJoQTw8aQu1 mRffx+VhNUy/up5gnqhKX8XfCC2YKW94djskaRloP7kUa8sV/CxEhSYOL4LLYS1iM4xX hDSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753881971; x=1754486771; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qaCBmGt9upOJXJpNufxHgT37mET/bwmeFP7DflX7/M0=; b=ArrDesg4fYjnoZfNkKrbqv36AlY8N8HW/v0cc2WmME+EgaQVNtA7JbkQDW0iVldn+/ 7OlODUtdwUPMsd1d6VGIzvDiEXTwyL67Vfu++jg0gypqfpDixETYSl3UC+d8P4+bdc2S 6aOprR4+TbuTu1n3KMLLKmHRWhzelkDnLG6R3nMU0pTH2xuG6gn8/24W7ubsVK2zHUKe Iw6nf4noCPd1NZGQBqOnkkqyOa9cbsb6m9ypQFGJzIuq0nDbL2U10TXKS+5n/29xSEmE b0NCZuRPMYUlY5U1gCRl1q6HoowWxl3dBrcT7ovC5TyUzJVJtIDEDQ7jBhduA/Va8YBN 6o6w== X-Gm-Message-State: AOJu0Yz1pfkc7jS1U6OYDlNp4Hat7963F+K027/G+7r6JUSLBBVAWD70 +sbD66YuNSXowuoIlTDMiGxjumyn5jnd18nRYzeswXvObF6vJ3Jdwiy83msBJg== X-Gm-Gg: ASbGncuH/ig6E9zSBxFpla3uIAgDXm4x+BGFY/zduT6YlOetCc4hIxB3qi/VXa+V7s7 BCKvEDqs1/9riGM01nXClDuK1PXFE7Tjvp0xf1R43mS1rnPjPOQaiuKa99HSk9SQohtuw+ijnmU aSq4UWSe5WXaMp6rVdViN0H4h27/qRoaObU1fc/vay0VrvS6BAV1EoZcXu01BEHtPVlPMuCxRxI GUe0ejoBT/nP6XV3+FX2sJ4JJRxAj8TaYtDiiczlo3atq0J33X3L6OJqiURIm2Egwq63moU91Tf DFAlyQkol9gwFH1V3jZWnRvkpo+UzpDbzuptWXFqNKi5XG7SgAsjKJYcb4UD7AP0NSVVRVr+b7x GWs6awVDt6Gqjp+M8j5WS X-Google-Smtp-Source: AGHT+IGP11MvqRv5JzCCrO89U3KiIA/EvtxKsw5QPkTQjueeNhV1aLynpklgnmw0B3Yqe3Td8LlM3A== X-Received: by 2002:a05:6000:1a86:b0:3a4:fb7e:5fa6 with SMTP id ffacd0b85a97d-3b794fc18d5mr3041266f8f.1.1753881970874; Wed, 30 Jul 2025 06:26:10 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:d168:7163:fc6b:404b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b7988671d1sm1101714f8f.29.2025.07.30.06.26.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jul 2025 06:26:09 -0700 (PDT) From: Robert Pluim To: bug-gnu-emacs@gnu.org Subject: 31.0.50; shortdoc doesn't always display the correct arglist X-Debbugs-Cc: Date: Wed, 30 Jul 2025 15:26:08 +0200 Message-ID: <87seidajyn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) emacs -Q (require 'shortdoc) (shortdoc 'sequence) The entry for e.g. `seq-empty-p' says: (seq-empty-p arg &rest args) Return non-nil if the SEQUENCE is empty, nil otherwise. (seq-empty-p []) =E2=87=92 t But C-h f seq-empty-p says: seq-empty-p is a byte-code-function in =E2=80=98seq.el=E2=80=99. (seq-empty-p SEQUENCE) Return non-nil if the SEQUENCE is empty, nil otherwise. Other relevant functions are documented in the sequence group. This is a generic function. Implementations: (seq-empty-p (LIST list)) in =E2=80=98seq.el=E2=80=99. Optimized implementation of =E2=80=98seq-empty-p=E2=80=99 for lists. (seq-empty-p SEQUENCE) in =E2=80=98seq.el=E2=80=99. Undocumented I imagine this is some interaction between `cl-defgeneric' with an implementation body, `cl-defmethod', and `help-function-arglist' (other functions in the 'sequence group are also affected). C-h f gets it right, but I couldn=CA=BCt find a simple function in help-fns.el to get me the actual arglist. Robert In GNU Emacs 31.0.50 (build 61, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0) of 2025-07-28 built on rltb Repository revision: d895d8d06e54ec741d495d23b7cdedf978f85da8 Repository branch: master System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --without-toolkit-scroll-bars --with-x-toolkit=3Dlucid --with-xinput2 'CFLAGS=3D-Og -ggdb'' From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 01 03:43:35 2025 Received: (at 79128) by debbugs.gnu.org; 1 Aug 2025 07:43:35 +0000 Received: from localhost ([127.0.0.1]:54324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uhkQR-0006y4-FI for submit@debbugs.gnu.org; Fri, 01 Aug 2025 03:43:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55892) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uhkQP-0006xj-A3 for 79128@debbugs.gnu.org; Fri, 01 Aug 2025 03:43:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhkQK-00079b-0Y; Fri, 01 Aug 2025 03:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wlOUjDVQUqncj+zzTLhfBJldxq4GVnggEVW4C0oWc7s=; b=a+7mrPMacwsCGPIRt92s OdSCy7irHd8JPiATwnYHOzm7TFYEtvtql1r/M5W/PPqdpMcPF3uH12vi2HdFnif7ZIISKo0UaN/rd ++kUMzR9A0XEABbaWU69NwNZ9ju3SOIF9G/SBlLx0O7l5Ulygf/RDUx8Jt2Ajg5+rrIu+DLCs6BdN 5niZyeuEVNm7BWAppz3kIKjRdALcggZJ0RiWZKVUb8eK6pO9+aCAWo2jQno58dzH0o9K/Y0NWxnIm m2jINnMl4emr018fen/Jdzu3aR+EkVNcIWgPPJAUNQR5Fck00IKd8xMimaJIvRCORyT2pvKnh0ArR Droq49orONcchw==; Date: Fri, 01 Aug 2025 10:43:24 +0300 Message-Id: <86jz3ntrkz.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87seidajyn.fsf@gmail.com> (message from Robert Pluim on Wed, 30 Jul 2025 15:26:08 +0200) Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist References: <87seidajyn.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Date: Wed, 30 Jul 2025 15:26:08 +0200 > > > emacs -Q > (require 'shortdoc) > (shortdoc 'sequence) > > The entry for e.g. `seq-empty-p' says: > > (seq-empty-p arg &rest args) > Return non-nil if the SEQUENCE is empty, nil otherwise. > (seq-empty-p []) > ⇒ t > > But C-h f seq-empty-p says: > > seq-empty-p is a byte-code-function in ‘seq.el’. > > (seq-empty-p SEQUENCE) > > Return non-nil if the SEQUENCE is empty, nil otherwise. > > Other relevant functions are documented in the sequence group. > > > This is a generic function. > > Implementations: > > (seq-empty-p (LIST list)) in ‘seq.el’. > > Optimized implementation of ‘seq-empty-p’ for lists. > > (seq-empty-p SEQUENCE) in ‘seq.el’. > > Undocumented > > I imagine this is some interaction between `cl-defgeneric' with an > implementation body, `cl-defmethod', and `help-function-arglist' (other > functions in the 'sequence group are also affected). C-h f gets it > right, but I couldnʼt find a simple function in help-fns.el to get me > the actual arglist. Sorry, I'm confused wrt what is the bug/issue you are reporting here. Are you saying that shortdoc is wrong in what it says? If so, please elaborate why, because I see nothing wrong with what it says, given that shortdoc is supposed to be, well, short. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 01 03:56:24 2025 Received: (at 79128) by debbugs.gnu.org; 1 Aug 2025 07:56:24 +0000 Received: from localhost ([127.0.0.1]:54363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uhkcq-0007oO-CY for submit@debbugs.gnu.org; Fri, 01 Aug 2025 03:56:24 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:46128) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uhkcn-0007o0-0K for 79128@debbugs.gnu.org; Fri, 01 Aug 2025 03:56:21 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3b7886bee77so1411396f8f.0 for <79128@debbugs.gnu.org>; Fri, 01 Aug 2025 00:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754034974; x=1754639774; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=yk1Zfhka3tvBMs60lt4iKYIL2Wmjt4AmjliiajMJBUY=; b=lTX3V5doWke7oskayv27cNyomKsSD6ah3nBKIIa6EQ2WWBYDe+joga8YTC9I7ONUbG O/XI1vOcjXg3QARWp3AcFDS7nYcHLCtoaAnSq6X2K1tcWjcv/RjoGOYoRLOAWQ2rFcWm WU/TsHGxbk0S78HQoxjdGqM1T30wovYtiHfBNlQ69OS+rdfVbhoYEwSVv6p/AcqZnNDd JdwCVu9RxyKiJboQtvEnoRwa/yhgewdIqzPwRQ5fAFMuqHn8bMdPrDcZMF0AcOmw4NK6 dUtpz15/GAjKuqBWypyxYWTSWMkeyc7J/4B4ryzuZhXq6BR4TkUqSOUOHrySTrvx6qi8 LOUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754034974; x=1754639774; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yk1Zfhka3tvBMs60lt4iKYIL2Wmjt4AmjliiajMJBUY=; b=qN+QbCURIkVN0v1qzfeDOpajpDfSACO9JEIeVmBjz/GnNcPUEvca/MOhbGRJcuUWrH Jc8V749/ydiVh/bkUAvmE05MAIu8Fp4CEw8RVqKwUu8OPtE61Xbx3BvQf7Xl7H+J2RQR 98Ld+3/OqQNDXblm1MdTO9fiJ7CsuUZ15sKCuhB7L9uW+TjCSx/wGuxQOVIVcV/5rnVr giemqknXrIZWcKNQRprR79squOhweNb29sRim1khYfO4zMeCFA0S9108VtXd7Qd7hfdP hvMEE1w2Qi6GzC3YshoVgq3/5djCvDh83oQkp8ReGT/eEkalKwRBvuif+nN5i0VUEr+m uDSQ== X-Gm-Message-State: AOJu0YwbzsM92XuivgQwl/Sg7RqCaUmNifBj8Fu+6dTTUS7QVnTvTEJu k0Wn8xXAFf2Rd6qFTTL0N78BQQswkuJZod298UpkM29H5X6u+SfVIeLds8/ipw== X-Gm-Gg: ASbGncu8aCyMc8p5OmsGlcgVGpbxiaDer7odVfMzYtlStSx5DYv3CA/MFeBwKHfy3Zp 9+3qaw4Ar8+JBt2fHf28YS2le5iX9N7cUA52JidAZuYWorvs2bU8zSwSdiRM/oBBsuzuZyIyFv5 5bmVbk/BSqdk3HW3f2z58PheauDrwhryqswVSwQOCJml1bVv6nGS3k6UL5VrHO8MAuMwjf98wFH RMHY2WOHPHXnEJhOmBCkWjOO5dXKwaeli0YzIwBOFhWGnv+gc0958aGVcgFDiFHaydoIg8gGgCo qSSqjrth+TFS7w7hRPJmPe7bd9yFMt+XqpjzyO18V/ifpAd1RBWXuYelKIRPosXa5N5175ASGQF fo0xC6K/OXA== X-Google-Smtp-Source: AGHT+IFXtadGKGA3wuvBOIPj4WLaPX4teobqbUMd31NvWef6Xi1dd5wNf7RgfG+86EMzkn4Fpkqwsg== X-Received: by 2002:a05:6000:1446:b0:3b8:d672:3cf8 with SMTP id ffacd0b85a97d-3b8d67246e9mr462549f8f.43.1754034974322; Fri, 01 Aug 2025 00:56:14 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:dd92:9d19:a53b:17cf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c4530a8sm4955194f8f.38.2025.08.01.00.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 00:56:13 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist In-Reply-To: <86jz3ntrkz.fsf@gnu.org> References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> Date: Fri, 01 Aug 2025 09:56:13 +0200 Message-ID: <87wm7n8ogy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 01 Aug 2025 10:43:24 +0300, Eli Zaretskii said: Eli> Sorry, I'm confused wrt what is the bug/issue you are reporting here. Eli> Are you saying that shortdoc is wrong in what it says? If so, please Eli> elaborate why, because I see nothing wrong with what it says, given Eli> that shortdoc is supposed to be, well, short. Shortdoc: >> (seq-empty-p arg &rest args) C-h f >> (seq-empty-p SEQUENCE) The shortdoc implies that this is legal: (seq-empty-p '() '()) but it gives: Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 2) #f(compiled-function (list) "Optimized implementation of `seq-empty-p' for lists." #)(nil nil) Robert -- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 06:44:12 2025 Received: (at 79128) by debbugs.gnu.org; 2 Aug 2025 10:44:12 +0000 Received: from localhost ([127.0.0.1]:34556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ui9il-0000v0-Ro for submit@debbugs.gnu.org; Sat, 02 Aug 2025 06:44:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54554) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ui9ii-0000uf-Vs for 79128@debbugs.gnu.org; Sat, 02 Aug 2025 06:44:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ui9id-0000RV-AY; Sat, 02 Aug 2025 06:44:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=crwvaxrFRAUQwcO8uDpYiEcMOnunRGP2D8QJQVhEYaI=; b=OPpJp9P4qLg8ejDKr/tJ 5+C6jkyJhfogyo1YgKvMQC1soyxEppzNhJqyCt0Vy1MPBJ7UHoxFYcWNvOnTmc1ymdRApgWJkfOhT rvGkTAyqHhdlEX8F9Fbxdn1nhYXBzAACDugSdylX0n4hBbE7G96K/7zx95UFX68ds4Kd3eKPAczPh 5QwmzSMnykd0VCVfeoA3WO9QxlEqGLcuDIjWAsvWND/nAN5OUObchNObYf3D8HUgOpeGzTUfPfuJP DfysOdKq9oVOMNHL2NrD9v30hh/6W3dzu8777czCZ1UoJ15Kc+Na66HllJ15b28Z601Xfxa3nW1F3 6JkeWIyiTf6Ssg==; Date: Sat, 02 Aug 2025 13:44:01 +0300 Message-Id: <86ecturojy.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim , Stefan Monnier In-Reply-To: <87wm7n8ogy.fsf@gmail.com> (message from Robert Pluim on Fri, 01 Aug 2025 09:56:13 +0200) Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> <87wm7n8ogy.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 79128@debbugs.gnu.org > Date: Fri, 01 Aug 2025 09:56:13 +0200 > > >>>>> On Fri, 01 Aug 2025 10:43:24 +0300, Eli Zaretskii said: > > Eli> Sorry, I'm confused wrt what is the bug/issue you are reporting here. > Eli> Are you saying that shortdoc is wrong in what it says? If so, please > Eli> elaborate why, because I see nothing wrong with what it says, given > Eli> that shortdoc is supposed to be, well, short. > > Shortdoc: > > >> (seq-empty-p arg &rest args) > > C-h f > > >> (seq-empty-p SEQUENCE) > > > The shortdoc implies that this is legal: > > (seq-empty-p '() '()) > > but it gives: > > Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 2) > #f(compiled-function (list) "Optimized implementation of `seq-empty-p' for lists." #)(nil nil) Ah, okay. It would be helpful to know this from the get-go. To answer your question: > I imagine this is some interaction between `cl-defgeneric' with an > implementation body, `cl-defmethod', and `help-function-arglist' (other > functions in the 'sequence group are also affected). C-h f gets it > right, but I couldnʼt find a simple function in help-fns.el to get me > the actual arglist. The function used by "C-h f" to DTRT is help-fns--signature. AFAICT, in this case it basically ignores what help-function-arglist returns, and uses the car of what help-split-fundoc returns: (let* ((use (cond ((and usage (not (listp advertised))) (car usage)) <<<<<< At this point, I'll step aside and leave it to Stefan and others to explain how to solve this. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 15:35:54 2025 Received: (at 79128) by debbugs.gnu.org; 2 Aug 2025 19:35:54 +0000 Received: from localhost ([127.0.0.1]:37889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiI1K-0005bz-Dv for submit@debbugs.gnu.org; Sat, 02 Aug 2025 15:35:54 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63917) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiI1I-0005bj-9z for 79128@debbugs.gnu.org; Sat, 02 Aug 2025 15:35:52 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 952FB10025E; Sat, 2 Aug 2025 15:35:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1754163345; bh=wXkcPCm6FpvyG18yYPCh/mEN+JyXK663U4QLUG3j8QI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NQ410dNEI7D15qW4MxaYyV0S1eLJwZZB4ifmxfgKMOOSOLUhxUMe+8h1ZHtyvj8ya wGLwvk6VpOI5zUP6hZfw16QwRHQh0XggIQby8/fPuFnTsAcd4JYjZNCNImrxTz/SU9 aa66fxq01ZVY/NBdqVUUe4GCUBnkOrUDLzA4DCjaq+hAWL2rib4SkBFr00+NBfKY90 7fZWJa9EuSDYyBwR+f4TppWm5BzRUymBNvsrLLmblWK5xOkCxrWJ0AUIqRdWSmjfY/ poeQHsMMEjY3MGLUCkjMNbMObk16oygnNTrFoclMo2dfaoOv/GLEazcx8A5vCXQb/X 9KgFek5z/ofsQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AF6EE1000BC; Sat, 2 Aug 2025 15:35:45 -0400 (EDT) Received: from pastel (unknown [108.175.226.132]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 84F8B12089B; Sat, 2 Aug 2025 15:35:45 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist In-Reply-To: <86ecturojy.fsf@gnu.org> Message-ID: References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> <87wm7n8ogy.fsf@gmail.com> <86ecturojy.fsf@gnu.org> Date: Sat, 02 Aug 2025 15:35:44 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Shortdoc: >> >> >> (seq-empty-p arg &rest args) Hmm... I suggest the patch below. Stefan diff --git a/lisp/help.el b/lisp/help.el index 65950a2b3a8..d1522ee392d 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -2282,8 +2282,9 @@ "Return a formal argument list for the function DEF. If PRESERVE-NAMES is non-nil, return a formal arglist that uses the same names as used in the original source code, when possible." - ;; Handle symbols aliased to other symbols. - (if (and (symbolp def) (fboundp def)) (setq def (indirect-function def))) + (let ((orig def) + ;; Follow symbols aliased to other symbols. + (def (indirect-function def))) ;; Advice wrappers have "catch all" args, so fetch the actual underlying ;; function to find the real arguments. (setq def (advice--cd*r def)) @@ -2299,7 +2300,10 @@ ((or (and (byte-code-function-p def) (integerp (aref def 0))) (subrp def) (module-function-p def)) (or (when preserve-names - (let* ((doc (condition-case nil (documentation def 'raw) (error nil))) + (let* ((doc (condition-case nil + ;; Use `orig' to obey `function-documentation'. + (documentation orig 'raw) + (error nil))) (docargs (if doc (car (help-split-fundoc doc nil)))) (arglist (if docargs (cdar (read-from-string (downcase docargs))))) @@ -2328,7 +2332,7 @@ (nreverse arglist)))) ((not (member (autoloadp def) '(nil keymap))) "[Arg list not available until function definition is loaded.]") - (t t))) + (t t)))) (defun help--make-usage (function arglist) (cons (if (symbolp function) function 'anonymous) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 04 05:08:57 2025 Received: (at 79128) by debbugs.gnu.org; 4 Aug 2025 09:08:57 +0000 Received: from localhost ([127.0.0.1]:49151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uirBg-0005uN-Pp for submit@debbugs.gnu.org; Mon, 04 Aug 2025 05:08:57 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:43160) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uirBZ-0005u0-Vu for 79128@debbugs.gnu.org; Mon, 04 Aug 2025 05:08:54 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-459d44d286eso3192575e9.0 for <79128@debbugs.gnu.org>; Mon, 04 Aug 2025 02:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754298523; x=1754903323; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=HwdJmxaNYMBC9gngD+S87HN7fvCf8c9nmPEyc/KIf6Y=; b=CiaDNUmhtaeZ6GKtukDZQD8fXLW3s9CIWSHSkCxOGqUUcfXi/FHg0x0SZZdHuuNJxi L0xLO4KUqFTaw+df4n5Dm1bPLsmkJPbyxHIdhWrYd+fKERCA1FNR+xmJBAp6ofYgRvZQ F7oiDBdPJlgdCEGDt6FJ7NCqIKOK+5mty+cfINIlrN8DdKAjq86gH0l2omecOQRO/ACU dps+2AcnsLizbQIJat0ZUpUoEK+3yNcMzkMhJWl+cZ6TV7lKW1E47Pi2sLN/ZXlDmmnd XTjb6IR83VR6CnZPJ1VoB0RawBpjXZRfMooq7lJ/TKSag2fj+okR0UNOwci9dlfVvUqS iyJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754298523; x=1754903323; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HwdJmxaNYMBC9gngD+S87HN7fvCf8c9nmPEyc/KIf6Y=; b=r+2aOCvb5eBosIgaAuzX4ZFDptD+kH7/pl8asATGktbYIcFuTLLlke7cFCkybW2pLu rREEENmBNdOJAxuMcIOHZjNnr0T05ckpJHKklm9e+nZy/7yoIPOT2AWj5AqFiw8c2Agx U+rqHPmOggdRzqcPZdN0V1BcrAES6T9DxN2e48Dil1OvUhqYsVIYJvNA+m+ioE0/sMEd 4lxD2gtye5Xy7vSEaUDoxdIpz8wZzPG1r4BLYGVw1M9PjvHJisyKCdA/V/JFK2RpQ54K SIid7VxVpZE3MBbZf/g8W4Ul6gxwMQbNYm16/VwGQJgRHYhOzdjN1DkjbX41pW0mqt3L auSA== X-Forwarded-Encrypted: i=1; AJvYcCVKjRNMEgelfs39Iihcr75HIqTPiezIgZ7kxE6ls1Q7o17AKpgje2148rlG9Fk+MbCMNEla+w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzsT2A0v9DvYiVs3uLNCjR8dUedbfLgleKggL0W4lza/zhSdbhn LfnnDcEezv9ABQx14Lrz210C9fv+sGbXosFMJGgVjEUNB6VRNMedHWAClBglog== X-Gm-Gg: ASbGnctXo+Hs4wZNingWY58snHtBLzXofIHKqgZrpYZEQvbYHyh+WN3dm7NaHKEtxWG CEaOjjytaOAIloep3bibfYqiMYAprrWPW1ebuk4zxBNzcoWj1oM25nlaryfEgfqDOLqIo2bMGRe CS/W05Q2+d5otFYH6VSRExLc0N1mRMrOppaiBW1RnvbML2dR3WCLPFJOFLL3e0CgN6H6BaRG6A0 +Ungsv1flSMnABgEb2wDRnzOfw4j2wfh9EPW5M0Tupo6Kn4L+IBkVL6hant40dOCJucu2SjH4fC GjW6sgcIAB3bYF4D5GYtb5Des3yHBxSu0L5sXro844Ut0XpCUuvdKoDo9XkWrjUkR/6TL9HM9Jz e83YruuMhnEmcIelnusg= X-Google-Smtp-Source: AGHT+IHRtJDWAiVy1rTcMiZ6AOLzuPwILp5ktbwZzPGMBn7xWf6Ps/PARxIo//SDoeSdJUEMrG8wGg== X-Received: by 2002:a05:6000:26cf:b0:3b7:910d:8054 with SMTP id ffacd0b85a97d-3b8d956a43fmr6559002f8f.11.1754298523170; Mon, 04 Aug 2025 02:08:43 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:72b3:45e2:f92:807e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c4a6f6fsm15177142f8f.74.2025.08.04.02.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Aug 2025 02:08:42 -0700 (PDT) From: Robert Pluim To: Stefan Monnier Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist In-Reply-To: References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> <87wm7n8ogy.fsf@gmail.com> <86ecturojy.fsf@gnu.org> Date: Mon, 04 Aug 2025 11:08:41 +0200 Message-ID: <87sei78ndy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 02 Aug 2025 15:35:44 -0400, Stefan Monnier said: >>> Shortdoc: >>>=20 >>> >> (seq-empty-p arg &rest args) Stefan> Hmm... I suggest the patch below. That fixes `seq-empty-p', but others are still sub-optimal, eg `seq-concatenate': (seq-concatenate arg1 &rest rest) which is defined as: (cl-defgeneric seq-concatenate (type &rest sequences) "Concatenate SEQUENCES into a single sequence of type TYPE. TYPE must be one of following symbols: `vector', `string' or `list'. \n(fn TYPE SEQUENCE...)" The signature is correct, but doesn=CA=BCt obey the "(fn" thing, nor does it preserve the argument names. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 04 16:10:21 2025 Received: (at 79128) by debbugs.gnu.org; 4 Aug 2025 20:10:21 +0000 Received: from localhost ([127.0.0.1]:52764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uj1Vl-0000q0-Ci for submit@debbugs.gnu.org; Mon, 04 Aug 2025 16:10:21 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51516) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uj1Vi-0000pj-3u for 79128@debbugs.gnu.org; Mon, 04 Aug 2025 16:10:19 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7297710024D; Mon, 4 Aug 2025 16:10:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1754338211; bh=YuNoq65lYmnsSm85I2S3lT0gCkXVcyzTCMzAitVNJa8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=isTzcSUroNVDGEV6/UrbwZwj14kqt6kj/9HY6eQJJWy6GDcGE8i6FVi/W+iyj2B1c kZFEfAgFXVZ9H13HqJRWsdTQhysEdsgLxCiA/SRIOFqcbI+fpUSgXp5qMygGwb1jB1 8TeisYgJSjT+GYcZxFwdUKGRWUqBGTehqw3HXFA8sAO34rHRBn0O3gs2mYqbcUjmnS /7Ha7KFo15+NEiLabTjzMz78MsSB8k9aWRE/iffVpd8jYgd4dbkvU43r9uav9O1d0X 9vhhuTLIEdOkZilobgA2ei7z+MRdbmJ9qp3Y5yi+YjQ18G6G0QmfDW3Xbs6bZj9MXP VlQ4FgVTsdtAg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B3246100034; Mon, 4 Aug 2025 16:10:11 -0400 (EDT) Received: from pastel (unknown [108.175.226.132]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 846F9120627; Mon, 4 Aug 2025 16:10:11 -0400 (EDT) From: Stefan Monnier To: Robert Pluim Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist In-Reply-To: <87sei78ndy.fsf@gmail.com> Message-ID: References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> <87wm7n8ogy.fsf@gmail.com> <86ecturojy.fsf@gnu.org> <87sei78ndy.fsf@gmail.com> Date: Mon, 04 Aug 2025 16:10:09 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > which is defined as: > > (cl-defgeneric seq-concatenate (type &rest sequences) > "Concatenate SEQUENCES into a single sequence of type TYPE. > TYPE must be one of following symbols: `vector', `string' or `list'. > > \n(fn TYPE SEQUENCE...)" > > The signature is correct, but doesn=CA=BCt obey the "(fn" thing, nor does > it preserve the argument names. The (fn TYPE SEQUENCE...) syntax is not a "proper" formal arglist, so `help-function-arglist` explicitly rejects it. I'd just delete the `\n(fn TYPE SEQUENCE...)` from the docstring. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 05 03:42:01 2025 Received: (at 79128) by debbugs.gnu.org; 5 Aug 2025 07:42:01 +0000 Received: from localhost ([127.0.0.1]:53549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ujCJ6-0003A7-PH for submit@debbugs.gnu.org; Tue, 05 Aug 2025 03:42:01 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:59468) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ujCJ2-00039q-ON for 79128@debbugs.gnu.org; Tue, 05 Aug 2025 03:41:58 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3b785a69454so2434476f8f.2 for <79128@debbugs.gnu.org>; Tue, 05 Aug 2025 00:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754379710; x=1754984510; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=7YLNrPZUqhOFmig4xISpDK3ejKdL3GA3KrjCu4ef6Y0=; b=MVZXyd4KpTBvmiuxAoFVKpPvyqcNecmLNvFjx3ixFtBCsdsErFMm3lAHlk3CuSmhl7 6xkaups40UEQedWO/husSaLvcsiSZLeyMcNtC19AL5IFer/sJIMqw6QAn9fUr+lhFIIE OkQuECiQAX2mg4Cn1A96M51LXfw1WKx9JXmEgBbhysJsxKR+pXbYFAy2XpAJ+Ns0Rsie DJmSdXII+DIqGALXh5G6I6NHellI1tJC5vISCDJJhqYL50N+wNOABUAw3WLJgIZQbDvf wH5wwMWplVlWyJhsPpGVoJ+M6doWHIiIdd2Uhk6ho5eCFuCkmqtYf/w5LbYiyytg2/cb bQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754379710; x=1754984510; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7YLNrPZUqhOFmig4xISpDK3ejKdL3GA3KrjCu4ef6Y0=; b=E/g5X76//GPxGffANxUtl+Jlyj8w2DvC3cEmajX3xdcKOELJP+E7vurjxLpwErcfGf yhWS+rumG1qY9aRvGJrKI9XgNp15GceviuA5/d+WBeCvhhtlXCN3KrQk5tYvp+sF4FQP X7O8Gpo3sVLx7WogYPCMbU7EBPJxLwAmXIKq7kj25EK4pc6W8QwOEG3SJLqmKsAzzBOw /umc/+6ObeIXb4NjkDWfLdMe3jMJRSOVJRuUiyxXW7VTv1Tdinh0yCqVIE0uYKJLC5df qvUDCzvBP3Js7DEI23exjJ7pm7e/PLsoOGHdVaXglt09HoCO7BW4HcqTQBrOKlw+wIFk ikcQ== X-Gm-Message-State: AOJu0YyQmV2IT5u2kon0SjpqwKCYhnIxPv8eeQmT4tH+b1w+aCF3wCzM f2/aY2KCH/SF7yU9GkangALgd1eRYzHUuSnKTZQ49LI0IgyZ0ZxtAZO6 X-Gm-Gg: ASbGncs+iBXRbIZdJJ9tjy+w8XI2eanxB2TfZlKnRQptdPyNdSc+FCmkuZkM5e3S1YM qFAB0Lq0rtCuoer5LF3sDfA8Z6UUP44B4OlPqKr7gUVLvXoquAW0iIQlYsAHXnR7iU2eN+6oDzg QuQyXlOMEOtCwflhVL899E08k7+vatb55UzK23s3ctSOI6LF+AOC9h98EcAqryUDBhSOqbpAsO0 /tU7pl1I6zfDS/vVBDm6cuvMBNC+ytsp1FyCQ4lMsNLV4C9AN8G08GMLVULzxrkHv8bz/nxPgrA ittc84rYZ8w1+StIvWyUSfD7alJuxx1+HchsDQMpw7rpn0FHk3TefugEhAZ4uPVdFQg2f2EMrE8 ZC1hMDQXk X-Google-Smtp-Source: AGHT+IEQhwkBW1i1dzLc+xIxqsYvlEXcSrTf50cwJji3JxJpGpuE9OxriZF275EX+JsERheN9TUhXQ== X-Received: by 2002:a05:6000:2313:b0:3b7:8e91:fd7e with SMTP id ffacd0b85a97d-3b8d94bb1b1mr9349669f8f.49.1754379709802; Tue, 05 Aug 2025 00:41:49 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:72b3:45e2:f92:807e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c46ee84sm17755489f8f.57.2025.08.05.00.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 00:41:49 -0700 (PDT) From: Robert Pluim To: Stefan Monnier Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist In-Reply-To: References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> <87wm7n8ogy.fsf@gmail.com> <86ecturojy.fsf@gnu.org> <87sei78ndy.fsf@gmail.com> Date: Tue, 05 Aug 2025 09:41:48 +0200 Message-ID: <87h5ym8bb7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 04 Aug 2025 16:10:09 -0400, Stefan Monnier said: >> which is defined as: >>=20 >> (cl-defgeneric seq-concatenate (type &rest sequences) >> "Concatenate SEQUENCES into a single sequence of type TYPE. >> TYPE must be one of following symbols: `vector', `string' or `list'. >>=20 >> \n(fn TYPE SEQUENCE...)" >>=20 >> The signature is correct, but doesn=CA=BCt obey the "(fn" thing, nor= does >> it preserve the argument names. Stefan> The (fn TYPE SEQUENCE...) syntax is not a "proper" formal argli= st, so Stefan> `help-function-arglist` explicitly rejects it. I'd just delete= the Stefan> `\n(fn TYPE SEQUENCE...)` from the docstring. That format is very common though, so I don=CA=BCt think I=CA=BCll be whole= sale deleting those. Your patch is good to go as far as I=CA=BCm concerned. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 07 13:51:12 2025 Received: (at 79128) by debbugs.gnu.org; 7 Aug 2025 17:51:12 +0000 Received: from localhost ([127.0.0.1]:35817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uk4lj-00049n-Vl for submit@debbugs.gnu.org; Thu, 07 Aug 2025 13:51:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52297) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uk4le-00049F-JZ for 79128@debbugs.gnu.org; Thu, 07 Aug 2025 13:51:10 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5CEAB1000BC; Thu, 7 Aug 2025 13:51:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1754589059; bh=nmob7/HO7PvxA0YNddjA6hAGzxLd4O3XKHLUUZq8P9k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HqKQjTOWZKB0wsCue/l1P7bR/JbAuUSdf5nJqwuMzYbrOFZiqX4ZWLUg/GuQCLgLn j1NFyht8XDVcV083y2NjpdwEBlmPDOWFpVcWDINz9q47F1CLmgqBm7hD0ITq4+8jNH RPUBGmYG5oBfJ1X8XfmyoOIdpfdIirrfqIbXRB2lOVJbgRTmOsDJKl2iOzgQ3LD6SL jolVQIm5puCGZSkFh2eMuVALsCjhYfL+W7JxTeDJ6Sid5YDuqOeZB2YK0v6GuIQFS+ MeWELjye5edAUGbD1RJMOvMAkn2mBVYkQoGdjDLpQiLAkMTIe4cuWoui6NcsqSQkQV yrmQlDtKyg/Mw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 97D25100029; Thu, 7 Aug 2025 13:50:59 -0400 (EDT) Received: from asado (unknown [89.207.175.50]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7FBD1208AC; Thu, 7 Aug 2025 13:50:55 -0400 (EDT) From: Stefan Monnier To: Robert Pluim Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist In-Reply-To: <87sei78ndy.fsf@gmail.com> Message-ID: References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> <87wm7n8ogy.fsf@gmail.com> <86ecturojy.fsf@gnu.org> <87sei78ndy.fsf@gmail.com> Date: Thu, 07 Aug 2025 13:50:50 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79128 Cc: 79128@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>>> On Sat, 02 Aug 2025 15:35:44 -0400, Stefan Monnier said: > >>> >> (seq-empty-p arg &rest args) > Stefan> Hmm... I suggest the patch below. > That fixes `seq-empty-p', Thanks, pushed to `master. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 09 08:46:40 2025 Received: (at 79128-done) by debbugs.gnu.org; 9 Aug 2025 12:46:40 +0000 Received: from localhost ([127.0.0.1]:40724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ukiy8-0003Ye-Fh for submit@debbugs.gnu.org; Sat, 09 Aug 2025 08:46:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59070) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ukiy5-0003YQ-Sc for 79128-done@debbugs.gnu.org; Sat, 09 Aug 2025 08:46:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukiy0-0006fa-8M; Sat, 09 Aug 2025 08:46:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lSp7D5G4tweEBjmOpPi7ZDzofUmCNADIWahxG00qxQc=; b=o8TQ/EJonDP1 ZOoH4Ms7+WEUBdM75fgXsW4LBNGttHLwMyFOLg2hfphpRj+Vm/ASf9p0/HnGklAcwupy5cVdT4jhL kgW/RscTyMaEPnBnHQnJ2l85Q4rTAdTXz9Tyx7GGwMoaB1kAi8vUzxafOW31yFpSnjnYET92MsKzV V+Qi5WmYvsLMNLkn+dnW26/DAEcdICBDfX2jlN3d9mqYgGL1gY3VY7ZR/KutfPAPabMXp8tn51eRt hsYzCQ7oA/7Xg4lxCoaMc5VUQDxyPLcMaQ0RK51lxiLI+hwFqjZvZqfF0ICDw91uj8f79lGHrOGre fp1hsh8Gy1X9IHZ7VcAqnw==; Date: Sat, 09 Aug 2025 15:46:29 +0300 Message-Id: <86o6soll22.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 07 Aug 2025 13:50:50 -0400) Subject: Re: bug#79128: 31.0.50; shortdoc doesn't always display the correct arglist References: <87seidajyn.fsf@gmail.com> <86jz3ntrkz.fsf@gnu.org> <87wm7n8ogy.fsf@gmail.com> <86ecturojy.fsf@gnu.org> <87sei78ndy.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79128-done Cc: 79128-done@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , 79128@debbugs.gnu.org > Date: Thu, 07 Aug 2025 13:50:50 -0400 > > >>>>>> On Sat, 02 Aug 2025 15:35:44 -0400, Stefan Monnier said: > > >>> >> (seq-empty-p arg &rest args) > > Stefan> Hmm... I suggest the patch below. > > That fixes `seq-empty-p', > > Thanks, pushed to `master. Thanks, closing.