GNU bug report logs - #79092
[PATCH] fix build ola

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#79092: closed ([PATCH] fix build ola)
Date: Sat, 26 Jul 2025 17:05:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 26 Jul 2025 19:04:11 +0200
with message-id <aIUKi0A0Hc31dKSB <at> jurong>
and subject line Re: [PATCH] fix build ola
has caused the debbugs.gnu.org bug report #79092,
regarding [PATCH] fix build ola
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
79092: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79092
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
Subject: [PATCH] fix build ola
Date: Fri, 25 Jul 2025 12:24:48 +0200

---
Maybe not the most elegant fix, but the next version of ola will target a newer
c++. At the moment ola doesn't build at all.
 gnu/packages/lighting.scm | 36 +++++++++++++++++-------------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/lighting.scm b/gnu/packages/lighting.scm
index 4794400e6e..77f1aade53 100644
--- a/gnu/packages/lighting.scm
+++ b/gnu/packages/lighting.scm
@@ -50,31 +50,29 @@ (define-public ola
         (base32 "0mbf5dc309pqg9ckqgk2kh9p3mf9vqsjkxnwjzqw7yzzf17ij3zk"))
        (file-name (git-file-name name version))))
     (build-system gnu-build-system)
-    (native-inputs
-     (list bison
-           cppunit
-           flex
-           pkg-config
-           ;; For git repository bootstrapping.
-           autoconf
-           automake
-           libtool))
-    (inputs
-     (list libftdi
-           libmicrohttpd
-           libusb
-           `(,util-linux "lib")
-           zlib))
-    (propagated-inputs
-     (list protobuf))       ; for pkg-config --libs libola
+    (native-inputs (list bison
+                         cppunit
+                         flex
+                         pkg-config
+                         ;; For git repository bootstrapping.
+                         autoconf
+                         automake
+                         libtool))
+    (inputs (list libftdi libmicrohttpd libusb
+                  `(,util-linux "lib") zlib))
+    (propagated-inputs (list protobuf)) ;for pkg-config --libs libola
     (arguments
      (list
       ;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
       ;; build to fail on low memory systems.  We disable that with the
       ;; following configure flags.
-      #:configure-flags #~(list "CXXFLAGS=-ftrack-macro-expansion=0")))
+      ;; We also have to omit: use of std::auto_ptr is deprecated, and template-id not allowed for constructor in C++20
+      #:configure-flags
+      #~(list
+         "CXXFLAGS=-ftrack-macro-expansion=0 -Wno-error=deprecated-declarations -Wno-template-id-cdtor")))
     (synopsis "Framework for controlling entertainment lighting equipment")
-    (description "The Open Lighting Architecture is a framework for lighting
+    (description
+     "The Open Lighting Architecture is a framework for lighting
 control information.  It supports a range of protocols and over a dozen USB
 devices.  It can run as a standalone service, which is useful for converting
 signals between protocols, or alternatively using the OLA API, it can be used
-- 
2.50.1

[Message part 3 (message/rfc822, inline)]

From: Andreas Enge <andreas <at> enge.fr>
To: Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
Cc: 79092-done <at> debbugs.gnu.org
Subject: Re: [PATCH] fix build ola
Date: Sat, 26 Jul 2025 19:04:11 +0200

Hello,

thanks for your patch, which I have just pushed.

In the future, please refrain from making cosmetic changes like
reformatting; it makes it more difficult to see what are the real
changes, and also confuse "git blame".

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.