GNU bug report logs - #79079
31.0.50; Piped command output is sometimes lost in Eshell

Previous Next

Full log

Message #131 received at 79079 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: mail <at> daniel-mendler.de, eggert <at> cs.ucla.edu, 79079 <at> debbugs.gnu.org
Subject: Re: bug#79079: 31.0.50; Piped command output is sometimes lost in
 Eshell
Date: Sun, 17 Aug 2025 08:03:40 +0300

> Date: Sat, 16 Aug 2025 16:54:57 -0700
> Cc: mail <at> daniel-mendler.de, eggert <at> cs.ucla.edu, 79079 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> +static FILE *
> +file_for_stream(Lisp_Object stream)
                 ^^
SPC missing there.

> +{
> +  CHECK_SYMBOL (stream);

Calls to CHECK_* should be made by the primitive itself, not by its
subroutine.  This is to allow the subroutines to be called where such
tests were already done, or are inappropriate.  The idea is that only
stuff exposed to Lisp validates the Lisp objects passed as arguments.

> +DEFUN ("internal-close-stream", Finternal_close_stream,

Nowadays we use "--" in the name of internal functions.  I suggest to
call this file--close-stream instead.

> +       Sinternal_close_stream, 1, 1, 0,
> +       doc: /* Close the file associated with STREAM.

This doesn't close the file, it closes the STREAM.  I suggest to
rephrase:

  Close the standard STREAM of the Emacs process.

P.S. I'd like to see what this does on Windows, where there's neither
SIGPIPE nor EPIPE, but that's a separate funeral.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.