From unknown Fri Aug 08 22:14:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79040 <79040@debbugs.gnu.org> To: bug#79040 <79040@debbugs.gnu.org> Subject: Status: [PATCH] ; * lisp/battery.el (battery-bsd-apm): Explain a FIXME. Reply-To: bug#79040 <79040@debbugs.gnu.org> Date: Sat, 09 Aug 2025 05:14:04 +0000 retitle 79040 [PATCH] ; * lisp/battery.el (battery-bsd-apm): Explain a FIXM= E. reassign 79040 emacs submitter 79040 Manuel Giraud severity 79040 normal tag 79040 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 17 08:24:53 2025 Received: (at submit) by debbugs.gnu.org; 17 Jul 2025 12:24:53 +0000 Received: from localhost ([127.0.0.1]:53422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ucNfQ-0002np-I6 for submit@debbugs.gnu.org; Thu, 17 Jul 2025 08:24:52 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38052) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ucNfH-0002mq-44 for submit@debbugs.gnu.org; Thu, 17 Jul 2025 08:24:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucNei-0000WS-Rk for bug-gnu-emacs@gnu.org; Thu, 17 Jul 2025 08:24:20 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucNec-00052I-Hg for bug-gnu-emacs@gnu.org; Thu, 17 Jul 2025 08:24:06 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=zMNDhluK GYZ4l+FjUEwAESZapfbgzEqTbRsLtovtNpo=; h=date:subject:to:from; d=ledu-giraud.fr; b=k4cQj7gwd3ck0Z92QsHwzhxMyTLLnGhUfP2uid5KeSeP65iTcr fKx9g/ClSxl0kL8NPvG68VyIxP4pKivWxgBg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=zMNDhluKGYZ4l+Fj UEwAESZapfbgzEqTbRsLtovtNpo=; h=date:subject:to:from; d=ledu-giraud.fr; b=kFEUgx9lNS4TRPuwzvObO5r/K1O0eWHc7cxGH3McfnVxE5dJY/ 0gx8KF/k9SOCvaC/ZjWz8GorJv1WXB0ZTLa7/BDSm9wCQ/Rbm3WI88miDLV1zFWDm34T9r TddwKtTOh+yGLRajVYIn4/SpP6p3GyMwnzvX7YC0sT8ltJrCOcTWbbfrZQ5uZFoQ35W14U JGmcGP68oO0DwdZkUObQS0z7kQ2pWX8BTDpg6jHp0JXo0FAYkg/sp3NwLNRAfVOIJIColi 33Iri5u/6ptaBVX/sdS9Y+L0/eTNY25w4JnIEh1JihbsymAyzptoVMdXXVkOy3kbksyiFe OOGOa/VYOawg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 1d4f3c05 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 17 Jul 2025 14:23:57 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; * lisp/battery.el (battery-bsd-apm): Explain a FIXME. X-Debbugs-Cc: Date: Thu, 17 Jul 2025 14:23:55 +0200 Message-ID: <87bjpjt38k.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Hi, A trivial patch that explains a FIXME comment. In GNU Emacs 31.0.50 (build 2, x86_64-unknown-openbsd7.7) of 2025-07-17 built on computer Repository revision: ae560ae11c1d4b1ae5e130f3a942364dcaf69b62 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101018 System Description: OpenBSD computer 7.7 GENERIC.MP#52 amd64 Configured using: 'configure CC=egcc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --with-toolkit-scroll-bars=no --without-cairo --without-dbus --without-gconf --without-gsettings --without-compress-install' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-battery.el-battery-bsd-apm-Explain-a-FIXME.patch >From 7b0d47ad9d6d877c1f860b779c7e32ea709a41f8 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 17 Jul 2025 14:22:26 +0200 Subject: [PATCH] ; * lisp/battery.el (battery-bsd-apm): Explain a FIXME. --- lisp/battery.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/battery.el b/lisp/battery.el index a738c3ed131..a7962e046a0 100644 --- a/lisp/battery.el +++ b/lisp/battery.el @@ -951,7 +951,10 @@ battery-bsd-apm %h Remaining time (to charge or discharge) in hours %t Remaining time (to charge or discharge) in the form `h:min'" (let* ((os-name (car (split-string - ;; FIXME: Can't we use something like `system-type'? + ;; We cannot use `system-type' because some BSD + ;; systems fall under the 'berkley-unix umbrella + ;; and we're trying to make the distinction + ;; among them here. (battery--call-process-to-string "uname")))) (apm-flag (pcase os-name ("OpenBSD" "mP") -- 2.50.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 17 09:18:54 2025 Received: (at 79040-done) by debbugs.gnu.org; 17 Jul 2025 13:18:55 +0000 Received: from localhost ([127.0.0.1]:53545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ucOVi-0005Vt-7y for submit@debbugs.gnu.org; Thu, 17 Jul 2025 09:18:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37620) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ucOVd-0005VW-2l for 79040-done@debbugs.gnu.org; Thu, 17 Jul 2025 09:18:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucOVW-0003mk-Er; Thu, 17 Jul 2025 09:18:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g5H6avoVtiNpw+QuoZx88fe9HMrFZ8JQmZlXNTNb0CM=; b=PHlbcJvT8Dbs P16hWRnnBdA+R3Et+76HUI9Ox1Nym9/6KKWeLnP0qHSVuTrO8JqVD5LC+7IcNAT7Q6omcP0AShX2m fx+ZHGbqkvBJsakjG2x/kQPTD1AmE3d9Gfl0MbUVAscY+h/kjBQ9Ny0X4M6xNDoE7f04rzqBv5V5i D2HRQP+1y0pJ+5a32T0JIC/3BoLQW1n4XbTqOawwDvJBCvLedh0+0e7F1LD9t4p38i5Hxtq+15DS2 6rH/FpeqX+5GJrkKWqOT8uXjTZoXi1npoOri2bfjSAoqDAQCBmdH3Yfb6X0IPK4+0F3+ttXz/E94P LDHWXMMKatcULi9nJG2oaw==; Date: Thu, 17 Jul 2025 16:18:40 +0300 Message-Id: <864ivbgdlb.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87bjpjt38k.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 17 Jul 2025 14:23:55 +0200) Subject: Re: bug#79040: [PATCH] ; * lisp/battery.el (battery-bsd-apm): Explain a FIXME. References: <87bjpjt38k.fsf@ledu-giraud.fr> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 79040-done Cc: 79040-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Date: Thu, 17 Jul 2025 14:23:55 +0200 > > A trivial patch that explains a FIXME comment. Thanks, installed on the emacs-30 release branch, and closing the bug.