GNU bug report logs - #79036
[PATCH] Fix pdb tracking for remote filenames

Previous Next

Full log

Message #68 received at 79036 <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79036 <at> debbugs.gnu.org, kobarity <at> gmail.com, michael.albinus <at> gmx.de
Subject: Re: bug#79036: [PATCH] Fix pdb tracking for remote filenames
Date: Fri, 18 Jul 2025 12:47:07 +0800

[Message part 1 (text/plain, inline)]

On Thu, Jul 17, 2025 at 10:31 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> So we need a function called, say, remote-file-name, which, when given
> a file name, even an absolute one, will consider it to be on the
> remote host indicated by default-directory, and will be equivalent to
> expand-file-name if default-directory is a local one, is that right?
>
> Michael, don't we already have such a function?
>
> If we did have such a function, wouldn't it be enough to just call
>
>    (find-file-noselect (remote-file-name file-name))
>
> ?  That is, we won't need to call get-file-buffer, nor file-exists-p,
> right?  Or am I still missing something?

They are still needed because python-pdbtrack-set-tracked-buffer is
not just used to visit file-name.

If the file-buffer already exists, which uses get-file-buffer for
checking, we don't kill it when pdb finishes. Otherwise, the
file-buffer will be created by find-file-noselect and added to
python-pdbtrack-buffers-to-kill.

file-exists-p: For a local file name in a remote python shell, we
cannot simply distinguish whether it is a file on the remote system or
a local file (i.e. sending code from local host), although the former
is more likely. So we need file-exists-p for verification.

Moreover, if file doesn't exist (e.g. the original file may be
deleted), it makes no sense to create an empty buffer/file, because we
don't want to edit it, but to debug the code in it.


The attached patch fixes the original bug and another one of pdbtrack
(described earlier). It also adds a check in case
python-pdbtrack-set-tracked-buffer cannot find file.

[0001-Fix-pdb-tracking-bug-79036.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.