GNU bug report logs - #79035
Remove micro-optimization for Funintern for performance

Previous Next

Full log

View this message in rfc822 format

From: Lynn Winebarger <owinebar <at> gmail.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 79035 <at> debbugs.gnu.org
Subject: bug#79035: Remove micro-optimization for Funintern for performance
Date: Sat, 19 Jul 2025 12:13:07 -0400

[Message part 1 (text/plain, inline)]

On Sat, Jul 19, 2025, 11:37 AM Mattias Engdegård <
mattias.engdegard <at> gmail.com> wrote:

> 18 juli 2025 kl. 23.43 skrev Lynn Winebarger <owinebar <at> gmail.com>:
>
> > Since I haven't heard back, I'm just going to revise the patch set
> > here.
>
> I pushed some patches for removing load-convert-to-unibyte (a good catch,
> thank you!) and fixing unintern.
>
> Regarding read-char etc they indeed don't belong in lread.c but the same
> is true for some other things such as the obarray code. Maybe later.
>

Wasn't sure about obarrays since read0 might conceivably inline code
referencing the initial obarray for performance.


> Looks like this concludes this bug -- anything else?
>
> For future contributions:
>
> * House conventions for commit messages.
>
I'm trying to get there.

* No walls of text.
>
I don't know what that means.  Although I suspect your reaction to that is
something like "Obviously"....

* No benchmarks with -O0.
>

Ok.  Do you have any benchmarks you prefer to see?

Lynn

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.