GNU bug report logs - #79035
Remove micro-optimization for Funintern for performance

Previous Next

Package: emacs;

Reported by: Lynn Winebarger <owinebar <at> gmail.com>

Date: Thu, 17 Jul 2025 03:26:02 UTC

Severity: normal

Full log

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>,
 Lynn Winebarger <owinebar <at> gmail.com>
Subject: Re: Remove micro-optimization for Funintern for performance
Date: Thu, 17 Jul 2025 18:05:14 +0200

17 juli 2025 kl. 17.09 skrev Stefan Monnier <monnier <at> iro.umontreal.ca>:

> Yeah, this static var is ugly, I'm in favor of removing it.

Same here. I don't think it was ever meant as an optimisation, just a quick and lazy way to implement Funintern.

> BTW, looking at the code of `Funintern` I get the impression that
> `oblookup_considering_shorthand` is wrong when the argument is a symbol:
> we should take shorthand into account only when passed a string.

Right. Funintern isn't often used but we could do a better job here.
This bug report was last modified 10 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.