GNU bug report logs - #79021
31.0.50; Unnecessary GC in after-load-functions

Previous Next

Package: emacs;

Reported by: Helmut Eller <eller.helmut <at> gmail.com>

Date: Mon, 14 Jul 2025 20:05:02 UTC

Severity: normal

Found in version 31.0.50

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79021 <at> debbugs.gnu.org, Daniel Colascione <dancol <at> dancol.org>, eller.helmut <at> gmail.com
Subject: bug#79021: 31.0.50; Unnecessary GC in after-load-functions
Date: Fri, 12 Sep 2025 08:35:36 -0400
>> >In any case, the fboundp test is not enough, we should test the value
>> >of dump-mode instead, I think.  Because Emacs might be built with
>> >pdumper support, but this session is not going to call
>> >dump-emacs-portable, due to command-line options or some other trick.
>> Just delete it.
> It's still useful if starting undumped Emacs, no?

Not really: its use was beneficial to try and keep the unexec'd `emacs`
compact, but it came at the cost of a slowdown.  The tradeoff was
positive then because we cared more about the size of the `emacs` binary
then about the slight increase to the build time.

But when starting Emacs un-dumped the benefit is mostly lost because in
that case we care more about minimizing the startup time than about
minimizing the size of the heap.

Helmut's patch looks good to me (you can remove the "probably" from the
comment, tho).


        Stefan





This bug report was last modified 7 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.