From unknown Sun Jul 20 03:28:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79021: 31.0.50; Unnecessary GC in after-load-functions Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jul 2025 20:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 79021 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 79021@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.175252348619865 (code B ref -1); Mon, 14 Jul 2025 20:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jul 2025 20:04:46 +0000 Received: from localhost ([127.0.0.1]:36713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubPPp-0005AL-RM for submit@debbugs.gnu.org; Mon, 14 Jul 2025 16:04:46 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59272) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubPPn-00059w-69 for submit@debbugs.gnu.org; Mon, 14 Jul 2025 16:04:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubPPU-00054g-W6 for bug-gnu-emacs@gnu.org; Mon, 14 Jul 2025 16:04:28 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubPPS-0005Yr-HR for bug-gnu-emacs@gnu.org; Mon, 14 Jul 2025 16:04:24 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-ae0dffaa8b2so938309466b.0 for ; Mon, 14 Jul 2025 13:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752523460; x=1753128260; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=04i79BPkaianxj93hAns8CgL7D86eF5p0bpDIFQt0g0=; b=FiC6x79IcibW/eOLY7E1OpVyj1MK6GSTUaf87izlVdGXGWd0KWWu/u+/qX8vZaVWAc 2VDODflBKqrs2ikclX1QMKTzTxAH2bMm16GPv08gCRpf6MSfT9rAp5rB4avWj018JvIW AlAq0WTOvF90ceNy8A37ABdBzAqgwAhG/Him8WlSEDMISek0O1hXCyHIBr5t1Lk0sVVv Hqzy5tYIKrNwNgF5I3b42UYoS0ASKFHKT30VeDUFwT74LvrO3dDgRHehtjIb4EnzitaQ dUvc47KNsawIWIQw4FX5VC5C+1diQZsPeLzpFPCeqMdOSFfYlENg8+O6Heb6kWMU6kJn P/lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752523460; x=1753128260; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=04i79BPkaianxj93hAns8CgL7D86eF5p0bpDIFQt0g0=; b=eYvpDDxDjWh1StKm48MSAkGzRpseCMqAt8M9sWjBkhhsgL3XRcgUaAXzfPgYZoOojP 4b0v6Ed92Nm17HFnwSWu4cjJBsWARgpytPai1TQzZEYH9Mg+TESvLRzTfEJllj8VQgJO f4mhW40jt78WxOD0Yizh7kSH+pLeMOPlAza83ojgiOzeg5tnXCqV71FiSWElK4Y2vBpa KTULmR1S06IrEin+QQ5Zy8aTOyyP5pc2gN88NLjkGwKCwrbC9qelJxvQh8WzLflmTm9K mkc3HbyxKHKQa4YvHDIJvDSL/VLBoWnsYp/xlYr/oDZEz6wRqCEHmGK5Ril4z1jCm70r Zz3g== X-Gm-Message-State: AOJu0YyaB69lnxaP/bm8HWeC2yv94TpbtmH+6LNS0OcM5GIIgnwGW3KD +x+6boVJiJRcl81+9/dT0E0KNua72H7oBUN7RzJDCOaAVqsdYWDQoMCV3rXlZA== X-Gm-Gg: ASbGnctprJfzFZsDqQvxGdh9W7DGXTMAQcb+WNONeoC9lkYV58mef757hod2wWh1QLj kky7W1bwLaOWmJscD//05SyuejNZkbTpUeHHTntQIZ4O31eVjEK/ZDo4DpL9DYEbqr8KAv+tgid ab+fkUv3o4YPC5L44ISX3yUGxarFUiVf0zY9FHjnpD7Zs5250SoLFuCcuNjX0yxc3JmAvgOTmzQ q5t9RZih7ZiFRwPAifCpO4NIbrYNn3hJF2xhjtGN+Zm5iw3hYGc7wesP7asNsvSwz2KeYvh3imz CYoZ6H8HR5+30+TjGC2/ZYFGuCsEshqGF83Qqf4GFyuHpw6cLK/UpPhZvd5PyaWF/9Lx7Yl18ZM Utx/f29BWs2vx7g1AjpQ= X-Google-Smtp-Source: AGHT+IFUlc/wrc0iMmtIRlEJbIs5+ZYNpwx9h9Y2r82RiRbSb7BDjMD5xpx6hXjFDnaFzovof6NHNw== X-Received: by 2002:a17:907:2daa:b0:add:f2c8:7d3f with SMTP id a640c23a62f3a-ae6fbf2395emr1330562166b.33.1752523459976; Mon, 14 Jul 2025 13:04:19 -0700 (PDT) Received: from caladan ([31.177.115.39]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7edd6cfsm876344666b.38.2025.07.14.13.04.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 13:04:19 -0700 (PDT) From: Helmut Eller Date: Mon, 14 Jul 2025 22:04:18 +0200 Message-ID: <878qkqfsjh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=eller.helmut@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) In loadup.el there is this: (add-hook 'after-load-functions (lambda (_) (garbage-collect))) What's this for? It seems unnecessary. It would be nice to remove this, because without it the time to execute loadup.el goes down from 13 seconds to 6. From unknown Sun Jul 20 03:28:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79021: 31.0.50; Unnecessary GC in after-load-functions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jul 2025 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79021 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Helmut Eller , Stefan Monnier Cc: 79021@debbugs.gnu.org Received: via spool by 79021-submit@debbugs.gnu.org id=B79021.175254665813312 (code B ref 79021); Tue, 15 Jul 2025 02:31:02 +0000 Received: (at 79021) by debbugs.gnu.org; 15 Jul 2025 02:30:58 +0000 Received: from localhost ([127.0.0.1]:38506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubVRZ-0003Sb-UC for submit@debbugs.gnu.org; Mon, 14 Jul 2025 22:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52360) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubVRR-0003Rb-Qy for 79021@debbugs.gnu.org; Mon, 14 Jul 2025 22:30:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubVRL-0005CQ-4y; Mon, 14 Jul 2025 22:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xiM8MpUy5YsU5ge4RPkE7OZaE1wl9EERidxnIUxKT3o=; b=puSHc9MIll4m 2pIA3VlvRjJQrgS8N/XVkAJ7uwEU8FSdViq87PXJPfa136mZkbDbhHvQ5R4cH9ygfa9IlT/9kQr8Q moF1FiyzNSI57QTqM7Elw2gC75XCvgLPzFWNUcBcZrfZmPcY0eeTNRcSJeSQbUP29SUpvJw4LSsyN Tp2v0yo/aeEk4mCFhvQB1bhjQw/ioXiTilNmlqziJhCIEhNz8KsGaggunstLYPvpKyJj69Fk8phGQ a+DE4xNN6bO0zhXJ53fTrQU4X0fVs3bcv0YQWNvhmY1sSsPF9E+c7zT69Us1mX+H02LwchIl/6rZV QP0sewgCdUr7mCTp+9sapg==; Date: Tue, 15 Jul 2025 05:30:40 +0300 Message-Id: <86ecuib2y7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <878qkqfsjh.fsf@gmail.com> (message from Helmut Eller on Mon, 14 Jul 2025 22:04:18 +0200) References: <878qkqfsjh.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Date: Mon, 14 Jul 2025 22:04:18 +0200 > > In loadup.el there is this: > > (add-hook 'after-load-functions (lambda (_) (garbage-collect))) > > What's this for? It seems unnecessary. > > It would be nice to remove this, because without it the time to execute > loadup.el goes down from 13 seconds to 6. I presume this is because we don't want to dump any garbage. Stefan? From unknown Sun Jul 20 03:28:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79021: 31.0.50; Unnecessary GC in after-load-functions Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jul 2025 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79021 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 79021@debbugs.gnu.org, Helmut Eller Received: via spool by 79021-submit@debbugs.gnu.org id=B79021.175258799112595 (code B ref 79021); Tue, 15 Jul 2025 14:00:02 +0000 Received: (at 79021) by debbugs.gnu.org; 15 Jul 2025 13:59:51 +0000 Received: from localhost ([127.0.0.1]:42699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubgCF-0003H4-8T for submit@debbugs.gnu.org; Tue, 15 Jul 2025 09:59:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47133) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubgCA-0003Ga-SA for 79021@debbugs.gnu.org; Tue, 15 Jul 2025 09:59:47 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3341C806C1; Tue, 15 Jul 2025 09:59:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1752587979; bh=RTeXtmzq4BB9MTJa4RES5HlN2S5VPdKrK+9JDYZp1Yg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H1NnkLgO/ggGauAsUfZKYhbhBGCNhE5CAMWZN4b6FiwKLJP3X4m2wcQrOKb1nKzS+ sTgFSlpMQLTrABcNqHdUgyyBdzMRaPMP0r79DWk+9phWuBW20BKnJbephMYx4/SHgp GUQpMFV1l7UfO5FCBmft2xxVgKTwT/LCzH22vYZ8tW4gol85E4NnSu8KoYxoT9+Uad MvSmPkCSTET2V0nnoZd1JoMK8+liGGOl1rUm2V9+s8HmQtcUYgmmPWcm/NXvw2zTba PdRaKcFJ1R2VJP607/Q98pR+Gd16WoYFuAzoYGIUDsUL6TIpclb6TLKeC5cvaM0WOg xo6vWTtQS133g== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3E88C80916; Tue, 15 Jul 2025 09:59:39 -0400 (EDT) Received: from pastel (unknown [104.247.225.139]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 10B181202F2; Tue, 15 Jul 2025 09:59:39 -0400 (EDT) From: Stefan Monnier In-Reply-To: <86ecuib2y7.fsf@gnu.org> Message-ID: References: <878qkqfsjh.fsf@gmail.com> <86ecuib2y7.fsf@gnu.org> Date: Tue, 15 Jul 2025 09:59:38 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.278 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> In loadup.el there is this: >> >> (add-hook 'after-load-functions (lambda (_) (garbage-collect))) >> >> What's this for? It seems unnecessary. >> >> It would be nice to remove this, because without it the time to execute >> loadup.el goes down from 13 seconds to 6. > > I presume this is because we don't want to dump any garbage. > Stefan? AFAIK it was added to keep the dumped Emacs' heap "dense": if we run the GC only "in the normal way", the heap objects created during `loadup.el` end up interspersed with more free spaces. It's possible/likely that the portable dumper has made that unnecessary. Stefan