GNU bug report logs - #79002
[PATCH 0/3] Update gopls.

Previous Next

Full log

View this message in rfc822 format

From: Tomas Volf <~@wolfsden.cz>
To: 79002 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>, Ashvith Shetty <ashvithshetty0010 <at> zohomail.in>, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [bug#79002] [PATCH 3/3] gnu: gopls: Update to 0.19.1.
Date: Sun, 13 Jul 2025 00:47:32 +0200

* gnu/packages/golang-apps.scm (gopls): Update to 0.19.1.
[arguments]: Use go-1.24.
<#:phases>: Add 'set-env.
[native-inputs]: Add go-github-com-fatih-gomodifytags-modifytags.

Change-Id: I5d3b371f3eadf0e6f28d3def228849e46772b7fb
---
 gnu/packages/golang-apps.scm | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/golang-apps.scm b/gnu/packages/golang-apps.scm
index c0a35c2e2a..36ea2b7620 100644
--- a/gnu/packages/golang-apps.scm
+++ b/gnu/packages/golang-apps.scm
@@ -124,7 +124,7 @@ (define-public gopls
     (name "gopls")
     ;; XXX: Starting from 0.14.0 gppls needs golang.org/x/telemetry, which
     ;; needs to be discussed if it may be included in Guix.
-    (version "0.18.1")
+    (version "0.19.1")
     (source
      (origin
        (method git-fetch)
@@ -133,11 +133,11 @@ (define-public gopls
              (commit (go-version->git-ref version #:subdir "gopls"))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0s396bjwac1acrlpbp7k7xfyhmkykyxc08w6hirbdhlq8vg923p7"))))
+        (base32 "1dihdw4nzp21hlbwxf6qyhyfgavi1a55lmlyk36czd85v0jcp6a0"))))
     (build-system go-build-system)
     (arguments
      (list
-      #:go go-1.23
+      #:go go-1.24
       #:install-source? #f
       #:import-path "golang.org/x/tools/gopls"
       #:unpack-path "golang.org/x/tools"
@@ -153,9 +153,14 @@ (define-public gopls
             (lambda _
               ;; XXX: Write a procedure deleting all but current module source
               ;; to cover case with monorepo.
-              (delete-file-recursively "src/golang.org/x/tools"))))))
+              (delete-file-recursively "src/golang.org/x/tools")))
+          (add-before 'check 'set-env
+            (lambda _
+              ;; Required for fingerprint_test.TestMatches.
+              (setenv "GODEBUG" "gotypesalias=1"))))))
     (native-inputs
-     (list go-github-com-google-go-cmp
+     (list go-github-com-fatih-gomodifytags-modifytags
+           go-github-com-google-go-cmp
            go-github-com-jba-templatecheck
            go-golang-org-x-mod
            go-golang-org-x-sync
-- 
2.50.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.