GNU bug report logs - #78994
31.0.50; [PATCH] php-ts-mode: `php-ts-mode' depends on `mhtml-ts-mode' instead of JS,CSS and HTML.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Subject: bug#78994: closed (Re: bug#78994: 31.0.50; [PATCH] php-ts-mode:
 `php-ts-mode' depends on `mhtml-ts-mode' instead of JS,CSS and HTML.)
Date: Sat, 09 Aug 2025 12:59:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#78994: 31.0.50; [PATCH] php-ts-mode: `php-ts-mode' depends on `mhtml-ts-mode' instead of JS,CSS  and HTML.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 78994 <at> debbugs.gnu.org.

-- 
78994: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78994
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 78994-done <at> debbugs.gnu.org
Subject: Re: bug#78994: 31.0.50;
 [PATCH] php-ts-mode: `php-ts-mode' depends on `mhtml-ts-mode' instead of
 JS,CSS and HTML.
Date: Sat, 09 Aug 2025 15:58:39 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: 78994 <at> debbugs.gnu.org
> Date: Thu, 07 Aug 2025 22:07:45 +0200
> 
> Ciao Eli, thank you. 
> Attached is the new version of the patch. 

Thanks, now installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50;
 [PATCH] php-ts-mode: `php-ts-mode' depends on `mhtml-ts-mode' instead of
 JS,CSS  and HTML.
Date: Fri, 11 Jul 2025 17:35:38 +0200

[Message part 4 (text/plain, inline)]

Ciao,
this patch replaces the dependency on {js,css,html}-ts-mode with the 
dependency on ‘mhtml-ts-mode’. 
Code maintenance should now be easier. 
Additional benefits are:
1. Imenu now exposes symbols for all of all languages,
2. navigation now works correctly for all languages,
3. outline works for all languages.
Additional new features are:
1. indentation of PHP in mixed buffers with HTML now works much better and 
allows three different behaviors, an option allows you to choose the behavior.
2. a new feature shows where PHP ini files are both locally and remotely, if 
the buffer is associated with a remote PHP file.

The patch is a little long, but I hope it's okay.
Thank you.

Vincenzo

[0001-php-ts-mode-depends-on-mhtml-ts-mode-instead-of-JS-C.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.