GNU bug report logs - #7899
23.2.91; Unsatisfactory interaction between shell-mode-hook and comint-read-input-ring

Previous Next

Full log

View this message in rfc822 format

From: Pete Beardmore <pete.beardmore <at> msn.com>
To: 7899 <at> debbugs.gnu.org
Subject: bug#7899: Unsatisfactory interaction between shell-mode-hook and comint-read-input-ring
Date: Mon, 27 May 2013 08:44:25 +0100

[Message part 1 (text/plain, inline)]

[patches against bzr master attached (hopefully!)]

hi,

i believe this is a bug in comint-read-input-ring. shell-mode sets a  
buffer-local version of comint-read-input-size which is effectively  
ignored due to comint-read-input-ring's use of '(with-temp-buffer ...'  
. i've lost ~40000 line bash history on more than one occasion over  
the last several years and am elated to have finally pinned the  
problem on something

(very loosely) related to this issue is the question of why the  
default of 'comint-input-history-ignore' is set to anything at all?  
it's currently "^#", and therefore without having pro-actively made  
any changes to their emacs setup, a user's shell history (for  
instance) doesn't emerge unscathed from a trip through comint if it  
contains comments. if modifying this default touches too many other  
comint uses, perhaps an override in shell-mode.el?

cheers,
Pete

[0001.comint_.ensure.buffer.local.comint-input-ring-read-size.variable.is.visible.throughout.input-read-ring.diff (text/x-patch, attachment)]

[0001.comint_.don't.strip.anything.by.default.on.comint-input-ring-read.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.