GNU bug report logs - #78987
30.1; Unable to create new Git repository in Dired mode

Previous Next

Full log

Message #67 received at 78987 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: stephen.berman <at> gmx.net, 78987 <at> debbugs.gnu.org,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode
Date: Sun, 13 Jul 2025 12:12:20 +0100

Hello,

On Sun 13 Jul 2025 at 10:54am +03, Eli Zaretskii wrote:

>> Cc: 78987 <at> debbugs.gnu.org
>> From: Juri Linkov <juri <at> linkov.net>
>> Date: Sun, 13 Jul 2025 09:58:59 +0300
>>
>> >  (defun dired-vc-deduce-fileset
>> >      (&optional state-model-only-files not-state-changing)
>> > -  (let ((backend (vc-responsible-backend default-directory))
>> > -        (files (dired-get-marked-files nil nil nil nil t)))
>> > +  (let* ((files (dired-get-marked-files nil nil nil nil t))
>> > +         (backend (or (vc-responsible-backend default-directory t)
>> > +                      (vc-backend-for-registration (car files)))))
>>
>> The original recipe still fails with the same error.
>> Shouldn't 'vc-responsible-backend' be wrapped with
>> 'ignore-errors' in 'dired-vc-deduce-fileset'?
>
> There's no need for ignore-errors; instead, vc-responsible-backend
> should be called with the second argument NO-ERROR non-nil.
>
> The original patch did precisely that, so it looks like some snafu
> when applying the patch; now fixed.

Oh, my fault.  Thank you for the fix.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.