GNU bug report logs - #78987
30.1; Unable to create new Git repository in Dired mode

Previous Next

Full log

Message #17 received at 78987 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: 78987 <at> debbugs.gnu.org
Cc: zipeilu <at> qq.com, Stephen Berman <stephen.berman <at> gmx.net>
Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode
Date: Fri, 11 Jul 2025 10:05:00 +0100

Hello,

On Fri 11 Jul 2025 at 09:36am +01, Sean Whitton wrote:

>> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
>> index e5b08af2a30..d8b195d9a12 100644
>> --- a/lisp/dired-aux.el
>> +++ b/lisp/dired-aux.el
>> @@ -4022,8 +4022,9 @@ dired-vc-next-action
>>  ;;;###autoload
>>  (defun dired-vc-deduce-fileset
>>      (&optional state-model-only-files not-state-changing)
>> -  (let ((backend (vc-responsible-backend default-directory))
>> -        (files (dired-get-marked-files nil nil nil nil t)))
>> +  (let* ((files (dired-get-marked-files nil nil nil nil t))
>> +         (backend (or (vc-responsible-backend default-directory t)
>> +                      (vc-backend-for-registration (car files)))))
>>      (when (and (not not-state-changing)
>>                 (cl-some #'file-directory-p files))
>>        (user-error "\
>
> I think this is okay, please install.

No, wait.  I think that we need to pass down the allow-unregistered
argument from vc-deduce-fileset to dired-vc-deduce-fileset, and only
if that's non-nil can we call vc-backend-for-registration.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.