From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 17:56:22 2025 Received: (at submit) by debbugs.gnu.org; 9 Jul 2025 21:56:22 +0000 Received: from localhost ([127.0.0.1]:52891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZcm0-0001P6-SV for submit@debbugs.gnu.org; Wed, 09 Jul 2025 17:56:22 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53792) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZajO-000317-2T for submit@debbugs.gnu.org; Wed, 09 Jul 2025 15:45:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZajC-0008Mh-H7 for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2025 15:45:14 -0400 Received: from xmbghk7.mail.qq.com ([43.163.128.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZaj5-0002B4-OF for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2025 15:45:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1752090303; bh=V+FYuiS/taf6px2P++TQS+usvwISYFpq50s+/5d6CN8=; h=From:To:Subject:Date; b=ZzTq++8H2InkuzfE5K57zw7GafJiGLXCa37f2w2AUv7xc6en7tP1+RthCujq2UhjN OHxk68bpKS6Tvb6i13Jj4ozrmfS+r3a0M/8rtXHN+c/KodweqT4zn3N8BlHKzK/g9q Co2tEiLxippmbEzTMXZeqBKnWH5Tx5/+f5Z/sLag= X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= X-QQ-XMAILINFO: ML14FDrYvfMHaRQtodLZWRw18VXw/+y9Q3J4434RKHl1bp/A5TEipe+QesQX2W sPAbrXAERUurvoGYJ8CuSVDHleiULS8Pf+jIBD0Mga2Cl3C8CYy/NX8ydD/ESZuzkMjsjiblHypNb 7kdZkHkN+mutp2kQg2f7CBI48vRF/dpheRrNKK8QuErjxYv7zshJerLal1SlZb60jO1ZSpFOKHWY8 H+Ceei3tLbIU8/COa3Q+C/mu7SX4lfRXSela33U8gxmf0qV7to4vdWUeRwZfolHsuStrHrDoNzRx9 J2vzEdH4xCjSIW+Dp3O0q60QkknJo8+2TuD/9DtRl5PD+rO0bhorycn8YNZLRUM/h75d+3/jD3peN ORZNZwo4fr1EhrGE+KoJ1qdazsoC2EijfegYxvILu+Lju6ZRAfP41E9ERKMIahiY9RAWncmRqkExl /j/fE2MU0/mqY8CEGex5SCoKGLdWj62y3iVQn6P17bGSrV+pnY4ypURBh2wn3SFAMrGWPT5D2DNfh Yrc/O/uV++9degdvVAAjDrMaXEizOw7ThQhZaPeLzq/XgKxtWPtaDLK/ZAirdd6ZU60nnjO7dntN8 AqKZMOk+hXR1RA1tQoBv1EDkLykBmtb9D9ZbTyCQovwmkTP22I6/ZAqoGv36++iGFqEFDalYke3oN 1ref70mQFftCr1W27hBKoxgYSYWUQPLSpQ4ZAszE2v/vVNYMG7YXxdwffCPmwpFDpS9NZScHclvl0 Rfekc2gF4u4WonbC673SSGMo5LB8+bf9UsLxfCeX2TELTr2PX7KqRKM48UsTMZPQsXK5tYFUQmGKT Cvgaa3y3pmYyXgdXYrZdEj/kBSBnehAWCQNTDnDDOnUM9+wxg5KCweGCWOFWTrHQJYaKnGO4CWU+k wSO+dXNnx/3l5+2ZhGBjRcwnIyStwk9t57F5ggEkVRh5EOhWEKtxHNeVJA+jqivjeow628Zi14eLD AlwgkqAVu8V7442VVLrOn3TRzc5vuOHX+30eUHGQ== From: "=?utf-8?B?WmlwZWkgTHU=?=" To: "=?utf-8?B?YnVnLWdudS1lbWFjcw==?=" Subject: 30.1; Unable to create new Git repository in Dired mode Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Date: Thu, 10 Jul 2025 03:37:40 +0800 X-Priority: 3 Message-ID: X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x X-QQ-mid: xmsepub6-1t1752089860t9le6vkvl Received-SPF: pass client-ip=43.163.128.54; envelope-from=zipeilu@qq.com; helo=xmbghk7.mail.qq.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 09 Jul 2025 17:56:13 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) SGVyZSBhcmUgdGhlIHN0ZXBzIHRvIHJlcHJvZHVjZSB0aGUgYnVnOgoxLiAnQy14IGQnIHRv IGFyYml0cmFyeSBkaXJlY3Rvcnkgd2l0aG91dCBhbnkgdmVyc2lvbiBjb250cm9sIHJlcG9z aXRvcnkuCjIuIE1hcmsgYXJiaXRyYXJ5IG51bWJlciBvZiBmaWxlcyB3aXRoICdtJy4KMy4g VHlwZSAnQy14IHYgdicuCgpUaGVuIHRoZSBtaW5pIGJ1ZmZlciB3aWxsIGRpc3BsYXk6CgpO byBWQyBiYWNrZW5kIGlzIHJlc3BvbnNpYmxlIGZvciBjOi9teS9kaXJlY3RvcnkvCgpBY2Nv cmRpbmcgdG8gR05VIEVtYWNzIG1hbnVhbCAzMC4xLjMuMSwgJ0MteCB2IHYnIGlzIGV4cGVj dGVkIHRvIGNyZWF0ZQphIG5ldyByZXBvc2l0b3J5IGluIHRoZSBkaXJlY3RvcnkuIEhvd2V2 ZXIsICdDLXggdiB2JyBjYW4gc3RpbGwgYmUgYWJsZSB0byBjcmVhdGUKbmV3IHJlcG9zaXRv cnkgaW4gdGhlIGJ1ZmZlciBvZiAgYSBmaWxlKE5vdCBpbiB0aGUgYnVmZmVyIG9mIGRpcmVj dG9yeSkuCgoJClppcGVpwqBMdQp6aXBlaWx1QHFxLmNvbQ== From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 20:29:59 2025 Received: (at 78987) by debbugs.gnu.org; 10 Jul 2025 00:29:59 +0000 Received: from localhost ([127.0.0.1]:53327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZfAj-000451-4Q for submit@debbugs.gnu.org; Wed, 09 Jul 2025 20:29:59 -0400 Received: from mout.gmx.net ([212.227.15.15]:37209) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZfAc-00042Z-63 for 78987@debbugs.gnu.org; Wed, 09 Jul 2025 20:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1752107375; x=1752712175; i=stephen.berman@gmx.net; bh=kDSoy66D5UBlXtVNO6WErrL0KOuiA3hQWtrbsRCSl5s=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Gw8xMblPJAFEXPZmZwcYYte4dyeyH5eUgP2KYX1gvCWVeqrfCNkSHOgx4YQBxnAm qgkiOJlb7TQFpSnYyjv56bvYWYAUYemg5W5zOaHNjh7ZfJITkC7oaJSR0/qmmA/Ho mAy149LN6x5E+VFkUSb7OoscPVEzGDq4rR+GYAf9/cOEbmeqky5OsZYXQb9HQzpfI SteBwArXB44CnNdsOU52XDox0Pu6uREXy3em2eyJhwTVp/OxA06V/TTpR+IYvdDJO STtYYopAZ3bFls/G7X5OTnx2/+YnL9I5u/alxEhmSAqHtS4erThSJa0Zlu97fhBYz eTqM53kC21KDNqjhVg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.49.212]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1ML9yS-1uHaJh0cmA-00JrD2; Thu, 10 Jul 2025 02:29:35 +0200 From: Stephen Berman To: "Zipei Lu" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: References: Date: Thu, 10 Jul 2025 02:29:34 +0200 Message-ID: <87h5zkanwx.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:zCvZ2z2zNSEgjjzm6h1c/X1fcgIj0cmraLx/A0yvSHxTfvg93NI gN28zxBv7E62NGLzO1xfKOjcn0WgZuQxF5NwCoqeEodDGsG013nsgsjJ8S99jo/s4oFzQIz o9QF0cdG/00GgVRIsKRVh98HUyggZ90gpdBZ9tOHxQSRp5KWXOuA5Lx3HrdL64AtGeQdxKB niZI79H4gczhQMVAf8lFg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:3VHDPVMjKTo=;bpiGo60u1pj+V5OXgCrPsXZedCF sruiRlA+aX1hOjJ00SOFSQlzJxQV/1uTmy0O0RuNGWWtWztilgt3tKyj1QpVnZABR8FvexBAN 25j0/qOtAEwUiNA1qTvqfwW85QjLnMI01xag2nyHULem0rz5HzzJAHKCjTVbo6lSE/XBWZpEy SHOjjoU913gO3veibmLJv9C6YANGFOn3TTXZBS8y2J9EbrBhPaXYmy9WVe65yuYSz0c5IFJoa IAWh7R/VaZp9Yi7nSdptxR/CaFbre2bjNFvDcvZDU/yh+FcmgALjmC7u5U3XcES6diD44EnGC GQCKSX8WDEDoXBICeNAM66LskIJ7ISlR+x1/XQxEh1a0cx1c3Ryr5z7UMOCjZRuJmRegzfSrQ nzPQRmHjsxGQI6sVW1ScT3FVhGNyBqjWRlyBjDhCzKLLgebxJblldfcC43f1L56+6UHHC0vnY fW8mMt5kxD77lKIwc2iLcFHloBaw+RZoR+N5TUlDIPZlDIvAHJkNhh771l62PiSQWyfgAaEil HvK6TGofzzQelu/+1KdyfmMT7e65G3b2b+DUUDQMjO3/35KBhXjkZADD2XrPANHzFqVx3TEtq l3Q5wNySSfVDF2dJBkWYUerJOoZjkHzm3jXnLXSW5ltlZHDSbXxMzOuX3yUhBzEgTJxzuobKE Vfcuf7Aq1GlUYI3qJLNM+jA9j0nCeztpWhLuMwDVrnTk28ywwhyFiPVYvjdZmtT82vkDwm1Y8 Oq2PNPX91FkD6QnGvoacDcK/3vVy/NioZhNzc3mjuVG3oJFIdf51FC+6g+HTXbZj72aKDUYkm fgU+wNvYPHjobcZPMdnpHOmCM1/av4W53aHX/AkI/Re88UQGTEQmlgYXNCykoJJpof9Q9+61H 2Xt+txcxJaCahqxOWO46C/dZ98y/3+jMPUJTqJJiyzWEHpBrrTmUKYNa2Oj88kqhz1Lhh4nkl Kmf6D1tXex5hnifPGWWkBVQblfvb2L6z7DGL0jmhqZEewlUh0G/Zupq3omSb7fGwJ8aUfdQvE e5+2zGQlyED9J8vy7LJvp02dWF0bONG8N4Fw5RFZHAmvOGeQ7XHLwtjwh54wPAHaQJne/uw90 CUTYzPhJiw6ZvERo6wZvsDpbi78ISUVl0uXNjIqFzOvYr0SZiJcBmxyKpEfPz7UNB9/EPNNwA 1JJvJXS506SAtySbza8fvsJfwBq9vkKvh/mT4ySJ0u1ydil5th18AXio1J07rt99TCd4VHYyu ebGsmRdHuKa3X19g7Ei/rvqG3UOasAWebf+dF/7zK816V7j9cKJWUtrxp2svGH8iPWhfF5ocH UrYYLSgm+xg50JshQqD/pufzwBvHXa1uLRIG+G6JsuWARehbZlWZR997Ut7MklBNgeMZd/7rb uI8W9F01y9VPpbweb474ijfm/Z+Vl2daQy9rRx5X+kBYj8amNs+D7YTqLOzb2S9UW8wF+nqSl fROqVsjR6363n5WWyWRMtRSympRXwhY95EMw8XlzC8bSg1pD6Vh1xe1lqAhZNv//lvk9lph1l 8m+eHqVguiHBPW2epddoLQqmY6TDG5G1YIWwH6aH5L24+/GdhY3+8eu0/mlYGqYdGV+XpskL+ E84pZOXxE2iXoPNI/Ps2Jz0Py8Nht+NeKh5Bu9LD6koGJAZMQx2GCWykGs3RIAXIlmPhAHrwN +YQ/8Uwb/Yeb15WofYJkTci4DoKXAGqm8O6itSbO+AFP9scr3hb+cLjIm4IweKgk53T5SiKHI /Gy1d3mfxr8UbQzQGaZnwN4BNlR48WQdGsRWljcA6RAQ6WmZRtFEiYmLV7FmjrgggTWvVtemd JauRsYxJhgl/3poBKkujgU4JvEVrmb4tSedr9Dp3IO1fBsySgfSWYOp6YM8Kz5NzdEdtSVML4 FINRehyNg7bIipq+B8TWg1z5ybx2qRBmI4dUDvWKDldJVCL9A0DTHR4yzcBVjtc7xjSVrmTHx AU7xP63ci7i166/yZRfggnes2DymFO05JiiolkIKtuHPqrxiImubQ6rbGbZrm/v8HFV8Ljfam +Q/KjIuJUfnp5Ribo4eZKyXfKwsCcR0cGn/fzXmccYxu/N4ckp61pUEERU5/eFDpK2cy0qSg3 9SwkhYNDkCAK9W4iqKa6uwB6GLIOuZHWq2v5wy7s2I540/Y3l2pnOrWR2Eoe86fv2hqa+ED4b CzPSLAZhqw4Y7D2DnOfO7wjo7R0GpeM+N9HiTwfx3ie2TjkUROsYY/uA2meDT6nRP+VLodb8a DcUp2uD/iJsdAnOFEhOuv4vh0zW5egEphUmkA8Pld88NlDy5b26pqHGZicH5IKf4kEqqIIFY1 VXcwddTkZYPCorw2AcPrIti+yU6nu1Wb3HymtOEUMreTx7FDXGbApitpPlIaEA5146fKhciWv 1xy5S9jUpkWCOUoPsUytvIck+JeIW3oFrSMJkkjzmqrFsGJFhIq2FgC8SMixjbkCWtjt1Pshe 9HhDAli7jH1zhPfcI++Mke/+cYrIaK3DYM1WeWpBCG5XTcYqdOCtiOtX4fD1W/3Jrf7xr1B/J SJs1rNJB17C/0djCTlDd5qb3bhzDPNYDph5O6fdoqaBeSqYpIjtTLjfdSzvxVt3Krm21tsvH+ N/ecAcWp2CM37zuNOEbvgKdXBNSs1Y6mMS/CxVkvDVCG6ak8Z/b17+jArBm7YYXSclPScM2id qXrHdeb3n/BQ0mfowcp7JwboHfELNAAo6UAz2Csa36a2a6qGtsVlB42dOTBN5X4UTvMWDyoPl vSGtN0IJhtWNz3g0Px/k3DnXNlhi/j+1TSo9WVfVgYJIFxXIgP8k88R3yhkDqZHbaPjZhQk62 54aR08vvULimVujfm/j21rWeYSayh8yg7CPX1in8E+r9kN0QjhjwlFfgS9UeADocJpKlLwn3l NuvRYzD8fRBf8+N6RW9VKGaMXC/p3sbR23htOoUqfhdEJ0npjIya6Va34/Nd6DyWTngGwa9RI gPD/jn8lRJNTcJTgaquoMqHtbwWx9Nm0YPjz6rMbHet/UcRrtJ6++XnsW9zS/tU8iVOqL9r1N WQtgCezqxsc3MEQDfpxjKH1YouONN0+WGpD5gyJAfmOvJnZxrvC7mNt9mWKI+r7ZDQQFNCK0B x1Gfy7LzGFckfEFQY7SFQM/ntAIrwGlLBQ4OGPdvI6VEVlCXgj+SOWEH1l5VnVRxblJl4hWHz N5CvUtVbdgvxHezGpZixC9eeVlbYkhwkoE/nS2qSUiihQ/EU13BzvMnSGipHXJLrcd7el5pgp r4SqCBqSmhvqRc6fqHPKO2T2szUW8zmgu8JdKZm/04nzf39tC4aWGaKJj0acrsXpNR+fcnvGf dDR4hQ8x1NDoc7jyhuPdSJzmsmZhfnirb2F7y4nYuzJ0npK3omBoKEQKN2PFyBH7rtVAyTP73 GGUjqJAqK7ndwXfR3nd/MJr3SVJsxJOy1nzNmP51R0dod5fSmFvBzYXSu3in5g1IfJ5Jp0kSx CHWTQWLzCJXgtAZEEG5yVLCrYrdSdeRQ8enI8cJyiAd6qUythOPpwCu20dzMF3j6avMIUPFT7 2imthOs8nvbBhCKSy6+A5SB3XdSGdEPZfZjQm+jli0h0SzxFjxVt9XypjaBWa+YN5rEKmEqFK +3tg+IwZmUViLI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78987 Cc: Zipei Lu , 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On Thu, 10 Jul 2025 03:37:40 +0800 "Zipei Lu" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > Here are the steps to reproduce the bug: > 1. 'C-x d' to arbitrary directory without any version control repository. > 2. Mark arbitrary number of files with 'm'. > 3. Type 'C-x v v'. > > Then the mini buffer will display: > > No VC backend is responsible for c:/my/directory/ > > According to GNU Emacs manual 30.1.3.1, 'C-x v v' is expected to create > a new repository in the directory. However, 'C-x v v' can still be able to create > new repository in the buffer of a file(Not in the buffer of directory). This patch seems to DTRT, at least on initial testing with -Q: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: dired-vc-deduce-fileset patch diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index e5b08af2a30..d8b195d9a12 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -4022,8 +4022,9 @@ dired-vc-next-action ;;;###autoload (defun dired-vc-deduce-fileset (&optional state-model-only-files not-state-changing) - (let ((backend (vc-responsible-backend default-directory)) - (files (dired-get-marked-files nil nil nil nil t))) + (let* ((files (dired-get-marked-files nil nil nil nil t)) + (backend (or (vc-responsible-backend default-directory t) + (vc-backend-for-registration (car files))))) (when (and (not not-state-changing) (cl-some #'file-directory-p files)) (user-error "\ --=-=-= Content-Type: text/plain Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 04:36:29 2025 Received: (at 78987) by debbugs.gnu.org; 11 Jul 2025 08:36:29 +0000 Received: from localhost ([127.0.0.1]:34501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ua9F7-0001ZZ-8m for submit@debbugs.gnu.org; Fri, 11 Jul 2025 04:36:29 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:32958) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ua9F3-0001Z5-9o for 78987@debbugs.gnu.org; Fri, 11 Jul 2025 04:36:27 -0400 DKIM-Signature: a=rsa-sha256; b=CWAJWV5aygEK/qXaH8zaYs1G3D9+mF5xI6rUM1px/LTBemLwcdAVAN0foE1b0/kRFygH5dxbYiYPjM/Hmb7XiNDA2WYFoFqApSGDceGMFDcaq5Q0QE2c0Mg6ElUYTA0FaOUxXR+I73/8I8FqLIdXzk/Lhe7AUisiPUBQCaGEIjyHAWJHP6RC23ZYURMc5GyJADg7/t7XMqPwFmDTUinoB7196U50s3XbfosCBF7CGJVLonlqh8NDJP2GoWvDVl3U77OjdIcxyidBqq/4Swb6VPAXaTZAFU3DUyBTHvAV+onW5kfzEjuKamHZr+1xeOm4VnGpy+LOEEXYrbplfYN8yw==; s=purelymail3; d=spwhitton.name; v=1; bh=8NXl/auH3L/AN38GLIvB9ivmaVav0JAC0Jq6AnKZYEs=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=gIxLPTxZ9AiD9he/lfKOlY2h4Rw9yZyy00+0dJ7Is8Y1ChAHdjtjKY00X9S/H/Vcl2ESzDu/yKsNtvf8aPHpDAeE/1LaohIaimM3Zsm96BQubmYQzCx41BGOs/DU1BtgGUiEXS1YYHi5RexSYGhDV/NB1G8ip41OaGoD+tOxLhFRxBtNSZ4MWJyj7qQ1086vzUlQquhPAs+lVtJKK7aUJW/TDrEF0E/N5rdaw2GhLcRXSLG806jY7/23fxU7ksfkkOMNi48XA7u2zW6dy6gsp9xgLoaoNIsuIleajFlfS9TO/SWLzu/IZWfT0ysuZFit1ff11Nx9eAP5kivhgpvzRw==; s=purelymail3; d=purelymail.com; v=1; bh=8NXl/auH3L/AN38GLIvB9ivmaVav0JAC0Jq6AnKZYEs=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -427526695; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 11 Jul 2025 08:36:15 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id D4E41941748; Fri, 11 Jul 2025 09:36:14 +0100 (BST) From: Sean Whitton To: 78987@debbugs.gnu.org Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87h5zkanwx.fsf@gmx.net> References: <87h5zkanwx.fsf@gmx.net> Date: Fri, 11 Jul 2025 09:36:14 +0100 Message-ID: <875xfzdszl.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Thu 10 Jul 2025 at 02:29am +02, Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > On Thu, 10 Jul 2025 03:37:40 +0800 "Zipei Lu" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > >> Here are the steps to reproduce the bug: >> 1. 'C-x d' to arbitrary directory without any version control repository. >> 2. Mark arbitrary number of files with 'm'. >> 3. Type 'C-x v v'. >> >> Then the mini buffer will display: >> >> No VC backend is responsible for c:/my/directory/ >> >> According to GNU Emacs manual 30.1.3.1, 'C-x v v' is expected to create >> a new repository in the directory. However, 'C-x v v' can still be able to create >> new repository in the buffer of a file(Not in the buffer of directory). > > This patch seems to DTRT, at least on initial testing with -Q: > > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index e5b08af2a30..d8b195d9a12 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -4022,8 +4022,9 @@ dired-vc-next-action > ;;;###autoload > (defun dired-vc-deduce-fileset > (&optional state-model-only-files not-state-changing) > - (let ((backend (vc-responsible-backend default-directory)) > - (files (dired-get-marked-files nil nil nil nil t))) > + (let* ((files (dired-get-marked-files nil nil nil nil t)) > + (backend (or (vc-responsible-backend default-directory t) > + (vc-backend-for-registration (car files))))) > (when (and (not not-state-changing) > (cl-some #'file-directory-p files)) > (user-error "\ I think this is okay, please install. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 05:05:13 2025 Received: (at 78987) by debbugs.gnu.org; 11 Jul 2025 09:05:13 +0000 Received: from localhost ([127.0.0.1]:34633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ua9gu-0003Rp-M5 for submit@debbugs.gnu.org; Fri, 11 Jul 2025 05:05:13 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:42582) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ua9gq-0003QO-Gp for 78987@debbugs.gnu.org; Fri, 11 Jul 2025 05:05:11 -0400 DKIM-Signature: a=rsa-sha256; b=T6We+96pBpMO2SdOfybnKLEPyScKgp48qIGQKUxgNIaB5naSiG6EZPKodqFDyYJPtNYgOZBzxSjfvLRE8MKxvMhIHCyRRyky3DAuoXxgaqFCLbt772Ntbv9KSick+WBJRz8P4WMnT2Nksvy263oVV17JzhF3dbppERQuNJeZBHGdmg4AxcTQlG3Z3jH/tfF3eqLIs/oeg3u2uI5eNMMq3trHjz09IgjMRG8pewowgt+JkBiWiAZAY4YiRiOAbYM7GWw3HITV8LMIizVxR4L3y8rcnOPxpcVny6YjSfT5/bLylvrZDpG1nvB5XqVtR8jLJVIEc8U/pwgk3J0zcfhZvA==; s=purelymail3; d=spwhitton.name; v=1; bh=8+t6754vqKnaECr+S4I8/608xjklmhOoERMuVz/kiLA=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=uO0AzssTDaghJ6CFyUvexpqzi5bIoZKGHBsz/x6vcHDUo3BQ7zOdovvxWmoH3A40GkJCu2YcCAb0GW0JAZ5os1fAFKRdASVPe2QKMx35KYsiLd/GP6Z96nIyGoZ8dv82w7Ab+bLSRlCEE8IO82FngXcuR/YHygUe7thw00g0c95n9XtWe2Gu8fB9n9Zeik1B+LAG7Sdk9V8t0Tf/6S4f7Tw6T6344fSz+YNIEzEOptYKW4L2a879iDQIP+sqryJTclGUGEBgVB6UeSWVXP2orohxm15BxKHiY8SjA7RHkO+jhc6rqFIMI2DDCnQ7Wis/uue54tBuKenNqy7wG+3UWw==; s=purelymail3; d=purelymail.com; v=1; bh=8+t6754vqKnaECr+S4I8/608xjklmhOoERMuVz/kiLA=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1938830035; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 11 Jul 2025 09:05:01 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id AF7DB941748; Fri, 11 Jul 2025 10:05:00 +0100 (BST) From: Sean Whitton To: 78987@debbugs.gnu.org Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <875xfzdszl.fsf@zephyr.silentflame.com> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> Date: Fri, 11 Jul 2025 10:05:00 +0100 Message-ID: <87ms9bcd37.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Fri 11 Jul 2025 at 09:36am +01, Sean Whitton wrote: >> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >> index e5b08af2a30..d8b195d9a12 100644 >> --- a/lisp/dired-aux.el >> +++ b/lisp/dired-aux.el >> @@ -4022,8 +4022,9 @@ dired-vc-next-action >> ;;;###autoload >> (defun dired-vc-deduce-fileset >> (&optional state-model-only-files not-state-changing) >> - (let ((backend (vc-responsible-backend default-directory)) >> - (files (dired-get-marked-files nil nil nil nil t))) >> + (let* ((files (dired-get-marked-files nil nil nil nil t)) >> + (backend (or (vc-responsible-backend default-directory t) >> + (vc-backend-for-registration (car files))))) >> (when (and (not not-state-changing) >> (cl-some #'file-directory-p files)) >> (user-error "\ > > I think this is okay, please install. No, wait. I think that we need to pass down the allow-unregistered argument from vc-deduce-fileset to dired-vc-deduce-fileset, and only if that's non-nil can we call vc-backend-for-registration. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 05:34:08 2025 Received: (at 78987) by debbugs.gnu.org; 11 Jul 2025 09:34:08 +0000 Received: from localhost ([127.0.0.1]:34741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaA8t-0005Ov-Lh for submit@debbugs.gnu.org; Fri, 11 Jul 2025 05:34:07 -0400 Received: from mout.gmx.net ([212.227.15.15]:54125) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaA8o-0005OJ-Ol for 78987@debbugs.gnu.org; Fri, 11 Jul 2025 05:34:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1752226435; x=1752831235; i=stephen.berman@gmx.net; bh=9ZArYYNLVw/TI+Et76CSlsMD6tGgFIPDuNi0P0y0XWc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=czBbFxvG5mLjARfRW0YGtM8F5J1ml+9suu43+KPIhBmk5nfDBFEvKA1TfpbQb8ue 4G7q8G6s67hUiOedPUjRQQY47OtD2lmIiSMEOs/dsH/Cscrt2ASxGt0fNwoDBIJpv SWR15WmENqU/5SaGnoHcccvxRIb6jzsop8R/xAzUuH6QsX/V0nbvnGUbfD8STHRQY GOdcONReLeY92JlujjOIcKVnC1yRZeLtCgJe+xWc1a54eSlQjIpeA89J8vNmUuRnQ 6VW9Gp2iq69hlL4Bsmd73647JOjKA1iVjshj3xfiXCObs72V5jAzys6OKZn34nJY7 XSbq+dQSLQFPOzigYw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.49.197]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQe9s-1uFjLa0h2k-00PLa9; Fri, 11 Jul 2025 11:33:52 +0200 From: Stephen Berman To: Sean Whitton Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87ms9bcd37.fsf@zephyr.silentflame.com> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> Date: Fri, 11 Jul 2025 11:33:51 +0200 Message-ID: <877c0foyv4.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:tB6WrbtJftBiAOjR1U69TD0mlclz4xtSxjRi3VHIh3yOwrW9VJf kBrmvAyRWUNBlN+ci2kfABwiuez21D4SxMpbG0a63jKbuZKctn19kokdr6fNgx3ZrdpNL82 LpX7ZFxj/fFPuTmfQjog3IHPDnv6OG2OMlOlvWLdhJhEOSY5OeUj+KmMXUaL3faCHmGc5vE hMWfWjVDZLclqv5JiA7DQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ipvxpDOdS0s=;vXYDKpgxDA8ZolKizuRrT4awws5 kzppLorjJAVBryYlCPeh+FWQjuhyWi1n8ZvChnBOn580tSz0NU4+orRJYMGOm6jJfDpRJBeI/ 7VRawGqFn4xPoVKzk2iRGOj+ktlaCdi42iJni9wX8KD7WO35mFEbozDcj0wQhjUfyIf4uBOLp aoVJP5x6RVkciun/dc3fx0CSrAq1FqFLJnDfJGIXU7IuPt+8hGPuzXaga2jhWj+/bpVrknKfZ n8UHkGbTnFDz7DkTkTbjwEn55YItvcUxvC+Dt2IYXZl5Y/sFA5zPVZwHsMaivfk4u7Vcr8Q1J JOIULcuZVB8WE1HJLXkJOaylVVBNOI4OqEhdouEi2eGgn7VUpv6i+BQ/681z090DYtDb+X7RQ 6cQGwejGM0xNtVakJHqJPGl1HmzwoZJ4/Z/cbEQQ/CZC6uxeEZzeVzI4//bRWUdlPRPpMHvU4 07Kz3ZQ8axT0ni4aaqox7c3K83DK9/2tPxUu2Vi92Yj57CO4RVqUjX+23a+qdYT0GSP2VqkAE IbDrJoHojSLV8KIQf2XDOsLtyeiOU32mq8P/JgsscMJer36iUxHFpdbr3mwcr/4cbNzKfscIC EzJ6GXIc96zpPxVurG7/QqyoNPDW88bYO2lTayZ4C4UZzvJCKaKcVZxwunu5AZs0pIB6IZagX dFzxngKXmAdjCxsTXFVQm2mb8ovFF+JdrY8iiYZbyBFZAts90TCxItOkHHxUWtvspWZQDe/x5 XqI6ac2VuzI1c3gWbwD5qqijrtAa4YilW9nNtzImip9oHulbqerI1hHQkCccF6CEFWQonbKoY Vcfh8YpqpDwHFtBAHb9WCnrotGoeTFmVpCopSqv2/ecELaUdeUWBwwwehEMOCZXQ3r/x/Tsq/ 0Ps4LTf240vrCC9Ng0umEjbo6dfP1gW07Rv2zofBELIKiG/H5UX+4TSPk+/9+rzyJu2qB6oGB LuTt1RMIjvCZUIdN4LZZBmDMpfCN5SMsXuxmP4IJVJq29527yVmnigHKIkZeTLiuGIwf8Uekt +w7EOlnf8LgIPkoDw2bScXmf9vQILX29HlFu2wNvpFiDlK5p8331aTeXzTL0zVPsVNiZpgp/2 Rnadv9exUjftmGkqUTRwgub08ZWYt5+PPUY122jeLx9sfgUAlsGSDoxG/2xkXBoTBUSkAl74c JbRymrqgtAAH0fzyHEmWsEedTKQWty0VfCbe9+HXnDoXgGrzcwolgeoQq3SYTjjvdChOtAwh6 W7Kwr8nNwIPNLY1rH+A9KK0a1xe04GDTRpkEjprToJEuHDujtefRt7T3+sYoD3lHT9PDur6od KnyVW0BewYKiulb3yprhWMQ3XDJ9Ox/M7bS0rgzjevsHpmAhxMrz/0/XF3MTxfkky/bDqVBKZ hPsw45ZmwpCgw/7detZJ+QIDzqLUG2NPUZH1ZrQqUDwzWuImfVYkKyWuHlkSkBBjjlNSzfDqB so/hui2ZNNGEgqR/57475gTnn5huLeYQldo3yC/Hl5oUTG/9nIvO6LqU69D/o0t9dKwRLFPkD QAtxigc+B89bGlvMK8seqiSv3hb0m+PFM9TbgtdD+LpAQC1xGvFkptrMihuinUX80Ufm1dLE0 8sydatGZyS4EM3Il78puYKKpOjTG/d7KCcUonBmr0qVDnf1fSB40E5xzhJi+/MHm/b9GP/D1x XJijnP5y4qJZY4ZmjKl9MKx0hKd3mzbrqe6zyxQti0WnNmlfmtPbJz4Yzxd12sUggA6Eh9kDR jurzyZCBMHYNK1du/Y/5IN0m2Jstk+BTqlIiMCTNqTP1U+y3LfUJAsa7W2sxEZX6whpo4G1nO CUOilWxHi79ujSQdc6vC9capcdt2An1GQU1wsxodNB06B2qkbD6UPweLWoV5yKF2c3PlNwSlN CPvNiqYi9rAHy1oTXXp4hGoi0I3HlRY0hzp2bJ2b6/cF9BtjXJC11DqV6HzPY5JSb37yW0QQE E1QChNPlR3gDzHE6PbqmQnIwcApV+DYQCuyiE02Bff/5Xq/QqA0YFoD7e5C/khxxqJwD4bOfi 3XOJZGh2aFZYBBu3lUZdATdu3jArpiKnEMFk0a7n7LuSJLv18dfFittIxw77Hkip4AapilC+b 2hPdZQStFmFTrBglrDEhvGAKuRoh0ln83oTBCifu+BvqutwYKRr+9xcsnjVuHRoL04BJIEAqU rkYj74GArnLpLbHDL39CLsYmkd0VRsu05LGWcTbi75BFHPWtC9+BA1Qtf9U6KG1STvtZCpupC QThcMCNATOSpygQgfabJWyyYpKAc0jmw80kWZvMrHkDjtNYZqrtb5HS8EmdiUpVj7ovqQdLmg uaLAi1cqfMpewAv7+jRkHMrxzcJKvDl7EXM98l102nvQ5VoePNJ5m+xrbTm33AQ0Qb+t2hus7 12jLS5I4hldQGu5Z+CifvLLhJgkVOP7oCJ7zAP7wNYiyxSsl8C8IR6VcGTl67lvdrFHmJieVp YAzes+KMUESg19mdFzrspe3DPYej5u4/JMMeqNJGJigBFwVaVBYVa1QISY4/62UU36jCpwDCR YP32Y4AD9EEDJBelvQs8zmmCeh1B+5h4DlZTqjswtl0ZM/F/Z69QI5hGUF2M+2T5+zMbq4+Lc LISjWfKByRS8mcOjsRavRfBYN/l2xHPftQQBgFh8NxPkubLMbT3C+9jXRERQtbxBaQTpf55Js MCZ0shH/7a9jNfMjSfIwQKRUwuFymfJwsIwqsa6BkWNk+HQNphvIsuFo5y2eKnXSfdJDEoJf7 flKqzQH1W+WpxJOKTf0gO2ZWmzJcmC5sMTSNjF2AN9g2sMrgDUDDg3LqsrlfUY54xKDbs3lZ9 Vl68WjaneqznQEu2vGfWb9P6yh1C5bDsjAnVv4kJ5zIjzP2BH86HLNXfUFrQiblawfrwmTx63 D/Bzkf0gpZ4ag6aBBA8cZXtE/HCzClw+nzosoXluLnnVIxIQmyz9fEx+z46pt94WrvgcD7faJ g/CJCFeOHkqDBaEUPdIYmXWlFPJ6l/EFHGOqJspyCIPwjjPnJO2eIvr0h82f7UJoLtMSvWum7 uPc4r605U2HuDH77YA/H6jBwI1ySEdR6O8OZG470Tb1IcYChdTG0fcj+fgOHC+5YRWIHSGTaJ 5lMOvdC5h9lq9M5mrV1wiLw2baQ9ZfVtNZRmNt/nlsorC+ctspCbsY84FWB5/aaNzR/VWJo1d tmqgEgOJCw7r2mHDnjRaDRCzZkuCTxnvzBFqHK2GobvXwNr6ZQS6x9cdBg1EqMN82qxyHCqFu /Acv0yVcyYqXk5LFzEav6acTkzZKvfGpKtbvPUs7CZo6y/dhekw/s92tme110cI4OAsT6oCT8 b9R+IO0RKWrs+sPxdvVsLtGQ/fVp6l9rawedEGJV9vskn9iKeQiQaFzpxD2EK/gTaUeGJV9Vk aPc+/eCCXpmjL0loT2fQf3wYZt2nEk9YXjkHKHiZKGg11eStcyQ8aqe8lpFmUywpmYPuV1of6 SbEEhFNshSkkwAbPE7WN2G756+WoHlTQUTCouQJHs3O9xbdXugZRgNG7pseWp/pKM1xTHC8J3 OOlf6oot4XbwA8QQCr1SjG28yP2e07iXw4jKcxOxb3T9VaSQgEUL1YxKVws6NGHJUTzwsYnAh VjWxnz5JCNoYdB1J22C9xU9p0Ta5Z58FXrUtbcd1NiZBwOIJVn/L0q0Xw== X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, 11 Jul 2025 10:05:00 +0100 Sean Whitton wrote: > Hello, > > On Fri 11 Jul 2025 at 09:36am +01, Sean Whitton wrote: > >>> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >>> index e5b08af2a30..d8b195d9a12 100644 >>> --- a/lisp/dired-aux.el >>> + [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.15 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.15 listed in bl.score.senderscore.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.15 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.15 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.49.197 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, 11 Jul 2025 10:05:00 +0100 Sean Whitton wrote: > Hello, > > On Fri 11 Jul 2025 at 09:36am +01, Sean Whitton wrote: > >>> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >>> index e5b08af2a30..d8b195d9a12 100644 >>> --- a/lisp/dired-aux.el >>> + [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.15 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.15 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.15 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.49.197 listed in zen.spamhaus.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.15 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager On Fri, 11 Jul 2025 10:05:00 +0100 Sean Whitton wrote: > Hello, > > On Fri 11 Jul 2025 at 09:36am +01, Sean Whitton wrote: > >>> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >>> index e5b08af2a30..d8b195d9a12 100644 >>> --- a/lisp/dired-aux.el >>> +++ b/lisp/dired-aux.el >>> @@ -4022,8 +4022,9 @@ dired-vc-next-action >>> ;;;###autoload >>> (defun dired-vc-deduce-fileset >>> (&optional state-model-only-files not-state-changing) >>> - (let ((backend (vc-responsible-backend default-directory)) >>> - (files (dired-get-marked-files nil nil nil nil t))) >>> + (let* ((files (dired-get-marked-files nil nil nil nil t)) >>> + (backend (or (vc-responsible-backend default-directory t) >>> + (vc-backend-for-registration (car files))))) >>> (when (and (not not-state-changing) >>> (cl-some #'file-directory-p files)) >>> (user-error "\ >> >> I think this is okay, please install. > > No, wait. I think that we need to pass down the allow-unregistered > argument from vc-deduce-fileset to dired-vc-deduce-fileset, and only > if that's non-nil can we call vc-backend-for-registration. When I test with -Q, a Git repository is created and either the file at point or the marked files in Dired are added to it, although `vc-deduce-fileset' calls `(dired-vc-deduce-fileset state-model-only-files not-state-changing)', i.e., without passing `allow-unregistered'; so why do you think it must be passed (and non-nil)? Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 07:12:53 2025 Received: (at 78987) by debbugs.gnu.org; 11 Jul 2025 11:12:53 +0000 Received: from localhost ([127.0.0.1]:35414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaBgS-0005vV-Ru for submit@debbugs.gnu.org; Fri, 11 Jul 2025 07:12:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46076) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaBgP-0005vC-OE for 78987@debbugs.gnu.org; Fri, 11 Jul 2025 07:12:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaBgG-0005uI-DK; Fri, 11 Jul 2025 07:12:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UCUIqE1Zz/HTLcI+Xv26VaNzkgyBYvy9eZX3hD0UDK4=; b=VKxjQaoRbDwa jZm6SvsPkRpDTQMJ6n8CWHV2bepc6A+HbL5lWze6COfMhKBvk3loPUrcMXqxDLIxAPWHP+Rt6KGhM bF4pOI2S6WBLwu7pumXjBcbDVOlacP9+lhmSf4w1FpaqGYWQugYSn/59RzLyKEKxPvH3JOSmI4Tz2 LPepfSf1IernG9FbM2AcY8eu0MJLNYHnZZI2nxvSz+f0fTLD8se34xtQKDF6IfB+/PxkxTLyHEPgi YFLhNjUJwdhh5lz6cTFituxDmqB5QIPSpC90U1zna3lQ/7T4qReh3RfRaG9bM3vtuWRD4Rp/edNFw jcit+U3qKxU/1malGi3arA==; Date: Fri, 11 Jul 2025 14:12:38 +0300 Message-Id: <868qkvgevt.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <875xfzdszl.fsf@zephyr.silentflame.com> (message from Sean Whitton on Fri, 11 Jul 2025 09:36:14 +0100) Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org, stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: zipeilu@qq.com, Stephen Berman > From: Sean Whitton > Date: Fri, 11 Jul 2025 09:36:14 +0100 > > Hello, > > On Thu 10 Jul 2025 at 02:29am +02, Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > > > On Thu, 10 Jul 2025 03:37:40 +0800 "Zipei Lu" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > > > >> Here are the steps to reproduce the bug: > >> 1. 'C-x d' to arbitrary directory without any version control repository. > >> 2. Mark arbitrary number of files with 'm'. > >> 3. Type 'C-x v v'. > >> > >> Then the mini buffer will display: > >> > >> No VC backend is responsible for c:/my/directory/ > >> > >> According to GNU Emacs manual 30.1.3.1, 'C-x v v' is expected to create > >> a new repository in the directory. However, 'C-x v v' can still be able to create > >> new repository in the buffer of a file(Not in the buffer of directory). > > > > This patch seems to DTRT, at least on initial testing with -Q: > > > > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > > index e5b08af2a30..d8b195d9a12 100644 > > --- a/lisp/dired-aux.el > > +++ b/lisp/dired-aux.el > > @@ -4022,8 +4022,9 @@ dired-vc-next-action > > ;;;###autoload > > (defun dired-vc-deduce-fileset > > (&optional state-model-only-files not-state-changing) > > - (let ((backend (vc-responsible-backend default-directory)) > > - (files (dired-get-marked-files nil nil nil nil t))) > > + (let* ((files (dired-get-marked-files nil nil nil nil t)) > > + (backend (or (vc-responsible-backend default-directory t) > > + (vc-backend-for-registration (car files))))) > > (when (and (not not-state-changing) > > (cl-some #'file-directory-p files)) > > (user-error "\ > > I think this is okay, please install. Please don't ignore my comment in https://lists.gnu.org/archive/html/help-gnu-emacs/2025-07/msg00090.html From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 07:49:59 2025 Received: (at 78987) by debbugs.gnu.org; 11 Jul 2025 11:49:59 +0000 Received: from localhost ([127.0.0.1]:35648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaCGM-0003LZ-IK for submit@debbugs.gnu.org; Fri, 11 Jul 2025 07:49:59 -0400 Received: from mout.gmx.net ([212.227.15.18]:40751) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaCGJ-0003L1-6n for 78987@debbugs.gnu.org; Fri, 11 Jul 2025 07:49:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1752234589; x=1752839389; i=stephen.berman@gmx.net; bh=fXNGPGNe6heTq+FiEI50yg//isFxBeUqvBQCRub2YxI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=CUrzQMhx645bRXiyVVFvKIewldLd1HKt0qLxoHorbnW7Bw1l6mbehW2cFK6UvFzZ yQHQ+9PeIaFlsq4XMVfH2wdoYGx6PQ9TjUQ51tyuetrlUkPQfI+Cg71kKCycO4f/F pmKmN5xtmMGvrtlypNAS3TcPBvHjENcYj2hvSuuP6zviPJa4B0Av3Rr1DUvSWxgJC LZPqdl5gQ3a/WRfvRYtwVCdQfPlAW6S2tBWzemtfDG5h1b0OUHO76TW9p/jdkwWI3 MCkC6hzz98d+IXdhVvxBaMHB0ynkWR0TDLjnYBf7vD/cE4AfiyC4waESFUz3FyHFj xAokuhSouwnchqQuDQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.49.197]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4hzZ-1ukgTT0C75-0133YK; Fri, 11 Jul 2025 13:49:48 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <868qkvgevt.fsf@gnu.org> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <868qkvgevt.fsf@gnu.org> Date: Fri, 11 Jul 2025 13:49:47 +0200 Message-ID: <87y0svne04.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:lndBZQjaW20kGmLSrMrp6L+8SHFAQcjjVQ7h3E3VrxjjmxoHO8W ncbSyWDyT/pNMyyhkqtUkj9DWt2pUk7pb1vwwhMBUpEyyoQLUtbSnomcdjOzJFhRg4Ic3wf 3pjOXoxyvRDCz8vTT7osBFjlUie7Y72vHgKZrNhBGbr+qFcS3O/xrO1ymcNyy2kfHxiYfwr 36cfVUSpXECsnW4Coc3Lg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lZ0BtK1rdqw=;PmZW+1zJtgPvJFeyJ+KljAwkrxw PyCoesn0bBfPFHHlYbX58FeyWQvsEjQDEeROe1aF4NAf1oeGCMInUHmS8pWDKJ4G56wGwBrk3 WBmXxx14oAMPpqEM54cDQFf+2xnJrGQAr6ifYi2SgNSJD4quNip4iPW2YI75NUwhfb96C4ZoV 14mNLxerwod7t5ykkTLLoa0u+QUmCrNkTs2tXClqJ9evwEmXOQrltVuC+zBt7j91KRITJNrMe kLyNNDbKqml1W+bIqFvhy0NULbLFrbOpuAngwOd7Q2VIqKvoQLrItaP5Krm9s+4fXu3xcOqLE A9EoYgVc0uCHSP5V+hJ0tR+c7nX80xB/FbwsSCp+5a0HIAHM3iCPUpAWiLAE3y5lyTO7Q3nrq 681fhVgKurikBzT2dnlsFZvFNte4bQF5WEDp+ShwLUyBy+R6JOs8NkDn+w8dkXmvvSLjgiqfQ CbSsPUu7ntZTOJbfNrcl5lPzD8NQpGBb995mh0FD8humB/RYBBzni9D+cKK1A4Ncge/xrmNub tsawqWEvSSzUNYAdBViC/bpuTDzXuZs+S5Gs4RlOfjoHSC9h5CNwvGRR096bDKVA03F98Veh/ E1lCKeKGqExRt1pG4mXMvWKfPNp1afCNTl2tb4n1lh6TZIe986We1NY9gB0KM4X+/dS3lXWGZ uqAjXvu3o+g9jRi/UKPNZWgyMqEy8clXPBPXwOw9D4sVvaiAjNyCHP8XAqo81LfDl2zj5BYrF 6eAKPoKhAUX+4SU4sKRF2Vf4V7tq4e9pTdFGsqdScEtSq5p/gyr6Dh7lb8islU70Xbc6sxvCt hadJjGGi4KknBEPgRkfL28Kph4yx2rPFuPqdXZRk19M8ZY0kdjnjZP0p7SeDze4jlz9ZwU5Nt GehMpYaR+j2rL1w11w9DVXw79kojFnaz9laDucTPDuJf0Y4A6XhN3iMwESLG+jjxFcoN0fUHX qPRb+ZPiz9oVQqP+sghIVci9NYdlomX0X+7Yk7HSx3otjfEzo3Tz8TXRudRRcvBcGOcR9COOO H7I4x/TrFV2k/1+2TUBxVbRhRVdjS4atGksDswimzhVMeSA2rsUSEmY6UZNsg33cZWnLBPbcU XgVXb39bEvfODaKJap+0cv+4V+rqsRf8+oNeqVbxcXp63wwzrLjoRtkM9lfu4SIUS7v5h26tn nEIcTbgwgnDMa6Yw2yDjzkGNZxtGWfkm9hOiD2YNITv7gZFWsDHda1EAvUonWM99J6vgMwi8H uQdVoRnSbEPGRaYIMmx6RvtpNHvngz8KOx4RIUKjtT24fbA7SAjE/7DFcoaiU9Ktn9FmOYhOn 0lKAGpDMUHqwN576+YnrPmkYG7Ok042ITlD0kJSUdBLycaPc8dbzjTpWNG+vk9B20y24rT70G vRudTKO0s975yXNimCJPp35Dt3I/cfoniHfET45UkyFTMvVnosVULlxkCuBHCyY5938noDlWV HiM6RjkwL9euSLH4IBoQtgwQyuffS7ng86ppNvlgzxh/VO4XfVUN0Fai6WsQdJclhVamBg6yU fn67XAoElA3+ugONvNw/nlpMgbZgG4JYIY+hwALsqtQLyow2iJ53ufxC4h4VgyqdMZNIExhnX SV3MMx+7bIoptKVKKgqi6DRofGKDTxQ6NFmqEQyoTmlmbuRK+jXVVOMOaThMyVtJki+AyTYB+ lpYj6gfaTx1blamIlqfQHJrHJVj7iRWUNDhR0lrxMy382/F0kQLZTpsiushyqESU4TlvbOEIW JDF3lorzOihTaVYJWDlV/n9Ir+irrRBHVCqL5FMr7thZnxk2XfQCyMbD00g8uADaPI2ZfblLg cpgQwH6W7E4GbUpuDgamjJ2Tq1Iq35vkC66tS/WulCNtHgZKUgPRWW7KVNdIYxc2CEjvNvGec +FOkDVauYpcuIHesg0S4QbWNlBDu5Q6cCRgNbHhgFd4X6T7f77qc/VxYAw/bJWYa47ATt2cwH h6AtjjroIeGZkWNmIxPa4328wlm8ztrq97YetPnpjCbE0fOFN0uYS7DCBU+xUXWNfFkBjdKaS C0hknMvvSsg7y5tq3YtSWfkGdyupF2RX5zm9oaoGSWHy5KP38zzpk2ejeNMJQj/8ULzMENRpk bDyTdKff+AAKDwCRBuy316EEN5YPGVhQSg36OM9mOXz0A1LL7y0ufU2Tw5m2GE2GsjUhpobYE h5VGYI2Bkc1JzFuz/MDOF2TXXD5+t4jOoaQ5KJVugd6UHXTF1TG+3o8IwonphFaqEId8EYpTJ 4qxL4uzbm04kOgbzFHU/NS75A4S6/bQb8h248remR1/aNzmlu841uukrZOg0Ym/9lJSt39oD+ 0E7AycyXhb6RwTyoQmHe9B0Brg1iV/1BgzTLZ4Ha3m2bfGn6Ny7ACdoXiWC4tf6sCq3VvG4cb lhNHphhm8lh2PcRjhouDO0qyXtfobqiwkQuvZimyShSViGTq2mx3OQA/eKto8YZMluHHlV81u AvglOz8BgZAKDXA8s9f1169rMyg7ugDTajS6Yc+FNTx7iwVsHj8+TZoT/TH5BGamHH7sof5fB EVaSwYGdbLbPVxymMhrYMxtkfXpK65PWXBZxRV1IRiCNBK8RCxeumwkp+7H0vCAbKwdPG2BMw PdELtqY+LAuDL/Nb0ozaKfjlePhGc0DUnzIbanjwIgSFjGLjS+ryTMIvsB12AXW8XT8GnOS0w E78rv0ecbGBOFiWst5O0zVc71QbBv1ogR+gd2M17QG1OuKwU/CsP+WOnMd3mahvegTRxQxywG XT9QrKkwsgyrJfKGnRlgOl/eMN1f3+KbfLkzgwdjnZyRi7NBTH7fKQQKM3PhTCY0H9b+rAmcS 158B/spmZeWiyuFNAVSFWn9lkKaFiZ2ApDLAbI1mwXwBmJpviyaXkz3yDPfiymkVNpM4rmJBm JBUFIiZxrQtaBrZIDyHKNw7k88kCuo+Sy1H/YP7EXYZYpHQACFKbE6kmz+Q/HhPqv0ORq4eV6 BM7HeFlLxmlQvCYqOmTvMvwrxcPJePwi6HSJbLHU7v18/Ku8UbrSWit9ng1fuk0Wbe81EhL0P igEsfE4EdS7wFBoNP24vf5/g+i1JrhVSq2pG3ylsX5l4hJsV2omn3q4AVSa5FeeuFPKke/PnA IXdWTU6CcaiIkm8ghl2uqS/PkwnEKIWBp8+2asMMWSJ50rC1oggdhv7OI5KZMYLFlL8/E11Ef o5UPOHhhPhPm0z8fcaDKbsGJGp7ROjf//oxc2nv9hgdFopWbvQ7uVOqb+uF8ZzSUgtJLx0Db5 Ascdt356p1m68HhClgrFIVrlM4EDsIeegsXmQwlQSQVwSaJnZp6Zk5+rY1t2lxDM++hhzHkOg 6I/VqASCh4AFAUbyc6RNURoUJK9lCa31KATgLscLNSmNjkthajPh/T51WCS8T6d07hbJ9eoT6 /SXtNr0udtW/NrTNZZSZmz21EoP9qaRRVyqISPqdYMGHhO4USoVm/5UmSwLc5cipvWbozoOgc LYva1/qOaWy/Ykc0tj9+oNwJ69x9070YebrHKURDDmz3n3e44cwL0x/nxnpkHKX32cT+wv5sP trZ2bSDOrahXfwqGF7YjMQhfTg3102/9I4UAow7AUPb6apneljCKES4KE6mMN4ERVXRPJAjoh rxEInidWO4TyiB8/l4IlzPdaavcbrpNGwiENFNeH1UresZXaGF2chzgJPHMM6+fzEz3KPPOlK 108OwRqUzcVpk3M5+YVKwsUBrbtpKk0lB3mzNB1myDy8fZhw== X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, 11 Jul 2025 14:12:38 +0300 Eli Zaretskii wrote: >> Cc: zipeilu@qq.com, Stephen Berman >> From: Sean Whitton >> Date: Fri, 11 Jul 2025 09:36:14 +0100 >> >> Hello, >> >> On Thu 10 Jul 2025 at 02:29am +02, Stephen Berman via "Bug reports for GNU > [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.49.197 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in bl.score.senderscore.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.15.18 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, 11 Jul 2025 14:12:38 +0300 Eli Zaretskii wrote: >> Cc: zipeilu@qq.com, Stephen Berman >> From: Sean Whitton >> Date: Fri, 11 Jul 2025 09:36:14 +0100 >> >> Hello, >> >> On Thu 10 Jul 2025 at 02:29am +02, Stephen Berman via "Bug reports for GNU > [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [88.130.49.197 listed in zen.spamhaus.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, 11 Jul 2025 14:12:38 +0300 Eli Zaretskii wrote: >> Cc: zipeilu@qq.com, Stephen Berman >> From: Sean Whitton >> Date: Fri, 11 Jul 2025 09:36:14 +0100 >>=20 >> Hello, >>=20 >> On Thu 10 Jul 2025 at 02:29am +02, Stephen Berman via "Bug reports for G= NU >> Emacs, the Swiss army knife of text editors" wrote: >>=20 >> > On Thu, 10 Jul 2025 03:37:40 +0800 "Zipei Lu" via "Bug reports for GNU >> > Emacs, the Swiss army knife of text editors" >> > wrote: >> > >> >> Here are the steps to reproduce the bug: >> >> 1. 'C-x d' to arbitrary directory without any version control reposit= ory. >> >> 2. Mark arbitrary number of files with 'm'. >> >> 3. Type 'C-x v v'. >> >> >> >> Then the mini buffer will display: >> >> >> >> No VC backend is responsible for c:/my/directory/ >> >> >> >> According to GNU Emacs manual 30.1.3.1, 'C-x v v' is expected to crea= te >> >> a new repository in the directory. However, 'C-x v v' can still be ab= le >> >> to create >> >> new repository in the buffer of a file(Not in the buffer of director= y). >> > >> > This patch seems to DTRT, at least on initial testing with -Q: >> > >> > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >> > index e5b08af2a30..d8b195d9a12 100644 >> > --- a/lisp/dired-aux.el >> > +++ b/lisp/dired-aux.el >> > @@ -4022,8 +4022,9 @@ dired-vc-next-action >> > ;;;###autoload >> > (defun dired-vc-deduce-fileset >> > (&optional state-model-only-files not-state-changing) >> > - (let ((backend (vc-responsible-backend default-directory)) >> > - (files (dired-get-marked-files nil nil nil nil t))) >> > + (let* ((files (dired-get-marked-files nil nil nil nil t)) >> > + (backend (or (vc-responsible-backend default-directory t) >> > + (vc-backend-for-registration (car files))))) >> > (when (and (not not-state-changing) >> > (cl-some #'file-directory-p files)) >> > (user-error "\ >>=20 >> I think this is okay, please install. > > Please don't ignore my comment in > > https://lists.gnu.org/archive/html/help-gnu-emacs/2025-07/msg00090.html I wanted to reply to that so I'll do it here; here's the context: > From: Eli Zaretskii > Subject: Re: Unable to create new Git repo with VC utilities > To: Stephen Berman > Cc: rpluim@gmail.com, lzpzipei@gmail.com, help-gnu-emacs@gnu.org > Date: Thu, 10 Jul 2025 07:52:07 +0300 (1 day, 6 hours, 38 minutes ago) > >> From: Stephen Berman >> Cc: rpluim@gmail.com, lzpzipei@gmail.com, help-gnu-emacs@gnu.org >> Date: Wed, 09 Jul 2025 19:55:54 +0200 [...] >> >> This patch seems to DTRT, at least on initial testing: [...] >> > Thanks, but vc-backend-for-registration is not autoloaded, so I think >> > something is still missing. >>=20 >> But vc-responsible-backend is called first and it is autoloaded. > > It is not a good idea to rely on that. It's fragile: one simple > change to the source, and the command will signal an error. I'm not sure what you mean by "one simple change to the source". But I did see this warning after rebuilding emacs: =E2=9B=94 Warning (native-compiler): dired-aux.el:4027:24: Warning: the function =E2=80=98vc-backend-for-registration=E2=80=99 is not known to be= defined. With the following patch, there is no longer such a warning; does it also allay your reservations? --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: dired-vc-deduce-fileset patch diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index e5b08af2a30..3c6ef080f5f 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -4022,8 +4022,10 @@ dired-vc-next-action ;;;###autoload (defun dired-vc-deduce-fileset (&optional state-model-only-files not-state-changing) - (let ((backend (vc-responsible-backend default-directory)) - (files (dired-get-marked-files nil nil nil nil t))) + (eval-when-compile (require 'vc)) + (let* ((files (dired-get-marked-files nil nil nil nil t)) + (backend (or (vc-responsible-backend default-directory t) + (vc-backend-for-registration (car files))))) (when (and (not not-state-changing) (cl-some #'file-directory-p files)) (user-error "\ --=-=-= Content-Type: text/plain Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 14:14:11 2025 Received: (at 78987) by debbugs.gnu.org; 11 Jul 2025 18:14:12 +0000 Received: from localhost ([127.0.0.1]:39619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaIGB-0000ya-Cu for submit@debbugs.gnu.org; Fri, 11 Jul 2025 14:14:11 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:44018) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaIG8-0000yH-Bi for 78987@debbugs.gnu.org; Fri, 11 Jul 2025 14:14:09 -0400 DKIM-Signature: a=rsa-sha256; b=tgNIqr6SLif5fhdqI5PxdsP22NoFbJpZjSNlvtYij391qnUtTyTBwp6uzbG1mn+TCYv6YH2qIliTLF59fJE0d9L8CVNajsyq2XWng8vBsY5AWTF/RVZap/KZHlYmB2cJzq4A9H4/OYOmBJ7jJOwKxUSSyeN3UGPkmkz5ES7o09tJTgsN5s8ht5BLgCOYGYf8++AF/LdMpeXgDXeg0xTvVoYyXWzeHEudydvhRoJLjf0E7SZUGg9IU9f7c1NZ16F1DlOO0nbebH2j8S7k/paSHNrgDLcBG/wt77qoLCCvwdhcX4LxAJODbsF6uX34mCgYKmg2ijmfV57pby+LHmDjmg==; s=purelymail3; d=spwhitton.name; v=1; bh=Gjmod9+pf2hC14mORMi5e6IwT/EXeeg8ckXu0v85vVo=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=ie2ZYAlNbPCLcynNU3lbmqw0YfGo4SSF4UkymxJo1svOpXJWad6iKhDpUA7y9NNhSEEjt1dnSlF7/Div8kUZ63q4jRHcmyqElvTWyKx3LWW1C8evwjax1mBuMKnIdwxdj9pg7XxZKVucbmFD8Pg7iHFpGMD36hyFM/cx3KITyqHYZ0ptkusEm2yixvcGa47hhh6v4a1u0EJbZSShZIl3kHRbVIUctmPwPku6VyMogntWLzdLxCBpDmSjjKrgcoCoh8zKOs+vDZDUsa2oo+oTNolS3z0/7qQS+KYE+Fxs+USR8pk5jyMCF9DG1sPI0JRsQguWS5NcIgEXHkcw4Fx/7g==; s=purelymail3; d=purelymail.com; v=1; bh=Gjmod9+pf2hC14mORMi5e6IwT/EXeeg8ckXu0v85vVo=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1686519920; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 11 Jul 2025 18:14:01 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id E51849419BB; Fri, 11 Jul 2025 19:13:59 +0100 (BST) From: Sean Whitton To: Stephen Berman Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <877c0foyv4.fsf@gmx.net> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> Date: Fri, 11 Jul 2025 19:13:59 +0100 Message-ID: <87ikjyd28o.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Fri 11 Jul 2025 at 11:33am +02, Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > When I test with -Q, a Git repository is created and either the file at > point or the marked files in Dired are added to it, although > `vc-deduce-fileset' calls `(dired-vc-deduce-fileset > state-model-only-files not-state-changing)', i.e., without passing > `allow-unregistered'; so why do you think it must be passed (and > non-nil)? It should be passed because the corresponding code path for vc-dir passes allow-unregistered down. dired-vc-deduce-fileset is meant to be just a dired version of the vc-dir code path in vc-deduce-fileset. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 05:07:45 2025 Received: (at 78987) by debbugs.gnu.org; 12 Jul 2025 09:07:45 +0000 Received: from localhost ([127.0.0.1]:43841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaWCv-0006CD-9l for submit@debbugs.gnu.org; Sat, 12 Jul 2025 05:07:45 -0400 Received: from mout.gmx.net ([212.227.15.18]:36169) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaWCs-0006Bk-RE for 78987@debbugs.gnu.org; Sat, 12 Jul 2025 05:07:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1752311251; x=1752916051; i=stephen.berman@gmx.net; bh=Cwpn2c9xF67kKORfElDm4pF2kAysaEDhIz2WiCAqo78=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=e4W1MwdQBGvp230vPSXNG89UepGREuy27he42ygo2DyAJ7u2hp2uvK6t9mcTxCMG o+tG85i6fec7aU6TvJkHvuAIv2U+nwkA2cfZkD2gvWpctFI9EoTGoW0ixVfpP7AJy ASKE4EzAQrNXlBXTL2XCuHAAseeXYCNXHhEH7RVZv2Ec9gXnyFDQhp4ddzPqIltqE Gs/VUdjXIADkpItC+JYnBeGdFZel/RlByAIMNjjJz7S6Mznmd7jWKJS0q1qgd4pjX h0UfUiSeSf2uiIYXp7/VE9Pw40FXh1SxXnttjje6mvsgltkOyJVXTiBzxEZrfuA41 Wfe70IVTE379xn8mGA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.72]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MWics-1u7ypt2ELw-00Vdsn; Sat, 12 Jul 2025 11:07:29 +0200 From: Stephen Berman To: Sean Whitton Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87ikjyd28o.fsf@zephyr.silentflame.com> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> Date: Sat, 12 Jul 2025 11:07:28 +0200 Message-ID: <87frf193qn.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:mYfb25IvMLGZ+PZt06ZiFuC7WdZ6uO5ewGW1k3EmcZhni6KoOam 4915YZUXP8gL/NndvSB3f+iD4XRZs2EKnGUpuinCPsh8ozYn2tlmnxHPxtBY3fmWOGsARc1 CcL3pG2JpUVQ+u/1FVBxiu0bca30JedPHABOnZkAvhGwAThqQ0hjk7LGFkm9AAeeHCi3W8b /f5U/9a+uFQDvavNUlZbQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ETvqxz+4Ns8=;t73+zEXHOVBg/XVon63t8FaD+A9 PYYqLSV9AsWVdXyc26M8BWotbOGSNcv8ujZHiJpOkiIUc1ojcjOnc0NRbF30f0IAZI9OuuJLK 4z56GbpO1wzfKh8BIQsootgrnst4AA+ArtIZ6XM+HMBsWUQluIowxiFK+nbL4vpD2+U4x7kEW HQI43wM/7QBKQhCUH3Ej98Zvxk/+KKShtwmFpzgstSPtA5i5sx9W8FYKxJUIhFSriwUzB0rO7 1eK9a7JOMvmGqdx0LAO+p+u8Yue2uIuP9DlSmJMWMsOvwN+8xK46sFsrYzXYoMJCBn0Be5MNb fQbhKhfPb+2YDPKnyoUKXKqXH6uu0rOM7A0TZKrZMUudQooCAbvXhjEsfi7I8BmmBxQ6J02f0 XVUpsLG+pAEsBUfU9NAGZX1g4kD+PbdqFpt//+To3jjsbH0IfHYT9lGz5GR+yh6gAiqB0lg0a hgDcVBdpU92d9KrDZPwBhUlTSebLLf5j/T7BSuiaEtz48Sl8S/aCAG4XMBUHx3k+B879U1Xam M1a9Ycg7IhQIfYxVkWMJ18ZRcRwNNGNo8Y+9VecUsxyoKCjrgRkkQktExER+om8ycNGAZ1ga4 MF8SC4kZxhBXufufg/cbZg+/rWmRuT6dmvRLrDqili2zCppfDdJdXkzHOq71qR+cVfXXefZo/ ZKEApFE0l7y1Sg19JvEukxvj6mL06Pw/0GFzJNyG6yoI0SPeh1vqaODQwW3PeVgTkGBsI6SN6 4CY8i9Oh4D8M5347cTYPLt3B8jrTBcllAj9HhBaeaj89p7jJDpdXzuBtfiFlKXpDTNvmDGERh 92H2/9S/kSrC/HbqXVBXMLMSa318N6+zzxv5zUsktYL9m1PKEoDf7ZJiK/37aHhq7u+GMAv9l ExJcI3+wlJiuaIFk2eILA8mUU8XUckGCneMDfkqFeS31K5GQ7Z2n8DokpSK2lgGuNdO37omiN kEV3dg3zjZVgWWdAQPABqTfQmpAuHMnFgywcpMXjMSn608X8Ozz+5ytUnkvPX8+lb+xh2T+yv Pbg31MYgG2ofWG5rGnj+Pc4+byQiSwqxe19bPi0iYAk/KnIk2HkWFX+2/ifNcokK/P4fzutg6 8Ie5sx7DhzCvsF7IVFcEEOdtqWjqu8r8sotpSeIFocIUALs42SwimrlwDq4y4YxwsQK4UYqfg u/z/iancy0D7zhxzQDI4VQttMapdTK5LoZzMhBSbwMaE5KLvyv18FD92OOsGplHsnbyUSX8/8 3XcHstgsupkjCGemVmXwqT9RX//0DGlGGuxxVdvQWE40aq2MHjNQ/4QdGH2Sxf4yD2JMgRPBz gr7sTTIPzEmskKVWd9JPRCvVLDGi5IFUfYmoJ5+76/RXKeGoUv9QTfIXJ+QuRyLwWhg0IWbOT V1Tm+XdzG1g3AZohRbTyv1NWCrZyaEYjap6yiTYepjAIRJ/E1/B/swUB2LaCnSXbO+a8griIf yuIw5KKdccmY3oz+kuGMxXLvkRg967UMFrFSiB8o/6w+j3oc+ha1NCDq9ZM3N/bRlH1ARADXu 89HzKNBoCLPJXeseCVKay+vDVw7jFyHpHtGwly1oXhWreIM0OVgb+Eoyp//BAusFeuTUKzFmA ZOFwgfeIiCOj5F1wkqNLkm37OQpV+NsVhEcSQYQ7RMLy6/ByBFPEW35mWu6i9h18r+h+AWlT8 to7JMjrH4+1uZr1kTz7EmSDyMYwtDIcg0AThFGwiXGVzfDvf4AP+VnZd7NJW1FsCAzSrAcudd VEE6z7xcNFius7aQ63of6E6gnNT4mcDksi5NxuR9zsr/k2Gr1coQni3ZixX1/r60tdb89HXEf vMZEtMQ/Rjrl3cIOAbC3kZhjBGG2Y+1TdYoDUY6dzRUT/Sr8ysqT3F7jAh9uNX9OQalORoYmH uiFd6r+o+SGGH/r22Y7apQJmyC9ttAY/44vuzmBUT7KLMi78uCcorygnHFSkQQbNneEdyHALJ v8ciIz5idJeEOK5ylYbzYQuWYeIVye22EAlm5giz157MbPxZPbIvSxBRJhvqYlw2TniJxXz9X BViiQeL+EvmAYP5ajR1yyixpjdSq0+D1LTK0hHlJA6akhwJLlowiNzG6YKcgucrCA7aWm6flf Ey0SGjzloNJtIZz4q9+Rzdsj5klh9NoNQJo3rUQkeKYl2DxbI0dGnqT6e341VC+gGWPzuem2S KCIrG3dTOszLLEP+igdm4SbB5shNdsQeiA1428vIqLTVRTPmz0tMkmxE4Xp74P7O5SuslZssg hPLIouMkCBMsCXBRsVbzjIsklBmT5NZugRWhR66kH7wrQBjQNnIZdUgf4y90pOXwWLsOElLPx RHjM44MepRuJl+0P4UJPzgptG9ChJvey6/CBo4yfyoHRVkMZvoTUHNPmFJN2bJSFnTnpBS8Ju lu5SCzZ6i3k/9w/aw8dMhqvPRb17cykUhEH3haN8E4AgpefZieX0Ld89dqGd8xyam17JCoiQd qaC9yqib3nUvN1VfWfWwqEXbHlogGtLbAezKfWDvWkUcFljBz1hh/aMHsU63HxvegS+HT191C CaBm6vZWVi6aV09wVyfv5L3JmOoK3atKlnpbyxfNDLmrMNDQJKKY4ZxG98nbGMnKzj057A9GH VoroB8e0bKpPoVIjbCkCidKuwDAWyfYuCFSjcLjw+mpnUmqz7DUjhARPLgJ4zXmf3w9QCoseb j+YFoj7LKTeYhWTCoG+Ospzpg2tFtlgNRLtdZaY5MHEldpL+Ad5Y+HM5XPDqKito0OngCXdxi xQ0x3SQwYPFohE/9SFNO+0VsGePiQ9DpzUcNrUipf6eH9q/hr7SbM6SFD73iTJCR8xnsD4X8F dYMj7PV5NPfU4GvcJ+eagcbpsaVr8CJ07fYgrLq1pVinkCL2oLjNe1AeFyw/cTqdJKV7H/NcS Pyj1OFloPlGo5mZu6TJFDKAVvk0cKGxc62tjtOsOaqN7AtzZiOKjQNphZACNIudgGt1bcsj3r hrwdoSfNuXn+08Kk2MOUZ7ZgO7Dbyuo1RLr2idyM/NJIAWr5ME4vctWF86wxGFsAumh17JBe+ EGWnQRQibqAO11KiDRVJKmqNwLhDUjfK983qHqghk0Wl68mRz2UwzWz/PXrCGNS8n6x49VVNW eMPs836oMp/pLWLAtCyDiNemgLthUHcPRZFPDEmNL0O1lndgyT2JeT2KUlVRwwArXiWfPFXiJ yo+bw0Bz5P/Z4jtsSjwtoO8BymE1QAEBqTMGNVslzc6jBxKG2owVyzBqncelaV2XG9R8Cu0Kl Fq1VZA/NgL9G7DX/r8Ph5fOVwn2hfw9uVO8+WbYQ9qeQPlJRNucM32QeM/I1VUn6pZbmpp//G TDn+egJmHOYFr3p+Jl9cq2vJe/HvDUkou5juhpP09SFhIhVhnKQER2v9zkQK9X7jcW8/IW3QS f1z7G40hjq/INxaGUz+NB54Iy2+nqZia5ixID/s3MQiETmefAowIopCVTHaJtLgk/FRncZPPh C7o3I5KYEXmbvAqFa32G+5sjYl+owUspvh1gGS+MLOdui/LiI4u3DwnWCToLYut6glOS27qgL IICx6Xb23v3fiH+aNgBvCm73kzA7uKE5Q65PfOYmBbuMTHLjnfE3Xk184j4/H3s5DS89vn62i HM50vMHrQSk13w= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 11 Jul 2025 19:13:59 +0100 Sean Whitton wrote: > Hello, > > On Fri 11 Jul 2025 at 11:33am +02, Stephen Berman via "Bug reports for GNU > Emacs, the Swiss army knife of text editors" wrote: > >> When I test with -Q, a Git repository is created and either the file at >> point or the marked files in Dired are added to it, although >> `vc-deduce-fileset' calls `(dired-vc-deduce-fileset >> state-model-only-files not-state-changing)', i.e., without passing >> `allow-unregistered'; so why do you think it must be passed (and >> non-nil)? > > It should be passed because the corresponding code path for vc-dir > passes allow-unregistered down. dired-vc-deduce-fileset is meant to be > just a dired version of the vc-dir code path in vc-deduce-fileset. I admit that I find the VC code hard to follow, but I don't see where `vc-dir' uses ALLOW-UNREGISTERED. The docstring of `vc-deduce-fileset' says: If the current buffer is in `vc-dir' or Dired mode, FILESET is the list of marked files, or the file under point if no files are marked. [...] Otherwise, if ALLOW-UNREGISTERED is non-nil and the visited file is unregistered, FILESET is a single-file list containing the name of the visited file. This seems to say that the code path using ALLOW-UNREGISTERED bypasses the code path using Dired. Anyway, I'm sure you understand the VC better than I do, so you should make the change you think is required. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 05:12:45 2025 Received: (at 78987) by debbugs.gnu.org; 12 Jul 2025 09:12:45 +0000 Received: from localhost ([127.0.0.1]:43894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaWHk-0006YU-NI for submit@debbugs.gnu.org; Sat, 12 Jul 2025 05:12:45 -0400 Received: from mout.gmx.net ([212.227.17.22]:57585) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaWHi-0006Xt-H6 for 78987@debbugs.gnu.org; Sat, 12 Jul 2025 05:12:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1752311556; x=1752916356; i=stephen.berman@gmx.net; bh=TVRbDYeSX07pVkfNCveOcFBMWHqAL7CyZi7k+nGCzVU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=GQLpZ8wR6we6lE+dRhceQopou0r2HdrvBBb9f8agI7LiBHTKjMgkWopB3pYOc+qa LFAYyWQxIwO9EqWTFLoiQXMNy18JcUbMxJ4PjX9X3SQjtnLYRQpFjMmoLf6NTrGGO sMbOhkzBIMd48JCOjD2G18AiUvZXp3/gys1GA+4kGXpaaYwktK0Jy9uN99rsaOTDB oCd4YDPO/9zL/FXBVodZ8WrMtkdvqZA9jWQKpP0LsNfEIOVRz+8HgkrZBBuMfWO4c 21HXM/PKbhfiUzlCqY9w26xmQMHbe1VhuGY8Abwf2cK1w2NmryXzfInU4LqvYWEnF F7Kqe/jKEp9c5ZbUyw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.72]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MN5eX-1uKMLO3ou5-00UZOY; Sat, 12 Jul 2025 11:12:36 +0200 From: Stephen Berman To: Sean Whitton Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87frf193qn.fsf@gmx.net> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> Date: Sat, 12 Jul 2025 11:12:35 +0200 Message-ID: <87bjpp93i4.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:trjdq5xRn1Nr4pKr7WY84psld9LXhI48KFpLdd69NPYSCBoI6Qc kMviRhXgCVEloXdAy1YuKxPq0GobnDauxlwmvAQcUxfUIQ2zLf8t7MKku0Unldbnw4blSXW LBB1oqE/DiTAl4IhVJGZ99Mybble+/nHukZcezkZt2nD5lalxirW/jR7df5f5CRex5a5GEY N8OEW7dIPhbaFXrd/4EEA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xO7gh0RHad8=;MzIRpytczgbvQw/yJMy4J/Hj0Xr uy7IKfHwXE5GFW+O8CRgXvXhgDKWetNS9kWY6kIliJscWSoVbhNxfVFwZKALt6gXGtbh4zjgU 5c7HoJ74Dsy3m11LfhvXoMrpoZyXRO5VfdOiiTpS0P+majfrYHlMvok3OQNwQA+rvnbF+P5Bc fdEptitYuM+/RelMOJsYrHH40A/kUYAlDBmYi6yX8fsN6+RVjsmxy/JP/DEEOo6Bf4gJO43MP FtLaeTtSQ0r3G+LDQZujTTbaxM2MWHL4CcFhmG3pUuIBSxTX787cO7uLYkACsYoxllH0dcd1h DU73M8ysLsc0j7xacVl2k0je/d1HR7P788AEmF0/vRlbl6TdcSQFv/RJsHDlJRNatv8hLAuOe WtmOPfyR2umgbKIbsevpo9sDx4Kn/enHH3Li9f9ypLwXAH8uR4eDjdwaq4btCQX1nKrEwqeDj XNWHKDY+zLhNU7pyqr5YIj0dKerwyUwHPX9mM0pGMbIuDxvIl8FniD9Kn3/X1nnvT2w6w4gaQ ORZhod24SYCRW48obAB7X2a4V4hLli4vEhZcxijN8iMjKOB5Zz+WyfSFUFka9Jx1Uv7zo2OmD PnduWo2cR+twx+pVZytyla61L8ROkfQ8mMHTJi5MQfNPhhCiiGSRVO8A8kTYva785FvsmdJ1d YBLX+sEnHg2gVhRpUOUplsAHMkseBJnkujT2FcQTqRWoRb8oFDneEKGA8RUZJY6jZT3QPJDI/ o3nBdCdMacjhRLgYDnx0apX+HYCK7JC0Poc1d9YAkf7sXKCAKBNCu6k4okXvh+l5PF0PqmGpc AFZSFwXVt/+/51z4kInyDwzMO3FshHqCJXOPtiOffqx1oN+S69PChKOoGwmizqMDA6kHrpc8X 32wVpyF6jFQCg9+1md8b1eTuxCTLMJegDcYl3dMHlYTHLQGkNiQEkbWl2PLneqsnMA5ZPWc9x 0U2s2ovrluy8+R7hY9hZjWPLrJzZEeG2bIwF40nhFO9aa6zFWpA9cMn4H38IKDU6eBpHY5HVL fKLijYoMm59pnHEZVuB7ZTvflUuiuM8ku3GYhIuP9ucs57wZvUIHdfNnRe64adHb5ythWZgmT CvfW8RPvmw/mkbUYYuIwM5u86kiYeZgTrmg7c9xZF+z3wxRiySIShx0NLa7/YnF9pP7znBuI2 4Aqwb9BlXNg2RyDqJ4bfVUxoUHpMCP4Kv03LKzGiFREtlP9YB51jSnyb69k5hZJJ09B2u9dTi mbU8Oc71CxNKx8tU8glV0sHchYskwrDrlAx8GDCg6nxlCSNTH1cc3g5nJtpbj1lteSO6lvKhK r2Yk5UkKFEpVH+u0rez1Nns2XgPy7sTk8nhC4t9Z9FTlGI5DhlbW1UzOUMf6jCANk99PGwIUz Ta39QIz0kdVaaOd6lFx0x4HPTUZaLwzEdyhm98j0iBK4gYbtPdgc85fTP/dWZuoxiz5ccWoKX 81p6M/utitBZJTZIaAPgJnyoRN21V9mGVr7+WQagu5AO4JHQewOPTfHeo2o1ylhXtSKO9hxke pmkLNHKEiI7zxNSBw07SRrIaFWOfUbtfdjUla2V3p5jTGEbRCTSsGBd1QBnIqWsesIKdQjw29 OR6sptqI1hAHEVaDrFdh5CZcYAXarxDu62KZnF58g8sZnE/NoIaQuW+Og41pcBZVHVViZI7kb Xje3pawALwFmU+SjgmFEcNCFAPoSjG39Ga81PSEj4MttTejLMOjzqRcq1h7uHH7i7ZAGygwgd DzwrRC7RmjEnz9j95ErBBrLkmdKHqMUNYBwBF1nZ7aLE1g5IgLKKvnDS+beSIHYNoa5D5dj+6 0R7pqBScwclgA/O48ySiN7RqsGxQ9/qNA7jKYauS22Rwb/hmMXHyT86ePQd+n9lB28vSCKab6 +1si1OKa39Sl8XhS9TwN3XSufd4n/LeYnMOJ1MY4KQLYUznioDocQBtbJuyvvGjKKzw8gtjVr gByOHpW6mEEChX7DNuKALSoWbRbKLGmhrDuaidJY84WGUUl8wme6OethPDEoORobCGU8U61Iz kbLWb1sGj1xe0G1VgQ4NeS7htvtR0sIdC2Yq1g+9jmHiRT1dacWt7fcRmgbh6nL5CzvMMM8FD +3NE8dSTdWk2t3AH4XxfqtqSXUjJLXzbB/7P5TbnKg/uD5Dqc48o1HoAws0K13t5vV0MTk5gF XbEu9DR6Thh1L+uodgcdD5G/DGGRBYbrXLkQdLywtBz9I/3yUFv2mqqTttR9SQ2zOq+w8u1zQ rURsMl9n82zYGSPRpj5VwCN4E8M5xi1uKeHCyeS4qJNEA0V6OqkWXjueBTU7aNuaH1eUg8UEh iD5qT/dMY5fyExaRngoVHXNRZl9U26vldqmqaoP9d0TP0nrRv57yNzUdAB03qR3agdajineKW kjOoDQzSwZ9ScEZKE++ZXMRD59LNZdcCk9wGrXGiFAvJh7bYMhva+WFAq0AHISJhLreKFKxcP 95d85EgvO1aOcIzEbAl3rAJzO/lkR7s5Fss34w2/21dE6upDZVDlyWdCuBdbYOK3EyDrbvqNL yGv4rnfQGGAhybPzz3t+GyQ5/aYdmJD4q3TrAhBsb9OMW0BZmPH+BptdICEpih5yax0sr0Gvz LNqWztafCsqJ9wiTnAsbPCde/K8QfE25q+oz+7Zt6k4kLJc4crObTCfQvVlC35RAz/rpFMfHW ctsEz/JVaXHTbzcFAoAoEoRb2EBPthd+efg7HSsYU+FovcNPzreawK+VKtizVjh7ShwQubVsn 3PalhKamNZZcMoGE5BlnK1Rd1omLc9kVj2Yv4SFuOFErP19gkvZ1EGBJOt/gN81QJVPS3M4HQ vESwbSdPunAWVSFCs5Gq0wS06q6uqTNl4JWY5BzMxoBYllYv5/g1oRHBashMHl+67mBJ+Gn9r pkjlgo7pzfalJbbn896QhNafjD20+rU4krHEtc9TnQxITLYHCrz/8SVXWRlbQMFTiTniO0ncl GP9njEY7rcA1ajbe3IVsUtD+p5x++p0lFLuXkJR8iQOO5ATfJBUrriMykbwYPEjh1cGkqN6vZ tbnOtFKlbU4x5e4iwJ9OzhF3l5MqTggvrLlygjBZoNOuTdBoudjlffHHPQ6C0xcba5lSY0pSv JHUTN8ltNgdxuX9NSTCrb9NokVf1g0yZn0kstr1wzgYXUZ8qEaW4dStXeOL+2eAj/QpPnWiPe 0dBgmF/R+FXMca1+S5EwV1C3kjXEneEM23otprcoM7wvBP14LiqF1w0aIB8g3Vc5uBW4Gvgf8 GyMacltknF5oZt3S/DEQvzQEitoqdOtgjAaZXIgWj50/wz88tlUyzshwdp4s3BHQTcN3dc6Ck fG4udJljgDnI8KlURbZZ71gXeSNAPv+DlQZ2xXkdQeeyqu2N7rMBeIIgryVh1KJ7wg1gbyzY+ uB9fmKhqDjuGEswaBMiNmVleiSMsTRr/XW6pqQf00McToGy9zj3JZV+fkuO/+zeY1api/Y423 00YUbM7smwOjAWf8UgzQPIPx57UV/wSfluyV1oAfQLWB3S2bVuhvNgFhayuOq9ZuYbNZbhKu6 OnKR2ifncu1zx0RFqtdGFI2u7ciQj1oHCRLPEGUCvOhj Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, 12 Jul 2025 11:07:28 +0200 Stephen Berman = wrote: > On Fri, 11 Jul 2025 19:13:59 +0100 Sean Whitton wrote: > >> Hello, >> >> On Fri 11 Jul 2025 at 11:33am +02, Stephen Berman via "Bug reports for = GNU >> Emacs, the Swiss army knife of text editors" wrote: >> >>> When I test with -Q, a Git repository is created and either the file a= t >>> point or the marked files in Dired are added to it, although >>> `vc-deduce-fileset' calls `(dired-vc-deduce-fileset >>> state-model-only-files not-state-changing)', i.e., without passing >>> `allow-unregistered'; so why do you think it must be passed (and >>> non-nil)? >> >> It should be passed because the corresponding code path for vc-dir >> passes allow-unregistered down. dired-vc-deduce-fileset is meant to be >> just a dired version of the vc-dir code path in vc-deduce-fileset. > > I admit that I find the VC code hard to follow, but I don't see where > `vc-dir' uses ALLOW-UNREGISTERED. The docstring of `vc-deduce-fileset' > says: > > If the current buffer is in `vc-dir' or Dired mode, FILESET is the > list of marked files, or the file under point if no files are > marked. > [...] > Otherwise, if ALLOW-UNREGISTERED is non-nil and the visited file > is unregistered, FILESET is a single-file list containing the > name of the visited file. > > This seems to say that the code path using ALLOW-UNREGISTERED bypasses > the code path using Dired. Anyway, I'm sure you understand the VC ^ either vc-dir or=20 > better than I do, so you should make the change you think is required. > > Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 06:35:16 2025 Received: (at 78987-done) by debbugs.gnu.org; 12 Jul 2025 10:35:17 +0000 Received: from localhost ([127.0.0.1]:44388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaXZc-0004Is-Jj for submit@debbugs.gnu.org; Sat, 12 Jul 2025 06:35:16 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:51274) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaXZX-0004Dq-Kp for 78987-done@debbugs.gnu.org; Sat, 12 Jul 2025 06:35:15 -0400 DKIM-Signature: a=rsa-sha256; b=i9EOO1uclvBnahPykVSjMUugT841o86u+QLhkmXfLU2cGsvc6o88o+z7WOXURElqd9fwiQ4jjJ5Spe6pG6WZStKRynnyMWXY9ybwxIVd3GUKYgwsXLGE1yH98mDMlyUXpt6TQj5Wx1ALVv9sdDbkpYj4m3mza8mcPW7BjmEX0PkzjL3sMBoSsQ1XmAwCPs33AIv/IQ5mEPAnrlsvkohq+QdPBm26xMiIN8vVzkg0b1LTQ92XA6zXfyYue5mKHr5PsFIaRffDh+Pp4/C3C3hX0aEFsu5tnNTr7qliQf9gWlnH4fMxLMFhHcAPnKl0A7qPeKkweEs+IzQW6jQis8OdDQ==; s=purelymail3; d=spwhitton.name; v=1; bh=+etP3C5FYX++WM5bDiHEYi8SJrbYV6qE8Pxp9wuznMk=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=oahw14ooJNaTSaGgRIRCx28KGG0jL8kNsJ1RQiJPCiSSmJ4/DInwScd4kn+Ds8yz9mn8Oyciul09vIJV8kiTibQBbMucxJPtBw25BUxZNTZK7MoSjPJfgtw5EGgY49G4+tsV2dT4KzqnuMD6f+ikLGcUJhit6hYqzyDF1czVaJ9Xm0ysdLNdC+32IEu4TFKdgKzJRpzH85y6Z6xpULpWmBo7vUH9JttirK22InEFQ8viL+ptbjYLDyjIkC3y29FJytP9kk4WS5+DXCboeRtIpX9S8lcz/ThIf5vM4ClALyi44ioBvaWPGZW24kqqvRO7iACTna4ZGXH0ivQlermH8Q==; s=purelymail3; d=purelymail.com; v=1; bh=+etP3C5FYX++WM5bDiHEYi8SJrbYV6qE8Pxp9wuznMk=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1661545783; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 12 Jul 2025 10:35:05 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 372779419BB; Sat, 12 Jul 2025 11:35:05 +0100 (BST) From: Sean Whitton To: Stephen Berman Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87frf193qn.fsf@gmx.net> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> Date: Sat, 12 Jul 2025 11:35:05 +0100 Message-ID: <87v7nxbsti.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987-done Cc: zipeilu@qq.com, 78987-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sat 12 Jul 2025 at 11:07am +02, Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > This seems to say that the code path using ALLOW-UNREGISTERED bypasses > the code path using Dired. Anyway, I'm sure you understand the VC > better than I do, so you should make the change you think is required. I had another look, and I think you're right. ALLOW-UNREGISTERED is not relevant here. I've installed your patch -- thanks! -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 06:51:28 2025 Received: (at 78987-done) by debbugs.gnu.org; 12 Jul 2025 10:51:28 +0000 Received: from localhost ([127.0.0.1]:44493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaXpH-0008GE-NN for submit@debbugs.gnu.org; Sat, 12 Jul 2025 06:51:28 -0400 Received: from mout.gmx.net ([212.227.15.18]:42065) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaXpE-0008Fa-7V for 78987-done@debbugs.gnu.org; Sat, 12 Jul 2025 06:51:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1752317478; x=1752922278; i=stephen.berman@gmx.net; bh=ZtaOFIuwdaLMIGiKvVpnb+fGSw0764tw6JADoNbw/6o=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=HiGqNa7tXyW0Q76txjokB30cLIn6nz95hWP3IQMP/4b7joEHil4fAXCc8kVc7nAo oXWynUjPj2nwwwUV3uDp9r44fiqd9XgYrBre5x/FyNO2RSnyMr238GOmD/vnNr4HK eM8GZdw7ZobQikGZulD0juJrN+M5Q54MbNekbR+01tQVQ/J47Ef2Cm3lG2p4mSIaa Wxy5+/9iiUpia0OAerO57Zybp3OwwfdPaoVEdpmrolp9Nogmia4GIeQ9n9f4SJ40L vt5GE5kJxC1yZFsfeZziz3Cb7L4CHXWbBs3ny0rjtckK7Ay/wnFoHEANRAiRKyDrd kCd6tqjG7IT5mJ5NAg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.72]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtwUw-1uvdZw2EqC-00svJz; Sat, 12 Jul 2025 12:51:16 +0200 From: Stephen Berman To: Sean Whitton Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87v7nxbsti.fsf@zephyr.silentflame.com> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> <87v7nxbsti.fsf@zephyr.silentflame.com> Date: Sat, 12 Jul 2025 12:51:15 +0200 Message-ID: <874ivh8yxo.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:s3Me35VXjuLvf/I1firAAf09CHo8fWyFDtxUDKBzaeBWHuuJXcG xdKnnIvzod1DkC+h2XrflkoGPvFXIB4C7v4TDJAoNb7maBvIed5mSPvdy7gjRDWG3kDcdqz VVFbWhDKI/NPqlR65lQTCpYWqJImVhTUupKZ2MBI9KbxLrTv+2uLiC+y2Bb6zACyrIbckhv hamhFWGUhHEUsBLMfvCMA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:13OeMKJJcbg=;/kG7PIiCrz4CwmzZ0d6GB+ZHZgV TPUMHcIODylT5V59IN1jjKf1OEWESXU8cnqzkR8b0ibF1D2gZ2hmk/snPs8prGQ3aEgLZDfMc ICQq9vBwS4GXHDrm1ojf/ubt2N7X+b+PRouxBc8zzFi51Sy/zqtSPfkXCacZHqHYb1Y863rzV 6HHSjKB5Mxej7excfc/jM+M2UYLQU2fh5dkGtMYY1JWDBEMjGntvJI35m6JDMuedjDCw9tIC5 27VF/mN16Pxlf54Al0E6UiYkyM6I1sUz1l3jxGZrl5I1rutPUwyRTgHHRkFXcYq+KZC2+2pW/ GYSdbAt47CGIbm1gH5vKxJQki5XR9N0uTBjdnDZVohpSTy2QJqEd2jI3oSiWx2SeGg5Usj7Kl Nx1N6cWy0lBo75iJnEEGyIrTAoYakKGqOk6mxDm9jfkvPFFWUfSdLMcknJOfIHWI+85p6yj43 zxKech1okE868N7oouSD+t7EYtH/XqfAy6nYkgj4TLhrdnhyqogBMunucOiI0YohMXZlRAeEl 7zS13N9OHclLxWECUFUUKMsDKD/GEbMRdEU5p1ebNUs0wG8xEfLefd1+0RhDebvQ/UM/dRkkV reme51uJdsIbuAvGRoDFrK9UftXPWWLwTJkl0lJsaYz15LM2MeMB7w8AgtEBKIGVVwaE4pWwN mvF/sJYvcA78FG+tiMHsr6y7jlDJQR9sjvQpbeVQRRwpmIbuOYvU3IwTKpFd1DZq1sX8XA5qt 5uh/KUcCZDlGevz/Enb7TXyXR25uz8E2Xmc3nma86VMudKwBzEfsqnIUT8pI8GwgK5all3CVV 3/7FL/t+75Hr0LDj7HfTMiwMpcK91BLbN8MNV97wyi8Wu3VI6cbJuLRzZaGozS8VEYRzAxEMz z/QY21fSCkpglbSGUqR0fs1AoRYcJIuAWdqd7iqk96sPkmqPCS75Bq4NxBWVP2YdTJgvQeL77 h+R21fnSPvMx6yWarsE7gJ5KIfQSvWuTOt1squeoEcPTW+i51NRh22zI3M3EEgofhKTIOSpYJ cR/7jXYOlFiUxslbSTEcxyJQVm5JmimQ7ig3/6D6/PHyfJKtnK0mHtkDOmv6C47KQGeaeiGwD xhcB3MzbYVpRU70ac0ClD1W1fS1LCb8FeFTunsKeJeK4EHI2o3Iddvm6MsFeirucRwnog9Bbv xcJwH9O1mzy4k8Yp/4JbYov4HSPqaLvD8gXCjjoI84GQ6G3YX5G4HtB5rbFkM1BsPfKQvWY8L uF/vG9H9fj6PWgRpekfUOyXLh2uijh+4yHp8bo2sRccDiVgV+6zpIbY+hxv4RTX2ySvW2eojn ZZj+RGRd9fgF3hIsfh0oaJ2YpLZbMCBlx45j47UA3Uh4S3RftLEbYho1frHD7TVMfCgeUCw5/ sYUxHaqlLzQl8pBJHewVe3rIUe8GTvkDGD3QjCkCly+06VsqW3iPdj1JYU1ais4++cF8yTTkq z2vGTl0vuTImGbxoCea/JTfA9TvzEH6b9gEpcDNCYFjPx1tK7F/mdSA5K0yY27cF3D/oGMCP7 nXonG9QboBxwLY+kJuqy0Zm3L+HW1etRHM6Ckoq2JZwJfTeMEZC6XoF/ShLkNOjms8zCw7+Zu IFQyFI76718uyp9fc7qJXq6tYlgAYCGy0Evn5QxPRy+jWLLL5eRVKPaDxSuXsNGeMzZrBRuJK 7U8AA5QabCmdLOiOb7bCOx8lEP2hjS6mkpT9BTROp5q8GyLPPczDbYNXyYLJbLPW90ByXPX10 q91XjGmOQ8qKggEG99V6vNGNOeyYpAbjzh5RBHP3YXaPtgTSBQgggPM026SVzOi88NzeKUV4b J2xJGLuUizgeRpaFNGt7hzbphcYD2xmJyX4msfAjdR81sAvYJ4jJbWH1wsTtD04wJ/2cvAImW LBjmgHgpCnLSP5MiqeKeSoIJgBBRtG87P9mpKlmuA+QG7remy75XJTQZLTtO1EdMpmrGWT6s/ G/N1zNClgPdLrpTRMp349XWJuNU7n9LcjNDro7f8KwVgF5Llll7/lEhjJ7DKVh2s/Un/RDWIH J2R5HuYMZPWqIKKTgGTxpUatL6AC/4D1WwXx67I2aCAXtB8ODJOounTy87YUDj48S2T7YgrHN WvhFP6HRtaM6YhCast+1E8nF80Oltl8aGAfuSu8v0juuqhl1L6OchdWicoNlqFDSV25hDTqDU jCXx0kE2yMOMt1tInIcWkIlgxqLpmcqZ3g4jj12gPjJXBqfDSpxlqnFs8mH5wWObsX2q1Vx// Sam246OZVy97xCr3IpCHMZVGWhpHilJNkSQe9OCePaJ9wezV7wkdiHXaJO5yWRvlpClDMdESp E95o3Vqbqlnfr4YiQdjj45ZHLG7JezYNOIYN0ZhwBmGxEhPCVSYhr2wAzM/4wUv4f9szeX9qx rw5yxFISkIyTJ99eOZ89qrT2nrkRJ2PxkmQsKBtiVyFB10ferh3rEbNdMuihE2eUF1NW8hCHJ NkqLOzrf5pF1fa5YeX04u4ZrVsq7qi6ACWC+YNvuO1CGP53JQswnBe77VoYAH2Z1OACWNg1jl yeYWnM5bJDG7OUQ8Nfav5mX8ijOG3JxjL3qDZeKwAgyVZwkpEajjP/FJL6JYoAGX9CEn3Epu/ ZZvy8nSIzw0lRSHKwkXyg9bRHwVB+BJxc2YYpKzjRCf1QyOFEO7OIKNNw0dGWJt/oWHMSPykl zNOAf0Ez7Lf2Z/mmwqD0Sh7+EKvqcKo2LuGRqvCjqasiv4h08Vno6iDViC+Gtd1m1j/xgYvko gXEQfyFEWQj7o1PHHjCKmIMCMamY+kcZFf3QpP3Bg9Bofi2kceafK7iYjj6JUp2WBSB7+F2po lMEX/VnBJXvzYPgNdepc09sNLhFensTURTgVrk18hT4X5Wa5J3bufY7MWyZXljW5tL/mtD9Za p++YlmKtIyemdeetLEIShCXD9Yo2b62nquNhxETRB5ujyCjyI5t7mo5JKLYSj1F1GZEyw+l3g 0wlTI0vOrv1p28y5NEv4GRp0CVVKczqVb4GOy8KiqQ4kxrZvmOkCe7zSG1qod+djbeTWk7hQp jBgklQExmdZ8p0qNVDbJE2nCmUtalJsSSmuJEayHwSrBprBJlEpCQ5QeZSGgNmNOrgYYH3znq 26V8w90CCgBQRqbUshnV54SkCbAIcxapJyxMskCkZEHZg9kyqRnJSBHulaLegciUoIKkP5LGf rRfcHfKIyrd4yL7Kivfc8DMj7HcoKfV2wuN578TeW5ihNQGEsaYBz7fyiYXt8ktCEEm4xQK5o qDKb7KPStZ8t2y2tsAZ8gML1RfHI6aZeCHIN3wOV4rQMSxvw/SQjCNQkOAZMmUmGudMupIIhO nyVGZSC80zOhie1PjtyOgqdSEvHstB0oTWg9MX6SuQP8Aw7S29kcznxD3Zm9HTAVStG/w6Ci3 lEozKolx/4jRWX7fNuPQO3THRH94qulRsUgpVW7R2bcGjBuBg6VZWPpCuce+f1kINsAhY0Mxv mbi0dzZkEc0Jo1uSPjqA7QgrpJ1PRQi4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78987-done Cc: zipeilu@qq.com, 78987-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, 12 Jul 2025 11:35:05 +0100 Sean Whitton wrote: > Hello, > > On Sat 12 Jul 2025 at 11:07am +02, Stephen Berman via "Bug reports for GNU > Emacs, the Swiss army knife of text editors" wrote: > >> This seems to say that the code path using ALLOW-UNREGISTERED bypasses >> the code path using Dired. Anyway, I'm sure you understand the VC >> better than I do, so you should make the change you think is required. > > I had another look, and I think you're right. ALLOW-UNREGISTERED is not > relevant here. I've installed your patch -- thanks! Thank you! Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 07:06:45 2025 Received: (at 78987) by debbugs.gnu.org; 12 Jul 2025 11:06:45 +0000 Received: from localhost ([127.0.0.1]:44578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaY44-0000r5-NV for submit@debbugs.gnu.org; Sat, 12 Jul 2025 07:06:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52968) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaY42-0000qb-7y for 78987@debbugs.gnu.org; Sat, 12 Jul 2025 07:06:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaY3w-0006PX-Dn; Sat, 12 Jul 2025 07:06:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zS1tTiEakylf8NCWDChpwAikCNZ9BRTtNAYXjvPkL00=; b=V4zavPioqLAA ti4S9/GwrVmsXWWr1a0R2bP1MemfFJEjIwrnCQztK2dGfrcq+1CYcMKCndIZ7f1OriZXWLQAw30ev VfdoR2XAonKDvUCO2S9iZrbZo5hcTAU8FHgI9MPthFs88fyR3UZBwLo5sM+EIfJ1bIqEAN/UgzxJ7 CA8KCy2geBgplw93kSk6ir/5+M5UgzI/78OUS1ZY9mhmYzCvCm7Oyzc81aLdywWJeWh6YZfKRSLGB wVxGDmed4xJOOt3nL5/h/ablDoykwVVSApUsARBo1QpEHp5xgdjJt5tG7cGZEg3CiZyZ4vhA9ThUA NC8tvVDJgwSJnzmoAy9crw==; Date: Sat, 12 Jul 2025 14:05:52 +0300 Message-Id: <86bjppekj3.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton , Stephen Berman In-Reply-To: <87v7nxbsti.fsf@zephyr.silentflame.com> (message from Sean Whitton on Sat, 12 Jul 2025 11:35:05 +0100) Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> <87v7nxbsti.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-To: bug-gnu-emacs@gnu.org > Cc: zipeilu@qq.com, 78987-done@debbugs.gnu.org > From: Sean Whitton > Date: Sat, 12 Jul 2025 11:35:05 +0100 > > Hello, > > On Sat 12 Jul 2025 at 11:07am +02, Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > > > This seems to say that the code path using ALLOW-UNREGISTERED bypasses > > the code path using Dired. Anyway, I'm sure you understand the VC > > better than I do, so you should make the change you think is required. > > I had another look, and I think you're right. ALLOW-UNREGISTERED is not > relevant here. I've installed your patch -- thanks! Thanks, but I don't understand why you both made vc-backend-for-registration autoloaded _and_ added an autoload form for it in dired-aux.el. Isn't just one of them enough? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 07:15:18 2025 Received: (at 78987) by debbugs.gnu.org; 12 Jul 2025 11:15:18 +0000 Received: from localhost ([127.0.0.1]:44615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaYCL-0001Na-TY for submit@debbugs.gnu.org; Sat, 12 Jul 2025 07:15:18 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:47796) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaYCG-0001Hz-38 for 78987@debbugs.gnu.org; Sat, 12 Jul 2025 07:15:15 -0400 DKIM-Signature: a=rsa-sha256; b=ksA+rhRkYG5u1eMDyAskkVVqp6hOggHopJ+QlbTqq1Va0hCEA6/P/Du4b5ynVirJQnkdDyu0HmkFKEeLOHBrviMCpFqt+t4aoynh3+OUVWg3RieQeOiBAxy09qu/G+tWburpFW3RSvf/63NWnjaUk1kVVymu5jvVjvJ7OPsDIf/TgNMeH7fLQovEOtShgfO8tNlsvZKlhGEtbYTfFRUOzaPJCAVSvVMY9yBodC4HGc5KFmWpV0tnSSneSu7GoHxKyBk7TUb0pa5pFpOhe4WJKLC2ms0CD7RzJfCOkrtLKqJ0R5Ckh39wr1ZI0QpT4/72r+TJiG3bMUCfxhpOHEYCdQ==; s=purelymail3; d=spwhitton.name; v=1; bh=9S5b1KuljipUEcUNzGuw/otftceCslJ1Ln7ROA9hdtY=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=ZREHs1mGpOtaYvm/S8emnsfMgsIWvfYE327L9Z469a17cCTtWvbDPIyq3zl1S+zzjGPeV7id3kwCV38uxyh61rwJoklTOhKknMps9Zn6iqA3A8f2Px5RPFrZTfZSTjMjkpiQQkRUKsyyty/g2NFChftrfOpyNM115sofTBrA2909698v0JvZDQVOZ8UiE8eb9lnJ0xZUSB19uvyjaaJE5A8RuA/0GG+c+iqn9NbY7ffmeRx2lxRclgHMe0PL+cF4CQJk5z5LMhegUEWT5FGXy06L56KJZAkKeIxgEXqGdczldwYFaNqYjsbTO40PQlQaGpkKJfpPxKNnqvs7wvTtJg==; s=purelymail3; d=purelymail.com; v=1; bh=9S5b1KuljipUEcUNzGuw/otftceCslJ1Ln7ROA9hdtY=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 351268648; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 12 Jul 2025 11:15:04 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 2929D9419BB; Sat, 12 Jul 2025 12:15:04 +0100 (BST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <86bjppekj3.fsf@gnu.org> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> <87v7nxbsti.fsf@zephyr.silentflame.com> <86bjppekj3.fsf@gnu.org> Date: Sat, 12 Jul 2025 12:15:04 +0100 Message-ID: <87ple5bqyv.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, Stephen Berman , 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sat 12 Jul 2025 at 02:05pm +03, Eli Zaretskii wrote: >> Resent-To: bug-gnu-emacs@gnu.org >> Cc: zipeilu@qq.com, 78987-done@debbugs.gnu.org >> From: Sean Whitton >> Date: Sat, 12 Jul 2025 11:35:05 +0100 >> >> Hello, >> >> On Sat 12 Jul 2025 at 11:07am +02, Stephen Berman via "Bug reports for GNU >> Emacs, the Swiss army knife of text editors" wrote: >> >> > This seems to say that the code path using ALLOW-UNREGISTERED bypasses >> > the code path using Dired. Anyway, I'm sure you understand the VC >> > better than I do, so you should make the change you think is required. >> >> I had another look, and I think you're right. ALLOW-UNREGISTERED is not >> relevant here. I've installed your patch -- thanks! > > Thanks, but I don't understand why you both made > vc-backend-for-registration autoloaded _and_ added an autoload form > for it in dired-aux.el. Isn't just one of them enough? The autoload form in dired-aux.el was just to satisfy the bytecompiler. Should it be declare-function? Or should I drop the autoload cookie? Which do you think would be more appropriate? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 07:45:00 2025 Received: (at 78987) by debbugs.gnu.org; 12 Jul 2025 11:45:00 +0000 Received: from localhost ([127.0.0.1]:44727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaYf6-000608-E4 for submit@debbugs.gnu.org; Sat, 12 Jul 2025 07:45:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35312) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaYf2-0005zr-NN for 78987@debbugs.gnu.org; Sat, 12 Jul 2025 07:44:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaYeu-0008Vc-JJ; Sat, 12 Jul 2025 07:44:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VUwet/oRmSal49pAf9p4z7Ltw6DZsFTiJegBaXO+5I8=; b=HgfFguG6nsb3 6z0fBMnbF3rXyn/WXcJiwpgWNuGXsXbiOFdkEE7HuNExSHT0eNANvmhhwEUoUFbinpksVqunIdCZS Kl9Zg1Ivmst0Bc8r2eXJfhhYWdILgbBX043zLc6Vr3ewl9Kvf4XxahG50J/4eSbh5gltm+EPAjc+h HSwOHiAlVWXWBrSy/T0Mkrr73A1By4RSNYNZ1VAS5e74MyrnNSP63HUP3VbuBlS263ktczEGKb2jV durXLiJ8+qdPntQOiioFlovOX5OeuP0SM/bNglVUPA+KUz8pFj45/r5dRdB36PDUHFLHsBO0Xurj5 fmZCK2N/uC/CuDmnPD7DXg==; Date: Sat, 12 Jul 2025 14:44:45 +0300 Message-Id: <86a559eiqa.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87ple5bqyv.fsf@zephyr.silentflame.com> (message from Sean Whitton on Sat, 12 Jul 2025 12:15:04 +0100) Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> <87v7nxbsti.fsf@zephyr.silentflame.com> <86bjppekj3.fsf@gnu.org> <87ple5bqyv.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, stephen.berman@gmx.net, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: Stephen Berman , 78987@debbugs.gnu.org, > zipeilu@qq.com > Date: Sat, 12 Jul 2025 12:15:04 +0100 > > On Sat 12 Jul 2025 at 02:05pm +03, Eli Zaretskii wrote: > > >> Resent-To: bug-gnu-emacs@gnu.org > >> Cc: zipeilu@qq.com, 78987-done@debbugs.gnu.org > >> From: Sean Whitton > >> Date: Sat, 12 Jul 2025 11:35:05 +0100 > >> > >> Hello, > >> > >> On Sat 12 Jul 2025 at 11:07am +02, Stephen Berman via "Bug reports for GNU > >> Emacs, the Swiss army knife of text editors" wrote: > >> > >> > This seems to say that the code path using ALLOW-UNREGISTERED bypasses > >> > the code path using Dired. Anyway, I'm sure you understand the VC > >> > better than I do, so you should make the change you think is required. > >> > >> I had another look, and I think you're right. ALLOW-UNREGISTERED is not > >> relevant here. I've installed your patch -- thanks! > > > > Thanks, but I don't understand why you both made > > vc-backend-for-registration autoloaded _and_ added an autoload form > > for it in dired-aux.el. Isn't just one of them enough? > > The autoload form in dired-aux.el was just to satisfy the bytecompiler. > Should it be declare-function? Or should I drop the autoload cookie? > Which do you think would be more appropriate? I'd like to avoid the autoload cookie, yes, if that's feasible. A single client doesn't justify the autoload, IMO. Why doesn't the autoload form in dired-aux enough to satisfy both the byte compiler and run-time? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 09:08:32 2025 Received: (at 78987) by debbugs.gnu.org; 12 Jul 2025 13:08:32 +0000 Received: from localhost ([127.0.0.1]:44957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaZxv-0002aT-SQ for submit@debbugs.gnu.org; Sat, 12 Jul 2025 09:08:32 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:36276) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaZxt-0002aC-4C for 78987@debbugs.gnu.org; Sat, 12 Jul 2025 09:08:30 -0400 DKIM-Signature: a=rsa-sha256; b=q3K3YCyzmlU0Px8BS/7cjDJqJo/1HPU1q5M+EDYnGJQBfp5pvxFGlpux5e646RbIKobvfAgESEzmv3xlVuyXIeWZpdSyKL74OsyOOIDsKM/7OIMgA2su+B+DHjl2a5EGc4uk9rX8m58FZOym1ZAklNwUvqfJ+IzN7cp8PKCjLnTe04pLZ1cMojxm+nrpt6mwRTryIVZqQAK2QEHqZLztNROxg/hJGAtnSrpgES8tWNZplUvPYtlnBdQMMfEW5gqBSOKNW1oC64KKbJW3TYzAKcP4c9iCFWyaNolYlwdc+yEloek8pWRQTiWN7W+b7vlEGE3XA8ltFEPECNrrjM/cWQ==; s=purelymail3; d=spwhitton.name; v=1; bh=OIe3K361R7cGRDeAhh8U8wgYBP4qiqj0QHuqzzIJnAs=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=c5X+xmWYk4meHxbQ4DbIy2zdEffpp0z1QielXHNDVL2zG2hi92Fu9TbPi7vFywa8rIHyph6JF2TQPF4mfePcUM8EuGJhBZdGNNhfCy9C+dJqiLqPhxQ7RfMmdaM6gN8WsRsnX180U6LLFNtGjkQyqbZMg48FxLmR85jHFctDRkkAg52If+n7sxWJhw/2vWP5cM3KJh6Qk7aJPzFGO/h0EJh2CHPttwyzH4z8byJe14eU7jeVCxn+fK654Aq3K/cqnwgTSHChU6lu0kddVN23RgWlWPmD8TEW5OZj78vPBH4POOwOrj5g4Pzbg5x6VBB7qOtADje9XEu2jGZJxA+BAw==; s=purelymail3; d=purelymail.com; v=1; bh=OIe3K361R7cGRDeAhh8U8wgYBP4qiqj0QHuqzzIJnAs=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -2015119603; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 12 Jul 2025 13:08:22 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 68F3B9419BB; Sat, 12 Jul 2025 14:08:21 +0100 (BST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <86a559eiqa.fsf@gnu.org> References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> <87v7nxbsti.fsf@zephyr.silentflame.com> <86bjppekj3.fsf@gnu.org> <87ple5bqyv.fsf@zephyr.silentflame.com> <86a559eiqa.fsf@gnu.org> Date: Sat, 12 Jul 2025 14:08:21 +0100 Message-ID: <87ldotblq2.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org, stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sat 12 Jul 2025 at 02:44pm +03, Eli Zaretskii wrote: > I'd like to avoid the autoload cookie, yes, if that's feasible. A > single client doesn't justify the autoload, IMO. Yup, now done. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 09:54:21 2025 Received: (at 78987) by debbugs.gnu.org; 12 Jul 2025 13:54:21 +0000 Received: from localhost ([127.0.0.1]:45095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaagG-0005XN-OG for submit@debbugs.gnu.org; Sat, 12 Jul 2025 09:54:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46356) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaagB-0005Wo-54 for 78987@debbugs.gnu.org; Sat, 12 Jul 2025 09:54:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaag5-00047Y-0G; Sat, 12 Jul 2025 09:54:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i8AAFHNkXpkdybvqNYnRR/FmZjNcvHum2m6PxO+RGZg=; b=GhZSWlx6dPKZ A4NrJdj42Xtet5vW9FYyiWtNMWpXAjWLy4l9hL/zJtj0LfJWKJxAoSdaH3fFs1DTyq+3KvpPCVW9z oEB3pcshDo668gnURzy0HxJs7BVcKoG1UKj18zRByZIvJTlm6iiSqnYO9AQCCuiiy/vPSH1+lerZq Gtht717QCwVf8EzYTi1q2JqIXsKvhsI40xvcqMSR7YWI/GF8LuhjCVHPa8qMczuzP8OX6+sMLQCAe RGGRTL8oEagp/Zw/NU6ZLJeW9RgQ49u6biDOlkhZ841+FmVfYSVO9D6zgaX0lbNec8o+V5ylniPyW MViHG5BiIt0dKMwKMYHH9w==; Date: Sat, 12 Jul 2025 16:54:06 +0300 Message-Id: <864ivhecqp.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87ldotblq2.fsf@zephyr.silentflame.com> (message from Sean Whitton on Sat, 12 Jul 2025 14:08:21 +0100) Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode References: <87h5zkanwx.fsf@gmx.net> <875xfzdszl.fsf@zephyr.silentflame.com> <87ms9bcd37.fsf@zephyr.silentflame.com> <877c0foyv4.fsf@gmx.net> <87ikjyd28o.fsf@zephyr.silentflame.com> <87frf193qn.fsf@gmx.net> <87v7nxbsti.fsf@zephyr.silentflame.com> <86bjppekj3.fsf@gnu.org> <87ple5bqyv.fsf@zephyr.silentflame.com> <86a559eiqa.fsf@gnu.org> <87ldotblq2.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78987 Cc: zipeilu@qq.com, 78987@debbugs.gnu.org, stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: zipeilu@qq.com, stephen.berman@gmx.net, 78987@debbugs.gnu.org > Date: Sat, 12 Jul 2025 14:08:21 +0100 > > Hello, > > On Sat 12 Jul 2025 at 02:44pm +03, Eli Zaretskii wrote: > > > I'd like to avoid the autoload cookie, yes, if that's feasible. A > > single client doesn't justify the autoload, IMO. > > Yup, now done. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 13 03:17:08 2025 Received: (at 78987) by debbugs.gnu.org; 13 Jul 2025 07:17:09 +0000 Received: from localhost ([127.0.0.1]:50727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaqxQ-0004LA-N3 for submit@debbugs.gnu.org; Sun, 13 Jul 2025 03:17:08 -0400 Received: from mout-y-209.mailbox.org ([2001:67c:2050:103:465::209]:50362) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaqxM-0004KG-7v for 78987@debbugs.gnu.org; Sun, 13 Jul 2025 03:17:06 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4bfxbD0DNgzB0XM; Sun, 13 Jul 2025 09:16:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1752391016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9tGxHVpVrf9pttqn8GnLEC+SxfBaebtfy8PiPqw/YD4=; b=CMCioRhX8btJDrsvRWNh/+/9NQbaMYNxzrTgS8Hxl6wDj3/pDo6mSNPboM+m14XkVVJXis OszqRIeJaNssPugHOa3bSeS4f/wGseSVjrfJMRbUC1VA5ALGtxnzNTq722eHhVd3DMSZUt GsTXuajxxfL76QZfrci3n+/G6Tp6eH33fPll4ua/kLH+y41Orxsezwm0wdr9GQkwXaVlVb 2w1uZtrjy2GR9Fc66eKKMnUbfkOY3Fvmf7f5zIra1qb1daTQgGbLUuN5so8AmoT0ZL/6Dm u6m9bpLNBX+JVoElYui+cgoPR8AgDBQI6gGP+kwcMRv4h+DZt37yBQQKdUa/IQ== From: Juri Linkov To: Stephen Berman Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87h5zkanwx.fsf@gmx.net> Organization: LINKOV.NET References: <87h5zkanwx.fsf@gmx.net> Date: Sun, 13 Jul 2025 09:58:59 +0300 Message-ID: <87h5zgmuhc.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78987 Cc: 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > (defun dired-vc-deduce-fileset > (&optional state-model-only-files not-state-changing) > - (let ((backend (vc-responsible-backend default-directory)) > - (files (dired-get-marked-files nil nil nil nil t))) > + (let* ((files (dired-get-marked-files nil nil nil nil t)) > + (backend (or (vc-responsible-backend default-directory t) > + (vc-backend-for-registration (car files))))) The original recipe still fails with the same error. Shouldn't 'vc-responsible-backend' be wrapped with 'ignore-errors' in 'dired-vc-deduce-fileset'? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 13 03:54:48 2025 Received: (at 78987) by debbugs.gnu.org; 13 Jul 2025 07:54:48 +0000 Received: from localhost ([127.0.0.1]:50906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uarXs-0006qL-69 for submit@debbugs.gnu.org; Sun, 13 Jul 2025 03:54:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60056) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uarXp-0006pv-6L for 78987@debbugs.gnu.org; Sun, 13 Jul 2025 03:54:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uarXj-0000W1-PV; Sun, 13 Jul 2025 03:54:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EUf80glgBHO/YOyIWoSkUnTgSoKsSUp6PMCFIFhg59A=; b=jx7Ylx1wH6q6 iDgRSrASOONPdfHf0QIPTRtv2+6cN9zB5jR92MoRqPwV3+2YVrlnaHIIin26Hy9slU0IHMz5t2Dow 3uMPJsAbtKw5sIx4bl9iWKaHCd5tFZsBUgmeGQrlD306o3SgaOYlQ0sTErxBvZCtNIzYQKsvhooe2 J/hBKgAwLMpIsYJ92CEcpeFXFModlUY3LqdCeFXNa9FVucQtBYQHKrkWZbOSHWMapDfbXD3H46/tf lmYlQyxNIYbTeMNuWHpZvluvzpEN5tr4399aQIcROXuTqY8ZKMyDKQuuDkejZHecf8CI+NfrcxuMu wW+9x2wb/as8IKoMITJehA==; Date: Sun, 13 Jul 2025 10:54:35 +0300 Message-Id: <86sej0cypw.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87h5zgmuhc.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 13 Jul 2025 09:58:59 +0300) Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78987 Cc: stephen.berman@gmx.net, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 78987@debbugs.gnu.org > From: Juri Linkov > Date: Sun, 13 Jul 2025 09:58:59 +0300 > > > (defun dired-vc-deduce-fileset > > (&optional state-model-only-files not-state-changing) > > - (let ((backend (vc-responsible-backend default-directory)) > > - (files (dired-get-marked-files nil nil nil nil t))) > > + (let* ((files (dired-get-marked-files nil nil nil nil t)) > > + (backend (or (vc-responsible-backend default-directory t) > > + (vc-backend-for-registration (car files))))) > > The original recipe still fails with the same error. > Shouldn't 'vc-responsible-backend' be wrapped with > 'ignore-errors' in 'dired-vc-deduce-fileset'? There's no need for ignore-errors; instead, vc-responsible-backend should be called with the second argument NO-ERROR non-nil. The original patch did precisely that, so it looks like some snafu when applying the patch; now fixed. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 13 07:12:33 2025 Received: (at 78987) by debbugs.gnu.org; 13 Jul 2025 11:12:33 +0000 Received: from localhost ([127.0.0.1]:51844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaudE-0003bG-HP for submit@debbugs.gnu.org; Sun, 13 Jul 2025 07:12:32 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:35402) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaudB-0003ai-8S for 78987@debbugs.gnu.org; Sun, 13 Jul 2025 07:12:30 -0400 DKIM-Signature: a=rsa-sha256; b=xdaiv9HJ+yCX/mrg7rurniII3ibI88K82Gi9q6Pd5X2CUAhQs4RoWeQeHkKCb9e1OJHARM0i6s54DoaDfzyDWN82h4HWjVOxl5YojM/NAFS/vOKW1sUYJnMgwv7pQ8lM2GLWbrDZ1Y8b1icszqrlPRV52j1GoziEO/zMVK7Tp/GUIdxFFMI0PMNsnQZhIeKcS+2agl0io4bb2PGAhKMdHpGCLTidJDR6ysmUbE5etcDGL1px1cIAa1Op2M0/0q3EEfr9tKZA4bczrSw6mDfYjPfyaQYIR5zEqnluMUzFNJCOCdd0yHjW8ui5R2voFZ4PtmNCqJVatcBY2lfeehPz3Q==; s=purelymail3; d=spwhitton.name; v=1; bh=LWDzxHk+4Tr+u0K1hnNbCuoW33pOxgCikIcWeAraDFM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=XIxfZHKtgp3CTuEIPIfMgbjNHgOgo/P4sUdn6fse82iWiVMNu8YcvIQZZ7UJHM0dteFZMEdkI/rOdFjeFTFatD3X8iCNpufkrQcUPNH1rLzyQHUxKVfkc/cxXBLgVMAbrUc+PBDdQJln/UyYQ8dda9g9ZPeHfD/qBB4cZs53ci8aAlK92M90mMENocAgP/q8XJIVRQoGx2TZNQe6LbteFJWNZi5CtOjD4rythIhCPpsEF8pSLIr/B5jWItoMsUhWUOCvAtyCmvuTxWVsLm3nFfMmsF0toX6xJsjQ2yorAxRS72/PiyzylFhLaVcMXO1QaIyD/25uxAXTKyLvVCQiHw==; s=purelymail3; d=purelymail.com; v=1; bh=LWDzxHk+4Tr+u0K1hnNbCuoW33pOxgCikIcWeAraDFM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1100480370; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 13 Jul 2025 11:12:21 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 0A302941B6F; Sun, 13 Jul 2025 12:12:20 +0100 (BST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <86sej0cypw.fsf@gnu.org> References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> <86sej0cypw.fsf@gnu.org> Date: Sun, 13 Jul 2025 12:12:20 +0100 Message-ID: <87a5589wff.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: stephen.berman@gmx.net, 78987@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sun 13 Jul 2025 at 10:54am +03, Eli Zaretskii wrote: >> Cc: 78987@debbugs.gnu.org >> From: Juri Linkov >> Date: Sun, 13 Jul 2025 09:58:59 +0300 >> >> > (defun dired-vc-deduce-fileset >> > (&optional state-model-only-files not-state-changing) >> > - (let ((backend (vc-responsible-backend default-directory)) >> > - (files (dired-get-marked-files nil nil nil nil t))) >> > + (let* ((files (dired-get-marked-files nil nil nil nil t)) >> > + (backend (or (vc-responsible-backend default-directory t) >> > + (vc-backend-for-registration (car files))))) >> >> The original recipe still fails with the same error. >> Shouldn't 'vc-responsible-backend' be wrapped with >> 'ignore-errors' in 'dired-vc-deduce-fileset'? > > There's no need for ignore-errors; instead, vc-responsible-backend > should be called with the second argument NO-ERROR non-nil. > > The original patch did precisely that, so it looks like some snafu > when applying the patch; now fixed. Oh, my fault. Thank you for the fix. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 13 12:53:19 2025 Received: (at 78987) by debbugs.gnu.org; 13 Jul 2025 16:53:19 +0000 Received: from localhost ([127.0.0.1]:54887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uazx0-0003mw-Ic for submit@debbugs.gnu.org; Sun, 13 Jul 2025 12:53:18 -0400 Received: from mout-y-111.mailbox.org ([91.198.250.236]:54602) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uazwy-0003mP-4Z for 78987@debbugs.gnu.org; Sun, 13 Jul 2025 12:53:17 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4bgBN40WZfz9xxQ; Sun, 13 Jul 2025 18:53:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1752425588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UhZsxndQQwZ+rw26dSKmhvWz8/G79r70D2KpbIUzygA=; b=SSFpY/Q1w9wSnNPBh7szZVq4Rg+vJH0dzyflrpFCLT6IRFgQlISE9DmdndZUKB0TUIMkzt 6xAi6yAlSQU72o413E+LKvuI3WBE+GOT4FRATW7UKX1TOMpn8/+guQn75gZG1TCBCZAOzh uFVZNWh3Flltv+h0hG4jR/rsL2q2/4vwB6nTzEqvy4cj+mFWB7VOLHPB83lzhULgVKDsRe ZSF2NpN42EVFCPFutjoYX3HczERyXLZbqaYSKMr8s7naE57rMM3BU5RQS+CcTb1g4WQfPG Y66bhx72KWIj0B8ARsqb9hvY+JWVu6NFAl6YuzSNbGrjppHH7gYAdq9MkV37fg== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of juri@linkov.net designates 2001:67c:2050:b231:465::102 as permitted sender) smtp.mailfrom=juri@linkov.net From: Juri Linkov To: Sean Whitton Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87a5589wff.fsf@zephyr.silentflame.com> Organization: LINKOV.NET References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> <86sej0cypw.fsf@gnu.org> <87a5589wff.fsf@zephyr.silentflame.com> Date: Sun, 13 Jul 2025 19:51:25 +0300 Message-ID: <87qzykkp9u.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bgBN40WZfz9xxQ X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78987 Cc: Eli Zaretskii , stephen.berman@gmx.net, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The first 'C-x v v' works now. Then I tried the second 'C-x v v' on the new file, but it fails because I customized 'log-edit-hook' and added 'log-edit-maybe-show-diff' to it: Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- file") signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- file")) error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code -p HEAD -- file") vc-do-command("*vc-diff*" 1 "git" ("/tmp/dir/file") "--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--") vc-git-command("*vc-diff*" 1 ("/tmp/dir/file") "diff-index" "--exit-code" "-p" "HEAD" nil "--") vc-git-diff(("/tmp/dir/file") nil nil "*vc-diff*" nil) vc-call-backend(Git diff ("/tmp/dir/file") nil nil "*vc-diff*" nil) vc-diff-internal(nil (Git ("/tmp/dir/file")) nil nil nil) vc-diff(nil not-essential (Git ("/tmp/dir/file"))) log-edit-diff-fileset() log-edit-maybe-show-diff() log-edit(vc-finish-logentry t ... vc-log-edit(("/tmp/dir/file") ... vc-start-logentry(("/tmp/dir/file") nil nil ... vc-checkin(("/tmp/dir/file") Git nil nil nil nil nil) vc-next-action(nil) dired-vc-next-action(nil) funcall-interactively(dired-vc-next-action nil) command-execute(dired-vc-next-action) Do you have an idea how to handle an empty repository on the first commit? Or this needs a separate bug report? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 15 05:29:52 2025 Received: (at 78987) by debbugs.gnu.org; 15 Jul 2025 09:29:52 +0000 Received: from localhost ([127.0.0.1]:40116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubbyy-0005Ww-3w for submit@debbugs.gnu.org; Tue, 15 Jul 2025 05:29:52 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:32806) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubbyt-0005WS-MR for 78987@debbugs.gnu.org; Tue, 15 Jul 2025 05:29:49 -0400 DKIM-Signature: a=rsa-sha256; b=FEQblXiS7gUGGTLGRalzoG1dYFZcr7fpFQ2/LpjtdOY5tt5Of4BcUatVZJSaKrobiL+AoDplHeJ439qjU8lGvrsWnwPc+Kl9a9/FPdKM4omShJ5dWM0PDV0WZXKThjz4tt+lLZQ+3eFR5BRDqe76EvfAw02F+6MSaww+a6jfyx+9Se6bGpMbmBXxwy9PRrS5d4h63hLQY/vLGz6WeMzw2zZ5nxxFzio0rCwDZQ5UnuagmZ3WnjxeWLfwoi2b7w9o69B0Q/Ydhm8+FzPiLeeIEX+9A2jwTzDB3Ux3kMMy5Yyd2b1g0BXf7unbQqSuREQ8z2IIpBAIFbBoXBtbYSGeGQ==; s=purelymail3; d=spwhitton.name; v=1; bh=wharhiEK6uR6PiLoqmwjzUD1Z6tx9J5B5Gr2pzfp+Fs=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=Aw0n4bAWDV3QcgjcX/fKk54ySneFS+2mScqGVy1fW+upILZqDOkbQoQPyssb9araNNOsRZGUMiL1nt9TmjdYrZCkMQP9ujJozQqUG610ktUCs8JWuZLiqEBIYYX/XKXcwGJJAbDxuu9FZqsaeWeBd+ZJQ/0qQLtrdrAHNzCq+IxE255sb35C4YIoPbsqwBkVM2livrtmuKMob2v85MNyUGBZ6DS0GAq4/ayU5FFl4L++Gc53lWkUSKJnaM2Zv64Scr5KWsKKBdUJoalFjCj/qKGj8jNBrm7MnmO31UEKR1oCvOviwufIF8KR7vdt88ycgsHjvji7KqCIuRWHIk4zUg==; s=purelymail3; d=purelymail.com; v=1; bh=wharhiEK6uR6PiLoqmwjzUD1Z6tx9J5B5Gr2pzfp+Fs=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -692087351; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 15 Jul 2025 09:29:40 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 4352F941B63; Tue, 15 Jul 2025 10:29:40 +0100 (BST) From: Sean Whitton To: Juri Linkov Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87qzykkp9u.fsf@mail.linkov.net> References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> <86sej0cypw.fsf@gnu.org> <87a5589wff.fsf@zephyr.silentflame.com> <87qzykkp9u.fsf@mail.linkov.net> Date: Tue, 15 Jul 2025 10:29:40 +0100 Message-ID: <87o6tl6buj.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: Eli Zaretskii , stephen.berman@gmx.net, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sun 13 Jul 2025 at 07:51pm +03, Juri Linkov wrote: > The first 'C-x v v' works now. Then I tried the second 'C-x v v' > on the new file, but it fails because I customized > 'log-edit-hook' and added 'log-edit-maybe-show-diff' to it: > > Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager > diff-index --exit-code -p HEAD -- file") > signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p > HEAD -- file")) > error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code > -p HEAD -- file") > vc-do-command("*vc-diff*" 1 "git" ("/tmp/dir/file") "--no-pager" > "diff-index" "--exit-code" "-p" "HEAD" nil "--") > vc-git-command("*vc-diff*" 1 ("/tmp/dir/file") "diff-index" "--exit-code" > "-p" "HEAD" nil "--") > vc-git-diff(("/tmp/dir/file") nil nil "*vc-diff*" nil) > vc-call-backend(Git diff ("/tmp/dir/file") nil nil "*vc-diff*" nil) > vc-diff-internal(nil (Git ("/tmp/dir/file")) nil nil nil) > vc-diff(nil not-essential (Git ("/tmp/dir/file"))) > log-edit-diff-fileset() > log-edit-maybe-show-diff() > log-edit(vc-finish-logentry t ... > vc-log-edit(("/tmp/dir/file") ... > vc-start-logentry(("/tmp/dir/file") nil nil ... > vc-checkin(("/tmp/dir/file") Git nil nil nil nil nil) > vc-next-action(nil) > dired-vc-next-action(nil) > funcall-interactively(dired-vc-next-action nil) > command-execute(dired-vc-next-action) > > Do you have an idea how to handle an empty repository on the first commit? > Or this needs a separate bug report? I think this is a bug in vc-git-diff. Does this fix it: --8<---------------cut here---------------start------------->8--- diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 13696a7a929..afcea8bdda6 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1818,7 +1818,10 @@ vc-git-diff ;; Diffing against the empty tree. (unless rev1 (setq rev1 "4b825dc642cb6eb9a060e54bf8d69288fbee4904")) (setq command "diff-index") - (unless rev1 (setq rev1 "HEAD"))) + (unless rev1 + (setq rev1 (if (vc-git--empty-db-p) + "4b825dc642cb6eb9a060e54bf8d69288fbee4904" + "HEAD")))) (if vc-git-diff-switches (apply #'vc-git-command (or buffer "*vc-diff*") (if async 'async 1) --8<---------------cut here---------------end--------------->8--- -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 15 08:29:31 2025 Received: (at 78987) by debbugs.gnu.org; 15 Jul 2025 12:29:31 +0000 Received: from localhost ([127.0.0.1]:40864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubemp-000396-Bi for submit@debbugs.gnu.org; Tue, 15 Jul 2025 08:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40572) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubemg-000386-H0 for 78987@debbugs.gnu.org; Tue, 15 Jul 2025 08:29:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubemY-000050-Pc; Tue, 15 Jul 2025 08:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zwrHhfFOgnhRJQS1WAm/EyqsV014JRYLC8v8OUVF8WY=; b=FvI0E6csxtDC sQWn5rjZnjqDjwcCjPowlB4TCz5rP9GMbt5mvt5Rn8r3sriv0Iwt2A0nT8cmdc9v+fXHQywE3Zox8 sAv40ILc9tzGKubOpBOf7EHdMS3pcP854Ugo4eZcr6oLMLgtYIoyKXNIRxINCZFTovaZ9hROkSb5q urq/lXZONvgyO8JUSu/hnvwY0qSyvUFxMoQONEfHD6WUoQ58W/Ds9R5OM0chWa5b+N7FXfi+/XAfk PpbtKuKqdI14ZE+UUQY7YtNMx3niKoWyw0OvZH2uwIe2N+dRSGzTkVzJ8i+Jkhv2Ew3yc5whAtZZg LsyLEgLpyC7MUrRxbGwnbw==; Date: Tue, 15 Jul 2025 15:29:10 +0300 Message-Id: <86jz49k57t.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87o6tl6buj.fsf@zephyr.silentflame.com> (message from Sean Whitton on Tue, 15 Jul 2025 10:29:40 +0100) Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> <86sej0cypw.fsf@gnu.org> <87a5589wff.fsf@zephyr.silentflame.com> <87qzykkp9u.fsf@mail.linkov.net> <87o6tl6buj.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78987 Cc: stephen.berman@gmx.net, 78987@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: Eli Zaretskii , stephen.berman@gmx.net, > 78987@debbugs.gnu.org > Date: Tue, 15 Jul 2025 10:29:40 +0100 > > > Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager > > diff-index --exit-code -p HEAD -- file") > > signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p > > HEAD -- file")) > > error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code > > -p HEAD -- file") > > vc-do-command("*vc-diff*" 1 "git" ("/tmp/dir/file") "--no-pager" > > "diff-index" "--exit-code" "-p" "HEAD" nil "--") > > vc-git-command("*vc-diff*" 1 ("/tmp/dir/file") "diff-index" "--exit-code" > > "-p" "HEAD" nil "--") > > vc-git-diff(("/tmp/dir/file") nil nil "*vc-diff*" nil) > > vc-call-backend(Git diff ("/tmp/dir/file") nil nil "*vc-diff*" nil) > > vc-diff-internal(nil (Git ("/tmp/dir/file")) nil nil nil) > > vc-diff(nil not-essential (Git ("/tmp/dir/file"))) > > log-edit-diff-fileset() > > log-edit-maybe-show-diff() > > log-edit(vc-finish-logentry t ... > > vc-log-edit(("/tmp/dir/file") ... > > vc-start-logentry(("/tmp/dir/file") nil nil ... > > vc-checkin(("/tmp/dir/file") Git nil nil nil nil nil) > > vc-next-action(nil) > > dired-vc-next-action(nil) > > funcall-interactively(dired-vc-next-action nil) > > command-execute(dired-vc-next-action) > > > > Do you have an idea how to handle an empty repository on the first commit? > > Or this needs a separate bug report? > > I think this is a bug in vc-git-diff. Does this fix it: > > --8<---------------cut here---------------start------------->8--- > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index 13696a7a929..afcea8bdda6 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1818,7 +1818,10 @@ vc-git-diff > ;; Diffing against the empty tree. > (unless rev1 (setq rev1 "4b825dc642cb6eb9a060e54bf8d69288fbee4904")) > (setq command "diff-index") > - (unless rev1 (setq rev1 "HEAD"))) > + (unless rev1 > + (setq rev1 (if (vc-git--empty-db-p) > + "4b825dc642cb6eb9a060e54bf8d69288fbee4904" > + "HEAD")))) > (if vc-git-diff-switches > (apply #'vc-git-command (or buffer "*vc-diff*") > (if async 'async 1) > --8<---------------cut here---------------end--------------->8--- Can we please have a comment there explaining the rationale for using this literal SHA1? And please make it a defconst instead of hard-coding it twice. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 15 08:55:35 2025 Received: (at 78987) by debbugs.gnu.org; 15 Jul 2025 12:55:35 +0000 Received: from localhost ([127.0.0.1]:40979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubfC2-0004ns-El for submit@debbugs.gnu.org; Tue, 15 Jul 2025 08:55:34 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:34110) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubfBt-0004nU-LM for 78987@debbugs.gnu.org; Tue, 15 Jul 2025 08:55:27 -0400 DKIM-Signature: a=rsa-sha256; b=DuzpVGYahb4gfUF0GZ9aQZgY/TOYIE0aEuZt0RXUEX/XOIzjGB8ihNP5ke0g5MjiDUXbdBpBgJNoKtsBXufa0cjfb/A0Un6vmHcAl0k25GikR30cKZPp3HUUU+HqBAXuycnddjcxY2BGy4qu6SZeYpMBB85X6FlRP4k/fGKGBd1aUopx0cxLtlvj0fyFgl0NV1x7XSpUKNTmE3JRUQrQ1RnJ4WlckN9M1cOlCkgOXuNEwGp2Ltw5f4eoHLATD9I0nAott4tEN57TnLSHd6QXClSbuplphBT+yRCvRt6McI2GYXNmVo+d2oAlLAoEF24Yfh2JVwVRaL9ex5mvr5XQeA==; s=purelymail3; d=spwhitton.name; v=1; bh=C0fU86Lygfo/VuaMHCRjYfArr0ciej7pV1rWaoxaeV8=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=cL14LPbgm4DY0T3UKSDshQf1thrpeu6T26XrNvrTIUXbjMNuqkwnvJs5M7VMb6PPRfYs4ehjkWFjvaxPY5OUUq1U5uUj4TEI2XPjgwVyZ2/5msskLFIUspjeXncfINRtQGmCJYzPHnBEGXUo1cXv4OAsZ2yFU1fEbZt541EHN/kvafuyam8IbiPHQ7VaDYdrfY09DZGsmXIi/EVvcOpenk3+rzr7ki7DN0ZqOSKyHbAca0KGF6ZgvbO7oMMFjzqaRzg+mCsCNj4++NIegAsMXP2Pt7X363VwETcET/HuveFUkkR2y83HhycAOZMSj1c26CXCePPbqlsq2t5yqkij3g==; s=purelymail3; d=purelymail.com; v=1; bh=C0fU86Lygfo/VuaMHCRjYfArr0ciej7pV1rWaoxaeV8=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 189799191; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 15 Jul 2025 12:55:19 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 7EB40941B63; Tue, 15 Jul 2025 13:55:18 +0100 (BST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <86jz49k57t.fsf@gnu.org> References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> <86sej0cypw.fsf@gnu.org> <87a5589wff.fsf@zephyr.silentflame.com> <87qzykkp9u.fsf@mail.linkov.net> <87o6tl6buj.fsf@zephyr.silentflame.com> <86jz49k57t.fsf@gnu.org> Date: Tue, 15 Jul 2025 13:55:18 +0100 Message-ID: <87ple14nrd.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: stephen.berman@gmx.net, 78987@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Tue 15 Jul 2025 at 03:29pm +03, Eli Zaretskii wrote: > Can we please have a comment there explaining the rationale for using > this literal SHA1? > > And please make it a defconst instead of hard-coding it twice. Yes, both done locally, just wanted to get Juri to test the functional change. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 16 02:24:07 2025 Received: (at 78987) by debbugs.gnu.org; 16 Jul 2025 06:24:07 +0000 Received: from localhost ([127.0.0.1]:47491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubvYk-0003XK-Lz for submit@debbugs.gnu.org; Wed, 16 Jul 2025 02:24:06 -0400 Received: from mout-y-209.mailbox.org ([2001:67c:2050:103:465::209]:50442) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubvYi-0003WZ-4f for 78987@debbugs.gnu.org; Wed, 16 Jul 2025 02:24:05 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4bhmGh4tTQz9ysj; Wed, 16 Jul 2025 08:23:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1752647036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N4dfv74MD5d1ZiETRLc76udCK2m2kTD4DJ+gBp7kABg=; b=TQbLOod3uf4MNu/suJUveACLitNR4hY/BpMiLNY89XRk1XXrRR8T4Xk2d8Mmh1ZG+OYJ0K QLMEriuEvHg3+y7tc2cbrUu9+eW8sCZt37VUIGRrTXTw7rewlh4spNFbSx25J44RSBEUZ+ fSrJx4Fs6BAcrskqUmX5AL/VkRsS5IyAk4lDLxqUzD76hOtjvSBYgNrlynf/ttJx1YDtli 0ytp9qiUHIfLxieFDV6SO5zDIzD9QwWYDIL+VHkF8rU56rswPbcLPdm6DvieSCm3IR9E/l hsDdzkgCagYyIq3M2TtLWvcMQiDLNHwRcRPzPKm54/HyQuF84tiYweBpjProCA== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of juri@linkov.net designates 2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=juri@linkov.net From: Juri Linkov To: Sean Whitton Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87o6tl6buj.fsf@zephyr.silentflame.com> Organization: LINKOV.NET References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> <86sej0cypw.fsf@gnu.org> <87a5589wff.fsf@zephyr.silentflame.com> <87qzykkp9u.fsf@mail.linkov.net> <87o6tl6buj.fsf@zephyr.silentflame.com> Date: Wed, 16 Jul 2025 09:20:01 +0300 Message-ID: <87ple08ycy.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bhmGh4tTQz9ysj X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78987 Cc: Eli Zaretskii , stephen.berman@gmx.net, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Do you have an idea how to handle an empty repository on the first commit? >> Or this needs a separate bug report? > > I think this is a bug in vc-git-diff. Does this fix it: > > @@ -1818,7 +1818,10 @@ vc-git-diff > - (unless rev1 (setq rev1 "HEAD"))) > + (unless rev1 > + (setq rev1 (if (vc-git--empty-db-p) > + "4b825dc642cb6eb9a060e54bf8d69288fbee4904" > + "HEAD")))) Thanks, I confirm it's fixed not only for the reported case, but generally for all uses of vc-diff in an empty repository. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 16 04:56:43 2025 Received: (at 78987) by debbugs.gnu.org; 16 Jul 2025 08:56:43 +0000 Received: from localhost ([127.0.0.1]:48002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ubxwQ-0007aQ-UO for submit@debbugs.gnu.org; Wed, 16 Jul 2025 04:56:43 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:59844) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ubxwM-0007Zs-1P for 78987@debbugs.gnu.org; Wed, 16 Jul 2025 04:56:39 -0400 DKIM-Signature: a=rsa-sha256; b=qa9K0UbrtqngSCmy9ukAlZILnmN1wvDY9b9kcBZepBREbOPlbjSe9aTf1oYL6ZywS41U/wScKrqWcKgRQv3oz7gn6fxhBRGpcWKv4HrTxZzx2tg2VRdxZvCNyAWwR7t6NcuZmgL3pMJ7TyRyIB+8K2yypeR1cCrdlxpiE4JQS6iwW4YnVlagSZw21RPn4TEM9T1JYGewbD1hJI/MaqNU7UoSmigE0ZJd++ZPGx5SvEbjRvNeQfydzwSzRTUCoSF1pnW7qLALuTFTEEUnaTJY7tz5eGq+lKDJhHoyPOkFUDaU33nqeiIHSahDbXeqtgJcFcBX+SvvF8Ms1JvCvWi4EA==; s=purelymail1; d=spwhitton.name; v=1; bh=30/ueHQ9/oFJqhiuRWWguz9rDnNn+SEOSL0XUVMbf8E=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=sdpHerc+u/QNpuhLII8n5ZqEnuK9lTqWYhnyYOruIG6cEFCM9YM6dQxtkmoqoeVBqV9ZeeNGZnStjXRqn4fhYj7QgbRwok88inrnza62Z4kkjhZuXEBeVLrbSCA2X0vPAWAlFdPaO6+yZ6THdcLcRkoyUPLe8CQOqPZbqEJJD9bmC+gQi+6crqSQom0+NKTx44peqDBjqW0cFXZ93FaAIry54MUQ4HKRq4SNrfNFaYcV7XEZEtw1ZO7Q8w+vuzP8yzMWZWh1yKeOBe0ZoFH4Wmq1DzNMiPuYy0+nlUgCNpojnjGkezpyw+jbEcPdAJ1DHwT1gr25tullR4vvrWFnww==; s=purelymail1; d=purelymail.com; v=1; bh=30/ueHQ9/oFJqhiuRWWguz9rDnNn+SEOSL0XUVMbf8E=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 78987@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1573171353; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 16 Jul 2025 08:56:31 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id B51879405C0; Wed, 16 Jul 2025 09:56:29 +0100 (BST) From: Sean Whitton To: Juri Linkov Subject: Re: bug#78987: 30.1; Unable to create new Git repository in Dired mode In-Reply-To: <87ple08ycy.fsf@mail.linkov.net> References: <87h5zkanwx.fsf@gmx.net> <87h5zgmuhc.fsf@mail.linkov.net> <86sej0cypw.fsf@gnu.org> <87a5589wff.fsf@zephyr.silentflame.com> <87qzykkp9u.fsf@mail.linkov.net> <87o6tl6buj.fsf@zephyr.silentflame.com> <87ple08ycy.fsf@mail.linkov.net> Date: Wed, 16 Jul 2025 09:56:29 +0100 Message-ID: <87ikjs345e.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78987 Cc: Eli Zaretskii , stephen.berman@gmx.net, 78987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Thank you for testing. Installed the fix. -- Sean Whitton From unknown Sat Sep 13 07:22:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Aug 2025 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator