Subject: bug#78960: VPATH build fails

From: Bruno Haible <[email-masked]>
Date: Sat, 05 Jul 2025 16:54:20 +0200

Pádraig Brady wrote:
> I pushed the following which passes both types of builds here.
> Marking this as done.
> 
> cheers,
> Padraig
> 
> diff --git a/src/local.mk b/src/local.mk
> index 537032578..fb763c4db 100644
> --- a/src/local.mk
> +++ b/src/local.mk
> @@ -708,7 +708,7 @@ src/version.h: Makefile
>   # -PD: MSVC (usable with a wrapper such as cccl from the SWIG project)
>   getmacopts = -dM -xdumpmacros -qshowmacros -PD
> 
> -CLEANFILES += src/speedlist.h
> +BUILT_SOURCES += src/speedlist.h
>   src/speedlist.h: src/termios.c lib/config.h src/speedgen
>          $(AM_V_GEN)rm -f $@
>          $(AM_V_at)${MKDIR_P} src
> @@ -718,8 +718,6 @@ src/speedlist.h: src/termios.c lib/config.h src/speedgen
>          $(AM_V_at)chmod a-w $@t
>          $(AM_V_at)mv $@t $@
> 
> -src/stty.c: src/speedlist.h
> -
>   # Generates a list of macro invocations like:
>   #   SINGLE_BINARY_PROGRAM(program_name_str, main_name)
>   # once for each program list on $(single_binary_progs). Note that
> 

That's better. But now, "make distcheck" fails in a different way,
namely in dist-check.mk line 127:

...
rm -f Makefile
make[3]: Leaving directory '/home/runner/work/ci-check/ci-check/coreutils/tests/torture/coreutils/test/coreutils-2025-07-05'
(cd /home/runner/work/ci-check/ci-check/coreutils/tests/torture/coreutils/test && mv coreutils-2025-07-05 coreutils-2025-07-05.old	\
  && ${TAR-tar} -Jxf - ) < coreutils-2025-07-05.tar.xz
find /home/runner/work/ci-check/ci-check/coreutils/tests/torture/coreutils/test/coreutils-2025-07-05.old /home/runner/work/ci-check/ci-check/coreutils/tests/torture/coreutils/test/coreutils-2025-07-05 -name .deps | xargs -r rmdir
diff -ur /home/runner/work/ci-check/ci-check/coreutils/tests/torture/coreutils/test/coreutils-2025-07-05.old /home/runner/work/ci-check/ci-check/coreutils/tests/torture/coreutils/test/coreutils-2025-07-05
Only in /home/runner/work/ci-check/ci-check/coreutils/tests/torture/coreutils/test/coreutils-2025-07-05.old/src: speedlist.h
make[2]: *** [dist-check.mk:116: my-distcheck] Error 1
make[2]: Leaving directory '/home/runner/work/ci-check/ci-check/coreutils'
make[1]: *** [Makefile:25823: distcheck-hook] Error 2
make[1]: Leaving directory '/home/runner/work/ci-check/ci-check/coreutils'
make: *** [Makefile:23735: distcheck] Error 1

Bruno