From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 15:15:16 2025 Received: (at submit) by debbugs.gnu.org; 4 Jul 2025 19:15:17 +0000 Received: from localhost ([127.0.0.1]:35198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXlsR-00058u-Nf for submit@debbugs.gnu.org; Fri, 04 Jul 2025 15:15:16 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58986) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXlsM-00057w-CC for submit@debbugs.gnu.org; Fri, 04 Jul 2025 15:15:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXlsF-0006ck-SA for bug-gnu-emacs@gnu.org; Fri, 04 Jul 2025 15:15:03 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXlsB-0007jd-SC for bug-gnu-emacs@gnu.org; Fri, 04 Jul 2025 15:15:03 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=sXK0sa/R bxG4fiHzxmql4nMo9A73TvKh2UbyZBA56do=; h=date:subject:to:from; d=ledu-giraud.fr; b=5oYpe5hFmz6gDaSHTuzJ0Q95ljpEAxcmwqRFwg73b8ewUXyVWJ pGW/paOwM/fjIujwo3Uth2yd2hwWSp2e1GBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=sXK0sa/RbxG4fiHz xmql4nMo9A73TvKh2UbyZBA56do=; h=date:subject:to:from; d=ledu-giraud.fr; b=02yzYvkdIxYgQyBW/lDioWcKbrp43V4ZIbnzgZqYNo7qHFux68 oJcn/p7CfZMbF8VaubA4hrc/ez0y7Bw040Mr+HmAwdhQlMtTRkH6ckkReBEVlcKg6EzsXJ X/xcndtMzNOu2/dxbSfFruQGbOBMd5u0Oc8miPplV+2ST7tz6zjGwQ9ozsmNkrhILW2twQ r3aDZ2tpIgXvS0kDdPgdrQ+5+iF3Wh7k0zcKVT5EkW249PWEfs1/brX2X6Rz1dG8fp4VNa CNeQ+1Asat8h2IAvwnBKwcRfT6k49HMlTPjoeNXqxa+/cxhPEEobvxEk66MkrfTKR4Gzwj VGXDO27Dyfqw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 83b0df65 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 4 Jul 2025 21:14:53 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Wrong mode-line in fancy diary X-Debbugs-Cc: Date: Fri, 04 Jul 2025 21:14:52 +0200 Message-ID: <87ms9jojir.fsf@ledu-giraud.fr> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.218, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi, When viewing diary entry from the calendar, the mode line could be set erroneously. The recipe: - Have a file "/tmp/diary" with the following content: --8<---------------cut here---------------start------------->8--- July 4, 2025 A bitter day for many --8<---------------cut here---------------end--------------->8--- - emacs -Q - M-: (setopt diary-file "/tmp/diary") - M-: (toggle-frame-fullscreen) - M-: (calendar) - g d - 2025 - July - 4 - d Observe that the date in the mode line of the diary view buffer is not centered and maybe partly out of sight. This seems to come from the fact that the call to `window-edges' in `calendar-set-mode-line' does not return correct values but I can't figure out why. In GNU Emacs 31.0.50 (build 14, x86_64-unknown-openbsd7.7) of 2025-07-04 built on computer Repository revision: 763c3cd081a833940961373a73705640b1808636 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101018 System Description: OpenBSD computer 7.7 GENERIC.MP#41 amd64 Configured using: 'configure CC=egcc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --with-toolkit-scroll-bars=no --without-cairo --without-dbus --without-gconf --without-gsettings --without-compress-install' Configured features: FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XFT XIM XINERAMA XINPUT2 XPM XRANDR ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: VC dir Minor modes in effect: vc-dir-git-mode: t display-time-mode: t display-battery-mode: t desktop-save-mode: t exwm-randr-mode: t server-mode: t electric-pair-mode: t override-global-mode: t repeat-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/prog/elisp/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm /home/manuel/prog/elisp/exwm/exwm-xsettings hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-xsettings /home/manuel/prog/elisp/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-xim /home/manuel/prog/elisp/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-workspace /home/manuel/prog/elisp/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-randr /home/manuel/prog/elisp/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-manage /home/manuel/prog/elisp/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-layout /home/manuel/prog/elisp/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-input /home/manuel/prog/elisp/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-floating /home/manuel/prog/elisp/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-systemtray /home/manuel/prog/elisp/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-core /home/manuel/prog/elisp/exwm/exwm-background hides /home/manuel/.emacs.d/elpa/exwm-0.34/exwm-background /home/manuel/.emacs.d/elpa/ef-themes-1.10.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/31.0.50/lisp/theme-loaddefs /home/manuel/.emacs.d/elpa/idlwave-6.5.1/idlwave hides /home/manuel/emacs/share/emacs/31.0.50/lisp/obsolete/idlwave /home/manuel/.emacs.d/elpa/idlwave-6.5.1/idlw-toolbar hides /home/manuel/emacs/share/emacs/31.0.50/lisp/obsolete/idlw-toolbar /home/manuel/.emacs.d/elpa/idlwave-6.5.1/idlw-shell hides /home/manuel/emacs/share/emacs/31.0.50/lisp/obsolete/idlw-shell /home/manuel/.emacs.d/elpa/idlwave-6.5.1/idlw-help hides /home/manuel/emacs/share/emacs/31.0.50/lisp/obsolete/idlw-help /home/manuel/.emacs.d/elpa/idlwave-6.5.1/idlw-complete-structtag hides /home/manuel/emacs/share/emacs/31.0.50/lisp/obsolete/idlw-complete-structtag Features: (shadow sort mail-extr emacsbug lisp-mnt macrostep-c cmacexp macrostep doc-view filenotify jka-compr image-mode exif flyspell ispell tex-mode compile shell pcomplete comint ansi-osc ansi-color vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view log-edit add-log pcvs-util eww vtable mule-util url-queue mm-url gnus-dired vc-dir ewoc vc vc-git diff-mode track-changes files-x vc-dispatcher debbugs-browse bug-reference texinfo texinfo-loaddefs format-spec time battery desktop frameset exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-themes modus-operandi-tinted-theme modus-themes zone speed-type thingatpt url-http url-auth url-gw nsm compat ytdious ring mpdired transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win ebdb-message message yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils mailheader ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base timezone icalendar gnus nnheader gnus-util text-property-search time-date range sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils erlang-start idlwave idlwave-menus idlw-menus idlwave-bindings idlw-bindings idlwave-routine idlw-routine idlwave-scan idlw-scan idlwave-help idlw-help idlwave-complete idlw-complete idlwave-variables idlw-variables skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs elec-pair appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs pcase dired-x dired-aux dired dired-loaddefs edmacro kmacro use-package-bind-key bind-key use-package-core repeat easy-mmode cus-edit pp cus-start cus-load wid-edit debbugs-autoloads ebdb-autoloads cl-extra help-mode ef-themes-autoloads elpher-autoloads exwm-autoloads gnuplot-autoloads hyperbole-autoloads kotl-autoloads hact set hhist idlwave-autoloads notmuch-autoloads osm-autoloads pdf-tools-autoloads reddigg-autoloads ht-autoloads dash-autoloads promise-autoloads rust-mode-autoloads info slime-autoloads warnings macrostep-autoloads speed-type-autoloads sudo-edit-autoloads svg-clock-autoloads tablist-autoloads transmission-autoloads xelb-autoloads ytdious-autoloads package browse-url xdg url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue lcms2 dynamic-setting font-render-setting xinput2 x multi-tty move-toolbar make-network-process tty-child-frames emacs) Memory information: ((conses 16 571884 484905) (symbols 48 41392 2) (strings 32 195972 20036) (string-bytes 1 4840619) (vectors 16 113028) (vector-slots 8 915611 43230) (floats 8 490 804) (intervals 56 3510 0) (buffers 1064 36)) -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 18:20:45 2025 Received: (at 78957) by debbugs.gnu.org; 4 Jul 2025 22:20:45 +0000 Received: from localhost ([127.0.0.1]:36587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXolx-0006qO-3B for submit@debbugs.gnu.org; Fri, 04 Jul 2025 18:20:45 -0400 Received: from mout.gmx.net ([212.227.17.21]:48331) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXolt-0006pP-Ox for 78957@debbugs.gnu.org; Fri, 04 Jul 2025 18:20:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1751667634; x=1752272434; i=stephen.berman@gmx.net; bh=Oq+rXcOAQOruITVgp92RGaolKHfTTzMsPmhZb5KU/HU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Os/hoeTTG0Z3NaTowcS6XUM/A/+V8BNnIfPcpTZXM83wKTGmrHN3DTLOfd1WNjWD SumK2Em3h2FMEprFkz8T6Ic6bRb7m8qquOvSS2jMWOB65AUYOIDX5369NGC+MhAQG 4HKEIZ4yNB4+0CH4Bb9ET4zTXZYEDXCEDm25Oocq9zr5kSwWqyt95+60BR0dGNpP1 mZRuIea3UiPsNrEeNKBqD+xeUTPU6cBWTuO/RbELngj4YNYbjAnWqJQ98l3p05/dI IyGoFg9wMCSzDha4axgrC0bltRj7YVVl9HuG2tMeBGha6DxylcpILUTR2we1faSl3 oO2SHoHad0uveHGvvQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.48.209]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M42nY-1uXolm1W2C-00BfHI; Sat, 05 Jul 2025 00:20:34 +0200 From: Stephen Berman To: Manuel Giraud Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <87ms9jojir.fsf@ledu-giraud.fr> References: <87ms9jojir.fsf@ledu-giraud.fr> Date: Sat, 05 Jul 2025 00:20:32 +0200 Message-ID: <8734bbha33.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:fHtJRBjSf9QYEWDHv+OrHibCEtu5AJcY6B8/zQq++sSmVX9H2M9 Bc0NJjTTQMRoL7s6bhaYiRteAtWHU76to5Sfb2INgkgprWeV1L9vH7Fo5XP9++7z8hVcIxq iSadwZtRTv7Q4VNUIPbvkqeLiXl+cFK8gU2k1LSFt2eKaJNK1x24+I317vrOsrsUL0o/pFW GYYVOVqVUVb7P3S40EjIg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:1vC9g6ya6wY=;Ae5TLwdZZGqH0I6xKkB8sWz+mJV 5IRCA4H5Ld2XaciKD5CvJ+q+SLPZVLx2kN9eNW7WtvgOotDiR/226GDpkRvHg9d8nfbN3KdXK IvUvkwnooL370q5wueOQqCsG5MZOGeszjAhrhC6/zGTk9kXTsiuNq8FaTD9i5Os3wRpG1o9Yi nRWt5bufdnbEHiuZt5n38NFtGqofk2Byr/ef0NVOv7XfVwhYqxoSzhGEl4/xnxY54A0SD3yHa e//67EWcpzuLzvMLrL7+ZDNpAMVAFCemZf0deP83zifjwdde2r2buHXvJq2m4GFN9HyzeU6cv dVSOxN8iSofwgCKoMNevXfAwXNJ5LQx2YsF8PcJKktFnPAUCTJ4V2jCUiG+9ljUw2UlrVGARm 74LAacRt1IIYfPeJo6S9KaCiziEQMYbFuMRm12XCj5P61x+gaVSeLH23MHfvnvHAWP/8mJ6O6 qMdCODW43irRrjSVbew7QqylI3txp/ShxJiep/97DkP0Zd3IpstzzAKEAB06Oygh0KZsv8JCx XL+7E9fxnRVyrpzdySSWuS3Q9MQNdlYG4SH505CTxEVwlBYu+dKC/97phyLrM4LR2oiN1XjnM b3oAGWg6BWAFbRp+9UMj7BFkELZT4XDkv8O2fria/whBQhULbBt+HPknaUaQ2HunQorXOfnxu QT6IfB0dlkJ/6EEYAba1POx45/GIUGY4mF4aN1TB9Kc8hf6BW8HtlEw++TLTeiVDd/rc2LfZa DeGrfDVikCu6fhDdnNNXY48prQ4gOwfP7zDQxlqWH7ndJfP9AbavrHPQeDGNUjY8gCjVcI8eD vJNB9JIh8G6Z5gOuqmHvlBZqFC+T1RsYaQoUst8uQGcOllaj565/ISy2xYt/XdYh4ZBFLcxdw j42HUBdPm4JoM4N0SMlhmmDB0840HILNeIqkGbY8Vp00oWhrmIW1KB3VYBlNFcL8PNAOqp6pn 5WQc+4qVq7gC7pSb/spRmFmz2rtXOtaMRDw9i5FDs8zB+2lVTSLYqW8qhQRQCO69Nkkq17Db2 TEqLr5aUs314o29JkCBrwYfSYo5SsCi2/hYAxjRIjpT7bgDrQirzRI4FJLxb1JIJZKIxxwOWA pCrUARK2qOQSWMXZiHz+/RoxHubUpzvzy8nXYCT/X9BVPzUP/ShTU35XEY89kBT01mwf8yPw0 4ggMZzYkhZyQ6RrglHu4mD7xy/mlG71bz25XY/jkF/ZD2JWbzk8XCqIo3Mo4xErHn0ILpk43R SpEgIuDfkMI/tytzUZNsJy3ZO2GRSxXSFLHmXxjscWniB5P7yZTqVIKwg2C7qU/n7Bp+kekKl BDhj22Hoa/n6EhMKgPNKJmfnSJqP4nKboXwfk6+pOSx/w0ixXcbo+u2mc63ffLhKovo5AVmB0 C+Yqu0qmfeXoneVAbWWjUv0zfkZgD5Cjf73Y3yFDq1aQOTlMtUj/CCWChMjwkateGyWwSg8+6 FDgJi5qZ3spjeQ3sVin0v4tzFbjbHAs8TROGsPiH/ZDpF/gfiGwakO21c1a/44YDIWVqE3HX0 bMKLOckqTubwRUjPlLNUdmUjbHgxvbl158Tl1kAtvJojw+C/7//UGOjFbrlYk2CHjW47bghhp oLNgFbldiqpi/4F0YkOBey0fYkLdEi6PCuTXy6+exByn1894nJvplu/nPDkU21fSW7amGC1xF OkEmMYNhL6ob5f62tpXfin6tl3suTPuGxNS5v12QvAXZpCVXEDS+g98oZLKXbMVXvFfhcLRR5 avm8EusyCJEqoh5KwEsi4zU6IkFiiNItv04pUzn/WTL7HaZu5oASTvaKBYAA75xY1B02kPqFS H1a3gIh0HVooAmkthuZHnBQxgkUdQPirMNIlZbovZ4WeATOs/NpB9T0Cf7MOUTvHsx8JbbxQ1 gv4ZMwFBSDKVCWZ241VSz18Zh0MM8J+lj7i7RHAqtpDH+OWfOKqGt+PkcvKeJFnEeU8+SVy61 6rEQvDrupAMQYSZ9Ac9t1G9cN40SzGIOxt5nN1/w3j71C3MGokF0Y05v1eKt/KJzneCJvyvQH mN2Z+uyBrW6CpP6T8rZDX8i9BZ/BZ6z/mGV0aev5cxIW6Rt3aR/RPWTuZCDLNY+uufpREnlGY MsuwW6zvSw6EiIlfFWNp0E6IxTDA9mh86oNtugQQJJbUcBPWcVhio8SAm8i8zV00kANvAk78K Xs5nvV4vp+5kH+f3kkDV8IaEs0Cyw8SYOHVD8xqBPC3+9RUPw4JFxeiWFs/ve0+YmR3t9L/42 p+FH+fE/PHnOCV03jZ/nnXXVyfYKVj0u2M8pVoDcu344U2QNtfml3W2T+r04pP8kz6ORFa4FS jHi5AEakDzeU/f7BTHAF/XOoYewU1mcctwDPbF3KM/aXvwKGxlo8Rt5VkDLhG0hfAt/e+Olui /pI4m+VXlljP3OmHmhTwqGMBTe2fV2KqgAale56nR/S6RnsGgoRABXkwu6BM3nXMutXQGL/fe vTOoA0m+EcYZBLaKhBRxwCpG1bjZJe1xKPCGm8J8m1ANg36znA/T0xI3ENdkxsNlJ3/QbSiU/ cr8JQHdZFUCMyNc4v0YgEnFV8VKG7Syz1hUJUNx+3jILtDUiZ5OqFy2AXJX4NU/cEeUtkrb50 lCqvnxv0dk2KywYCfGbzRMkfFrDiBt7mMoZ4TFAERAUF6X6bsKMN9k9vqjIemMSY1EZ5/fKB4 WZsCeN45vwjK8B/2oQ/NbfFi4tbX74qUAMd1hLnr6oelFAmpbCmCpAXS954PnX5aUATxDfxp4 UYe+2lJUlkk5Vsvci/wVs7iFaW0avxGEKhObmSxi2gfJAl4JboKD0Szhm40ePgKlqaRcSGJSb grmvMpN7RPWvU9PCdcwYdHexxsZ4kdlU90hnmgsTiVe+5SAPPzr4aOZ03bg2pA1oDThssj6FP AQHLTc2O/4c+UdIRxa7LxGWMCRj7KBbt3KGjZzIygKTot6twX6j2Ua8b1oLsTlDvkdSZPncZx 2z6e3odtYbdUffw9feghEx+unD4kqykN7WnX1gP+4+xvB1jM2oc0uPYTRccYVjBeTLhYCvlGg 9N4+0vkGtkB8ZHbX3jP9N9cjDaJi6kuka/z3fBF+kCazXN9EklnUaTYOOr6Htm9Qi30lGNCrx qG1jKgQ4u0vY02GEbILCwlTiyk53p3NlZsLmk517kNewu7iu9gY//Fb3d0iJfbAo1R+UV4a2H M+SueukDBHJ7gtEyLRd3lthD3amz1NRMLgoSCwvCDiRNPZxwHuwvn13Hblwf6DGUSCb++OynX utY3/0c4AShaCLgx3PBSpnKGN5cjYx3yXS5oShvJ3ISapm/8r9vNpfrKbTDwmLrj/tpYf3Rmy em0bbU8n3Wz5Dli0thLotYiPStzg2rJnnc/TqcLBBPJgViMMMq0mLPEb4Y8o3Cdp2g5iSafOH 2l/6sQH/UPRa4dIbzsspMxtUgXA5mjJLObkUWvVxRQraRk0uSDXdZa2qU8B2oixn8AZd+bTi3 Z2yiZ+7TePg== X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78957 Cc: 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) --=-=-= Content-Type: text/plain On Fri, 04 Jul 2025 21:14:52 +0200 Manuel Giraud wrote: > Hi, > > When viewing diary entry from the calendar, the mode line could be set > erroneously. The recipe: > > - Have a file "/tmp/diary" with the following content: > > July 4, 2025 A bitter day for many > > - emacs -Q > - M-: (setopt diary-file "/tmp/diary") > - M-: (toggle-frame-fullscreen) > - M-: (calendar) > - g d > - 2025 > - July > - 4 > - d > > Observe that the date in the mode line of the diary view buffer is not > centered and maybe partly out of sight. This seems to come from the > fact that the call to `window-edges' in `calendar-set-mode-line' does > not return correct values but I can't figure out why. I think it's because both times `window-edges' is called in `diary-fancy-display' the selected window is the one displaying the Calendar, whose `window-width' is the full screen width due to `toggle-frame-fullscreen', while the window displaying the Fancy Diary is half as wide. The following patch seems to fix the problem for me: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: diary-fancy-display patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el index 8fb6fadfe4c..3b0275d4cee 100644 =2D-- a/lisp/calendar/diary-lib.el +++ b/lisp/calendar/diary-lib.el @@ -1058,7 +1058,8 @@ diary-fancy-display (unless (car (diary-display-no-entries)) ; no entries ;; Prepare the fancy diary buffer. (calendar-in-read-only-buffer diary-fancy-buffer - (calendar-set-mode-line "Diary Entries") + (with-selected-window (get-buffer-window diary-fancy-buffer) + (calendar-set-mode-line "Diary Entries")) (let ((holiday-list-last-month 1) (holiday-list-last-year 1) (date (list 0 0 0)) @@ -1139,7 +1140,8 @@ diary-fancy-display (if (eq major-mode 'diary-fancy-display-mode) (run-hooks 'diary-fancy-display-mode-hook) (diary-fancy-display-mode)) - (calendar-set-mode-line diary--date-string)))) + (with-selected-window (get-buffer-window diary-fancy-buffer) + (calendar-set-mode-line diary--date-string))))) =20 ;; FIXME modernize? (defun diary-print-entries () --=-=-= Content-Type: text/plain Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 04:53:20 2025 Received: (at 78957) by debbugs.gnu.org; 5 Jul 2025 08:53:20 +0000 Received: from localhost ([127.0.0.1]:40043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXye8-0005Vj-6i for submit@debbugs.gnu.org; Sat, 05 Jul 2025 04:53:20 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:27741) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXye4-0005Uy-Q6 for 78957@debbugs.gnu.org; Sat, 05 Jul 2025 04:53:18 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=spsyAfaz P3Nsq6vdat/5uvOuZ7zbg+ugh/4JOCF9nNk=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=+E67zF2AD6w1seOt0GtYFuF6QCNNnN F/ik8wDRN1z5BYnppWbJJGppgDF0lKWJZXRzzwM3QcTK5j2zCzitHxDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=spsyAfazP3Nsq6vd at/5uvOuZ7zbg+ugh/4JOCF9nNk=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=tS7S1NwjLEQ3PsICKFxtpGsw2n5gt3cU3HrwP5 X4AI5UPOOr2ucI5TX8uxnLgXW0eusQyPhWk1f0MZMFJ3QnF73ShdcwTblq+6+SIRypDj/K szkk0Mjah+fe8Bl+zeZRDDHmrSG8eCOIjYBXQyIejvS4LPCWf+UKMQnNAJR/Ylz/mA57Z9 3lZPG1fxrIxbQ7BDZA5OYIrOUw/wxGGAhIcVUGGqn+IBP46f0e2bCYK4uYtJ9CWL3kkmYu 23C8Mk5ajn7qUq2cJFDKTet6RSytYoW1CvouFuTAGDkrp/bgk0dVJYbqoHRcWhTF3knAID MCLBPb4OYvl/NbdBSpGOhbpw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 415c4cad (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Jul 2025 10:53:14 +0200 (CEST) From: Manuel Giraud To: Stephen Berman Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <8734bbha33.fsf@gmx.net> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> Date: Sat, 05 Jul 2025 10:53:11 +0200 Message-ID: <87ikk7nhmw.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 78957 Cc: 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Stephen Berman writes: > On Fri, 04 Jul 2025 21:14:52 +0200 Manuel Giraud wrote: > >> Hi, >> >> When viewing diary entry from the calendar, the mode line could be set >> erroneously. The recipe: >> >> - Have a file "/tmp/diary" with the following content: >> >> July 4, 2025 A bitter day for many >> >> - emacs -Q >> - M-: (setopt diary-file "/tmp/diary") >> - M-: (toggle-frame-fullscreen) >> - M-: (calendar) >> - g d >> - 2025 >> - July >> - 4 >> - d >> >> Observe that the date in the mode line of the diary view buffer is not >> centered and maybe partly out of sight. This seems to come from the >> fact that the call to `window-edges' in `calendar-set-mode-line' does >> not return correct values but I can't figure out why. > > I think it's because both times `window-edges' is called in > `diary-fancy-display' the selected window is the one displaying the > Calendar, whose `window-width' is the full screen width due to > `toggle-frame-fullscreen', while the window displaying the Fancy Diary > is half as wide. The following patch seems to fix the problem for me: > > diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el > index 8fb6fadfe4c..3b0275d4cee 100644 > --- a/lisp/calendar/diary-lib.el > +++ b/lisp/calendar/diary-lib.el > @@ -1058,7 +1058,8 @@ diary-fancy-display > (unless (car (diary-display-no-entries)) ; no entries > ;; Prepare the fancy diary buffer. > (calendar-in-read-only-buffer diary-fancy-buffer > - (calendar-set-mode-line "Diary Entries") > + (with-selected-window (get-buffer-window diary-fancy-buffer) > + (calendar-set-mode-line "Diary Entries")) > (let ((holiday-list-last-month 1) > (holiday-list-last-year 1) > (date (list 0 0 0)) > @@ -1139,7 +1140,8 @@ diary-fancy-display > (if (eq major-mode 'diary-fancy-display-mode) > (run-hooks 'diary-fancy-display-mode-hook) > (diary-fancy-display-mode)) > - (calendar-set-mode-line diary--date-string)))) > + (with-selected-window (get-buffer-window diary-fancy-buffer) > + (calendar-set-mode-line diary--date-string))))) Thanks! That works as expected. I thought that the set-buffer (from calendar-in-read-only-buffer) was enough but apparently not. While here, I will complete your patch for other calls of calendar-set-mode-line (lunar phases,...) -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 06:03:08 2025 Received: (at 78957) by debbugs.gnu.org; 5 Jul 2025 10:03:09 +0000 Received: from localhost ([127.0.0.1]:40927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXzjd-0007r5-0d for submit@debbugs.gnu.org; Sat, 05 Jul 2025 06:03:07 -0400 Received: from mout.gmx.net ([212.227.15.18]:60507) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXzjY-0007pE-OO for 78957@debbugs.gnu.org; Sat, 05 Jul 2025 06:03:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1751709774; x=1752314574; i=stephen.berman@gmx.net; bh=NfLq1c3KxYOF3wWtSqGrZq9RB9taA2QcgcTDqQDnGSo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=PissgUlgQzzJj401S9bevIF/HwL4k7w/DL5dML/AShkrMWH0qPJ83oxCBFOTuASW Pr92TwYGF37BnJV1cRf576bW2EwyY84w5HBb57IG+5Dtev5oI5ot2+6mkw7lAMrsn 4bGzEIqdQF3qZitJ1fqlx9A6t74gQrgr3XM1721xB3CZA8dicCRR3rEe7rLoKgdtr vOxwMq9a9mFtI4Br80Tc465c+fmKG5hY5XrM2JhKQnRNeObHqoj07yz8bqKjJ6c9C swPHx0+jjEJYYNrEX0pCqSVfuKJJlBXdc2O5z3dYLNAsazEFT72RiCUWN6LYrccS+ Bkb7/HoevMfaFmm0Ig== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.218]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mj8qd-1vConY2yqT-00hiU9; Sat, 05 Jul 2025 12:02:53 +0200 From: Stephen Berman To: Manuel Giraud Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <87ikk7nhmw.fsf@ledu-giraud.fr> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> Date: Sat, 05 Jul 2025 12:02:52 +0200 Message-ID: <87qzyvvttf.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:70kiE9zHupMunAjTHfCYb9soTy0rTkAWNxPOMUqB0pZllidva+z 0G32vgSABQ4e1Xj3ju/WWlZXsDKzha3adK25eVmcZCfhGlMQ2RgCO9yVptWQBzlMOHqHKR6 maoQpkaIRuporFtvefOqbqZraG/KDrix39esBOIH8swRDB+YFzuHCRINOg8GsZmvGoMMJCr ffFOMrtvVlDgzhsKs1AzQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4vIhgX9Vtfc=;sDIV74cUnut/Mg9X0/aNgEM204q /m93EBKxQlr0MKpP+RFzYDg58mGnQuDOfs27jyeR06aECZdybq6sT2/5mjy2Kms/D4NvVILOA 4D77N/uF7oVa/QTOkXY6N/smUBM6HUH4EBlBzL8Zvkd+7hRTSA1hZ2t5xtGku5v9FXuXES6B8 TkgRgAhobA2nxQyHJfJ5wpU6gZGYqpeFTyXrvBXuSBkiylXtsZ5S0IrN/PCoBzabfz1Y9jRfM Ptb186Eel8q4xxnCfQorearVCJ95cy3nVckQnvYCOfQLYQNIWZJzsP1s1nUnu40G9HRQ9YQzO jCEdwu7rU+QvtdSIKgf+9JOj4+FEmKlMq2XNWx2sDDTk2oPeyXRRp1d556sl/DGqTRsqgPPsq PLp0tnL1b6N+Xg8NqqPbVBp3ZmJpELK7HxkNUZE321oz7kJVcY+6wDL5IU9ybo5za3ZIRlLZQ ooTHYu0cLqCGtrJp4TeuIk0n8mR+aimgK0aKCtUKCmKQZoytWTCUstzKwmmzA+fulDXBKhKDt PTbVyd8+ryvjd0Wy/HWM0StB5F3weveIi3g1sJgeGwnwTlbDo+Zw0UqmJsf82wuiD5WygdTK9 r2wOdeTOaMDcnBCD6D8pNztJ+2onp42cdSMBH5RroLeuNkGqnoYjO1Bs7Xvspd+SNkByae5o4 NEoNHwptWm0lLG86egtuoyIf0ujLaPbw69k4aFVRiAeXubnKoz8PiC7yq8Nm6Uy571Ti3TX5K WqOJP5ZTacGJxpLCayedKxWYTZPOIlUQtfOqxiI9PDer6HeKQgUNpeXbJmDNjlu7ChFXaasl1 maP2XHgIzstwypLJBLJD8UhRF8NEAmJm2PelQB0+TgHdin0fl5V1IJhNH6AQy8Ewvkn3SwFh+ 0nhafCnnJv0moserhKyzxCkBg26OWp3sRfjMCaRLYXretaOLJk1wZ5uaXX1BZuXvZTb9EVF4/ Hc07iyZbYa5boCfetnlZ+ExTjo8z2PA5Dna5NTPLPXTxQTHLkjHDh5q+3+OQ77tU4zmSjebz+ Qa7BdE7ZR09ivo9dS28X0K6+Tg5o6kwxhEbLyoM95YFBrjpkDOwLC2f/5h7RMCcYxDjvKSa+A WZfi8u8eauO1Wpqal8Xb2DD2z7YEdJwTGeKKkTjlZ4fDkZoY7UZuv535yRaIEMFCvI+FMSbNq R1qVwq7wXNYeH9pi1kaVCwhx8oh1+xxFtuY5r/xxMfA3zc8I1MAdB7hDsrXDX5HU5+ly+LcmJ AZOiO93Pz45KdU/6Hb+TqQUrBoKkctqxBbzAYdzoEsbJRFMjY62yEHv8pmF2YaUpsjA7ArbUl bCyzeKCIoLLi5fHwMXGpBiXXvD5HDX2K7ejv+4zUcylkmFSRRGvX4+l2qhGDz9Bw1a7uk8sNB Emln0ggZ5/zZ99zO4s6NuG3fkYwxX7W5HiCkS9+RngeQC+8LYV7AkraYUIcC9zk1n3YjEDRA7 c5ho87M4JubjkLhuQ8LKtBkiX/MS7lS8VLs+OMHfHM/VjgOwNrPGCgNBxIioKcJodzqo1LYzE zHjnYaPLaB0M/v0kjeOq9b8CiK984om/AGn5G5Bq98Brn7iN7J2WLu50X7sJwGPE7DTjU8Nfc 1mjH0Gi+n3AsCVHrnSC21Pej7k1+me/GczC+x5aQEsoboVD0PvS1PLXMnXOmj/slb+SAV0Lh0 a8PRPtvrlQ51xgNzOG5W89k2Xrr4rIpkIARIpept9ll+YDPUlCaIozh0b9zr3r6rsQ8Q2oazP edEAWQ3DPdfsdWw419TCh/5AMwz6ixKPAsDaCuO4RmzZTBAVLO1ndCKtstuciOMo1cfxdZUuw gdv5qlJ6+yqqRAq3ikuFR06H/CXYm9S6X+uflSBsaIFNR5MtJq0XQij1WvREW28Qqg5s02drQ G5dE3L0a4waIWeZZO/UtNbjSQWMcX9TM7a743eg19YuoCS3sJf7ffwZBxkeBJ3+8OC6fgOyFq mgVqyrmKUhM4s38G73TAnM0xmlvu5B0u7B2v7O1rx0Ndb6cSvmcXiOZgiXSvNIuxdwiDbXezm bnrEQZS4M9euraV2X6tQqka/7h7PsUMKMcHLgTf7jokxPMtZ5g/SXs+xJAIMFW/JPRTYfrXnf LzOzT/z47EI8OFb5URy0Z/QICDbIAW4fAddgHIDzJ7QM+TxNUzmgrCSsLe4I2PZn6MrhSU3cv uZJD8pgrHm4JiLY1Eq4NSa+lqVDAVR25n+RBs/ARLMgbh9kNzxO5T6xqMGAehgCOkp+NSF6Op bmIRFhLY87WLoY05CQaPz4KmY18gZ8qC8Cyzhj/gXc7ZEh92WBzcRll32JqEQJS0LXSMtvRUs 7GSVTBpjXWaTLVrlMIKzLr1pj9mqBrKXeoWOjuQt7tvnV7MlNmUr6k/Vq9F/Ro6H2cvlsHS7j huodpjLKy+5wZOp5FbNvHUkmi5EhHNXoov00nn2NbKqukYUNkjDJnSWnv4xW2iQY0F3nvvyjQ CVtP+hVLZ3elQo8wkI9mTseQ5hLiXvZBwdx56bHUBrJ8j2ZjeXAyHp33h1bm33oJ+rLBwntLo H2xstUSJExys6eAxRYkPUdlIhmCY1hJqF+BbLQw0OckjhrZ6Jq/DUAZT60XQlY2jxXMlO6oa1 TTyEjHFqhZWtfBFhiAaTK0Y4RzjlpxPrHh/eqYssD13hQRfApX7ldafXfrgXv2413aqluZ6Vw MFU5b8rX/rzYCMIvBnjxXYmknk0rIg2oIyQ3+xWM11KeEhND+zO1Qc50mipyQXicaUkFs3WZn /6a5byUhwF/dj6xhD1Gb42bYQI1WUPk5a9mRXv3kp2pGjRwUA+JYPJgsltAl+bmLv20CGDQCI jQOqryuSlj6nJTM9UeTWg+v/l5EKOy0XjFY0a0c4FJM1AJiV57KU6insadsoxVRuwD1jIzkC9 bdGyf8GpZD+/6iCahSOeKXbuFYcmZA7tnc61bbZAQru1zxBr9EKedi98Jz9BvEoyLEu2ibraO /FvcM+JIA5EBudk62gGOMYccSpnloCRugu5crLJPCcIBCqBhktpRMz0EX7hWJBETZVkdEpBwf t6bYtxOGPMfufuVqkkQMyQQr3Sl8F6S06ICtbSUuGUSokOsXtEGTaIwExL1VYXNXJO8cxEHAv 5fjz8pKLv56jyYbQ88Q9nEWdE94NLYYhEDItnbph2Ag8Wmpi7zBFSgQrOCCRrIqMTGcOir1S2 Gt98/xn5vdD4zJW1Cq/PygxnJNM8q4l1plaRxUaWOh1JecbsMRItHB8UHXXThawgHs/6JcUgQ fpUXBggDf6AX0hhdE4yz7qfeXgeJ7Z0v731/xyOC5Gm78N7H/KiXzlPmwg2d32gyo8ujxc7MR lV6zhCWRKURvW/Ec34lR9p8a7eF0ZRVIV2prRpBRsPN8Z6ienXpi3AnCc7euUv0ruN+3AaPAc ZRafoDaIR3RiSiJh6SSk3F1WqrzBUB+Q46VmB8eFGlljo5FMXusHCuHrRvHVIurxVkIPkSZsv Z+iP8x9ScwhVB1vsf+Y6ixel/hSjSBBQ= X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78957 Cc: 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) --=-=-= Content-Type: text/plain On Sat, 05 Jul 2025 10:53:11 +0200 Manuel Giraud wrote: > Stephen Berman writes: > >> On Fri, 04 Jul 2025 21:14:52 +0200 Manuel Giraud wrote: >> >>> Hi, >>> >>> When viewing diary entry from the calendar, the mode line could be set >>> erroneously. The recipe: >>> >>> - Have a file "/tmp/diary" with the following content: >>> >>> July 4, 2025 A bitter day for many >>> >>> - emacs -Q >>> - M-: (setopt diary-file "/tmp/diary") >>> - M-: (toggle-frame-fullscreen) >>> - M-: (calendar) >>> - g d >>> - 2025 >>> - July >>> - 4 >>> - d >>> >>> Observe that the date in the mode line of the diary view buffer is not >>> centered and maybe partly out of sight. This seems to come from the >>> fact that the call to `window-edges' in `calendar-set-mode-line' does >>> not return correct values but I can't figure out why. >> >> I think it's because both times `window-edges' is called in >> `diary-fancy-display' the selected window is the one displaying the >> Calendar, whose `window-width' is the full screen width due to >> `toggle-frame-fullscreen', while the window displaying the Fancy Diary >> is half as wide. The following patch seems to fix the problem for me: >> >> diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el >> index 8fb6fadfe4c..3b0275d4cee 100644 >> --- a/lisp/calendar/diary-lib.el >> +++ b/lisp/calendar/diary-lib.el >> @@ -1058,7 +1058,8 @@ diary-fancy-display >> (unless (car (diary-display-no-entries)) ; no entries >> ;; Prepare the fancy diary buffer. >> (calendar-in-read-only-buffer diary-fancy-buffer >> - (calendar-set-mode-line "Diary Entries") >> + (with-selected-window (get-buffer-window diary-fancy-buffer) >> + (calendar-set-mode-line "Diary Entries")) >> (let ((holiday-list-last-month 1) >> (holiday-list-last-year 1) >> (date (list 0 0 0)) >> @@ -1139,7 +1140,8 @@ diary-fancy-display >> (if (eq major-mode 'diary-fancy-display-mode) >> (run-hooks 'diary-fancy-display-mode-hook) >> (diary-fancy-display-mode)) >> - (calendar-set-mode-line diary--date-string)))) >> + (with-selected-window (get-buffer-window diary-fancy-buffer) >> + (calendar-set-mode-line diary--date-string))))) > > Thanks! That works as expected. I thought that the set-buffer (from > calendar-in-read-only-buffer) was enough but apparently not. > > While here, I will complete your patch for other calls of > calendar-set-mode-line (lunar phases,...) I hope you haven't spent time on that yet, because it occurred to me that the following patch might suffice: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: calendar-in-read-only-buffer patch diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index 917624c489e..6b23cbcd1d4 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -1167,7 +1167,7 @@ calendar-in-read-only-buffer (setq buffer-read-only nil buffer-undo-list t) (erase-buffer) - (display-buffer ,buffer) + (select-window (display-buffer ,buffer)) ,@body (goto-char (point-min)) (set-buffer-modified-p nil) --=-=-= Content-Type: text/plain It seems to DTRT for all users of `calendar-in-read-only-buffer' (after byte-compiling), if I haven't overlooked anything. Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 06:19:50 2025 Received: (at 78957) by debbugs.gnu.org; 5 Jul 2025 10:19:50 +0000 Received: from localhost ([127.0.0.1]:41072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXzzp-0001zq-9x for submit@debbugs.gnu.org; Sat, 05 Jul 2025 06:19:50 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:28955) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXzzl-0001z4-FQ for 78957@debbugs.gnu.org; Sat, 05 Jul 2025 06:19:47 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=KeVj6z7f D4w6DTQpZ8upzD81l+bCqCHo13R69F39LlY=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=dOO2EFWc5alz97mAdvNxiDXeKl26Ju FFSfv850Q30DElgLyaHhuzyyWbRvKK/fQSjIHutn3tCofAop/g7H68DA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=KeVj6z7fD4w6DTQp Z8upzD81l+bCqCHo13R69F39LlY=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=1Y5Qt8ZhrKg5MzGay+f92SeDq4YmBTnWj/OTlD G4ot1RNhOMDrBRL6cKtwBKQJbTJ+vOZJ5OJ9Xi6zitv2ygis9v3zyXoXd76AVvCYQC6Kuw QT6xNn4i9cFFI8g61tETNA/HwUjt4vHLlIwvrmSblpfNHKqcWFO15qgULYkoVzE5v4MHIT 0ufGbBgcqNlZxAQeNA7aIxxMNP6MM18MYDrYH1VnQKTzBqQ47Cq9rOu0ufpXI5pTdomNf8 bKgJXzepfUoHCqP0syREnhaNVDowkVEznSykMbppJxfVB54ShvgkfUZLjHucdupIDooED1 WIHn82EM6YKm7yld7N6rghSg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 2f49e5f3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Jul 2025 12:19:43 +0200 (CEST) From: Manuel Giraud To: Stephen Berman Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <87qzyvvttf.fsf@gmx.net> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> Date: Sat, 05 Jul 2025 12:19:40 +0200 Message-ID: <87ecuvndmr.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 78957 Cc: 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Stephen Berman writes: [...] > I hope you haven't spent time on that yet, because it occurred to me > that the following patch might suffice: :-D I did not spend to much time but, in the mean time, came up with this one: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-mode-line-string-width-in-diary-view.patch >From 5b1b04936e5d31197ea5129fb7e56e28f0aa24ad Mon Sep 17 00:00:00 2001 From: Stephen Berman Date: Sat, 5 Jul 2025 10:56:00 +0200 Subject: [PATCH] Fix mode-line string width in diary view * lisp/calendar/calendar.el (calendar-in-read-only-buffer): Select the buffer window because, for example, `calendar-set-mode-line' needs it. --- lisp/calendar/calendar.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index 917624c489e..8b7aa71db93 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -1168,8 +1168,9 @@ calendar-in-read-only-buffer buffer-undo-list t) (erase-buffer) (display-buffer ,buffer) - ,@body - (goto-char (point-min)) + (with-selected-window (get-buffer-window ,buffer) + ,@body + (goto-char (point-min))) (set-buffer-modified-p nil) (setq buffer-read-only t))) -- 2.49.0 --=-=-= Content-Type: text/plain But, I prefer yours. Do you mind if I complete your patch with my log entry? -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 06:23:32 2025 Received: (at 78957) by debbugs.gnu.org; 5 Jul 2025 10:23:32 +0000 Received: from localhost ([127.0.0.1]:41118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uY03Q-0002bV-9R for submit@debbugs.gnu.org; Sat, 05 Jul 2025 06:23:32 -0400 Received: from mout.gmx.net ([212.227.15.18]:43905) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uY03N-0002a4-5K for 78957@debbugs.gnu.org; Sat, 05 Jul 2025 06:23:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1751711002; x=1752315802; i=stephen.berman@gmx.net; bh=h4LDIRhFzj5TwQ9L53bEyi9OtD3kU/NLnkKynef3xEE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=alr7p0wxUua3Qf12pFLsVvdIy7vbFmdxW/90UfXBVASoZ6OKKHSpjjs0Cy2pP/63 oPJhnZ9P0ImVASbgSQLyYm0PMmae6MuIHJSoH7Q1nikjdDJZbkSn98FBh6i6WoJro TCOwH+soB3Y0MkUDXXsdPNxwgtvIcnnrneGTlybPHTF/CdtQrUcBGF+pJaddg8fEu QKApwOJwIAh6pT8YS/6RneRSII8sH1TUUqPA8gmWD6qvHDFon41/fhqNWTRNc4rY5 Esl1sOhLL3520NT+Gv7rjMVqH9H4nu1B9qRSFJnoDFRJBggLhE+wCuOTYnu+cb+eN 6sLMlvexn1tGhwdO2g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.218]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mkpf3-1uxwLl0GMR-00jKsd; Sat, 05 Jul 2025 12:23:22 +0200 From: Stephen Berman To: Manuel Giraud Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <87ecuvndmr.fsf@ledu-giraud.fr> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> Date: Sat, 05 Jul 2025 12:23:21 +0200 Message-ID: <87ms9jvsva.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:chG9sWxa+vjUQ/jdcq+drNNRQyBm30+XXd5iVfqk4JWrkifH2kH kPLl4huleX7cxQuopXmYLp8RCrl5c2jRq7MFrwr0MJY46glzQvu/vo0IN0tknC5xcLqoRkW hRHw9gk5dsBi7AR2XeiSaRLpbSqa1eyVKprZ9Y3gdmz/KfHwhTgBHUtbgO87QeJc8wzYB4n qq8wiuuslFgExPaiLCy3A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Eihgv55ZwN0=;XusFkH2phlJv6ThKXGHu/PuwNQT sEmCHD1XhMZ0YO4Izxax/nIVnqpHgbr8xv1RvARw05I1VlclNdmocw5/qom7vQK67IhpmXAA+ A+9NSKwVKHZMvF1e+PU/xRbUWRCI+XZ6aIye75eU9oSDmeT4XSfflA71q66nwLUHXXEiFLtXE Fytta061N0cRjIyPGoorSKnYqcmWUfy6znkTiUzNK+xIKfcLU1e9nNeHOrUQ83ptpxhGK2Yq3 wI9M9/w6h2d1Gn34jilDnLMzobY21pmQIHs8Fx7Dtxfe39WVq3s3bAZQ3segOqlG+Qs2lmoi9 bDAr9MJJxIOFNyGpN/L2JIX0XRrBjWZVJmIXVVNl6LIa7b7vv0Flv7mQdDV/yB6Toc3gKzNzP 3RM3uY/izbhmRpQ4+6CF1jpi5c15rKS22lpKdirxy83FpulEIbuPQahn0IVNnVzXiVLDMCJmh puTzkE5pMg+PXhTApj0iFQGotZ48D0jIfyINp139sx14cnwAawZW6HyP7Z19KxWdpTarIbBi6 09Ssx9VoEQdUwKkB7KPg2wVVB9njnbNKT0lqnwl32vKVqllPFkWbzLh+2I8jqHSeX2FpW+kYg Gufqb6RFfwGwx8dDgmnae59d5wrQq4jtyEGjrRCMVnZIs7tx3y7BQ7KgBsdeWX+IVbbtlO7tw n5G1IfAyLQAv7tGL/S3wB4zxVlnjOE6irQkDsfsm1WV1bcOT725CHGZJ9s7IHsHZy+dXXT/sV wKFUNWTPKsUowERWEPFmge5b1JuaDFA4zR9Er4x7fkl4/+yQBY5RMHLPqK8hpv7QwCSSux5DA RtDaeamCEVqmMzgisEWjihmPB6ZsWXlyzkMiXbArYsPf45c3ajqbj2wKEXqwuSQmarodbp3LN d/W4UmQfeadeh91dFU+j430ZvAJ0JHt5lvREc57z1h2fIsZGgMwAfZb+x/B5e8NMJqUhivhaU fKuWyAevGzDCz5kEI6ydZq6w3hRSVHHkCiSsNzcbp2RolBoU8ZMKQ9cB6P7Rsv84IymV/q4jM N9vSSqHOxqCOJLyAzOZ8vzNTJuTDNvElr455Vmm81i9m7+ltP64orNf9t7VZDt+eLjpFNfTGO WrbFLuZGrVRNxZ6xOhmlYf/DCcdyTjSU9NaCHCcDTNBxgFKd4xtiVD8Dux0Fb7lpfa8nsTLvi nqijt0k9AfgMCNvxOthN6+bF8Uob1zOoyx8BNN3svunDiNMGI89u8M4IXCRCgafD698zK4LRF avnHx1Ow3rYhKS6dBKcUsPVtxWEOBtLTUNF2EFJXteOIWczRsN3IoekDapFU0J5z+06XP4cbP JG/ZrGq4mYlMjhVo3gxdBTNnBOZyM2gWp3yfWlE0qyG4u6rQHYiWUiqKLuJFUEw9JaOJ/dUYh QkGER2vixrrLCNaCuSfMdbh+14AhMv9S6XeaELoS6/iGEl2S3SmxWGH7OAvDFhHLRef16lUcK pI9vJmPrj71v+i2fhTt7NggfDUgzll1UA7B2LHymQhTpDqZBbmgLG1HfNjlUf2/c+boFbnu+v 7EKbfp29pE5XoblsQNHjRxr+pTdWfERq4OAzSXsAOZfRCiCjP7VKB9Bj3UsMEZrJDq+4vaqhm 9PL7CslzkxOJnpr7NRZtwdl6Koch/q8CsLOMsRhMNp6LoTs6x7IG5eNF3ye0vpCK+63UUNtyN luiRvhq0RZ4QUi66YIiRVhasALYp54eLGU7bEHWVmGiqIhs38EyHVN8l3li2cMtM55WDM1HsZ /5mp0RBZDhupL58K2DLsGg5av8Zuz0jCmMcz6G5ZI+KqG806IQaDXIQJXE5imvSH9IRVse3GS 7Fsbb1hTY1n7LGVb9IUMxudLk8viWwZkYkiM64mLR2mmqsK7utJzKc5jLxvnnwUmgppLSpFaA 1yIzFdrrYR5U7JalGqGpbjQgUun+iNMOy2Nzb3xjNyXkeoUg7wYx8htnfuUnck18eS9HCKnxs RbiC2IbKZMmTyKiGEnNt87WaWYy2Gp8WZTCXL5mKTL3WI28Voiw8FCjEmPe7ylOnWLwbG63Hc 8K8gFgWIw2N2wn+r52teGDYmY9Ke40s/MygYrLWgCYptD0lsw+aY1nrSlF6gyaL79ZeFNbJ7K uLWhj8LrRLKVfnYmqmHyg/Z6u4fKC+IB9EONduD3i4zIPoMN4f6l+v0dtgeqmRV/QCfGK7e2R Nmy9L9fLryXCejD7YB7dHRuv/1V+kwHlKdr74Bbppzw6+xUiU1N4ctGbG0qr3wqW9ypkKFgnZ YaU/vwvQdXDVTKcJF4ur0pDvNy6TjNw5AqDQW8k+9FgrOytLgJgDHUq76XWGkQ8SOezTRCjpq irlIdqthqDod0yAGcHcKMrEm8vpacX3WTnfUxpjWYKKIbXUhnx6vYxiPwYi+cESyM538yjjE+ hSiKosp36Yrt9Cnlxm1859HqUQ/sHGVMjKlhhTHmmtLM8T1V+a+gRJrhGFKP6eABdw5T4Hy91 M3puSy+xBE7kNdWaHrK5cpShEP9AJCRcpVZcDYEZ71AR2Me7+GjR5SUnIPFWDwKUOjwdA8eCO /QfGlEdWURaaRJwy8QjHGCBidzSceFVVBFItAIdNmNe6chCBGEgd7pz8SqEH9nnp+Yx3cr2er ffPqtHH8uVu9MuXGX26evRJ3qjW4hudAtW7y826tme+wwe6iHeGchHsEu8Iwh7YmRaAEd5LTl feWAAoLvppZkL1g2SUu2Nfz6B0YHX/y9GoFVaUbvWDUxoQaw33UQOCX4yic+2SF9WG1qig373 3jJQBfjTxAektdbU6mcMp9B7ChMhDQl6C/kcrl7blw+IX/IIS8LxDZ1q3HVe+TJLAugxXI2Nr 2jni2Jd2eQGI54dN72UG2I/PzYl3RgUDxoffg0wX3ULgfX5aH9Bkjz1Pi68XurEPIi4xi7uWs DZrxKRUycNFd+DcwvUnBGq+MXLmvYXxd93aejiGI0EwYrEjWKteBFjfo7cEyqxJGWD8lCLk1I Rssh5F7/GdX5L1pWU2XNVCkk6ySrRkbPER7WGITzmMfd+BlzNYW8u272adSYDQmbdwdQmkwYr KXVo5yV9Dbg11ALQdu7VIC7I+HFjlMT+9CXmweZLQ6dBSxz6AptETPC5/kVwVl9db8jY9VovB h0H8y/rvkPtoYAX5eZEtjpDw92SYNPD/6aQ2RpHC7gzLSLcTg7NQ4+zLcdQ+1Izo+J6HcggSc +rokdWTibMY4IawiywEYE8s82+cSoncB3BAFyYIUet6MLY0FOk7OYLywI9iTpxau2uFi43qnf OnzeiJk2k92nii5QA8lvUNNQNoJNdLo+yOxuMM4MlXzWRssrOD4wUhIghvum8NAGVowsr5K4J M0iD8A8qJVoRp1xwU4+PY1L17psjacGToEd4zaU30rWz/Wrt18XUoxpHNj4scoumnzBGBfQjA pB8PLSefqeYN0CMh6fAPCkf9MB4x3RU3L9fDKuUNo= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78957 Cc: 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) On Sat, 05 Jul 2025 12:19:40 +0200 Manuel Giraud w= rote: > Stephen Berman writes: > > [...] > >> I hope you haven't spent time on that yet, because it occurred to me >> that the following patch might suffice: > > :-D I did not spend to much time but, in the mean time, came up with > this one: > >>>From 5b1b04936e5d31197ea5129fb7e56e28f0aa24ad Mon Sep 17 00:00:00 2001 > From: Stephen Berman > Date: Sat, 5 Jul 2025 10:56:00 +0200 > Subject: [PATCH] Fix mode-line string width in diary view > > * lisp/calendar/calendar.el (calendar-in-read-only-buffer): > Select the buffer window because, for example, > `calendar-set-mode-line' needs it. > --- > lisp/calendar/calendar.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el > index 917624c489e..8b7aa71db93 100644 > --- a/lisp/calendar/calendar.el > +++ b/lisp/calendar/calendar.el > @@ -1168,8 +1168,9 @@ calendar-in-read-only-buffer > buffer-undo-list t) > (erase-buffer) > (display-buffer ,buffer) > - ,@body > - (goto-char (point-min)) > + (with-selected-window (get-buffer-window ,buffer) > + ,@body > + (goto-char (point-min))) > (set-buffer-modified-p nil) > (setq buffer-read-only t))) > =20 > --=20 > 2.49.0 > > > But, I prefer yours. Do you mind if I complete your patch with my log > entry? Be my guest :-) Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 06:30:56 2025 Received: (at 78957) by debbugs.gnu.org; 5 Jul 2025 10:30:56 +0000 Received: from localhost ([127.0.0.1]:41212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uY0Aa-0003o6-3q for submit@debbugs.gnu.org; Sat, 05 Jul 2025 06:30:56 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:3462) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uY0AW-0003nI-EY for 78957@debbugs.gnu.org; Sat, 05 Jul 2025 06:30:53 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=debJSwIP SIejazDOwawHExuP2fMOp0nTfVcFuYXBC9w=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=ORxEXRnBOxbxFcOXqdV/c2c7EJTXc2 XBx79cyrQVpF8JeHEcYEsglosUgp8Ekf30PWs27oI3H4w+Wgw/76BLDw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=debJSwIPSIejazDO wawHExuP2fMOp0nTfVcFuYXBC9w=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=c8gYzNxNMKIjKK7DsjhPr7zmCWefdv0bg3TJlJ Rwbi0Abxiurg9fBqlBX95fDgE1pULJb1+JUkzi0hVYt4HrfBUeKQkxcDC5aEOJdH/hbKvh PUQdtSRkHUXH1SLKoVkk23qtXB1z7tlYjd3wuCJKueVEKzALwQctbpyhpu32lfYp8p0PCB v7gLeHZd6wkn7NNJBf30cc2W18WsC2jm+nJiMpLaQclKrY1WXw1G63EHCNb5y9h+tDkWKX pcv0s7sAjnNRB/0szkHhkr6u98VK0+yAOEeWL1bIgpsi1Q1cDUYM9DcNb3a7WC4SAVpCes O5+lDpp38p0+g7kzkOa2Q2Lg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9637a25b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Jul 2025 12:30:50 +0200 (CEST) From: Manuel Giraud To: Stephen Berman Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <87ms9jvsva.fsf@gmx.net> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9jvsva.fsf@gmx.net> Date: Sat, 05 Jul 2025 12:30:39 +0200 Message-ID: <875xg7nd4g.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 78957 Cc: 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Stephen Berman writes: [...] >> But, I prefer yours. Do you mind if I complete your patch with my log >> entry? > > Be my guest :-) Sorry I spoke to quick. I think mine does the right thing, because it preserve the selected window as the calendar (as it used to be). WDYT? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 06:40:25 2025 Received: (at 78957) by debbugs.gnu.org; 5 Jul 2025 10:40:25 +0000 Received: from localhost ([127.0.0.1]:41350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uY0Jk-0005Gg-1X for submit@debbugs.gnu.org; Sat, 05 Jul 2025 06:40:25 -0400 Received: from mout.gmx.net ([212.227.15.18]:44395) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uY0Jg-0005BP-Py for 78957@debbugs.gnu.org; Sat, 05 Jul 2025 06:40:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1751712014; x=1752316814; i=stephen.berman@gmx.net; bh=UWVb5ZEA2QEdZuABj7+M3H4lUS2XkgurIDk8JPGPb2Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=bl3fuBxn1AOTHoG/4V8p0LQyrt3vv/8W8VMyWWspXWXDfd9S2aZLWgGw8Ie4Edtp D27uNeKGkiS7AWjKfFhtMDAys1xPLYzvdCH+rHYlJrg8ZXtGDC4JedwdK+TLWjGGL 85pnQ+wcT6XBNoi+By8So0V2mykmKwh84X/FmI8/8jKi2y6BRWoemwQKgLgtCPmFC vYQHiT/fBC6GKK+kidINCs3Wsd/fBQaPEzZM6JlG8FeEEzkpASS28DW9LIXUUXscq LFjnbF18xWkNiVFjrEypvyl3davyOjZQuPb9Q1+ZQdTDQWP31agBUJkALH8lYbNnb Jc8q00WuMPSt+DTlpg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.218]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MdvqW-1v8zpD3eX0-00cl1T; Sat, 05 Jul 2025 12:40:13 +0200 From: Stephen Berman To: Manuel Giraud Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <875xg7nd4g.fsf@ledu-giraud.fr> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9jvsva.fsf@gmx.net> <875xg7nd4g.fsf@ledu-giraud.fr> Date: Sat, 05 Jul 2025 12:40:13 +0200 Message-ID: <87ikk6x6nm.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Ej9HOK2pz58nIJWOgXuFJR0YAJ1kXVRwgEf/YZuu41vZN47oSzS tGaTQyaLC27bt1BCPCRE5+GDYOZYFuL3DTmxhhxwWqqi2gzulx517SPtuaMHtqSz+VfDPn3 fmI+CbtmFJ18nXJWee4FTh+k/oDmdVwrZZBvH+3PQKumU3RXiCLWtQE4sHRYI90HDW6kMga Xe/hTtoEOr9rROVyntr7g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9g4bswsDgyQ=;sD8Y4HSXwXxVa/lRlSG7WBBNTdc JAiZIevjuHTQbRNQKeHpT8VXenqLix8Az8QwEtuBZIE4IWSEMby8MCH8qqQRou0vK1XNz3y/q vVj4d/uSsBoTEYbR6WrsGBfxnUzy06EvIVZIWIgYhJPeYRHAnxdlSW1VDjkxrel2dketwfWb1 bXGdb4qAVTHT2dHFnEfmgZlFPd1Sp0vp4qV+C/3V0SyxA4OtQ/LhxhNfmUQu2aDnerujL+0X/ 2CYROFyv2LC9hmaqULbxHjyICXx3kx8vSLRgyQXY5I9tvlv12TLVu/351xIavsdSCQYCOmDuz NONiBT4G//iqM+YGX9h4IYiSUdftVKlQOgJ2ogDmMwJdyks/3pE1mPSa/mQBb9y5vfHDdhXP8 PGTusjPYCwIS+/Di0SC5/aXF081KbjmTxu/32+/vjakEwvvssf7EpvP6v/uYCkN4nXbZcWvND 04kEL9AK4/eoh41UBxDDWbNQkkRksBvbnM1j9+n+fDBe0LWlhiupBEAwOni/BGgFrvuJ9FWjg PNj2qnC1iE6fNt6lIRkDnoh2MX2CIlLUMlWZka5wNUcBpsusIJ0MAXl077VzRzU+BpbM7hEn+ OiuUcHPIiJZMjEK62abNKJmBkRKlN56MjTxuoaX4IiGjZOrTpbov/IIFDb6/J8D6M+2w7NPpz J/YlHkKhma9IRzUyWEgBhVki46lVfScDNIaz+u8n6pNX6tvC00q+3uqOSc974caX3A6sEc+t6 xHS1ScCQCDD/cBtpi1nSvxkuo1iI7Oz7ZYhVJPXoYUBYo/7YUL+VnJyozBdK8ie+SXSo5+qZd Y4kSBjJko1j0rlwuv3STK2z8gXBpJJeqRv0SJ4FCTLiu8qWM8bzNrjQbflLHcIRPkZcSxkhx/ OvrbIfV5M94cvScJarOEFpQS+54QGYl/Rk4NWFIHEJTGBodKlNH+9c22lrRlwXd62sxYafmTm FOFAlhR0qS8zKpr1wS8YYoLCs8Xv/ZYNlxRLd9sofzqNruwLsjAYw0C+Y9AauDJyuzuHbc7v8 7PZLfa9EU4IoxlhcyXU9FvRbR0wLNDDjiWkZD8ZBIV/io4bfWwCc1iVeUeeLjbUzneVBQSEEo MWwGts6Rk/oF0vGWh+g2aO7butFjM22pw0A32AyDRMEC8gN8+S9NaFef2Au9kkVrFdmv8xEqQ HBuQe7ODrhvp9/BZ8xR0TQCMnPKhpH9rWXvoDpHyamvtWVyw+ZplVXGDEsfFa9rXx8fWhptty FJQ6gEjGzWBPisbb4wrzVtq1GnJI78EbFtgrrW2u9Y2uV9yrOJIkpEz8HuAw/xXVM7yv5eYA4 XPrnxf1FnpNOSZeEvNGvyG5ua83mN87k5nOLbghYrwgPzN6e5a/YEza6lAIdP1rHj8gw1SUCs JFQI3a6UQ1osPGh323fy2g5fNCw37s25O9asICEDcoXiG0WOIBGgQShKyTQZ65GpLbcw5/q0t wxKC2CmkMu+pHJj1h23F44jWMPEnjZ1zdQcnBzWxipoM+1mgmNAC50uDKENrSeABLxB7hhmcp nX/g5KQYGdPqamYExHkNd1RIDQ+E9/eC+ioSFbicC0N+GutYd8LGEOFMdq31smVrVymNCP4HB SVbiURJ5He4zYda8VsRfKG7MvFyWjH0RshWGqgU7SQTAxez65cqvjElCBVcc5FdIjZduKVzQL W7a9CjkBCRL+3maRkrYARKXd4mq/0eecYFiVz/EV2T5UwS9f5w6MYwX6Yp9iwcaNmYkJx6sK2 5FVevN3Xk1bAb+je2k66cykHk8A1ct3l0J4Nq+CrWyX7w/pQYjVbUt0LWco4MKKjwoemnaF6n xHipXL2x7Il4UU8NMn425UvI4cVT7ffoWxoIavSzDGeAJIwolesH6tFCUqPTHVtmMl16xubRR K3F5MlsDrIBpt1b9s5SXZ/lYcC2GCvuoywjqrHwj2JjE4fWM7+eHq2cp5uKdAfIXM5SNSK/A8 GOMoiqzWkVkQw53JbF4gJAuScAxr3PgG3gxdR3I1zZ1OJFltFNvy3WvJtpuIyAIgD+OAfstoa d4qkGMRgV8xe1JUYgCM8xATDDAyIa0pJWs/Jr8H03OsQQ25D4g+0owat4L5lesAqNaK+CVjGm 55GjQJrgKWmpZnNtpzMy3QBdzz2mV9ZpSzBl2Og71E80GWrsEcSVtQBgwu6ESgYD7uyRAURUM oWK62LlECcO/pY2TfHe3JFUOj9gRFqk4SbpbD7aHdF2VdrGkQ5Dc1s2g6tb5JiHkbdP1TE587 NedBWDmI4tzhFBHY/5nQGap2GBS44gF2xKobM/7zqxQ90Nk+YJQVos2IKcs/x2AD4eocrDCyR kqZIrNYYtB2MyapmC/d0lrRbZ/Sb0kqdz/oFrxLUzjQSv65rezyIf5wbERMAjIYPT+OL40Ej5 JhNaTc0EUEBCNxn32ndxlAja/9HR4kI9jLZFt5Q1EuEQfcAdUlHdVx02mDFnaL5XEL9TYByy3 FfIbmHQvtH1RLyjrARhPlpahSGIiTekLEXhitfYsS23vK4SymcwNvwIVcOhK3ExS2cFNxYpZ1 aPH7CGZM71mRLh0jFPEGg2hR9+I+kflG97xylUbdGWDrnj34xtUuVLZP8zopz0pGwhpZd7Vbu HQdzZhM+Z5K6i0B1X39B4rAgCV4kEPpGCNYAtRwY35fi95GexCY62OyTY/LNylIXi6T6D07dT SkikuNsOCySdMOWcdevSrK26AZx6hvE5nbWqyLLWQzeR7tQ2eYBtuiwmBhlPZxbpprt0MAMDs HcYMJ7V4l+nYJ4vsFYRGzk5YeonT0STUEB+Fu7HB0mOiBxrQ19/QPahDumRkdaHa9v7E+iBQs K/nsT2DZrQt+ogpymXYp2vgC1i1vJvBiplqJwLk8xUtYMR7eGH62pLrvLf5LxvsbRQ6DYBzj2 ksdfkuu1ncFvpcJRJGYjugNzcmkShywaCyaLnwkhI6xMgHHWxhnsSP6cNnA0cgIylinr+pXVU eWa4YUsQslE5HB8eAEqazFQfuhL3rB7CpcQQNLSfSRTu+Ss99kJqtEUJSOuteAk9DckGkMfHT t3ydmW9pTxJ0UW9IsZtYcHwWNquy3SqLG5LSkksGsREqqXk6ycKAhMUKKR/adbeMs4fiRgUaI zOB3dS4R5Vg2LYe5qCWasH+bCKdCMDdM79v5XUr/1DlccHFLQH8FA/Sb3MwTyR2ozVCbDnMeI L+p9IR6huK6u85G/hGtP0FGh1gn7//MFhQK8Toit/LRZFz+3cuURFwFF67X/nOjXg0hpvcpEN Rk3i5zFdP2IWx0nTnPvvWXRN625rtBDE/DJra9vE8aQxfZX+ufxuK9vwzSTesy2Pi5OUPIU6v UhEEhB5StjnJCdIztWl232XPRP8zkw+7dDKqpWbCdBILy6edazs1ZzjRhXfpP46q/Rk0qi0 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78957 Cc: 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) On Sat, 05 Jul 2025 12:30:39 +0200 Manuel Giraud wrote: > Stephen Berman writes: > > [...] > >>> But, I prefer yours. Do you mind if I complete your patch with my log >>> entry? >> >> Be my guest :-) > > Sorry I spoke to quick. I think mine does the right thing, because it > preserve the selected window as the calendar (as it used to be). WDYT? Ah, right, I did overlook that. Yes, your patch is better. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 08:24:13 2025 Received: (at 78957) by debbugs.gnu.org; 10 Jul 2025 12:24:14 +0000 Received: from localhost ([127.0.0.1]:56302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZqJw-0004zs-Bj for submit@debbugs.gnu.org; Thu, 10 Jul 2025 08:24:13 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:20453) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZqJp-0004yL-06 for 78957@debbugs.gnu.org; Thu, 10 Jul 2025 08:24:08 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=LkNS0juM /GFRGkMHjbsQcZW52fAjzQz6EtcTXPeEM24=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=NiQTmg0JhLA9hZs7t5h0SiNLW3m6rm xvSU97uJ/uMe/fkpZ3eHEG/M9ATu+r3nPRhztx3B2PCrPgy2Kz6hhgBA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=LkNS0juM/GFRGkMH jbsQcZW52fAjzQz6EtcTXPeEM24=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=W2fs/UjePZonbQ6aeZPy1+SH0J4U1SvKjIpAHP bo1g2/Z0myYiQ3uUc89SD4OjExbZvqufEIwDB8gWd+lJpyAeIkMiGKRBVPB71y3kALciFA KZD9FasZCqsGDkJBlg2fZSJF0hc7pfjr7miOUX1/EfnrxCeEshgQQHCtA1ltf55s+RcjYG xOKquoUlwoTUmLC5SlYV+XJrWKnnvmhg5gZF785AwMDbwsmQrWoRp8JpecLmAwEZjDjqlE JB/gCwSqhFF/i6fX/y1bspsHScbSd+qqooFJBJBjX1r65spU/G7o+9OYP4CfSBoOljDTKm EGk2M2YD1iuRKO1Ka2KLjsEQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 7b7f9d72 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 10 Jul 2025 14:24:00 +0200 (CEST) From: Manuel Giraud To: Stephen Berman Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <87ecuvndmr.fsf@ledu-giraud.fr> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> Date: Thu, 10 Jul 2025 14:24:00 +0200 Message-ID: <87ms9cs07z.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78957 Cc: Eli Zaretskii , 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud writes: > Stephen Berman writes: > > [...] > >> I hope you haven't spent time on that yet, because it occurred to me >> that the following patch might suffice: > > :-D I did not spend to much time but, in the mean time, came up with > this one: > >>>From 5b1b04936e5d31197ea5129fb7e56e28f0aa24ad Mon Sep 17 00:00:00 2001 > From: Stephen Berman > Date: Sat, 5 Jul 2025 10:56:00 +0200 > Subject: [PATCH] Fix mode-line string width in diary view > > * lisp/calendar/calendar.el (calendar-in-read-only-buffer): > Select the buffer window because, for example, > `calendar-set-mode-line' needs it. > --- > lisp/calendar/calendar.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el > index 917624c489e..8b7aa71db93 100644 > --- a/lisp/calendar/calendar.el > +++ b/lisp/calendar/calendar.el > @@ -1168,8 +1168,9 @@ calendar-in-read-only-buffer > buffer-undo-list t) > (erase-buffer) > (display-buffer ,buffer) > - ,@body > - (goto-char (point-min)) > + (with-selected-window (get-buffer-window ,buffer) > + ,@body > + (goto-char (point-min))) > (set-buffer-modified-p nil) > (setq buffer-read-only t))) > > -- > 2.49.0 Hi Eli, Do you think this patch could go in? Maybe in the emacs-30 branch since it is a bug fix? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 09:28:38 2025 Received: (at 78957) by debbugs.gnu.org; 10 Jul 2025 13:28:39 +0000 Received: from localhost ([127.0.0.1]:56519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZrKH-0007O7-CP for submit@debbugs.gnu.org; Thu, 10 Jul 2025 09:28:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41336) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZrKD-0007Ms-UY for 78957@debbugs.gnu.org; Thu, 10 Jul 2025 09:28:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZrK7-0007sW-TF; Thu, 10 Jul 2025 09:28:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MZl3WOlVkZvzBN23nZEH2c8GkW115UMe9jbSgtYINJE=; b=nAboJEwd9+f7 b7/rk+0/9D42oUTYYQy46VavIaF+LQsoHrpxe0klptTd7OR/h/COD1hlsVZPIonANSQUEe9mIPr0W YgARDL6RlbGuA9CAsjh2gMDN14tzl+2uLoAUevkz5F5AAVi1z7gebgq/cX0o5D51FzOT3lgBcPVw9 +KWTIr1AoRYcESHC9Oiq4lLSqsVa1EpRqrqsXX3KQUiVQQjEPH7Irayo/BYO2HsemuOoA4nD0poOc p+IriK2lUnPfSphHOJlpzFAtJ0LLPU6mEf1xpwb4CfCW7gX7Km7m3nHFYcnTlElbE+49cT/wLAJ71 QyfB7EznF6vyblzjQ0wGrw==; Date: Thu, 10 Jul 2025 16:28:25 +0300 Message-Id: <86o6tsgop2.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud , martin rudalics In-Reply-To: <87ms9cs07z.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 10 Jul 2025 14:24:00 +0200) Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78957 Cc: stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 78957@debbugs.gnu.org, Eli Zaretskii > Date: Thu, 10 Jul 2025 14:24:00 +0200 > > Hi Eli, > > Do you think this patch could go in? Maybe in the emacs-30 branch since > it is a bug fix? Is this a regression in a recent Emacs version? If yes, which version? If this isn't a regression, then please make the patch 110% safe if you want it to go to the release branch. E.g., what if get-buffer-window returns nil? Martin, any comments to the patch, with emphasis on its safety? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 10:42:17 2025 Received: (at 78957) by debbugs.gnu.org; 10 Jul 2025 14:42:18 +0000 Received: from localhost ([127.0.0.1]:58260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZsTY-0000fV-UY for submit@debbugs.gnu.org; Thu, 10 Jul 2025 10:42:17 -0400 Received: from mout.gmx.net ([212.227.15.18]:47967) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZsTV-0000du-Il for 78957@debbugs.gnu.org; Thu, 10 Jul 2025 10:42:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1752158526; x=1752763326; i=rudalics@gmx.at; bh=JX8RrQMXR9Low+dD69sproF/dI3IFzp3o638BT/GNyk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=EPud4X0xrMph1GHYoCSKpe3mfVPlkensysrSaj1w001L5xeHTAjkUSPsFyL9856o L+NJNBpfMAkJgw9cok/WspuKe5sMOkdhiC89tRKErM2YnyWvQH5UY/lnanOBfPD6D P7Nr2h6gTKlME183bD4ZvNA1xOy/4xb/tdidemaOV1SuJtmpNNyy2ssTJGxfo13Cw C7VW6jSrxFFXtiXEMDLhro/FqKkJE7IJlzts9tYWyW8K4EQV/AwP6tt0MfUkqQuxh RrxZOeH1nNd6ckdW5s6G9vdXs297QQ4UFESOi4neqiVDB2FiR0pNM0VZPtQH/7FuC OeGxsT3PlDuY1yrDgQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.172]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mk0JW-1uxywH18dU-00j3UG; Thu, 10 Jul 2025 16:42:05 +0200 Message-ID: Date: Thu, 10 Jul 2025 16:42:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary To: Eli Zaretskii , Manuel Giraud References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> Content-Language: en-US From: martin rudalics In-Reply-To: <86o6tsgop2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:YumS0XGrgMQuGbOFRJqIV1z5BbE9IghyJHp1NAl/9dA7ewjC7rJ U4amlAHjI9kPNWWKJ6zpiDg1uFhuRwUhVYqTcPlTLbhTGuLeZMDliCHjbTwDc7iUDhSADGw lmtw/pKQTH0ck+gl3FSqqM3PSidRQXDlG04QUpi4LHpSRkbvs5FbQasQisDxwSF1kiMNJsU auAXj/Em60SCUK8WrKJWQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:EUmtqEOS7fY=;6qRJiwt/HCF4DZAjFgO314G2se8 DlQLT/y5iH2b00yZy4g23Pn1Wbp9oDT1FAgD13lYzj0vFnVRvuz+j0yTzpsKdzDpUqJmKFC4J kp0cwOIA2NPpddihbOLOEGUycSxLuCRsiyhXpT/putNyS7U6+VkIC05ReMbhL824q828rtGEj TAE7vdmuVb5VnLKwF+tcw6BDGOwpTRAIrZGyACDKRpgVa2swSuFPC48bCJyWGhJGzLudeGUp/ a6u14Xaf400grWN4Jb9nIohjapznFulfOLNzfdghxR6wlNSL6Oqy1DEAtuaAo8uzWuwC/8pL9 BD2GuBLB8Ws8R4qTEtSTdgvAS4abgYSpJF0chHw7g6nMG2ov+UCCUXATBB/i3iEJHlVbtQ3h8 fuq5b9dTzVt2YQWV1XJCia+72k/ACzIl1At5o3j+CgDCHvKL1bLJcBrqVwKR6YaBYo+jKnXy9 L9XNg5BcnMGQ7Q7s29gkyE/FMlGC4FsNZdfa/vpEYC/BUYEyA0t96a5z8u8XVWeuM/PCS2xuR sxfunM6Cckb0E9D0EJ5VMCa0XPZc/Q6dL5TIBtYHO4ck6QHT0dY971e1FYHBBCES2/4WOWXJ9 RM5fUlpe66OZ54Y/mUM68dvpUfk5jd+/QHk12qvxjfvQZEWdIMtd4HppuxrwZHOp59l5XeqJc LQRFXmHEy3H26AvHiIPStcR5DlzoKEUFYuRMWdG29larQbj2HcoxSDHlCWDVOiIcKG78jiBGu YgzilyCC81ygYVXWKdgIIniSRB7p0T71NACBL2X9+MaHTcGSFtquAgT6df++pERG5IDQOQzqo gPpFPW3mAN7HySZci8f2updLdZP8lr2VPGhEvdwks4I27I6MBvnHrXZFl7CXoQG4yCwAy/T/b WoHHyW2K1rPbkWDbqeLQHLdLxIUiTDsqjXb9LvBrr2IRXVjHEe8nu2R7wtKQkpp9Y+JoWtpWc uBzBxXEjp7nl+HMpRJ238+LsUc1Q8cg7/KBfLjX/wYslwUot0uigT9xjINge+DoRjsz9PMm/g jg1QwEMB74y8nM+WBJDfnpBRX8I56swKL5pPxnjh3pzvf6pQ/7SSJsoQZRtrb4irWft5SxcpA t6E3Ec9L8iyANwqHbgzsmrhucok+mBWODCmpwGmea5GXW1cVviMFYowC/VTAJczjzV9tSYnTD AepW6mBcM+nKyHd99IBpykcO0YFcUfoscz613veRk1nXxCDidqd6nTO+usX+pHg42YB1beA9m Tje5CGFhHIRJ4rHX8FxOvf5kKTPNhdyujWnn+3msoSKi1qgmLdd0OEszeagrTL2VAI9jCY4Kk JPRPwJ0tRh8ksmUpSeh5DM2JSYuJUybOLlqqMDwelTP4TyUL2NcI+mLg7Wo4I9o1yux+np0jG WpXcRAd8BNUKzAz5qluRrFhlVTLPn0N6FsE7942zXTibHcN4oRh1zPU28MTGbfKlTYE0bHzy4 p4PJqfTrVTM2uPh020jmhUWVdrNbIhQEq+pVTjMXGrDsGFEcL8ib6BDS6wUj6y0NWOZSVjTX2 KwU6Lee8tvAsRi9G7moKA8q3GVrK/UXBYg5AGtNrILCWvnZYltTBX63TQTKs5u4EYfITHJ/lf 2/a6noZrauw+y+N64ZYomu+tMq+ea8+O+X5DcOMzdnZfh3a2klJhaZ/8FKV7dwRh6gZ/7PjSC Zh5N4lsUpqgFWVvRttczpOtwQHG2V164nl/9E2x7zBzL600yl5Tlw4R6+sNE+lOYioLRZQAle 86xANs/PwJzkN1RJ2LUlflMvcw1KmTznB0I99MhcMMNgpakHVyljhcVlTK611Z6K6v3gFbKbF uncQf+OR4gOB5hHoDQiz5DOiVS2vb6Aidh2RKTyfuHUoNRrdZ7Ag3f1QV/FHbrYdF+3WtQskk tqWtJlrXIGsOp+VkJz36YXGeCGpoxbWthG1YMgofkl5mDXInPuSJwh8OGDmUs+unS7tkrX1pI mhpKk+36EKU/tB2261ODY7KoRtpjXjMx9RXOksEhUMkfkT2+GhU+VPZxskcRo6umSZ5Q6OW40 lhIVO0soZE9Vgmdp7e8BW5o5L8V6eSLeQhKOn2dKivEHjfhKq3ZHH43ZORdOeDeCFO9a9usLk Bh7AIr2d5aVpnh4D84vrckQdfuZWdoF2jLEqJ4fS1THBZh9LDgG0kp8eSkxTWsTvBJYkWfrTO Rw0xLTaxd9bS1YhOt2FyqujB0gIoKDJFVAJBG9YTyONSq+k6Wi1lYyP4U3g/xCjC22B3U5Wbv QAKO0d+QK8mQUAq90FGjqhHe6Vxi1d91jbqEYkEqyecyd7Dk7oJ+eL/cUA+mJlh9Ll0I54i7t SyaQ6553L2EVHjns7roKyszxs2Elx+CnLyqHlUuugAcbhCh2JSnPt3xEfnupWGm/W/+2aAOcx AdotvBrlkmmr7E1e7/4uawCf0lHdE1NsBDDKpkbxPNEUMoGUca099gxCbM0rDZWU8fncgoqk5 GEFsT3HJ2x9VJKsRICQTsgjh/NIOm7/S5aviOPLaY64+UJNpTuyAXIvxst1Mr9dNPpyzTQr7e ttedW0DKM54Mo5hZzXt4TP2kqyYsDk3FB7VgaQI76F/siD/wf9l3V3LHxr+nWOqZhexrNlJgR J1L/dhdryYIeDMuVg+p0i1eBmFS3NfGxVeFc7qMv2BeAAxQw2nTaGG8TfyjVQuIllrkbQWHgv vaWyRVWUxKQqdMHIi8F8mx0YiUef04d+uTAYMM7ASW3F2Jsfy1Uy0H7cH6dWz0pLl7+7Xaobk chxeadyqs/eGgnCw8zQVqveaoJlOteiaSUw1WdZP4JI+bWWIkQhOdqoATKQf2kTwKkAzxx5sh DPyOlX0mPCx/1mcNXw5mArz415PXcGnstBzExv27HmaV+glz2q/2AO97AVmzzpxSuEhmnlLwT CLm/hsQns4qCZr0LjvvPxuLBVyBJ3HoDwXHAk++8OV8hgWOErePn9unVacnhcASfYtPxL0ka0 Z4CdyOOf6SalVEFo4fHPDhj9mYHIAJhGXnzO4Amf1V5oHcmF7+fJEgs+BSV7lCHwXS7PmDQRz OGvvZjLDlFzkUf1MKTYFLbJ5EospavpQzSi+5eg2cEAfade5oBv4vC6AejU5eCsiVZAC0nCtb dNcRJNLb3+FZ73SsMRfwrhHlqNmUtNg0gvBCEbtHn77Y6WCS0yIKmnqWpXVBkLFD+CaWLmPL8 MmpGpOPzclyWADgmYubaq3OUcADdvVqwuxsSdQ2GPRqZaaZ6ce3+kMPs2eB12aPo3VsHiV6ue CqdDOitFezKC4cb6ClkRHddT8mZhureLRYHXKZX/vKthOeWewlfUTZTQ5hIpkSUBkKMGkXdO/ 6xv8FpVF5s3t1ILD79BIyk5x+mFucjMAkIsiu3j524Oe5m9FcCL4jb+pqu78DMWWvqe9V/5Lo /kC4nDLZoS7xrlgBpdUKibHf/uQ/DAmFBsWBs+iCFsxEWb4MiHgA/uvaFzRaxfptP5etBKcs0 +zG+mq2RrOiRX33+Yv9dx57E501FAU75nV4+DzZIBv3Ux9lKNATciKi6TiWEpz1lNYMbjVgNs 9Q== X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Martin, any comments to the patch, with emphasis on its safety? If the patch is this one diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index 917624c489e..8b7aa71db93 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -1168,8 +1168,9 @@ calendar- [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.15.18 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in sa-accredit.habeas.com] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.172 listed in zen.spamhaus.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in bl.score.senderscore.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 78957 Cc: stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Martin, any comments to the patch, with emphasis on its safety? If the patch is this one diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index 917624c489e..8b7aa71db93 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -1168,8 +1168,9 @@ calendar- [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.172 listed in zen.spamhaus.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.18 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > Martin, any comments to the patch, with emphasis on its safety? If the patch is this one diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index 917624c489e..8b7aa71db93 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -1168,8 +1168,9 @@ calendar-in-read-only-buffer buffer-undo-list t) (erase-buffer) (display-buffer ,buffer) - ,@body - (goto-char (point-min)) + (with-selected-window (get-buffer-window ,buffer) + ,@body + (goto-char (point-min))) (set-buffer-modified-p nil) (setq buffer-read-only t))) Switch to BUFFER then I would write it as diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index 917624c489e..67764eb0b26 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -1167,9 +1167,11 @@ calendar-in-read-only-buffer (setq buffer-read-only nil buffer-undo-list t) (erase-buffer) - (display-buffer ,buffer) - ,@body - (goto-char (point-min)) + (let ((window (display-buffer ,buffer))) + (when window + (with-selected-window window + ,@body + (goto-char (point-min))))) (set-buffer-modified-p nil) (setq buffer-read-only t))) which selects the correct window if there is one. But I doubt that it is a good idea to use 'set-buffer' here and talk about "Switch to BUFFER" in the first place. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 11:11:12 2025 Received: (at 78957) by debbugs.gnu.org; 10 Jul 2025 15:11:13 +0000 Received: from localhost ([127.0.0.1]:58463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZsvV-0004tC-4g for submit@debbugs.gnu.org; Thu, 10 Jul 2025 11:11:12 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:14436) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZsvN-0004rT-6v for 78957@debbugs.gnu.org; Thu, 10 Jul 2025 11:11:05 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=HaN6/5gy eOirMNem4DKDz/UFnQ2lomIDTaPVAcccLP8=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=IDRHwbjN7RtgFxIanJNPv0WegRbMxV U/22urCcFvG9AoKQ9lQtX35YrtxwHvl3pCv+4KR5/8vPCAlDt9sgogBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=HaN6/5gyeOirMNem 4DKDz/UFnQ2lomIDTaPVAcccLP8=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=WfO7LFko/uBhsfVhYxaMIDZQU63ULE/SO3tFna STNMgDu99sIzWdL8MzlnuNBG/OqIiWqVQMz5kCWHOEv16z27NbtsDnE9Ck09QH51GQHoFC Q/zScfyMHPbY34C84YdfSV4Q8Nw4pwBdKLOKoK81se3dD5rXNvfzYBvPyig/uNh1SCkU1R eQgMleeGROfwmnSgIr5T0F0wBB3Nw97Xvt9Xxj13paTU9DbIDXdpzovzAukvIMBStI3QUb 0ygWfin3qo3WEVtAQVXyp20httNGE+hqlAeE3DbNZT3SoAHYDz9fPYexQ7n470O240ydZo 1nJQy2qU7xeksK6zQIrLLEsA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 37e96099 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 10 Jul 2025 17:10:57 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <86o6tsgop2.fsf@gnu.org> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> Date: Thu, 10 Jul 2025 17:10:56 +0200 Message-ID: <87v7o084jj.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78957 Cc: martin rudalics , stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 78957@debbugs.gnu.org, Eli Zaretskii >> Date: Thu, 10 Jul 2025 14:24:00 +0200 >> >> Hi Eli, >> >> Do you think this patch could go in? Maybe in the emacs-30 branch since >> it is a bug fix? > > Is this a regression in a recent Emacs version? If yes, which > version? Hard to tell but it seems it already has been an issue before: --8<---------------cut here---------------start------------->8--- commit 4cbd0713000c5f0a184e16df3556e8408ea3b894 Author: Mark Oteiza Date: Sat Oct 10 22:23:59 2015 -0400 * lisp/calendar/calendar.el: Display buffer before executing body. In each use of this macro, the modeline is derived from a window width calculation, which will be wrong if (display-buffer) splits the window horizontally. --8<---------------cut here---------------end--------------->8--- But at the same time, `calendar-set-mode-line' has not been modified since 2012. So maybe, once upon a time, `display-buffer' meant "make this buffer the selected window" and this is not the case anymore. > If this isn't a regression, then please make the patch 110% safe if > you want it to go to the release branch. E.g., what if > get-buffer-window returns nil? > > Martin, any comments to the patch, with emphasis on its safety? I'll try and report about Martin's proposal. Thanks. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 11:24:24 2025 Received: (at 78957) by debbugs.gnu.org; 10 Jul 2025 15:24:24 +0000 Received: from localhost ([127.0.0.1]:58543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZt8J-0006k4-Nh for submit@debbugs.gnu.org; Thu, 10 Jul 2025 11:24:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43322) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZt89-0006jY-KL for 78957@debbugs.gnu.org; Thu, 10 Jul 2025 11:24:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZt83-0002Fs-04; Thu, 10 Jul 2025 11:24:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Vyu9KPsWdzYZUAiTOPkWfad9xHgWdxLCU7dmUqr45r4=; b=OutN43xR7KnB R92XVNI4SwAsRdHnnQJCpi/yRJxjSXUc0QHwpPqbwr27w0KYW366L3wtPZQe4GnYyEecdBn3jZwF5 g2eIc65wyQKAcV7sDWSxXCC28uOZduje22axRuq8GtzoRMwzcMKyTcrssmoi/R2fF6Ed+3l4yhCr3 7Pguhm1o2Ax/JJevUf71oh4hVSgxPTe8wqwdvk/op36nybq873MLBdIGnDQsdw7B0rdhMsRh2nh5D 0SDjDQI6iSBBe+GhyDq2R7X2jiFjA7cx2P69rHdnbOP5imkQzuBm+My+o+iGP2caHH34QUzP2BGCl B5TFyRwzGqQrUgujdKQKFQ==; Date: Thu, 10 Jul 2025 18:23:47 +0300 Message-Id: <86ms9cgjcs.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87v7o084jj.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 10 Jul 2025 17:10:56 +0200) Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> <87v7o084jj.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78957 Cc: rudalics@gmx.at, stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: martin rudalics , stephen.berman@gmx.net, > 78957@debbugs.gnu.org > Date: Thu, 10 Jul 2025 17:10:56 +0200 > > > Is this a regression in a recent Emacs version? If yes, which > > version? > > Hard to tell but it seems it already has been an issue before: > > --8<---------------cut here---------------start------------->8--- > commit 4cbd0713000c5f0a184e16df3556e8408ea3b894 > Author: Mark Oteiza > Date: Sat Oct 10 22:23:59 2015 -0400 > > * lisp/calendar/calendar.el: Display buffer before executing body. > > In each use of this macro, the modeline is derived from a window width > calculation, which will be wrong if (display-buffer) splits the window > horizontally. > --8<---------------cut here---------------end--------------->8--- > > But at the same time, `calendar-set-mode-line' has not been modified > since 2012. > > So maybe, once upon a time, `display-buffer' meant "make this buffer the > selected window" and this is not the case anymore. No, display-buffer never selected the window. Its doc string always said that. > > If this isn't a regression, then please make the patch 110% safe if > > you want it to go to the release branch. E.g., what if > > get-buffer-window returns nil? > > > > Martin, any comments to the patch, with emphasis on its safety? > > I'll try and report about Martin's proposal. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 07:44:33 2025 Received: (at 78957) by debbugs.gnu.org; 11 Jul 2025 11:44:33 +0000 Received: from localhost ([127.0.0.1]:35607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaCB6-0002ug-Ma for submit@debbugs.gnu.org; Fri, 11 Jul 2025 07:44:33 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:23146) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaCB0-0002uE-IJ for 78957@debbugs.gnu.org; Fri, 11 Jul 2025 07:44:29 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=R/qfIGtZ 6kBZv/Wcyr8fOk1yxhZ0TrVlPXGdXxu19WQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=G/jpFrAhn4YcTIw4njj0xKc8joW1Gd mIk3lECSC0KCjicdjFGXwy40vx2dv+ubRu0xhgmGe95/W7BYSftdwuDQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=R/qfIGtZ6kBZv/Wc yr8fOk1yxhZ0TrVlPXGdXxu19WQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Wa01EOy6qpXL9Fomnw23dow/3nXl8Z4zP4S26S /KbHzjyjaG/O6uhVEd2hqh8tGP9TnPbBRAaxzKRJzk3PdVtYCWSL521aKfsycxQkley+FD LHDVcJT8r1LZfiWmPi52VY4UiVpm9heUWTVyNHpfpX8bgcyVIF0O3VCInKfbBfzjM+bIl+ 30PFMNXSU85fy/u95i1z5Yz6a60hYjuH+hFHL3hVQTJGIBrxgYVUcgsQRLB4RLWZevhw7K FClEGUmPtLlWNMOZWyl8tUzJ9mta/GM3WVVzVlehmGI66k0Oz8uM54O+jAqFMDdsBi/fsO nsfkQqB04Yk0myZ7bW0qR7gQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id f11d0398 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 11 Jul 2025 13:44:22 +0200 (CEST) From: Manuel Giraud To: martin rudalics Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> Date: Fri, 11 Jul 2025 13:44:20 +0200 Message-ID: <8734b3ostn.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78957 Cc: Eli Zaretskii , stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: > > Martin, any comments to the patch, with emphasis on its safety? > > If the patch is this one > > diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el > index 917624c489e..8b7aa71db93 100644 > --- a/lisp/calendar/calendar.el > +++ b/lisp/calendar/calendar.el > @@ -1168,8 +1168,9 @@ calendar-in-read-only-buffer > buffer-undo-list t) > (erase-buffer) > (display-buffer ,buffer) > - ,@body > - (goto-char (point-min)) > + (with-selected-window (get-buffer-window ,buffer) > + ,@body > + (goto-char (point-min))) > (set-buffer-modified-p nil) > (setq buffer-read-only t))) > Switch to BUFFER > then I would write it as > > diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el > index 917624c489e..67764eb0b26 100644 > --- a/lisp/calendar/calendar.el > +++ b/lisp/calendar/calendar.el > @@ -1167,9 +1167,11 @@ calendar-in-read-only-buffer > (setq buffer-read-only nil > buffer-undo-list t) > (erase-buffer) > - (display-buffer ,buffer) > - ,@body > - (goto-char (point-min)) > + (let ((window (display-buffer ,buffer))) > + (when window > + (with-selected-window window > + ,@body > + (goto-char (point-min))))) > (set-buffer-modified-p nil) > (setq buffer-read-only t))) > > which selects the correct window if there is one. So, there is something I missed with both patches. After a complete rebuild of Emacs with the patch, the misalignment in the mode-line is still there. But if afterward, I `load-file' "calendar.el" and then "diary-lib.el", the misalignment is fixed. What am I missing? > But I doubt that it is a good idea to use 'set-buffer' here and talk > about "Switch to BUFFER" in the first place. Yes, we'd have to modify the docstring. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 07:51:18 2025 Received: (at 78957) by debbugs.gnu.org; 11 Jul 2025 11:51:18 +0000 Received: from localhost ([127.0.0.1]:35667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaCHe-0003Wq-0d for submit@debbugs.gnu.org; Fri, 11 Jul 2025 07:51:18 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:47912) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaCHX-0003WR-EF for 78957@debbugs.gnu.org; Fri, 11 Jul 2025 07:51:15 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=HpgB3Hd0 5l2Qzgb8/8lQENw36T4EoJjA4xclHtVoFWY=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=VNn9rsozK8keU79/YI7vrxXBgrG/5L jIQe5ZbMWRTQ5h2E+JzHH7mG49l+AWs6vg+edOGrxqw0N9cf/ce7JUCQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=HpgB3Hd05l2Qzgb8 /8lQENw36T4EoJjA4xclHtVoFWY=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=pqwCJ+1Yyi5/Ksh6B9MJIHQ8x/lJhu9Pzbl1zU oMqgy9Lr+OSu+T0oIKehdH4FW6wCQ5MFpjGriL0MN/5bKwoON9kpUOI8Oo9kp2EYE6di5k yaBYetSIaTXpmxqcdDhvuT4cUsMjcjfg/svguAogaXRk++EKFARIJ2BwCeIHY5Vi96QpWm dQiEJHfAdYatv4AZmT3enc59/bZe9A7p9t6Sd79cW7mucJ6fifoDqWRZOpx9LtAc5JI6q9 0/m9v8P1TLaotWpdc5iO1U8ZVNrnZr5EorE6hea+yFDhlYv4hLLSlvoGOmvwxUX/uyGyvR NrbI3m7rWdjUzl1wWZOFXawg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 723677bc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 11 Jul 2025 13:51:09 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <86ms9cgjcs.fsf@gnu.org> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> <87v7o084jj.fsf@ledu-giraud.fr> <86ms9cgjcs.fsf@gnu.org> Date: Fri, 11 Jul 2025 13:51:07 +0200 Message-ID: <87y0svndxw.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78957 Cc: rudalics@gmx.at, stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: martin rudalics , stephen.berman@gmx.net, >> 78957@debbugs.gnu.org >> Date: Thu, 10 Jul 2025 17:10:56 +0200 >> >> > Is this a regression in a recent Emacs version? If yes, which >> > version? >> >> Hard to tell but it seems it already has been an issue before: >> >> --8<---------------cut here---------------start------------->8--- >> commit 4cbd0713000c5f0a184e16df3556e8408ea3b894 >> Author: Mark Oteiza >> Date: Sat Oct 10 22:23:59 2015 -0400 >> >> * lisp/calendar/calendar.el: Display buffer before executing body. >> >> In each use of this macro, the modeline is derived from a window width >> calculation, which will be wrong if (display-buffer) splits the window >> horizontally. >> --8<---------------cut here---------------end--------------->8--- >> >> But at the same time, `calendar-set-mode-line' has not been modified >> since 2012. >> >> So maybe, once upon a time, `display-buffer' meant "make this buffer the >> selected window" and this is not the case anymore. > > No, display-buffer never selected the window. Its doc string always > said that. Ok. So maybe, the patch 4cbd07130 was working by chance because the calendar window was already splitted at correct width. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 26 04:38:48 2025 Received: (at 78957) by debbugs.gnu.org; 26 Jul 2025 08:38:48 +0000 Received: from localhost ([127.0.0.1]:39698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ufaQa-000051-63 for submit@debbugs.gnu.org; Sat, 26 Jul 2025 04:38:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33086) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ufaQX-0008WK-0V for 78957@debbugs.gnu.org; Sat, 26 Jul 2025 04:38:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ufaQR-0004BU-CM; Sat, 26 Jul 2025 04:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Jmw1vI+XxgrC9nSFCa9CxApL5KDS6pAtMGSk0MQR1A8=; b=Zh4ao3QQBlUq n2xiS/UNSGqBzjNo+6W64/0Re/oZZ3AwPLxFYYvvR6fpqpCpsbfFznNk/FUH8s0n3xD5p8G6ThvyX a/PV9ZEPZCy+E7fUPkFwLN3sYh71mLSxRDAJgtuQQ3a+9Ca/JhDicAQBKrxnP8aagH/zLS1zrHkXw 3U9nWATcaZ/cy9D844d88Qe/5uYJR/mwAuK1AGrFQnzdt0Ds2eNI2Q6zxE4HeU5nOeiay0h0z9MVe 5C3P36MVYJksh81qwSPfTX0Lcyz+dh85hA32QU8moC3SvsRX06SsPnvI+DivtSu01iXgXimNFC6lN UOjubNY8ZDvbBlIP5y132Q==; Date: Sat, 26 Jul 2025 11:38:35 +0300 Message-Id: <865xff2vp0.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <8734b3ostn.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 11 Jul 2025 13:44:20 +0200) Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> <8734b3ostn.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78957 Cc: rudalics@gmx.at, stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Can we please make some progress with this? > From: Manuel Giraud > Cc: Eli Zaretskii , stephen.berman@gmx.net, > 78957@debbugs.gnu.org > Date: Fri, 11 Jul 2025 13:44:20 +0200 > > martin rudalics writes: > > > > Martin, any comments to the patch, with emphasis on its safety? > > > > If the patch is this one > > > > diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el > > index 917624c489e..8b7aa71db93 100644 > > --- a/lisp/calendar/calendar.el > > +++ b/lisp/calendar/calendar.el > > @@ -1168,8 +1168,9 @@ calendar-in-read-only-buffer > > buffer-undo-list t) > > (erase-buffer) > > (display-buffer ,buffer) > > - ,@body > > - (goto-char (point-min)) > > + (with-selected-window (get-buffer-window ,buffer) > > + ,@body > > + (goto-char (point-min))) > > (set-buffer-modified-p nil) > > (setq buffer-read-only t))) > > Switch to BUFFER > > then I would write it as > > > > diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el > > index 917624c489e..67764eb0b26 100644 > > --- a/lisp/calendar/calendar.el > > +++ b/lisp/calendar/calendar.el > > @@ -1167,9 +1167,11 @@ calendar-in-read-only-buffer > > (setq buffer-read-only nil > > buffer-undo-list t) > > (erase-buffer) > > - (display-buffer ,buffer) > > - ,@body > > - (goto-char (point-min)) > > + (let ((window (display-buffer ,buffer))) > > + (when window > > + (with-selected-window window > > + ,@body > > + (goto-char (point-min))))) > > (set-buffer-modified-p nil) > > (setq buffer-read-only t))) > > > > which selects the correct window if there is one. > > So, there is something I missed with both patches. After a complete > rebuild of Emacs with the patch, the misalignment in the mode-line is > still there. But if afterward, I `load-file' "calendar.el" and then > "diary-lib.el", the misalignment is fixed. What am I missing? > > > But I doubt that it is a good idea to use 'set-buffer' here and talk > > about "Switch to BUFFER" in the first place. > > Yes, we'd have to modify the docstring. > -- > Manuel Giraud > From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 26 13:27:23 2025 Received: (at 78957) by debbugs.gnu.org; 26 Jul 2025 17:27:23 +0000 Received: from localhost ([127.0.0.1]:44691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ufig7-0001qo-9C for submit@debbugs.gnu.org; Sat, 26 Jul 2025 13:27:23 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:43146) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ufig4-0001qW-Ue for 78957@debbugs.gnu.org; Sat, 26 Jul 2025 13:27:22 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=lgKZ5a2e x/2NWqMBU8yd1QyPE+JJuSiymMo8DjzKzhA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=+cYweL/aV1l9Ns4hCV4mSs/PMT4j1u gI52xbCWpMb9bUuffGXE9Ej1VjPy98fTgY1+9zXj2PqcAzp0ffsTciBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=lgKZ5a2ex/2NWqMB U8yd1QyPE+JJuSiymMo8DjzKzhA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=F6VBkg80T1sLfdXh3haUAhl/SWMK1/Px7XqqIh EeNZq1tX0ytYU8P/vkc/sM1RphnFuKaBW4qBCRJe0eGvsr3jbZ+rm1qR6cLNvQ6p9+GN9N eD9Pux1xL2SWBhv9APcvfj4a/mWT1L+I5rBLOLCO78TxI/6kikF8dXcka5tEXggr+n+zx9 ilt04j5TVs3BcMxLnYhrlti+jn2cbDK1akcviBM+Pq63GFCdJQDKa4UfbtsUXUfXpwGX0v wyATgHQuDdTeThXvjpcEtn9JjK+mhOk8YzUt7OMB6kpXMpu9ZG/w9vhwc3VaqkgfQvrVpJ z4ewKoa/y0X5P7G1UODn3y2g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id e7d82229 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 26 Jul 2025 19:27:18 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary In-Reply-To: <865xff2vp0.fsf@gnu.org> References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> <8734b3ostn.fsf@ledu-giraud.fr> <865xff2vp0.fsf@gnu.org> Date: Sat, 26 Jul 2025 19:27:16 +0200 Message-ID: <87ecu2yia3.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78957 Cc: rudalics@gmx.at, stephen.berman@gmx.net, 78957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Ping! Can we please make some progress with this? Ok. So I've tried again this time starting from a "make extraclean" with the attached patch and it works as expected for diary entries, moonphases, etc. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-mode-line-string-width-in-diary-view.patch >From 3ef79d0fb04199fb64c6ced52ff1687a3d779fc4 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sat, 5 Jul 2025 10:56:00 +0200 Subject: [PATCH] Fix mode-line string width in diary view Bug#78957 * lisp/calendar/calendar.el (calendar-in-read-only-buffer): Select the buffer window because, for example, `calendar-set-mode-line' needs it. --- lisp/calendar/calendar.el | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index 917624c489e..04bbc2cb8a4 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -1161,17 +1161,20 @@ calendar-in-read-only-buffer First creates or erases BUFFER as needed. Leaves BUFFER read-only, with disabled undo. Leaves point at `point-min', displays BUFFER." (declare (indent 1) (debug t)) - `(progn - (set-buffer (get-buffer-create ,buffer)) - (or (derived-mode-p 'special-mode) (special-mode)) - (setq buffer-read-only nil - buffer-undo-list t) - (erase-buffer) - (display-buffer ,buffer) - ,@body - (goto-char (point-min)) - (set-buffer-modified-p nil) - (setq buffer-read-only t))) + (let ((window (gensym))) + `(progn + (set-buffer (get-buffer-create ,buffer)) + (or (derived-mode-p 'special-mode) (special-mode)) + (setq buffer-read-only nil + buffer-undo-list t) + (erase-buffer) + (let ((,window (display-buffer ,buffer))) + (when ,window + (with-selected-window ,window + ,@body + (goto-char (point-min))))) + (set-buffer-modified-p nil) + (setq buffer-read-only t)))) ;; The following are in-line for speed; they can be called thousands of times ;; when looking up holidays or processing the diary. Here, for example, are -- 2.50.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 10:09:01 2025 Received: (at 78957-done) by debbugs.gnu.org; 2 Aug 2025 14:09:02 +0000 Received: from localhost ([127.0.0.1]:36809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiCuz-0002uE-5q for submit@debbugs.gnu.org; Sat, 02 Aug 2025 10:09:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37256) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uiCuw-0002ts-FW for 78957-done@debbugs.gnu.org; Sat, 02 Aug 2025 10:08:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uiCuq-00078m-86; Sat, 02 Aug 2025 10:08:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SVSszG5/RaIFlNA935PA0M1J7UbpcuMeFf5tssryHJg=; b=qW8B5yiIg5tF 13wJ6X3r3iWHTPoNunQd8qAIPH1SzP/vDo+tBAX7Aki4bNIPCsEC3N0HWO2GV6D3LDXp0MgiPm3pq nEPxgDka/RhhyGA6k1G3JHOC5aXGNiqLVoQomiTCKUUjbyBQs0y+Me9i0TVWdXQPMLo4Hue0XSle2 eiuDGsprzqR4Rst5dx+nshDODh4tLUcW1/SfvS4YXNj16ONGEEjMEF5/Ihk8ULJddePwKokcL4TGS Z2qSLZ7unJjrV0ngJuK88tZhXMtLTJ1f7Q1GDGi8j4MBv3pcE4MWnkyMT5+8AgzWYYlN+QACQG4kV cUlbliF9HN0Wf4c6tRpBUw==; Date: Sat, 02 Aug 2025 17:08:50 +0300 Message-Id: <86o6sxrf2l.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87ecu2yia3.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 26 Jul 2025 19:27:16 +0200) Subject: Re: bug#78957: 31.0.50; Wrong mode-line in fancy diary References: <87ms9jojir.fsf@ledu-giraud.fr> <8734bbha33.fsf@gmx.net> <87ikk7nhmw.fsf@ledu-giraud.fr> <87qzyvvttf.fsf@gmx.net> <87ecuvndmr.fsf@ledu-giraud.fr> <87ms9cs07z.fsf@ledu-giraud.fr> <86o6tsgop2.fsf@gnu.org> <8734b3ostn.fsf@ledu-giraud.fr> <865xff2vp0.fsf@gnu.org> <87ecu2yia3.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78957-done Cc: rudalics@gmx.at, stephen.berman@gmx.net, 78957-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: rudalics@gmx.at, stephen.berman@gmx.net, 78957@debbugs.gnu.org > Date: Sat, 26 Jul 2025 19:27:16 +0200 > > Eli Zaretskii writes: > > > Ping! Can we please make some progress with this? > > Ok. So I've tried again this time starting from a "make extraclean" > with the attached patch and it works as expected for diary entries, > moonphases, etc. Thanks, installed on the master branch, and closing the bug. From unknown Sat Sep 13 08:10:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 31 Aug 2025 11:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator