GNU bug report logs - #7895
24.0.50; `image-dired-list-tags' should use `find-file-noselect', not `find-file'

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Sun, 23 Jan 2011 17:55:02 UTC

Severity: normal

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 7895 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 7895 <at> debbugs.gnu.org
Subject: Re: bug#7895: 24.0.50;
	`image-dired-list-tags' should use `find-file-noselect',
	not`find-file'
Date: Mon, 08 Aug 2011 14:22:12 -0400

>> Use find-file-noselect plus `with-current-buffer' or `set-buffer'.
>
> Same thing for `image-dired-get-comment', `image-dired-remove-tag',
> `image-dired-mark-tagged-files', and `image-dired-create-gallery-lists'.
>
> IOW, _all_ occurrences of `find-file' in `image-dired.el' are
> misguided.  They should use `find-file-noselect', or in some other way
> not display the file.

Fixed; thanks for the bug report.
This bug report was last modified 13 years and 349 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.