Welcome to my home page

From unknown Fri Aug 15 04:02:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78948 <78948@debbugs.gnu.org> To: bug#78948 <78948@debbugs.gnu.org> Subject: Status: [PATCH] Retain the tag when making a page in EWW document readable Reply-To: bug#78948 <78948@debbugs.gnu.org> Date: Fri, 15 Aug 2025 11:02:40 +0000 retitle 78948 [PATCH] Retain the tag when making a page in EWW docum= ent readable reassign 78948 emacs submitter 78948 Steven Allen severity 78948 normal tag 78948 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 02 17:38:05 2025 Received: (at submit) by debbugs.gnu.org; 2 Jul 2025 21:38:05 +0000 Received: from localhost ([127.0.0.1]:39682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uX59W-0005TI-Pe for submit@debbugs.gnu.org; Wed, 02 Jul 2025 17:38:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44688) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uX59R-0005RJ-In for submit@debbugs.gnu.org; Wed, 02 Jul 2025 17:38:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uX59A-0006kc-5S for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2025 17:37:46 -0400 Received: from fout-b2-smtp.messagingengine.com ([202.12.124.145]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uX593-00020Y-Jd for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2025 17:37:38 -0400 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 28F361D00210 for ; Wed, 2 Jul 2025 17:37:30 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Wed, 02 Jul 2025 17:37:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1751492250; x=1751578650; bh=EYxqvz11eTbk2aFUYn+CRDyRKRvfXYco kUwg3wcmMXo=; b=LE9uKZUcoqHDhYIrf6ANNZWZJuFj1uzakrrP4iW2bE/E/e4f WMVp7z89gADkOQm97r0NlDbiQt0BkK7s7Uj9Zhci7/7sWC4khZMkNrLWDAw2slyI QZR0eakuYghzF40U54WNCWjRAl8FYWn5fKN5q1Q1rPO8Wh2he9to9OlTPACnGI2Y Q5C2x1zTv7Gi+G8aJahldetaVZgQPerjYlxaYe3YDDccXaUyFOud04EOmnFqRi8M RpnHliLycTiTU+DWZ04/8+F3hdxxWtqkMdrMg384JHAdA0rktHuuSzD9G8UPLvYW WJ/uaHCQGgOCI3AO4nJRDJrIV9cHLzsJoueprg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1751492250; x= 1751578650; bh=EYxqvz11eTbk2aFUYn+CRDyRKRvfXYcokUwg3wcmMXo=; b=F XWJ6/Niyt//1aol68WeskLkbLGOE36lGX72+RrHQodEeU71a/k1HH5W+2aPhfwFQ bKZNkNYquVslale9WCopF1RY0ZWbG6mUVvIAsiFyrnO8/Xnbj5LcVluAf3OrUNld L80K/2tViF3OYrJsBrCYFGGuZ1N1qi92GINFhgqz1dEcDTauFVLVgmmD42oRLpIz T77SZurxqliUdXwVGBhe7TUoReeWQwQG9c1LXUFyla29DfrnnCt+Ag+wH7aHAsT6 QU3w11tCicJ31IrYhBrw6oYn+pEAubHgmp+aFKIFu8qto1WJTfiN+Eaa5czAaGob 26MweSpaOAcCSK4o0o73A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddukeehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesmhdtreertddttdenuc fhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivghn rdgtohhmqeenucggtffrrghtthgvrhhnpeekffffgfevteehtdeiffelffegkedvieeige ehfedtteejkeefhfevtddtkeefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgspg hrtghpthhtohepuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepsghughdqghhn uhdqvghmrggtshesghhnuhdrohhrgh X-ME-Proxy:

Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 2 Jul 2025 17:37:29 -0400 (EDT) From: Steven Allen To: bug-gnu-emacs@gnu.org Subject: [PATCH] Retain the tag when making a page in EWW document readable X-Debbugs-Cc: Lars Magne Ingebrigtsen , Jim Porter Date: Wed, 02 Jul 2025 14:37:27 -0700 Message-ID: <87o6u246lk.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=202.12.124.145; envelope-from=steven@stebalien.com; helo=fout-b2-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.237, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain Tags: patch Retain the tag when making a page in EWW document readable. Otherwise, relative links aren't resolved correctly. In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.18.4) of 2025-07-02 built on Laptop Repository revision: bf7d9f3c47ee59d45129d08490411e572a737db5 Repository branch: makepkg Windowing system distributor 'The X.Org Foundation', version 11.0.12101018 System Description: Arch Linux Configured using: 'configure 'CPPFLAGS=-I/run/user/1000/build/emacs-git/src/mps-git/build/include ' 'LDFLAGS=-L/run/user/1000/build/emacs-git/src/mps-git/build/lib -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto' --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-m17n-flt --without-selinux --without-pop --without-gconf --disable-gc-mark-trace --with-mps=yes --enable-link-time-optimization --with-native-compilation=yes --with-xinput2 --with-x-toolkit=no --without-toolkit-scroll-bars --without-xaw3d --without-gsettings --with-cairo-xcb --without-xft --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=native -mtune=native -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fomit-frame-pointer -fno-math-errno -fno-trapping-math -fno-math-errno -fno-trapping-math -flto=auto'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Retain-the-base-tag-when-making-a-page-in-EWW-docume.patch >From a681cc767b1124bed84432ebb062f110383ede68 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Wed, 2 Jul 2025 14:32:28 -0700 Subject: [PATCH] Retain the tag when making a page in EWW document readable The base tag is necessary to correctly resolve relative links. * lisp/net/eww.el (eww-readable-dom): Retain the base tag in addition to the title/link tags. --- lisp/net/eww.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 2f99234c47d..76dccaec9dd 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1225,7 +1225,7 @@ eww-readable-dom ;; "previous" pages. NOTE: We could probably filter out ;; stylesheet tags here, though it doesn't really matter ;; since we don't *do* anything with stylesheets... - (when (memq (dom-tag node) '(title link)) + (when (memq (dom-tag node) '(title link base)) ;; Copy the node, but not any of its (non-text) children. ;; This way, we can ensure that we don't include a node ;; directly in our list in addition to as a child of some -- 2.50.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 02 23:49:31 2025 Received: (at 78948) by debbugs.gnu.org; 3 Jul 2025 03:49:31 +0000 Received: from localhost ([127.0.0.1]:41141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXAx1-0002Ij-2g for submit@debbugs.gnu.org; Wed, 02 Jul 2025 23:49:31 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:61797) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uXAwv-0002Gt-Bd for 78948@debbugs.gnu.org; Wed, 02 Jul 2025 23:49:27 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-73972a54919so4940484b3a.3 for <78948@debbugs.gnu.org>; Wed, 02 Jul 2025 20:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751514559; x=1752119359; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=hY98D9H/byUvnEmNxUkMpCe7jqXgPY6MONH/OigkIbw=; b=g2RJn1Xh/zOkLdpXJzvdgyZ4isBnkcV3iapRwXST7v+shXHEHKmEmGchtfdpIzz2bz yGVTQgyYj2qDHuWlYMbPwdmnUC+itG8GNrfrXqPWg79aHLjWAAddVdUbKULMk7SPOxyc 0n2DIl5ZC0bAhqOG89DGQTlAzf5Bg78SFLf4X4jfoXJq5oWU1Coe0g8WtOxpsdYn9N40 2dWaHRvsm7oC3uE/j5Gl9MHuFQQl7Cb8NZVTLDWPRsXZeZXTvcbAF2u8qh4m+sAWvN1W 4YzkrGGOIFL/w1EQI05fKJbRsGuWTBmreX62c/CqZhFoVdZtpDY2J/RoDgXU08PySiYo S3Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751514559; x=1752119359; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hY98D9H/byUvnEmNxUkMpCe7jqXgPY6MONH/OigkIbw=; b=YHVqQRby0H2E1vM0mdFvhE8tiqQTb5Gy4BMeMWge9OR4GlgcB4T1cutXXZQXcgTFw4 RLW4O46yenfj3zx8PvehPgbr0Wirm2JohkeydKHFE6+G0m4h/Oa+qKxJ3xq2aTbHLaOM QgwTTl2yYJ7n5RlgWakAHqLZlR+E5hAbI2W0QTPRnINNBzvkUacxr9RLjX0n+YW9qnc6 JSvQZ0VmnPgF+TXxzzvjSdvg849YeGTMjixVx2bVYfCDGm1++4sGj8hsxvhmY9MeTGcm Jz+FBIV8qpS3pGAV0qpn6TeCHijjQPg8ni4g2uKX+FDs3S1tQzrUhDBlZ8v31Z5Osg8e dujg== X-Forwarded-Encrypted: i=1; AJvYcCU2P9f2LTiZyUgI+4XiPWj7tjd5sUi3svOCr3Jf7IFGS8yQmgm7p3znNJvam3X2pu+17COXQg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxyUZG+plv0AgTNSMGyI9SeHs7F20rU+9eiO8gZ1KQiIRETYEMH XAwYF5vh6WmIkw8Ly33sUKhzsYcwyAOIBzsgVuTvQeTjio6Q3N8ZbV+X X-Gm-Gg: ASbGncsy1PwcT2t3J7d8QnLM/Pbh+TjvPvUZzep4y+J3gDVMGPjFYIvxBV5PFVor6Cl fVSY73GkFSIMZoEW8UNWXCvs67ClAJNOTUn7E1TMCVV9YC1MpfF2NPFJRFlky/f7b1bBYrAe7U0 kzgS8wT2ijiKlpchW8t/ANfJr0jC7NtlfepZO6QE5/LLmz6puW0ySDlt9GaMlTGA1w2p4bYCUW3 7yJt53kQKm+d5BAGHw6bDXkjCyTozNDfjLJFnrEpSpTBmkLHhSDd95PpgXFhX54rLVAvjuNV2eD TOu+ryws6k9iDVrQXCKC6CfcvFGko4IcJx6PpDvy6O1aFSzLKM7srC6f6bStp4oIjlm/UgKWWjM sFvDbamcFfQ5WYo20sD5y3UA8jQdEW1hGY3WkP1rCew== X-Google-Smtp-Source: AGHT+IFkixiGhuHcLgc7JucWgsO3R/z59lKv+IrdvEodur1u8Xs9hU3wBM9P7bBp6MGpBubJKxlLMA== X-Received: by 2002:a05:6a20:3ca8:b0:220:ace9:193c with SMTP id adf61e73a8af0-222d7f32a71mr7673389637.38.1751514558850; Wed, 02 Jul 2025 20:49:18 -0700 (PDT) Received: from [192.168.1.2] (syn-076-168-144-128.res.spectrum.com. [76.168.144.128]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-b34e31bea22sm14125653a12.38.2025.07.02.20.49.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 20:49:18 -0700 (PDT) Message-ID: <856a75e0-4f33-0c86-d78f-a411544d4d40@gmail.com> Date: Wed, 2 Jul 2025 20:49:18 -0700 MIME-Version: 1.0 Subject: Re: bug#78948: [PATCH] Retain the tag when making a page in EWW document readable Content-Language: en-US To: Steven Allen , 78948@debbugs.gnu.org References: <87o6u246lk.fsf@stebalien.com> From: Jim Porter In-Reply-To: <87o6u246lk.fsf@stebalien.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78948 Cc: Lars Magne Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 7/2/2025 2:37 PM, Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Retain the tag when making a page in EWW document > readable. Otherwise, relative links aren't resolved correctly. This makes sense to me. Just one small question to be sure: this isn't a new regression, right? I know I merged a patch to this code recently, but I don't think the previous version was doing anything about tags either... From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 00:03:55 2025 Received: (at 78948) by debbugs.gnu.org; 3 Jul 2025 04:03:55 +0000 Received: from localhost ([127.0.0.1]:41162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXBAw-0004Xz-8a for submit@debbugs.gnu.org; Thu, 03 Jul 2025 00:03:55 -0400 Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]:56213) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXBAp-0004Vr-3I for 78948@debbugs.gnu.org; Thu, 03 Jul 2025 00:03:49 -0400 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 15765EC0229; Thu, 3 Jul 2025 00:03:41 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Thu, 03 Jul 2025 00:03:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1751515421; x= 1751601821; bh=qtCbdBlziOULXq726r4MxVHuMRhP7ExXn4x+ySt74zI=; b=7 fYjPJLH8yOQo9CsnG65e6qNUinPOM4PD0NdWyW3YMjkUYsIHLRX9j/0X3OA03NHE bX2Hw1eREjxAMFFdjfT7rozSi6lgElajsnz896kPqrS50wWoyLEGvW0AWsH4RRsm 6dUDvmTryl/QTHiwp7QFbSr/eua6p1OErnmZbWBh55FH2+q26z/Wtds+uTc5vlt/ /dLC9FEcSPV68Mq6krhUwreu/DmMcZbBkoLwoHpDUyWPnuPUJoi6wBGux9FcTabH yFuJdVBWINY8t1VToiGu1NaoMLEzFqUsFjgp8nO7B7lnTrrPpWhaS5FV5sZAWH6y HqaBrNxypbTYP2bMhB1UA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1751515421; x=1751601821; bh=qtCbdBlziOULXq726r4MxVHuMRhP7ExXn4x +ySt74zI=; b=F4+pvHHLcgVEMfMwDbiNvNePwkOXNTu2xIuWYSxtR7WAor7cOeD ynCKXx7tjsctXLoyzJqoRx9bPXcCy+oW7MmjjoS3o/U2nVQV2W4rtH3lSsuF5P9q GITtOg06tzCDM+xONUZozCotLO76RlVAksMRRxvH3+w1t3SrG/bzmHH//dpcYHvr VDbNYBAIsLlou/8oEf0ohRJNq3fgYRGPYflLd0r9BAU/M6SfTzJCVVj1quNJVg8c odUUQEMs+3crpKBduRnaFSagF4hcQFZzvk3vuQIw00nKJFtj3jmJHPMSMzklbWjd w7IpBHIiJ7i5WiFXUHJ+JZU5OcIIefeH8+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduledvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufhtvghvvghnucet lhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmqeenucggtffrrghtth gvrhhnpedvkeehkeegleehheeggfduleektefhhffgueffteekgedtvdefuddutddtjeej vdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsth gvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgspghrtghpthhtohepfedpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepjhhpohhrthgvrhgsuhhgshesghhmrghilhdrtg homhdprhgtphhtthhopeejkeelgeekseguvggssghughhsrdhgnhhurdhorhhgpdhrtghp thhtoheplhgrrhhsihesghhnuhhsrdhorhhg X-ME-Proxy:

Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Jul 2025 00:03:40 -0400 (EDT) From: Steven Allen To: Jim Porter , 78948@debbugs.gnu.org Subject: Re: bug#78948: [PATCH] Retain the tag when making a page in EWW document readable In-Reply-To: <856a75e0-4f33-0c86-d78f-a411544d4d40@gmail.com> References: <87o6u246lk.fsf@stebalien.com> <856a75e0-4f33-0c86-d78f-a411544d4d40@gmail.com> Date: Wed, 02 Jul 2025 21:03:38 -0700 Message-ID: <87o6u1nco5.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78948 Cc: Lars Magne Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) Jim Porter writes: > On 7/2/2025 2:37 PM, Steven Allen via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >> Retain the tag when making a page in EWW document >> readable. Otherwise, relative links aren't resolved correctly. > > This makes sense to me. Just one small question to be sure: this isn't a > new regression, right? I know I merged a patch to this code recently, > but I don't think the previous version was doing anything about > tags either... No, this isn't a new regression as far as I can tell. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 01:10:26 2025 Received: (at 78948) by debbugs.gnu.org; 3 Jul 2025 05:10:26 +0000 Received: from localhost ([127.0.0.1]:41528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXCDJ-0006Le-Sy for submit@debbugs.gnu.org; Thu, 03 Jul 2025 01:10:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56634) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXCDG-0006JU-Ui for 78948@debbugs.gnu.org; Thu, 03 Jul 2025 01:10:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXCDA-0007Q9-V1; Thu, 03 Jul 2025 01:10:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WitpVkNz7CLKqu/0u1tBrP/yw91Q+U2sXsvqg1oBMxs=; b=bgV1CfImb+yg KWYKio6xCqefQSGtOwFGa0rIAKBtZcgnDJWIjbPdqi7BydsEfxm64ru1T7PVToJAVSPv1jqTyuHqu 6zFY9kkQd2muHLb6bvDXvBWGi8joG3NKPm0wzwyTXDXN/t5HfFdv/OadA/XzRRuN/rhs8TsLTkKHn Vzd2Y5R7Y26vfsvu9iygSRrW7g6DxlfDntrVoKWDvPSW0kw6u5ePbteqY+EQ5XAiffUhc3JcvoGr0 ANlsvHWMJBjtv4DMB93lB/Y7EcHyD51rIaEa8diPwIfEIBYg9MW6pYRjjIHqvUkEVt1eGXC2e43Yy RN9cHzhGEGg3JlCZMefQMQ==; Date: Thu, 03 Jul 2025 08:10:14 +0300 Message-Id: <86a55l272h.fsf@gnu.org> From: Eli Zaretskii To: Steven Allen In-Reply-To: <87o6u246lk.fsf@stebalien.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#78948: [PATCH] Retain the tag when making a page in EWW document readable References: <87o6u246lk.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78948 Cc: jporterbugs@gmail.com, larsi@gnus.org, 78948@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Lars Magne Ingebrigtsen , > Jim Porter > Date: Wed, 02 Jul 2025 14:37:27 -0700 > From: Steven Allen via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Retain the tag when making a page in EWW document > readable. Otherwise, relative links aren't resolved correctly. Thanks. Could you please show a recipe for reproducing the problem? Also, would it make sense to have a test for this? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 11:18:43 2025 Received: (at 78948) by debbugs.gnu.org; 3 Jul 2025 15:18:43 +0000 Received: from localhost ([127.0.0.1]:49786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXLhz-0005fC-3q for submit@debbugs.gnu.org; Thu, 03 Jul 2025 11:18:43 -0400 Received: from fhigh-a7-smtp.messagingengine.com ([103.168.172.158]:57579) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXLhv-0005ej-B5 for 78948@debbugs.gnu.org; Thu, 03 Jul 2025 11:18:40 -0400 Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfhigh.phl.internal (Postfix) with ESMTP id D9AED140024C; Thu, 3 Jul 2025 11:18:33 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 03 Jul 2025 11:18:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1751555913; x= 1751642313; bh=03piMo6uuwgE1+w2WSC/O/y0sstcV5vlQ2UGLo9RjSw=; b=q gdQEoSL30hit0df7S4TygPby201/Fp7Y1onI9M1T2SavOsaUDbSlm/GZmlqcifqJ ZsOv1FL1WtwvDIiw8Td7/xonqeojn9uQ2frFJYyvOeosx/1eQM7s9ptVil3P2Bj+ YTVN+PKeI79lfuoFXB/QlmSZ7vsoWuiTJ+s+yfj683c4IJgps4YM8p/KjG2RSjDz OmljKz8qxrPILb9uppKcS2ar+VOVgLgq8C/mzQVqC7hClZom1Qn1giC2vovy33bu 5wPRcbzRm6rM6J3W3/NcvIPsXrBnmOUXRTdr2m2Z/PTziS+bdDYUt/5UQNqMPjyb YFl5sf2vmI+i6XVTID3/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1751555913; x=1751642313; bh=03piMo6uuwgE1+w2WSC/O/y0sstcV5vlQ2U GLo9RjSw=; b=QIsb4YoYz7mLt4ivgR5OdSlCta9QvECWpR+xtXYeZK5/QqBBPkZ 50yNpoPL4ft8HjlKY11OthIe5kFPehPQ8cr05sWXI7HEchrD+TMacRYGeqq+Ejqo 6ye+ZUKUd4fA7K7FBlRgC+ynONjWK1Ssjgm/8R+GVXZsYWgxEwVwzbkTwki2LoGd BhwnIJSVxN3n9MsIBETNVc6hIu0QI7XHM5j0KQfD3Jtd9MQ8WBeSMxqRkJDPl/LH J9Koe7/lWhS/iulsxSSgATRn70mFQ4W3/A29gfaCw4c5p6dwncpE3LoyeqSgunX2 2bWwkw9J2szkH77KUF1TVfAXvDt9zWmm21g== X-ME-Sender:

X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddvtdeivdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesmhdtreertddttdenucfhrhhomhepufhtvghvvghnucet lhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmqeenucggtffrrghtth gvrhhnpeevgeevffffleeuteehgfdvhefghfeljedtleevveeuteekvdeufedthfeitdet teenucffohhmrghinhepshhtvggsrghlihgvnhdrtghomhenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgv nhdrtghomhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpth htohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepjeekleegkeesuggvsggsuhhg shdrghhnuhdrohhrghdprhgtphhtthhopehlrghrshhisehgnhhushdrohhrghdprhgtph htthhopehjphhorhhtvghrsghughhssehgmhgrihhlrdgtohhm X-ME-Proxy:

Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Jul 2025 11:18:32 -0400 (EDT) From: Steven Allen To: Eli Zaretskii Subject: Re: bug#78948: [PATCH] Retain the tag when making a page in EWW document readable In-Reply-To: <86a55l272h.fsf@gnu.org> References: <87o6u246lk.fsf@stebalien.com> <86a55l272h.fsf@gnu.org> Date: Thu, 03 Jul 2025 08:18:31 -0700 Message-ID: <87ldp5gv5k.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78948 Cc: jporterbugs@gmail.com, larsi@gnus.org, 78948@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Cc: Lars Magne Ingebrigtsen , >> Jim Porter >> Date: Wed, 02 Jul 2025 14:37:27 -0700 >> From: Steven Allen via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Retain the tag when making a page in EWW document >> readable. Otherwise, relative links aren't resolved correctly. > > Thanks. Could you please show a recipe for reproducing the problem? 1. Start emacs. 2. M-x eww RET https://stebalien.com/tags/emacs/ RET 3. R (readable mode) 4. Try to follow the top link and get a 404 error code. > Also, would it make sense to have a test for this? Good point, see attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Retain-the-base-tag-when-making-a-page-in-EWW-docume.patch >From 1db9f024b5767df8bbc61b6d0d43e65e334c4358 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Wed, 2 Jul 2025 14:32:28 -0700 Subject: [PATCH] Retain the tag when making a page in EWW document readable The base tag is necessary to correctly resolve relative links. * lisp/net/eww.el (eww-readable-dom): Retain the base tag in addition to the title/link tags. (Bug#78948) * test/lisp/net/eww-tests.el (eww-test--wordy-page): Add a base tag. (eww-test/readable/default-readable): Test that the base tag is retained. --- lisp/net/eww.el | 2 +- test/lisp/net/eww-tests.el | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 2f99234c47d..76dccaec9dd 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1225,7 +1225,7 @@ eww-readable-dom ;; "previous" pages. NOTE: We could probably filter out ;; stylesheet tags here, though it doesn't really matter ;; since we don't *do* anything with stylesheets... - (when (memq (dom-tag node) '(title link)) + (when (memq (dom-tag node) '(title link base)) ;; Copy the node, but not any of its (non-text) children. ;; This way, we can ensure that we don't include a node ;; directly in our list in addition to as a child of some diff --git a/test/lisp/net/eww-tests.el b/test/lisp/net/eww-tests.el index 18cbd272991..e9cfde4243a 100644 --- a/test/lisp/net/eww-tests.el +++ b/test/lisp/net/eww-tests.el @@ -39,6 +39,7 @@ eww-test--wordy-page "" "Welcome to my home page" "" + "" "" "This is an uninteresting sentence." "

" eww-test--lots-of-words "

" @@ -251,9 +252,13 @@ eww-test/readable/default-readable (eww "example.invalid") ;; Make sure EWW uses "readable" mode. (should (plist-get eww-data :readable)) - ;; Make sure the page include the and <link> nodes. + ;; Make sure the page include the <title>, <link>, and <base> nodes. (should (equal (plist-get eww-data :title) "Welcome to my home page")) - (should (equal (plist-get eww-data :home) "somewhere.invalid"))))) + (should (equal (plist-get eww-data :home) "somewhere.invalid")) + (let* ((html (dom-child-by-tag (plist-get eww-data :dom) 'html)) + (base-tags (dom-by-tag html 'base))) + (should (length= base-tags 1)) + (should (equal (dom-attr (car base-tags) 'href) "/foo/")))))) (provide 'eww-tests) ;; eww-tests.el ends here -- 2.50.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 00:05:05 2025 Received: (at 78948-done) by debbugs.gnu.org; 4 Jul 2025 04:05:05 +0000 Received: from localhost ([127.0.0.1]:55069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1uXXfc-0004hw-Gt for submit@debbugs.gnu.org; Fri, 04 Jul 2025 00:05:05 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:47470) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jporterbugs@gmail.com>) id 1uXXfZ-0004gG-S7 for 78948-done@debbugs.gnu.org; Fri, 04 Jul 2025 00:05:02 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-236377f00a1so5805475ad.3 for <78948-done@debbugs.gnu.org>; Thu, 03 Jul 2025 21:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751601895; x=1752206695; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=8zXOAtvNkYbsEFa2aTsd4Qr22wpTbQ09JU+rWM2QEOo=; b=SvkVYr8M5fJyIQREfGxpdQpmNNf7GMRhoghpL0IvX6wZG2XFhgCx5WrteFBmt8oRXW RjB1eo1n8XzapgHRqZ+C8YdbjQx6RAk7x4mWDHeoGgd2/NfE1pPPwaMyjw+CDOjHdM31 Hh1d41m43qEJ9XHDGSHZJAFlj6BUoZhub4uoCIhJSd+8P4QqmbGCIIRerOPXe3PpXxyV r+YSqQeBjTPD9pVzKD1snHUAsfZzgM8aXE5EnDGIX/r1u0wlv4AgsDTumph1ciEXg3Z+ CWD0qjq3JK1l4AmJbVB5/rqB6cN2kGO28BMlfCqSvpLPzmXADyfPoEfvuWuTlcQXtAT5 Z1Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751601895; x=1752206695; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8zXOAtvNkYbsEFa2aTsd4Qr22wpTbQ09JU+rWM2QEOo=; b=WPsDuyhfSXl6Cx73AT4dX5MvgeUbrS/jbugGsSC41HeIj+LfgP5nnR6E+6q5D+LApU 9WmwExvRT+5596wGISJgAkk5uoei5yWrWbeklsPoN5xwyZVbB/Y+30V96GnpyKGch/Dm OOyXXuG/X978IcZwjDKTcpvwq1h3y4QBCdheVp1qiK4EBFwBvBcbIP2Agj03cduypnIw PApfjpUnVeZbQTng7y5ZFGfsQ6g3JJ7FDsdbxQ7KOTS14fBaU/GFXQaXLtuzeH4SanNp orjXi8J43DVaWITtTlHVE/64RcMboh4sjAFsh2OgfjvysJO2HNXdO4PbxZZhXjnVErHw lDxQ== X-Forwarded-Encrypted: i=1; AJvYcCXVZIASPmGk0llrVnixxuqcx3HFn0j5/3ZEfCKMcO1NPPMjJVG1WHrqlWt/ovqz2ECojbN9gl+TVe7x@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw9g+awIIPW0b4J6fEIy3JDAfvQWnm8YotOt4nBmllDPOUvKw+6 dkZdJ7TmmHA6SWYhnum12v+B/JpF6+Vq7y5/ApIZV6yBV9gPveZHm563 X-Gm-Gg: ASbGncu2gPx7nU/WnRrwYxkfOPYToUJc02U0ZiSx+xp/7uN1+XLZvQklXQ4HxwMVadx MbzbfuFlbzbeq6APliNkIB+HofcRX3qo71fvn0KduFwLiHwN3iAtZzV++44lW3lnoBkpCdbEddg BBW9t37hWgcPguegj7lyHHjq8PddSloiDk8luJU6c1qoOlWP33TCPxApzcri2fgJ6XoJUqGVnM1 eB8553E24av1SNGVafV4Q5G4A6dtEU6uNQc6uQW9LQomiWhEOERuAu0J6MEBa+76sYoiGMHpdze pQ+5+lZiJE8Rs/cry4i5Gw7SCLOba+Ur0y+btD0h7gh5IiEGdvnmBNW0EuXEQ2ju3EU0MJF2x4g GMvLiiGOJUVDjS0zMerE+PxP8yT2pPM9zJ6Jo9GnD0g== X-Google-Smtp-Source: AGHT+IGahQO6RuqXlUIm6MYaOeI/PxArjlHQuZNOJlmFyl9QfKtA0OkusIzv1l+Jnb0N0TQ4QiLrHw== X-Received: by 2002:a17:902:d484:b0:234:986c:66bf with SMTP id d9443c01a7336-23c860673edmr18699065ad.11.1751601895485; Thu, 03 Jul 2025 21:04:55 -0700 (PDT) Received: from [192.168.1.2] (syn-076-168-144-128.res.spectrum.com. [76.168.144.128]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-23c845be93esm9708915ad.247.2025.07.03.21.04.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 21:04:55 -0700 (PDT) Message-ID: <4ed08bdf-fd32-9697-2560-00421e13bcdd@gmail.com> Date: Thu, 3 Jul 2025 21:04:52 -0700 MIME-Version: 1.0 Subject: Re: bug#78948: [PATCH] Retain the <base> tag when making a page in EWW document readable To: Steven Allen <steven@stebalien.com>, Eli Zaretskii <eliz@gnu.org> References: <87o6u246lk.fsf@stebalien.com> <86a55l272h.fsf@gnu.org> <87ldp5gv5k.fsf@stebalien.com> Content-Language: en-US From: Jim Porter <jporterbugs@gmail.com> In-Reply-To: <87ldp5gv5k.fsf@stebalien.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78948-done Cc: larsi@gnus.org, 78948-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit@debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 7/3/2025 8:18 AM, Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Good point, see attached. Thanks. This all looks good to me, so I've merged it to the master branch as f10bf71151b. (I hope... I got an error while pushing, but I think everything's in sync. I guess Savannah's under attack again.) From unknown Fri Aug 15 04:02:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request <help-debbugs@gnu.org> Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Aug 2025 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator