From unknown Sat Aug 09 13:17:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78945 <78945@debbugs.gnu.org> To: bug#78945 <78945@debbugs.gnu.org> Subject: Status: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' Reply-To: bug#78945 <78945@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:17:49 +0000 retitle 78945 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-= file' reassign 78945 emacs submitter 78945 Alcor severity 78945 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 02 15:12:06 2025 Received: (at submit) by debbugs.gnu.org; 2 Jul 2025 19:12:06 +0000 Received: from localhost ([127.0.0.1]:39455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uX2sH-0001e0-BA for submit@debbugs.gnu.org; Wed, 02 Jul 2025 15:12:05 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54866) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uX2sC-0001cA-V8 for submit@debbugs.gnu.org; Wed, 02 Jul 2025 15:12:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uX2s5-0000s1-7p for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2025 15:11:53 -0400 Received: from tilde.club ([142.44.150.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uX2rt-0005yw-U0 for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2025 15:11:52 -0400 Received: from osiris.tilde.club (unknown [IPv6:2001:9e8:7dc:4e00:222:c11f:3316:598d]) by tilde.club (Postfix) with ESMTPSA id 953652236052E for ; Wed, 02 Jul 2025 19:11:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 953652236052E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1751483494; bh=KjcAEJnMvnAZTqtkwhN+zpoF8lumRg4k0k4SByJigl8=; h=From:To:Subject:Date:From; b=o+pL89I1hhDDOjAghWUzJD2lKkmQSB2YhbwsZrzoa/Lw85kjnkHxD5MhE49DUPHvY 4vOmgCel8tOriIZW1Aa5Wczir/upms7LIyfpBV13BSrTc0V43ZAg5ONw3jLfKRbfFR LLG9y4zmpaezL+D8zMJHfr33kDxZp0B5uM/oAQdg= From: Alcor To: bug-gnu-emacs@gnu.org Subject: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' X-Debbugs-Cc: Date: Wed, 02 Jul 2025 21:11:32 +0200 Message-ID: <87tt3uflwb.fsf@tilde.club> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=142.44.150.184; envelope-from=alcor@tilde.club; helo=tilde.club X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.237, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Steps to reproduce: 1. Start a fresh emacs -Q process 2. Open some directory in dired via e.g. C-x C-f /tmp RET 3. Rebind to dired-find-file via (define-key dired-mode-map (kbd "") #'dired-find-file) 4a. Try C-x 4 4 and click on a filename OR 4b. Try C-x 5 5 and click on a filename Expected behavior: The file is opened in a new window (if 4a i.e. C-x 4 4) or a new frame (if 4b aka C-x 5 5). Observed behavior: C-x 4 4 or C-x 5 5 are ignored. `dired-find-file' always opens the clicked file in the same window. In GNU Emacs 30.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2025-06-29 built on lcy02-amd64-115 Repository revision: 3c103e7c295c18cc75553fc09b3d603dab7b6703 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12302006 System Description: Ubuntu 24.04.2 LTS Configured using: 'configure --prefix=/snap/emacs/current/usr --with-x-toolkit=gtk3 --without-xaw3d --with-modules --with-cairo --with-native-compilation=aot --without-pgtk --with-xinput2 --with-tree-sitter 'CFLAGS=-isystem /build/emacs/parts/emacs/install/usr/include -isystem /build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu -isystem /build/emacs/stage/usr/include -O2' 'CPPFLAGS=-isystem /build/emacs/parts/emacs/install/usr/include -isystem /build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu -isystem /build/emacs/stage/usr/include' 'LDFLAGS=-L/build/emacs/parts/emacs/install/lib -L/build/emacs/parts/emacs/install/usr/lib -L/build/emacs/parts/emacs/install/lib/x86_64-linux-gnu -L/build/emacs/parts/emacs/install/usr/lib/x86_64-linux-gnu -L/build/emacs/stage/usr/lib'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: de_DE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Text Minor modes in effect: whitespace-mode: t display-line-numbers-mode: t goto-address-mode: t which-key-mode: t winner-mode: t windmove-mode: t recentf-mode: t global-auto-revert-mode: t fido-vertical-mode: t icomplete-vertical-mode: t icomplete-mode: t fido-mode: t desktop-save-mode: t minibuffer-depth-indicate-mode: t delete-selection-mode: t repeat-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win emacsbug message yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums disp-table whitespace display-line-numbers goto-addr thingatpt gnus nnheader gnus-util text-property-search time-date mail-utils range mm-util mail-prsvr doom-themes-ext-org doom-themes-ext-visual-bell face-remap doom-nord-theme pcase doom-themes doom-themes-base which-key finder-inf use-package-ensure winner ring windmove recentf tree-widget autorevert filenotify icomplete desktop frameset mb-depth delsel repeat edmacro kmacro use-package-bind-key bind-key easy-mmode cus-edit pp cus-load wid-edit use-package-core site-start comp comp-cstr cl-extra help-mode comp-common warnings rx doom-themes-autoloads erc-irc-format-autoloads markdown-mode-autoloads rainbow-delimiters-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 495938 18679) (symbols 48 24742 0) (strings 32 134936 4843) (string-bytes 1 3328789) (vectors 16 36024) (vector-slots 8 432373 11360) (floats 8 525 7563) (intervals 56 459 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 00:47:00 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 04:47:01 +0000 Received: from localhost ([127.0.0.1]:41357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXBqd-0002aT-Iq for submit@debbugs.gnu.org; Thu, 03 Jul 2025 00:47:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39922) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXBqa-0002ZZ-HQ for 78945@debbugs.gnu.org; Thu, 03 Jul 2025 00:46:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXBqU-00057K-9D; Thu, 03 Jul 2025 00:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i6JThgtT1a+ZBQOGkSod/oQ0r1UJm/ONvLEuBSTyOSk=; b=FzZQFsywJJSY ZwtWQHKjhHxy9o/8Jw+ZNfakCJpocFq+23UAFTXiw+gV1scO+xbet/pHAjnVvQYMYNEctnAUvA4CZ HBb2+5AJFQYAQBodGej6177DhqruVYNeMQPfSYAsr2Ehn+lkTksEMRXGakxY3QxRvZ5K7OE6Xh3Sf SE3lP7B5LB7WB1mZGYFCwODjZZ9/wltl/NvqekXOQ8Js6swyFe9E7TNbD5+KN7VibqKH4K3E1jgRC 0J23ZhsQ4/TyvfPZCE/ff1G4Ba6Mu03RK/xE1hnhwsbBJhzEIASpqiLL9/A0q+Cpmg8RomuB7Lijj AfQmkB9mwjeJIcVTUFhz5g==; Date: Thu, 03 Jul 2025 07:46:43 +0300 Message-Id: <86ikk9285o.fsf@gnu.org> From: Eli Zaretskii To: Alcor In-Reply-To: <87tt3uflwb.fsf@tilde.club> (bug-gnu-emacs@gnu.org) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 02 Jul 2025 21:11:32 +0200 > From: Alcor via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Steps to reproduce: > > 1. Start a fresh emacs -Q process > 2. Open some directory in dired via e.g. C-x C-f /tmp RET > 3. Rebind to dired-find-file via (define-key dired-mode-map > (kbd "") #'dired-find-file) > 4a. Try C-x 4 4 and click on a filename > OR > 4b. Try C-x 5 5 and click on a filename > > Expected behavior: > > The file is opened in a new window (if 4a i.e. C-x 4 4) or a new frame > (if 4b aka C-x 5 5). > > Observed behavior: > > C-x 4 4 or C-x 5 5 are ignored. `dired-find-file' always opens the > clicked file in the same window. I cannot reproduce this. I tried both in Emacs 30.1 and in the current pretest of Emacs 30.2, and I get the expected behavior in both cases. I'm not on Ubuntu, but I doubt if this could be specific to Ubuntu or to X. Can anyone else reproduce this? P.S. Your Subject says dired-mouse-find-file, whereas the recipe uses dired-find-file. I tried both, and I get the expected behavior with both. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 02:13:26 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 06:13:26 +0000 Received: from localhost ([127.0.0.1]:42042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXDCG-0007OB-SP for submit@debbugs.gnu.org; Thu, 03 Jul 2025 02:13:26 -0400 Received: from tilde.club ([142.44.150.184]:57030 ident=postfix) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXDCE-0007NC-5D for 78945@debbugs.gnu.org; Thu, 03 Jul 2025 02:13:23 -0400 Received: from osiris.tilde.club (unknown [IPv6:2001:9e8:7e6:f600:8be4:cac:8001:499c]) by tilde.club (Postfix) with ESMTPSA id DE9CA22363AD5; Thu, 03 Jul 2025 06:13:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club DE9CA22363AD5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1751523198; bh=dNdQULwteMhMNH4LyVW/mjqVwGxbJRLndBm1AnRaQ4Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gmL4Bwrjsyl3a+Sbe/B5PtJtpMbYvzWNOVyXgdB8iwaQwkL9g4yxqM93g/UPva1Rh Io6LI+h9lWPY/YRX0gjDGnKkMQoIfvG0N2h8/Z1/c+wRIffJJVMEbRSEzaJWst0aXY aPQ5SjcOF+PGrL0U8nfRCilwtRaLIyX6kgKE/QLw= From: Alcor To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <86ikk9285o.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Jul 2025 07:46:43 +0300") References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> Date: Thu, 03 Jul 2025 08:13:15 +0200 Message-ID: <871pqxajk4.fsf@tilde.club> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Eli Zaretskii writes: > P.S. Your Subject says dired-mouse-find-file, whereas the recipe uses > dired-find-file. I tried both, and I get the expected behavior with > both. I apologize, there is one important distinction in the bug report I should have made: I meant "single-click" by "click", i.e. in Emacs jargon. Clicking directly works correctly and does exhibit the expected behavior. The issue here is that C-x 4 4 and C-x 5 5 do not work when the is translated from . As for `dired-mouse-find-file' vs. `dired-find-file' - I have meant to write `dired-mouse-find-file' in the original message, but the behavior should be reproducible with both. For completeness, the corrected reproducer looks like this: 1. Start a fresh emacs -Q process 2. Open some directory in dired via e.g. C-x C-f /tmp RET 3. Rebind to dired-mouse-find-file via (define-key dired-mode-map (kbd "") #'dired-mouse-find-file) 4a. Try C-x 4 4 and single-click () on a filename OR 4b. Try C-x 5 5 and single-click () on a filename I'm not sure how I should describe/retitle the issue - maybe "C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' using a translated keybind"? Also, I'd like to mention that this behavior is not just limited to GUI Emacs. Trying the above with `emacs -nw' with M-x xterm-mouse-mode yields the same results. Cheers, -A. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 02:36:56 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 06:36:57 +0000 Received: from localhost ([127.0.0.1]:42139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXDZ2-0002Nb-GA for submit@debbugs.gnu.org; Thu, 03 Jul 2025 02:36:56 -0400 Received: from mout-y-111.mailbox.org ([91.198.250.236]:33718) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXDYz-0002MP-Ej for 78945@debbugs.gnu.org; Thu, 03 Jul 2025 02:36:54 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4bXn9T0VQSz9xqg; Thu, 3 Jul 2025 08:36:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1751524605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LrqqjySlMo3y0oZU+cvVPHDdlBbItSUg9RV/uE/KHOk=; b=dwRaOtdLSK+wdPBOOKCsiGnJw/fwcf67mEWXhR2V9906I+y+cSceMuYrzJgoUN7+SybotO SM/qJqpc1m3tHNPJkl994CE4gwtF8GtT/IRdEfddKmFMTituu2J1VAwV9IsscrT8R1ldWK J+u9RqADrpNL6TIM8DV3M2ae/vFldB6XzNm06eDHr/Ij2htkkLreOyDSIN5vSEZba8mLlN czJNbNXRv/T6P7aJQAaejSqMXYfBGTaCaHihbpVUMbw+4DXHDACJsTGqLdWIEZo/mLroFP GtD3N74lpchjyHK7S69Iy0cm/xFD49RIabWWiKN28vCLQqIxywUsEF3+ZL7kRQ== From: Juri Linkov To: Alcor Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <871pqxajk4.fsf@tilde.club> Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> Date: Thu, 03 Jul 2025 09:35:18 +0300 Message-ID: <87qzyx3hp5.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bXn9T0VQSz9xqg X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) > For completeness, the corrected reproducer looks like this: > > 1. Start a fresh emacs -Q process > 2. Open some directory in dired via e.g. C-x C-f /tmp RET > 3. Rebind to dired-mouse-find-file via (define-key dired-mode-map > (kbd "") #'dired-mouse-find-file) > 4a. Try C-x 4 4 and single-click () on a filename > OR > 4b. Try C-x 5 5 and single-click () on a filename Thanks for the corrected reproducer. The 'C-h l' (view-lossage) shows that 'mouse-drag-region' gets in the way: C-x 5 5 ;; other-frame-prefix ;; mouse-drag-region ;; dired-mouse-find-file C-h l ;; view-lossage If there are no better ideas, maybe it should be ignored explicitly: diff --git a/lisp/window.el b/lisp/window.el index af7680e4486..3e245741caa 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -9672,7 +9679,8 @@ display-buffer-override-next-command (> (minibuffer-depth) minibuffer-depth) ;; But don't remove immediately after ;; adding the hook by the same command below. - (eq this-command command)) + (eq this-command command) + (memq this-command '(mouse-drag-region))) (funcall exitfun)))) ;; Call post-function after the next command finishes (bug#49057). (add-hook 'post-command-hook postfun) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 03:30:16 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 07:30:16 +0000 Received: from localhost ([127.0.0.1]:42284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXEOe-0001lU-19 for submit@debbugs.gnu.org; Thu, 03 Jul 2025 03:30:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48764) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXEOa-0001gr-SO for 78945@debbugs.gnu.org; Thu, 03 Jul 2025 03:30:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXEOT-0006Fc-Iz; Thu, 03 Jul 2025 03:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LL9UBOie/prcnOu6xtAv1Ici5lc0bGRp5a1mKOLy/PM=; b=cmftjY/FadN+ whqOg28kZRnC8c+CHL8c6ws0ENtjyQj1rF8uCpHXU1vT5TejE3CSpMmevxEweGSWAsDOF7xW7wKiR VUwkRTKGTz4LyXA+z3NirJaqcfiTUZcrdWyCc/3POmIN0euqrDEZaiLSQP3RhEZIBjjA1h8PMPEJo 6/1fn531OzlGocugYOJ4wsYDNL02hsUSc+QCA6aBDr76+ras32ULBULlBjU/1UWhxxGPY0VrV9ENI OlCmoJRVBqSsYERrKFQ9bolZUReLh6pttPVuOn1qiyVHfdqASxYTurNknc59HpFOQQ6alPw0CYQAR 8sYlWYdk6Tny1U/+gbb7hA==; Date: Thu, 03 Jul 2025 10:29:58 +0300 Message-Id: <864ivt20ll.fsf@gnu.org> From: Eli Zaretskii To: Alcor , martin rudalics , Stefan Monnier , Juri Linkov In-Reply-To: <871pqxajk4.fsf@tilde.club> (message from Alcor on Thu, 03 Jul 2025 08:13:15 +0200) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alcor > Cc: 78945@debbugs.gnu.org > Date: Thu, 03 Jul 2025 08:13:15 +0200 > > Eli Zaretskii writes: > > > P.S. Your Subject says dired-mouse-find-file, whereas the recipe uses > > dired-find-file. I tried both, and I get the expected behavior with > > both. > > I apologize, there is one important distinction in the bug report I > should have made: I meant "single-click" by "click", i.e. in > Emacs jargon. > > Clicking directly works correctly and does exhibit the > expected behavior. The issue here is that C-x 4 4 and C-x 5 5 do not > work when the is translated from . > > As for `dired-mouse-find-file' vs. `dired-find-file' - I have meant to > write `dired-mouse-find-file' in the original message, but the behavior > should be reproducible with both. > > For completeness, the corrected reproducer looks like this: > > 1. Start a fresh emacs -Q process > 2. Open some directory in dired via e.g. C-x C-f /tmp RET > 3. Rebind to dired-mouse-find-file via (define-key dired-mode-map > (kbd "") #'dired-mouse-find-file) > 4a. Try C-x 4 4 and single-click () on a filename > OR > 4b. Try C-x 5 5 and single-click () on a filename Thanks, I do see this, and I added the relevant people to this discussion, in the hope that they will explain why we lose the effect of "C-x 4 4" while redirecting mouse-1 to mouse-2. > I'm not sure how I should describe/retitle the issue - maybe "C-x 4 4 > and C-x 5 5 do not work with `dired-mouse-find-file' using a translated > keybind"? > > Also, I'd like to mention that this behavior is not just limited to GUI > Emacs. Trying the above with `emacs -nw' with M-x xterm-mouse-mode > yields the same results. > > Cheers, > -A. > From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 06:09:34 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 10:09:34 +0000 Received: from localhost ([127.0.0.1]:44144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXGsn-0006CH-Ny for submit@debbugs.gnu.org; Thu, 03 Jul 2025 06:09:34 -0400 Received: from mout.gmx.net ([212.227.15.19]:36315) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXGsk-0006BB-La for 78945@debbugs.gnu.org; Thu, 03 Jul 2025 06:09:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1751537349; x=1752142149; i=rudalics@gmx.at; bh=EymmMNfVaum21YE6jtNg2lDNTFo2TFUf0NZie9cPyFo=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=pW8LWd3rxKfJG3TCizG4PpWOMHnz9Brr9yYb4hHfdKaJfrTfMW7MLGJ7ZuuqrpB9 rNCeDKw89xStxGHy3Ha+xppCz/hkPHYLKUSkGwR7mXBZeaDUxy2dxu5TRJ3C1RCPX gqvwBVLqfz3jDepdop+tfSjp57pf3Aw6JgVx+nnN9QBOQGNZjxf0S52ZU3EwjTHDV cN33Tb5Y161MPxGYNw+GdLabNyS1r6/8OTWZUjWZKU7lUSvSHxr1OQCWrtVsy13hQ k4fJ0CpBqpyrj2AbyJY25MO2zuXaiKLVzX/XtDm4hDgsnYQV6mNOzm06Xhz0V/1kS FoIb1lQuXCoe3OfVLQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.8.154]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmlT2-1uwBVb1RPq-00lmyM; Thu, 03 Jul 2025 12:09:09 +0200 Message-ID: Date: Thu, 3 Jul 2025 12:09:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' To: Eli Zaretskii , Alcor , Stefan Monnier , Juri Linkov References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <864ivt20ll.fsf@gnu.org> Content-Language: en-US From: martin rudalics In-Reply-To: <864ivt20ll.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:SvuXivXSnFiCz84yiekNpXnU1c0mYhKEnR3e65JOhbhSslSu8f+ UA2Ww3wscRwsuRTZR+aBn/Kh8sXGYfG3Ilcw+2yndcCUl4RT6ipB7lwFTnqBzPAtZXOokKr J9sVDbQesW7HUIPl8dfN5P8kWGBpMbds554k0tZ3qkddn8oghyI3b4Pt+93hjF93ax6Si5m EY0YBndVXpW1vgDR/M/1w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9VOnOYWP/rU=;Az4pW9kI0/hCvWEWfeEp+oA3NWG /JrNHKUYuWVtT475ep16ulOM8nd4DwRGT9+EnO/gFcr+VzgJQLQoyw4yctKONMzBozpJy2Ycy keMdHSFHc1U6nMzHpDJoDl8SRKbNv/+pjieD5hamRIiFHcOvHg6H1+GRjK2h8vu9NegzWyq+E I29eqqCuAahKlUfd7MeXLD4GpuuTps0LLPMGdeX8XH+HGj41jKB7Y9QjZEzrnES1uYOqWcLAn 3+zuK2N4VSY8FeUWNM5pxmP+PeXZxxUQC4mv+V9/smxgxUzx7WlhHjULyfrurAPPNR41G1SFR r3tl7V+ksYkWMnTegN6Na16T+8xviU+APdN9VrekVTlNr/wxWDHvthZ/J+tHvba5FlA6GM91E mFYKaSjz9KLEEhTMGjMSdnewX9UiRfk4j4nnxPaNWH+I3l+ZNZbIPGIGUu1ikUMPtBeL8vDVU U1lceQpR6NAJK3cM0mPFyq3bqEwgLtvzQkZGPRXMA/bpfoCMkevCrXLKhZ8eU/DFy1KRL05aw XDwNpWMwRjNmQFKCpzMr9tWyHYMXFtYy6EDnlvDAOwOGHMU90itDK+hpQPEIMBHcVMeHbrf8C wHIG4/Pb4DEklY9LMOI9zswx/uvhhaSziSdEbVNwYGzPLhktHkvm2xABWmhxIxtPPSgePAf2c Prw8whv/kum0YGfvM9Rk2JvJebQ29RSEGZ5NF1QQxUbFeET1yk02JI36m4noEdCPoOSosKicw r4o6/Ld6PLTZ6l/oR4Yy8feRX1CCnHAJK2gXrAMoAqHJ9XHDkOoSRaG6btUcdQ9ouenllcTHP 5aQl6hmq1qBxvq36ffVy2/2h45CJQIvQga9TqPuFwkF8/V0amaMq5nQtUr4p92QORsdtxZ0Ja QL17VAHI1wq2XJDyd0SQMepcnxMmsYdbNzcMJ6dbGopnuNrBQVWiC/f7dcCbqm4TWThjyqeoO cT1VVfBb65lJBj6QTsrhYzQ8we59rU0/ModabEiTVoPGyZJlmGvFMD8yyNyVCXmMkMx5dx5rx 29Cy1mvLeP2FZA+d71TRNuq1YfMveBug9RcR9DleLcx6gb3n/ywU0hF7EBW6PsORel5ixs+/a wT/svInqVGN6yFKwnzuuhsWOr0jaYdzNjM8/CFToWvlymvM7ZcQy8pl3ij3naW9oJ1LtcYysn pr5TU8dzdItiEudDv0nK29TORzM5ZE9mwd5JlVJd/5bb81F0HvdREI8Mig5v35NrVBfQoZmhq EZxi1S3sp1bxzA8P9Re3x0VO6mlpz8+9JStsr06wYotvHpsPQY9cU+Ir82jzYFPVJQZsXTYSq w7z+S0OQa6ZetRbs60HHFMJ+PKzaQprOw5WEQcEOugTlhjeOfHpP9eoVbmyw/DAQhxo06h4Mr MMr9JW2Rh18Hs6E5vKo268nB8UljNgeuboN+mWkYFWgviweaA7yv9fVzQA1hISbZMpDlVjqfP vAQ1DgZLCoSNEuO0SXKORyTXlYl8C3/6fK9RWWYHXmw0Yepq5Qng0KSbZbKBQ4GiocO4f5DY4 1oVcmS//Yk7ljq6AbiCHTVSttZKDodkCrh8INAeECrrIFLpEPY7rqj7qV3oNLQD9GvhuukJcJ M2PUtjk2rRlCfsfINwrm8ofni4lyvx0Ct98X6m0/C55R166fi8wQuZ74WxmmCFwZkSTh/8G+p Lio1xUXdnVou6gp9tGuxhgPS93jvPaUxB/Nmq/ZKm3rbNrqvbWyZ9gBSevToNZwWSqd8KD8BB /h+jDyyk20EbP2ytfrtQi1EY4Azco+AkLHrhP3eseYqhhKO1E2kbaHDJzOs3qAY5LB59Sr5Li M9kFjT6Ix9BeS9Ww4u3ctSjakQRJ4+IYDSunbcHUMNWdRJ02pJDJp0ygqU+HBbSMW2oKX7XpU OKBunoBcpqoUp8HYANoNNoUD6JweZF4JBOIwM6DbhJZ9aUJxnJlyfzbUnfGxSSoChLnWMgfd+ 3LyjrgZvM05uPKFy76aeaUhq3nSlk17KvmzNU2eDTUtvvRHo5N6NM8EPW+iI9Wwi+BS8Q5lzJ iQtSDVbyG6YYihF87H2BpKU+6lAm7oITpWVOCOhBqPVX35Le1pHaNxqAQRSfoLyNkuRpODCrf lU0GcUSdSQzs63lLRgReCIQ8l1xrJEEhYfbbHOeCEc5DbgYxFScUagdoWO8fgucENink5Rlh6 t37xhIoAJx0igQegEwyb6s94XoRdm1rH9Vp+fzNiOmOQzdonfRvKNgNoESTIy/mkuez7XoYnR nlcJXLwc+GH1n/n8PObj++P5/LqAjovhdQYpNRB6sIlB1aHPDI6x10kk9HcBqiZRo8goWbQ+R SHwx/hDC4DtLs2GLn8ugzO8GdcJrKGnebob2Ugyor3EBa1M2MBeoZl9pX6aaavqn9hRXp0ivO 819mCDG20kGORRqzAosOMOxMVtP/RoStWpTfZ2LGs8TaBzwdcsRtwyRC0pyUXPVTLQ4x9wDx9 qrdJlwIB9FW0/z4BR5i3wbvs8omBuIRrht4ia2akJGjuu/VbesR5nsVyPg/oWgjT/zJXBX5e6 rZK4jsSJdiDg19/MI3RsAwpaPxLu+0vnHJ6/xwHqIrItx31GPqJ93q43mYh9tN9+HNEcF275e IB91oHsuYJXAjJOqExra5Ff7SgoptL34OXKSm3jMUD9uQXdPRE6Z9OY5LJsqSd+lF8B6CXY/Q YIdbfjSGTJqA1BoNDaDgz5VJRPKwKWEyM9Qio6XtaCcDGJ0/jXvaT/pRC2riAyD9rhWQAWpCm X+T7ecXcqpSnTz4GgxyS/2jeDOgGo42Z1u2V3Wtw2jf4nAi05j4CrqB3HV0EOxGAUklYVgLFz kaRooxEF7YyyMl8+JsJwV3QzcnT2VhILJEo2fgTBgQW948p7DDVipDWHve/v8LVfLokGVWcNz ryLmwnBNG69zwvOwn55HpikSmrN/f1MPJn9WPD/lMZeoiz2hVa3aLZnp9XyKEa0R65jh0JTsP ejiQlvqnLvqoaiFaY6K8kjL27ybUkuaX8igciMYNtJC7oCDKXfHht33sD80AlwEmqmjZqpQ/E hAd028SnSyCtTYn496lFsDiRUOQhwtDI7G544cUv4v0PTaGABrewT2OQiReNUl2tHpnS+8Knk 4hTlbpwfpFdVBHeCUClTtKdnhnjN/S9GBzyMGcZGW6UP0bWyZ8mZhYxvPhYoSuisfWkunkerj fwCokUY09aN72Snk1iJH9RpmOHohBqi2lb95Z6SrWE3CLY/0F1Ou9lknDEa4qgjVTqLZ1g3EX KdRiJXn6uPWly2+BtgPf4XbmMxqUjZG1G0vWdPjaFOHPi+LRa6AMFaj53YL/DNjx72MQEFBjm h6EpX4Yvu0V2K6yDdy97+fYxSRHzJU6VvJkLwUr4vlpiflNdxsP1ofFvdWEcia09431UFlf X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) > Thanks, I do see this, and I added the relevant people to this > discussion, in the hope that they will explain why we lose the effect > of "C-x 4 4" while redirecting mouse-1 to mouse-2. I cannot contribute much. Here rebinding mouse-2 is not necessary to show the faulty behavior and Juri's patch fixes the behavior for mouse-1 and also for mouse-2 if it is rebound. And the standard behavior here is to always show a buffer for the file in a new window, that is C-x 4 4 would not be needed anyway. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 12:55:31 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 16:55:31 +0000 Received: from localhost ([127.0.0.1]:50915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXNDe-0001gH-OL for submit@debbugs.gnu.org; Thu, 03 Jul 2025 12:55:31 -0400 Received: from tilde.club ([142.44.150.184]:55596 ident=postfix) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXNDZ-0001fF-3V for 78945@debbugs.gnu.org; Thu, 03 Jul 2025 12:55:26 -0400 Received: from osiris.tilde.club (unknown [IPv6:2001:9e8:7e6:f600:39e3:d398:36ff:de33]) by tilde.club (Postfix) with ESMTPSA id D9175221A49F5; Thu, 03 Jul 2025 16:55:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club D9175221A49F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1751561723; bh=bqGwc/+x2Um1cf1I2dML2JzxaS3eR5xFerlI254yZbY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=rUZ0DHUVh0bU4aZQCxOjRfEXTH/08nCMrowHLft2b+qzqvI0+8t1eVR5vXm9gWXqh XSYFivuVqHNz8Z7lM8P84F394IIJgnZwtVEX7liQXG1b4OhH7vDPR6othH2IwnnPLL ZJhmxs19BUnlOwbcM+EmKScUzpeMn75JrqquUWNw= From: Alcor To: Juri Linkov Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <87qzyx3hp5.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 03 Jul 2025 09:35:18 +0300") References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> Date: Thu, 03 Jul 2025 18:55:21 +0200 Message-ID: <87bjq1w6x2.fsf@tilde.club> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Juri Linkov writes: > Thanks for the corrected reproducer. The 'C-h l' (view-lossage) > shows that 'mouse-drag-region' gets in the way: > > C-x 5 5 ;; other-frame-prefix > ;; mouse-drag-region > ;; dired-mouse-find-file > C-h l ;; view-lossage > > If there are no better ideas, maybe it should be ignored explicitly: > > diff --git a/lisp/window.el b/lisp/window.el > index af7680e4486..3e245741caa 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -9672,7 +9679,8 @@ display-buffer-override-next-command > (> (minibuffer-depth) minibuffer-depth) > ;; But don't remove immediately after > ;; adding the hook by the same command below. > - (eq this-command command)) > + (eq this-command command) > + (memq this-command '(mouse-drag-region))) > (funcall exitfun)))) > ;; Call post-function after the next command finishes (bug#49057). > (add-hook 'post-command-hook postfun) Thanks for the above patch, I can also confirm this fixes the issue when applied on 30.1. I just have a question regarding possible side effects: I understand that this change ignores `mouse-drag-region' events. I'm not sure whether it's possible to bind functions to these events, but if yes, wouldn't this preclude any commands/functions bound to `mouse-drag-region' from being affected by C-x 4 4 or C-x 5 5? Cheers, -A. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 13:36:13 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 17:36:13 +0000 Received: from localhost ([127.0.0.1]:51286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXNr2-0007ow-GW for submit@debbugs.gnu.org; Thu, 03 Jul 2025 13:36:12 -0400 Received: from mout-y-209.mailbox.org ([91.198.250.237]:58996) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXNqw-0007n4-Dw; Thu, 03 Jul 2025 13:36:10 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4bY3p600Cfz9yYJ; Thu, 3 Jul 2025 19:35:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1751564158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i2L17Ixjde4vox7MpOiRaU71XKCavyN8bgWmqSyB1Jo=; b=ss1Muhrej5PaBP2inIbtfJdVi6P+6T/Uh881TZxk/tei++QzqV4PVzLVWooqEB++Fj0xNO XQQU5RvbXwTj9bqKwIkS9ayQOsjh7fYBsK16pSPUOdS2EJCUNfBAYykLTe3KG6qhd4D3r9 cIx2bdfwYO72W5qGxEiEaRcIh1a57r+VHt+CozJ6Gpeej99knwqQRO8tu0Ol80EspwLnHz +3H2dvsKCBpgRdLNqrJ8O3QH8JC1fuPCL3kJ3XXoLNcaFLYau4IJfkxF5T25fzeR8g6IJq lPElJ5HPTDnJa1HDo46IC+g/JCVtxE1zJzBT1AxnuOzlKdn3atcBLR3vhQcAHg== From: Juri Linkov To: Alcor Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <87bjq1w6x2.fsf@tilde.club> Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> Date: Thu, 03 Jul 2025 20:34:42 +0300 Message-ID: <87ldp5jhzh.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) close 78945 31.0.50 thanks > I just have a question regarding possible side effects: I understand > that this change ignores `mouse-drag-region' events. I'm not sure > whether it's possible to bind functions to these events, but if yes, > wouldn't this preclude any commands/functions bound to > `mouse-drag-region' from being affected by C-x 4 4 or C-x 5 5? Indeed. So I pushed a better patch that handles both down-mouse-1 and mouse-1 events. `dired-mouse-find-file' is on mouse-1/2, so it's not ignored anymore: diff --git a/lisp/window.el b/lisp/window.el index af7680e4486..068b4d61f79 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -9672,7 +9679,10 @@ display-buffer-override-next-command (> (minibuffer-depth) minibuffer-depth) ;; But don't remove immediately after ;; adding the hook by the same command below. - (eq this-command command)) + (eq this-command command) + ;; Don't exit on mouse down event + ;; in anticipation of mouse release event. + (memq 'down (event-modifiers last-input-event))) (funcall exitfun)))) ;; Call post-function after the next command finishes (bug#49057). (add-hook 'post-command-hook postfun) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 03 15:14:58 2025 Received: (at 78945) by debbugs.gnu.org; 3 Jul 2025 19:14:58 +0000 Received: from localhost ([127.0.0.1]:51852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXPOb-0007KC-GH for submit@debbugs.gnu.org; Thu, 03 Jul 2025 15:14:58 -0400 Received: from tilde.club ([2607:5300:203:31b6::115]:35452 ident=postfix) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXPOZ-0007Jq-8K for 78945@debbugs.gnu.org; Thu, 03 Jul 2025 15:14:56 -0400 Received: from osiris.tilde.club (unknown [IPv6:2001:9e8:7e6:f600:39e3:d398:36ff:de33]) by tilde.club (Postfix) with ESMTPSA id 7F63F22316523; Thu, 03 Jul 2025 19:14:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 7F63F22316523 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1751570094; bh=MeGsQgB6oLChhChzRHBPHmxwYvzvx3LLg43XUIW/3TE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NTWDh73IhgN5UZbXaeEuKVM1UoJjqYdh3mPO9IjXCZX/4i/Jyy4v4YGdVXnXAuRT2 1aoXllHe497tp5Q1uubmN2YkcWJINz2TfpoQeOUeI+OU50RNC8KcTOq0P6RFmRmo1g BB3OSHFFURcf8IdzeIetv+MXM9zS/uBl/5kT9Vn8= From: Alcor To: Juri Linkov Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <87ldp5jhzh.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 03 Jul 2025 20:34:42 +0300") References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> Date: Thu, 03 Jul 2025 21:14:51 +0200 Message-ID: <87a55l13ys.fsf@tilde.club> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Indeed. So I pushed a better patch that handles both > down-mouse-1 and mouse-1 events. `dired-mouse-find-file' > is on mouse-1/2, so it's not ignored anymore: Thanks Juri & Eli. Since the original issue was filed against 30.1, and the patch seems minimal enough - would it be possible to ask for a backport to the emacs-30 branch so this fix may make it into 30.2? Cheers, -A From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 02:28:50 2025 Received: (at 78945) by debbugs.gnu.org; 4 Jul 2025 06:28:50 +0000 Received: from localhost ([127.0.0.1]:56130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXZui-0000BS-VW for submit@debbugs.gnu.org; Fri, 04 Jul 2025 02:28:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39702) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXZuf-0000Az-FH for 78945@debbugs.gnu.org; Fri, 04 Jul 2025 02:28:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXZuY-00061Y-Bb; Fri, 04 Jul 2025 02:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mIVymaDLm3GJ01OuzUvUhuvwvrpVhLjJ7erYr4jN1Og=; b=d+IgTc3TRkrj AEhRzai+zThhizqZypOtU8v4i1wFQmB+gRsGcDpJi4UVisJr/nwEw/H8pfEE3h81OOKRYjUMhfo0L 2S6q6Pv7nO4bpvYcrbzIrZuPdXwe13CbfedrhSBffGMJ5Oo4+8pT3va3BRla/etqEFm9bZAGY18oB wiiiBaaRMRuBV0MAOgnlHskV/G7jALcBN0062Ln3EIpCqeVR4SKDXYcSMs9eyE5VijTpyr4CGdJR8 9T227A268EjBenZYhp1Xd4cUWCoEDUXb5hAbDiQlOJZhlvsAHZcfIfhVK8W0S1yR75gbNpky65hiB Jl4Exf8de5RJktsZbE7XiQ==; Date: Fri, 04 Jul 2025 09:28:34 +0300 Message-Id: <86bjq0zcz1.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov , Stefan Monnier In-Reply-To: <87ldp5jhzh.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 03 Jul 2025 20:34:42 +0300) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 78945@debbugs.gnu.org, Eli Zaretskii > Date: Thu, 03 Jul 2025 20:34:42 +0300 > > > I just have a question regarding possible side effects: I understand > > that this change ignores `mouse-drag-region' events. I'm not sure > > whether it's possible to bind functions to these events, but if yes, > > wouldn't this preclude any commands/functions bound to > > `mouse-drag-region' from being affected by C-x 4 4 or C-x 5 5? > > Indeed. So I pushed a better patch that handles both > down-mouse-1 and mouse-1 events. `dired-mouse-find-file' > is on mouse-1/2, so it's not ignored anymore: > > diff --git a/lisp/window.el b/lisp/window.el > index af7680e4486..068b4d61f79 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -9672,7 +9679,10 @@ display-buffer-override-next-command > (> (minibuffer-depth) minibuffer-depth) > ;; But don't remove immediately after > ;; adding the hook by the same command below. > - (eq this-command command)) > + (eq this-command command) > + ;; Don't exit on mouse down event > + ;; in anticipation of mouse release event. > + (memq 'down (event-modifiers last-input-event))) > (funcall exitfun)))) > ;; Call post-function after the next command finishes (bug#49057). > (add-hook 'post-command-hook postfun) Thanks, but how general is this fix? What if some bindings change the command invoked as mouse-drag-region in this case, and we have a different command "interfering"? For that matter, could you please explain how exactly did mouse-drag-region "get in the way" of the "C-x 4 4" feature? Because I still don't understand the root cause of the problem, and the fix you installed doesn't explain that to me. I therefore cannot understand the implications of the fix, and IMO we should continue discussing this until we have a complete understanding of both the problem and its fix. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 02:44:31 2025 Received: (at 78945) by debbugs.gnu.org; 4 Jul 2025 06:44:31 +0000 Received: from localhost ([127.0.0.1]:56196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXa9u-0001z5-Sk for submit@debbugs.gnu.org; Fri, 04 Jul 2025 02:44:31 -0400 Received: from mout-y-111.mailbox.org ([91.198.250.236]:46912) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXa9s-0001xd-4l for 78945@debbugs.gnu.org; Fri, 04 Jul 2025 02:44:29 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4bYPHk1dmZz9xqs; Fri, 4 Jul 2025 08:44:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1751611458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fn869Z1D+e7mgbpwPSlRpoSCYPFWiXfad+6pINgX8OQ=; b=XdWny+aa9z4sIhVHCWsWd/PK3NFtuEHBjthUYgflaAianuH5sESQZ/N5kYhRVN/Mo6V7ik 9gtxL07PnIIjfdj+8+cy6UE/+jKxP16jXcxDArA7utNikRjVEm/L8b0Oy2DFq408E0qZPy OVO+PW996+05fpYdeWYRPanABF0QthdKbD9njWFZytqHLTPydecyW2AJR+vPxcMYTO9rjB iFbUk/kGzisxcbNiOQOxJsF+Pyce5R4p6uwriCfam0wLnHwL/3EZA2GuTAQ5Q/Z4/ecwv3 98I1Q/1wKIFzMMFAwVhGShLRvuLl/uw96QVAMx1CAP5uuNsPMpwppf6YbFLFeQ== From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <86bjq0zcz1.fsf@gnu.org> Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> Date: Fri, 04 Jul 2025 09:42:07 +0300 Message-ID: <87h5zstq2o.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bYPHk1dmZz9xqs X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Stefan Monnier , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) >> > I just have a question regarding possible side effects: I understand >> > that this change ignores `mouse-drag-region' events. I'm not sure >> > whether it's possible to bind functions to these events, but if yes, >> > wouldn't this preclude any commands/functions bound to >> > `mouse-drag-region' from being affected by C-x 4 4 or C-x 5 5? >> >> Indeed. So I pushed a better patch that handles both >> down-mouse-1 and mouse-1 events. `dired-mouse-find-file' >> is on mouse-1/2, so it's not ignored anymore: >> >> diff --git a/lisp/window.el b/lisp/window.el >> index af7680e4486..068b4d61f79 100644 >> --- a/lisp/window.el >> +++ b/lisp/window.el >> @@ -9672,7 +9679,10 @@ display-buffer-override-next-command >> (> (minibuffer-depth) minibuffer-depth) >> ;; But don't remove immediately after >> ;; adding the hook by the same command below. >> - (eq this-command command)) >> + (eq this-command command) >> + ;; Don't exit on mouse down event >> + ;; in anticipation of mouse release event. >> + (memq 'down (event-modifiers last-input-event))) >> (funcall exitfun)))) >> ;; Call post-function after the next command finishes (bug#49057). >> (add-hook 'post-command-hook postfun) > > Thanks, but how general is this fix? This fix is general unlike the first version that hard-coded mouse-drag-region. > What if some bindings change the command invoked as mouse-drag-region > in this case, and we have a different command "interfering"? Both commands (bound to down-mouse-1 and mouse-1) should be handled here, regardless of whether it's mouse-drag-region or anything else. > For that matter, could you please explain how exactly did > mouse-drag-region "get in the way" of the "C-x 4 4" feature? Because > I still don't understand the root cause of the problem, and the fix > you installed doesn't explain that to me. I therefore cannot > understand the implications of the fix, and IMO we should continue > discussing this until we have a complete understanding of both the > problem and its fix. Looking at 'C-h l' (view-lossage) explains everything: C-x 5 5 ;; other-frame-prefix ;; mouse-drag-region ;; dired-mouse-find-file Now both commands for and are handled. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 02:57:13 2025 Received: (at 78945) by debbugs.gnu.org; 4 Jul 2025 06:57:13 +0000 Received: from localhost ([127.0.0.1]:56231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXaM9-0003Vg-Nn for submit@debbugs.gnu.org; Fri, 04 Jul 2025 02:57:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49624) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXaM6-0003UW-Sr for 78945@debbugs.gnu.org; Fri, 04 Jul 2025 02:57:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXaLr-0006el-Hj; Fri, 04 Jul 2025 02:57:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aaM6A/111ciUH5ntp5PSNXSMNLzJihSV7yhhT9MwznU=; b=OzJ8OYiL/1VP HADSA6Kxb7kz2XY2w3kqlZYaO9O0i1Mm0F4vr9dWNBJe68fs1/VGMDYE6B4HjtJPJd/XpVKJrd6ez wogbCng5I0AyrxIzuB4V9bBGn1nSD3NEsGsWM2X1DUaGCg/UkGshsOBxBdRL05baFlLkoVT1s9MeC rvGTSva0HXHD1J47owAmmjmH4juSbcaEphIalRNXW+U1mRMZkcOC8qQUMfgNM33gUOrtBRP5dqLXN ShlAwNXEwAffT1bw6+54JWnvXusiRITQUqvMrwgfQjjB5vRatIlYj4vZqyKbj2bH59qbfX24GO50z UR3JIZwVBYmwPRx7PTwVaw==; Date: Fri, 04 Jul 2025 09:56:43 +0300 Message-Id: <868ql4zbo4.fsf@gnu.org> From: Eli Zaretskii To: Alcor In-Reply-To: <87a55l13ys.fsf@tilde.club> (message from Alcor on Thu, 03 Jul 2025 21:14:51 +0200) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <87a55l13ys.fsf@tilde.club> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alcor > Cc: 78945@debbugs.gnu.org, Eli Zaretskii > Date: Thu, 03 Jul 2025 21:14:51 +0200 > > Juri Linkov writes: > > > Indeed. So I pushed a better patch that handles both > > down-mouse-1 and mouse-1 events. `dired-mouse-find-file' > > is on mouse-1/2, so it's not ignored anymore: > > Thanks Juri & Eli. > > Since the original issue was filed against 30.1, and the patch seems > minimal enough - would it be possible to ask for a backport to the > emacs-30 branch so this fix may make it into 30.2? In general, no, because this fix is somewhat ad-hoc, and therefore could have unintended consequences; that is inappropriate on the release branch at this time. But please wait until the discussion of this bug and its fix is completed, because only then we will have a complete picture about the root cause and the expected effects of the solution we will install (which is not necessarily what was already installed, for the reasons I tried to explain in my previous message). From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 03:48:00 2025 Received: (at 78945) by debbugs.gnu.org; 4 Jul 2025 07:48:00 +0000 Received: from localhost ([127.0.0.1]:56444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXb9J-0004Wg-Eh for submit@debbugs.gnu.org; Fri, 04 Jul 2025 03:47:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53902) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXb9F-0004Uv-9o for 78945@debbugs.gnu.org; Fri, 04 Jul 2025 03:47:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXb96-00037i-P5; Fri, 04 Jul 2025 03:47:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/p+Ro/j2ehaBW9LuifwlBSbSnHf0r16b5sjJ5iNZgTU=; b=jSr6bgcxnyKS rBic7QZwRvg5HmpAZcPHMlspqjZGu+mNvV+kIVLVoYqZIvqWAFrPXNJQ/pTiu/+xoprvvXxToo1hY Ew3suR1cqqJqHn4vI1l256TIovecPtIsAYCzveGiEoXmiNz8xGcj4I5y0Xqm9PFY8QBUm7kiPUU4c UNLB/1D5Ekjp5K9tkVtui+BI0fS2+4Yulz444tpZYWrPJVkSHziCT4aV5gO3ap5vYa6Tzyg/eDQ8x uMrrRYKboamh3gpFQgW1WPrCYssCeDVZvhiVJfwmm3UAuZv8b6B8+HdhGWcoQ8STUeKlAh2yVx4GC whsWzUWgm22M1U8gxSMNIQ==; Date: Fri, 04 Jul 2025 10:47:41 +0300 Message-Id: <86wm8oxuqq.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87h5zstq2o.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 04 Jul 2025 09:42:07 +0300) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Stefan Monnier , alcor@tilde.club, > 78945@debbugs.gnu.org > Date: Fri, 04 Jul 2025 09:42:07 +0300 > > > Thanks, but how general is this fix? > > This fix is general unlike the first version that hard-coded mouse-drag-region. > > > What if some bindings change the command invoked as mouse-drag-region > > in this case, and we have a different command "interfering"? > > Both commands (bound to down-mouse-1 and mouse-1) should be handled here, > regardless of whether it's mouse-drag-region or anything else. > > > For that matter, could you please explain how exactly did > > mouse-drag-region "get in the way" of the "C-x 4 4" feature? Because > > I still don't understand the root cause of the problem, and the fix > > you installed doesn't explain that to me. I therefore cannot > > understand the implications of the fix, and IMO we should continue > > discussing this until we have a complete understanding of both the > > problem and its fix. > > Looking at 'C-h l' (view-lossage) explains everything: > > C-x 5 5 ;; other-frame-prefix > ;; mouse-drag-region > ;; dired-mouse-find-file Sorry, it doesn't, not to me, probably because I don't understand well enough what "C-x 4 4" does and how. So please talk me through the code which implements "C-x 4 4" and explain how down-mouse-1 in the middle defeated it. Without that, I cannot understand the fix and its generality. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 09:56:30 2025 Received: (at 78945) by debbugs.gnu.org; 4 Jul 2025 13:56:30 +0000 Received: from localhost ([127.0.0.1]:60501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uXgtx-0002z5-To for submit@debbugs.gnu.org; Fri, 04 Jul 2025 09:56:30 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16059) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uXgtu-0002x1-Pl for 78945@debbugs.gnu.org; Fri, 04 Jul 2025 09:56:27 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1A3008089D; Fri, 4 Jul 2025 09:56:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1751637379; bh=xvJpXocvZ5cL0eEGjJ0P48iFMlFneHlE8yepDs30arY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DxxVW2M2zzNMJk1xTWNbMJ0vmZUvU65b6dbt6P5qYN0DFOeEedT1AXF3Qo2l/hSNn WCay1Pz8HfnmlBlkso0U5HYNnD9h1maddEAevVE6/tARobPKQD8+bE5QWd1uc6rvHK Vlm7azIcXS3lvY+yHJq0ulqaNn6mFk5k8ssOTEFP2yRDRSvW2xmFlwiuQx+PWIK29H Qm5l6VwraBF9zVbdRidKW8V9/bZRV3sO438kBFnFL/PWnxGa0PWXpUC8txPwaI2TKW il46FGITj2h0W40VEtI1IkIJkHziGE3TXGLl3dLot4EeFvJTAKb/DmMg8khtDsLxdK 8vc7ADi+zCEVg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4927A80758; Fri, 4 Jul 2025 09:56:19 -0400 (EDT) Received: from pastel (unknown [104.247.225.139]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 18CD0120346; Fri, 4 Jul 2025 09:56:19 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <87h5zstq2o.fsf@mail.linkov.net> Message-ID: References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> Date: Fri, 04 Jul 2025 09:56:18 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.293 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) > Looking at 'C-h l' (view-lossage) explains everything: > > C-x 5 5 ;; other-frame-prefix > ;; mouse-drag-region > ;; dired-mouse-find-file BTW, `help--read-key-sequence` faces the same problem (and tries to additionally handle the same issue for double-clicks). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 02:45:24 2025 Received: (at submit) by debbugs.gnu.org; 7 Jul 2025 06:45:25 +0000 Received: from localhost ([127.0.0.1]:60836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uYfbP-0003TE-HH for submit@debbugs.gnu.org; Mon, 07 Jul 2025 02:45:24 -0400 Received: from lists.gnu.org ([2001:470:142::17]:50978) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uYfbE-0003MO-VU for submit@debbugs.gnu.org; Mon, 07 Jul 2025 02:45:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uYfb9-0006DS-BE for bug-gnu-emacs@gnu.org; Mon, 07 Jul 2025 02:45:07 -0400 Received: from mout-y-209.mailbox.org ([91.198.250.237]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1uYfb7-00007q-Q0; Mon, 07 Jul 2025 02:45:07 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4bbF985nntzB0PL; Mon, 7 Jul 2025 08:45:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1751870700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f6VMPtcKV+KWIjo0m065NjrHx+DnZSqM3tvswc5LTOI=; b=kKry2+stp4K9Lk6rTz4YR5lXTlj+ZaCN6C1Ei+ok+ePU1gXN07Y4s3JwVPQHQ0miyupp61 0jtTA2ks/Ccdmirpdv05x73SyO3AtihtBmcM3u2bTD1ngcjEk8DpU/+GVIiHdtQTdzRFty rIgl6yJ+5Q1Ki26cEznYhXviZmPzZBo+JKUxLYxrRLwrp/NFo40cUoLD8U0LrGwo5DkG/W bHWGZCgRjv8Dbkwiz5tv0FCYmCE2AcQKrLAkcP13hb1+NXzkock/cu5zciySNCbxmvOcV2 2gchzZKhq0wDIqfLSYGJHhfT21dTn3XDqJ5MYpg1heWyvM8KyAnQAneUDZ8uyQ== From: Juri Linkov To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> Date: Mon, 07 Jul 2025 09:39:49 +0300 Message-ID: <8734b85wsq.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bbF985nntzB0PL Received-SPF: pass client-ip=91.198.250.237; envelope-from=juri@linkov.net; helo=mout-y-209.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: 78945@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >> Looking at 'C-h l' (view-lossage) explains everything: >> >> C-x 5 5 ;; other-frame-prefix >> ;; mouse-drag-region >> ;; dired-mouse-find-file > > BTW, `help--read-key-sequence` faces the same problem (and tries to > additionally handle the same issue for double-clicks). Not sure how would be possible to handle double-clicks in this case: C-x 5 5 ;; other-frame-prefix ;; mouse-drag-region ;; mouse-set-point ;; mouse-drag-region ;; mouse-set-point `describe-key` uses (and (not (memq mouse-1-click-follows-link '(nil double))) (> (length raw) 0) (eq (car-safe (aref raw 0)) 'mouse-1) But I'm afraid that not exiting on in `display-buffer-override-next-command` would be too error-prone. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 02:45:09 2025 Received: (at 78945) by debbugs.gnu.org; 7 Jul 2025 06:45:09 +0000 Received: from localhost ([127.0.0.1]:60822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uYfbA-0003MU-2z for submit@debbugs.gnu.org; Mon, 07 Jul 2025 02:45:09 -0400 Received: from mout-y-209.mailbox.org ([91.198.250.237]:47698) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uYfb7-0003JV-EA for 78945@debbugs.gnu.org; Mon, 07 Jul 2025 02:45:06 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4bbF954tdcz9tg7; Mon, 7 Jul 2025 08:44:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1751870697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=11Q7ONrH27mKNmj6iYMlHu36kV0SlnvB25Uug8yPKj4=; b=rpp1+nPD5ux5uYSil6mIRv3TOwoC+F2I4/p/F1drBS7hxFzPdBa9SQoXzbakX6JnIbtkdc aVyEFPKVWlJWH/IIWdon4tUF4ovjGstvHyA3eimsVFqc6URnqDhIHW9tb09cGPzzfFr7ai ERI86pJ2IqwKkyhToM26qTX7dC2yBS9hNplidRDn2HhWGJsp+hVzBYj0tOXl3Ijuj37jn9 ky/CFvUNRC7IVFG+puaUqQeT6DabAP5T5D3n+2i0KUGAJxgN0cX6fd7wvKsitBb3Br91fp OHfCAbZgZTfZ4ZPRYExd6MDeX5sFioKoSyIykCP56VTs8CDZ/b1PkoYEcO1OUQ== From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <86wm8oxuqq.fsf@gnu.org> Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <86wm8oxuqq.fsf@gnu.org> Date: Mon, 07 Jul 2025 09:34:17 +0300 Message-ID: <87sej85x20.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bbF954tdcz9tg7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > Thanks, but how general is this fix? >> >> This fix is general unlike the first version that hard-coded mouse-drag-region. >> >> > What if some bindings change the command invoked as mouse-drag-region >> > in this case, and we have a different command "interfering"? >> >> Both commands (bound to down-mouse-1 and mouse-1) should be handled here, >> regardless of whether it's mouse-drag-region or anything else. >> >> > For that matter, could you please explain how exactly did >> > mouse-drag-region "get in the way" of the "C-x 4 4" feature? Because >> > I still don't understand the root cause of the problem, and the fix >> > you installed doesn't explain that to me. I therefore cannot >> > understand the implications of the fix, and IMO we should continue >> > discussing this until we have a complete understanding of both the >> > problem and its fix. >> >> Looking at 'C-h l' (view-lossage) explains everything: >> >> C-x 5 5 ;; other-frame-prefix >> ;; mouse-drag-region >> ;; dired-mouse-find-file > > Sorry, it doesn't, not to me, probably because I don't understand well > enough what "C-x 4 4" does and how. So please talk me through the > code which implements "C-x 4 4" and explain how down-mouse-1 in the > middle defeated it. Without that, I cannot understand the fix and its > generality. The docstring of "C-x 4 4" says: Display the buffer of the next command in a new window. Clicking the mouse button runs two commands, so both should be handled here. Or do you think this special case should be mentioned in the docstring? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 09:58:12 2025 Received: (at 78945) by debbugs.gnu.org; 7 Jul 2025 13:58:12 +0000 Received: from localhost ([127.0.0.1]:36005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uYmMG-0004Gw-CN for submit@debbugs.gnu.org; Mon, 07 Jul 2025 09:58:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18709) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uYmME-0004GN-Fw for 78945@debbugs.gnu.org; Mon, 07 Jul 2025 09:58:10 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 54AAF10013E; Mon, 7 Jul 2025 09:58:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1751896683; bh=hY940PHc9p3QoFb5+76RiBBYarzJ2wEeDiFvwBos4Tc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WmudXDR93UvWIV4V0B7KKv3o091oAT8GjGLV5phQ3XGe8gWATmI1SyoHP0LSjC5gp 01tQq9CJB3v/LeMKpj3hh+gpcRw9dEc+iG9XzI+QKCl2LVulTwAa1PlXJvmO6vzlxY Us9fN/Ahl+rVwXyM/byMaQoOrQMvRpTE5rd3z7IDXnhpxtE+qPs9SxZdETI9tnF9tz oreWS6u9uRw4dGMDtl3YCPjAGSCGd7jSlyD1WK3DuDVSv71PiVLflMXnV+pBHebjbo YeoKXNOLZbpBToHMmp2I3LAZOFszPYGmcpTL7FNVv/1j8KGaO81dy3qWypFSKHJ+uH O3pT6p4HwbNSw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5AEAF10002E; Mon, 7 Jul 2025 09:58:03 -0400 (EDT) Received: from alfajor (unknown [104.247.225.139]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0AC1D1201B6; Mon, 7 Jul 2025 09:58:03 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <8734b85wsq.fsf@mail.linkov.net> Message-ID: References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> Date: Mon, 07 Jul 2025 09:58:01 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.290 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Not sure how would be possible to handle double-clicks in this case: > > C-x 5 5 ;; other-frame-prefix > ;; mouse-drag-region > ;; mouse-set-point > ;; mouse-drag-region > ;; mouse-set-point Why not? > `describe-key` uses > > (and (not (memq mouse-1-click-follows-link '(nil double))) > (> (length raw) 0) > (eq (car-safe (aref raw 0)) 'mouse-1) Not really. The relevant code is (in `help--read-key-sequence`): (while ;; Read at least one key-sequence. (or (null key-list) ;; After a down event, also read the (presumably) following ;; up-event. (memq 'down last-modifiers) ;; After a click, see if a double click is on the way. (and (memq 'click last-modifiers) (not (sit-for (/ (mouse-double-click-time) 1000.0) t)))) That also handles triple-clicks. > But I'm afraid that not exiting on in > `display-buffer-override-next-command` would be too error-prone. The "normal" way to disable the override is by consuming it: ;; Reset display-buffer-overriding-action ;; after the first display-buffer action (bug#39722). (funcall clearfun) I'm not suggesting we leave the override active "indefinitely" for as long as no `display-buffer` used it, but I don't expect any serious problem if the override lingers a bit longer. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 10:05:14 2025 Received: (at 78945) by debbugs.gnu.org; 7 Jul 2025 14:05:14 +0000 Received: from localhost ([127.0.0.1]:36056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uYmT3-0004sH-UL for submit@debbugs.gnu.org; Mon, 07 Jul 2025 10:05:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uYmT1-0004n1-6Q for 78945@debbugs.gnu.org; Mon, 07 Jul 2025 10:05:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uYmSu-0000OR-0Y; Mon, 07 Jul 2025 10:05:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ABe3PRc4g9q59Oi8wmHWQMcZNdM4/MJPrAIkBuqygJI=; b=LAuhzWcivIRx uXpR5ngRRrMytA9isHUFt2Bj+msb79fMbAEJA1XMHgkhxgyzkZ9cpe8YwVU7gT4gw2hXZfwQ31E7L A/ihvR7mqa24O2gYDPpXOxMu7Qr1BwTLUJE3/bJdNeoCafVnQZOjko3z+fgRNKn4rQB4nqu4Aj9KC TA7rrvWyVHCJhvQ+yyfuYhBUXLKogztyjdiRXjizCS0yFdpMystD2vMhuaZs8FoSBQENxtz6ja1KL PoBs0uxdf05JoxfOahU+/DeioSyH+d1bTeVm+PHfHbRvruuPOFB3mHpq4IkdFg56jgBDyshmvRziB qfEmO0yZee9uYLfyJnPXHA==; Date: Mon, 07 Jul 2025 17:05:01 +0300 Message-Id: <865xg4t7ua.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87sej85x20.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 07 Jul 2025 09:34:17 +0300) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <86wm8oxuqq.fsf@gnu.org> <87sej85x20.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: monnier@iro.umontreal.ca, alcor@tilde.club, 78945@debbugs.gnu.org > Date: Mon, 07 Jul 2025 09:34:17 +0300 > > >> Looking at 'C-h l' (view-lossage) explains everything: > >> > >> C-x 5 5 ;; other-frame-prefix > >> ;; mouse-drag-region > >> ;; dired-mouse-find-file > > > > Sorry, it doesn't, not to me, probably because I don't understand well > > enough what "C-x 4 4" does and how. So please talk me through the > > code which implements "C-x 4 4" and explain how down-mouse-1 in the > > middle defeated it. Without that, I cannot understand the fix and its > > generality. > > The docstring of "C-x 4 4" says: > > Display the buffer of the next command in a new window. > > Clicking the mouse button runs two commands, so both should be handled here. > Or do you think this special case should be mentioned in the docstring? We should probably document it once we agree and understand the full effect of the change. Right now, I understand that: . "C-x 4 4" etc. can affect more than just one next command -- as long as the commands have the 'down' modifier, we will keep the override in effect -- is this expected or TRT? . If some command is bound to mouse-down event, it might not be the only command affected by "C-x 4 4" -- do we want that? . What about commands bound to double clicks and triple clicks? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 13:13:31 2025 Received: (at 78945) by debbugs.gnu.org; 7 Jul 2025 17:13:32 +0000 Received: from localhost ([127.0.0.1]:37480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uYpPH-0001Av-HE for submit@debbugs.gnu.org; Mon, 07 Jul 2025 13:13:31 -0400 Received: from mout-y-111.mailbox.org ([91.198.250.236]:51770) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uYpPF-0001AL-45 for 78945@debbugs.gnu.org; Mon, 07 Jul 2025 13:13:29 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4bbW691X6Hz9xwX; Mon, 7 Jul 2025 19:13:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1751908401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vAfRgKDtrPofJdzt0jswRKLgfDhK+FD0GvFZux0Hkv4=; b=xW/2mEPCretPGv60hDYDl51B6yxzzycdaG5pf4uraM9e7+z2Ck37bx1KBlOICOp5GXN2yV CYT/whmjm9nQZkENLifTIruJ7jAkjC3VQvkEiaVVDvdJYAoDOqC7s4KOC1VMJU+gdf1aI1 B/E4VgTYEU8P44SrkUpwdoKRhyOPC/hU50rP0v7gKXpRp5J9VEu6+kON4XnCk342AyXkly xBtxqJ7/uuCHivqQxRHcMzzMlV5zSslhBODRl24xTObRENSSyt7IvcjnfgwvergTmJafRZ SV+2DwOhfqTAqaJxArd47tv9+Rl1sUyZeO9hHRCm5Luw2XVbq2MMO3ueLey0QA== From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <865xg4t7ua.fsf@gnu.org> Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <86wm8oxuqq.fsf@gnu.org> <87sej85x20.fsf@mail.linkov.net> <865xg4t7ua.fsf@gnu.org> Date: Mon, 07 Jul 2025 19:57:29 +0300 Message-ID: <87ikk42bj2.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bbW691X6Hz9xwX X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> >> Looking at 'C-h l' (view-lossage) explains everything: >> >> >> >> C-x 5 5 ;; other-frame-prefix >> >> ;; mouse-drag-region >> >> ;; dired-mouse-find-file >> > >> > Sorry, it doesn't, not to me, probably because I don't understand well >> > enough what "C-x 4 4" does and how. So please talk me through the >> > code which implements "C-x 4 4" and explain how down-mouse-1 in the >> > middle defeated it. Without that, I cannot understand the fix and its >> > generality. >> >> The docstring of "C-x 4 4" says: >> >> Display the buffer of the next command in a new window. >> >> Clicking the mouse button runs two commands, so both should be handled here. >> Or do you think this special case should be mentioned in the docstring? > > We should probably document it once we agree and understand the full > effect of the change. > > Right now, I understand that: > > . "C-x 4 4" etc. can affect more than just one next command -- as > long as the commands have the 'down' modifier, we will keep the > override in effect -- is this expected or TRT? This is the right thing since it fixes the reported problem. > . If some command is bound to mouse-down event, it might not be the > only command affected by "C-x 4 4" -- do we want that? Yes, we need to handle mouse-down and mouse-up commands. > . What about commands bound to double clicks and triple clicks? This is doable. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 13:13:37 2025 Received: (at 78945) by debbugs.gnu.org; 7 Jul 2025 17:13:37 +0000 Received: from localhost ([127.0.0.1]:37484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uYpPM-0001BS-W9 for submit@debbugs.gnu.org; Mon, 07 Jul 2025 13:13:37 -0400 Received: from mout-y-111.mailbox.org ([91.198.250.236]:51780) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uYpPI-0001AZ-8W for 78945@debbugs.gnu.org; Mon, 07 Jul 2025 13:13:32 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4bbW6D4KCXz9yTq; Mon, 7 Jul 2025 19:13:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1751908404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6UFHYqS3YxAUaSapBu3WU4/m8Kh9mutrrF4Wxc7KgYc=; b=CFzGXJEFPnKwYkaYDquK0++hSBJFAwz1pPVPMfiQ5nWAksWCOYZd0yPTMhmT0E6iTJb7Sc DL7+B7F2DPzuCR4hfUPjrvLoR/WpguxcDEoLaJKEB7iHKnztWSuSa8Igzt75TaTJPPQSPg Sv0Ie70eGx7sAXFFrcPZntWo7jr2fFeXPcn9eGu49kFgD1SVKNP4JnwUO5rzXKfYInxs9+ UMj2MrntF0oYv69p1V4WC8fKIMd++6TWkd831MomvYdVl6Ge1VoF9xG7OGD0CPEgxhls51 3cYgJITnj2A6j0WA0UlESCbUB0t21S9UgrEJycHcA2LLwSlHzW8owoUHOoWYfw== From: Juri Linkov To: Stefan Monnier Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> Date: Mon, 07 Jul 2025 20:01:24 +0300 Message-ID: <87jz4k0vur.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bbW6D4KCXz9yTq X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Not sure how would be possible to handle double-clicks in this case: >> >> C-x 5 5 ;; other-frame-prefix >> ;; mouse-drag-region >> ;; mouse-set-point >> ;; mouse-drag-region >> ;; mouse-set-point > > Why not? Ok, double-clicks should be handled as well. For example, image-dired defines: "" #'image-dired-mouse-select-thumbnail "" #'image-dired-mouse-select-thumbnail "" #'image-dired-mouse-display-image But currently `C-x 5 5 ` doesn't display an image in a new frame. >> `describe-key` uses >> >> (and (not (memq mouse-1-click-follows-link '(nil double))) >> (> (length raw) 0) >> (eq (car-safe (aref raw 0)) 'mouse-1) > > Not really. The relevant code is (in `help--read-key-sequence`): > > (while > ;; Read at least one key-sequence. > (or (null key-list) > ;; After a down event, also read the (presumably) following > ;; up-event. > (memq 'down last-modifiers) > ;; After a click, see if a double click is on the way. > (and (memq 'click last-modifiers) > (not (sit-for (/ (mouse-double-click-time) 1000.0) t)))) > > That also handles triple-clicks. > >> But I'm afraid that not exiting on in >> `display-buffer-override-next-command` would be too error-prone. > > The "normal" way to disable the override is by consuming it: > > ;; Reset display-buffer-overriding-action > ;; after the first display-buffer action (bug#39722). > (funcall clearfun) > > I'm not suggesting we leave the override active "indefinitely" for as > long as no `display-buffer` used it, but I don't expect any serious > problem if the override lingers a bit longer. The only potential problem is mistyped keys or accidental clicks. But since it's very rare then maybe this patch is ok: diff --git a/lisp/window.el b/lisp/window.el index ea102706ecb..a25af158a73 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -9673,9 +9680,9 @@ display-buffer-override-next-command ;; But don't remove immediately after ;; adding the hook by the same command below. (eq this-command command) - ;; Don't exit on mouse down event - ;; in anticipation of mouse release event. - (memq 'down (event-modifiers last-input-event))) + ;; Don't exit on mouse down event in anticipation + ;; of mouse release or double click event. + (mouse-event-p last-input-event)) (funcall exitfun)))) ;; Call post-function after the next command finishes (bug#49057). (add-hook 'post-command-hook postfun) From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 15:20:56 2025 Received: (at 78945) by debbugs.gnu.org; 7 Jul 2025 19:20:56 +0000 Received: from localhost ([127.0.0.1]:37990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uYrOZ-0006NH-Mo for submit@debbugs.gnu.org; Mon, 07 Jul 2025 15:20:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47389) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uYrOX-0006Mo-Ix for 78945@debbugs.gnu.org; Mon, 07 Jul 2025 15:20:54 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E0B0680926; Mon, 7 Jul 2025 15:20:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1751916042; bh=LYHDcKa/+raCIFNw+ZDEH+XjUG4lbD+DfXDMSC3vX2I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=f5MfQhQ/cW/EV/3ez+uOy3pko1YaDUsv+LhjolhNCZdvsuuUgh3bhEUJYknl8vda1 vufH3V56YZbZ/1zoHiDUtzSFqgkt6Lh5Yl8qVnm1nOB1hPONKUMdjaflSJe+HECpnn TJv347uYyxOthpBFRidnoNlyjJKfVwVSvUnL8EFask3jvf7yx88Z7q2sVZ6vWwHjRZ Ebtz2OJlkO/Yvh3cBSH6TKBHHTgTXnP9k5I1LEqAl85/XgPviLXLBI+e70W3QgzH84 neq6yKTWJFljf6yzCEMfoslOOBTL80JEkn1rEENIEtZ8NZCpekBzIXOOtsVHsMQkw8 0o9vwrIAKWJBA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DB77B808F6; Mon, 7 Jul 2025 15:20:42 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C8AAB1204C0; Mon, 7 Jul 2025 15:20:42 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <87jz4k0vur.fsf@mail.linkov.net> Message-ID: References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> Date: Mon, 07 Jul 2025 15:20:42 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The "normal" way to disable the override is by consuming it: >> >> ;; Reset display-buffer-overriding-action >> ;; after the first display-buffer action (bug#39722). >> (funcall clearfun) >> >> I'm not suggesting we leave the override active "indefinitely" for as >> long as no `display-buffer` used it, but I don't expect any serious >> problem if the override lingers a bit longer. > > The only potential problem is mistyped keys or accidental clicks. > But since it's very rare then maybe this patch is ok: > > diff --git a/lisp/window.el b/lisp/window.el > index ea102706ecb..a25af158a73 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -9673,9 +9680,9 @@ display-buffer-override-next-command > ;; But don't remove immediately after > ;; adding the hook by the same command below. > (eq this-command command) > - ;; Don't exit on mouse down event > - ;; in anticipation of mouse release event. > - (memq 'down (event-modifiers last-input-event))) > + ;; Don't exit on mouse down event in anticipation > + ;; of mouse release or double click event. > + (mouse-event-p last-input-event)) > (funcall exitfun)))) > ;; Call post-function after the next command finishes (bug#49057). > (add-hook 'post-command-hook postfun) LGTM. `help--read-key-sequence` combines it with a time-limit because we don't want `C-h k` to sit there indefinitely, but it doesn't seem needed here, indeed, since in most cases the override will have been disabled/consumed by an intervening `display-buffer` anyway. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 02:52:59 2025 Received: (at 78945) by debbugs.gnu.org; 9 Jul 2025 06:52:59 +0000 Received: from localhost ([127.0.0.1]:48200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZOfr-0004Ft-Cx for submit@debbugs.gnu.org; Wed, 09 Jul 2025 02:52:59 -0400 Received: from mout-y-209.mailbox.org ([91.198.250.237]:49232) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZOfo-0004FA-2d for 78945@debbugs.gnu.org; Wed, 09 Jul 2025 02:52:56 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4bcTF94HSDzB0P9; Wed, 9 Jul 2025 08:52:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1752043965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VfenriFwY5U+nXaJdM4oEylPeMA9tXSOS0TFXjmqRw8=; b=Rdk95vOxQqkEXZZuYMTlvfKiR0WZTTKprGTYWquBW3SHVJSejZrZJQBScm0qj/IoN9TVpx jTbAJrtkuiyg5budYn7tUJUT76Yw43lEtMcMk8L9aTCtcQwTHfF3apJiNno00+0HSPfRyR UDs2gUYTu9K4qeE+V8Rx8si+2nqvwwJPyHXylK897FZI2MgG5hnHhSAMelZj+uRZBqitIr efxFz1WlJsQuNNfsLpPqS3ZN7DoInBPo01c82ZrEmsT6/7O0ru5LGIxJKG2mV54kVu/6Bz TqYxMLZglPZb1zJLjL96fRS69x/O70uI0nk0hmosuW1J0FLuSTg7vR2xcQADEQ== From: Juri Linkov To: Stefan Monnier Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> Date: Wed, 09 Jul 2025 09:51:22 +0300 Message-ID: <87ikk1rhc5.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Eli Zaretskii , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> @@ -9673,9 +9680,9 @@ display-buffer-override-next-command >> ;; But don't remove immediately after >> ;; adding the hook by the same command below. >> (eq this-command command) >> - ;; Don't exit on mouse down event >> - ;; in anticipation of mouse release event. >> - (memq 'down (event-modifiers last-input-event))) >> + ;; Don't exit on mouse down event in anticipation >> + ;; of mouse release or double click event. >> + (mouse-event-p last-input-event)) >> (funcall exitfun)))) >> ;; Call post-function after the next command finishes (bug#49057). >> (add-hook 'post-command-hook postfun) > > LGTM. > > `help--read-key-sequence` combines it with a time-limit because we don't > want `C-h k` to sit there indefinitely, but it doesn't seem needed here, > indeed, since in most cases the override will have been > disabled/consumed by an intervening `display-buffer` anyway. Now pushed with docstring updates that describe this behavior. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 06:58:07 2025 Received: (at 78945) by debbugs.gnu.org; 9 Jul 2025 10:58:07 +0000 Received: from localhost ([127.0.0.1]:49144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZSV4-0003n1-KQ for submit@debbugs.gnu.org; Wed, 09 Jul 2025 06:58:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44932) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZSUy-0003lm-0q for 78945@debbugs.gnu.org; Wed, 09 Jul 2025 06:58:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZSUp-00087p-Ot; Wed, 09 Jul 2025 06:57:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KoyOlFW9VfCGaehGcjF4wvmYpWIfHEL4OdkJeRIpIOg=; b=eEtV+43l02of Et3YA25rFG9MorxS7OvP2Cg9fYte/u16XZI+tE4nSQ+mX9Fyu4vpwnmmpPZymSJu4R+a/lhHcqFBX mEk5g3VCRDEElBD0E0fcKB2iBrcpYOn+tCt+iOCA9qkzDjAxtcOUCcNSPHU8dmyLLwW0iTyk+kWFw CfMcG3roHOHMFkBpW9ikwwacSp3d+blBKi63GEoiXxaRPwWAJCKCA5gb8KaIRiAGCMRtVBnpuqlU7 XO0H4QXb1iCy7mDf+2MAkeyzuQoY7FjrtDoaDK7/r7DcloppNrEBlBY7lktTiS2X56PrLC6Das8Ig cYPYcviFQMWXqyq7HfKbnA==; Date: Wed, 09 Jul 2025 13:57:47 +0300 Message-Id: <864ivlk4wk.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87ikk42bj2.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 07 Jul 2025 19:57:29 +0300) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <86wm8oxuqq.fsf@gnu.org> <87sej85x20.fsf@mail.linkov.net> <865xg4t7ua.fsf@gnu.org> <87ikk42bj2.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: monnier@iro.umontreal.ca, alcor@tilde.club, 78945@debbugs.gnu.org > Date: Mon, 07 Jul 2025 19:57:29 +0300 > > >> >> Looking at 'C-h l' (view-lossage) explains everything: > >> >> > >> >> C-x 5 5 ;; other-frame-prefix > >> >> ;; mouse-drag-region > >> >> ;; dired-mouse-find-file > >> > > >> > Sorry, it doesn't, not to me, probably because I don't understand well > >> > enough what "C-x 4 4" does and how. So please talk me through the > >> > code which implements "C-x 4 4" and explain how down-mouse-1 in the > >> > middle defeated it. Without that, I cannot understand the fix and its > >> > generality. > >> > >> The docstring of "C-x 4 4" says: > >> > >> Display the buffer of the next command in a new window. > >> > >> Clicking the mouse button runs two commands, so both should be handled here. > >> Or do you think this special case should be mentioned in the docstring? > > > > We should probably document it once we agree and understand the full > > effect of the change. > > > > Right now, I understand that: > > > > . "C-x 4 4" etc. can affect more than just one next command -- as > > long as the commands have the 'down' modifier, we will keep the > > override in effect -- is this expected or TRT? > > This is the right thing since it fixes the reported problem. Then it should be documented. Right now, we are talking about "the next command", singular. > > . If some command is bound to mouse-down event, it might not be the > > only command affected by "C-x 4 4" -- do we want that? > > Yes, we need to handle mouse-down and mouse-up commands. Again, should be documented. > > . What about commands bound to double clicks and triple clicks? > > This is doable. I think we should do it, then, to avoid subtle inconsistencies (and future bugs). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 07:14:48 2025 Received: (at 78945) by debbugs.gnu.org; 9 Jul 2025 11:14:48 +0000 Received: from localhost ([127.0.0.1]:49196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZSlD-0005Fu-S8 for submit@debbugs.gnu.org; Wed, 09 Jul 2025 07:14:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36294) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZSlB-0005FE-ES for 78945@debbugs.gnu.org; Wed, 09 Jul 2025 07:14:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZSl3-0001xI-5a; Wed, 09 Jul 2025 07:14:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KDELF+7BkaeSfiirJhvo5dvLoF9AsZu7ntPNkBpIygU=; b=NQUieuOdW66F LcW19D94hgO095ep03uzPFxOxhcfy/P4yAaEDYUv0LNuZM9riR4Ok7iy67qkCo6YBndu9lQn0YzQH +4RCmTX/ui+QKEW0PCyJjp7q67Z0WrbC8mbnPRQGSdTjOc/43Fs9f+nU4AB5dXdkwHfluPHQ6XuzJ 3LT6clE0NV3FtDtFpv1XAxJjZDxDpQvYYp+jeZ7+iPansHrQUatlBd3i1M5JwuZnnxx8TG6sabGh/ xtPf6qAlY3Rre2sw3iqWmB3Y4zgcJLRsyrfbutMXH54/kR/6oPZl9677ouQHmvu8o4JsdhFeJrsQY qm8Cxt7Lq9DVoDF1x7aodg==; Date: Wed, 09 Jul 2025 14:14:24 +0300 Message-Id: <8634b5k44v.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Mon, 07 Jul 2025 15:20:42 -0400) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, alcor@tilde.club, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 78945@debbugs.gnu.org, Eli Zaretskii , alcor@tilde.club > Date: Mon, 07 Jul 2025 15:20:42 -0400 > > >> The "normal" way to disable the override is by consuming it: > >> > >> ;; Reset display-buffer-overriding-action > >> ;; after the first display-buffer action (bug#39722). > >> (funcall clearfun) > >> > >> I'm not suggesting we leave the override active "indefinitely" for as > >> long as no `display-buffer` used it, but I don't expect any serious > >> problem if the override lingers a bit longer. > > > > The only potential problem is mistyped keys or accidental clicks. > > But since it's very rare then maybe this patch is ok: > > > > diff --git a/lisp/window.el b/lisp/window.el > > index ea102706ecb..a25af158a73 100644 > > --- a/lisp/window.el > > +++ b/lisp/window.el > > @@ -9673,9 +9680,9 @@ display-buffer-override-next-command > > ;; But don't remove immediately after > > ;; adding the hook by the same command below. > > (eq this-command command) > > - ;; Don't exit on mouse down event > > - ;; in anticipation of mouse release event. > > - (memq 'down (event-modifiers last-input-event))) > > + ;; Don't exit on mouse down event in anticipation > > + ;; of mouse release or double click event. > > + (mouse-event-p last-input-event)) > > (funcall exitfun)))) > > ;; Call post-function after the next command finishes (bug#49057). > > (add-hook 'post-command-hook postfun) > > LGTM. Does this mean any mouse-click command will cause the next command also be affected by "C-x 4 4" and friends? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 17:44:46 2025 Received: (at 78945) by debbugs.gnu.org; 9 Jul 2025 21:44:46 +0000 Received: from localhost ([127.0.0.1]:52853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZcar-0007wl-92 for submit@debbugs.gnu.org; Wed, 09 Jul 2025 17:44:46 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61186) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZcao-0007v6-K3 for 78945@debbugs.gnu.org; Wed, 09 Jul 2025 17:44:43 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 36B9980A0F; Wed, 9 Jul 2025 17:44:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1752097476; bh=PdtK10A5+UJu+JBcSfIi0T4L+bA9iQ8uFIFb44Led/U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=F2MYDCcL1TpkQs/JBm2TtL0AHHdjKhN3UB9y1f7MRgt/L+FLlpJm3wUVYmOQ7cl/+ IwV81gQGFWWCWYFHKQqfw/MpYWIvtDw/RCvbpH1Rl4vaNabckoM5dZTUfuEBZpRtiR TML/Kus4apWRVzoAp6CPRvml9A/5Ri3mokiz3o4qXbBUi/cgZ6p1VDDbjyQkaIGuax P8tCIUdFtU7+BJUYhjU5Czw9fJ6QcQNyuaXX0RvJo4Wi6cXn4E4tGJraiMN87mWQhi iNpIUXoN5jxzu1D2LGCRW3bB35gnzDHS2fnH+3UkzJxC+kPvET3yHBKJipevIreCCa 8FAuET20Zo39w== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6E29B80977; Wed, 9 Jul 2025 17:44:36 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 59076120AB0; Wed, 9 Jul 2025 17:44:36 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <8634b5k44v.fsf@gnu.org> Message-ID: References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> <8634b5k44v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Wed, 09 Jul 2025 17:44:36 -0400 MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, alcor@tilde.club, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > @@ -9673,9 +9680,9 @@ display-buffer-override-next-command >> > ;; But don't remove immediately after >> > ;; adding the hook by the same command below. >> > (eq this-command command) >> > - ;; Don't exit on mouse down event >> > - ;; in anticipation of mouse release event. >> > - (memq 'down (event-modifiers last-input-event))) >> > + ;; Don't exit on mouse down event in anticipation >> > + ;; of mouse release or double click event. >> > + (mouse-event-p last-input-event)) >> > (funcall exitfun)))) >> > ;; Call post-function after the next command finishes (bug#49057). >> > (add-hook 'post-command-hook postfun) >> >> LGTM. > > Does this mean any mouse-click command will cause the next command > also be affected by "C-x 4 4" and friends? Sometimes, yes. But only when the mouse-click command did not itself use `display-buffer`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 02:10:08 2025 Received: (at 78945) by debbugs.gnu.org; 10 Jul 2025 06:10:09 +0000 Received: from localhost ([127.0.0.1]:54681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZkTt-00013C-MJ for submit@debbugs.gnu.org; Thu, 10 Jul 2025 02:10:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39206) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZkTp-00010y-HF for 78945@debbugs.gnu.org; Thu, 10 Jul 2025 02:10:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZkTh-0002Tk-6l; Thu, 10 Jul 2025 02:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qi3G6Z5L9I5ld4A90LWmwn0QtcLhNZTQ5wFLvtaL6TM=; b=O8kRD6gl0SJW LVxsJIeyQ7l8560l3RXmxXXG9nMvr3K5lTQ9DllOn5H4OGlQHN4+BUwiLr7ajU+kRv5/nqStsxGqo DufQ2hBf46zHHbKAqbd0cWgiUyVPImOjSyY/B4t2ekmsiz8u2B91r86C6z0mHNpz46QAXCAJ5gdgI 68w3wjg6tfD/ddCmGlTPIcnKkpenY2K0aCtzAXkXXLzUcrWaELl2f+gKm8KUIGoNaT/+fnVz/VBxI josl5EDiDp4VQO6NwiSz+PCI+jblA6lG1zd9r9IO3JPnFKToAsH5XjQpX9+EIpo2MgUi4aGLY7084 6Hqn4ztH6EaSewO7gVlf1Q==; Date: Thu, 10 Jul 2025 09:09:49 +0300 Message-Id: <86wm8gh902.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Wed, 09 Jul 2025 17:44:36 -0400) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> <8634b5k44v.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, alcor@tilde.club, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: juri@linkov.net, 78945@debbugs.gnu.org, alcor@tilde.club > Date: Wed, 09 Jul 2025 17:44:36 -0400 > > >> > @@ -9673,9 +9680,9 @@ display-buffer-override-next-command > >> > ;; But don't remove immediately after > >> > ;; adding the hook by the same command below. > >> > (eq this-command command) > >> > - ;; Don't exit on mouse down event > >> > - ;; in anticipation of mouse release event. > >> > - (memq 'down (event-modifiers last-input-event))) > >> > + ;; Don't exit on mouse down event in anticipation > >> > + ;; of mouse release or double click event. > >> > + (mouse-event-p last-input-event)) > >> > (funcall exitfun)))) > >> > ;; Call post-function after the next command finishes (bug#49057). > >> > (add-hook 'post-command-hook postfun) > >> > >> LGTM. > > > > Does this mean any mouse-click command will cause the next command > > also be affected by "C-x 4 4" and friends? > > Sometimes, yes. But only when the mouse-click command did not itself > use `display-buffer`. I wonder how we could document this in user-facing terms, so that users would know what to expect from using these prefixes. Any ideas or suggestions? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 02:58:53 2025 Received: (at 78945) by debbugs.gnu.org; 10 Jul 2025 06:58:53 +0000 Received: from localhost ([127.0.0.1]:54937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZlF7-0008Cn-Ba for submit@debbugs.gnu.org; Thu, 10 Jul 2025 02:58:53 -0400 Received: from mout-y-111.mailbox.org ([91.198.250.236]:39860) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZlF4-0008CV-MS for 78945@debbugs.gnu.org; Thu, 10 Jul 2025 02:58:51 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4bd5KZ1t0sz9y05; Thu, 10 Jul 2025 08:58:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1752130722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2yuphlFpg4yqmQuN+cJEuEVyEQC3PZQ4D8jd5AGjusQ=; b=tWxQo6PBwo+OCUYa6DMNakT5RbNOcvF1bxTq1/FqGZE/XqjspAX4911nSaSwpU5uADYnT6 jTVooGa+UYoO2K5yHX0u8g7UlmnhaLovhq5PpjHVs5lt5eB8AAkxWIfF/CN82yBOG4zcox BPF/j/IxA2WjobSSZczWck9MNku7J1mAjdsy8Z4UAXUrwS+NHi4y4DdG3K1cG1N2oHF95a nlK3G22TUrTk4mYElflgIsuyIpgY2j5/m+opCix6ukTwS0uWyGbzdzbFLZo1otcRDGmpbS O+Yo1wEQmM4iQOEEsGsmp9Ue4GXbpUIcFMGndHLCkWdsEUVgIangMI296e0jOw== From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <86wm8gh902.fsf@gnu.org> Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> <8634b5k44v.fsf@gnu.org> <86wm8gh902.fsf@gnu.org> Date: Thu, 10 Jul 2025 09:58:08 +0300 Message-ID: <87sej4ilbz.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, Stefan Monnier , alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > Does this mean any mouse-click command will cause the next command >> > also be affected by "C-x 4 4" and friends? >> >> Sometimes, yes. But only when the mouse-click command did not itself >> use `display-buffer`. > > I wonder how we could document this in user-facing terms, so that > users would know what to expect from using these prefixes. Any ideas > or suggestions? I already documented this. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 03:29:58 2025 Received: (at 78945) by debbugs.gnu.org; 10 Jul 2025 07:29:58 +0000 Received: from localhost ([127.0.0.1]:55155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZljB-0004Mj-Nl for submit@debbugs.gnu.org; Thu, 10 Jul 2025 03:29:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55170) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZlj6-0004LC-5M for 78945@debbugs.gnu.org; Thu, 10 Jul 2025 03:29:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZliy-0002ba-Iz; Thu, 10 Jul 2025 03:29:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AWIoNJEucj7nnafe/04ZtFmRLyNM8eI7i8OwTUkvZU8=; b=li049gJNzDX3 27+HYcASHDaauLXOHhj0Iu/hUEJilX54Ni9h0Q45EMh6BWenGLfufmfGrW+w8RGec3Gnz8TShiRPU 8Hn9JS2DgM5LxWOUZK4AHsl8aSrBqUDtVJqBCob5oqZRm9fReCkMTuW7Cz9rFxdsvgYB8cDkVxGsk jw48zsJ75umHbJgJhX9ttFATJ+D7zDkYEh+Y5SEnE4NmEoYYuEdG3TuYP0w4NDuacGHQJdo7OLFKN 5wxyNt34l3BHM5OtPVC/4Y2kA4N2DLXfHk+nq8WOVKYmZwJFkLhRUvtEz243XmWpY0q7hYhnx6DXY Ur/JSH7Z16qlYGFftmMN6A==; Date: Thu, 10 Jul 2025 10:29:40 +0300 Message-Id: <86tt3kh5az.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87sej4ilbz.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 10 Jul 2025 09:58:08 +0300) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> <8634b5k44v.fsf@gnu.org> <86wm8gh902.fsf@gnu.org> <87sej4ilbz.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Stefan Monnier , 78945@debbugs.gnu.org, > alcor@tilde.club > Date: Thu, 10 Jul 2025 09:58:08 +0300 > > >> > Does this mean any mouse-click command will cause the next command > >> > also be affected by "C-x 4 4" and friends? > >> > >> Sometimes, yes. But only when the mouse-click command did not itself > >> use `display-buffer`. > > > > I wonder how we could document this in user-facing terms, so that > > users would know what to expect from using these prefixes. Any ideas > > or suggestions? > > I already documented this. I guess you mean the below? In case of multiple consecutive mouse events such as , a mouse release event , , all bound commands are handled until one of them displays a buffer. If so, I've seen this, thanks. But (a) it is IMO too terse to make the effect clear, and (b) the manuals don't document these prefixes at all AFAICS (I saw nothing in NEWS, either). From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 14:55:30 2025 Received: (at 78945) by debbugs.gnu.org; 10 Jul 2025 18:55:30 +0000 Received: from localhost ([127.0.0.1]:59675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uZwQc-0007AF-8b for submit@debbugs.gnu.org; Thu, 10 Jul 2025 14:55:30 -0400 Received: from mout-y-111.mailbox.org ([2001:67c:2050:103:465::111]:43146) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uZwQZ-00078c-KN for 78945@debbugs.gnu.org; Thu, 10 Jul 2025 14:55:28 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4bdPDR6fGmz9xyV; Thu, 10 Jul 2025 20:55:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linkov.net; s=MBO0001; t=1752173719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FzeJRqZBfO27c+7Wh7WNnXOMU9SeLJYMLtYa90Z+GmU=; b=p5WH+z3+KMjtxHnzey0KcZ2lByK6Vaj5slOkizcvJ/gxsErFSfFb41+bskHuWKqqB0syig XgENaQG8Xxscr+3zcLEVi7glYy+QNTLe+lNKAI2+FeqEWOd8dIaNWadyJPwUyW1nwc7TKy r9dmuunULAFKXMUMaemXeFza+Xp0c7/bnQO4TzkvjsO7rldcDfPQgE388Qs8HGdd3bEl3E MZKyYyTmJBdhg1ghU07D5ZX9rgCYzlOVWQNKQoWrWpLPs5OEJe9zm2MxSTPq7gHwj0LgOl xtYzaowg8ZFFzOJpqH0brRxtrDBaT/OhuLCQ90b0eelQE0nCMEr2twLRa7FpgQ== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of juri@linkov.net designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=juri@linkov.net From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <86tt3kh5az.fsf@gnu.org> Organization: LINKOV.NET References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> <8634b5k44v.fsf@gnu.org> <86wm8gh902.fsf@gnu.org> <87sej4ilbz.fsf@mail.linkov.net> <86tt3kh5az.fsf@gnu.org> Date: Thu, 10 Jul 2025 21:54:59 +0300 Message-ID: <87o6trg9ks.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4bdPDR6fGmz9xyV X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I guess you mean the below? > > In case of multiple consecutive mouse events such as , > a mouse release event , , > all bound commands are handled until one of them displays a buffer. > > If so, I've seen this, thanks. But (a) it is IMO too terse to make > the effect clear, and (b) the manuals don't document these prefixes at > all AFAICS (I saw nothing in NEWS, either). In what Info nodes they could be documented? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 02:26:37 2025 Received: (at 78945) by debbugs.gnu.org; 11 Jul 2025 06:26:38 +0000 Received: from localhost ([127.0.0.1]:34040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ua7DR-0006jN-IG for submit@debbugs.gnu.org; Fri, 11 Jul 2025 02:26:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54918) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ua7DO-0006j2-Su for 78945@debbugs.gnu.org; Fri, 11 Jul 2025 02:26:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ua7DH-0001m9-E2; Fri, 11 Jul 2025 02:26:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ORpc7sx9VVkdcrRDaTaRMieTwbJVanS/yUvMNmgB1+4=; b=cXvQY2UzY1Qd MF0KVSTUb2Kl0YSQzGZTWSBP9bIXSVMnZ6duGZ/X9PchJru3ZWknBXh/NtES3ljrznn8sXW4Mg5Mp uk5biRujC879sajbgKIT3aLm63LiA9N/rV39YvOR7x0Bi0FSrOR5wuUDApBBHgD25UZtPbjqO8Mik J1NzOwQIO+2DGk1+jonFcdWmZ1PXpvthSF0lsj6Q2doc3QhheyGIAfKXTBiGr0pxwJa3/OXTVS1LP tWN5Py5yCkEUJ2Ih9q4vVVjMJq7tvqFRIGiW8cCcLbKWWDu3Gt4koZPNI8VBaFfYJPbN00KmTd1zE 6wAwqWlUIKYv5McIyVV2Bw==; Date: Fri, 11 Jul 2025 09:26:15 +0300 Message-Id: <86h5zjgs54.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87o6trg9ks.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 10 Jul 2025 21:54:59 +0300) Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> <8634b5k44v.fsf@gnu.org> <86wm8gh902.fsf@gnu.org> <87sej4ilbz.fsf@mail.linkov.net> <86tt3kh5az.fsf@gnu.org> <87o6trg9ks.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, monnier@iro.umontreal.ca, alcor@tilde.club X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: monnier@iro.umontreal.ca, 78945@debbugs.gnu.org, alcor@tilde.club > Date: Thu, 10 Jul 2025 21:54:59 +0300 > > > I guess you mean the below? > > > > In case of multiple consecutive mouse events such as , > > a mouse release event , , > > all bound commands are handled until one of them displays a buffer. > > > > If so, I've seen this, thanks. But (a) it is IMO too terse to make > > the effect clear, and (b) the manuals don't document these prefixes at > > all AFAICS (I saw nothing in NEWS, either). > > In what Info nodes they could be documented? Actually, I see that I was mistaken: the user manual does describe "C-x 4 4" and "C-x 5 5", just without an index entry; I've now fixed that. However, the subtle effect on several mouse-bound commands still needs to be described there. As for the ELisp manual, I think the right place is in the "Prefix Keys" node. What I think we should describe there is that this prefix command works via display-buffer-alist, and also how the multiple mouse clicks are handled for this purpose. I also have a question: if I type "C-x 4 4" before a mouse-bound command that shows no buffer, does it mean that the next command (which could be arbitrary and unrelated) will be affected by the prefix? If so, we should mention this subtlety in the ELisp manual. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 10:18:20 2025 Received: (at 78945) by debbugs.gnu.org; 11 Jul 2025 14:18:20 +0000 Received: from localhost ([127.0.0.1]:38241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uaEZw-0007eG-7D for submit@debbugs.gnu.org; Fri, 11 Jul 2025 10:18:20 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53832) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uaEZt-0007dr-Lh for 78945@debbugs.gnu.org; Fri, 11 Jul 2025 10:18:18 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 53E7A10013E; Fri, 11 Jul 2025 10:18:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1752243490; bh=9AaQzk0GGGkngIsvWv4A8FbHXM73Z4o/oxgHO5zuXV4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=K3p6oxLPG8yYUhSPPE+8njZC18ohhMREknUrlGhMoHMlStb+wIDg8ch5zP/syYLHF oeG+/GDBDBBkaWDj8lnbFpNMV0jiT54zSh5oPVBcHfHXmHGimXG0coMS8guMYaEUyu N9ZRwSeDswtyxe+0GMZgLDuJbUL+Cfvn7Sqr2akdKxQeP6EvMaDpmdhtqLxqI3Pf2C znAFnvKzNRw+fbxJ327fh1yIU+3vd6V9HySPRp+dUl3A567LWolfydMSyuHi/qxJ9y 5tkN6IRqQAOoBVbY4KPVDHSnktzvZfdPLFlKTNi1uG7iUAjhY+btOoVMlthtgcKRrN 8WEouthANdLTQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A1C010002E; Fri, 11 Jul 2025 10:18:10 -0400 (EDT) Received: from pastel (unknown [104.247.225.139]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C6F97120372; Fri, 11 Jul 2025 10:18:09 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#78945: 30.1; C-x 4 4 and C-x 5 5 do not work with `dired-mouse-find-file' In-Reply-To: <86h5zjgs54.fsf@gnu.org> Message-ID: References: <87tt3uflwb.fsf@tilde.club> <86ikk9285o.fsf@gnu.org> <871pqxajk4.fsf@tilde.club> <87qzyx3hp5.fsf@mail.linkov.net> <87bjq1w6x2.fsf@tilde.club> <87ldp5jhzh.fsf@mail.linkov.net> <86bjq0zcz1.fsf@gnu.org> <87h5zstq2o.fsf@mail.linkov.net> <8734b85wsq.fsf@mail.linkov.net> <87jz4k0vur.fsf@mail.linkov.net> <8634b5k44v.fsf@gnu.org> <86wm8gh902.fsf@gnu.org> <87sej4ilbz.fsf@mail.linkov.net> <86tt3kh5az.fsf@gnu.org> <87o6trg9ks.fsf@mail.linkov.net> <86h5zjgs54.fsf@gnu.org> Date: Fri, 11 Jul 2025 10:18:00 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.285 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78945 Cc: 78945@debbugs.gnu.org, alcor@tilde.club, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I also have a question: if I type "C-x 4 4" before a mouse-bound > command that shows no buffer, does it mean that the next command > (which could be arbitrary and unrelated) will be affected by the > prefix? Yes. This is the undesirable consequence of the patch. For a single click, it is hard to fix this while still allowing `C-x 4 4` to apply to double-click commands since after the first click we don't know yet if another click is coming. We could try and add some hack with a `pre-command-hook` such that after a mouse event we disable the `C-x 4 4` if the next event is not among a specific subset of events (e.g. after a down event we keep the `C-x 4 4` alive but only if the next event is the corresponding up event). I'm not sure it's worth the trouble: most commands show no buffer, so in most cases the arbitrary/unrelated next command will not be affected by the lingering prefix anyway. Stefan From unknown Sat Aug 09 13:17:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Aug 2025 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator