Subject: Re: bug#78941: feature/igc [PATCH] igc_alloc_handler: use label "handler".

From: Pip Cet <[email-masked]>
Date: Wed, 09 Jul 2025 14:40:51 +0000

"Helmut Eller" <[email-masked]> writes:

> diff --git a/src/igc.c b/src/igc.c
> index 61886f5cf90..d0bd9eb63e8 100644
> --- a/src/igc.c
> +++ b/src/igc.c
> @@ -4625,7 +4625,9 @@ igc_alloc_blv (void)
>  void *
>  igc_alloc_handler (void)
>  {
> -  struct handler *h = igc_xzalloc_ambig (sizeof *h);
> +  static_assert (sizeof (struct handler) % IGC_ALIGN_DFLT == 0);

I see no reason for that to be true on the less alignmnent-friendly
ABIs.  Is it always true?

> +  struct handler *h = xzalloc (sizeof *h);
> +  root_create_ambig (global_igc, h, h + 1, "handler");

Looking forward to the day we keep our sys_jmp_buf structures on the C
stack so we no longer need an ambiguous root here.

Pip