GNU bug report logs - #78927
[PATCH] Update `fill-region-as-paragraph-semlf' to follow fill.el protocols

Previous Next

Package: emacs;

Reported by: Roi Martin <jroi.martin <at> gmail.com>

Date: Mon, 30 Jun 2025 11:11:01 UTC

Severity: normal

Tags: patch

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Roi Martin <jroi.martin <at> gmail.com>
Subject: bug#78927: closed (Re: bug#78927: [PATCH] Update `fill-region-as-paragraph-semlf'
 to follow fill.el protocols)
Date: Mon, 30 Jun 2025 21:35:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#78927: [PATCH] Update `fill-region-as-paragraph-semlf' to follow fill.el protocols

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 78927 <at> debbugs.gnu.org.

-- 
78927: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78927
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Roi Martin <jroi.martin <at> gmail.com>
Cc: 78927-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#78927: [PATCH] Update `fill-region-as-paragraph-semlf' to
 follow fill.el protocols
Date: Mon, 30 Jun 2025 17:34:06 -0400
> I've attached a new version of the patch.  It addresses Stefan's
> comments and reimplements the `fill-paragraph-semlf' function using
> `fill-paragraph' and `fill-region-as-paragraph-function'.

Thanks, pushed,


        Stefan


[Message part 3 (message/rfc822, inline)]
From: Roi Martin <jroi.martin <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Update `fill-region-as-paragraph-semlf' to follow fill.el
 protocols
Date: Mon, 30 Jun 2025 13:09:57 +0200
[Message part 4 (text/plain, inline)]
Tags: patch

This patch updates the `fill-region-as-paragraph-semlf' function to
follow the `fill-region-as-paragraph-function' protocol.  This allows to
delete the `fill-paragraph-semlf' function, which is replaced by
`fill-paragraph' combined with assigning
`fill-region-as-paragraph-semlf' to `fill-region-as-paragraph-function'.

Stefan, I also took the opportunity to remove the `with-restriction'
call from `fill-region-as-paragraph-semlf', as discussed in:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78561#47

Given that `fill-paragraph-semlf' is not part of any stable release of
GNU Emacs, I guess it is fine to remove it.  Is this a fair assumption?

        Roi

[0001-Update-fill-region-as-paragraph-semlf-to-follow-fill.patch (text/x-patch, attachment)]

This bug report was last modified 9 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.