GNU bug report logs - #78905
31.0.50; Extra dot in C-h k output

Previous Next

Full log

Message #31 received at 78905-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: stephen.berman <at> gmx.net, 78905-done <at> debbugs.gnu.org
Subject: Re: bug#78905: 31.0.50; Extra dot in C-h k output
Date: Thu, 26 Jun 2025 17:40:23 +0300

> From: Eshel Yaron <me <at> eshelyaron.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  78905 <at> debbugs.gnu.org
> Date: Thu, 26 Jun 2025 16:21:49 +0200
> 
> Hi,
> 
> Stephen Berman <stephen.berman <at> gmx.net> writes:
> 
> > On Thu, 26 Jun 2025 16:05:13 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >>> From: Stephen Berman <stephen.berman <at> gmx.net>
> >>> Cc: Eshel Yaron <me <at> eshelyaron.com>,  78905 <at> debbugs.gnu.org
> >>> Date: Thu, 26 Jun 2025 14:47:32 +0200
> >>> 
> >>> Since the sexp `(or remapped menus (princ "."))' is within a sexp
> >>> beginning `(when menus ...)' and nothing nullifies `menus' within that
> >>> sexp, doesn't this change then make `(princ ".")' a no-op?
> >>
> >> Sorry, a thinko.  The below is better, I hope.
> >>
> >> diff --git a/lisp/help-fns.el b/lisp/help-fns.el
> >> index 481360b..ff69227 100644
> >> --- a/lisp/help-fns.el
> >> +++ b/lisp/help-fns.el
> >> @@ -632,7 +632,7 @@ help-fns--key-bindings
> >>                               (format-message "`%s'" remapped)
> >>  		           "an anonymous command"))
> >>                    (princ "as well.\n"))
> >> -                (or remapped (princ "."))
> >> +                (or remapped (= (point) start) (princ "."))
> >>                  (fill-region-as-paragraph start (point))))
> >>              (ensure-empty-lines)))))))
> >
> > Yes, this is effectively equivalent to the patch I posted ;-)
> 
> Both variants seem to work over here :)

Thanks, installed, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.