From unknown Thu Aug 14 21:51:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78885: [PATCH] maint: assume that compilers support '\a' as specified by C89 Resent-From: Collin Funk Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Tue, 24 Jun 2025 04:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78885 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: 78885@debbugs.gnu.org X-Debbugs-Original-To: bug-sed@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17507402983446 (code B ref -1); Tue, 24 Jun 2025 04:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jun 2025 04:44:58 +0000 Received: from localhost ([127.0.0.1]:37520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uTvWj-0000tW-Iw for submit@debbugs.gnu.org; Tue, 24 Jun 2025 00:44:57 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34552) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uTvWh-0000rW-FT for submit@debbugs.gnu.org; Tue, 24 Jun 2025 00:44:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTvWQ-0001Gz-4s for bug-sed@gnu.org; Tue, 24 Jun 2025 00:44:38 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uTvWK-0004gS-7h for bug-sed@gnu.org; Tue, 24 Jun 2025 00:44:33 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-747fc7506d4so3863683b3a.0 for ; Mon, 23 Jun 2025 21:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750740270; x=1751345070; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=voy8B8z6eElZo51P5cQSC5hnLc+6PDnHaLFZjYBAOYc=; b=XAINjmCzIfu2oA1ipF9vBur6Gi7MhTIUCcAvvb+PLZ155g5PDf/WjTTqSw+Mq+2BvC NQ82EgO/v+PAXojmeR50MhARKuMwL2CeZA27omxYpn69nQ4gpl+81SzrArGQeYMD0lJP oTVbGYGSgmLmeJ0ObDrMeLyB21/ms6XlBLJlhgUsosUXrIaFjLFy/mhguPOF3MYsKXmC +nNlYLQqj63VRsKa1Pw7RnLuORTY97u/EJ+F18ZhZZ7Iz+lBf09Qrc9f3OKH7Nl7Jjxf 7WGItO9DZOI5RuW7s6GQe9dzbukMBY9JeTtfnsNohzLr+knKERL9m4bkCDhm1E5YkTME j2HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750740270; x=1751345070; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=voy8B8z6eElZo51P5cQSC5hnLc+6PDnHaLFZjYBAOYc=; b=nSJBhi0bPJEwjDeJTmPRMjlM3I0lF7BlC5bXZPmG7xojYnk871Arku9Th+L+qfovsX OfHKvq+DscFCu/Lt0bzGMoGYlS2YO/8pg3nyHkbJ5k3oWaz+0CBy7K5YqHRx1fh7jjZy w5Pxzj4Tmk0XEWpFokLTRYTHBffzslqT1XXeAwVp+jdKaPwZeV5sdXw8C2GwK5Lgb2v/ dLYFt3P9wBHUYDbJ3aJ5vBP+dargozLs1NwrhCh4sXsYCLdrIS4ukzjVbQoOod0jnX0M vcebQwSXMj3YJ9/zkvaJVhbJfx67aS27FJqTaVBlpY4vPr55Ue43azv7H04Zs9BCmWfs VCIA== X-Gm-Message-State: AOJu0YwzbCfDI1jqa2XHZwkCBZbjcsDEErUTSfzmvRISrZ6HbiNbUvV7 KqZWNQ6TKgwkjn/Iby0Yli5IA619Zy64cLuLFs7KaMr+WbqxtiAyl5vujDhxPLPO X-Gm-Gg: ASbGncsIvFKhWe2vC0TfhuHujoboEEX5g7KZR1tnqzBuP//wpWt/YocJDIdppC7k0+H s8lw1UNIW4nZPTxwGz25swyS3dG7wvI634UJZKNZ4Ettia20tmri4y17y5+eHLbYOo+9vnjJD2K +s9wXHYsQG2XORwshmKBbo2iNMNF3DKi0pq5PTupwq141GAUFGO+D6vQMnTBFdov/rGuph/ljYI /jI24gdk01MRQntIbTNIiMQ87sCQ4IpbzvKA9/bAx6FZ2PTehzdVeRwbtrvB0mhqMhRK2Hod/v4 vvhq4o4KPE62dO5OBwMuUO9qi0uEpemruXB+D2sdGD4= X-Google-Smtp-Source: AGHT+IFoVwGlepSwfNq+VV1zhYQxk7gXRYcj5VrHVjbd5xGFB42O8LUCbDMQAFNP1TARvqcsf4NPEQ== X-Received: by 2002:a05:6a20:729d:b0:21d:375a:ee33 with SMTP id adf61e73a8af0-22026e8226amr24741193637.9.1750740269866; Mon, 23 Jun 2025 21:44:29 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::b659]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b31f126a7c7sm9192813a12.70.2025.06.23.21.44.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 21:44:29 -0700 (PDT) From: Collin Funk Date: Mon, 23 Jun 2025 21:44:28 -0700 Message-ID: <87ldph695f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=collin.funk1@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, I noticed some very old code: #if defined __STDC__ && __STDC__-0 case 'a': *q++ = '\a'; p++; continue; #else /* Not STDC; we'll just assume ASCII */ case 'a': *q++ = '\007'; p++; continue; #endif Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (collin.funk1[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (collin.funk1[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain Hi, I noticed some very old code: #if defined __STDC__ && __STDC__-0 case 'a': *q++ = '\a'; p++; continue; #else /* Not STDC; we'll just assume ASCII */ case 'a': *q++ = '\007'; p++; continue; #endif This is from before C89 when '\a' was standardized. In sed/debug.c and in Gnulib we already assume it is supported. So the fallback code can be removed. And if compilers don't support it, they most certainly have other larger problems than this. :) Collin --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-maint-assume-that-compilers-support-a-as-specified-b.patch >From 8e8f528ee5142945d2206e9d17c41d3141051a01 Mon Sep 17 00:00:00 2001 Message-ID: <8e8f528ee5142945d2206e9d17c41d3141051a01.1750740211.git.collin.funk1@gmail.com> From: Collin Funk Date: Mon, 23 Jun 2025 21:36:40 -0700 Subject: [PATCH] maint: assume that compilers support '\a' as specified by C89 * sed/compile.c (normalize_text): Remove backup code for pre-C89 compilers. * sed/execute.c (do_list): Likewise. --- sed/compile.c | 4 ---- sed/execute.c | 4 ---- 2 files changed, 8 deletions(-) diff --git a/sed/compile.c b/sed/compile.c index 46b0bed..8a43945 100644 --- a/sed/compile.c +++ b/sed/compile.c @@ -1329,11 +1329,7 @@ normalize_text (char *buf, idx_t len, enum text_types buftype) if (*p == '\\' && p+1 < bufend && bracket_state == 0) switch (*++p) { -#if defined __STDC__ && __STDC__-0 case 'a': *q++ = '\a'; p++; continue; -#else /* Not STDC; we'll just assume ASCII */ - case 'a': *q++ = '\007'; p++; continue; -#endif /* case 'b': *q++ = '\b'; p++; continue; --- conflicts with \b RE */ case 'f': *q++ = '\f'; p++; continue; case '\n': /*fall through */ diff --git a/sed/execute.c b/sed/execute.c index adc7575..63c7cc5 100644 --- a/sed/execute.c +++ b/sed/execute.c @@ -936,11 +936,7 @@ do_list (intmax_t line_len) } else { *o++ = '\\'; switch (*p) { -#if defined __STDC__ && __STDC__-0 case '\a': *o++ = 'a'; break; -#else /* Not STDC; we'll just assume ASCII */ - case 007: *o++ = 'a'; break; -#endif case '\b': *o++ = 'b'; break; case '\f': *o++ = 'f'; break; case '\n': *o++ = 'n'; break; -- 2.49.0 --=-=-=-- From unknown Thu Aug 14 21:51:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78885: [PATCH] maint: assume that compilers support '\a' as specified by C89 Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Thu, 26 Jun 2025 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78885 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: Collin Funk Cc: 78885@debbugs.gnu.org Received: via spool by 78885-submit@debbugs.gnu.org id=B78885.175097905320426 (code B ref 78885); Thu, 26 Jun 2025 23:05:02 +0000 Received: (at 78885) by debbugs.gnu.org; 26 Jun 2025 23:04:13 +0000 Received: from localhost ([127.0.0.1]:54860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uUvdc-0005JO-JS for submit@debbugs.gnu.org; Thu, 26 Jun 2025 19:04:12 -0400 Received: from mail-pj1-f44.google.com ([209.85.216.44]:43167) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uUvdZ-0005I2-7Z for 78885@debbugs.gnu.org; Thu, 26 Jun 2025 19:04:09 -0400 Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-312e747d2d8so2449327a91.0 for <78885@debbugs.gnu.org>; Thu, 26 Jun 2025 16:04:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750979043; x=1751583843; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LkhTsWPHXTU78MVd3cdN+Y9e5FwzMHMHYl1W7SHFUVc=; b=n0NjkEoKdLmBS/jBo4dJSrczrV5NRRlZjJvFUSyKvz9AnQyEjzgwGvib1TfdU0XxXz iKGU5PNYmmfSZ21Q8vUxWuA4tbh1i9nzIZqIPVBnQ69royWNKtXTHaS8auRajbhHDpca atxPwYbDc1tzdcXoc7m8PR5bQp4v0OnNi+lTIFhRLrrXfe5e8JpaG8rV79WzWoNuL2d0 DtwtTWOsKq+OWQ3DoGbdKqqFtqxXvyXeh5F/YRmkmsxJbBVRljnV2GWPENjVte5fM0E7 xtm2rLYzWrRcHGQ6XnS+1wRNhZo+63BwVdhoW+vlxf+GF+CxLd+51yvxkMZpVr9ASKaj kZDg== X-Gm-Message-State: AOJu0YzGzQY9vJU7xcoK/V3tNNUJmIuf9Lbhy18fojqkqoqfVUBYo701 30j4egBCP1iIrqx2bukJOr3vstPvFh+Vs9FBVLuP6vPRa+505Da2D135YmUU3PcyYSn3jXqiO0m sIkbNBGZ4ZIscOp8eEMy6W1xtbh/jVtE= X-Gm-Gg: ASbGncs0pebAxBHeTAA7iNAq2Lqu89B8PBHjf7rmnY1rHG1rKeA+2UYQowKTNnIBwX3 Lv6xz9YzkZ29nvabGh1VeRuZdTRde8vywpZjJKIvoS5GrTS/voEq/OP98dCAqFbYLQoxH/nNRx6 atz1KgVtOGhIpDhjJ8cM7zmialdsZ3k101v5ZQD30c X-Google-Smtp-Source: AGHT+IE76X/4pF9nrU2zQpqWiXXm/vyuOopLzn5jRHDsdG7IMHVnXwftAPTuGbQ81MB0azeWvLku51ZnhQsVVZYcg28= X-Received: by 2002:a17:90b:4a4c:b0:315:9624:37db with SMTP id 98e67ed59e1d1-318c90f043bmr1214535a91.3.1750979042835; Thu, 26 Jun 2025 16:04:02 -0700 (PDT) MIME-Version: 1.0 References: <87ldph695f.fsf@gmail.com> In-Reply-To: <87ldph695f.fsf@gmail.com> From: Jim Meyering Date: Thu, 26 Jun 2025 16:03:50 -0700 X-Gm-Features: Ac12FXyW-ItBSxHIkMua4M9t5H11vvIOKyF7OxvTrvI3TBnN4RN3-j5d43JqvTU Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jun 23, 2025 at 9:45=E2=80=AFPM Collin Funk wrote: > I noticed some very old code: > > #if defined __STDC__ && __STDC__-0 > case 'a': *q++ =3D '\a'; p++; continue; > #else /* Not STDC; we'll just assume ASCII */ > case 'a': *q++ =3D '\007'; p++; continue; > #endif > > This is from before C89 when '\a' was standardized. In sed/debug.c and > in Gnulib we already assume it is supported. So the fallback code can be > removed. > > And if compilers don't support it, they most certainly have other larger > problems than this. :) Very old, indeed. Thanks. Applied. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 22 15:10:34 2025 Received: (at control) by debbugs.gnu.org; 22 Jul 2025 19:10:34 +0000 Received: from localhost ([127.0.0.1]:39500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ueINl-0007jv-S2 for submit@debbugs.gnu.org; Tue, 22 Jul 2025 15:10:34 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:47544) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ueINg-0007jL-LQ for control@debbugs.gnu.org; Tue, 22 Jul 2025 15:10:31 -0400 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-3137c2021a0so4502161a91.3 for ; Tue, 22 Jul 2025 12:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753211422; x=1753816222; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=7Qpdy8BNQLoT6ryzbIpXFFXHGhlLHy6y1cREszgxoAY=; b=aUVCxOTse6aWCQZZBAOlnTXKQYfdgZtY7fJGnLZEUdGwt98cvQ/L9ZKX3oRqttJ/uc KTXeXw/yuwfnGF2dYzpGbueUKHM5WmBFjsEMskeULKct86m6qSOi7gkxCrPTyUEmfY3B CZD7iQGapEBY0jyv06KjtQ3QRZ6VM2JBo7SHDpfcsFS1k79pWyrfwH0tl5b0FUMeqQcW NkighJpMBPdhOEmPWdji0xoWd+L2CJmbzMq7Hcu/bOnGz1aTJ8n+5rdqNB3gY6YTp2UO ka2/AXWBUrWeP8MVoFDviSLIXXSHqymBlDMOhf5JuQj0UX8IZPx1hJxW/1ipthgOAchs 0o8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753211422; x=1753816222; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7Qpdy8BNQLoT6ryzbIpXFFXHGhlLHy6y1cREszgxoAY=; b=lHKyWlUDYjTzGWyYfeH0LrZD9818gWeHaA081t9uK8HEjdmy/w67EWHNTAntK1Fk6S PSco3xu8mIF9qVBLIVhRY28rpwJ4abCx94wnsI7kFW5990W94ejMP1j0TQXTkPLTl4MW 2pPDMexe7A5mVJpdqaH09x2WFcIoelBXHmMs1ealIeDzoo3NyukqSCjt4GBs5P7I5mvb OswBu4QEMaNFCOJNzw/uNUUzdDFezzSjy+NsPbSiZO4XHbkdb+D9KZaUEG9/CXSpf+iW SOUYbuHJQmRrj7dNN6RBYtQT9k0aTf+fyMMEgK401hrLdaZ9klQTZ/B0g6JzLesCToz4 Dnzw== X-Gm-Message-State: AOJu0Yxujx37k9ORjGg6CMR7xbFlzsUvU009gpjz4b7pyzvknmDbA+/p OLxPAd14tbMaxOW17PM0TDyZPiCNvzMJHQvZnH247T9J0bP1fAYyP62Gm8Vj7Q== X-Gm-Gg: ASbGncvM5qO8JsIsY0ZR9hRGhAnP8Gk69YSv9WPDSs7pfPeDVOkYDjV0eyc7uuJGTSG bBPGWeF5EDZx5Ei3bnUgSP2A5lq/T+TjY6VvjQ7d6B44xXmUYDFoo/O4h2R75fQosQOxB5RKC3m o3pQFz8Qaukhzf9i2USHZ9x4DUdKm0a72RMOHWUxlFz1Thr94xVhG2/z+VBpnoiDMpK561hlyBf M/YeYuh+4ARIuOBEfpWkIWQg6nR0y2vOKKEhK1MM2wNCz5IGSdpexh8Vs0u1+GHEB0miHV4TnGv jbELUpB2IBNnb91edwfrDGs/w8LpLSfrXf44dI+v9q41bC9yp5+Ek9cnA2qHAKBr8t57yrw196A CUrg= X-Google-Smtp-Source: AGHT+IEY3DUitcjnySO2IAf0M/D3MIDGo23DAz+kITKjgTLtrFOpIs4JYcCs7A1rneZfIxzKp7Cfsw== X-Received: by 2002:a17:90b:254d:b0:313:f6fa:5bc6 with SMTP id 98e67ed59e1d1-31e507c491cmr695008a91.20.1753211422104; Tue, 22 Jul 2025 12:10:22 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::69a9]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b3f2fe67f8bsm7597528a12.5.2025.07.22.12.10.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 12:10:21 -0700 (PDT) From: Collin Funk To: control@debbugs.gnu.org Subject: Re: [PATCH] maint: assume that compilers support '\a' as specified by C89 Date: Tue, 22 Jul 2025 12:10:20 -0700 Message-ID: <87seiodotf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 78885 fixed close 78885 stop Closing since the patch was committed. Collin