GNU bug report logs - #78885
[PATCH] maint: assume that compilers support '\a' as specified by C89

Previous Next

Package: sed;

Reported by: Collin Funk <collin.funk1 <at> gmail.com>

Date: Tue, 24 Jun 2025 04:45:02 UTC

Severity: normal

Tags: fixed, patch

Done: Collin Funk <collin.funk1 <at> gmail.com>

To reply to this bug, email your comments to 78885 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-sed <at> gnu.org:
bug#78885; Package sed. (Tue, 24 Jun 2025 04:45:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Collin Funk <collin.funk1 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-sed <at> gnu.org. (Tue, 24 Jun 2025 04:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: bug-sed <at> gnu.org
Subject: [PATCH] maint: assume that compilers support '\a' as specified by C89
Date: Mon, 23 Jun 2025 21:44:28 -0700

[Message part 1 (text/plain, inline)]
Hi,

I noticed some very old code:

    #if defined __STDC__ && __STDC__-0
               case 'a': *q++ = '\a'; p++; continue;
    #else /* Not STDC; we'll just assume ASCII */
              case 'a': *q++ = '\007'; p++; continue;
    #endif

This is from before C89 when '\a' was standardized. In sed/debug.c and
in Gnulib we already assume it is supported. So the fallback code can be
removed.

And if compilers don't support it, they most certainly have other larger
problems than this. :)

Collin


[0001-maint-assume-that-compilers-support-a-as-specified-b.patch (text/x-patch, attachment)]
Information forwarded to bug-sed <at> gnu.org:
bug#78885; Package sed. (Thu, 26 Jun 2025 23:05:02 GMT) Full text and rfc822 format available.

Message #8 received at 78885 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: 78885 <at> debbugs.gnu.org
Subject: Re: bug#78885: [PATCH] maint: assume that compilers support '\a' as
 specified by C89
Date: Thu, 26 Jun 2025 16:03:50 -0700

On Mon, Jun 23, 2025 at 9:45 PM Collin Funk <collin.funk1 <at> gmail.com> wrote:
> I noticed some very old code:
>
>     #if defined __STDC__ && __STDC__-0
>                case 'a': *q++ = '\a'; p++; continue;
>     #else /* Not STDC; we'll just assume ASCII */
>               case 'a': *q++ = '\007'; p++; continue;
>     #endif
>
> This is from before C89 when '\a' was standardized. In sed/debug.c and
> in Gnulib we already assume it is supported. So the fallback code can be
> removed.
>
> And if compilers don't support it, they most certainly have other larger
> problems than this. :)

Very old, indeed. Thanks. Applied.
Added tag(s) fixed. Request was from Collin Funk <collin.funk1 <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 22 Jul 2025 19:11:01 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 78885 <at> debbugs.gnu.org and Collin Funk <collin.funk1 <at> gmail.com> Request was from Collin Funk <collin.funk1 <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 22 Jul 2025 19:11:02 GMT) Full text and rfc822 format available.
This bug report was last modified 18 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.