GNU bug report logs - #78881
[PATCH] New command 'toggle-mode-line-visibility'

Previous Next

Full log

Message #31 received at 78881 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, eg642616 <at> gmail.com
Cc: 78881 <at> debbugs.gnu.org
Subject: Re: bug#78881: [PATCH] New command 'toggle-mode-line-visibility'
Date: Sat, 05 Jul 2025 13:35:21 +0300

> Resent-To: bug-gnu-emacs <at> gnu.org
> Cc: 78881-done <at> debbugs.gnu.org
> Date: Sat, 05 Jul 2025 11:37:48 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> > Cc: 78881 <at> debbugs.gnu.org
> > Date: Sat, 28 Jun 2025 12:36:47 -0600
> > 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> > 
> > [...]
> > 
> > > Why "temporarily"?
> > >
> > > I would rephrase this:
> > >
> > >   This command toggles the mode-line visibility of the current buffer:
> > >   hides it if it is shown, and shows it if it's hidden.
> > 
> > Thanks, sending fixed patch:
> 
> Thanks, installed on the master branch, and closing the bug.

Sorry, I needed to revert that, because these changes failed the
bootstrap.

We cannot call define-minor-mode in bindings.el, because bindings.el
is loaded by loadup.el before loaddefs.el, and so define-minor-mode is
not yet known as an autoloaded macro.

One solution is to move the code to simple.el instead.  Stefan, do we
have something better, assuming we want this to live in bindings.el
for some reason?

Please in the future always test your changes by "make bootstrap", to
avoid problems of this kind.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.