GNU bug report logs - #78866
[PATCH] (Finsert_file_contents): Refine commit d07af40d8826

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 78866 <at> debbugs.gnu.org
Cc: <monnier <at> iro.umontreal.ca>
Subject: bug#78866: [PATCH] (Finsert_file_contents): Refine commit d07af40d8826
Date: Sun, 22 Jun 2025 22:28:31 -0400

[Message part 1 (text/plain, inline)]

Tags: patch

As requested in bug#78777, here's a separate bug report for the
following problem:

- Start with:

      % src/emacs -Q BUGS &
      % echo foo >>BUGS

- In the Emacs session type:

      a

  Notice how Emacs correctly prompts about "changed on disk, really edit".
  Hit `C-g` so we don't actually edit the buffer.

- In the Emacs session do:

      M-: (insert-file-contents "README" nil nil nil t) RET

  Notice how Emacs just blindly changed the contents of the buffer
  without prompting about "changed on disk, really edit".

I think this last step is an error, we should be prompted just as we are
with any other buffer modification that diverges from the file's contents.

The patch below does just that,


        Stefan

[0002-Finsert_file_contents-Refine-commit-d07af40d8826.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.