From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Roi Martin Original-Sender: "Debbugs-submit" Resent-CC: philipk@posteo.net, bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jun 2025 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 78855@debbugs.gnu.org Cc: Philip Kaludercic X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Philip Kaludercic Received: via spool by submit@debbugs.gnu.org id=B.17505068855498 (code B ref -1); Sat, 21 Jun 2025 11:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jun 2025 11:54:45 +0000 Received: from localhost ([127.0.0.1]:36254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uSwo1-0001Qc-0l for submit@debbugs.gnu.org; Sat, 21 Jun 2025 07:54:45 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uSwnx-0001QA-Gm for submit@debbugs.gnu.org; Sat, 21 Jun 2025 07:54:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSwng-0000P5-Fm for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2025 07:54:29 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSwnQ-0000WZ-UA for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2025 07:54:23 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-441ab63a415so27894045e9.3 for ; Sat, 21 Jun 2025 04:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750506713; x=1751111513; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=fVaqcH7BGokjd+Uo4eDaXOgCOyRzGMVukSV65NAuZ/M=; b=cEZNWMrkI5gXW5lgPw2fInN5M0/S1aOXY1V9e3hQcTkgJNFMbCavuQxREgTNjJKqaL tgxq/LXc3R6VW6jj9lr34MUmb6gslxyxNS8GwUc1MYi6AWEhK+HKVcByBRUPEXDma6HW MHouuwQimYSzpiAGHebOz+0zmdxwAGc5bOtmKktR4UzDyE5ZTKduY0ptLnxxSTiZZhuQ zdigObCUOF5SOvG+EhmENoemxQkX8qrRDJ9kO/5iNQhk4pEJORqr5eL0fuwkVw7AOeyD Jfv5dFmjRaRcWhdDvvxeXqBB3KEuLu89vCPO0DQop+KHCpF66M594Qjbjxw6j9+CW+oJ iC8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750506713; x=1751111513; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fVaqcH7BGokjd+Uo4eDaXOgCOyRzGMVukSV65NAuZ/M=; b=CrYYptgYp3P8Pe00xnKnbEwU4gsaCyE/sd+q0tmISveamBG0/L96sV1kdDgo1OwhB7 bf1n5bvImPMDygsIZKQR66L6F0uUsx12ZvAZXw3ASOJz0CvZtjiObL3lR7THXwdMGmYK lPXszblpT6VkODlDNjEVFtH94zEX3k4vUQOXkbdGbslcn9l/cakjcTUb1FvSlklJBzWW 1U92wz6mE/+DbpX1honjgzlQDGLXubFbAcfpR4lIaVrCc8s3YcmUb9A41bJ54DRxic4P 9Peok5HC7Qp3G4lC6mDeuvRy/0MS4bwfKhadGeK9S47AbR7xLid0g0UGeP8LPq5xc818 q9MQ== X-Gm-Message-State: AOJu0YzeIaLv9LW5emUS9pM0beSZ8tOMKQp/1lSBQtHNaizBZIqHggTI kJZ04dCwkH0GEPDqLfCiHgD4LC/lVA2Pay58sMKiXbeNi7Da+HChO1ka7qjLUQ== X-Gm-Gg: ASbGnctVqUKT9QQWELoQO8SqdU45vKGLZ9vtFtWcz9HtWBWnzXuhodwG+6DtEN8JjQy nmtfUdGTqLdkh9pT/TB6hCV0QA1Xl+XISfu2WC/PWGv8XVdE4H/J9m0xIXgCRsfgbWj7awjsa8f IrEqTbwOctiAV/Ehjyj+7Kp2H2jddeR6bYDFP7U+vCuWQsAX8JVKwZQRBprxs1rA+6nYXueE3MU I1cVwi4ADDY/Vr+ljteDe7XcuIHLpp9zUWICuikSqHXyGUyKUS6SMMuI3c2zuiYejQ++OgYK0XV td3t4x4pOwhInSPBhZCd6A8kMsk3G76bhEio2n66FlnQCi/KUCwohnjpSjmG X-Google-Smtp-Source: AGHT+IH11MApP8+Ud31us60aJjFOhEGCZSpaDqKSwtetr12fLCjnTA4IQ1f0BuJDQ4Jx2oI3Shk0Hg== X-Received: by 2002:a05:600c:314f:b0:43d:fa59:af97 with SMTP id 5b1f17b1804b1-453659c0d74mr49257715e9.32.1750506713386; Sat, 21 Jun 2025 04:51:53 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646fd74asm51678255e9.22.2025.06.21.04.51.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Jun 2025 04:51:52 -0700 (PDT) From: Roi Martin Date: Sat, 21 Jun 2025 13:51:48 +0200 Message-ID: <87y0tlb9d7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=jroi.martin@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch When `package-vc-install-from-checkout' is called interactively, it asks users to input a directory. If users have enabled `fido-mode', when selecting a directory and pressing RET, they will actually pass "/path/to/pkg/./" to the function. Because NAME defaults to the base name of DIR, it is assigned the value ".". That is problematic in several ways. First, the package would be named ".", which is unexpected. Second, the following code in `package-vc-install-from-checkout': (let* ((name (or name (file-name-base (directory-file-name dir)))) (pkg-dir (expand-file-name name package-user-dir)) ; ... (when (file-exists-p pkg-dir) (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) (package--delete-directory pkg-dir) (error "There already exists a checkout for %s" name))) (make-directory pkg-dir t) ; ... would assign `pkg-dir' the value of `package-user-dir', which is wrong. I.e. it would check for the existence of the wrong directory, it will try to create the wrong directory, etc. This patch expands the directory name passed by the user. So now the behavior of the command is: NAME defaults to the base name of DIR after being expanded. I don't think there is any case where the old behavior is expected by users. So, this change should not break any current use of the function. Is this a fair assumption? Is there any case where the old behavior can be useful? Roi --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Expand-DIR-arg-on-package-vc-install-from-checkout.patch >From 73d15ca95c2842949050f3c2f64b1991b36c54b0 Mon Sep 17 00:00:00 2001 From: Roi Martin Date: Sat, 21 Jun 2025 10:28:45 +0200 Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Expand the directory name passed to the `package-vc-install-from-checkout' function so that paths like "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that the package name defaults to "pkg" instead of ".". * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): Expand the provided directory name. --- lisp/emacs-lisp/package-vc.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index babc0b715245..69852e27107a 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -915,22 +915,23 @@ package-vc-checkout ;;;###autoload (defun package-vc-install-from-checkout (dir &optional name) "Install the package NAME from its source directory DIR. -NAME defaults to the base name of DIR. +NAME defaults to the base name of DIR after being expanded. Interactively, prompt the user for DIR, which should be a directory under version control, typically one created by `package-vc-checkout'. If invoked interactively with a prefix argument, prompt the user for the NAME of the package to set up." (interactive (let* ((dir (read-directory-name "Directory: ")) - (base (file-name-base (directory-file-name dir)))) + (base (file-name-base (directory-file-name (expand-file-name dir))))) (list dir (and current-prefix-arg (read-string (format-prompt "Package name" base) nil nil base))))) (package-vc--archives-initialize) - (let* ((name (or name (file-name-base (directory-file-name dir)))) + (let* ((dir (expand-file-name dir)) + (name (or name (file-name-base (directory-file-name dir)))) (pkg-dir (expand-file-name name package-user-dir)) (package-vc-selected-packages - (cons (list name :lisp-dir (expand-file-name dir)) + (cons (list name :lisp-dir dir) package-vc-selected-packages))) (when (file-exists-p pkg-dir) (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) -- 2.49.0 --=-=-=-- From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jun 2025 12:55:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Roi Martin Cc: 78855@debbugs.gnu.org, philipk@posteo.net Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.17505104582065 (code B ref 78855); Sat, 21 Jun 2025 12:55:04 +0000 Received: (at 78855) by debbugs.gnu.org; 21 Jun 2025 12:54:18 +0000 Received: from localhost ([127.0.0.1]:36938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uSxjd-0000XA-3l for submit@debbugs.gnu.org; Sat, 21 Jun 2025 08:54:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43294) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uSxjU-0000Vd-He for 78855@debbugs.gnu.org; Sat, 21 Jun 2025 08:54:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSxjO-0002CZ-49; Sat, 21 Jun 2025 08:54:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ttvTWKJdpd1MocJgd73TH5YeLDr2Vy7inToUKPFDeVU=; b=aZmwuDqU3K+J dbjR/OuQkK1WNJffc2zsJCYMdQKMaZRHmTCcHW8sXnusE9P02SPIXET3EiCOUb+k5oipeISxr/sXS dKC0/R/RCrB+tsC7OoB/gJCrvPlzLb6RBrNqiMe76NC7JJFTmWxpuQejUf0mJiKHbbYi0ucgTdKC8 aEOrEmQdqaIlbcfxHcDR6NPF3InLnxkg0q0SlJmwV3+4/SmxXXTiq0V98r1Zni4OyXUnphg9V3eTa AvsVtyRLJ2jiSEzaU+TrNH47a1qiaKe1SAwbfbgmao/OFOV5ymImwfsn0zmW8f3sYM7/8nYioDBbZ io3AefmBmOfcS06m84rbSg==; Date: Sat, 21 Jun 2025 15:53:58 +0300 Message-Id: <86tt49i7bt.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87y0tlb9d7.fsf@gmail.com> (message from Roi Martin on Sat, 21 Jun 2025 13:51:48 +0200) References: <87y0tlb9d7.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Philip Kaludercic > From: Roi Martin > Date: Sat, 21 Jun 2025 13:51:48 +0200 > > When `package-vc-install-from-checkout' is called interactively, it asks > users to input a directory. If users have enabled `fido-mode', when > selecting a directory and pressing RET, they will actually pass > "/path/to/pkg/./" to the function. Because NAME defaults to the base > name of DIR, it is assigned the value ".". That is problematic in > several ways. > > First, the package would be named ".", which is unexpected. > > Second, the following code in `package-vc-install-from-checkout': > > (let* ((name (or name (file-name-base (directory-file-name dir)))) > (pkg-dir (expand-file-name name package-user-dir)) > ; ... > (when (file-exists-p pkg-dir) > (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) > (package--delete-directory pkg-dir) > (error "There already exists a checkout for %s" name))) > (make-directory pkg-dir t) > ; ... > > would assign `pkg-dir' the value of `package-user-dir', which is wrong. > I.e. it would check for the existence of the wrong directory, it will > try to create the wrong directory, etc. > > This patch expands the directory name passed by the user. This is the right solution, IMO, but there are a few nits, see below. > (defun package-vc-install-from-checkout (dir &optional name) > "Install the package NAME from its source directory DIR. > -NAME defaults to the base name of DIR. > +NAME defaults to the base name of DIR after being expanded. This part of the change is not necessary: such fine implementation details should not be in the doc string. > (interactive (let* ((dir (read-directory-name "Directory: ")) > - (base (file-name-base (directory-file-name dir)))) > + (base (file-name-base (directory-file-name (expand-file-name dir))))) > (list dir (and current-prefix-arg > (read-string > (format-prompt "Package name" base) > nil nil base))))) > (package-vc--archives-initialize) > - (let* ((name (or name (file-name-base (directory-file-name dir)))) > + (let* ((dir (expand-file-name dir)) > + (name (or name (file-name-base (directory-file-name dir)))) Can we avoid this duplicate call to expand-file-name in the interactive invocation? From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Roi Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jun 2025 18:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78855@debbugs.gnu.org, philipk@posteo.net Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175053051213138 (code B ref 78855); Sat, 21 Jun 2025 18:29:03 +0000 Received: (at 78855) by debbugs.gnu.org; 21 Jun 2025 18:28:32 +0000 Received: from localhost ([127.0.0.1]:43108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uT2x6-0003Pp-3W for submit@debbugs.gnu.org; Sat, 21 Jun 2025 14:28:32 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:45243) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uT2x2-0003Om-WB for 78855@debbugs.gnu.org; Sat, 21 Jun 2025 14:28:30 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3a6d1369d4eso909108f8f.2 for <78855@debbugs.gnu.org>; Sat, 21 Jun 2025 11:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750530503; x=1751135303; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=a1HwzTGPmfqXB9apf16GjxOzzwZTtgM3LmzwLkeArMA=; b=ZsozAX8pEZgqZzJbLc6Xm4k6l+izTO9yV+YX1+xshZXeRvyQqpz3k9oTET+IUvj38p qDHwJLbK83pJORNJ+LfHL2DYDGFmwyl2jSpEQ84PUYN8kfEltAfzHvcy+s0zRQvuZoae c6gwMI9D6fWZbG6Zh4OEZJTmAWr6HB79FXQAAEajJ71hazu7C/YV7r5VX/GpoRsgDoeJ SaCq4VLfLNClKM9O+4bVfYKVSw1CoCjMT+uPcOMU4X513PgMpM0UBRn1F+CJE8nPyhYS 5CI8WHHvCxMIzcVrySXUcH5ZvCgjASqD78fihAvKXwrYWlKL+iNRb5SfRGVpGp7i3yv4 l4NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750530503; x=1751135303; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a1HwzTGPmfqXB9apf16GjxOzzwZTtgM3LmzwLkeArMA=; b=Dj8Nu00D4YPT+XsfDpW/LRG3ObwXY77tLEol8bIkssW0KCaJ4N2GcTtAVTtzd9uQSD vJElCtRXCeB/Ca45R4o0yxhOc7UB4lWlKOIERvJ9+7uoyf5eHjTMsKzEWMEge0pESFv+ XjyWYmFmw44IAUaOAz+V3u0xQ5tIyAdhg7S/Q/T7sDcPybX298aten5salAIz9nS0S2t FBndfiBXd++erDxiaAUjTWrZdqnYnBSB+17n05udE2UtnFpbduugEnLT2dQZdAb/B2Mb uwUorladm/942I1YJ3SaUs5k6bFu6cGIUqlMgFMiJs4D70RE/X5S8Jy4oi12btqKmpKb b/5g== X-Gm-Message-State: AOJu0YzhBN86A/08GdoOTNNodfPntE58cRHZQyJs/cYCokzlShN27fM1 tZvbprHdZr1/+0umWLY0GIv6ZHksQTLkB51XqKaqztg3/zmBbgovyhNv X-Gm-Gg: ASbGncs8ekCVAbfPzN8mcUxaU/33xxWTuHFNW0XGWTbQ4M1NM5TZKsPn7Xsfz3SR3UF DIKoodX5K5Wu3YXmg/hag4zSjTFQLIrb9rAd9miWLg7AJSuC781NcNCxBngtdtz9wzPxx+KJNrE uGZN4NR7kX8+UbanV6wpk2Cm6tthMPQoXBva05Ui6hu3NrbuOBvHnbxD6z5XeLdznA/aFoKSEAC zh51OGlQ76yDE9XXZblLfUtDfPbtwz2k/ooxRXMfDAIY4EftIXANEGs0YAzp+JmJJ0xWlIThQk+ 3CKIwsc8717Z4O5AKl5e3Nv4CBNHTgqnaY2LqPPqhphTL+6S/DXmzouAtWeA X-Google-Smtp-Source: AGHT+IEef8xG1q3OxmJDFZspLPOmvhySwZJW2zjoO75yOgdCOmaP+8uueNmGtokNQnO7kZRowlbtQA== X-Received: by 2002:adf:e19d:0:b0:3a4:cbc6:9db0 with SMTP id ffacd0b85a97d-3a6d12ea306mr5695500f8f.51.1750530502571; Sat, 21 Jun 2025 11:28:22 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535e983a4bsm94661385e9.13.2025.06.21.11.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Jun 2025 11:28:22 -0700 (PDT) From: Roi Martin In-Reply-To: <86tt49i7bt.fsf@gnu.org> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> Date: Sat, 21 Jun 2025 20:28:17 +0200 Message-ID: <87zfe154qm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> (interactive (let* ((dir (read-directory-name "Directory: ")) >> - (base (file-name-base (directory-file-name dir)))) >> + (base (file-name-base (directory-file-name (expand-file-name dir))))) >> (list dir (and current-prefix-arg >> (read-string >> (format-prompt "Package name" base) >> nil nil base))))) >> (package-vc--archives-initialize) >> - (let* ((name (or name (file-name-base (directory-file-name dir)))) >> + (let* ((dir (expand-file-name dir)) >> + (name (or name (file-name-base (directory-file-name dir)))) > > Can we avoid this duplicate call to expand-file-name in the > interactive invocation? I don't think so. If I'm not wrong, `interactive' must be located at top-level and be the first form in the body (not counting `declare'). Additionally, we also want to expand the directory name when the command is called from Emacs Lisp. So, I don't see how to deduplicate that call. In fact, (file-name-base (directory-file-name ...)) was already duplicated. Maybe because of the same reason? Any hint to avoid this? In any case, I've attached a new version of the patch that fixes the doc string issue and adds the bug number. Roi --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Expand-DIR-arg-on-package-vc-install-from-checkout.patch >From e9f920afb8f3987550ed30cef453a8f8d64de2fc Mon Sep 17 00:00:00 2001 From: Roi Martin Date: Sat, 21 Jun 2025 10:28:45 +0200 Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Expand the directory name passed to the `package-vc-install-from-checkout' function so that paths like "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that the package name defaults to "pkg" instead of "." (Bug#78855). * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): Expand the provided directory name. --- lisp/emacs-lisp/package-vc.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index babc0b715245..66bd84148755 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -921,16 +921,17 @@ package-vc-install-from-checkout If invoked interactively with a prefix argument, prompt the user for the NAME of the package to set up." (interactive (let* ((dir (read-directory-name "Directory: ")) - (base (file-name-base (directory-file-name dir)))) + (base (file-name-base (directory-file-name (expand-file-name dir))))) (list dir (and current-prefix-arg (read-string (format-prompt "Package name" base) nil nil base))))) (package-vc--archives-initialize) - (let* ((name (or name (file-name-base (directory-file-name dir)))) + (let* ((dir (expand-file-name dir)) + (name (or name (file-name-base (directory-file-name dir)))) (pkg-dir (expand-file-name name package-user-dir)) (package-vc-selected-packages - (cons (list name :lisp-dir (expand-file-name dir)) + (cons (list name :lisp-dir dir) package-vc-selected-packages))) (when (file-exists-p pkg-dir) (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) -- 2.49.0 --=-=-=-- From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jun 2025 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Roi Martin Cc: 78855@debbugs.gnu.org, philipk@posteo.net Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.17505330095499 (code B ref 78855); Sat, 21 Jun 2025 19:11:01 +0000 Received: (at 78855) by debbugs.gnu.org; 21 Jun 2025 19:10:09 +0000 Received: from localhost ([127.0.0.1]:43230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uT3bJ-0001QC-Tp for submit@debbugs.gnu.org; Sat, 21 Jun 2025 15:10:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60978) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uT3bE-0001OG-28 for 78855@debbugs.gnu.org; Sat, 21 Jun 2025 15:10:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uT3b8-0003BW-Or; Sat, 21 Jun 2025 15:09:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=L7W3L9Xtj5og2rj92wv1yQETQxew7EAaDjrwsYRa15s=; b=rn8wsCe3eREZ poe93CqSmQK55JVvqjXQLDVq2WBBYxAAdzVqxkknDQ9pnWVRD6Sq2pbcv1mQPEiYh/E7SJaidAwbp dyeEmas1TAij3l8U1K4J/cS3Jq0aONJhZNjdmEvYit8y6oQ54/wcoZI2C/AgUMaGcadkvn0OdJZqm tqbCcg2qySjpgl6YBvaPEYAB5SZOELvI1dM7evLjd0YxsLSUkjSogieVQ4XX6mrE5u9Npu9r0dz4p dCJF0Unp6MonbFWO3b9aaFKfwpGyH7BYJwouNZvfHBHT6tCTTHFE5Kz4HOfMi5JuQkHhmw5KdZ3up nQTvvb750CEjZQyvZinzyQ==; Date: Sat, 21 Jun 2025 22:09:51 +0300 Message-Id: <86jz54j4hs.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87zfe154qm.fsf@gmail.com> (message from Roi Martin on Sat, 21 Jun 2025 20:28:17 +0200) References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Roi Martin > Cc: 78855@debbugs.gnu.org, philipk@posteo.net > Date: Sat, 21 Jun 2025 20:28:17 +0200 > > Eli Zaretskii writes: > > >> (interactive (let* ((dir (read-directory-name "Directory: ")) > >> - (base (file-name-base (directory-file-name dir)))) > >> + (base (file-name-base (directory-file-name (expand-file-name dir))))) > >> (list dir (and current-prefix-arg > >> (read-string > >> (format-prompt "Package name" base) > >> nil nil base))))) > >> (package-vc--archives-initialize) > >> - (let* ((name (or name (file-name-base (directory-file-name dir)))) > >> + (let* ((dir (expand-file-name dir)) > >> + (name (or name (file-name-base (directory-file-name dir)))) > > > > Can we avoid this duplicate call to expand-file-name in the > > interactive invocation? > > I don't think so. If I'm not wrong, `interactive' must be located at > top-level and be the first form in the body (not counting `declare'). > Additionally, we also want to expand the directory name when the command > is called from Emacs Lisp. So, I don't see how to deduplicate that > call. But there are ways to know if the call was interactive, right? > In fact, > > (file-name-base (directory-file-name ...)) > > was already duplicated. Maybe because of the same reason? Any hint to > avoid this? It would be good to avoid that as well. However, while file-name-base is a very simple function that just transforms its string argument, expand-file-name is much more complex, and can be expensive, especially if the file name is remote. From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Roi Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jun 2025 12:20:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78855@debbugs.gnu.org, philipk@posteo.net Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175059476120704 (code B ref 78855); Sun, 22 Jun 2025 12:20:05 +0000 Received: (at 78855) by debbugs.gnu.org; 22 Jun 2025 12:19:21 +0000 Received: from localhost ([127.0.0.1]:47261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uTJfM-0005Nj-J2 for submit@debbugs.gnu.org; Sun, 22 Jun 2025 08:19:21 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:42076) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uTJfJ-0005MR-6N for 78855@debbugs.gnu.org; Sun, 22 Jun 2025 08:19:18 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3a4fd1ba177so2067746f8f.0 for <78855@debbugs.gnu.org>; Sun, 22 Jun 2025 05:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750594751; x=1751199551; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=gQu5yJRqpNxsXJtZtimhh34GT2ZpoSdTsgIKbRvUVjk=; b=b9Cg9UBJVtCIeBmabr9taWTwR04/e9Y6DnwSv1+p6yL4fA9aP9KkVLTt1j5ILuIj8c /9+MqSFLNcRhhBuJQ3jOzK1Fj0pwRA5FQledCGgsNVyoRyWlZvLORZosh/NrP5QCSSqO SZuh1BV85fSm3aSANkXMVWecaXQKTT9rzWPAMd5Z9vgvJdtKKueekmRWOCxE801oaD54 5kQO+MdlYLbUkiWUubAUNALQdFM8cLIVhgJqELO5FB1v1dF+QpZjxvdcxSHWQ5qSxcYQ tIbw3eJYjo0J5Lu6SyDQvStvMq96jiBnwh+P0EZNBgtwcIfmXp23tEHrMjhvmtQSqjoy Gbdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750594751; x=1751199551; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gQu5yJRqpNxsXJtZtimhh34GT2ZpoSdTsgIKbRvUVjk=; b=r5w8OykiqKqB24r1gPtOSEsh4/a0QRfvEsVKG0zb0bve47liKLQmFy9Wm41m1lBhJO FY4FtKC6tCU/JCzVsuRyElHcqbfDsyR9LrKkRFIlI8TMz3GPEqOzswvk3AdRNFt0WM3z RBFUXIiTHDLlgLhnfaNMsgCxwiM+pOINR6N2LJ0dEZXutCr3wUIaDAhtraG9KpWQTspl rx67WkFN+6phN0hVoyxXrfyBL+gnEkCKhz4TvMpHNOXvmQNLxXBUEppNQZyjl9Xo/cpU CD0sD0tvDigijzMdR8hObVZaSsbDBXtnvAwDHU3QLLtuLLRLtwlzXMeh86T+Urwx/Bk9 tkuQ== X-Gm-Message-State: AOJu0Yy2R/hOogBI5HS+iM2KXlmZpwzw1T5GRwrKcJ9pg8kAUrZJCc2N Cpf4C6mGqDme93irLL4681NPthW6sgc5pdqmizSyDvcEl2TmvfnHkFk8 X-Gm-Gg: ASbGnctGl829I9MM7uHfUKRczKowISuzXy8DNvk1/qAmPO+pgIXniFZ20DwfRs22DRT lrBriAZKMU0apUfoL5GpcimmqNB2Ka9sGnX7sUb9qHFrHxgz1BKaMZoaJGlW9c6/C0bTvNlAG0r 1JSDwSxgmjzhv512tLBXvoJ9Bc1JWMPPDu/hZIVo67UmOb/vP+6cH1ROw8z4nGH6EgjmTdXSpUO KuTAKc/eL1XaUKZtzXUU11HIuPpj/ERkdPCvXhinPriIBpbdyB9NY7H5lS+ejJcKLUETLHrVeN/ CznyUl8cPPizq7i15D4u/Csl93v0AZ2FR4pr8Gf/EsEVukzWKqHt2XZLJnA7 X-Google-Smtp-Source: AGHT+IEXGGg5FHFpkxVJDGmh0MfwKU5SITmw139cTgTkVxM9Xj4xnEwOcIUS68D4ZzoeEXN/xFAShw== X-Received: by 2002:adf:f4c5:0:b0:3a5:25e2:6129 with SMTP id ffacd0b85a97d-3a6d27eed4amr6712691f8f.21.1750594750652; Sun, 22 Jun 2025 05:19:10 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4536fefd2b4sm21820605e9.36.2025.06.22.05.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Jun 2025 05:19:09 -0700 (PDT) From: Roi Martin In-Reply-To: <86jz54j4hs.fsf@gnu.org> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> Date: Sun, 22 Jun 2025 14:19:04 +0200 Message-ID: <87tt4855qf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> >> (interactive (let* ((dir (read-directory-name "Directory: ")) >> >> - (base (file-name-base (directory-file-name dir)))) >> >> + (base (file-name-base (directory-file-name (expand-file-name dir))))) >> >> (list dir (and current-prefix-arg >> >> (read-string >> >> (format-prompt "Package name" base) >> >> nil nil base))))) >> >> (package-vc--archives-initialize) >> >> - (let* ((name (or name (file-name-base (directory-file-name dir)))) >> >> + (let* ((dir (expand-file-name dir)) >> >> + (name (or name (file-name-base (directory-file-name dir)))) >> > >> > Can we avoid this duplicate call to expand-file-name in the >> > interactive invocation? >> >> I don't think so. If I'm not wrong, `interactive' must be located at >> top-level and be the first form in the body (not counting `declare'). >> Additionally, we also want to expand the directory name when the command >> is called from Emacs Lisp. So, I don't see how to deduplicate that >> call. > > But there are ways to know if the call was interactive, right? Sorry, I thought you meant simplifying the code, not avoiding the second call at runtime. I've attached a new version of the patch. Roi --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Expand-DIR-arg-on-package-vc-install-from-checkout.patch >From 16610a7da2f947e043db7ed95525091712ac38ff Mon Sep 17 00:00:00 2001 From: Roi Martin Date: Sat, 21 Jun 2025 10:28:45 +0200 Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Expand the directory name passed to the `package-vc-install-from-checkout' function so that paths like "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that the package name defaults to "pkg" instead of "." (Bug#78855). * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): Expand the provided directory name. --- lisp/emacs-lisp/package-vc.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index babc0b715245..11e5af884d0a 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -920,17 +920,18 @@ package-vc-install-from-checkout under version control, typically one created by `package-vc-checkout'. If invoked interactively with a prefix argument, prompt the user for the NAME of the package to set up." - (interactive (let* ((dir (read-directory-name "Directory: ")) + (interactive (let* ((dir (expand-file-name (read-directory-name "Directory: "))) (base (file-name-base (directory-file-name dir)))) (list dir (and current-prefix-arg (read-string (format-prompt "Package name" base) nil nil base))))) (package-vc--archives-initialize) - (let* ((name (or name (file-name-base (directory-file-name dir)))) + (let* ((dir (if (called-interactively-p 'any) dir (expand-file-name dir))) + (name (or name (file-name-base (directory-file-name dir)))) (pkg-dir (expand-file-name name package-user-dir)) (package-vc-selected-packages - (cons (list name :lisp-dir (expand-file-name dir)) + (cons (list name :lisp-dir dir) package-vc-selected-packages))) (when (file-exists-p pkg-dir) (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) -- 2.49.0 --=-=-=-- From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jun 2025 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Roi Martin Cc: Eli Zaretskii , 78855@debbugs.gnu.org Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.17509704902845 (code B ref 78855); Thu, 26 Jun 2025 20:42:02 +0000 Received: (at 78855) by debbugs.gnu.org; 26 Jun 2025 20:41:30 +0000 Received: from localhost ([127.0.0.1]:54455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uUtPW-0000jn-6E for submit@debbugs.gnu.org; Thu, 26 Jun 2025 16:41:30 -0400 Received: from mout02.posteo.de ([185.67.36.66]:39429) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uUtPR-0000id-Ly for 78855@debbugs.gnu.org; Thu, 26 Jun 2025 16:41:28 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BE578240103 for <78855@debbugs.gnu.org>; Thu, 26 Jun 2025 22:41:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.net; s=1984.ea087b; t=1750970479; bh=5XH6EqRSQM8XcsmpwCgHnJ99Wgf4ik8pkSadiQ6CZa8=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=BbGOTi9f8K2xU6Ma5iXGkFfIt+QCyjSW+KSQdGwH77llYn03vkPp3PRsrUh+9/A+9 LzUX48DQSpIQgPjllO77IkwhyTaWF7kGVNCnvMOVG0XbVOsak8Fb5x0zVVExmgg1on nS8GAH+YBZp24zKPPGFTQtKzNV1boxNCs/aWnYCjBLN47INbsxkY/QU4ttcyCylZOb bAhNkzc89wKaR2kwbd0m9e26HtJExpPZYlaeNHZORakkQdCqRZFNRLuxO0+ar2Nc4o kxYTdpiGWriStyVZLobfKG/XDz4N8QZeSYC7jYCq6LD6QC2RxADQXs1d0kk8DrpsiZ HuBAt9ThrI66dItb/865k11xN/RLrRzJZoCe1FfQ4IDnFewrVO6Ef1SNijH3bEArIR Wuzq4/6W6VKVm9x4Zg7RSOD44hexPk4ZP1KmMuRNuWWcQtbVC05SpA38B/s/W4JI2R AEe/bs5j8j9a/h8HcUDAeEiDesqdmhP3JL3kA3hob2x7k2Sb7pf Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4bSrFB6xTlz9rxF; Thu, 26 Jun 2025 22:41:18 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <87tt4855qf.fsf@gmail.com> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Date: Thu, 26 Jun 2025 20:41:17 +0000 Message-ID: <878qleck2a.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Roi Martin writes: > Eli Zaretskii writes: > >>> >> (interactive (let* ((dir (read-directory-name "Directory: ")) >>> >> - (base (file-name-base (directory-file-name dir)))) >>> >> + (base (file-name-base (directory-file-name (expand-file-name dir))))) >>> >> (list dir (and current-prefix-arg >>> >> (read-string >>> >> (format-prompt "Package name" base) >>> >> nil nil base))))) >>> >> (package-vc--archives-initialize) >>> >> - (let* ((name (or name (file-name-base (directory-file-name dir)))) >>> >> + (let* ((dir (expand-file-name dir)) >>> >> + (name (or name (file-name-base (directory-file-name dir)))) >>> > >>> > Can we avoid this duplicate call to expand-file-name in the >>> > interactive invocation? >>> >>> I don't think so. If I'm not wrong, `interactive' must be located at >>> top-level and be the first form in the body (not counting `declare'). >>> Additionally, we also want to expand the directory name when the command >>> is called from Emacs Lisp. So, I don't see how to deduplicate that >>> call. >> >> But there are ways to know if the call was interactive, right? > > Sorry, I thought you meant simplifying the code, not avoiding the second > call at runtime. I've attached a new version of the patch. > > Roi > > From 16610a7da2f947e043db7ed95525091712ac38ff Mon Sep 17 00:00:00 2001 > From: Roi Martin > Date: Sat, 21 Jun 2025 10:28:45 +0200 > Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' > > Expand the directory name passed to the > `package-vc-install-from-checkout' function so that paths like > "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that > the package name defaults to "pkg" instead of "." (Bug#78855). > * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): > Expand the provided directory name. > --- > lisp/emacs-lisp/package-vc.el | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index babc0b715245..11e5af884d0a 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -920,17 +920,18 @@ package-vc-install-from-checkout > under version control, typically one created by `package-vc-checkout'. > If invoked interactively with a prefix argument, prompt the user > for the NAME of the package to set up." > - (interactive (let* ((dir (read-directory-name "Directory: ")) > + (interactive (let* ((dir (expand-file-name (read-directory-name "Directory: "))) > (base (file-name-base (directory-file-name dir)))) > (list dir (and current-prefix-arg > (read-string > (format-prompt "Package name" base) > nil nil base))))) > (package-vc--archives-initialize) > - (let* ((name (or name (file-name-base (directory-file-name dir)))) > + (let* ((dir (if (called-interactively-p 'any) dir (expand-file-name dir))) I do not get the advantage of this approach? Even if we ignore that `called-interactively-p' is tricky, the result is that whatever `dir' is bound to after this point has passed through `expand-file-name'? So isn't the first patch the simpler solution, with the same effect? > + (name (or name (file-name-base (directory-file-name dir)))) > (pkg-dir (expand-file-name name package-user-dir)) > (package-vc-selected-packages > - (cons (list name :lisp-dir (expand-file-name dir)) > + (cons (list name :lisp-dir dir) > package-vc-selected-packages))) > (when (file-exists-p pkg-dir) > (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Roi Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jun 2025 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: Eli Zaretskii , 78855@debbugs.gnu.org Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.17509740183981 (code B ref 78855); Thu, 26 Jun 2025 21:41:02 +0000 Received: (at 78855) by debbugs.gnu.org; 26 Jun 2025 21:40:18 +0000 Received: from localhost ([127.0.0.1]:54587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uUuKO-00011E-2j for submit@debbugs.gnu.org; Thu, 26 Jun 2025 17:40:18 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:49647) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uUuKJ-0000x3-Cr for 78855@debbugs.gnu.org; Thu, 26 Jun 2025 17:40:13 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3a365a6804eso940344f8f.3 for <78855@debbugs.gnu.org>; Thu, 26 Jun 2025 14:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750974005; x=1751578805; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=+4xzkN4hnecZXC4daCLIYSV9yGGSu7EnAWXkQO6Tm+8=; b=EWcjH8TrAiQTlKYBZjaHLq7SU0xHPc6f/lrqsqQW9fmRjd4nADSom2pgHLHlxqXwc1 Rjcjc6p9mFXHPVLeHRKwcR+Nwg41e5qTfaTzSFN8genIZPL1poAUUhal77WMeFrzOjXw CIfO21U0fefHMARjX+Kud4yB2gWu2BG2DYS8bfs7bMb5JBTGLX3dRMUGGcYN8fGYAFbZ b4UX0xwxwX6jS7cBCzFpQrAkNN/fd3bvbPsgvIn8KjeVNLpRlgsTr2SA5I4SKGDZ7Ull u+qdRaMjXoNyh/qdrt6ODxhsSoUyqVbF/VqEos2mp8PQ60+G5ZgCQz0OOUxOxDQRnC2k +AUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750974005; x=1751578805; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+4xzkN4hnecZXC4daCLIYSV9yGGSu7EnAWXkQO6Tm+8=; b=iMZDC51AHJuN2VwgH4EZwfD7pQrzSrk7JacRQLyIMQZ3t7P0MQRe9EBp0GqyHVw41r zsvguKYbkLNgeRNVqAyne1p5SmRBP8Y/QjlJIrcdhYbM8+vnMZlo/dNxpndQlvyCd1R7 gIqPvnZtxVGNdDPl+xfm47pDOv+mYCN5bTirreqROV+AVErit/hLteFZdmUTFZa7qqTn 6mNaqoVqdEqJO2mYyL1JZndjZheiVNmyhyBGdiFywjkxC42f3YN31378XjqdR3zUhtM1 b8RQHpzjphf/E9p9IQtdXHL3B+NyBmgcljSCnQ7kyrwC0AvRbZkR1ySMbnwE8TpH1Tnw bGFQ== X-Forwarded-Encrypted: i=1; AJvYcCXNmGmwg2dryerA3f1q4j6m2b1PsJByOpJfxH5R/TkI6zo4jA7dpDAHgIYaVEw+bz0OGcA0ag==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx9cMEzu9B53W1HtDX/3kwrzPtsywcZiFNCieYFBkoB22q1XEyn rSccQsN2uRRQJpZgCFTKjnyUWQVj3ovAHx4n1baKrQLiyvKQ3ChyLpRg8sefSw== X-Gm-Gg: ASbGncsBKdHy93zRiob1ehhGO9O1GCaChpD0q/yKGJhdsWcJhfKqkv+yXV8rCsOKEAR 49YPQ/IBQ9mUpKwRevXEWvnKWypitSJcL0LvaZ/Xl6dOFuuDvOhuuV0hEMTjGPdmfIN8xKNGxga FCGSPUT/ZnSftxpSLPhg32W145Gj+0QVd4oFoT+zaxz6pqc30fOCcwUJT7QrVH15wfwJIaorjSP zeIGyjz50iqYpp0tQJrCxNSGJxN6liOBOqt27456FrbGwCNPehkavRVEPHqv39oaOrrYhnobPZH RJuqyV6tm17lgEnK6g4OsxkCnOe02WLl/Lxf+jjuE3j5FeFhc/CWhCTAmx4CO21lsRCmts8= X-Google-Smtp-Source: AGHT+IEHvQAkOh+vj9MsaD2TTQNLZEpK6ZryslCLA1AGAh1/inY/mmM6u+oj2Hi7c7TThbbpi1nl3Q== X-Received: by 2002:a05:6000:2d09:b0:3a5:52b2:fa65 with SMTP id ffacd0b85a97d-3a8fdb2a75dmr714890f8f.5.1750974004411; Thu, 26 Jun 2025 14:40:04 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e59628sm892582f8f.81.2025.06.26.14.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jun 2025 14:40:04 -0700 (PDT) From: Roi Martin In-Reply-To: <878qleck2a.fsf@posteo.net> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> Date: Thu, 26 Jun 2025 23:40:03 +0200 Message-ID: <87v7oixjv0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: >> From 16610a7da2f947e043db7ed95525091712ac38ff Mon Sep 17 00:00:00 2001 >> From: Roi Martin >> Date: Sat, 21 Jun 2025 10:28:45 +0200 >> Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' >> >> Expand the directory name passed to the >> `package-vc-install-from-checkout' function so that paths like >> "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that >> the package name defaults to "pkg" instead of "." (Bug#78855). >> * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): >> Expand the provided directory name. >> --- >> lisp/emacs-lisp/package-vc.el | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> index babc0b715245..11e5af884d0a 100644 >> --- a/lisp/emacs-lisp/package-vc.el >> +++ b/lisp/emacs-lisp/package-vc.el >> @@ -920,17 +920,18 @@ package-vc-install-from-checkout >> under version control, typically one created by `package-vc-checkout'. >> If invoked interactively with a prefix argument, prompt the user >> for the NAME of the package to set up." >> - (interactive (let* ((dir (read-directory-name "Directory: ")) >> + (interactive (let* ((dir (expand-file-name (read-directory-name "Directory: "))) >> (base (file-name-base (directory-file-name dir)))) >> (list dir (and current-prefix-arg >> (read-string >> (format-prompt "Package name" base) >> nil nil base))))) >> (package-vc--archives-initialize) >> - (let* ((name (or name (file-name-base (directory-file-name dir)))) >> + (let* ((dir (if (called-interactively-p 'any) dir (expand-file-name dir))) > > I do not get the advantage of this approach? Even if we ignore that > `called-interactively-p' is tricky, the result is that whatever `dir' is > bound to after this point has passed through `expand-file-name'? So > isn't the first patch the simpler solution, with the same effect? Eli's point is: expand-file-name is much more complex, and can be expensive, especially if the file name is remote. With this approach we avoid calling `expand-file-name' twice. Roi From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jun 2025 06:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175100480719106 (code B ref 78855); Fri, 27 Jun 2025 06:14:01 +0000 Received: (at 78855) by debbugs.gnu.org; 27 Jun 2025 06:13:27 +0000 Received: from localhost ([127.0.0.1]:59180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uV2Kz-0004xx-QS for submit@debbugs.gnu.org; Fri, 27 Jun 2025 02:13:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60450) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uV2Ku-0004wH-EQ for 78855@debbugs.gnu.org; Fri, 27 Jun 2025 02:13:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uV2Kn-0000ta-65; Fri, 27 Jun 2025 02:13:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eTQVaVJ8Sr2laeYGJfC4ddF55CCGJUrbn2St30lDq8c=; b=Wj2eozNH5MFj QDx9spsesbsL3pnKR5FDBRZNQuqgx+rKcC3KT0kS6x71xzdWu9Yialm7nkH3nM5hj6PrUNrRrtRs+ +HE0M5q/9pBccazsTTtUy9bk64DNOrn61OHfV5Xfz/YIVmsbZV9iH0YEI5pRLwGCeriNE7EbTJTlO B575c92Y3daeAjrdzUgrpecZRu29IZ1IJFlJKl/8CJOAxULGTRbL41Mt/Eix4qWuCd2qUTNoyA9ie xmYWSDN6TfX04dqZYO62+SiYEfMbj5F7MueKpeHFsXkBW3UknXg1wBDh1gU4BAzhOtxd/Hu4n17BY hXEuADNbZL4ttCAr/cE2/A==; Date: Fri, 27 Jun 2025 09:13:06 +0300 Message-Id: <86ikkhbtl9.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <878qleck2a.fsf@posteo.net> (message from Philip Kaludercic on Thu, 26 Jun 2025 20:41:17 +0000) References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: Eli Zaretskii , 78855@debbugs.gnu.org > Date: Thu, 26 Jun 2025 20:41:17 +0000 > > Roi Martin writes: > > > Eli Zaretskii writes: > > > >>> > Can we avoid this duplicate call to expand-file-name in the > >>> > interactive invocation? > >>> > >>> I don't think so. If I'm not wrong, `interactive' must be located at > >>> top-level and be the first form in the body (not counting `declare'). > >>> Additionally, we also want to expand the directory name when the command > >>> is called from Emacs Lisp. So, I don't see how to deduplicate that > >>> call. > >> > >> But there are ways to know if the call was interactive, right? > > > > Sorry, I thought you meant simplifying the code, not avoiding the second > > call at runtime. I've attached a new version of the patch. > > > > Roi > > > > From 16610a7da2f947e043db7ed95525091712ac38ff Mon Sep 17 00:00:00 2001 > > From: Roi Martin > > Date: Sat, 21 Jun 2025 10:28:45 +0200 > > Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' > > > > Expand the directory name passed to the > > `package-vc-install-from-checkout' function so that paths like > > "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that > > the package name defaults to "pkg" instead of "." (Bug#78855). > > * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): > > Expand the provided directory name. > > --- > > lisp/emacs-lisp/package-vc.el | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > > index babc0b715245..11e5af884d0a 100644 > > --- a/lisp/emacs-lisp/package-vc.el > > +++ b/lisp/emacs-lisp/package-vc.el > > @@ -920,17 +920,18 @@ package-vc-install-from-checkout > > under version control, typically one created by `package-vc-checkout'. > > If invoked interactively with a prefix argument, prompt the user > > for the NAME of the package to set up." > > - (interactive (let* ((dir (read-directory-name "Directory: ")) > > + (interactive (let* ((dir (expand-file-name (read-directory-name "Directory: "))) > > (base (file-name-base (directory-file-name dir)))) > > (list dir (and current-prefix-arg > > (read-string > > (format-prompt "Package name" base) > > nil nil base))))) > > (package-vc--archives-initialize) > > - (let* ((name (or name (file-name-base (directory-file-name dir)))) > > + (let* ((dir (if (called-interactively-p 'any) dir (expand-file-name dir))) > > I do not get the advantage of this approach? Even if we ignore that > `called-interactively-p' is tricky, the result is that whatever `dir' is > bound to after this point has passed through `expand-file-name'? So > isn't the first patch the simpler solution, with the same effect? I would like to avoid running file names through expand-file-name more than once, because that call could be expensive. So in this case performance trumps simplicity, IMO. Of course, if there's a simpler way of avoiding duplicate calls to expand-file-name, we should use it, so if you have a suggestion for such a simpler way, please tell the details. From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jun 2025 09:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Roi Martin , philipk@posteo.net Cc: 78855@debbugs.gnu.org Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.17511041387589 (code B ref 78855); Sat, 28 Jun 2025 09:49:03 +0000 Received: (at 78855) by debbugs.gnu.org; 28 Jun 2025 09:48:58 +0000 Received: from localhost ([127.0.0.1]:48003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uVSB7-0001y4-7L for submit@debbugs.gnu.org; Sat, 28 Jun 2025 05:48:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57056) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uVSB3-0001wr-MY for 78855@debbugs.gnu.org; Sat, 28 Jun 2025 05:48:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uVSAy-0004m2-6B; Sat, 28 Jun 2025 05:48:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PD6Rcq3OlAtJ6RsNxi9yZujSCgu3EbJoWAtVnYgs1Zw=; b=mA+/lvpS5uKK 5XBFYkpzzRxSOcyWS8GH59iD5gZD75YiO6w3owG6blx9bazRSFmEc4hO+J2F+NxKDvyTwUzmw1t6T HQymO7MHpAJfD5rAtTrr5q6LPv16HzJJC7AEeDx6e/bdSj6krr7YZZwFO30oSJo33yCmwc0Jjjtx1 qLxRn6wY/5T5tBwhMUCb1MBfJMvNSkPR05V418G3xwvj1hsrchfuuNUXI+t9skB8bgbbgunJxqPK/ 5J1adzhGx9KG2lW78Sr3RxkppkW4T6ZylqIlc/xgF083XJpODucL4lKDPcOhee+bRxKcV3livBrj+ sLtYkZYyxomkMeVp4fRu8g==; Date: Sat, 28 Jun 2025 12:48:45 +0300 Message-Id: <86cyao6vsy.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87tt4855qf.fsf@gmail.com> (message from Roi Martin on Sun, 22 Jun 2025 14:19:04 +0200) References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Roi Martin > Cc: 78855@debbugs.gnu.org, philipk@posteo.net > Date: Sun, 22 Jun 2025 14:19:04 +0200 > > Eli Zaretskii writes: > > >> >> (interactive (let* ((dir (read-directory-name "Directory: ")) > >> >> - (base (file-name-base (directory-file-name dir)))) > >> >> + (base (file-name-base (directory-file-name (expand-file-name dir))))) > >> >> (list dir (and current-prefix-arg > >> >> (read-string > >> >> (format-prompt "Package name" base) > >> >> nil nil base))))) > >> >> (package-vc--archives-initialize) > >> >> - (let* ((name (or name (file-name-base (directory-file-name dir)))) > >> >> + (let* ((dir (expand-file-name dir)) > >> >> + (name (or name (file-name-base (directory-file-name dir)))) > >> > > >> > Can we avoid this duplicate call to expand-file-name in the > >> > interactive invocation? > >> > >> I don't think so. If I'm not wrong, `interactive' must be located at > >> top-level and be the first form in the body (not counting `declare'). > >> Additionally, we also want to expand the directory name when the command > >> is called from Emacs Lisp. So, I don't see how to deduplicate that > >> call. > > > > But there are ways to know if the call was interactive, right? > > Sorry, I thought you meant simplifying the code, not avoiding the second > call at runtime. I've attached a new version of the patch. Philip, is this okay to install? From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jun 2025 13:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175111840728601 (code B ref 78855); Sat, 28 Jun 2025 13:47:03 +0000 Received: (at 78855) by debbugs.gnu.org; 28 Jun 2025 13:46:47 +0000 Received: from localhost ([127.0.0.1]:49092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uVVtC-0007QV-1M for submit@debbugs.gnu.org; Sat, 28 Jun 2025 09:46:47 -0400 Received: from mout01.posteo.de ([185.67.36.65]:51263) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uVVt4-0007P1-5A for 78855@debbugs.gnu.org; Sat, 28 Jun 2025 09:46:38 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 15A7024002B for <78855@debbugs.gnu.org>; Sat, 28 Jun 2025 15:46:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.net; s=1984.ea087b; t=1751118387; bh=digFkL9ngDTpvzsoNyZ3GdouIMZ13bNpgkINPf4wmBg=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=DEj0yznGdFjbFyk5SPZTldJgslp6q918EeG3mT/Escgb+fhij04s/U8K8dUB4fVkD WulJ8GRlI9B44pOBj6WDArDY+y/MjvXg7tpbABTlk+FuVBba5obB/lBWtzvy+zJZtX zMV5g31XbwSFw7Sr0qnMsDRCu8QW6RErSdhalSDDZCU0dLQB5wup7+8XNkriITxNR3 N/+C7GwzTggUrInJjZLvdDEyiAHNygwjTUzNPUldk/b3ukmtl8qtY0xDhBKfa/Oten dKEy6yoLboPeV4jpkXNSIkBatfcnobEF3MXknx/mZfojHjn4m4nkSJVkG+0fjKf9zj XPzfqQi+TCVG6ZZdbpzmyJhbefBE9W3RVxG1rxtWwdUVpQk3brhPajLETg8t11mRJz PwrN5Uye2jQiR5ToQ+KsnQGXAk5sLglWULU+o+IApj/hHfFkxnMKKv+Merh839HIrk QW3cpRrSnPrttfzg3rx8OnDYXgL+O8nmZI+i3B+2RTkWgGlCLaq Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4bTtxY4Vy3z9rxh; Sat, 28 Jun 2025 15:46:25 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <86ikkhbtl9.fsf@gnu.org> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Date: Sat, 28 Jun 2025 13:45:32 +0000 Message-ID: <87o6u8asjn.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Eli Zaretskii , 78855@debbugs.gnu.org >> Date: Thu, 26 Jun 2025 20:41:17 +0000 >> >> Roi Martin writes: >> >> > Eli Zaretskii writes: >> > >> >>> > Can we avoid this duplicate call to expand-file-name in the >> >>> > interactive invocation? >> >>> >> >>> I don't think so. If I'm not wrong, `interactive' must be located at >> >>> top-level and be the first form in the body (not counting `declare'). >> >>> Additionally, we also want to expand the directory name when the command >> >>> is called from Emacs Lisp. So, I don't see how to deduplicate that >> >>> call. >> >> >> >> But there are ways to know if the call was interactive, right? >> > >> > Sorry, I thought you meant simplifying the code, not avoiding the second >> > call at runtime. I've attached a new version of the patch. >> > >> > Roi >> > >> > From 16610a7da2f947e043db7ed95525091712ac38ff Mon Sep 17 00:00:00 2001 >> > From: Roi Martin >> > Date: Sat, 21 Jun 2025 10:28:45 +0200 >> > Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' >> > >> > Expand the directory name passed to the >> > `package-vc-install-from-checkout' function so that paths like >> > "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that >> > the package name defaults to "pkg" instead of "." (Bug#78855). >> > * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): >> > Expand the provided directory name. >> > --- >> > lisp/emacs-lisp/package-vc.el | 7 ++++--- >> > 1 file changed, 4 insertions(+), 3 deletions(-) >> > >> > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> > index babc0b715245..11e5af884d0a 100644 >> > --- a/lisp/emacs-lisp/package-vc.el >> > +++ b/lisp/emacs-lisp/package-vc.el >> > @@ -920,17 +920,18 @@ package-vc-install-from-checkout >> > under version control, typically one created by `package-vc-checkout'. >> > If invoked interactively with a prefix argument, prompt the user >> > for the NAME of the package to set up." >> > - (interactive (let* ((dir (read-directory-name "Directory: ")) >> > + (interactive (let* ((dir (expand-file-name (read-directory-name "Directory: "))) >> > (base (file-name-base (directory-file-name dir)))) >> > (list dir (and current-prefix-arg >> > (read-string >> > (format-prompt "Package name" base) >> > nil nil base))))) >> > (package-vc--archives-initialize) >> > - (let* ((name (or name (file-name-base (directory-file-name dir)))) >> > + (let* ((dir (if (called-interactively-p 'any) dir (expand-file-name dir))) >> >> I do not get the advantage of this approach? Even if we ignore that >> `called-interactively-p' is tricky, the result is that whatever `dir' is >> bound to after this point has passed through `expand-file-name'? So >> isn't the first patch the simpler solution, with the same effect? > > I would like to avoid running file names through expand-file-name more > than once, because that call could be expensive. So in this case > performance trumps simplicity, IMO. Of course, if there's a simpler > way of avoiding duplicate calls to expand-file-name, we should use it, > so if you have a suggestion for such a simpler way, please tell the > details. I took a closer look at the code, and resolved my confusion. My only suggestion would be to use `file-name-absolute-p' instead of `called-interactively-p', or would this also be too expensive (then again, seeing as this is an interactive function, I am not under the impression that the slowdown of invoking the function twice could be /that/ slow, even with TRAMP involved (which doesn't seem that relevant, I expect that people are not going to be loading packages over the network...)). From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jun 2025 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175112078216938 (code B ref 78855); Sat, 28 Jun 2025 14:27:02 +0000 Received: (at 78855) by debbugs.gnu.org; 28 Jun 2025 14:26:22 +0000 Received: from localhost ([127.0.0.1]:50984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uVWVZ-0004P6-Cg for submit@debbugs.gnu.org; Sat, 28 Jun 2025 10:26:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37726) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uVWVU-0004O3-UG for 78855@debbugs.gnu.org; Sat, 28 Jun 2025 10:26:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uVWVP-0007zC-3z; Sat, 28 Jun 2025 10:26:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MdQaxP9VPAzXvih9fW05oSpgFHLux/4GYg8edpy7cJ0=; b=qypAF1NM3vrw TOaddgOmkuY7Y4wvMCJMiuZ3LPlazwGhXaeahc3RfvNgxizmC9kncHSp4yU1ZanO+QFosod1AMNdD pDNJYdsf7NBesbTM8CGAZdF0wUj8JF95SUwdL8OS7+iTHyrDpUx8/EdWil2ZToMS5Vv8eAVHlMJsz 9LtqRWAsuvMhIHBfHHsT/EJ0yYAjVZwclQiPnfjvR0HV3v1aihb3z6V3U4j5pH9jkw1I4bXbhTGDf ckVb1t5ddvx1IsLMYzjPUvBzpGos0B95YIYVfGObsz7f9313TDtI/q0eCuzav/qYLM0/H8iwxblMk ozEn2dIdT1pKdkp4HWj5+w==; Date: Sat, 28 Jun 2025 17:26:08 +0300 Message-Id: <86wm8w54e7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87o6u8asjn.fsf@posteo.net> (message from Philip Kaludercic on Sat, 28 Jun 2025 13:45:32 +0000) References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com > Date: Sat, 28 Jun 2025 13:45:32 +0000 > > Eli Zaretskii writes: > > > I would like to avoid running file names through expand-file-name more > > than once, because that call could be expensive. So in this case > > performance trumps simplicity, IMO. Of course, if there's a simpler > > way of avoiding duplicate calls to expand-file-name, we should use it, > > so if you have a suggestion for such a simpler way, please tell the > > details. > > I took a closer look at the code, and resolved my confusion. My only > suggestion would be to use `file-name-absolute-p' instead of > `called-interactively-p' That doesn't work, because file-name-absolute-p returns non-nil for ~/foo file names. > (then again, seeing as this is an interactive function, I am not > under the impression that the slowdown of invoking the function > twice could be /that/ slow, even with TRAMP involved (which doesn't > seem that relevant, I expect that people are not going to be loading > packages over the network...)). The function can also be invoked non-interactively, though. From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jun 2025 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: philipk@posteo.net Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175112122020891 (code B ref 78855); Sat, 28 Jun 2025 14:34:02 +0000 Received: (at 78855) by debbugs.gnu.org; 28 Jun 2025 14:33:40 +0000 Received: from localhost ([127.0.0.1]:50994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uVWce-0005Qs-3a for submit@debbugs.gnu.org; Sat, 28 Jun 2025 10:33:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44196) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uVWcZ-0005PG-DN for 78855@debbugs.gnu.org; Sat, 28 Jun 2025 10:33:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uVWcT-000138-TW; Sat, 28 Jun 2025 10:33:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+En63EVD5zhofWohtqg58z0DiRwpGjZtpbpcDLqK8fA=; b=Z5qp4ALkRPaU 44pdTBOfn0EM/4kmXIvlaUJM13haiGp/oxwDIdaxD5XSFUm3tNmnbGdl/o9MwOUnIgKOKaonq3ucn sZSr8BI8tTq0z9edlMiZ99/djUrRrT/dg0SEgqb3Bmbln6QzbpSs//Tn6pBzvhM3x0xoPNXmZo9Xo 9g82kFlyAG3L3FO9bJBUDh3uEUq7L4ERdsdSTs6d4rOdNrkPHeotGnIj63NPJDWmHlk6Ugza4otk7 LYmXwZXN3cu1gHPrxlKKz1hqBOefTRZon9ffAOfXcnLmE1nByFzjnVHZtObaqmNU4qNy94Qdkfl1z 1qGAEREAKDf4CQ6QguUnfg==; Date: Sat, 28 Jun 2025 17:33:27 +0300 Message-Id: <86v7og5420.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86wm8w54e7.fsf@gnu.org> (message from Eli Zaretskii on Sat, 28 Jun 2025 17:26:08 +0300) References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> <86wm8w54e7.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com > Date: Sat, 28 Jun 2025 17:26:08 +0300 > From: Eli Zaretskii > > > From: Philip Kaludercic > > Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com > > Date: Sat, 28 Jun 2025 13:45:32 +0000 > > > > (then again, seeing as this is an interactive function, I am not > > under the impression that the slowdown of invoking the function > > twice could be /that/ slow, even with TRAMP involved (which doesn't > > seem that relevant, I expect that people are not going to be loading > > packages over the network...)). > > The function can also be invoked non-interactively, though. And in addition, users are known to complain about slow responses of interactive functions. From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jun 2025 14:48:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175129484432619 (code B ref 78855); Mon, 30 Jun 2025 14:48:04 +0000 Received: (at 78855) by debbugs.gnu.org; 30 Jun 2025 14:47:24 +0000 Received: from localhost ([127.0.0.1]:45081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uWFn1-0008Ts-25 for submit@debbugs.gnu.org; Mon, 30 Jun 2025 10:47:24 -0400 Received: from mout01.posteo.de ([185.67.36.65]:52373) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uWFmt-0008Rq-IJ for 78855@debbugs.gnu.org; Mon, 30 Jun 2025 10:47:19 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6DC5B240028 for <78855@debbugs.gnu.org>; Mon, 30 Jun 2025 16:46:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.net; s=1984.ea087b; t=1751294822; bh=Yjebf4l+/8tg5K2i8z4fpHC8gQtbkGUC92whdeAXhaE=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=gOj6bCUr2OsDKR9Zx4AkLWaxhae03SJBBWAV7Fe32xgIYvJ6Y2YrS1mhBRK4s1PzZ MEO74fMB7WOzV56HFxqKuC376luBU5fOZisDoi4jn+3IeeELbJnm+iEBYS7zynd2sw hhGcD6Xu4m9jDGg8vghCux56h42/cHiPwd2grFevEr3MDxSh+XxIxKlVO97yiMtodL 7FtUu/CWroK1/QQrXab28M1xaHblfgORvHanfFWr/OIMpc8lQ0gDJ+lnTb5ZgwfyK6 6NQL6yPaxjl/BWL70gKFHcnhz7IOObkspJ6XnCRnIP3s/0WOU1TTMU6GFRmBwPg2wZ 3Bq70ltVulc+2pNaTH19kC+5twe1vtMNsO9u6EzDyMlV+vZNPifwD3RKu1u/HieyTl xLwydurykozrX44RbJJIjI7RjQB9oLRjoYuSbU/VtbnMQhOHr2x6QSunOg7BS4QM7m Fh11XFgx2rpLNrz5ktERBKbfTWf0Jtq51W9FWB5ACGZq9DNViIV Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4bW8BK00TCz9rxf; Mon, 30 Jun 2025 16:46:48 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <86wm8w54e7.fsf@gnu.org> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> <86wm8w54e7.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Date: Mon, 30 Jun 2025 14:46:40 +0000 Message-ID: <87h5zxb833.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com >> Date: Sat, 28 Jun 2025 13:45:32 +0000 >> >> Eli Zaretskii writes: >> >> > I would like to avoid running file names through expand-file-name more >> > than once, because that call could be expensive. So in this case >> > performance trumps simplicity, IMO. Of course, if there's a simpler >> > way of avoiding duplicate calls to expand-file-name, we should use it, >> > so if you have a suggestion for such a simpler way, please tell the >> > details. >> >> I took a closer look at the code, and resolved my confusion. My only >> suggestion would be to use `file-name-absolute-p' instead of >> `called-interactively-p' > > That doesn't work, because file-name-absolute-p returns non-nil for > ~/foo file names. Considering that we are only interested in the base-name, that should be fine, unless DIR is "~" -- which usually isn't a package directory, but I guess it is safer not to make assumptions like these. >> (then again, seeing as this is an interactive function, I am not >> under the impression that the slowdown of invoking the function >> twice could be /that/ slow, even with TRAMP involved (which doesn't >> seem that relevant, I expect that people are not going to be loading >> packages over the network...)). > > The function can also be invoked non-interactively, though. True, though I can say that it wasn't my intention and it should have been annotated that way. It is too late for that now, in my estimation, as it could break working code. Eli Zaretskii writes: >> Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com >> Date: Sat, 28 Jun 2025 17:26:08 +0300 >> From: Eli Zaretskii >> >> > From: Philip Kaludercic >> > Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com >> > Date: Sat, 28 Jun 2025 13:45:32 +0000 >> > >> > (then again, seeing as this is an interactive function, I am not >> > under the impression that the slowdown of invoking the function >> > twice could be /that/ slow, even with TRAMP involved (which doesn't >> > seem that relevant, I expect that people are not going to be loading >> > packages over the network...)). >> >> The function can also be invoked non-interactively, though. > > And in addition, users are known to complain about slow responses of > interactive functions. I remain unconvinced that two local file expansions would be that computationally intensive, but I adjusted the patch nevertheless to hopefully address the issue and reduce the number of file expansions. The main difference is that the command now takes an explicit argument to indicate interactive invocations, which I find preferable to the `called-interactively-p'-approach. Would appreciate comments: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index babc0b71524..37bad5f9ddd 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -913,24 +913,29 @@ package-vc-checkout (find-file directory))) ;;;###autoload -(defun package-vc-install-from-checkout (dir &optional name) +(defun package-vc-install-from-checkout (dir &optional name interactive) "Install the package NAME from its source directory DIR. -NAME defaults to the base name of DIR. -Interactively, prompt the user for DIR, which should be a directory -under version control, typically one created by `package-vc-checkout'. -If invoked interactively with a prefix argument, prompt the user -for the NAME of the package to set up." - (interactive (let* ((dir (read-directory-name "Directory: ")) - (base (file-name-base (directory-file-name dir)))) +NAME defaults to the base name of DIR. Interactively, prompt the user +for DIR, which should be a directory under version control, typically +one created by `package-vc-checkout'. If invoked interactively with a +prefix argument, prompt the user for the NAME of the package to set up. +If INTERACTIVE is non-nil, then the command will assume that argument +DIR is in expanded form, and function will not expand DIR again." + (interactive (let ((dir (expand-file-name (read-directory-name "Directory: ")))) (list dir (and current-prefix-arg - (read-string - (format-prompt "Package name" base) - nil nil base))))) + (let ((base (file-name-base + (directory-file-name + dir)))) + (read-string + (format-prompt "Package name" base) + nil nil base))) + :interactive))) (package-vc--archives-initialize) - (let* ((name (or name (file-name-base (directory-file-name dir)))) - (pkg-dir (expand-file-name name package-user-dir)) + (let* ((dir (if interactive dir (expand-file-name dir))) ;avoid double expansion + (name (or name (file-name-base (directory-file-name dir)))) + (pkg-dir (file-name-concat package-user-dir name)) (package-vc-selected-packages - (cons (list name :lisp-dir (expand-file-name dir)) + (cons (list name :lisp-dir dir) package-vc-selected-packages))) (when (file-exists-p pkg-dir) (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) --=-=-=-- From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jun 2025 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.175129826128976 (code B ref 78855); Mon, 30 Jun 2025 15:45:02 +0000 Received: (at 78855) by debbugs.gnu.org; 30 Jun 2025 15:44:21 +0000 Received: from localhost ([127.0.0.1]:45775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uWGg8-0007XE-LX for submit@debbugs.gnu.org; Mon, 30 Jun 2025 11:44:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56034) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uWGg4-0007WG-UH for 78855@debbugs.gnu.org; Mon, 30 Jun 2025 11:44:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWGfz-0001fp-D5; Mon, 30 Jun 2025 11:44:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gmK0uYxmZ8+1fIgwsbZuDHqhDyXp+ytix7aCL1rVoSk=; b=I7Q2gWVxhPoN MS2su+xW5eOdiC4VZzdnVP2DULr3zCKYMsWmiBbTFRpmyctefqXlEnMa9dBoT4Km5B5KDD9HqOsnh tirCciFS0FddecpFb+VzcZIrj/VdOeNaEbl8VQ9jWv977/EKTR7Jydo5q8f7IdGmsaQGcMqvfUtuU eqNLMsAxhOXSm+6A2v7y7zWALTrlrgA1aV+v1wGqyzmknEl4q2uS5wh03GCswL7W1ApX9WRcBT+Uo KKOfKOOziXm3tIkPz69sI6u8IG8MVn/4k+vnoYmqB7s1av1WQHGK1ukPD7YoyPYoFms7GvfCbdejg OeHxW3d5MU4xkERWrQJTvg==; Date: Mon, 30 Jun 2025 18:43:33 +0300 Message-Id: <8634bh44m2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h5zxb833.fsf@posteo.net> (message from Philip Kaludercic on Mon, 30 Jun 2025 14:46:40 +0000) References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> <86wm8w54e7.fsf@gnu.org> <87h5zxb833.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com > Date: Mon, 30 Jun 2025 14:46:40 +0000 > > I remain unconvinced that two local file expansions would be that > computationally intensive, but I adjusted the patch nevertheless to > hopefully address the issue and reduce the number of file expansions. > The main difference is that the command now takes an explicit argument > to indicate interactive invocations, which I find preferable to the > `called-interactively-p'-approach. Would appreciate comments: Thanks, LGTM, but I suggest a slight rewording of the doc string: "Install the package NAME from its source directory DIR. NAME defaults to the base name of DIR. Interactively, prompt the user for DIR, which should be a directory under version control, typically one created by `package-vc-checkout'. If invoked interactively with a prefix argument, prompt the user for the NAME of the package to set up. If the optional argument INTERACTIVE is non-nil (as happens interactively), DIR must be an absolute file name." From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jun 2025 21:31:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.17513190248880 (code B ref 78855); Mon, 30 Jun 2025 21:31:03 +0000 Received: (at 78855) by debbugs.gnu.org; 30 Jun 2025 21:30:24 +0000 Received: from localhost ([127.0.0.1]:50478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uWM50-0002J5-UC for submit@debbugs.gnu.org; Mon, 30 Jun 2025 17:30:23 -0400 Received: from mout01.posteo.de ([185.67.36.65]:52895) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uWM4y-0002Hs-1M for 78855@debbugs.gnu.org; Mon, 30 Jun 2025 17:30:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 91BFF240028 for <78855@debbugs.gnu.org>; Mon, 30 Jun 2025 23:30:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.net; s=1984.ea087b; t=1751319013; bh=J/e44GpoMpmJ+Kf5BDK3z/fyw+btwdFCGWXBLT59RA0=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=AAtxoPoWRzpG/eosz74rym2JwS4MWvGT3TKT5WjnKb7UA2J47GXZiU4sNicbsq2+R Bvu/XAqeMx7qUYIUxXKlxgfQ/WfuvORvKBjxdG6IG5VLfOmtS408PmxoEcwN9eZGJL YCURxyRrHtNeHcFhu54/9cZTYlcAriIsARx251OCISnEKsr8gwIqlqhKofzPo+tjCL FdhKGAINf1xOcqLCl+SIw1Z4/RslOlKgm2xw9SiglQmJ55TqzeK7pDK1xKLFfUznfw /is+NXIboxOscRIZ7q5ovbCMEXAxgUnXnOSLRF+3PauO9P3rYjHUVI74L2/WUygHZE 5nVwRNeyyzThrzCdA4PmiHkSdryXQrN/Qr2C8VF2UScgd+qU2O5KaPumkce3KQFWpL Lh9lRB56yJUXJDngpZSdJkIwptm3CkLOx5gaiBUWYWQpk977TvroGOC96J+1zrH4K6 dKKatvtXVnJWW97gRxo/TpKRbLyI4EKPchwXP03gP/jmXilpDTL Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4bWK7m5MgXz6tws; Mon, 30 Jun 2025 23:30:12 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <8634bh44m2.fsf@gnu.org> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> <86wm8w54e7.fsf@gnu.org> <87h5zxb833.fsf@posteo.net> <8634bh44m2.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Date: Mon, 30 Jun 2025 21:30:10 +0000 Message-ID: <87cyakc3z1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 78855@debbugs.gnu.org, jroi.martin@gmail.com >> Date: Mon, 30 Jun 2025 14:46:40 +0000 >> >> I remain unconvinced that two local file expansions would be that >> computationally intensive, but I adjusted the patch nevertheless to >> hopefully address the issue and reduce the number of file expansions. >> The main difference is that the command now takes an explicit argument >> to indicate interactive invocations, which I find preferable to the >> `called-interactively-p'-approach. Would appreciate comments: > > Thanks, LGTM, but I suggest a slight rewording of the doc string: > > "Install the package NAME from its source directory DIR. > NAME defaults to the base name of DIR. Interactively, prompt the user > for DIR, which should be a directory under version control, typically > one created by `package-vc-checkout'. If invoked interactively with a > prefix argument, prompt the user for the NAME of the package to set up. > If the optional argument INTERACTIVE is non-nil (as happens > interactively), DIR must be an absolute file name." Will change that. Just want to know what Roi thinks of the change, and if I should commit it under my or their name? From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Roi Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Jul 2025 06:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic , Eli Zaretskii Cc: 78855@debbugs.gnu.org Received: via spool by 78855-submit@debbugs.gnu.org id=B78855.17513526159310 (code B ref 78855); Tue, 01 Jul 2025 06:51:02 +0000 Received: (at 78855) by debbugs.gnu.org; 1 Jul 2025 06:50:15 +0000 Received: from localhost ([127.0.0.1]:54208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uWUom-0002Pw-BW for submit@debbugs.gnu.org; Tue, 01 Jul 2025 02:50:14 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:44200) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uWUof-0002O1-Gh for 78855@debbugs.gnu.org; Tue, 01 Jul 2025 02:50:09 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3a6e2d85705so2882234f8f.0 for <78855@debbugs.gnu.org>; Mon, 30 Jun 2025 23:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751352588; x=1751957388; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=57z7oNq+LpHzBCLcGZKqAOvH8bQuCYdjhq8K9gWFZNs=; b=a1PCK3l/FvEqc0Z8ec+ioq4VMvdsMU5GiJNuvb14O55BlkO17g5VjzhXsheQvtPSnx GKgYspjWDJrt+nN4ZIboq6f47cTLEJnEWLi0bNjDdK0s0LQkckCgwhLqjm6kzYZ/avOK f9z/32GUg+4PRHPqQb5nXB3WsW45uUfbTV7kmQJoPIMZpRHDML4vIxQF9MNnctpwWteX MNAory5inOE3lHHREysnL+aqlsh/qv68uqxdkKMTpBEleTo9/5AjIcq4yhcrwU2WWyan 51N2KWCKpUvECbkUBwLO9LRh6El+rPbmmB8NYd4s+iKaUnBVEuKc3NgC2ISf+WlawIKM qoFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751352588; x=1751957388; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=57z7oNq+LpHzBCLcGZKqAOvH8bQuCYdjhq8K9gWFZNs=; b=r6Pl5Szs0SuXS+o6JAchfQo0o9yAvQ7XO1WypemPKwqz482LuYgSAvAFYX08fxhmSL hd9K+YfGkm6CVOtNYxETQ0z7Lden3iV7/EqxXQA1nEyRcB0BndlWpLhnRqdCZ9N1W1mS uUEBOSTQMs18VewTeKOOVu69hiNQ6tDanXGi/bql6gVBm2C7CWJrJRkzkddEMXZgXyTE cUujUDMkmsh2/j4JT9KxWbHo1bZgIvyhOeiT3I5W90b9gQLbwtYQOGxvCw5zYUQVtiCd WFC+59J5fzukFFLwm7vQD2xXELGJzpA6k1mbrT2ajD8jVG1MuFzjDh6ZE4ZINQZXZn/x NdPw== X-Gm-Message-State: AOJu0YzazEhOici5P9vb24V2DwfzMYSG+luCnEZlHgXSzdWb2hg/Yh7E UYYQP5iqodYzdqNJX3ATX9YZ48N5ILPmZFVVRstbu1SMMfvbSi2HZJ1I6NsGwwJN X-Gm-Gg: ASbGncvrnX/Fnekwi1we3wzztX6VtAILZagWSbLsmqtBvdpbPbt7qh7vG9chcfAfZ5x X4ytWDdv7JZNLf4Sp2zWrAMr7kNnkiruzadpXBH2ul3wZoD+DijkZ4Ba3fUMtkaTFA88yqMH+Oq xifue3SE6wBiYT5xhy0/czV3mYWArqpnGNceAIu0jdHVcze+7l6dkxoGNGd83Nw+w71+JDPGl3+ BzGLio9b2pxsqDHqGX2F5OfIAmnIS+JN0nT5rRPHRHidw83yueyl1xiO7vCxzoA1PeGuIPksjhR 9xBEZvsPqAaN4B+XlGVk1M8mSszfHup0dCXp/pIPqyDihXBzb5PFkLQIfJSi X-Google-Smtp-Source: AGHT+IFstgpAK7/rSCTXnHS3EtGVxMwSWXC2socVC0dGT4phUM8Vx3utepvJVUyJszlgRsYNqv4KbQ== X-Received: by 2002:adf:b612:0:b0:3a4:df80:7284 with SMTP id ffacd0b85a97d-3a8fdb29f36mr11307216f8f.1.1751352587547; Mon, 30 Jun 2025 23:49:47 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453a1914d10sm46160625e9.4.2025.06.30.23.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 23:49:47 -0700 (PDT) From: Roi Martin In-Reply-To: <87cyakc3z1.fsf@posteo.net> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> <86wm8w54e7.fsf@gnu.org> <87h5zxb833.fsf@posteo.net> <8634bh44m2.fsf@gnu.org> <87cyakc3z1.fsf@posteo.net> Date: Tue, 01 Jul 2025 08:49:41 +0200 Message-ID: <87y0t8csmy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > Will change that. Just want to know what Roi thinks of the change, and > if I should commit it under my or their name? LGTM. Please, commit it under your name. Thanks for giving it a look! BTW, in the future, I'll follow your approach for detecting interactive calls. I saw that the Emacs Lisp reference recommends it, but I was worried about adding a new optional parameter to the function. Roi From unknown Fri Sep 05 08:20:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Roi Martin Subject: bug#78855: closed (Re: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout') Message-ID: References: <875xgbbrac.fsf@posteo.net> <87y0tlb9d7.fsf@gmail.com> X-Gnu-PR-Message: they-closed 78855 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 78855@debbugs.gnu.org Date: Tue, 01 Jul 2025 20:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1751401022-19373-1" This is a multi-part message in MIME format... ------------=_1751401022-19373-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 78855@debbugs.gnu.org. --=20 78855: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78855 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1751401022-19373-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 78855-done) by debbugs.gnu.org; 1 Jul 2025 20:16:48 +0000 Received: from localhost ([127.0.0.1]:58843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uWhPK-000501-Ev for submit@debbugs.gnu.org; Tue, 01 Jul 2025 16:16:47 -0400 Received: from mout02.posteo.de ([185.67.36.66]:55391) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uWhPH-0004yo-Qs for 78855-done@debbugs.gnu.org; Tue, 01 Jul 2025 16:16:44 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 57522240101 for <78855-done@debbugs.gnu.org>; Tue, 1 Jul 2025 22:16:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.net; s=1984.ea087b; t=1751400997; bh=tp4YWNqJrV/XrJMvQQMJu/xzx4wFYxQ+YBIev8JPmCQ=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=h8tNwsEcffAcHpUs1DSD41vjzRL5erz42wiNM1fl53XdX5qDKYEvGDI7KKvljJAf5 8pmcLZAkrBMCy/fjHhZtd05MWGguCqTwZ/4gWCYpBy7+gxvEHX79eR/paOmIuQqwrX fX7ANjHAIx9/qvxHEFtNW4dy3oQKtbcXvFbZNeg9Y1UCLpapS8tZjd2B19vvAn8FPI 7DutwBd+wpgdiW0egxMBzW7q+jCsDy2emSj+L3bc2hxLpQr5TpKTfy2SZaQSbcKjcn dzaEV0LRP+siwzCPF9xrTqxuuCSpEBICWLR6P13Y7GJbINdbGTcwEbmr7/zdErcCbq vFH8dun6hBsMxjGoMF5O02rPAGuBt01kmv8EJNDpaBk6Rp5zYgN/CFeuby5UuJgrXH CylLjHpprOIX+U2TqPYFGZfhkbd5tgCRdvJXXp/A7SbMpgSSUKfOX+5EGmgfBVLgNV DgSBIxUQ75PpOzdyLtEyo9toV8uk2qeUf8XDjW7vrYZt2vCQ//u Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4bWvSN2KJTz6tsg; Tue, 1 Jul 2025 22:16:36 +0200 (CEST) From: Philip Kaludercic To: Roi Martin Subject: Re: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' In-Reply-To: <87y0t8csmy.fsf@gmail.com> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> <86wm8w54e7.fsf@gnu.org> <87h5zxb833.fsf@posteo.net> <8634bh44m2.fsf@gnu.org> <87cyakc3z1.fsf@posteo.net> <87y0t8csmy.fsf@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Date: Tue, 01 Jul 2025 20:16:27 +0000 Message-ID: <875xgbbrac.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78855-done Cc: Eli Zaretskii , 78855-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Roi Martin writes: > Philip Kaludercic writes: > >> Will change that. Just want to know what Roi thinks of the change, and >> if I should commit it under my or their name? > > LGTM. Please, commit it under your name. Thanks for giving it a look! OK, but I have listed you under Co-developed-by FWIW. I'm closing the bug report now. > BTW, in the future, I'll follow your approach for detecting interactive > calls. I saw that the Emacs Lisp reference recommends it, but I was > worried about adding a new optional parameter to the function. 1+ > Roi ------------=_1751401022-19373-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Jun 2025 11:54:45 +0000 Received: from localhost ([127.0.0.1]:36254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uSwo1-0001Qc-0l for submit@debbugs.gnu.org; Sat, 21 Jun 2025 07:54:45 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uSwnx-0001QA-Gm for submit@debbugs.gnu.org; Sat, 21 Jun 2025 07:54:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSwng-0000P5-Fm for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2025 07:54:29 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSwnQ-0000WZ-UA for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2025 07:54:23 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-441ab63a415so27894045e9.3 for ; Sat, 21 Jun 2025 04:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750506713; x=1751111513; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=fVaqcH7BGokjd+Uo4eDaXOgCOyRzGMVukSV65NAuZ/M=; b=cEZNWMrkI5gXW5lgPw2fInN5M0/S1aOXY1V9e3hQcTkgJNFMbCavuQxREgTNjJKqaL tgxq/LXc3R6VW6jj9lr34MUmb6gslxyxNS8GwUc1MYi6AWEhK+HKVcByBRUPEXDma6HW MHouuwQimYSzpiAGHebOz+0zmdxwAGc5bOtmKktR4UzDyE5ZTKduY0ptLnxxSTiZZhuQ zdigObCUOF5SOvG+EhmENoemxQkX8qrRDJ9kO/5iNQhk4pEJORqr5eL0fuwkVw7AOeyD Jfv5dFmjRaRcWhdDvvxeXqBB3KEuLu89vCPO0DQop+KHCpF66M594Qjbjxw6j9+CW+oJ iC8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750506713; x=1751111513; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fVaqcH7BGokjd+Uo4eDaXOgCOyRzGMVukSV65NAuZ/M=; b=CrYYptgYp3P8Pe00xnKnbEwU4gsaCyE/sd+q0tmISveamBG0/L96sV1kdDgo1OwhB7 bf1n5bvImPMDygsIZKQR66L6F0uUsx12ZvAZXw3ASOJz0CvZtjiObL3lR7THXwdMGmYK lPXszblpT6VkODlDNjEVFtH94zEX3k4vUQOXkbdGbslcn9l/cakjcTUb1FvSlklJBzWW 1U92wz6mE/+DbpX1honjgzlQDGLXubFbAcfpR4lIaVrCc8s3YcmUb9A41bJ54DRxic4P 9Peok5HC7Qp3G4lC6mDeuvRy/0MS4bwfKhadGeK9S47AbR7xLid0g0UGeP8LPq5xc818 q9MQ== X-Gm-Message-State: AOJu0YzeIaLv9LW5emUS9pM0beSZ8tOMKQp/1lSBQtHNaizBZIqHggTI kJZ04dCwkH0GEPDqLfCiHgD4LC/lVA2Pay58sMKiXbeNi7Da+HChO1ka7qjLUQ== X-Gm-Gg: ASbGnctVqUKT9QQWELoQO8SqdU45vKGLZ9vtFtWcz9HtWBWnzXuhodwG+6DtEN8JjQy nmtfUdGTqLdkh9pT/TB6hCV0QA1Xl+XISfu2WC/PWGv8XVdE4H/J9m0xIXgCRsfgbWj7awjsa8f IrEqTbwOctiAV/Ehjyj+7Kp2H2jddeR6bYDFP7U+vCuWQsAX8JVKwZQRBprxs1rA+6nYXueE3MU I1cVwi4ADDY/Vr+ljteDe7XcuIHLpp9zUWICuikSqHXyGUyKUS6SMMuI3c2zuiYejQ++OgYK0XV td3t4x4pOwhInSPBhZCd6A8kMsk3G76bhEio2n66FlnQCi/KUCwohnjpSjmG X-Google-Smtp-Source: AGHT+IH11MApP8+Ud31us60aJjFOhEGCZSpaDqKSwtetr12fLCjnTA4IQ1f0BuJDQ4Jx2oI3Shk0Hg== X-Received: by 2002:a05:600c:314f:b0:43d:fa59:af97 with SMTP id 5b1f17b1804b1-453659c0d74mr49257715e9.32.1750506713386; Sat, 21 Jun 2025 04:51:53 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646fd74asm51678255e9.22.2025.06.21.04.51.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Jun 2025 04:51:52 -0700 (PDT) From: Roi Martin To: bug-gnu-emacs@gnu.org Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' X-Debbugs-Cc: Philip Kaludercic Date: Sat, 21 Jun 2025 13:51:48 +0200 Message-ID: <87y0tlb9d7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=jroi.martin@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch When `package-vc-install-from-checkout' is called interactively, it asks users to input a directory. If users have enabled `fido-mode', when selecting a directory and pressing RET, they will actually pass "/path/to/pkg/./" to the function. Because NAME defaults to the base name of DIR, it is assigned the value ".". That is problematic in several ways. First, the package would be named ".", which is unexpected. Second, the following code in `package-vc-install-from-checkout': (let* ((name (or name (file-name-base (directory-file-name dir)))) (pkg-dir (expand-file-name name package-user-dir)) ; ... (when (file-exists-p pkg-dir) (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) (package--delete-directory pkg-dir) (error "There already exists a checkout for %s" name))) (make-directory pkg-dir t) ; ... would assign `pkg-dir' the value of `package-user-dir', which is wrong. I.e. it would check for the existence of the wrong directory, it will try to create the wrong directory, etc. This patch expands the directory name passed by the user. So now the behavior of the command is: NAME defaults to the base name of DIR after being expanded. I don't think there is any case where the old behavior is expected by users. So, this change should not break any current use of the function. Is this a fair assumption? Is there any case where the old behavior can be useful? Roi --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Expand-DIR-arg-on-package-vc-install-from-checkout.patch >From 73d15ca95c2842949050f3c2f64b1991b36c54b0 Mon Sep 17 00:00:00 2001 From: Roi Martin Date: Sat, 21 Jun 2025 10:28:45 +0200 Subject: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Expand the directory name passed to the `package-vc-install-from-checkout' function so that paths like "/path/to/pkg/./" are converted to "/path/to/pkg/". This ensures that the package name defaults to "pkg" instead of ".". * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): Expand the provided directory name. --- lisp/emacs-lisp/package-vc.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index babc0b715245..69852e27107a 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -915,22 +915,23 @@ package-vc-checkout ;;;###autoload (defun package-vc-install-from-checkout (dir &optional name) "Install the package NAME from its source directory DIR. -NAME defaults to the base name of DIR. +NAME defaults to the base name of DIR after being expanded. Interactively, prompt the user for DIR, which should be a directory under version control, typically one created by `package-vc-checkout'. If invoked interactively with a prefix argument, prompt the user for the NAME of the package to set up." (interactive (let* ((dir (read-directory-name "Directory: ")) - (base (file-name-base (directory-file-name dir)))) + (base (file-name-base (directory-file-name (expand-file-name dir))))) (list dir (and current-prefix-arg (read-string (format-prompt "Package name" base) nil nil base))))) (package-vc--archives-initialize) - (let* ((name (or name (file-name-base (directory-file-name dir)))) + (let* ((dir (expand-file-name dir)) + (name (or name (file-name-base (directory-file-name dir)))) (pkg-dir (expand-file-name name package-user-dir)) (package-vc-selected-packages - (cons (list name :lisp-dir (expand-file-name dir)) + (cons (list name :lisp-dir dir) package-vc-selected-packages))) (when (file-exists-p pkg-dir) (if (yes-or-no-p (format "Overwrite previous checkout for package `%s'?" name)) -- 2.49.0 --=-=-=-- ------------=_1751401022-19373-1-- From unknown Fri Sep 05 08:20:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78855: [PATCH] Expand DIR arg on `package-vc-install-from-checkout' Resent-From: Roi Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Jul 2025 20:24:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: Eli Zaretskii , 78855-done@debbugs.gnu.org Received: via spool by 78855-done@debbugs.gnu.org id=D78855.175140143823718 (code D ref 78855); Tue, 01 Jul 2025 20:24:03 +0000 Received: (at 78855-done) by debbugs.gnu.org; 1 Jul 2025 20:23:58 +0000 Received: from localhost ([127.0.0.1]:58867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uWhWH-0006AO-Us for submit@debbugs.gnu.org; Tue, 01 Jul 2025 16:23:58 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:46232) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uWhWE-00068m-KD for 78855-done@debbugs.gnu.org; Tue, 01 Jul 2025 16:23:55 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-450cfb790f7so51267335e9.0 for <78855-done@debbugs.gnu.org>; Tue, 01 Jul 2025 13:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751401428; x=1752006228; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=meMtV3SdRxLkOl6ULvwcUMy8R+mSW/XHM4Aj3JxvkRo=; b=M2el00Yy/cWN7+j1VvnBYiyi1f1T5Icp90r5boL4AURTopi8Hu392HU2nQdy4fWBSm /HuOce7zZy/Dp4BD7NXwzDmiyCC3BdYZhVOvKL3Mpk7RGK4f5In6tpc88xtgNjwZPMMb ABi+sXdPVP127yWQVK+JPIcVmKjABRx7XZP+dqbpoafHXZzv2ysz7L6gwoDpKvCc4avC 28XAxW6Qj/FmwjqDVzs3WDbc1s9de3JFXI9MpRhqQhxPhvilTr73mQc5WsCcWe4DNG2a +yPv+xSI6OiIB8rNdkmYh9BjT8EDt4AsKPdV3Pikl19/rlo43WsBtNuwP/+TC+jGZHxK SW7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751401428; x=1752006228; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=meMtV3SdRxLkOl6ULvwcUMy8R+mSW/XHM4Aj3JxvkRo=; b=g85YIJT00mO0iN4Ylk1JHiDf8lkmZ0t8DWINEJlo1pyqHBIVgXo5mWeu2V2HdFoqJ5 2DdGKFC3Pr5t3AXcMaW/GLTgf0wR6yKeXeaWRMRw46yH5o8r3mFyY3JOSsRzlqWpXqDS W8S6nbcgPGzg6asj1KsnaIF5t+PKiOz/lB6B0gJasFDQUfYRPUufm9udR+0D9bIVNIo6 rPmV5apmMJOubIQ1PfFmpKGPYdZkkmYLtI/b+duU3HF8DauwEroPiVv3aOJOy6HqSlNq gUNGPGCG4zLTg5vBXSB4irYoojMqO7GzICt6c1TOcmT5ehZGv1b+hk390EPiLIl4NDKo f0Eg== X-Forwarded-Encrypted: i=1; AJvYcCU7P4//qN5lpygBf0ApsuXoXBTlbrXh+rRKZ385swHBJzcJ78WqVEO+NWy4AEoUyMkhlrKRfUQFjaV2@debbugs.gnu.org X-Gm-Message-State: AOJu0YyHZSn1cHJdzXFctObWt53wDnAh6gclX+ZYnnw51cqHaWYgCpvO ANfn1xfMuc9d9tsuGgBjsfe71/nUJcXEdyoWMp1uqkNoTTNKhcHEdDvN X-Gm-Gg: ASbGncuk2gmEjGscMJvujG/u/f7HMRB1MoHIKVqa3TIMj8vYLYvPUsZkjAAxAfiGMlh R45iXPOaBGgutoOU8iLqIvNCyVf/LQHFrJ6TEg9AMQJf6MzRDFC7PMh33g8olieLcJIHg9hsAz7 kirMov/ISM1Axya5Iflp8vsgEkeUo1nTJFlShEWf5/7RNJ8LB9LNyoYxYnY3ImwNeI5Hd9Reqp3 TufYbRIIodAcUPuDW2OfBkqvZv6c78z43NDeipXlcIhqnwtkZGpdaDI0UBUoeAwz1aH/ro7JYW3 vQkdgLpF9+acSax7pEN6j4EIYkQ8suy+4sz+8ba4OJNjCxFFyq83VkmGmet9 X-Google-Smtp-Source: AGHT+IGdSMQkek2g5DNF1MIeIaAHk/TrqK1QpB3TJOcWySgmxrrwp5T/A1G/VlzNHyxuSuZ+yFU8Vw== X-Received: by 2002:a05:600c:a085:b0:450:cfa7:5ea1 with SMTP id 5b1f17b1804b1-454a370c52cmr5281685e9.16.1751401427822; Tue, 01 Jul 2025 13:23:47 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7e7814sm13923067f8f.8.2025.07.01.13.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 13:23:47 -0700 (PDT) From: Roi Martin In-Reply-To: <875xgbbrac.fsf@posteo.net> References: <87y0tlb9d7.fsf@gmail.com> <86tt49i7bt.fsf@gnu.org> <87zfe154qm.fsf@gmail.com> <86jz54j4hs.fsf@gnu.org> <87tt4855qf.fsf@gmail.com> <878qleck2a.fsf@posteo.net> <86ikkhbtl9.fsf@gnu.org> <87o6u8asjn.fsf@posteo.net> <86wm8w54e7.fsf@gnu.org> <87h5zxb833.fsf@posteo.net> <8634bh44m2.fsf@gnu.org> <87cyakc3z1.fsf@posteo.net> <87y0t8csmy.fsf@gmail.com> <875xgbbrac.fsf@posteo.net> Date: Tue, 01 Jul 2025 22:23:46 +0200 Message-ID: <87frffwtgt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > OK, but I have listed you under Co-developed-by FWIW. I'm closing the > bug report now. Thanks! :)