From unknown Fri Jun 20 07:11:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78820 <78820@debbugs.gnu.org> To: bug#78820 <78820@debbugs.gnu.org> Subject: Status: 31.0.50; savehist timer does not run repeatedly Reply-To: bug#78820 <78820@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:49 +0000 retitle 78820 31.0.50; savehist timer does not run repeatedly reassign 78820 emacs submitter 78820 Daniel Mendler severity 78820 normal tag 78820 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 20:23:34 2025 Received: (at submit) by debbugs.gnu.org; 18 Jun 2025 00:23:35 +0000 Received: from localhost ([127.0.0.1]:38674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRgaO-0002aS-Mv for submit@debbugs.gnu.org; Tue, 17 Jun 2025 20:23:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59156) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRgaM-0002ZW-NT for submit@debbugs.gnu.org; Tue, 17 Jun 2025 20:23:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRgaG-0006w9-K5 for bug-gnu-emacs@gnu.org; Tue, 17 Jun 2025 20:23:20 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRgaE-0002KL-Ea for bug-gnu-emacs@gnu.org; Tue, 17 Jun 2025 20:23:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QOc7PMyHBcj37qRbnh05XHp4k8eAN+NTw81jnMJywac=; b=UbA6TlYJhGFUGvsY/wHeeBSZFr dCE3/Igv6AotJsH2dAvsL280EDVP+NWNuXHvqE2wk+f0R1P2QpNnqeW+awcVlfMnD8cZN1GEoKla1 QKeVisCKmHZNFTjJm5pDt4kqokDqE3G0ZnG5rJCLmZ4nga/6EQqNO+JktU+8n55+YCug=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org Subject: 31.0.50; savehist timer does not run repeatedly X-Debbugs-Cc: "Stefan Monnier" Date: Wed, 18 Jun 2025 02:23:14 +0200 Message-ID: <87cyb1oq31.fsf@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) It seems that the savehist timer does not run repeatedly. run-with-timer is called with repeat argument t. (run-with-timer savehist-autosave-interval t #'savehist-autosave) If I understand correctly, the correct call should look like this: (run-with-timer t savehist-autosave-interval #'savehist-autosave) (run-with-timer savehist-autosave-interval savehist-autosave-interval #'savehist-autosave) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 05:56:30 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 09:56:30 +0000 Received: from localhost ([127.0.0.1]:46442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRpWw-0007Br-4c for submit@debbugs.gnu.org; Wed, 18 Jun 2025 05:56:30 -0400 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]:49412) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uRpWs-0007BM-7a for 78820@debbugs.gnu.org; Wed, 18 Jun 2025 05:56:27 -0400 Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-4c9cea30173so1766163137.3 for <78820@debbugs.gnu.org>; Wed, 18 Jun 2025 02:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750240580; x=1750845380; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MCiERtrYUVxFTYB87GtNXFCwTW76grAXvYpoOIy8/TQ=; b=JMLj/uXQWbVLYriY+r27Ao3uEpTo93AkdOIw3i4/Xjo/7x+ycfRVCttkTHYjycExR2 ktzyMjj2fmatCLiRagOIzqfufnOGHnrLD+ynkG2iqdMKCFxvjyp8tWcffcYhKPq8ZHIp cSaQSeV4xUW8K7oR9preqWs4sOgUA05IuQLLmFc9nRKVUH38TFK5my/TXgNuAwNR17JO 8ZEK/OE8VxJemdYv4qqqjsvfppLWFD9a1ddJtNwsHSa6BpZ+C70471fGeTuxU8TUXG7R bSRWHDy9ubOzxX84Hz/NykxpqnEN0RumhZLEKqiwV/3nWLE6kB6j2uLPHAHZL8C7KsS8 QbJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750240580; x=1750845380; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MCiERtrYUVxFTYB87GtNXFCwTW76grAXvYpoOIy8/TQ=; b=bDhDgiKBNrT/W5HBPIH/xeCmZgvgor2gzY+++CcKZ9t5OhiDOGWAaSEY0JRtceIIhO Tflnthrqse3ZHGTQHpEWE/swQNsN6SmzO5MkRp62Zd1e7lHt/dnmJBUUNaL1QY7Nip4W 9rmHflttCutT4+IZgUxS3zqMmHyEWBHJiYpY5vv+6lvGBH+2dmebXDftaRIRgMStkuO3 j1fzzUdbI/xDzgbzYm1HkOlE97C/k6gx387x18+SBRprHifIEDXVTLrZyJ/zlPrihsTG teCdaT3X1B41fSymhTvzdOrJG6caA/63MYUitampjuzQ+UHT3U5KKiRquN5JX+ONfw8g ZQAg== X-Gm-Message-State: AOJu0YwdyRnNpBVtUlXOK/WEeLHvl0OvCYLtoM6uaqknYm/lWAVaJpeM hn/DQ2QjeCi4hEg0CuJoNyeLQHM6HK7hKzjUZq4Z3FjlklVnTCODwlNgR2IJuj2Qg7jPDB2I09y +3j3kDa74E+fkJ/6tpA6UXR+ko5oS+zrXjg== X-Gm-Gg: ASbGncvwLOqznOd30ZiIaybaLyVi7MHxgHAl+1hZQ4/gUahndo3hS6I3/HNO49cKQwP 75j/UpMN6lERX+4Qi/Dta8HGYrJe7CCg8KOaGIpaWsNcjeus5rOno+is0atKiN63dG0KXuaVtnP LZqImL53o4ZTUD4+x5s5iIR7a0q2yy1XzwCSOWkAE5ZpQ= X-Google-Smtp-Source: AGHT+IFc/7flit7wkk3g6vKsIOV4ABgtm/3NjqEZLVNXAvku1nCdwwcvS0zDUo7JqV6X/VDY3r2remXgDwU3OVMAyuM= X-Received: by 2002:a05:6102:370c:b0:4df:8259:eab with SMTP id ada2fe7eead31-4e7f63c60ebmr12136686137.19.1750240580218; Wed, 18 Jun 2025 02:56:20 -0700 (PDT) MIME-Version: 1.0 References: <87cyb1oq31.fsf@daniel-mendler.de> In-Reply-To: <87cyb1oq31.fsf@daniel-mendler.de> From: =?UTF-8?Q?St=C3=A9phane_Marks?= Date: Wed, 18 Jun 2025 05:56:08 -0400 X-Gm-Features: Ac12FXzNONMAmN7M0WFu4q__eSRJZN94p0hbk6CfTkbYN9OOEZja_J9I8oT0qbU Message-ID: Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly To: Daniel Mendler Content-Type: multipart/alternative; boundary="0000000000000e35970637d5a46d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78820 Cc: 78820@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000e35970637d5a46d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 17, 2025 at 8:24=E2=80=AFPM Daniel Mendler via Bug reports for = GNU Emacs, the Swiss army knife of text editors wrote: > It seems that the savehist timer does not run repeatedly. run-with-timer > is called with repeat argument t. > > (run-with-timer savehist-autosave-interval t #'savehist-autosave) > > If I understand correctly, the correct call should look like this: > > (run-with-timer t savehist-autosave-interval #'savehist-autosave) > (run-with-timer savehist-autosave-interval savehist-autosave-interval > #'savehist-autosave) > 100% right. I think this silly typo/thinko was me. I could submit a patch but I don't have commit access. It would be faster for this one-liner if someone else patched. --0000000000000e35970637d5a46d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Tue, Jun 17, 2025 at 8:24=E2=80=AFPM Daniel Mendler via Bug reports for = GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
It seems that the savehist timer does not run repeate= dly. run-with-timer
is called with repeat argument t.

(run-with-timer savehist-autosave-interval t #'savehist-autosave)

If I understand correctly, the correct call should look like this:

(run-with-timer t savehist-autosave-interval #'savehist-autosave)
(run-with-timer savehist-autosave-interval savehist-autosave-interval #'= ;savehist-autosave)

100% right.=C2=A0 I think this silly t= ypo/thinko was me.=C2=A0 I could submit a patch but I don't have commit= access.=C2=A0 It would be faster for this one-liner if someone else patche= d.
--0000000000000e35970637d5a46d-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 05:57:37 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 09:57:37 +0000 Received: from localhost ([127.0.0.1]:46460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRpY1-0007IB-0f for submit@debbugs.gnu.org; Wed, 18 Jun 2025 05:57:37 -0400 Received: from mail-vk1-xa35.google.com ([2607:f8b0:4864:20::a35]:48250) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uRpXy-0007Hm-Cl for 78820@debbugs.gnu.org; Wed, 18 Jun 2025 05:57:35 -0400 Received: by mail-vk1-xa35.google.com with SMTP id 71dfb90a1353d-53164bd0df3so856217e0c.0 for <78820@debbugs.gnu.org>; Wed, 18 Jun 2025 02:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750240648; x=1750845448; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nEZNVwK/Oza5o+GhBQFcxFcBLoy8wm2wQWyY2Sl0pvw=; b=NrObfw+v5baV6UhGFPt9gm4edzE7XRg2CWzkLJGHXb0H1QbqyurCpjveDPwKkkWz6F RevtoFlDZLHe1nxMdz3QjbABBq2SAxitXzk7QWYNE6zEdbKvUYU3q9U/ptYnG5/NWT7X TKJYCxcU3AG37pqQD5BKXEhJ+wPYho0sSWNF/B/0rU+z7CWoFQ7La52Fr6QLFiJESRFr xgMB3Au5lipK3I1Snib45xYqK7n5BqsNngWlMVIQYP26aQh59ZoU4O450OLuOkUpGnJ0 HFjIu1zMDQE9k5tS4YwgOySN+pg8JtkhOD4fkvXFa/R9M2jTm2Gd4mq715vVXEhUfgTe 7ydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750240648; x=1750845448; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nEZNVwK/Oza5o+GhBQFcxFcBLoy8wm2wQWyY2Sl0pvw=; b=SRThxHQJwFPedlImR4N7170Srng/20uyXMC0Hp9tSlN4nHBPIARVhSBR+5NmJcj6CI xNddUVFLX4SLZ/V/NmEBU3bLMYDPsZdggzQivEdnkpnEDnqaeCXoceRY8Bueg0OOBe9u 1qmjM7A2lLAohOpQqYsjBk9y7b9XzZIXCt6X1b83/H8Hdxg1VAh3n9rhprKhWUMXNk2q TM55bOaYemjM2TPk8chXAuIkeSmoJn82xdODOwMJJVkDo7gjyUVqzSiRdqndSwoWigY+ 8ww5MuJoILQAZieQcQV5GKx6qITenXQ+3uAMI6zznxLQSogJon7HJ/Pi43bP3+D60AbS qmFQ== X-Gm-Message-State: AOJu0Yx2BPNpmLRRxMDfbeKquZr7XDZ8FVX4UJq29vsL7mkgFvtJM8Ox d4IkdHGRHuD+OQVD6FHg2L5kePx0HFjWIvH6y2ibVIv4Iz95QBPH8Mk7RYrPMOlTZ2CpgQoJe45 PduacrMwSL6NNq6KkpcV+YZgGiuWyR7I= X-Gm-Gg: ASbGncv9R2mG3DONDUQ/bu6sSNWITqxZ1sy8t6pRZ0eAXhgtKYeYOaJY/eGpNIWUehS Yk6ju5LGU51XSbkORUx7bRzNsxfaN4j3ZRIooUUf3vfYhr40wdVGZTT+sazhgp4/sImBQBqKBi9 JHM7xB1hwkbxHKSROh1TTdhoJKZoR2jElYdobfDP22OAo= X-Google-Smtp-Source: AGHT+IFOF5ZrWXsGw90eSyBkVtymH/gZvjJbSsKawc5oywTyJyMu+yl/0YuOcAP8OdcxdUg7M8AyBw5A01uC/1og3I4= X-Received: by 2002:a05:6122:251d:b0:530:6538:cb12 with SMTP id 71dfb90a1353d-53149c59675mr11771851e0c.11.1750240648480; Wed, 18 Jun 2025 02:57:28 -0700 (PDT) MIME-Version: 1.0 References: <87cyb1oq31.fsf@daniel-mendler.de> In-Reply-To: From: =?UTF-8?Q?St=C3=A9phane_Marks?= Date: Wed, 18 Jun 2025 05:57:17 -0400 X-Gm-Features: Ac12FXzM4EOhYdvwKTywdO0b9VqJHsClZ2IZSktOQivWu-fGArzeG7IWwGlfP-o Message-ID: Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly To: Daniel Mendler Content-Type: multipart/alternative; boundary="0000000000001fcb700637d5a876" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78820 Cc: 78820@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001fcb700637d5a876 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 18, 2025 at 5:56=E2=80=AFAM St=C3=A9phane Marks wrote: > On Tue, Jun 17, 2025 at 8:24=E2=80=AFPM Daniel Mendler via Bug reports fo= r GNU > Emacs, the Swiss army knife of text editors wrote= : > >> It seems that the savehist timer does not run repeatedly. run-with-timer >> is called with repeat argument t. >> >> (run-with-timer savehist-autosave-interval t #'savehist-autosave) >> >> If I understand correctly, the correct call should look like this: >> >> (run-with-timer t savehist-autosave-interval #'savehist-autosave) >> (run-with-timer savehist-autosave-interval savehist-autosave-interval >> #'savehist-autosave) >> > > 100% right. I think this silly typo/thinko was me. I could submit a > patch but I don't have commit access. It would be faster for this > one-liner if someone else patched. > Originally bug 75834. --0000000000001fcb700637d5a876 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Wed, Jun 18, 2025 at 5:56=E2=80=AFAM St=C3=A9phane Marks <shipmints@gmail.com> wrote:
=
On Tue, Jun 17, 2025 at 8:24=E2=80=AFPM Daniel Mendler via Bug repor= ts for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wr= ote:
It seems that the savehist timer does not run repe= atedly. run-with-timer
is called with repeat argument t.

(run-with-timer savehist-autosave-interval t #'savehist-autosave)

If I understand correctly, the correct call should look like this:

(run-with-timer t savehist-autosave-interval #'savehist-autosave)
(run-with-timer savehist-autosave-interval savehist-autosave-interval #'= ;savehist-autosave)

100% right.=C2=A0 I think this silly typo/thinko was me.=C2=A0= I could submit a patch but I don't have commit access.=C2=A0 It would = be faster for this one-liner if someone else patched.

Originally bug 75834.
--0000000000001fcb700637d5a876-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 07:54:07 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 11:54:07 +0000 Received: from localhost ([127.0.0.1]:48077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRrMl-0006Hc-2N for submit@debbugs.gnu.org; Wed, 18 Jun 2025 07:54:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52862) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRrMj-0006GN-4i for 78820@debbugs.gnu.org; Wed, 18 Jun 2025 07:54:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRrMd-0002dJ-Cz; Wed, 18 Jun 2025 07:53:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=He5WXLur+/vH8fHzcA1kWO/gz9U6k8JlnKf+OKmOsOM=; b=Ika79TdFM3ap 6LqfKcWLf3cm+PXqdFBqxBplV5jq6ENap/PdC3qpMtWX+QtjhAVl/GSuCZB/uLKZcQdjuS8BoksJL 9MWhzo/0jXFYWvTjrqhZZ8JbhirMGjnLa1M4k2nsaVc62f5YarXFU8uAgYjyepVCIG3yRD3Sa2Wq3 Y11eDVcKOVqLps8+4Kt6pWK/AoAs1sHYFIporpK5nx2s2AupEIAX1zR/V1Kdpv/axOJRciDihN92T b6II/8vx+YCFQxTeiSHVA78HYkBYithK3p9BlcVVdkGpDpFIt0eykty+M12gt+6vyPD+ZbmhCMPMq LSXH68nL/CFdpW5OVLrGSw==; Date: Wed, 18 Jun 2025 14:53:56 +0300 Message-Id: <86jz59mfjf.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87cyb1oq31.fsf@daniel-mendler.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly References: <87cyb1oq31.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78820 Cc: 78820@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: "Stefan Monnier" > Date: Wed, 18 Jun 2025 02:23:14 +0200 > From: Daniel Mendler via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > It seems that the savehist timer does not run repeatedly. run-with-timer > is called with repeat argument t. > > (run-with-timer savehist-autosave-interval t #'savehist-autosave) > > If I understand correctly, the correct call should look like this: > > (run-with-timer t savehist-autosave-interval #'savehist-autosave) > (run-with-timer savehist-autosave-interval savehist-autosave-interval #'savehist-autosave) Why do you think so? The calling sequence of run-with-timer is this: (run-with-timer SECS REPEAT FUNCTION &rest ARGS) So what savehist.el does appears to be correct. Or what am I missing? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 08:13:02 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 12:13:02 +0000 Received: from localhost ([127.0.0.1]:48388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRrf3-0008Ny-Ey for submit@debbugs.gnu.org; Wed, 18 Jun 2025 08:13:01 -0400 Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]:61613) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uRrf0-0008NG-E2 for 78820@debbugs.gnu.org; Wed, 18 Jun 2025 08:13:00 -0400 Received: by mail-vs1-xe36.google.com with SMTP id ada2fe7eead31-4e7eefcbf08so1203542137.2 for <78820@debbugs.gnu.org>; Wed, 18 Jun 2025 05:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750248772; x=1750853572; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zMMxcPOrIgC+cUfrCQyjLOqnDNv7ImAEIt+iNV3dlfo=; b=Cf8XQK33pCiJ1EbGpcXxxpg2Mmwe4qdM1M5guIoLbEXpd1YDeWOwkSCKALByRE/PDr wpu0J5D5FOVV6VeVrbPlOD0JGjmPS5SZsyVywcAEJKJvZZJN5Aa6OJBAD3sTWJT/1Rai Paf/56q3giQNEJ0HZDVCLwTPy4YrKV6ZK0DZMFoSzIimhlLbemKY/8HyU+8YzTty4yWt 4zPZRJADr/MtNdnegqJDGI9zaucImJU6k8Rm988a5HcXUFor0kiqjVgBdJeoxYvwV/lv cCV2fyIo/pUAMtdxthSQtiJeg6vy1IpxhavKS3D/344toGo6ZLxgyaLZnB8yuosqaO34 EAEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750248772; x=1750853572; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zMMxcPOrIgC+cUfrCQyjLOqnDNv7ImAEIt+iNV3dlfo=; b=YF1cv2Z0CPCf62RiUozYfj41/pfsddGmlHHmCkOLsafbN+AkkB/ko7/NEU5UYCl248 5NQ5FfdicGHszNGPXJqVzQjQ4gHB2sjlHH1ZVDoaMSo5iHmUO/kuDm3tHXMvBLWiFvek XZJ5uUrQjZhI/iqkmZsMf7yNf4X5dsy4znE8+qG8nZl6/KkmA+zMgaerWTpK8qscoGD0 b9eEJhv08Tu5o6ALp0+v+wcifWkZx4ewnea84fu3x6hdGzrgTevzRsXjb8ryzgDSvtqP f4VcUyCLB/GYdDYo4KER7cZ/PVsD321x4QgdsQCoTmDxRn4lg00F/vcCm0mPnq02lAmk yNrA== X-Forwarded-Encrypted: i=1; AJvYcCXhKu0Lop3kssk1MkpetqLCIESKun1yY3moj2apmoI2KzdZ7YU9+Kc3UsB4eX/OmZalhiWW4w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwZ6PwNjg7F8x5zLnPikjx5vaU3U1eVIvczqjt1Wn5NXINBKYVg IcIvcj1CRIH6sxTDs2FvuVvpHMLs34//U27hKduXPz1/6lZMI2Ay7UkDh8Wi1Xc32ZZv97EeuN1 arSD+IPni1StDF/XPFMdzE/V6GbJhiMk= X-Gm-Gg: ASbGncvH0dLLkoX3pnNuHyIt1whL6cntYW+IejfD7tVEl50+mzrDO+FWNhI6P+31/3j zkj5pXILGlUN01bcgBo+7f4B7cczdiwlp6L1wcWmCPR7xnwweE3w4XhZeDYQPZetNd/g781OM7M A6MmRA1sn3igVBKl4uqB0JIG+LOrq1+/bt7ozWuFTing0= X-Google-Smtp-Source: AGHT+IFqeKRw4tAr/eOTNr73mPIOGCXti9anwdVWujk78AHkNY4otPsVM7J4xopFJ7nTCjjiyW7gV/DhwHyp+qx9RT8= X-Received: by 2002:a05:6102:548c:b0:4e6:e17f:1523 with SMTP id ada2fe7eead31-4e7f6110c4bmr11289434137.4.1750248772169; Wed, 18 Jun 2025 05:12:52 -0700 (PDT) MIME-Version: 1.0 References: <87cyb1oq31.fsf@daniel-mendler.de> <86jz59mfjf.fsf@gnu.org> In-Reply-To: <86jz59mfjf.fsf@gnu.org> From: =?UTF-8?Q?St=C3=A9phane_Marks?= Date: Wed, 18 Jun 2025 08:12:39 -0400 X-Gm-Features: Ac12FXwNrl6rfHd9hM0mLJCT-K098cgcH7ofq1L-aOJOvnVNBsEMLEXRR8ieL-o Message-ID: Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000005579d10637d78c92" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78820 Cc: Daniel Mendler , 78820@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005579d10637d78c92 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 18, 2025 at 7:55=E2=80=AFAM Eli Zaretskii wrote: > > Cc: "Stefan Monnier" > > Date: Wed, 18 Jun 2025 02:23:14 +0200 > > From: Daniel Mendler via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > It seems that the savehist timer does not run repeatedly. run-with-time= r > > is called with repeat argument t. > > > > (run-with-timer savehist-autosave-interval t #'savehist-autosave) > > > > If I understand correctly, the correct call should look like this: > > > > (run-with-timer t savehist-autosave-interval #'savehist-autosave) > > (run-with-timer savehist-autosave-interval savehist-autosave-interval > #'savehist-autosave) > > Why do you think so? The calling sequence of run-with-timer is this: > > (run-with-timer SECS REPEAT FUNCTION &rest ARGS) > > So what savehist.el does appears to be correct. Or what am I missing? > (defun savehist--manage-timer () ;; should be (run-with-timer savehist-autosave-interval savehist-autosave-interval #'savehist-autosave)) ;; not silly t (run-with-timer savehist-autosave-interval t #'savehist-autosave)) --0000000000005579d10637d78c92 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Wed, Jun 18, 2025 at 7:55=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> Cc: "Stefan Monnier" <monnier@iro.umontreal.ca>
> Date: Wed, 18 Jun 2025 02:23:14 +0200
> From:=C2=A0 Daniel Mendler via "Bug reports for GNU Emacs,
>=C2=A0 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> It seems that the savehist timer does not run repeatedly. run-with-tim= er
> is called with repeat argument t.
>
> (run-with-timer savehist-autosave-interval t #'savehist-autosave)<= br> >
> If I understand correctly, the correct call should look like this:
>
> (run-with-timer t savehist-autosave-interval #'savehist-autosave)<= br> > (run-with-timer savehist-autosave-interval savehist-autosave-interval = #'savehist-autosave)

Why do you think so?=C2=A0 The calling sequence of run-with-timer is this:<= br>
=C2=A0 (run-with-timer SECS REPEAT FUNCTION &rest ARGS)

So what savehist.el does appears to be correct.=C2=A0 Or what am I missing?=

(defun savehist--m= anage-timer ()
;;=C2=A0
should be= =C2=A0
=C2=A0 =C2=A0(run-wit= h-timer savehist-autosave-interval
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0savehist-autosave-interval<= /span>=C2=A0#'savehist-autosave))
=
<= span class=3D"gmail_default" style=3D"font-family:monospace">;; not silly t=
=C2=A0 =C2=A0(run-with-timer savehist-autosav= e-interval t #'savehist-autosave))

--0000000000005579d10637d78c92-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 08:20:22 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 12:20:22 +0000 Received: from localhost ([127.0.0.1]:48491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRrm9-0000qq-WF for submit@debbugs.gnu.org; Wed, 18 Jun 2025 08:20:22 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:35921 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRrm7-0000pl-MF for 78820@debbugs.gnu.org; Wed, 18 Jun 2025 08:20:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VVP6i+bgByfNj5BP4QAbmb3Aj/zT3IxsLqYcF8jE4/U=; b=xbZxiWXmwxICTiRttSrkv2MFr8 L4WqVz0Sr0WGP+x2N7cVaNiRWrmfW65JN/OVEwx9wOCMbwpYm/Sx9r1HQP/3MJJqoAgtAtsbQoaJv +vcYw6RJoAzPzUhCNf8EGHjKBupx2gDSYrypRnH1VZTGZtg1ozJJmyKTr8sXsvgf9wUk=; From: Daniel Mendler To: =?utf-8?Q?St=C3=A9phane?= Marks Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly In-Reply-To: References: <87cyb1oq31.fsf@daniel-mendler.de> <86jz59mfjf.fsf@gnu.org> Date: Wed, 18 Jun 2025 14:20:11 +0200 Message-ID: <87ikktdyx0.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78820 Cc: Eli Zaretskii , 78820@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) St=C3=A9phane Marks writes: > On Wed, Jun 18, 2025 at 7:55=E2=80=AFAM Eli Zaretskii wrot= e: > >> > Cc: "Stefan Monnier" >> > Date: Wed, 18 Jun 2025 02:23:14 +0200 >> > From: Daniel Mendler via "Bug reports for GNU Emacs, >> > the Swiss army knife of text editors" >> > >> > It seems that the savehist timer does not run repeatedly. run-with-tim= er >> > is called with repeat argument t. >> > >> > (run-with-timer savehist-autosave-interval t #'savehist-autosave) >> > >> > If I understand correctly, the correct call should look like this: >> > >> > (run-with-timer t savehist-autosave-interval #'savehist-autosave) >> > (run-with-timer savehist-autosave-interval savehist-autosave-interval >> #'savehist-autosave) >> >> Why do you think so? The calling sequence of run-with-timer is this: >> >> (run-with-timer SECS REPEAT FUNCTION &rest ARGS) >> >> So what savehist.el does appears to be correct. Or what am I missing? >> > > (defun savehist--manage-timer () > ;; should be > (run-with-timer savehist-autosave-interval > savehist-autosave-interval #'savehist-autosave)) > ;; not silly t > (run-with-timer savehist-autosave-interval t #'savehist-autosave)) To clarify, with the argument t, the timer does not run repeatedly, but only once. That's the problem. Btw I wonder if it would make sense to allow St=C3=A9phane's calling convention too and just dtrt. It is not obviously silly imo. Daniel From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 08:36:54 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 12:36:54 +0000 Received: from localhost ([127.0.0.1]:48698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRs2A-0002T1-9w for submit@debbugs.gnu.org; Wed, 18 Jun 2025 08:36:54 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:52243) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uRs28-0002SR-1B for 78820@debbugs.gnu.org; Wed, 18 Jun 2025 08:36:52 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3a52874d593so6584621f8f.0 for <78820@debbugs.gnu.org>; Wed, 18 Jun 2025 05:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750250205; x=1750855005; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=QIwc2xs9FLGJt0YBcWx1vvcqBOCEBIrHhWx+ZVydCXs=; b=OhNJOFSXigTZL3DY7nlTrpeg5VI8ShON+X+0u999hG+b9E1rwcSU94qgV6ptp8d4fc oKBRMZQRhDbje/D+G0rlX+FTUunCX+Y/LY5jGOj88UYSTFe95jEI7BUVgOTBLnCtIBlg yxpH1CfDUGyXcZaXnhOLuSHOB2Ma3GRs2Zzj+7WXMtDdADvEimpCxUyMv0IZ2g04pebT m2pHfIso/x0BwHFWD1pr+t0mvmoHLQ7VBb7NaeiGXamziF9LS4EGK1JQOFGExc644vGj A/UwxVhEyAKTkI3WRQVYcbl90zxm2rvevp8g5E+2qGE8HqmeR0PLl359vNMxDJgn3VOR fZaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750250205; x=1750855005; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QIwc2xs9FLGJt0YBcWx1vvcqBOCEBIrHhWx+ZVydCXs=; b=ay2MdZTqdbwDfGjjwfaOQptj7BeF6lYRkkHqqmuNc2Y1q9yyY25U6PI5M+MakOWgSz 4cf5eeC/OckXzUR4oR0NR+MOIqKFNSCMvY/Uw8D3movoG9+PLbkgrQup3dtyvSxe8yUM Ki3A8m01D03uIBhlGK675RbVClm/7eCMXZLfqVp7ecMeMeioaU3oTcmxwy34LZGnPWpR g9vQMwahPAbJQ+hcx4rHLLjFqOMDx9eFQDkXxEwdGvnTiKKzGowUq5AJQ1cuc6WqeJsI hmbgQAiRyWIrGE7AJa9Wic+GGiG1rzCX9mnJnOJ/5uHkXmyL3G9LrXTATWOxXFLDQr6E DjVA== X-Forwarded-Encrypted: i=1; AJvYcCVHrq+2P0OGXS8IV3/yl0Sju08tTDqrMsCxCLuDt0Tc/aaKjF+pauiYxUoHWyo//pqpa6Nniw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwdiJmNDU8hWNBA/t1aXkjUysLoUoiJqlCo9HWGoLzqJPlGd7XP 0GgbGADSMVETqNPgoKSrm7Pk1f1PZb8mMELNhtVHHRDAvJHq1+72ymXB X-Gm-Gg: ASbGncuAbBWZ2jOrDom+VkAsuPqVJ9rbCAUv7p9i9v/KVTL+BPht79wniBBaIoWS+V/ XSaO60NqoZ35z9f6JQF+nImYltkDqSIVuISUMlhAFdfO/yJLcP6o+6yFDiUShxpdWnjiDaY2aSq jE//NSYb/LxaVJwC9JpS3E61xbacvv0n+ZQDuUlB+l8ESKipO5YZeZ9sV3aiw58uLqXbKUKP4bS CGOZDn7ef0/GGlQ4UkdHpRmqVW5kVhx1IoXuAHNb4pqbzlKxCs9wrKdpQ/NfV2DGa0gPFLedMvO ruU39sDsvk5YuGDLHVUzwgD+FOit1NqSN/TAHZ30DFMJcgmx+06eCNTZWZw= X-Google-Smtp-Source: AGHT+IEjJXJ+pLrgOy+c089We9yFU0vXB0BOoNO5/lf7t0L97xeBqJeUcet9YTkeSY16nG3g1J/c5A== X-Received: by 2002:a05:6000:4387:b0:3a5:2465:c0a4 with SMTP id ffacd0b85a97d-3a572374adbmr14000149f8f.20.1750250205163; Wed, 18 Jun 2025 05:36:45 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:332:f25c:cdb8:eac9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5780c5004sm13296376f8f.56.2025.06.18.05.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 05:36:44 -0700 (PDT) From: Robert Pluim To: Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly In-Reply-To: <87ikktdyx0.fsf@daniel-mendler.de> References: <87cyb1oq31.fsf@daniel-mendler.de> <86jz59mfjf.fsf@gnu.org> <87ikktdyx0.fsf@daniel-mendler.de> Date: Wed, 18 Jun 2025 14:36:44 +0200 Message-ID: <87frfxw7j7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78820 Cc: Daniel Mendler , Eli Zaretskii , 78820@debbugs.gnu.org, =?utf-8?Q?St=C3=A9phane?= Marks , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 18 Jun 2025 14:20:11 +0200, Daniel Mendler via "Bug reports f= or GNU Emacs, the Swiss army knife of text editors" = said: >> (defun savehist--manage-timer () >> ;; should be >> (run-with-timer savehist-autosave-interval >> savehist-autosave-interval #'savehist-autosave)) >> ;; not silly t >> (run-with-timer savehist-autosave-interval t #'savehist-autosave)) Daniel> To clarify, with the argument t, the timer does not run repeate= dly, but Daniel> only once. That's the problem. Btw I wonder if it would make se= nse to Daniel> allow St=C3=A9phane's calling convention too and just dtrt. It = is not Daniel> obviously silly imo. No need: (run-with-timer t savehist-autosave-interval #'savehist-autosave) already works, although the docstring and the manual don=CA=BCt make this clear, you need to read the manual for `run-at-time' attentively. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 08:42:23 2025 Received: (at submit) by debbugs.gnu.org; 18 Jun 2025 12:42:23 +0000 Received: from localhost ([127.0.0.1]:48773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRs7S-000336-Pw for submit@debbugs.gnu.org; Wed, 18 Jun 2025 08:42:23 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53118) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRs7Q-00032I-Ec for submit@debbugs.gnu.org; Wed, 18 Jun 2025 08:42:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRs7I-0007uP-9n for bug-gnu-emacs@gnu.org; Wed, 18 Jun 2025 08:42:12 -0400 Received: from mail-vs1-xe2a.google.com ([2607:f8b0:4864:20::e2a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uRs7G-00027t-B3; Wed, 18 Jun 2025 08:42:12 -0400 Received: by mail-vs1-xe2a.google.com with SMTP id ada2fe7eead31-4e98a88fa5aso429447137.0; Wed, 18 Jun 2025 05:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750250528; x=1750855328; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/LFuW7jIY3BCW+/+91aWfl5IMxNXQL0tEJdSad9KFYA=; b=BJo80hWAlgocGTrxXLYcJllH6vnIp3+TMXZW+VJeOUcWesMRhklDvO8vegxRAYejuF x0bJHUYoqKalyP5b4fNILIRZ112AbJpBCdrx390aItSE7NWVWJI1nz5sB0x7ubrfKPiB qXix1kxx1z5fgj7Kue1UfO8wx3fw0f1ofiPYhuucXOPiSWIUJT0d6midkzMWaj3eOZnY rMLmCKf8GY8mZR7OlXGw8BYnULb3P08ajoXPJS8EYVsqbWjiFFw/gYRZZuyUhcOdMzgg 36wP1CtBP8ZYCRltfl7c9FLlIN3Ojrw6CRDvgJf+3flh5Suxhp02G1FtVci+j0hyTwXG lhOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750250528; x=1750855328; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/LFuW7jIY3BCW+/+91aWfl5IMxNXQL0tEJdSad9KFYA=; b=dNKiUGyRFE8eijMOtkKYSx7IRRqSylSM2iFmBUuNVUZGtgCa1zKMfjH/t6aRLBUxYD mGsIdrANTzxp125lYWU0A/JOpxLWjdzqf0cX1mBMotgHlek7LCLOorWQ+y7TTFAxp105 UHpS7Vw8c6QhiGDEN1zCUP2EEB8wMBDXmGEeDYBbLQJfebvJeWU0tczyy+8S3MD/TNmP +M4melR/iVVEfHROVyTgOT84Yp4j3v7IjGGIsibZEfXXKnd0z1+qc+sMG+/bcs733VzP jB/aci1hvnEec6gIop/j+9tnm0LOkXO8XQc680xev/7PWMXO5Nx+RET7rYUC2eVr8Y4V dLPg== X-Forwarded-Encrypted: i=1; AJvYcCUsOT6ccjDc0TXMNzTvswJ5KCsVtz0QzpjufmwmKNB6ba03EFu5iw+d5Lwnq3moCfBE5XO/@gnu.org X-Gm-Message-State: AOJu0Yxx6/Cb278x7PMooDDSeP+bO3zchINlCArffKUpw/S0mEyELSM1 sHLiDM2pTEWbOwtLginAGLIurxITV017uoefZ4d6/2YB2PwBW3zt4kT5yUJhU8KQp7GXw38Gbmn 8PfLJ1Ihnx+QPrEnzg90Q62VxdtkzJic= X-Gm-Gg: ASbGncuEscaXQ+UhyxSjMFVWcveutbXY+Bp5g2bHdCOPFO3+ZE6Z387SwQZSHmJoOYK SK0LXasiBCZAFndVD74MTfzyT+sJoc7AX/S08YRJ+Qx8IfDxIwMh+6iT9LI2ZmhuZQgKCwXNS6p k4964826xvZ+oCk8QTkvulbA/r20beN4lCnkWC6h4G4fo= X-Google-Smtp-Source: AGHT+IEuy/W/7m4Eiy/f3Gr+qo2n/EN6sFX+C+Hlfx5vT0n3KK4DTqTC4OkE/NfKciEfwI2AfqA9ENGDhQum8Bw4tr8= X-Received: by 2002:a05:6102:5092:b0:4cb:5d6c:9946 with SMTP id ada2fe7eead31-4e7f638b30amr11825838137.10.1750250528721; Wed, 18 Jun 2025 05:42:08 -0700 (PDT) MIME-Version: 1.0 References: <87cyb1oq31.fsf@daniel-mendler.de> <86jz59mfjf.fsf@gnu.org> <87ikktdyx0.fsf@daniel-mendler.de> <87frfxw7j7.fsf@gmail.com> In-Reply-To: <87frfxw7j7.fsf@gmail.com> From: =?UTF-8?Q?St=C3=A9phane_Marks?= Date: Wed, 18 Jun 2025 08:41:57 -0400 X-Gm-Features: Ac12FXz8ljQ1Lt3bvZ2JnUXOI7xlNvVkDxpRSHhr2sj0qcyISiHmLyAQC3E-W9g Message-ID: Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly To: Robert Pluim Content-Type: multipart/alternative; boundary="000000000000084fa70637d7f5f3" Received-SPF: pass client-ip=2607:f8b0:4864:20::e2a; envelope-from=shipmints@gmail.com; helo=mail-vs1-xe2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Daniel Mendler , bug-gnu-emacs@gnu.org, 78820@debbugs.gnu.org, Eli Zaretskii , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000084fa70637d7f5f3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 18, 2025 at 8:36=E2=80=AFAM Robert Pluim wro= te: > >>>>> On Wed, 18 Jun 2025 14:20:11 +0200, Daniel Mendler via "Bug reports > for GNU Emacs, the Swiss army knife of text editors" < > bug-gnu-emacs@gnu.org> said: > >> (defun savehist--manage-timer () > >> ;; should be > >> (run-with-timer savehist-autosave-interval > >> savehist-autosave-interval #'savehist-autosave)) > >> ;; not silly t > >> (run-with-timer savehist-autosave-interval t #'savehist-autosave)) > > Daniel> To clarify, with the argument t, the timer does not run > repeatedly, but > Daniel> only once. That's the problem. Btw I wonder if it would make > sense to > Daniel> allow St=C3=A9phane's calling convention too and just dtrt. I= t is > not > Daniel> obviously silly imo. > > No need: > > (run-with-timer t savehist-autosave-interval #'savehist-autosave) > > already works, although the docstring and the manual don=CA=BCt make this > clear, you need to read the manual for `run-at-time' attentively. > Funny perhaps I did that at the time, but I prefer the more precise form. --000000000000084fa70637d7f5f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Wed, Jun 18, 2025 at 8:36=E2=80=AFAM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Wed, 18 Jun 2025 14:20:11 +0200, D= aniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of = text editors" <bug-gnu-emacs@gnu.org> said:
=C2=A0 =C2=A0 >> (defun savehist--manage-timer ()
=C2=A0 =C2=A0 >> ;; should be
=C2=A0 =C2=A0 >> (run-with-timer savehist-autosave-interval
=C2=A0 =C2=A0 >> savehist-autosave-interval #'savehist-autosave))=
=C2=A0 =C2=A0 >> ;; not silly t
=C2=A0 =C2=A0 >> (run-with-timer savehist-autosave-interval t #'s= avehist-autosave))

=C2=A0 =C2=A0 Daniel> To clarify, with the argument t, the timer does no= t run repeatedly, but
=C2=A0 =C2=A0 Daniel> only once. That's the problem. Btw I wonder if= it would make sense to
=C2=A0 =C2=A0 Daniel> allow St=C3=A9phane's calling convention too a= nd just dtrt. It is not
=C2=A0 =C2=A0 Daniel> obviously silly imo.

No need:

=C2=A0 =C2=A0 (run-with-timer t savehist-autosave-interval #'savehist-a= utosave)

already works, although the docstring and the manual don=CA=BCt make this clear, you need to read the manual for `run-at-time' attentively.

Funny perhaps I did that at the time, but I prefer the more pre= cise form.
--000000000000084fa70637d7f5f3-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 09:32:07 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 13:32:07 +0000 Received: from localhost ([127.0.0.1]:49357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRsta-0000L8-Rd for submit@debbugs.gnu.org; Wed, 18 Jun 2025 09:32:07 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:52714) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uRstV-0000Jg-2d for 78820@debbugs.gnu.org; Wed, 18 Jun 2025 09:32:03 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso6641675f8f.1 for <78820@debbugs.gnu.org>; Wed, 18 Jun 2025 06:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750253515; x=1750858315; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=findU5thHmMyVIhiaZh4JVKg1B0IXidKglW7XDhHFFE=; b=J0cCCkNpVNv7tAGcGauf5ptTIeXE0s6bFEJ0LRxfOJ0hURq25uW4veZGBZiQVkzvpA dwY+AIR39b4fHX0R5UQmbk+Ne22NaM/9C04Y7D0mI3VH5w3f03XQ/K0QpPcaPJtrSzr1 qbBuVg0vzRzf6DDcfZmp8uIlwlbCZ12unk4upyv82Yo0GAliQEKUnjteExfd4zt6+zlW +DCQldkLIONDWTGsvHzuZszc7azOJMO/CBe+Df4FPvkX91OfTN4/xBu6JfhY/KwNshlt 2Uz+ExiFWAaFc7Pikaihp2dAfSxYxS6yd2LB77tjByVec0rbBOqJxMBt5cCvZyZb6Fqo v98A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750253515; x=1750858315; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=findU5thHmMyVIhiaZh4JVKg1B0IXidKglW7XDhHFFE=; b=MZOV4ZSwLCF9Zs1RzR+IIBsAaNESqQ4mYQs6x6fv1VXXJutD7UjIIxKqgAx/dRcsQr 3KU+UQFTcEa3kqYSzIea1teQuuM5FkwrTHRFtJ8pq5yK1Uh0tgKtpQAASOMOPuM85D87 TKWvZIhJIEpvtSsI1xB2TCqyMHUnCEKgZnqTjdIfz4w/f2DFQai/MRjne33tdMO7dhmj p6cLBii8qZzBTQUGLNqzQExoJKdmAeXq4KGMC5on6DTwphcW3+hQh5Se3QAJmh4y8TEn Wf0PwetWH06WyqqcKdrECLwdFm0IYdq7Q3F6fou3nphocZOl8xgkg6r9zBZ87QfhwrLE Nwjg== X-Forwarded-Encrypted: i=1; AJvYcCUVybgBZ902mTrGFsLj8n75TijlotXu4qxAmtlk9EsF7w0+hnfw6LnO9qODL0tDA41eRn+amg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyUs7k0W6c/c9WTVpY6oLhOg03Ah2Lgcr/mBEJxTodGaIqzMZHp vinqBphbzV1xpyLfRtBvQC8g0mFIfGre0x5vYuhbQ79OqX9/QBcNhW4N X-Gm-Gg: ASbGncvT8qAU4U9nJgQpZAm9CLgiwJSThCSVUpUWFLkjAycqfoJsuLIJ8nvrTqpu0/A zHDw+CY2/ZTP6sLvl3N49wOBFIS1TxnahjWv8NveovDq6VQBqj9wqlOMGmbC8YggZFteKb1rKmH ifVCdROPoysEcWwJY0IcIThWsz7OmIVSI2ho1DwF1KxNoeIetuxrmMA1HxDOPNL7yIQ7pBG93zy ddI3V9FoWc0tcRAAuE7aF78n9oyr7ONFpYVA+StPek9RBAlYmucpTBOK1iLHfL2OZIPganpmjq0 8yTuzBQkUCaovKUGI7zF0px9wwLC3YL408rRga033306uUng X-Google-Smtp-Source: AGHT+IFobjy0IV8UVVNBOKCvYr0xrUz3uxbHMyQim8Bp630pQKUrMbnyZrGSC4JPbMljKk21zcSY4w== X-Received: by 2002:a05:6000:22c7:b0:3a4:f7dd:234b with SMTP id ffacd0b85a97d-3a571896c71mr13439747f8f.0.1750253514498; Wed, 18 Jun 2025 06:31:54 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:332:f25c:cdb8:eac9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e254396sm212152275e9.28.2025.06.18.06.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 06:31:54 -0700 (PDT) From: Robert Pluim To: =?utf-8?Q?St=C3=A9phane?= Marks Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly In-Reply-To: References: <87cyb1oq31.fsf@daniel-mendler.de> <86jz59mfjf.fsf@gnu.org> <87ikktdyx0.fsf@daniel-mendler.de> <87frfxw7j7.fsf@gmail.com> Date: Wed, 18 Jun 2025 15:31:53 +0200 Message-ID: <87bjqlw4za.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78820 Cc: Daniel Mendler , Eli Zaretskii , 78820@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 18 Jun 2025 08:41:57 -0400, St=C3=A9phane Marks said: >> No need: >>=20 >> (run-with-timer t savehist-autosave-interval #'savehist-autosave) >>=20 >> already works, although the docstring and the manual don=CA=BCt make= this >> clear, you need to read the manual for `run-at-time' attentively. >>=20 St=C3=A9phane> Funny perhaps I did that at the time, but I prefer the St=C3=A9phane> more precise form. Sure, that also works. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 11:06:37 2025 Received: (at 78820) by debbugs.gnu.org; 18 Jun 2025 15:06:37 +0000 Received: from localhost ([127.0.0.1]:52285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRuN2-0002l0-Vh for submit@debbugs.gnu.org; Wed, 18 Jun 2025 11:06:37 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:50639) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uRuMt-0002jZ-0z; Wed, 18 Jun 2025 11:06:27 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4532ff4331cso21246715e9.1; Wed, 18 Jun 2025 08:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750259180; x=1750863980; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0EI0liknVf88T6vBI4vksREeLPmIzK488ZIBdxHN1Mk=; b=XT1DITVIL+Blie6NSQqhYxerDEMQdkhUo8vp2DLqeZzSRPWMmKQJucmasJlENU+Yfm uZ7aHa3oIrjJLZ+/5qD9+A3pCJDcFgtk07nbA5Wx6Of2yBldwe0EIl/BQLDw+5d8GDHW Wlu7Dz4eEaRG1+Ngp3chM/Z2mSqy98dnXfxx3QRKHhkLYAJobR4CMStVP15LXQAQq/cb scDWx312j0RoPFU173K8k5kmYY+9UihWEMn+BMwh6rodr+4oEk9ZTuFBHDAioWrvR5+D l7SNM9KG2B2+Hk0+VSd5oPsv9wzwyx3A8XySjs2d06GVHHTtGodgxQ/jFubAMk9fNV5M nAyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750259180; x=1750863980; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0EI0liknVf88T6vBI4vksREeLPmIzK488ZIBdxHN1Mk=; b=F7qscGTtOCUh+MVpzEUO458TPpezjOSOPTnEJS/TdSTj7gDghPM4BGwcg9GuM9byCw S/6GgGzPogIOy0rOMHBjpI74rq/ICcy0rfT9NG55dh8285ME3ut9Vy8CB7sRTklozJ0U JZT+btSS+EYBH/5f2o1AshLRj7n2CyLR3JOY6eZRGGpkXwyQMp0AmBthEOYMlWuY+DiT JEV8OHcR//Ox9xJ4b3yXtrc32c59R/dMU/Lm6x0HoO8GGQbcsPtqey80nhKDwhYBvzOP MscAAztKFOUWO3ZeDIwIh0u/SPEsdCD3faJinEp43RseAYmoi+WlvfCtFQOWJsSrYttP YMHA== X-Forwarded-Encrypted: i=1; AJvYcCUCHKxkiZMf4ISpcrkIbJ0TVsXts/Mwq1evAAYH83FEsHO6OdHOBZH6D0VcE05cDp51mTdhUQ==@debbugs.gnu.org, AJvYcCVY7yMmjAJvm3AXbe42p+y2LxFwDMCT32Ydf5yUVguoYQEL3nSWXHGqPSLljQGdjvtJSnJvlcPe8w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YznEqalQCeyhQvkgGB+GKGhqLjAjmIuRkviXi8oKcHm1EK5PX0V oCrGr5R2EcqwxjFTdkxXgh1gDrrVXIGDhk9wp1y0klII1XEpHIYYm8TvfpHZ5nyf X-Gm-Gg: ASbGncsNrdmNwW/aGlN+nJ0a5Z82/pvDP57uN2mKOPlqPs6cAhs0AWkO2E3eZVsh4VY sHJsqZp08iCCeFpqLDTvb68yMZXZFP//IBWOwCizQ/SGMtEkJS2r/eVYYqYL62yBg1PJqv3g65I Sh1Dp6tQ/Fci57De3SD5BpFi83QKzOHlzzLA+QXz7FpfxhqiY4N5ASuJjT+sUJU2iU7Z8lvcPlF a705kG3FZuXOEq8yGXaDERI7eZJK2myxjpNFqEikNfGxARml8OQA6tqJR4iN1+iHWsVie1sRPZh o26gLsJ+0CqW8AsQY+TYEM0t2O8nZ+TsUaPEWM6E5HUIjPyJ X-Google-Smtp-Source: AGHT+IHhHtmRnE+jxC9OUeHqhHgJdHtDI1oFEPpU0yikolKtwse+AEJzkjz4YBUQOwmEBqJuFogi4A== X-Received: by 2002:a05:600d:b:b0:43d:fa5d:9315 with SMTP id 5b1f17b1804b1-45341b044cemr115676105e9.33.1750259179875; Wed, 18 Jun 2025 08:06:19 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:332:f25c:cdb8:eac9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535e993b72sm123105e9.27.2025.06.18.08.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 08:06:19 -0700 (PDT) From: Robert Pluim To: =?utf-8?Q?St=C3=A9phane?= Marks Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly In-Reply-To: <87bjqlw4za.fsf@gmail.com> References: <87cyb1oq31.fsf@daniel-mendler.de> <86jz59mfjf.fsf@gnu.org> <87ikktdyx0.fsf@daniel-mendler.de> <87frfxw7j7.fsf@gmail.com> <87bjqlw4za.fsf@gmail.com> Date: Wed, 18 Jun 2025 17:06:18 +0200 Message-ID: <877c19w0lx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78820 Cc: Daniel Mendler , Eli Zaretskii , 78820@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 78820 fixed close 78820 31.1 quit >>>>> On Wed, 18 Jun 2025 15:31:53 +0200, Robert Pluim s= aid: >>>>> On Wed, 18 Jun 2025 08:41:57 -0400, St=C3=A9phane Marks said: >>> No need: >>>=20 >>> (run-with-timer t savehist-autosave-interval #'savehist-autosave) >>>=20 >>> already works, although the docstring and the manual don=CA=BCt mak= e this >>> clear, you need to read the manual for `run-at-time' attentively. >>>=20 St=C3=A9phane> Funny perhaps I did that at the time, but I prefer the St=C3=A9phane> more precise form. Robert> Sure, that also works. Done. Robert --=20 Pushed to master. 318715105d0 2025-06-18T17:03:36+02:00 "Make savehist timer actually repeat" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D318715105d05036a2e= 1307a57b4febcf15048912