GNU bug report logs - #78820
31.0.50; savehist timer does not run repeatedly

Previous Next

To reply to this bug, email your comments to 78820 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 02:23:14 +0200

It seems that the savehist timer does not run repeatedly. run-with-timer
is called with repeat argument t.

(run-with-timer savehist-autosave-interval t #'savehist-autosave)

If I understand correctly, the correct call should look like this:

(run-with-timer t savehist-autosave-interval #'savehist-autosave)
(run-with-timer savehist-autosave-interval savehist-autosave-interval #'savehist-autosave)

Message #8 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Stéphane Marks <shipmints <at> gmail.com>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 78820 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 05:56:08 -0400

[Message part 1 (text/plain, inline)]

On Tue, Jun 17, 2025 at 8:24 PM Daniel Mendler via Bug reports for GNU
Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:

> It seems that the savehist timer does not run repeatedly. run-with-timer
> is called with repeat argument t.
>
> (run-with-timer savehist-autosave-interval t #'savehist-autosave)
>
> If I understand correctly, the correct call should look like this:
>
> (run-with-timer t savehist-autosave-interval #'savehist-autosave)
> (run-with-timer savehist-autosave-interval savehist-autosave-interval
> #'savehist-autosave)
>

100% right.  I think this silly typo/thinko was me.  I could submit a patch
but I don't have commit access.  It would be faster for this one-liner if
someone else patched.

[Message part 2 (text/html, inline)]

Message #11 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Stéphane Marks <shipmints <at> gmail.com>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 78820 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 05:57:17 -0400

[Message part 1 (text/plain, inline)]

On Wed, Jun 18, 2025 at 5:56 AM Stéphane Marks <shipmints <at> gmail.com> wrote:

> On Tue, Jun 17, 2025 at 8:24 PM Daniel Mendler via Bug reports for GNU
> Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
>
>> It seems that the savehist timer does not run repeatedly. run-with-timer
>> is called with repeat argument t.
>>
>> (run-with-timer savehist-autosave-interval t #'savehist-autosave)
>>
>> If I understand correctly, the correct call should look like this:
>>
>> (run-with-timer t savehist-autosave-interval #'savehist-autosave)
>> (run-with-timer savehist-autosave-interval savehist-autosave-interval
>> #'savehist-autosave)
>>
>
> 100% right.  I think this silly typo/thinko was me.  I could submit a
> patch but I don't have commit access.  It would be faster for this
> one-liner if someone else patched.
>

Originally bug 75834.

[Message part 2 (text/html, inline)]

Message #14 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 78820 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 14:53:56 +0300

> Cc: "Stefan Monnier" <monnier <at> iro.umontreal.ca>
> Date: Wed, 18 Jun 2025 02:23:14 +0200
> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> It seems that the savehist timer does not run repeatedly. run-with-timer
> is called with repeat argument t.
> 
> (run-with-timer savehist-autosave-interval t #'savehist-autosave)
> 
> If I understand correctly, the correct call should look like this:
> 
> (run-with-timer t savehist-autosave-interval #'savehist-autosave)
> (run-with-timer savehist-autosave-interval savehist-autosave-interval #'savehist-autosave)

Why do you think so?  The calling sequence of run-with-timer is this:

  (run-with-timer SECS REPEAT FUNCTION &rest ARGS)

So what savehist.el does appears to be correct.  Or what am I missing?

Message #17 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Stéphane Marks <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 78820 <at> debbugs.gnu.org,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 08:12:39 -0400

[Message part 1 (text/plain, inline)]

On Wed, Jun 18, 2025 at 7:55 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: "Stefan Monnier" <monnier <at> iro.umontreal.ca>
> > Date: Wed, 18 Jun 2025 02:23:14 +0200
> > From:  Daniel Mendler via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >
> > It seems that the savehist timer does not run repeatedly. run-with-timer
> > is called with repeat argument t.
> >
> > (run-with-timer savehist-autosave-interval t #'savehist-autosave)
> >
> > If I understand correctly, the correct call should look like this:
> >
> > (run-with-timer t savehist-autosave-interval #'savehist-autosave)
> > (run-with-timer savehist-autosave-interval savehist-autosave-interval
> #'savehist-autosave)
>
> Why do you think so?  The calling sequence of run-with-timer is this:
>
>   (run-with-timer SECS REPEAT FUNCTION &rest ARGS)
>
> So what savehist.el does appears to be correct.  Or what am I missing?
>

(defun savehist--manage-timer ()
;; should be
   (run-with-timer savehist-autosave-interval
                   savehist-autosave-interval #'savehist-autosave))
;; not silly t
   (run-with-timer savehist-autosave-interval t #'savehist-autosave))

[Message part 2 (text/html, inline)]

Message #20 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Stéphane Marks <shipmints <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78820 <at> debbugs.gnu.org,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 14:20:11 +0200

Stéphane Marks <shipmints <at> gmail.com> writes:

> On Wed, Jun 18, 2025 at 7:55 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> > Cc: "Stefan Monnier" <monnier <at> iro.umontreal.ca>
>> > Date: Wed, 18 Jun 2025 02:23:14 +0200
>> > From:  Daniel Mendler via "Bug reports for GNU Emacs,
>> >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> >
>> > It seems that the savehist timer does not run repeatedly. run-with-timer
>> > is called with repeat argument t.
>> >
>> > (run-with-timer savehist-autosave-interval t #'savehist-autosave)
>> >
>> > If I understand correctly, the correct call should look like this:
>> >
>> > (run-with-timer t savehist-autosave-interval #'savehist-autosave)
>> > (run-with-timer savehist-autosave-interval savehist-autosave-interval
>> #'savehist-autosave)
>>
>> Why do you think so?  The calling sequence of run-with-timer is this:
>>
>>   (run-with-timer SECS REPEAT FUNCTION &rest ARGS)
>>
>> So what savehist.el does appears to be correct.  Or what am I missing?
>>
>
> (defun savehist--manage-timer ()
> ;; should be
>    (run-with-timer savehist-autosave-interval
>                    savehist-autosave-interval #'savehist-autosave))
> ;; not silly t
>    (run-with-timer savehist-autosave-interval t #'savehist-autosave))

To clarify, with the argument t, the timer does not run repeatedly, but
only once. That's the problem. Btw I wonder if it would make sense to
allow Stéphane's calling convention too and just dtrt. It is not
obviously silly imo.

Daniel

Message #23 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: <bug-gnu-emacs <at> gnu.org>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, Eli Zaretskii <eliz <at> gnu.org>,
 78820 <at> debbugs.gnu.org, Stéphane Marks <shipmints <at> gmail.com>,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 14:36:44 +0200

>>>>> On Wed, 18 Jun 2025 14:20:11 +0200, Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> said:
    >> (defun savehist--manage-timer ()
    >> ;; should be
    >> (run-with-timer savehist-autosave-interval
    >> savehist-autosave-interval #'savehist-autosave))
    >> ;; not silly t
    >> (run-with-timer savehist-autosave-interval t #'savehist-autosave))

    Daniel> To clarify, with the argument t, the timer does not run repeatedly, but
    Daniel> only once. That's the problem. Btw I wonder if it would make sense to
    Daniel> allow Stéphane's calling convention too and just dtrt. It is not
    Daniel> obviously silly imo.

No need:

    (run-with-timer t savehist-autosave-interval #'savehist-autosave)

already works, although the docstring and the manual donʼt make this
clear, you need to read the manual for `run-at-time' attentively.


Robert
-- 

Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stéphane Marks <shipmints <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, bug-gnu-emacs <at> gnu.org,
 78820 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, monnier <at> iro.umontreal.ca
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 08:41:57 -0400

[Message part 1 (text/plain, inline)]

On Wed, Jun 18, 2025 at 8:36 AM Robert Pluim <rpluim <at> gmail.com> wrote:

> >>>>> On Wed, 18 Jun 2025 14:20:11 +0200, Daniel Mendler via "Bug reports
> for GNU Emacs, the Swiss army knife of text editors" <
> bug-gnu-emacs <at> gnu.org> said:
>     >> (defun savehist--manage-timer ()
>     >> ;; should be
>     >> (run-with-timer savehist-autosave-interval
>     >> savehist-autosave-interval #'savehist-autosave))
>     >> ;; not silly t
>     >> (run-with-timer savehist-autosave-interval t #'savehist-autosave))
>
>     Daniel> To clarify, with the argument t, the timer does not run
> repeatedly, but
>     Daniel> only once. That's the problem. Btw I wonder if it would make
> sense to
>     Daniel> allow Stéphane's calling convention too and just dtrt. It is
> not
>     Daniel> obviously silly imo.
>
> No need:
>
>     (run-with-timer t savehist-autosave-interval #'savehist-autosave)
>
> already works, although the docstring and the manual donʼt make this
> clear, you need to read the manual for `run-at-time' attentively.
>

Funny perhaps I did that at the time, but I prefer the more precise form.

[Message part 2 (text/html, inline)]

Message #35 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Stéphane Marks <shipmints <at> gmail.com>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, Eli Zaretskii <eliz <at> gnu.org>,
 78820 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 15:31:53 +0200

>>>>> On Wed, 18 Jun 2025 08:41:57 -0400, Stéphane Marks <shipmints <at> gmail.com> said:

    >> No need:
    >> 
    >> (run-with-timer t savehist-autosave-interval #'savehist-autosave)
    >> 
    >> already works, although the docstring and the manual donʼt make this
    >> clear, you need to read the manual for `run-at-time' attentively.
    >> 

    Stéphane> Funny perhaps I did that at the time, but I prefer the
    Stéphane> more precise form.

Sure, that also works.

Robert
-- 

Message #38 received at 78820 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Stéphane Marks <shipmints <at> gmail.com>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, Eli Zaretskii <eliz <at> gnu.org>,
 78820 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#78820: 31.0.50; savehist timer does not run repeatedly
Date: Wed, 18 Jun 2025 17:06:18 +0200

tags 78820 fixed
close 78820 31.1
quit

>>>>> On Wed, 18 Jun 2025 15:31:53 +0200, Robert Pluim <rpluim <at> gmail.com> said:

>>>>> On Wed, 18 Jun 2025 08:41:57 -0400, Stéphane Marks <shipmints <at> gmail.com> said:
    >>> No need:
    >>> 
    >>> (run-with-timer t savehist-autosave-interval #'savehist-autosave)
    >>> 
    >>> already works, although the docstring and the manual donʼt make this
    >>> clear, you need to read the manual for `run-at-time' attentively.
    >>> 

    Stéphane> Funny perhaps I did that at the time, but I prefer the
    Stéphane> more precise form.

    Robert> Sure, that also works.

Done.

Robert
-- 

Pushed to master.

318715105d0 2025-06-18T17:03:36+02:00 "Make savehist timer actually repeat"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=318715105d05036a2e1307a57b4febcf15048912

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.