GNU bug report logs - #78803
[PATCH] Allow starting with 'C-x O' for other-window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 78803 in the body.
You can then email your comments to 78803 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: James Thomas <jimjoe <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow starting with 'C-x O' for other-window
Date: Mon, 16 Jun 2025 07:05:49 +0530

[Message part 1 (text/plain, inline)]

Tags: patch
Severity: wishlist

Is this a good idea? (I shall use it anyway :-))

In GNU Emacs 31.0.50 (build 6, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.0, Xaw scroll bars) of 2025-06-16 built on inspiron15
Repository revision: 9b80d2ea28826466b86e00631718a47a3f2fa2ee
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: Guix System

Configured using:
 'configure --with-x-toolkit=lucid --with-native-compilation=aot
 PKG_CONFIG_PATH=/gnu/store/j6rdgb6pk0274dfl0mdqxal89kpf18zj-profile/lib/pkgconfig:/gnu/store/j6rdgb6pk0274dfl0mdqxal89kpf18zj-profile/share/pkgconfig'

[0001-Allow-starting-with-C-x-O-for-other-window.patch (text/patch, attachment)]

Message #8 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: James Thomas <jimjoe <at> gmx.net>
To: 78803 <at> debbugs.gnu.org
Subject: [PATCH] Allow starting with 'C-x O' for other-window
Date: Mon, 16 Jun 2025 10:57:30 +0530

With repeat-mode one may use 'O' after a first 'C-x o': which involves a
stop-over in the current window, even if the intention was to move to
the previous window in the first place. But this lets you use a 'C-x O'
for that, at the start itself.

(Sorry, forgot to add the explanation earlier)

--

Message #11 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: James Thomas <jimjoe <at> gmx.net>
Cc: 78803 <at> debbugs.gnu.org, ultrono <at> gmail.com
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Mon, 16 Jun 2025 09:33:27 +0300

> Is this a good idea? (I shall use it anyway :-))
>
>  (define-key ctl-x-map "o" 'other-window)
> +(define-key ctl-x-map "O" (lambda ()
> +                            (interactive)
> +                            (setq repeat-map 'other-window-repeat-map)
> +                            (other-window -1)))

If we'll decide to add the global C-x keybinding 'C-x O',
then better to create a special command with the name such as
'other-window-backward' like we created a special command
'tab-bar-move-tab-backward' for symmetry with 'tab-bar-move-tab'.

Message #14 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: "Paul D. Nelson" <ultrono <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 78803 <at> debbugs.gnu.org, jimjoe <at> gmx.net
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Mon, 16 Jun 2025 11:55:06 +0200

>> Is this a good idea? (I shall use it anyway :-))
>>
>>  (define-key ctl-x-map "o" 'other-window)
>> +(define-key ctl-x-map "O" (lambda ()
>> +                            (interactive)
>> +                            (setq repeat-map 'other-window-repeat-map)
>> +                            (other-window -1)))
>
> If we'll decide to add the global C-x keybinding 'C-x O',
> then better to create a special command with the name such as
> 'other-window-backward' like we created a special command
> 'tab-bar-move-tab-backward' for symmetry with 'tab-bar-move-tab'.

Seems like a good idea at least to me.  [I've had something equivalent
in my config for a long time -- maybe why I was CC'd?]

Thanks, best

Paul

Message #17 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: "Paul D. Nelson" <ultrono <at> gmail.com>
To: James Thomas <jimjoe <at> gmx.net>
Cc: 78803 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Tue, 24 Jun 2025 15:45:24 +0200

Thanks, I see.  Your patch looks good to me (perhaps modulo NEWS entry)

Message #20 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: James Thomas <jimjoe <at> gmx.net>
To: 78803 <at> debbugs.gnu.org
Cc: "Paul D. Nelson" <ultrono <at> gmail.com>, juri <at> linkov.net
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Fri, 11 Jul 2025 09:22:41 +0530

[Message part 1 (text/plain, inline)]

"Paul D. Nelson" writes:

> Thanks, I see.  Your patch looks good to me (perhaps modulo NEWS entry)

May this not die for want of that... :

[0001-Add-other-window-backward-for-a-default-binding.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Regards,
James

Message #23 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: James Thomas <jimjoe <at> gmx.net>
To: 78803 <at> debbugs.gnu.org
Cc: "Paul D. Nelson" <ultrono <at> gmail.com>, juri <at> linkov.net
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Fri, 11 Jul 2025 12:06:17 +0530

[Message part 1 (text/plain, inline)]

James Thomas writes:

> "Paul D. Nelson" writes:
>
>> Thanks, I see.  Your patch looks good to me (perhaps modulo NEWS entry)
>
> May this not die for want of that... :

Or for a more complete commit message:

[0001-Add-other-window-backward-for-a-default-binding.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

--

Message #26 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: James Thomas <jimjoe <at> gmx.net>
Cc: juri <at> linkov.net, 78803 <at> debbugs.gnu.org, ultrono <at> gmail.com
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Sat, 26 Jul 2025 11:27:31 +0300

> Cc: "Paul D. Nelson" <ultrono <at> gmail.com>, juri <at> linkov.net
> Date: Fri, 11 Jul 2025 12:06:17 +0530
> From:  James Thomas via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> James Thomas writes:
> 
> > "Paul D. Nelson" writes:
> >
> >> Thanks, I see.  Your patch looks good to me (perhaps modulo NEWS entry)
> >
> > May this not die for want of that... :
> 
> Or for a more complete commit message:

Thanks, almost there.

> From 3cacdd6519c65a09b8397ae337083595d4d0f191 Mon Sep 17 00:00:00 2001
> From: James Thomas <jimjoe <at> gmx.net>
> Date: Mon, 16 Jun 2025 01:20:31 +0530
> Subject: [PATCH] Add 'other-window-backward' for a default binding
> 
> This moves in the opposite direction to 'other-window' by
> default, and is consistent with its repeat map.
> * lisp/window.el (other-window-backward): New function bound to
> 'C-x O'.
> (ctl-x-map): Update definition.
> * doc/emacs/windows.texi (Other Window): Update docs.
> * etc/NEWS: Announce the new command.

Please mention the bug number in the log message.

> +(defun other-window-backward (count &optional all-frames interactive)
> +    "Select another window in the cyclic ordering of windows, skipping
> +COUNT windows backward, starting with the selected window, before making
> +the selection.  Like `other-window', but moves in the opposite
> +direction."

The first line of the doc string must be a single complete sentence.
I suggest

  Select another window in reverse cyclic ordering of windows.

Then explain what the "reverse" means here in the rest of the doc
string.

Message #29 received at 78803 <at> debbugs.gnu.org (full text, mbox):

From: James Thomas <jimjoe <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: juri <at> linkov.net, 78803 <at> debbugs.gnu.org, ultrono <at> gmail.com
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Wed, 30 Jul 2025 04:46:59 +0530

[Message part 1 (text/plain, inline)]

Eli Zaretskii  writes:

>> Cc: "Paul D. Nelson" , juri <at> linkov.net
>> Date: Fri, 11 Jul 2025 12:06:17 +0530
>> From:  James Thomas via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" 
>> 
>> James Thomas writes:
>> 
>> > "Paul D. Nelson" writes:
>> >
>> >> Thanks, I see.  Your patch looks good to me (perhaps modulo NEWS entry)
>> >
>> > May this not die for want of that... :
>> 
>> Or for a more complete commit message:
>
> Thanks, almost there.
>
>> From 3cacdd6519c65a09b8397ae337083595d4d0f191 Mon Sep 17 00:00:00 2001
>> From: James Thomas 
>> Date: Mon, 16 Jun 2025 01:20:31 +0530
>> Subject: [PATCH] Add 'other-window-backward' for a default binding
>> 
>> This moves in the opposite direction to 'other-window' by
>> default, and is consistent with its repeat map.
>> * lisp/window.el (other-window-backward): New function bound to
>> 'C-x O'.
>> (ctl-x-map): Update definition.
>> * doc/emacs/windows.texi (Other Window): Update docs.
>> * etc/NEWS: Announce the new command.
>
> Please mention the bug number in the log message.
>
>> +(defun other-window-backward (count &optional all-frames interactive)
>> +    "Select another window in the cyclic ordering of windows, skipping
>> +COUNT windows backward, starting with the selected window, before making
>> +the selection.  Like `other-window', but moves in the opposite
>> +direction."
>
> The first line of the doc string must be a single complete sentence.
> I suggest
>
>   Select another window in reverse cyclic ordering of windows.
>
> Then explain what the "reverse" means here in the rest of the doc
> string.

Modified accordingly, with an attempt to keep it concise:

[0001-Add-other-window-backward-for-a-default-binding-bug-.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

--

Message #34 received at 78803-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: James Thomas <jimjoe <at> gmx.net>
Cc: juri <at> linkov.net, 78803-done <at> debbugs.gnu.org, ultrono <at> gmail.com
Subject: Re: bug#78803: [PATCH] Allow starting with 'C-x O' for other-window
Date: Sat, 02 Aug 2025 17:27:09 +0300

> From: James Thomas <jimjoe <at> gmx.net>
> Cc: 78803 <at> debbugs.gnu.org,  ultrono <at> gmail.com,  juri <at> linkov.net
> Date: Wed, 30 Jul 2025 04:46:59 +0530
> 
> Modified accordingly, with an attempt to keep it concise:

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.