GNU bug report logs - #78794
[PATCH] Pretiffy package-menu

Previous Next

Full log

Message #35 received at 78794 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 78794 <at> debbugs.gnu.org, philipk <at> posteo.net
Subject: Re: bug#78794: [PATCH] Pretiffy package-menu
Date: Sat, 21 Jun 2025 11:33:13 +0300

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: 78794 <at> debbugs.gnu.org,  philipk <at> posteo.net
> Date: Wed, 18 Jun 2025 19:31:57 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> >> Cc: Eli Zaretskii <eliz <at> gnu.org>,  78794 <at> debbugs.gnu.org
> >> Date: Mon, 16 Jun 2025 13:52:32 -0600
> >> 
> >> Philip Kaludercic <philipk <at> posteo.net> writes:
> >> 
> >> >>> +(defcustom package-menu-marks-indicators
> >> >>> +  '((install . "I")
> >> >>> +    (delete . "D"))
> >> >>> +  "Alist indicators to indicate a package is marked to install or delete.
> >> >>> +The value of each list must be in the formt: '(KIND . MARK) where KIND
> >> >>> +is the kind mark performed (`install' or `delete') in package-menu and
> >> >>> +MARK a string to use for mark the packages.  This currently support
> >> >>> +marks for install and delete."
> >> >
> >> > What is the reason we would want to customise this in the first place?
> >> 
> >> IMO, the I and D characters looks somewhat ugly to me, making them
> >> customizable allows to change them to an Unicode/Emoji icon (or any
> >> other character), making them more recognizable according to the user's
> >> preferences (e.g. 🗑️/♻️ and ✅).
> >
> > I hear you, but AFAIR we don't provide such customizations in any
> > other clients of tabulated-list-mode, so why do it here?
> 
> Fine, then I've removed the option/feature here, to avoid making this
> thread longer.

Thanks.

Byte-compiling this brings up the following warning:

    ELC      emacs-lisp/package.elc

  In package-menu-mode:
  emacs-lisp/package.el:3242:16: Warning: reference to free variable `package-menu-mode-line-format'

Also, I have no packages installed, but the mode line says "New: 0",
with the help-echo saying "Total number of new packages available".
This is confusing; perhaps we need to use a different word instead of
"New"?

> +(defface package-mark-install-line
> +  '((((class color) (background light))
> +     :background "darkolivegreen1" :extend t)
> +    (((class color) (background dark))
> +     :background "seagreen" :extend t)
> +    (t :inherit (highlight) :extend t))
> +  "Face used for highlight the line where a package is marked to install."
                ^^^^^^^^^^^^^                             ^^^^^^^^^^^^^^^^^
Either "for highlighting" or "to highlight".
Also, "marked to be installed".

> +(defface package-mark-delete-line
> +  '((((class color) (background light))
> +     :background "rosybrown1" :extend t)
> +    (((class color) (background dark))
> +     :background "indianred4" :extend t)
> +    (t :inherit (highlight) :extend t))
> +  "Face used for highlight the line where a package is marked to delete."

Same here.

Could you please fix these nits and resubmit?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.