GNU bug report logs - #78794
[PATCH] Pretiffy package-menu

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 78794 <at> debbugs.gnu.org, philipk <at> posteo.net
Subject: bug#78794: [PATCH] Pretiffy package-menu
Date: Tue, 17 Jun 2025 14:20:36 +0300

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  78794 <at> debbugs.gnu.org
> Date: Mon, 16 Jun 2025 13:52:32 -0600
> 
> Philip Kaludercic <philipk <at> posteo.net> writes:
> 
> >>> +(defcustom package-menu-marks-indicators
> >>> +  '((install . "I")
> >>> +    (delete . "D"))
> >>> +  "Alist indicators to indicate a package is marked to install or delete.
> >>> +The value of each list must be in the formt: '(KIND . MARK) where KIND
> >>> +is the kind mark performed (`install' or `delete') in package-menu and
> >>> +MARK a string to use for mark the packages.  This currently support
> >>> +marks for install and delete."
> >
> > What is the reason we would want to customise this in the first place?
> 
> IMO, the I and D characters looks somewhat ugly to me, making them
> customizable allows to change them to an Unicode/Emoji icon (or any
> other character), making them more recognizable according to the user's
> preferences (e.g. 🗑️/♻️ and ✅).

I hear you, but AFAIR we don't provide such customizations in any
other clients of tabulated-list-mode, so why do it here?

> 
> >> This doc string has several grammatical issues, and also lacks some
> >> important information.  I suggest to rephrase as follows:
> >>
> >>    "Indicators for packages to be installed or deleted.
> >>  The value is an alist whose elements have the form (KIND . MARK),
> >>  where KIND is the operation to perform, either `install' or `delete',
> >>  and MARK is a string to indicate that the operation is pending for
> >>  the package.  The MARK string should satisfy the requirements of the
> >>  TAG argument of `tabulated-list-put-tag', which see.  It is displayed
> >>  in the padding area of the package's line.
> >>
> >>  Currently, only indicators for installing or deleting a package are
> >>  supported."
> >>
> >>> +  :type '(list (cons symbol string)
> >>> +               (cons symbol string))
> >>
> >> Can we come up with a meaningful :tag for the value?
> >
> > (I haven't check it, but...) is this the type of
> > `package-menu-marks-indicators'?  If so, we shouldn't document the user
> > option as an Alist.
> 
> But what other name would be better?

I don't agree with Philip here: we do say in doc strings of user
options that the value should be an alist.  We could use "association
list" if that makes it more clear, though.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.