GNU bug report logs - #78794
[PATCH] Pretiffy package-menu

Previous Next

Full log

View this message in rfc822 format

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78794 <at> debbugs.gnu.org
Subject: bug#78794: [PATCH] Pretiffy package-menu
Date: Sun, 15 Jun 2025 13:02:06 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> Date: Sat, 14 Jun 2025 20:12:34 -0600
>> 
>> +---
>> +*** New user option 'package-menu-mode-line'.
>> +If non-nil, package-menu will display additional information about Total
>> +packages installed, Total packages from all the package archives, Total
>> +packages to upgrade and Total new packages available.
>
> Any reason not to have this by default, and drop the option?

This is enabled by default (I forgot to include it in the NEWS entry).
The reason why i decided make it an option is because some user
may find it annoying.

>> +(defface package-mark-install-line
>> +  '((((class color) (min-colors 88) (background light))
>> +     :background "darkolivegreen1" :extend t)
>> +    (((class color) (min-colors 88) (background dark))
>> +     :background "seagreen" :extend t)
>> +    (((class color) (min-colors 8))
>> +     :background "green" :foreground "white" :extend t)
>
> If tty-color translation produces "green" from the two green shades
> you define for 88+ color displays, then the last part is not needed.

Fine.

>> +    (t :inverse-video t :extend t))
>
> Isn't the mode line shown in inverse video by default in monochrome
> case?  If so, this is not needed, either.

These faces are not for the mode-line, are for the package-menu buffer,
specifically for highlight the line where a package was marked for
install/delete.

>> +(define-fringe-bitmap
>> +  'package-menu-install
>> +  (vector
>> +   #b000000
>> +   #b001100
>> +   #b001100
>> +   #b111111
>> +   #b111111
>> +   #b001100
>> +   #b001100
>> +   #b000000)
>> +  nil nil 'center)
>> +
>> +(define-fringe-bitmap
>> +  'package-menu-delete
>> +  (vector
>> +   #b000000
>> +   #b000000
>> +   #b000000
>> +   #b111111
>> +   #b111111
>> +   #b000000
>> +   #b000000
>> +   #b000000)
>> +  nil nil 'center)
>
> Both colors _and_ fringe markers?  Isn't than too much?

Well, I don't know what others say about this, the fringes were
originally intended as an alternative to the "I" and "D" marks.

Anyways I've added a better alternative to fringes.

>> +;; Mode-line
>> +(defcustom package-menu-mode-line t
>> +  "If non-nil, package-menu will display additional information in mode-line.
>> +package-menu mode-line information includes: Total packages installed,
>> +Total packages from all the packages archive, Total packages to upgrade
>> +and Total new packages available."
>
> Capitalization is wrong here: the last sentence should start with a
> capital letter, whereas the "Total something" parts should not be
> capitalized.

Thanks, fixed.

>> +              ;; XXX: Add a efficient way for set these variables (?)
>
> What about this part?

Oh, that was temporal, I was supposed to remove it before making the
patch.

[0001-Pretiffy-package-menu-Bug-78794.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.