From unknown Fri Aug 15 17:22:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78782: 31.0.50 ; remove eieio's *-list-p Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2025 13:28:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 78782@debbugs.gnu.org, monnier@iro.umontreal.ca X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Stefan Monnier Received: via spool by submit@debbugs.gnu.org id=B.17498212542691 (code B ref -1); Fri, 13 Jun 2025 13:28:04 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2025 13:27:34 +0000 Received: from localhost ([127.0.0.1]:44797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uQ4RS-0000hK-B1 for submit@debbugs.gnu.org; Fri, 13 Jun 2025 09:27:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46562) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uQ4RP-0000fc-HZ for submit@debbugs.gnu.org; Fri, 13 Jun 2025 09:27:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uQ4R9-0006GF-1i for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2025 09:27:16 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uQ4R6-0004EA-B5 for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2025 09:27:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1749821229; x=1750080429; bh=Gq6daXKDgxI34Knnlm2jWGrbgsFADvvYX7rnKPjHGyM=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=HsKU3FN4HOenihMyRaC2ZHHSI/IRznoiAG6Szk7W1fPC3hipuNZZeEusK3dJAwPvG lHr9OeQh20gZdgtJTVOqjncbTaXIxWXX2oL8DwtP/AmXeTWl1Ewc3mnMyaKsbrxyjT W7OGZMm2siArK49ZL42Drw7a8NaXDOpzpXanB/FZ5402n8NAMDo3F6ThZGZ86Ws8k2 l8gpyIXrajclVLI9TSkZUYxlDh0i8H925YiQCUXITdA/IZdcxKz4RNHwV5aPvJOaLk 2FMejxNnfHZxjYGuZ0RhugWOwgEcPccb+zDoMNtGYlaPVbPojQijI8y3QK1h7CEPum rIu0u1IZLwQmA== Date: Fri, 13 Jun 2025 13:27:04 +0000 From: Pip Cet Message-ID: <87ecvnydp8.fsf@protonmail.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 04e9ea8cb96512501c3ba507e372cea5bf8b12fd MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=pipcet@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This code in eieio-core.el: (lambda (obj) (:documentation (format "Test OBJ to see if it a list of objects which are a child of= type %s" cname)) (when (listp obj) (let ((ans t)) ;; nil is valid ;; Loop over all the elements of the input list, test ;; each to make sure it is a child of the desired object cl= ass. (while (and obj ans) (setq ans (and (eieio-object-p (car obj)) (object-of-class-p (car obj) 'cname))) (setq obj (cdr obj))) ans)))) creates *-list-p, which then tests whether a list of objects are all descendants of class 'cname, a literal symbol. This works only if the class we're defining is called "cname", and no one noticed, so it's time to remove this obsolete function (obsoleted in 25.1). The code has been in place since: commit 2c47eaa18a4a3f7eb53ed826d8c5d018ac843586 AuthorDate: Tue May 18 17:13:37 2021 -0400 This would probably also make (defclass proper nil 'x) work, instead of redefining proper-list-p to be a different function. OK to do this on master? From unknown Fri Aug 15 17:22:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78782: 31.0.50 ; remove eieio's *-list-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2025 14:15:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet Cc: 78782@debbugs.gnu.org Received: via spool by 78782-submit@debbugs.gnu.org id=B78782.174982409216214 (code B ref 78782); Fri, 13 Jun 2025 14:15:04 +0000 Received: (at 78782) by debbugs.gnu.org; 13 Jun 2025 14:14:52 +0000 Received: from localhost ([127.0.0.1]:46812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uQ5BE-0004DS-Ho for submit@debbugs.gnu.org; Fri, 13 Jun 2025 10:14:52 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12098) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uQ5BB-0004D9-Ds for 78782@debbugs.gnu.org; Fri, 13 Jun 2025 10:14:50 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7F3244414E9; Fri, 13 Jun 2025 10:14:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1749824079; bh=NroBHzKk9ZCQR8To2Mc+AVIG16VnWGzD1cFBZq6nKvU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=picC+sVCnvP0iQO1WvF5hAf0Jg9woV9V2CweJwq4Oz4FmmM/LdaGtCgNlFkW1IPhW LJo2tds2Mu+y8mgHhXqiPjfhWK0TsUzaM54pkAoDTR3vmaP+8s92gFiPvsdFVcY5Ip cwVVke8XuQ/+SD+joNTcOJz3tOFQzWW8g4QSSoqysg3RA4R8DK91qkW5LlZ4MApWVa w363S9ACh14JDLiwWOjA1BdFah0UFajK8eUN8bS0xi2P+BaFzg4C/wMbVgg31SsMb9 AwWCEZvC2Yfderfz75d1/vHNWvvROm7SyZLlfa33hKE8hiix8lQjt3qJiTuRS+iLct kFXo8eboNZFMQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8D66C4414C9; Fri, 13 Jun 2025 10:14:39 -0400 (EDT) Received: from asado (unknown [130.159.220.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7B6B31204B4; Fri, 13 Jun 2025 10:14:38 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87ecvnydp8.fsf@protonmail.com> Message-ID: References: <87ecvnydp8.fsf@protonmail.com> Date: Fri, 13 Jun 2025 10:14:36 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > OK to do this on master? +1 Stefan From unknown Fri Aug 15 17:22:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78782: 31.0.50 ; remove eieio's *-list-p Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jun 2025 09:15:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet Cc: 78782@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 78782-submit@debbugs.gnu.org id=B78782.175110208319484 (code B ref 78782); Sat, 28 Jun 2025 09:15:04 +0000 Received: (at 78782) by debbugs.gnu.org; 28 Jun 2025 09:14:43 +0000 Received: from localhost ([127.0.0.1]:47828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uVRdx-000541-Rk for submit@debbugs.gnu.org; Sat, 28 Jun 2025 05:14:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57276) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uVRdw-000539-3U for 78782@debbugs.gnu.org; Sat, 28 Jun 2025 05:14:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uVRdq-00061B-LJ; Sat, 28 Jun 2025 05:14:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EXvLU+uxqpFg2igAqr9d7dMoVMKeOb0weCAqWz7sl00=; b=SSlSBXglsGRI +d4EFUAu+Du8g1bH80apaBBrJoj+Rl0GGnHw0YvbFZ0uXO203INVhFX0EZzJfb0g1JrfI0SxvsojM VHT95WTAPbuVBazi4/vXTKyaaLq1X0/uQzw41QobbSqmR9riCIVsXHKbN2Lz52Tes1hx+hJyqIK0y GGqZuFxoI3q4V9w7nOgSXb5kKTr6KwmMqEJid+C+inT5xmMLGFuTQtuaosl5bJT/q98jaek1+DURV iRTy+i01uhWSDeUE+SVGxa2hGfJAXh4IktmdXQr93Mg6gFjwFEM7t7BfGYLK9Bj3kI7tl4JKB7gPS F6Hpo9rCeslyAA4neoqKVw==; Date: Sat, 28 Jun 2025 12:14:32 +0300 Message-Id: <86v7og6xdz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87ecvnydp8.fsf@protonmail.com> (bug-gnu-emacs@gnu.org) References: <87ecvnydp8.fsf@protonmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 13 Jun 2025 13:27:04 +0000 > From: Pip Cet via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This code in eieio-core.el: > > (lambda (obj) > (:documentation > (format > "Test OBJ to see if it a list of objects which are a child of type %s" > cname)) > (when (listp obj) > (let ((ans t)) ;; nil is valid > ;; Loop over all the elements of the input list, test > ;; each to make sure it is a child of the desired object class. > (while (and obj ans) > (setq ans (and (eieio-object-p (car obj)) > (object-of-class-p (car obj) 'cname))) > (setq obj (cdr obj))) > ans)))) > > creates *-list-p, which then tests whether a list of objects are all > descendants of class 'cname, a literal symbol. This works only if the > class we're defining is called "cname", and no one noticed, so it's time > to remove this obsolete function (obsoleted in 25.1). > > The code has been in place since: > > commit 2c47eaa18a4a3f7eb53ed826d8c5d018ac843586 > AuthorDate: Tue May 18 17:13:37 2021 -0400 > > This would probably also make (defclass proper nil 'x) work, instead of > redefining proper-list-p to be a different function. > > OK to do this on master? Fine by me, thanks. From unknown Fri Aug 15 17:22:41 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Pip Cet Subject: bug#78782: closed (Re: bug#78782: 31.0.50 ; remove eieio's *-list-p) Message-ID: References: <874iw02pjl.fsf@protonmail.com> <87ecvnydp8.fsf@protonmail.com> X-Gnu-PR-Message: they-closed 78782 X-Gnu-PR-Package: emacs Reply-To: 78782@debbugs.gnu.org Date: Sat, 28 Jun 2025 09:18:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1751102283-21512-1" This is a multi-part message in MIME format... ------------=_1751102283-21512-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #78782: 31.0.50 ; remove eieio's *-list-p which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 78782@debbugs.gnu.org. --=20 78782: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78782 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1751102283-21512-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 78782-done) by debbugs.gnu.org; 28 Jun 2025 09:17:51 +0000 Received: from localhost ([127.0.0.1]:47837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uVRh0-0005ZE-4U for submit@debbugs.gnu.org; Sat, 28 Jun 2025 05:17:50 -0400 Received: from mail-10631.protonmail.ch ([79.135.106.31]:48491) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uVRgx-0005Xo-4x for 78782-done@debbugs.gnu.org; Sat, 28 Jun 2025 05:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1751102259; x=1751361459; bh=fE+RmugTUTdzDHWim6OdNhxVBGKDlEPhpfOwWjTHXBA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=zOYRt1BN2rQAUkX6sxgoH2P6xglu9xckzhuPOOTDzSjNa7k7auC1nyOaZMEz+DC/a rUxTmfi9WCfKvBH1YdtiMYojE41POtW2jieAWc03eR8rOR06EO5nhri6SSfVPhvZAX BKVn8CJow34wkoHjFJHduXvkhV/PDu3J7VmxkAlwF6BKumyewXpjqhmyUXEF9PN2QX hTs27/7dTsg/0jObPEA4IlJay+eEzaGUcPHjLpRaQL9CtQldM2/zEzi7hvxSXrlU4F DmuCz6Ru8GKsv8Tsyf69qvR3twi6gBCWNIgYbcDxJ4WmX6dKGHwwpir8EICIK5zxby TC4vmFTFM0+ag== Date: Sat, 28 Jun 2025 09:17:37 +0000 To: Eli Zaretskii From: Pip Cet Subject: Re: bug#78782: 31.0.50 ; remove eieio's *-list-p Message-ID: <874iw02pjl.fsf@protonmail.com> In-Reply-To: <86v7og6xdz.fsf@gnu.org> References: <87ecvnydp8.fsf@protonmail.com> <86v7og6xdz.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 75e80dcee172d9b1c61c84ba7832de53bc2584e8 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78782-done Cc: monnier@iro.umontreal.ca, 78782-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Eli Zaretskii" writes: >> Date: Fri, 13 Jun 2025 13:27:04 +0000 >> From: Pip Cet via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> This code in eieio-core.el: >> >> (lambda (obj) >> (:documentation >> (format >> "Test OBJ to see if it a list of objects which are a child= of type %s" >> cname)) >> (when (listp obj) >> (let ((ans t)) ;; nil is valid >> ;; Loop over all the elements of the input list, test >> ;; each to make sure it is a child of the desired object= class. >> (while (and obj ans) >> (setq ans (and (eieio-object-p (car obj)) >> (object-of-class-p (car obj) 'cname))) >> (setq obj (cdr obj))) >> ans)))) >> >> creates *-list-p, which then tests whether a list of objects are all >> descendants of class 'cname, a literal symbol. This works only if the >> class we're defining is called "cname", and no one noticed, so it's time >> to remove this obsolete function (obsoleted in 25.1). >> >> The code has been in place since: >> >> commit 2c47eaa18a4a3f7eb53ed826d8c5d018ac843586 >> AuthorDate: Tue May 18 17:13:37 2021 -0400 >> >> This would probably also make (defclass proper nil 'x) work, instead of >> redefining proper-list-p to be a different function. >> >> OK to do this on master? > > Fine by me, thanks. Done in: af68c6e8255: Remove eieio's ...-list-p predicate (bug#78782) I'd kept the bug open in case there would be any problems, but there weren't. Closing now. Pip ------------=_1751102283-21512-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jun 2025 13:27:34 +0000 Received: from localhost ([127.0.0.1]:44797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uQ4RS-0000hK-B1 for submit@debbugs.gnu.org; Fri, 13 Jun 2025 09:27:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46562) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uQ4RP-0000fc-HZ for submit@debbugs.gnu.org; Fri, 13 Jun 2025 09:27:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uQ4R9-0006GF-1i for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2025 09:27:16 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uQ4R6-0004EA-B5 for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2025 09:27:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1749821229; x=1750080429; bh=Gq6daXKDgxI34Knnlm2jWGrbgsFADvvYX7rnKPjHGyM=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=HsKU3FN4HOenihMyRaC2ZHHSI/IRznoiAG6Szk7W1fPC3hipuNZZeEusK3dJAwPvG lHr9OeQh20gZdgtJTVOqjncbTaXIxWXX2oL8DwtP/AmXeTWl1Ewc3mnMyaKsbrxyjT W7OGZMm2siArK49ZL42Drw7a8NaXDOpzpXanB/FZ5402n8NAMDo3F6ThZGZ86Ws8k2 l8gpyIXrajclVLI9TSkZUYxlDh0i8H925YiQCUXITdA/IZdcxKz4RNHwV5aPvJOaLk 2FMejxNnfHZxjYGuZ0RhugWOwgEcPccb+zDoMNtGYlaPVbPojQijI8y3QK1h7CEPum rIu0u1IZLwQmA== Date: Fri, 13 Jun 2025 13:27:04 +0000 To: bug-gnu-emacs@gnu.org, Stefan Monnier From: Pip Cet Subject: 31.0.50 ; remove eieio's *-list-p Message-ID: <87ecvnydp8.fsf@protonmail.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 04e9ea8cb96512501c3ba507e372cea5bf8b12fd MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=pipcet@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This code in eieio-core.el: (lambda (obj) (:documentation (format "Test OBJ to see if it a list of objects which are a child of= type %s" cname)) (when (listp obj) (let ((ans t)) ;; nil is valid ;; Loop over all the elements of the input list, test ;; each to make sure it is a child of the desired object cl= ass. (while (and obj ans) (setq ans (and (eieio-object-p (car obj)) (object-of-class-p (car obj) 'cname))) (setq obj (cdr obj))) ans)))) creates *-list-p, which then tests whether a list of objects are all descendants of class 'cname, a literal symbol. This works only if the class we're defining is called "cname", and no one noticed, so it's time to remove this obsolete function (obsoleted in 25.1). The code has been in place since: commit 2c47eaa18a4a3f7eb53ed826d8c5d018ac843586 AuthorDate: Tue May 18 17:13:37 2021 -0400 This would probably also make (defclass proper nil 'x) work, instead of redefining proper-list-p to be a different function. OK to do this on master? ------------=_1751102283-21512-1--