GNU bug report logs - #78737
sit-for behavior changes when byte-compiled

Previous Next

Full log

Message #56 received at 78737 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: dancol <at> dancol.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 78737 <at> debbugs.gnu.org, pipcet <at> protonmail.com
Subject: Re: bug#78737: sit-for behavior changes when byte-compiled
Date: Wed, 11 Jun 2025 16:23:40 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  pipcet <at> protonmail.com,
>   78737 <at> debbugs.gnu.org
> Date: Tue, 10 Jun 2025 13:23:29 -0400
> 
> > BTW: the problem isn't just with transient. It also manifests with
> > read-extended-command! It's a nasty race that, AFAICT, has been with us
> > since the 90s. I think defining read_char to translate quits to quit_char
> > solves the problem.
> 
> I like your way of thinking.  I'm not completely sure it will solve
> world hunger, and it may come with regressions, but it's worth a try.
> Given the pervasive impact, it might be best to have a global config var
> to enable/disable it (with some scary internal name) until we're
> confident that it's an improvement.

This code is used everywhere, and we have no one on board who knows it
(and its many quirks and platform-dependent subtleties) well enough.
It isn't an accident that we prefer not to make changes in it: each
time we made even small changes in this code we ended up with
regressions.  We don't have any decent test suite for the this part of
Emacs.  We don't even have an exhaustive list of
features/commands/operations to test in order to make sure some change
doesn't break them.  Notable corners that get frequently broken by
changes in this area: keyboard macros, Leim input methods, and
non-keyboard input events.

So yes, we definitely need such a knob, if we are seriously
considering to merge these changes.  Daniel, would you please add such
a knob?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.