GNU bug report logs - #78737
sit-for behavior changes when byte-compiled

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 78737 <at> debbugs.gnu.org, pipcet <at> protonmail.com, dancol <at> dancol.org, monnier <at> iro.umontreal.ca, owinebar <at> gmail.com
Subject: bug#78737: sit-for behavior changes when byte-compiled
Date: Sat, 14 Jun 2025 11:14:04 +0300

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Cc: Daniel Colascione <dancol <at> dancol.org>,  78737 <at> debbugs.gnu.org,  Eli
>  Zaretskii <eliz <at> gnu.org>,  Pip Cet <pipcet <at> protonmail.com>,  Lynn
>  Winebarger <owinebar <at> gmail.com>
> Date: Sat, 14 Jun 2025 05:43:41 +0200
> 
> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
> 
> >>> We already have something like that. :-) read-event already runs the
> >>> events it reads through special-event-map, right?
> >> Entirely unrelated, I just came across this because I searched for
> >> read-event. Let me just mention that read-event does not respect
> >> input-decode-map. This is a problem on ttys, see bug#75886.
> >
> > Currently the only "decoding" we have to turn the TTY input bytes into
> > events is limited to the keyboard-coding-system thingy.  🙁
> >
> > Maybe I should have implemented `input-decode-map` directly inside
> > `read-event`, but I think it goes contrary to the design.
> >
> > It's usually better to change the users to use a higher-level function
> > instead, such as `read-key`.
> >
> > Admittedly, if you want to recognize a quit event encoded as an escape
> > sequence, that's not going to help you because we need/want those events
> > to be decoded at as-low a level as we can. 🙁
> 
> I'd deprecate read-event TBH.

If we want to do this, we should start by removing it from our own
sources.  Currently, we use it in around 80 places.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.