GNU bug report logs - #78730
31.0.50; Some eglot test failures

Previous Next

Package: emacs;

Reported by: Michael Albinus <michael.albinus <at> gmx.de>

Date: Mon, 9 Jun 2025 07:58:01 UTC

Severity: normal

Found in version 31.0.50

Full log


Message #14 received at 78730 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: João Távora <joaotavora <at> gmail.com>
Cc: 78730 <at> debbugs.gnu.org
Subject: Re: bug#78730: 31.0.50; Some eglot test failures
Date: Mon, 09 Jun 2025 12:30:35 +0200
[Message part 1 (text/plain, inline)]
Michael Albinus <michael.albinus <at> gmx.de> writes:

Hi João,

> (skip-when (getenv "EMACS_EMBA_CI")) shall do. However, not all eglot
> tests fail due to a timeout.

What about this?

[Message part 2 (text/x-patch, inline)]
diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el
index 2b6e09a4d16..2b98da4134b 100644
--- a/test/lisp/progmodes/eglot-tests.el
+++ b/test/lisp/progmodes/eglot-tests.el
@@ -185,7 +185,9 @@ eglot--call-with-timeout
                 (funcall fn)))
       (cancel-timer timer)
       (when (eq retval timed-out)
-        (error "%s" (concat "Timed out " message))))))
+        (if (getenv "EMACS_EMBA_CI")
+            (ert-skip (concat "Timed out " message))
+          (error "%s" (concat "Timed out " message)))))))
 
 (defun eglot--find-file-noselect (file &optional noerror)
   (unless (or noerror
[Message part 3 (text/plain, inline)]
>> João

Best regards, Michael.

This bug report was last modified 61 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.