From unknown Mon Jun 16 23:47:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78681 <78681@debbugs.gnu.org> To: bug#78681 <78681@debbugs.gnu.org> Subject: Status: [PATCH] correct parameter parsing in test-driver script Reply-To: bug#78681 <78681@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:47:35 +0000 retitle 78681 [PATCH] correct parameter parsing in test-driver script reassign 78681 automake-patches submitter 78681 Christoph Gr=C3=BCninger severity 78681 normal tag 78681 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 03 12:41:52 2025 Received: (at submit) by debbugs.gnu.org; 3 Jun 2025 16:41:52 +0000 Received: from localhost ([127.0.0.1]:40752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMUhz-0000UH-0e for submit@debbugs.gnu.org; Tue, 03 Jun 2025 12:41:51 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41568) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMRfy-0005Ej-1i for submit@debbugs.gnu.org; Tue, 03 Jun 2025 09:27:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMRfh-0002oi-0x for automake-patches@gnu.org; Tue, 03 Jun 2025 09:27:17 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.218]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMRfZ-0000kL-Sz for automake-patches@gnu.org; Tue, 03 Jun 2025 09:27:14 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1748957223; cv=none; d=strato.com; s=strato-dkim-0002; b=UCJ2r95TzR+0k8iKxr2SRiBKXhfWlA1XotrG/u/pwbzfMPcQFxLWLKj8u1fpEQ+Lec oyByYz963bMxVSsdYrnN8NQQrEb5El4EiHL9Sat9W0R5ELvYoG6PQPsSZX/kgvsZ2kVC p41d3GCsjbyWGKPR2Cn+fguWGuCuLB72MnsOolLB/Z4lWp/dcoFmH2qlePSPB0TuzUlW VS7UdmlgWP44pvZP71SVjeAUhSPFThYWb4I+VDOrv9XfzLOWpH2AFre1/acDumKkXUFm 8zYHpr7hSVYDQiWTitPbBmyCrImRpNb2JwlqDEonWBZYJ413HQdepyv5L/cMGsNTr5Bc Z0YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1748957223; s=strato-dkim-0002; d=strato.com; h=Subject:From:To:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=tQ+5F93kl9o90akx/dAw1QsKBz1wDq4fMww4TeQoZMc=; b=lhbND7SdI9I4czmBzKu9uefcV+WIh9x5hFCG9XNoY9WkfXQnVwKatOfdZX9kGGLiDP 7+PQPMJ/RSJBFAkU2qz8s5SX3L9Iq+FGz/RxfjGA5s4M68slzWXX4g5l9RrA5dqr2SaO kTF47NVoN4wUm09MrfAPs725P9yf3KcWBfUifW+PhQESj9VGEY+HvdHzS2FdseFqWrBi ksWuh2ro/+AFf9p6ErJAHNm9hsAxoznyw8wE3fWX4x5uar/u0waeJwr8g1ffU+3Gl7f5 A9bFewfWc8R3kMNL4ZJUvyplmI+iAjiGOuu3Qcb3yR2/uVV6fzL1Qu1MBoj5yWMAprQg 2H4A== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1748957223; s=strato-dkim-0002; d=grueninger.de; h=Subject:From:To:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=tQ+5F93kl9o90akx/dAw1QsKBz1wDq4fMww4TeQoZMc=; b=hIYHuT4nQoYQSUvhodVK4uDy6zPB7B2MUg75JAS0jeQ0v7yHlOBl+/SY2jH/b9n7Ly cjUNZ74sF8ZD1n4Jik6XGGwgCAv1DN2IkdmtTUkypmDG8M7Wuj8dyaUc9wS/MAPyZDZX X0zfdqTkfMKCIw3pdggNkcRsp9Q64yhG7aOI8/asJ0NrzKChQhX/qLOEMbfS2B0mtjK7 F33mxCyjbNW7Mt9aJaLib/fpjd6EigbERg1ouN79w58mQBNmnYTcxcahQkEv6Upa1hmf 90ffWtpZH7+rzem4ZZlLmUhFe6oDpQJeIUBFcRMYlTtUx4IETEVHcGpe7OG0TKKT6lea DTrg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1748957223; s=strato-dkim-0003; d=grueninger.de; h=Subject:From:To:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=tQ+5F93kl9o90akx/dAw1QsKBz1wDq4fMww4TeQoZMc=; b=XPL8Y5Gow/sPMqIN4VEg0/TDrdRlBPccS8z9HvWL4wrVb5PKcEKkGydcSKPzxkaXv5 uLkVGjWYQF+t7tF4tmDQ== X-RZG-AUTH: ":KmMXZmCvaeohc7VigFhGhYQlaG+8Y2WlGQK9xTU69ffPMhoFOSeiO+VI+ciLbDw8LCcxVLBp11XiTYyxhz+M3aTm7Pi+w1/2+h0=" Received: from [IPV6:2001:9e8:a09a:9100:96e6:f7ff:fed5:1fce] by smtp.strato.de (RZmta 51.3.0 AUTH) with ESMTPSA id I294d4153DR2Kms (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Tue, 3 Jun 2025 15:27:02 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------RaPnxG5Uvwuos4RwNXX9kqxd" Message-ID: Date: Tue, 3 Jun 2025 15:27:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: automake-patches@gnu.org Content-Language: de-DE, en-US From: =?UTF-8?Q?Christoph_Gr=C3=BCninger?= Subject: [PATCH] correct parameter parsing in test-driver script Content-Transfer-Encoding: 7bit Received-SPF: none client-ip=81.169.146.218; envelope-from=foss@grueninger.de; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 03 Jun 2025 12:41:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------RaPnxG5Uvwuos4RwNXX9kqxd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit While updating the openSuse package to Automake 1.18, I stumbled across the attached patch. I got permission from the author to upstream it. Are you interested? Bye Christoph -- Most customers will not accept source code with compile errors in it. Dan Saks, CppCon 2016 (https://youtu.be/D7Sd8A6_fYU) --------------RaPnxG5Uvwuos4RwNXX9kqxd Content-Type: text/x-patch; charset=UTF-8; name="0001-correct-parameter-parsing-in-test-driver-script.patch" Content-Disposition: attachment; filename*0="0001-correct-parameter-parsing-in-test-driver-script.patch" Content-Transfer-Encoding: base64 RnJvbSBiYTExNzIxNTRkYTY3MzlmOWJmOWUxMWM5M2YyYWJiYjkwYTIyNmFjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgQmx1bWUgPFRob21hcy5CbHVtZUBzdXNl LmNvbT4KRGF0ZTogVHVlLCAxNCBKdW4gMjAxNiAxNDo0NTo0MiArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIGNvcnJlY3QgcGFyYW1ldGVyIHBhcnNpbmcgaW4gdGVzdC1kcml2ZXIgc2NyaXB0 CgpUaGUgaGVscCB0ZXh0IHN1Z2dlc3QgdXNpbmcgYW4gZXF1YWwgc2lnbiBmb3IgYXNzaWdu aW5nIHBhcmFtZXRlciB2YWx1ZXMKYnV0IHRoZSBjb2RlIG9ubHkgc3VwcG9ydHMgc3BhY2Vz LgpUaGUgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBib3RoLgotLS0KIGxpYi90ZXN0LWRyaXZl ciB8IDI3ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE2 IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKSW5kZXg6IGF1dG9tYWtlLTEuMTYu My9saWIvdGVzdC1kcml2ZXIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gYXV0b21ha2UtMS4xNi4zLm9y aWcvbGliL3Rlc3QtZHJpdmVyCisrKyBhdXRvbWFrZS0xLjE2LjMvbGliL3Rlc3QtZHJpdmVy CkBAIC02NCwyMiArNjQsMjcgQEAgZXhwZWN0X2ZhaWx1cmU9bm8KIGNvbG9yX3Rlc3RzPW5v CiBjb2xsZWN0X3NraXBwZWRfbG9ncz15ZXMKIGVuYWJsZV9oYXJkX2Vycm9ycz15ZXMKLXdo aWxlIHRlc3QgJCMgLWd0IDA7IGRvCi0gIGNhc2UgJDEgaW4KK3doaWxlIHRlc3QgJCMgLWd0 IDE7IGRvCisgYXJnPSR7MSU9Kn0KKyB2YWw9JHsxIyo9fQorIGlmIFsgJGFyZyA9ICR2YWwg XTsgdGhlbgorICAgdmFsPSQyCisgICBzaGlmdAorIGZpCisgY2FzZSAkYXJnIGluCiAgIC0t aGVscCkgcHJpbnRfdXNhZ2U7IGV4aXQgJD87OwogICAtLXZlcnNpb24pIGVjaG8gInRlc3Qt ZHJpdmVyIChHTlUgQXV0b21ha2UpICRzY3JpcHR2ZXJzaW9uIjsgZXhpdCAkPzs7Ci0gIC0t dGVzdC1uYW1lKSB0ZXN0X25hbWU9JDI7IHNoaWZ0OzsKLSAgLS1sb2ctZmlsZSkgbG9nX2Zp bGU9JDI7IHNoaWZ0OzsKLSAgLS10cnMtZmlsZSkgdHJzX2ZpbGU9JDI7IHNoaWZ0OzsKLSAg LS1jb2xvci10ZXN0cykgY29sb3JfdGVzdHM9JDI7IHNoaWZ0OzsKLSAgLS1jb2xsZWN0LXNr aXBwZWQtbG9ncykgY29sbGVjdF9za2lwcGVkX2xvZ3M9JDI7IHNoaWZ0OzsKLSAgLS1leHBl Y3QtZmFpbHVyZSkgZXhwZWN0X2ZhaWx1cmU9JDI7IHNoaWZ0OzsKLSAgLS1lbmFibGUtaGFy ZC1lcnJvcnMpIGVuYWJsZV9oYXJkX2Vycm9ycz0kMjsgc2hpZnQ7OwotICAtLSkgc2hpZnQ7 IGJyZWFrOzsKKyAgLS10ZXN0LW5hbWUpIHRlc3RfbmFtZT0kdmFsOzsKKyAgLS1sb2ctZmls ZSkgbG9nX2ZpbGU9JHZhbDs7CisgIC0tdHJzLWZpbGUpIHRyc19maWxlPSR2YWw7OworICAt LWNvbG9yLXRlc3RzKSBjb2xvcl90ZXN0cz0kdmFsOzsKKyAgLS1jb2xsZWN0LXNraXBwZWQt bG9ncykgY29sbGVjdF9za2lwcGVkX2xvZ3M9JHZhbDs7CisgIC0tZXhwZWN0LWZhaWx1cmUp IGV4cGVjdF9mYWlsdXJlPSR2YWw7OworICAtLWVuYWJsZS1oYXJkLWVycm9ycykgZW5hYmxl X2hhcmRfZXJyb3JzPSR2YWw7OworICAtLSkgYnJlYWs7OwogICAtKikgdXNhZ2VfZXJyb3Ig ImludmFsaWQgb3B0aW9uOiAnJDEnIjs7Ci0gICAqKSBicmVhazs7CiAgIGVzYWMKLSAgc2hp ZnQKKyAgWyAkYXJnICE9ICR2YWwgXSAmJiBzaGlmdAogZG9uZQogCiBtaXNzaW5nX29wdHM9 Cg== --------------RaPnxG5Uvwuos4RwNXX9kqxd-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 03 16:14:43 2025 Received: (at 78681) by debbugs.gnu.org; 3 Jun 2025 20:14:44 +0000 Received: from localhost ([127.0.0.1]:41944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMY1t-00061b-Ql for submit@debbugs.gnu.org; Tue, 03 Jun 2025 16:14:43 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:34046 helo=freefriends.org) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMY1k-00060E-Lu; Tue, 03 Jun 2025 16:14:31 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.16.1/8.16.1) with ESMTPS id 553KEPD3255083 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 3 Jun 2025 14:14:26 -0600 Received: (from apache@localhost) by freefriends.org (8.16.1/8.14.7/Submit) id 553KEPfO255082; Tue, 3 Jun 2025 14:14:25 -0600 Date: Tue, 3 Jun 2025 14:14:25 -0600 Message-Id: <202506032014.553KEPfO255082@freefriends.org> From: Karl Berry To: foss@grueninger.de Subject: Re: [bug#78681] [PATCH] correct parameter parsing in test-driver script In-Reply-To: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78681 Cc: 78681@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Christoph, While updating the openSuse package to Automake 1.18, I stumbled across the attached patch. I got permission from the author to upstream it. Are you interested? Thanks, but no. This was fixed in 1.17, by replacing the use of = in the help text and doc with spaces. Since test-driver never supported = signs for parsing, no one could ever have used it that way. Main ChangeLog entry below for reference. Also, not that it matters given the above, but the patch uses various sh(ell) unportabilities. Closing ... --thanks, karl. 2024-05-21 Mark Wooding doc: test-driver option args are separate words. For https://bugs.gnu.org/70638. As now mentioned in the manual, the description of the test-driver command-line interface has been wrong since 2011 when it was first added. The manual, and the driver usage messages themselves, have consistently shown option arguments joined to the option name with `=' characters, while the implementation of Automake has always provided option arguments in the following argument word, and the provided test drivers only accepted option arguments in the following argument word. Because Automake has never used the `=' syntax, there can't possibly be a working driver which actually follows the specification as written, so, despite the fierce language of the manual, we agreed that changing the specification was the right approach. The `test-driver' program's usage message has already been fixed (#22445), but the full extent of the problem wasn't noticed at that time. * doc/automake.texi (Command-line arguments for test drivers): Fix the table of options to show arguments passed as separate words; add footnote explaining this rather sorry situation. * doc/automake.texi (Use TAP with the Automake test harness): Remove `=' from documentation of `--diagnostic-string', because that was never acceptable either. * lib/tap-driver.sh: Fix usage message. * contrib/tap-driver.pl: Change usage message to match the defined protocol. (This implementation parses options using Perl's `Getopt::Long' module, so it accepts the `=' syntax as specified, but this program isn't actually used.)