GNU bug report logs - #78673
outline-revert-buffer-restore-visibility modifies visibility

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78673: closed (outline-revert-buffer-restore-visibility
 modifies visibility)
Date: Wed, 04 Jun 2025 20:41:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 04 Jun 2025 16:40:36 -0400
with message-id <jwvsekfkzqn.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#78665: 31.0.50; Very slow saves
has caused the debbugs.gnu.org bug report #78673,
regarding outline-revert-buffer-restore-visibility modifies visibility
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78673: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78673
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: outline-revert-buffer-restore-visibility modifies visibility
Date: Mon, 02 Jun 2025 14:13:02 -0400

Package: Emacs
Version: 31.0.50


While playing in bug#78665 I noticed the following bug:

    src/emacs -Q lisp/transient.el -f outline-minor-mode
    M-: (hide-sublevels 1000) RET
    M-: (funcall (outline-revert-buffer-restore-visibility)) RET

Notice that after the first `M-:` all the definitions' first lines are
visible (and their bodies are hidden), whereas after the second `M-:`
only the `;;;` headings are visible and none of the actual code.
This seems to be due to the design of this save&restore code which
presumes that all the hiding is applied always to whole subtrees.


        Stefan

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> linkov.net>
Cc: 78673-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Jonas Bernoulli <jonas <at> bernoul.li>, 78665-done <at> debbugs.gnu.org
Subject: Re: bug#78665: 31.0.50; Very slow saves
Date: Wed, 04 Jun 2025 16:40:36 -0400

> I've completed testing your patch and found no problems.

Thanks, pushed to `master`,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.