From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Collin Funk Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2025 05:17:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 78659@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174875500724805 (code B ref -1); Sun, 01 Jun 2025 05:17:05 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jun 2025 05:16:47 +0000 Received: from localhost ([127.0.0.1]:35234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLb3m-0006R7-UY for submit@debbugs.gnu.org; Sun, 01 Jun 2025 01:16:46 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39540) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLb3g-0006PN-1T for submit@debbugs.gnu.org; Sun, 01 Jun 2025 01:16:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLb3Z-0002vK-A3 for bug-gnu-emacs@gnu.org; Sun, 01 Jun 2025 01:16:25 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uLb3U-0004Ti-0b for bug-gnu-emacs@gnu.org; Sun, 01 Jun 2025 01:16:25 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-742c7a52e97so2694341b3a.3 for ; Sat, 31 May 2025 22:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748754977; x=1749359777; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=1Knva0tKp0+TrwnMqt5rd5LgVRS0gyDUg3NDEeuiuq8=; b=jAaSw/oRSLxDjz+r8TwXX2LY9tCeLZ9AAzOqk6ZPuCBkA/2YmYe8PyDW08q9HRpjCb /fsKN1wOhNysJRi0rU2RXAZJxSWSaoV58U2+TAsN43SbrgUgT8XlZXR1eVRumov5cDP5 O+Qa3TuZpJH6t5mNCXfwvF9Jg1IbPVaPv8lb9cBDrxNt4OpIfMyzow16SQF2vq1vwf+W ncvyb5uPF6PBFqrJVCyVTbUmjlxUd6wGghWhilDP6enI37tvwwSJcTgVesn4kf6JJjjx GQsBY7O/tYyD0BegVnmj7z57zyl3CCQ4T+DB8XG0NRIb6LUtINY1Wr4MhQx2ocYPUchM AMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748754977; x=1749359777; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Knva0tKp0+TrwnMqt5rd5LgVRS0gyDUg3NDEeuiuq8=; b=MWdV9xmuyzwaw0QO+Z5BVbrO/0BjsuapxrLuIWNqrcySgnC840/L7N1sWh7IH5s568 NxJUzf+gTtWOQirrSgxoMrop1uPHqpJnlTIWEaL7XwnQFpmzVYjDGzcU5lTooINEfElx qD9hP0HxBsPdWzB5iakfxvh/S5vodvGbnBB3mLmDN7v7c98J6U5ukpRqlrW6r4HoBa1v U9U0isBHIWH6yM676s50R57KEV9JZhSWXz2W1v7zr3ZeoW7oWmeW4iobLqd8xx0FlCmr hGvV3kXUCLwxDyAzEu7siy/SZSPvOFQ193gvdJoGuvoHTSbr3IHe6X8BUrOEuh6M3CBY ztlw== X-Gm-Message-State: AOJu0Yyn6a1/YSJAz7KVwAmd4M7bD/L2p2XNc9wXS0sOpcbCOahowJ1m sXmQkF8lYQNx4nvWnvCTnmgzrAL9cGYUx88zWE641dovjQ8/jo/v7eGzsIPXYw== X-Gm-Gg: ASbGncvrMoqxGZnJQrU72o2poniQUDPaAFJrC416t3hJ3pCX4ovjxoO6ihVOkeVDURp Z/kxb4QasSjHi8Q8YNXG6u+ZSWtYONG86KPWUeHtSL/9mX0TRoc+0Rx2CVxWiurrmNy71wkAHUW CtbMlnX1mJL+oVXsi9d7K6j+8wxGvB18lb/4oKxS8CGMF5x3qRqd6jaLUkaBGsPQMMA9b4ckoUI 4zV4yzGd3w5LGrDQ/P86oTnIcYB4V9HLOnslAeA4FF4aZRqv9zxz1igX5mmTBaxsIyFA5CE7/6y Wt+VcL/3jSH84U/6aISpOJpzVpa2Lzil X-Google-Smtp-Source: AGHT+IFZr2cFnuXkCaGmu3Q3srI2mUyE7BraxnJChdrGYVa3C6tqZzZr7AiTUEzFgAjA2tuSRQxm9g== X-Received: by 2002:a05:6a20:144f:b0:215:dc32:ffac with SMTP id adf61e73a8af0-21ae00836eamr10963849637.26.1748754977173; Sat, 31 May 2025 22:16:17 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::eef5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747afe96451sm5610842b3a.13.2025.05.31.22.16.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 May 2025 22:16:16 -0700 (PDT) From: Collin Funk Date: Sat, 31 May 2025 22:16:15 -0700 Message-ID: <874ix059eo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=collin.funk1@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, When compiling with './autogen.sh && ./configure CC=clang && make': [...] xfns.c:2041:6: warning: format specifies type 'unsigned int' but the argument has type 'int' [-Wformat] 2040 | sprintf (css, "scrollbar slider { background-color: #%02x%02x%02x; }", | ~~~~ | %0 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (collin.funk1[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (collin.funk1[at]gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain Hi, When compiling with './autogen.sh && ./configure CC=clang && make': [...] xfns.c:2041:6: warning: format specifies type 'unsigned int' but the argument has type 'int' [-Wformat] 2040 | sprintf (css, "scrollbar slider { background-color: #%02x%02x%02x; }", | ~~~~ | %02x 2041 | color.red >> 8, color.green >> 8, color.blue >> 8); [...] This warning is harmless, but interestingly 'gcc -Wformat-signedness' does not warn about it, but 'clang -Wformat-signedness' does. Since the color fields of struct XColor are 'unsigned short' and the constant is an 'int', the expression should be an 'int'. Anyways, the attached patch silences the warnings. Collin --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Pacify-Clang-s-Wformat-signedness.patch >From 1c34ded32a2826d009ee531c1f0d695b8144b39d Mon Sep 17 00:00:00 2001 Message-ID: <1c34ded32a2826d009ee531c1f0d695b8144b39d.1748754583.git.collin.funk1@gmail.com> From: Collin Funk Date: Sat, 31 May 2025 21:54:54 -0700 Subject: [PATCH] Pacify Clang's -Wformat-signedness. * src/gtkutil.c (xg_set_widget_bg): Cast the expression passed to the "%x" specifier to unsigned int. * src/xfns.c (x_set_scroll_bar_foreground, x_set_scroll_bar_background): Likewise. --- src/gtkutil.c | 3 ++- src/xfns.c | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gtkutil.c b/src/gtkutil.c index c192102730c..c8b0943fb2f 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -1434,7 +1434,8 @@ xg_set_widget_bg (struct frame *f, GtkWidget *w, unsigned long pixel) { static char const format[] = "* { background-color: #%02x%02x%02x; }"; char buffer[sizeof format + 3 * INT_STRLEN_BOUND (xbg.red)]; - sprintf (buffer, format, xbg.red >> 8, xbg.green >> 8, xbg.blue >> 8); + sprintf (buffer, format, (unsigned int) xbg.red >> 8, + (unsigned int) xbg.green >> 8, (unsigned int) xbg.blue >> 8); GtkCssProvider *provider = gtk_css_provider_new (); gtk_css_provider_load_from_data (provider, buffer, -1, NULL); gtk_style_context_add_provider (gtk_widget_get_style_context(w), diff --git a/src/xfns.c b/src/xfns.c index 4f7be935000..5f0cb0e16a9 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -2038,7 +2038,9 @@ x_set_scroll_bar_foreground (struct frame *f, Lisp_Object value, Lisp_Object old &color); sprintf (css, "scrollbar slider { background-color: #%02x%02x%02x; }", - color.red >> 8, color.green >> 8, color.blue >> 8); + (unsigned int) color.red >> 8, + (unsigned int) color.green >> 8, + (unsigned int) color.blue >> 8); gtk_css_provider_load_from_data (FRAME_X_OUTPUT (f)->scrollbar_foreground_css_provider, css, -1, NULL); } @@ -2111,7 +2113,9 @@ x_set_scroll_bar_background (struct frame *f, Lisp_Object value, Lisp_Object old &color); sprintf (css, "scrollbar trough { background-color: #%02x%02x%02x; }", - color.red >> 8, color.green >> 8, color.blue >> 8); + (unsigned int) color.red >> 8, + (unsigned int) color.green >> 8, + (unsigned int) color.blue >> 8); gtk_css_provider_load_from_data (FRAME_X_OUTPUT (f)->scrollbar_background_css_provider, css, -1, NULL); } -- 2.49.0 --=-=-=-- From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2025 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Collin Funk , Paul Eggert Cc: 78659@debbugs.gnu.org Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.174875906122444 (code B ref 78659); Sun, 01 Jun 2025 06:25:02 +0000 Received: (at 78659) by debbugs.gnu.org; 1 Jun 2025 06:24:21 +0000 Received: from localhost ([127.0.0.1]:35719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLc7I-0005pu-85 for submit@debbugs.gnu.org; Sun, 01 Jun 2025 02:24:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39234) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLc7F-0005pM-7w for 78659@debbugs.gnu.org; Sun, 01 Jun 2025 02:24:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLc77-0001zm-Tg; Sun, 01 Jun 2025 02:24:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fv1qNevYSbWGTFb+ER+mRAC7q5Zf63TZoZAGR7ZZkzA=; b=REL5kYvUhIcX 2NbiZFkx4D8OVqfx/V1Ug+5uTLk7M08v/SN/ojSSYxFguLGJvnqCb1A0JRSe5LoYOpz5824yafed/ GqTV/4qQPl/NI6vt8ysXl0BzFcJeKBWJqlLxx4tci3E+/a3RcohofxbkjY/ARf/WY9Y6YGBV06zde nFd7ACfI+nD8khogWKPT9v58B8b2t1c/f8kZIRSQ5ngs2aEHOYP2FcRssfBokQAn4iSl/+qTN9git vpulTWCR1t+ddhHVJWsb6SjTj6rJJwBhDMiAmA7jEQt6gJwV6RIStCz3OIv5ZfvzI+rj0f3MHeX27 KLY11oKz6z2Po7+gYPMdZw==; Date: Sun, 01 Jun 2025 09:24:07 +0300 Message-Id: <868qmcq8s8.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <874ix059eo.fsf@gmail.com> (message from Collin Funk on Sat, 31 May 2025 22:16:15 -0700) References: <874ix059eo.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Collin Funk > Date: Sat, 31 May 2025 22:16:15 -0700 > > When compiling with './autogen.sh && ./configure CC=clang && make': > > [...] > xfns.c:2041:6: warning: format specifies type 'unsigned int' but the argument has type 'int' [-Wformat] > 2040 | sprintf (css, "scrollbar slider { background-color: #%02x%02x%02x; }", > | ~~~~ > | %02x > 2041 | color.red >> 8, color.green >> 8, color.blue >> 8); > [...] > > This warning is harmless, but interestingly 'gcc -Wformat-signedness' > does not warn about it, but 'clang -Wformat-signedness' does. > > Since the color fields of struct XColor are 'unsigned short' and the > constant is an 'int', the expression should be an 'int'. > > Anyways, the attached patch silences the warnings. Thanks. Paul, any comments or suggestions? From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2025 06:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Collin Funk Cc: 78659@debbugs.gnu.org Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.17487604462668 (code B ref 78659); Sun, 01 Jun 2025 06:48:02 +0000 Received: (at 78659) by debbugs.gnu.org; 1 Jun 2025 06:47:26 +0000 Received: from localhost ([127.0.0.1]:35856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLcTc-0000go-Uu for submit@debbugs.gnu.org; Sun, 01 Jun 2025 02:47:25 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:51022) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLcTa-0000fN-4M for 78659@debbugs.gnu.org; Sun, 01 Jun 2025 02:47:23 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id F088D3C0149EE; Sat, 31 May 2025 23:47:15 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id T7RUuBCB2Mx6; Sat, 31 May 2025 23:47:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id C937A3C0149EF; Sat, 31 May 2025 23:47:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu C937A3C0149EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1748760435; bh=PBxe7KJZkvhicOpYr3SB4bCq3IMBiZZ056PJ3fV11dA=; h=Message-ID:Date:MIME-Version:To:From; b=SHelPUTJRR/v43m7z2zjfxYOL7ZLoKhOc8IFeC7WqwRmlfB/HvjISWvMjHwssMJWM CkZgvX9/vN3lii3kKXP4hwhVeRJxXad6zJqgVksEukr21eWGrzyCAykyNEJGOrRY2v HfoipkLdF6Eaf6hSWKw3dk4nwEFKUoysYisscI0/ZjmoebYb3s+EQPsg/Dxsw/TZGL xaNE9ccVnxp+tvDkLCma49lwz/tRImX+T/t5lBwbl8taeUx/NfHp1+DgbHl5G+O5nF RmA2JnpT+AR9aXGu3pZHZrh8hLi0hVLvt5g/yrGikSBLZC6Z1vi8lYFOTj53XMfAYe YC8wtaoon+jQA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id vJWTWph5dYiV; Sat, 31 May 2025 23:47:15 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-143-215-226.fdr01.snmn.ca.ip.frontiernet.net [47.143.215.226]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id A5D413C0149EE; Sat, 31 May 2025 23:47:15 -0700 (PDT) Message-ID: <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> Date: Sat, 31 May 2025 23:47:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <868qmcq8s8.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-05-31 23:24, Eli Zaretskii wrote: > Paul, any comments or suggestions? As a general rule of thumb, I wouldn't bother pacifying anything but the latest GCC, especially to work around false alarms (which these are). Since this is isn't the latest GCC and these are false alarms, I suggest ignoring the false alarms, or silencing them by using ./configure --disable-gcc-warnings. Come to think of it, when building from Git maybe 'configure' should make --enable-gcc-warnings the default only when using recent GCC. Currently it also defaults to --enable-gcc-warnings with Clang or with older GCC, but that's probably more trouble than it's worth. From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2025 07:30:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 78659@debbugs.gnu.org, collin.funk1@gmail.com Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.174876299022549 (code B ref 78659); Sun, 01 Jun 2025 07:30:06 +0000 Received: (at 78659) by debbugs.gnu.org; 1 Jun 2025 07:29:50 +0000 Received: from localhost ([127.0.0.1]:36118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLd8c-0005rH-W5 for submit@debbugs.gnu.org; Sun, 01 Jun 2025 03:29:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38998) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLd8X-0005pg-Pl for 78659@debbugs.gnu.org; Sun, 01 Jun 2025 03:29:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLd8R-0007i1-Kh; Sun, 01 Jun 2025 03:29:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7qa5H9FKIyRV2Zo1tthQlHAf00wvVGw2/CWpAEan12g=; b=Yl3Ma2nVIrUg Bp9MVhCiExP8cNc46BoatSyXpyOSsY90I72PzFHsvPaEjuG/AMlY0NDk9ymFZW0EWxyT0a9d2wAYk Os3JDPaqfIxMFtNRv+AbHDuYa4eAnW7X9lWZddJJRv3zFvTPGVqZcYo8FpT/VWQLdg2q9Y5H/jav8 EUvbsMQVyHG/2UxgIce5I5T8/SjKnLCPe5WEpT++9XyW7x5vHXB1GU00sWHKMJ+vp94G/CVL0GMNm XFZpyS59EdAccYOBqlFb5Vx99RBIeDH8SOvqql8kzyPbNDko5AN0+qQPtYMhjZWQD/197d04hev2u 9tP8DDDHHvQVtXME0cH+nw==; Date: Sun, 01 Jun 2025 10:29:33 +0300 Message-Id: <867c1vrkbm.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> (message from Paul Eggert on Sat, 31 May 2025 23:47:15 -0700) References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 31 May 2025 23:47:15 -0700 > Cc: 78659@debbugs.gnu.org > From: Paul Eggert > > On 2025-05-31 23:24, Eli Zaretskii wrote: > > Paul, any comments or suggestions? > > As a general rule of thumb, I wouldn't bother pacifying anything but the > latest GCC, especially to work around false alarms (which these are). > Since this is isn't the latest GCC and these are false alarms, I suggest > ignoring the false alarms, or silencing them by using ./configure > --disable-gcc-warnings. Agreed. > Come to think of it, when building from Git maybe 'configure' should > make --enable-gcc-warnings the default only when using recent GCC. I tend to agree, but isn't the latest GCC prone to bugs in this area? And how can we know what is "recent GCC"? From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Collin Funk Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jun 2025 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Paul Eggert , 78659@debbugs.gnu.org Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.17488262844473 (code B ref 78659); Mon, 02 Jun 2025 01:05:02 +0000 Received: (at 78659) by debbugs.gnu.org; 2 Jun 2025 01:04:44 +0000 Received: from localhost ([127.0.0.1]:44094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLtbX-0001A5-GK for submit@debbugs.gnu.org; Sun, 01 Jun 2025 21:04:43 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:54659) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uLtbU-00019X-UG for 78659@debbugs.gnu.org; Sun, 01 Jun 2025 21:04:42 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-742c46611b6so4579951b3a.1 for <78659@debbugs.gnu.org>; Sun, 01 Jun 2025 18:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748826274; x=1749431074; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=M5UcMGkQvcMp0Wd6mhnNigBs4u482wsvyJoUxLCcro0=; b=Hz46QXzb8iu58TWqx76Qr41kd2EdCJAfk5NdK3G5btJnlG2WTFmlLHh+80n+y34MlK So4tXinTLvxgsEz6mSxn8WK1Nn1aPW3ZRw3a4cqcs4mVViKOY4OeOvrdRtGgCsC/y2P2 YTLqt9m/6mAxvKuSqijusUpVE0Q9ouXv7fep4KoHfunEcRogqNWSNV1OyGcKcVBWVHsH IuR+ydzLougTqGt167dRRZfOTvafXwEtSbgqgQd66xx3Yy7qbfuJSXJT1ImSbShyiLy8 EgD2bL3cZ08PI7V1JwVUtkDA6Sh83VNvDcqpZt+Y5O6vD/XQQ5DsYRnGNSqsyg8yKRGJ 1+ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748826274; x=1749431074; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M5UcMGkQvcMp0Wd6mhnNigBs4u482wsvyJoUxLCcro0=; b=gctRa3JcFrUo6bBVLDmSv1CHTPRMyGV695PhBnZrXDqIHzhabdH7EqM0lfmYcglumo Cg1XjGWCX9EC9hpupzw8rHFsY5LoJWUA/LmJ/D7GdA2D1pJxEGIW704EU8wZf2mmhnWm /2f505GkUfjDbVMZm3bRXNMXWTCuPonAUX2Sqjjy4caxPgEE2pB0sNmFzS9IgmXL8dST ksGOLI58/F8IPEm7UMWQhoieb9KQ8/4uuPfaokdYMG+N6QZhs/cuCOw7PLp0WwIbUPck kPCZIx9voWruxcawRBLCggfrgR0BEjo5ugSXda1SZmVFX+evMtqdjK/nZL7UNBTAtXKD xoDg== X-Forwarded-Encrypted: i=1; AJvYcCXhHhbH7qW4i0DxEcGDMETKZ7QDwol6ZeHyYxkP+9IiqKkKqq5Ek9rq3Vmu8PEEmATT0rkGAg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yys1YQbiS2JQdAvNLAboZGG9CBUjjmhVLV9//WAhyHzaSI20Qnz XRtwcuDmv8FFvp0N+QnBx+iMb8dvYxHmnWBlx4JbZovdV6tZpbuDPqvpBH8cWQ== X-Gm-Gg: ASbGncv46yf1aaBI8D46VAhFLyTrJbd55biKvjvsi7AoFuFGSgnm/xjFV93SDDvMsnA XfvbHtu2duD2hmC1vEMzxkhtjtYSWdzGNMc/bV55UAxhltYsPqtYrTwpjfZVCZqzSiJ2YxoWfG8 y4HNlhb8bjiB8h5q9NjyngqaZ3F07eMoPx8ziSuZxRkgqaAjtRKzZnc7ibPiyy0CNS1SLEV0x5c vT5aZyTy45CZ7AxkonbUFW/3SYuCWo3t1OSrTO/FpmROIka8Ff9st9nDDe8OUBeMRHO+VgU5B3b OOb7id84tOicVG2kjFlZO2xl6I1IZKwhgPKGfHsZlLQ= X-Google-Smtp-Source: AGHT+IGjfdnhwpmjncWrOuwYsePex5Jd0WLiRr9G2FVaeKmlp154VmvSgo1mWovwIZ85QstPJ0km7w== X-Received: by 2002:a05:6a00:3a1c:b0:747:aa79:e2f5 with SMTP id d2e1a72fcca58-747c18dd897mr14473604b3a.0.1748826274504; Sun, 01 Jun 2025 18:04:34 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::eef5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747affcf6f8sm6697955b3a.139.2025.06.01.18.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Jun 2025 18:04:33 -0700 (PDT) From: Collin Funk In-Reply-To: <867c1vrkbm.fsf@gnu.org> References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> <867c1vrkbm.fsf@gnu.org> Date: Sun, 01 Jun 2025 18:04:32 -0700 Message-ID: <87plfn6jj3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Hi Eli and Paul, Eli Zaretskii writes: >> Date: Sat, 31 May 2025 23:47:15 -0700 >> Cc: 78659@debbugs.gnu.org >> From: Paul Eggert >> >> On 2025-05-31 23:24, Eli Zaretskii wrote: >> > Paul, any comments or suggestions? >> >> As a general rule of thumb, I wouldn't bother pacifying anything but the >> latest GCC, especially to work around false alarms (which these are). >> Since this is isn't the latest GCC and these are false alarms, I suggest >> ignoring the false alarms, or silencing them by using ./configure >> --disable-gcc-warnings. > > Agreed. How about just disabling this warning if Clang is being used like we do for many others? Simple 1 line patch attached. Collin --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v2-0001-Pacify-Clang-s-Wformat-signedness.patch >From 8f482d6d176df05b642319bfc6c805c0d3e898cb Mon Sep 17 00:00:00 2001 Message-ID: <8f482d6d176df05b642319bfc6c805c0d3e898cb.1748826177.git.collin.funk1@gmail.com> From: Collin Funk Date: Sun, 1 Jun 2025 18:01:33 -0700 Subject: [PATCH v2] Pacify Clang's -Wformat-signedness. * configure.ac: Enable -Wno-format-signedness if Clang is being used. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index bafbb748149..d7c27dae734 100644 --- a/configure.ac +++ b/configure.ac @@ -1870,6 +1870,7 @@ AC_DEFUN # clang is unduly picky about some things. if test "$emacs_cv_clang" = yes; then gl_WARN_ADD([-Wno-bitwise-instead-of-logical]) + gl_WARN_ADD([-Wno-format-signedness]) gl_WARN_ADD([-Wno-missing-braces]) gl_WARN_ADD([-Wno-null-pointer-arithmetic]) gl_WARN_ADD([-Wno-implicit-const-int-float-conversion]) -- 2.49.0 --=-=-=-- From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jun 2025 07:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78659@debbugs.gnu.org, collin.funk1@gmail.com Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.174884919815015 (code B ref 78659); Mon, 02 Jun 2025 07:27:02 +0000 Received: (at 78659) by debbugs.gnu.org; 2 Jun 2025 07:26:38 +0000 Received: from localhost ([127.0.0.1]:47071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLzZ8-0003u4-Bu for submit@debbugs.gnu.org; Mon, 02 Jun 2025 03:26:38 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:43880) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLzZ6-0003td-KB for 78659@debbugs.gnu.org; Mon, 02 Jun 2025 03:26:36 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id BD7713C010858; Mon, 2 Jun 2025 00:26:30 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id Rt6ElxVNopYW; Mon, 2 Jun 2025 00:26:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 9449C3C0149E6; Mon, 2 Jun 2025 00:26:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 9449C3C0149E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1748849190; bh=HrwAwKVLiWgYbsHBwToyMxCYpZp24V1e8MVK42uXLLE=; h=Message-ID:Date:MIME-Version:To:From; b=ngV2EfTKVK+FT+N1yZLI7lXGeJUTnb7BlgUp2KxPUf4fCRlFCHabutePRTYpFp7EG DBHoyWeaEOp+o03sN04PT4q/ZYORXQEn/3mMaxjjny3o8Dt2wb3vr3aXl7CxjEMJcq bqKHmbgx8y16mS4BU7r7CEFiC7lHqFVuMo9YxrEMZdWVQAt4AqGLkZ+A3Pk0pbX7VQ 5UG8aKXZG+phHz3JFfeacmxjGiWhg8H5qDK4eARbf6lTV2hBPA3vZs1fQp3SYxWNze cdhWqIhbTf8NFKhSLFLpmiaWWGbVwXZ5VUkGr3dSEPrWJErDiNq5Y2UwuD4rchjLU/ +5158DNMlcLcA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id jT0u8Chvvvbp; Mon, 2 Jun 2025 00:26:30 -0700 (PDT) Received: from penguin.cs.ucla.edu (unknown [47.143.215.226]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 71BDD3C010858; Mon, 2 Jun 2025 00:26:30 -0700 (PDT) Message-ID: Date: Mon, 2 Jun 2025 00:26:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> <867c1vrkbm.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <867c1vrkbm.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-06-01 00:29, Eli Zaretskii wrote: > I tend to agree, but isn't the latest GCC prone to bugs in this area? Not that I know of. I usually build with it. > And how can we know what is "recent GCC"? I suggest worrying only about the most recent stable GCC release. Anything older than that is generally not worth worrying about, though there may be some exceptions in extremely annoying circumstances. After all, these warnings are meant only for developers who should be using recent GCC anyway. From unknown Sun Jun 15 08:57:56 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Collin Funk Subject: bug#78659: closed (Re: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness.) Message-ID: References: <70d89b66-b69a-4662-b73d-5abcf49ab12b@cs.ucla.edu> <874ix059eo.fsf@gmail.com> X-Gnu-PR-Message: they-closed 78659 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 78659@debbugs.gnu.org Date: Mon, 02 Jun 2025 07:28:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1748849282-15299-1" This is a multi-part message in MIME format... ------------=_1748849282-15299-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #78659: [PATCH] Pacify Clang's -Wformat-signedness. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 78659@debbugs.gnu.org. --=20 78659: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78659 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1748849282-15299-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 78659-done) by debbugs.gnu.org; 2 Jun 2025 07:27:40 +0000 Received: from localhost ([127.0.0.1]:47084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLza7-0003xd-Vo for submit@debbugs.gnu.org; Mon, 02 Jun 2025 03:27:40 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:60074) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLza5-0003xC-Oh for 78659-done@debbugs.gnu.org; Mon, 02 Jun 2025 03:27:38 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 2CBD13C010858; Mon, 2 Jun 2025 00:27:32 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id w85ju0NziNOG; Mon, 2 Jun 2025 00:27:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 071433C0149E6; Mon, 2 Jun 2025 00:27:32 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 071433C0149E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1748849252; bh=RBgEG6a9FpBM/HNxaMZslXuMS99O387LRpZ7WceuB84=; h=Message-ID:Date:MIME-Version:To:From; b=BSKGNXyWD69BnVIczMaa70GFqOr3Bs5NC+pMLslmLJRS0M8LV3lD1ULcN3Bdr/ULy I4BFNyu9rTbz3Jw2uHRxDf9PNqFsmp//OYudXoqrZ+W0zo3Q7JvAOHbMUFzzauFO/X 9bNWwmjUr/1AaKlVGmZPmwGUI2fpmVpWeEslBItNRaTWZiTC0d2YfEkF5yexj0WFZy NWjlEMW6QzUv96VwZ3o+gH25JzsUuTAX/ifIWefbEF3n7opQf7nfdfON/wIAyNKAHm SK/Qfy/NbNcjkDWn2H9HuhXUOi2wYaTwl9Iumvld+gAZ2S/WjWfqPCj4OWOgBwiTut kaoMjn1lSQslA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id 2RYDgrFXG-VI; Mon, 2 Jun 2025 00:27:31 -0700 (PDT) Received: from penguin.cs.ucla.edu (unknown [47.143.215.226]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id D75C83C010858; Mon, 2 Jun 2025 00:27:31 -0700 (PDT) Message-ID: <70d89b66-b69a-4662-b73d-5abcf49ab12b@cs.ucla.edu> Date: Mon, 2 Jun 2025 00:27:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. To: Collin Funk , Eli Zaretskii References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> <867c1vrkbm.fsf@gnu.org> <87plfn6jj3.fsf@gmail.com> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <87plfn6jj3.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78659-done Cc: 78659-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-06-01 18:04, Collin Funk wrote: > How about just disabling this warning if Clang is being used like we do > for many others? Thanks, I installed that. Closing the bug report. ------------=_1748849282-15299-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Jun 2025 05:16:47 +0000 Received: from localhost ([127.0.0.1]:35234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLb3m-0006R7-UY for submit@debbugs.gnu.org; Sun, 01 Jun 2025 01:16:46 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39540) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLb3g-0006PN-1T for submit@debbugs.gnu.org; Sun, 01 Jun 2025 01:16:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLb3Z-0002vK-A3 for bug-gnu-emacs@gnu.org; Sun, 01 Jun 2025 01:16:25 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uLb3U-0004Ti-0b for bug-gnu-emacs@gnu.org; Sun, 01 Jun 2025 01:16:25 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-742c7a52e97so2694341b3a.3 for ; Sat, 31 May 2025 22:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748754977; x=1749359777; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=1Knva0tKp0+TrwnMqt5rd5LgVRS0gyDUg3NDEeuiuq8=; b=jAaSw/oRSLxDjz+r8TwXX2LY9tCeLZ9AAzOqk6ZPuCBkA/2YmYe8PyDW08q9HRpjCb /fsKN1wOhNysJRi0rU2RXAZJxSWSaoV58U2+TAsN43SbrgUgT8XlZXR1eVRumov5cDP5 O+Qa3TuZpJH6t5mNCXfwvF9Jg1IbPVaPv8lb9cBDrxNt4OpIfMyzow16SQF2vq1vwf+W ncvyb5uPF6PBFqrJVCyVTbUmjlxUd6wGghWhilDP6enI37tvwwSJcTgVesn4kf6JJjjx GQsBY7O/tYyD0BegVnmj7z57zyl3CCQ4T+DB8XG0NRIb6LUtINY1Wr4MhQx2ocYPUchM AMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748754977; x=1749359777; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Knva0tKp0+TrwnMqt5rd5LgVRS0gyDUg3NDEeuiuq8=; b=MWdV9xmuyzwaw0QO+Z5BVbrO/0BjsuapxrLuIWNqrcySgnC840/L7N1sWh7IH5s568 NxJUzf+gTtWOQirrSgxoMrop1uPHqpJnlTIWEaL7XwnQFpmzVYjDGzcU5lTooINEfElx qD9hP0HxBsPdWzB5iakfxvh/S5vodvGbnBB3mLmDN7v7c98J6U5ukpRqlrW6r4HoBa1v U9U0isBHIWH6yM676s50R57KEV9JZhSWXz2W1v7zr3ZeoW7oWmeW4iobLqd8xx0FlCmr hGvV3kXUCLwxDyAzEu7siy/SZSPvOFQ193gvdJoGuvoHTSbr3IHe6X8BUrOEuh6M3CBY ztlw== X-Gm-Message-State: AOJu0Yyn6a1/YSJAz7KVwAmd4M7bD/L2p2XNc9wXS0sOpcbCOahowJ1m sXmQkF8lYQNx4nvWnvCTnmgzrAL9cGYUx88zWE641dovjQ8/jo/v7eGzsIPXYw== X-Gm-Gg: ASbGncvrMoqxGZnJQrU72o2poniQUDPaAFJrC416t3hJ3pCX4ovjxoO6ihVOkeVDURp Z/kxb4QasSjHi8Q8YNXG6u+ZSWtYONG86KPWUeHtSL/9mX0TRoc+0Rx2CVxWiurrmNy71wkAHUW CtbMlnX1mJL+oVXsi9d7K6j+8wxGvB18lb/4oKxS8CGMF5x3qRqd6jaLUkaBGsPQMMA9b4ckoUI 4zV4yzGd3w5LGrDQ/P86oTnIcYB4V9HLOnslAeA4FF4aZRqv9zxz1igX5mmTBaxsIyFA5CE7/6y Wt+VcL/3jSH84U/6aISpOJpzVpa2Lzil X-Google-Smtp-Source: AGHT+IFZr2cFnuXkCaGmu3Q3srI2mUyE7BraxnJChdrGYVa3C6tqZzZr7AiTUEzFgAjA2tuSRQxm9g== X-Received: by 2002:a05:6a20:144f:b0:215:dc32:ffac with SMTP id adf61e73a8af0-21ae00836eamr10963849637.26.1748754977173; Sat, 31 May 2025 22:16:17 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::eef5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747afe96451sm5610842b3a.13.2025.05.31.22.16.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 May 2025 22:16:16 -0700 (PDT) From: Collin Funk To: bug-gnu-emacs@gnu.org Subject: [PATCH] Pacify Clang's -Wformat-signedness. Date: Sat, 31 May 2025 22:16:15 -0700 Message-ID: <874ix059eo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=collin.funk1@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, When compiling with './autogen.sh && ./configure CC=clang && make': [...] xfns.c:2041:6: warning: format specifies type 'unsigned int' but the argument has type 'int' [-Wformat] 2040 | sprintf (css, "scrollbar slider { background-color: #%02x%02x%02x; }", | ~~~~ | %0 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (collin.funk1[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (collin.funk1[at]gmail.com) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain Hi, When compiling with './autogen.sh && ./configure CC=clang && make': [...] xfns.c:2041:6: warning: format specifies type 'unsigned int' but the argument has type 'int' [-Wformat] 2040 | sprintf (css, "scrollbar slider { background-color: #%02x%02x%02x; }", | ~~~~ | %02x 2041 | color.red >> 8, color.green >> 8, color.blue >> 8); [...] This warning is harmless, but interestingly 'gcc -Wformat-signedness' does not warn about it, but 'clang -Wformat-signedness' does. Since the color fields of struct XColor are 'unsigned short' and the constant is an 'int', the expression should be an 'int'. Anyways, the attached patch silences the warnings. Collin --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Pacify-Clang-s-Wformat-signedness.patch >From 1c34ded32a2826d009ee531c1f0d695b8144b39d Mon Sep 17 00:00:00 2001 Message-ID: <1c34ded32a2826d009ee531c1f0d695b8144b39d.1748754583.git.collin.funk1@gmail.com> From: Collin Funk Date: Sat, 31 May 2025 21:54:54 -0700 Subject: [PATCH] Pacify Clang's -Wformat-signedness. * src/gtkutil.c (xg_set_widget_bg): Cast the expression passed to the "%x" specifier to unsigned int. * src/xfns.c (x_set_scroll_bar_foreground, x_set_scroll_bar_background): Likewise. --- src/gtkutil.c | 3 ++- src/xfns.c | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gtkutil.c b/src/gtkutil.c index c192102730c..c8b0943fb2f 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -1434,7 +1434,8 @@ xg_set_widget_bg (struct frame *f, GtkWidget *w, unsigned long pixel) { static char const format[] = "* { background-color: #%02x%02x%02x; }"; char buffer[sizeof format + 3 * INT_STRLEN_BOUND (xbg.red)]; - sprintf (buffer, format, xbg.red >> 8, xbg.green >> 8, xbg.blue >> 8); + sprintf (buffer, format, (unsigned int) xbg.red >> 8, + (unsigned int) xbg.green >> 8, (unsigned int) xbg.blue >> 8); GtkCssProvider *provider = gtk_css_provider_new (); gtk_css_provider_load_from_data (provider, buffer, -1, NULL); gtk_style_context_add_provider (gtk_widget_get_style_context(w), diff --git a/src/xfns.c b/src/xfns.c index 4f7be935000..5f0cb0e16a9 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -2038,7 +2038,9 @@ x_set_scroll_bar_foreground (struct frame *f, Lisp_Object value, Lisp_Object old &color); sprintf (css, "scrollbar slider { background-color: #%02x%02x%02x; }", - color.red >> 8, color.green >> 8, color.blue >> 8); + (unsigned int) color.red >> 8, + (unsigned int) color.green >> 8, + (unsigned int) color.blue >> 8); gtk_css_provider_load_from_data (FRAME_X_OUTPUT (f)->scrollbar_foreground_css_provider, css, -1, NULL); } @@ -2111,7 +2113,9 @@ x_set_scroll_bar_background (struct frame *f, Lisp_Object value, Lisp_Object old &color); sprintf (css, "scrollbar trough { background-color: #%02x%02x%02x; }", - color.red >> 8, color.green >> 8, color.blue >> 8); + (unsigned int) color.red >> 8, + (unsigned int) color.green >> 8, + (unsigned int) color.blue >> 8); gtk_css_provider_load_from_data (FRAME_X_OUTPUT (f)->scrollbar_background_css_provider, css, -1, NULL); } -- 2.49.0 --=-=-=-- ------------=_1748849282-15299-1-- From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jun 2025 07:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 78659@debbugs.gnu.org, collin.funk1@gmail.com Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.174885075022402 (code B ref 78659); Mon, 02 Jun 2025 07:53:01 +0000 Received: (at 78659) by debbugs.gnu.org; 2 Jun 2025 07:52:30 +0000 Received: from localhost ([127.0.0.1]:47364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLzy9-0005pE-Ib for submit@debbugs.gnu.org; Mon, 02 Jun 2025 03:52:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33430) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLzy6-0005ok-Ns for 78659@debbugs.gnu.org; Mon, 02 Jun 2025 03:52:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLzy0-0006SX-0Y; Mon, 02 Jun 2025 03:52:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Y/fJbnoJUVeLWC7uxOUAzaaihQZ+FgV96eORYYzv3Rw=; b=Fymy9NrL8j0v Vu7UhUsSIQ8fC2QecUi0nL5eyhkEHgqpEKE3AgoRglXyT1cWFw/jcly+qH5xpWEe2jShXbUwP2wiO guqRoqwmXZQn4zf0u4EK+D9irlYgsFcIW2qrhk48MogWzGpMyaiSt3/rUS1R0H1R3kz9CFQSfuCwm H0AMNq+c3nZljtGe29c8pMGO5Qgylkgrsd0ZPDS5/1RUh49KadONhbkuh+h3JtIVK4hSSZ26Nd2T7 skSjmnzl7Mz7EsgyLcDdo8S5t7V7Ql6av9mK2aPmu9faw7PH7MERwA9u/RqSYSqSyX+bxefZCNO8O JUMwELIv+OBlIIKSrS4OfA==; Date: Mon, 02 Jun 2025 10:52:14 +0300 Message-Id: <86frgipolt.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Paul Eggert on Mon, 2 Jun 2025 00:26:30 -0700) References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> <867c1vrkbm.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 2 Jun 2025 00:26:30 -0700 > Cc: collin.funk1@gmail.com, 78659@debbugs.gnu.org > From: Paul Eggert > > On 2025-06-01 00:29, Eli Zaretskii wrote: > > I tend to agree, but isn't the latest GCC prone to bugs in this area? > > Not that I know of. I usually build with it. > > > And how can we know what is "recent GCC"? > > I suggest worrying only about the most recent stable GCC release. > Anything older than that is generally not worth worrying about, though > there may be some exceptions in extremely annoying circumstances. After > all, these warnings are meant only for developers who should be using > recent GCC anyway. OK, but the question of how to recognize that version still stand. Assuming we want to enable the warning automatically by some autoconf test, that is. From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jun 2025 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78659@debbugs.gnu.org, collin.funk1@gmail.com Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.17488887081728 (code B ref 78659); Mon, 02 Jun 2025 18:26:01 +0000 Received: (at 78659) by debbugs.gnu.org; 2 Jun 2025 18:25:08 +0000 Received: from localhost ([127.0.0.1]:54609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uM9qN-0000RO-Ly for submit@debbugs.gnu.org; Mon, 02 Jun 2025 14:25:07 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:55804) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uM9qK-0000OE-LJ for 78659@debbugs.gnu.org; Mon, 02 Jun 2025 14:25:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 7A1CA3C010860; Mon, 2 Jun 2025 11:24:58 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id G1poL7x3D5sk; Mon, 2 Jun 2025 11:24:58 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 519303C0149F2; Mon, 2 Jun 2025 11:24:58 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 519303C0149F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1748888698; bh=fnyQe7YkR4d0qCMSCRVXifLOnFmArNzrlDxOxELrsr8=; h=Message-ID:Date:MIME-Version:To:From; b=a/MEBRFKXDIZQjm4SAb0MytfQ1NHQp9L8YeVHZutrrax0IhOBRYGDbBef4eWca3y0 pd++GLmKluAMvElqh6L2OkY9W9QTadTE0IbxTKvrc6bH4tXOUtihrWTAmYrD39/hvh 79ftdqYkNrv0Y6d8fmZMx1brWvwiom+mqHp3ujkf7io4LI9nWAVp/5MKDn/xygWa+x 32Ymg4eNICsqezu7jlTcM+drhuBkodoFsC6nxL8hvDpjymUBmoS3Fm+c3qdul4+hWr qdfDNlRfFXAuDjeY72kFttHhVrVhpLp5JUJ1+15+9eEJ3O5n9nvLD87r7NyyZJ0waQ muQnqoBNVNGzw== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id Swp7wfBPBa1m; Mon, 2 Jun 2025 11:24:58 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-143-215-226.fdr01.snmn.ca.ip.frontiernet.net [47.143.215.226]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 324833C010860; Mon, 2 Jun 2025 11:24:58 -0700 (PDT) Message-ID: Date: Mon, 2 Jun 2025 11:24:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> <867c1vrkbm.fsf@gnu.org> <86frgipolt.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <86frgipolt.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-06-02 00:52, Eli Zaretskii wrote: > the question of how to recognize that version still stand. That version recognition is done by configure.ac; see its use of gl_GCC_VERSION_IFELSE. Currently the default is to enable warnings (but don't fail the build) with any version of Clang, or with GCC 5.3 or later. We could easily change the default to some other version. From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jun 2025 11:14:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 78659@debbugs.gnu.org, collin.funk1@gmail.com Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.174894922226431 (code B ref 78659); Tue, 03 Jun 2025 11:14:07 +0000 Received: (at 78659) by debbugs.gnu.org; 3 Jun 2025 11:13:42 +0000 Received: from localhost ([127.0.0.1]:60892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMPaQ-0006sE-9q for submit@debbugs.gnu.org; Tue, 03 Jun 2025 07:13:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46190) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMPaN-0006ry-F5 for 78659@debbugs.gnu.org; Tue, 03 Jun 2025 07:13:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMPaH-00044n-AF; Tue, 03 Jun 2025 07:13:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=T9X3SmX5c24YjKvIlAzuPkGoYzreLPUi2amFydYv4yg=; b=pMkOCFHJqHBp uTKLafL6bBmY8u/kIaxDS6mbuNppoUVQaObA5vFnGGBWNrvXYu6kXlhhOWuo37XFcMnm+PC8qBgaP fcA52hFqntvsirpupUZ1vG9FPOFmFYpuuggbMcJvMNc/mm+Lif4dRY26WxXLHiBcnynbwMYJF+JcW /0HCe0PF56FCkpi5koRdJbUODgzDopRG4XZRtbuF+El6RA5l8F7LqD3+WmxSfGXDk+4qlG68AjTDf MTK8dXv7hsz4v+w9/tyH+1usR3wtDLn9qLvDvuisopy+NrIgjPddm5IYFA81OCNknJNruwiAYOv2n 5ZJCxyJ6y6Y62zngl3uEDg==; Date: Tue, 03 Jun 2025 14:13:30 +0300 Message-Id: <86wm9tnkmd.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Paul Eggert on Mon, 2 Jun 2025 11:24:57 -0700) References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> <867c1vrkbm.fsf@gnu.org> <86frgipolt.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 2 Jun 2025 11:24:57 -0700 > Cc: collin.funk1@gmail.com, 78659@debbugs.gnu.org > From: Paul Eggert > > On 2025-06-02 00:52, Eli Zaretskii wrote: > > the question of how to recognize that version still stand. > > That version recognition is done by configure.ac; see its use of > gl_GCC_VERSION_IFELSE. Currently the default is to enable warnings (but > don't fail the build) with any version of Clang, or with GCC 5.3 or > later. We could easily change the default to some other version. I see. Should we perhaps have some procedure in place to update the cutoff version? Like in make-tarball.txt, perhaps (since releasing a new version might be a good time to consider updating this)? From unknown Sun Jun 15 08:57:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78659: [PATCH] Pacify Clang's -Wformat-signedness. Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jun 2025 06:06:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 78659@debbugs.gnu.org, collin.funk1@gmail.com Received: via spool by 78659-submit@debbugs.gnu.org id=B78659.17490171495515 (code B ref 78659); Wed, 04 Jun 2025 06:06:03 +0000 Received: (at 78659) by debbugs.gnu.org; 4 Jun 2025 06:05:49 +0000 Received: from localhost ([127.0.0.1]:45922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMhFz-0001Qb-8i for submit@debbugs.gnu.org; Wed, 04 Jun 2025 02:05:48 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:35824) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMhFw-0001PL-6P for 78659@debbugs.gnu.org; Wed, 04 Jun 2025 02:05:45 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 491F33C01085D; Tue, 3 Jun 2025 23:05:38 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id k1FGa7vU2vXS; Tue, 3 Jun 2025 23:05:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 1E6983C010860; Tue, 3 Jun 2025 23:05:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 1E6983C010860 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1749017138; bh=efAZJnLPUrRKldO9EJXNqM9oMsQS7Ds8prhmar2d+5c=; h=Message-ID:Date:MIME-Version:To:From; b=Kzmcn3YielDN8flurYJD0nBqepRXeS8Fl2gEzzaHB2Cc8ZInuEnvM/AIfL11k3d60 c3q35uAYmPojXRM/sKqyEszZpq8npNDfcoA30BXch6g9HAGdbaw7hNYqhCaM2ME86S qvqKYmrqK6jqNcXQWTi2hLoUWupnhlqSIGpW+280LzcxKAhh54emWJydtEbEWZdE8N fJCGlOKOfnU+zyW2+rJyxRJ6H51kXbUELnrfc/mxwhIfXCha7wdRdOzhNhMWjZ5UC/ nVC+4bwp0XFryZPTdXTm5OZKTNKm85Jo+1fHL23a1QSuYL2dZukdbW7u+mwKZ4Ppod Am9Jz1FM1IoJg== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id yWpLMGB30h4S; Tue, 3 Jun 2025 23:05:38 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-143-215-226.fdr01.snmn.ca.ip.frontiernet.net [47.143.215.226]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 0166C3C01085D; Tue, 3 Jun 2025 23:05:37 -0700 (PDT) Message-ID: <328b698a-a5aa-40cf-ba31-4112e70f06eb@cs.ucla.edu> Date: Tue, 3 Jun 2025 23:05:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <874ix059eo.fsf@gmail.com> <868qmcq8s8.fsf@gnu.org> <6c6ca592-2d15-4986-840f-851935486191@cs.ucla.edu> <867c1vrkbm.fsf@gnu.org> <86frgipolt.fsf@gnu.org> <86wm9tnkmd.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <86wm9tnkmd.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-06-03 04:13, Eli Zaretskii wrote: > I see. Should we perhaps have some procedure in place to update the > cutoff version? Like in make-tarball.txt, perhaps Wouldn't hurt to add it to a checklist somewhere, I suppose. But since this a developer thing, not a user thing, we can change the cutoff any time; it doesn't need to be associated with a release. It's more likely we'd change the cutoff due to a change in Emacs's bleeding-edge code, than due to a release.