GNU bug report logs - #78654
NS Emacs crashing (since stipples?)

Previous Next

Package: emacs;

Reported by: Ship Mints <shipmints <at> gmail.com>

Date: Sat, 31 May 2025 21:47:01 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #28 received at 78654-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stéphane Marks <shipmints <at> gmail.com>
Cc: ben <at> bensimms.moe, 78654-done <at> debbugs.gnu.org
Subject: Re: bug#78654: NS Emacs crashing (since stipples?)
Date: Wed, 04 Jun 2025 19:58:18 +0300
> From: Stéphane Marks <shipmints <at> gmail.com>
> Date: Wed, 4 Jun 2025 12:34:24 -0400
> Cc: 78654 <at> debbugs.gnu.org, ben <at> bensimms.moe
> 
>  seems to have a thinko: it should say this instead:
> 
>            if (s->row->mouse_face_p
>                && cursor_in_mouse_face_p (s->w))
>              {
>                face = FACE_FROM_ID_OR_NULL (s->f,
>                                             MOUSE_HL_INFO (s->f)->mouse_face_face_id);
> 
>                if (!face)  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>                  face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
>                prepare_face_for_display (s->f, face);
> 
>  Can you try that change?
> 
>  Making a normal build now.  Will test today/tomorrow.
> 
>  So far, so good.  I'll give it more time before declaring success.  Thank you for the fast patch.
> 
> I have not seen this recur.  Would you prefer I submit a patch for this or would you handle this?

Thanks, I've now installed this on the master branch, and I'm closing
this bug.




This bug report was last modified 45 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.